[GitHub] [tomcat] martin-g commented on a change in pull request #361: Add a GitHub action to lint the Markdown and YAML files.
martin-g commented on a change in pull request #361: URL: https://github.com/apache/tomcat/pull/361#discussion_r487754324 ## File path: .github/workflows/lint.yml ## @@ -0,0 +1,18 @@ +name: Lint + +on: [push, pull_request] + +jobs: + lint: +name: 🧹 Markdown and YAML Lint +runs-on: ubuntu-latest +steps: + - uses: actions/checkout@v2 + - name: yaml-lint +uses: ibiqlik/action-yamllint@v1 + - name: Use Node.js +uses: actions/setup-node@v1 +with: + node-version: '12.x' + - run: npm install -g markdownlint-cli@0.23.2 + - run: markdownlint '**/*.md' --ignore node_modules Review comment: Is it possible to pass the config file as an argument ? The idea is to move `.markdownlint.yml` from the root folder to be next to `lint.yml`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on a change in pull request #361: Add a GitHub action to lint the Markdown and YAML files.
martin-g commented on a change in pull request #361: URL: https://github.com/apache/tomcat/pull/361#discussion_r487755893 ## File path: .github/workflows/lint.yml ## @@ -0,0 +1,18 @@ +name: Lint + +on: [push, pull_request] + +jobs: + lint: +name: 🧹 Markdown and YAML Lint +runs-on: ubuntu-latest +steps: + - uses: actions/checkout@v2 + - name: yaml-lint +uses: ibiqlik/action-yamllint@v1 Review comment: Please move `yamllint.yml` from the root folder to `.github/workflows/` and use [config_file](https://github.com/ibiqlik/action-yamllint#optional-parameters) to specify it. The idea is to not pollute the root folder with too many config files which are used for very specific needs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated (120bf9d -> c2b35b6)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 120bf9d Implement checkContainersAvailable flag add c2b35b6 Update to Commons Daemon 1.2.3 No new revisions were added by this update. Summary of changes: build.properties.default | 12 ++-- webapps/docs/changelog.xml | 11 +++ 2 files changed, 17 insertions(+), 6 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Update to Commons Daemon 1.2.3
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 379e862 Update to Commons Daemon 1.2.3
379e862 is described below
commit 379e8621705042270e6a0bbb6a7a780bdfe87027
Author: Mark Thomas
AuthorDate: Mon Sep 14 10:01:37 2020 +0100
Update to Commons Daemon 1.2.3
---
build.properties.default | 12 ++--
webapps/docs/changelog.xml | 11 +++
2 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/build.properties.default b/build.properties.default
index 0ea6651..2d65f9d 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -175,20 +175,20 @@
nsis.nsdialogs.dll=${nsis.home}/Plugins/${nsis.arch.dir}nsDialogs.dll
nsis.loc=${base-sf.loc}/nsis/nsis-${nsis.version}.zip
# - Commons Daemon, version 1.2.0 or later -
-commons-daemon.version=1.2.2
+commons-daemon.version=1.2.3
-# checksum for commons-daemon-1.2.1-bin.tar.gz
+# checksum for commons-daemon-1.2.3-bin.tar.gz
commons-daemon.bin.checksum.enabled=true
commons-daemon.bin.checksum.algorithm=SHA-512
-commons-daemon.bin.checksum.value=f9fb917aaf398f61c42796eb4168664e076f81bc3fae82790eb39c723f03a1e7cbc2304161938d8d8993b7fbb718214b94740dbf9679f6ef93e85b5a2e861761
+commons-daemon.bin.checksum.value=0d7ced8f5d6fd3e8781146ee47c37046c6ccd2f364138f89d137eea5f0255e1b2afae5faf7005164c077087cb08203fd44478d5c14c57c7df449feb324443447
-# checksums for commons-daemon-1.2.1-native-src.tar.gz,
commons-daemon-1.2.1-bin-windows.zip
+# checksums for commons-daemon-1.2.3-native-src.tar.gz,
commons-daemon-1.2.3-bin-windows.zip
commons-daemon.native.src.checksum.enabled=true
commons-daemon.native.src.checksum.algorithm=SHA-512
-commons-daemon.native.src.checksum.value=45ad856a8a6b024e80905cfac5a741a57ab86479ecd65adab9641f5444d3a2362bb13d1ea38ec3db5eb89d30c29f2f6d3b0e48cbf2f60c081c4df2451acd1ab4
+commons-daemon.native.src.checksum.value=5f223ee3c133f673fe698f575d7cfb15f27fbbb8acf2e6db292e0e1690a20d636b35312187aa1091b315062f2434788eec9cde167e2ae1d7e673ebdd2ddb41f6
commons-daemon.native.win.checksum.enabled=true
commons-daemon.native.win.checksum.algorithm=SHA-512
-commons-daemon.native.win.checksum.value=16e7a6fc5bc83ada3bcf9e10cc69ef21400dc019d1f2be00caec0bce72c3bc5a7c72116878e12b4851a15bb473c0948a9c14e1a86b6addcefa6c20638dbcc88c
+commons-daemon.native.win.checksum.value=c79ee31a367addc5d49db474aabe084cebcd4f7f0f0f9ddc7999c02d4de5cd6ace6d5f55a230f399cfaaf780179b6f9808739efc7500b18c27cdb963daaef8d5
commons-daemon.home=${base.path}/commons-daemon-${commons-daemon.version}
commons-daemon.jar=${commons-daemon.home}/commons-daemon-${commons-daemon.version}.jar
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index fad0a39..5c3e83f 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -53,6 +53,17 @@
+
+
+
+Update to Commons Daemon 1.2.3. This adds support to jsvc for
+--enable-preview and native memory tracking (Procrun
+already supported these features), adds some addition debug logging and
+adds a new feature to Procrun that outputs the commnd to (re-)configure
+the service with the current settings. (markt)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Increment version ready for next dev cycle
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4e6e65d Increment version ready for next dev cycle 4e6e65d is described below commit 4e6e65da2f9b459b5f51131cde7b996390062964 Author: Mark Thomas AuthorDate: Mon Sep 14 10:06:06 2020 +0100 Increment version ready for next dev cycle --- build.properties.default | 2 +- res/maven/mvn.properties.default | 2 +- webapps/docs/changelog.xml | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/build.properties.default b/build.properties.default index 2ad68c1..0d70217 100644 --- a/build.properties.default +++ b/build.properties.default @@ -25,7 +25,7 @@ # - Version Control Flags - version.major=8 version.minor=5 -version.build=58 +version.build=59 version.patch=0 version.suffix=-dev diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default index 81fa393..e44bcff 100644 --- a/res/maven/mvn.properties.default +++ b/res/maven/mvn.properties.default @@ -39,7 +39,7 @@ maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d maven.asf.release.repo.repositoryId=apache.releases.https # Release version info -maven.asf.release.deploy.version=8.5.58 +maven.asf.release.deploy.version=8.5.59 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 600caa4..9ff40c3 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -44,7 +44,9 @@ They eventually become mixed with the numbered issues (i.e., numbered issues do not "pop up" wrt. others). --> - + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Update to Commons Daemon 1.2.3
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 211a2b0 Update to Commons Daemon 1.2.3
211a2b0 is described below
commit 211a2b049e04ccbe4d411b7a7eff65ffdeace27d
Author: Mark Thomas
AuthorDate: Mon Sep 14 10:01:37 2020 +0100
Update to Commons Daemon 1.2.3
---
build.properties.default | 12 ++--
webapps/docs/changelog.xml | 11 +++
2 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/build.properties.default b/build.properties.default
index 0d70217..e506f8e 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -179,20 +179,20 @@
nsis.nsdialogs.dll=${nsis.home}/Plugins/${nsis.arch.dir}nsDialogs.dll
nsis.loc=${base-sf.loc}/nsis/nsis-${nsis.version}.zip
# - Commons Daemon, version 1.2.0 or later -
-commons-daemon.version=1.2.2
+commons-daemon.version=1.2.3
-# checksum for commons-daemon-1.2.1-bin.tar.gz
+# checksum for commons-daemon-1.2.3-bin.tar.gz
commons-daemon.bin.checksum.enabled=true
commons-daemon.bin.checksum.algorithm=SHA-512
-commons-daemon.bin.checksum.value=f9fb917aaf398f61c42796eb4168664e076f81bc3fae82790eb39c723f03a1e7cbc2304161938d8d8993b7fbb718214b94740dbf9679f6ef93e85b5a2e861761
+commons-daemon.bin.checksum.value=0d7ced8f5d6fd3e8781146ee47c37046c6ccd2f364138f89d137eea5f0255e1b2afae5faf7005164c077087cb08203fd44478d5c14c57c7df449feb324443447
-# checksums for commons-daemon-1.2.1-native-src.tar.gz,
commons-daemon-1.2.1-bin-windows.zip
+# checksums for commons-daemon-1.2.3-native-src.tar.gz,
commons-daemon-1.2.3-bin-windows.zip
commons-daemon.native.src.checksum.enabled=true
commons-daemon.native.src.checksum.algorithm=SHA-512
-commons-daemon.native.src.checksum.value=45ad856a8a6b024e80905cfac5a741a57ab86479ecd65adab9641f5444d3a2362bb13d1ea38ec3db5eb89d30c29f2f6d3b0e48cbf2f60c081c4df2451acd1ab4
+commons-daemon.native.src.checksum.value=5f223ee3c133f673fe698f575d7cfb15f27fbbb8acf2e6db292e0e1690a20d636b35312187aa1091b315062f2434788eec9cde167e2ae1d7e673ebdd2ddb41f6
commons-daemon.native.win.checksum.enabled=true
commons-daemon.native.win.checksum.algorithm=SHA-512
-commons-daemon.native.win.checksum.value=16e7a6fc5bc83ada3bcf9e10cc69ef21400dc019d1f2be00caec0bce72c3bc5a7c72116878e12b4851a15bb473c0948a9c14e1a86b6addcefa6c20638dbcc88c
+commons-daemon.native.win.checksum.value=c79ee31a367addc5d49db474aabe084cebcd4f7f0f0f9ddc7999c02d4de5cd6ace6d5f55a230f399cfaaf780179b6f9808739efc7500b18c27cdb963daaef8d5
commons-daemon.home=${base.path}/commons-daemon-${commons-daemon.version}
commons-daemon.jar=${commons-daemon.home}/commons-daemon-${commons-daemon.version}.jar
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 9ff40c3..19cef68 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -45,6 +45,17 @@
issues do not "pop up" wrt. others).
-->
+
+
+
+Update to Commons Daemon 1.2.3. This adds support to jsvc for
+--enable-preview and native memory tracking (Procrun
+already supported these features), adds some addition debug logging and
+adds a new feature to Procrun that outputs the commnd to (re-)configure
+the service with the current settings. (markt)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Update to Commons Daemon 1.2.3
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new 6e27262 Update to Commons Daemon 1.2.3
6e27262 is described below
commit 6e27262bdf4bca6063aadfe7b49652bcee853d32
Author: Mark Thomas
AuthorDate: Mon Sep 14 10:01:37 2020 +0100
Update to Commons Daemon 1.2.3
---
build.properties.default | 12 ++--
webapps/docs/changelog.xml | 7 +++
2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/build.properties.default b/build.properties.default
index e51e92a..b549abe 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -211,20 +211,20 @@
nsis.nsdialogs.dll=${nsis.home}/Plugins/${nsis.arch.dir}nsDialogs.dll
nsis.loc=${base-sf.loc}/nsis/nsis-${nsis.version}.zip
# - Commons Daemon, version 1.2.0 or later -
-commons-daemon.version=1.2.2
+commons-daemon.version=1.2.3
-# checksum for commons-daemon-1.2.1-bin.tar.gz
+# checksum for commons-daemon-1.2.3-bin.tar.gz
commons-daemon.bin.checksum.enabled=true
commons-daemon.bin.checksum.algorithm=SHA-512
-commons-daemon.bin.checksum.value=f9fb917aaf398f61c42796eb4168664e076f81bc3fae82790eb39c723f03a1e7cbc2304161938d8d8993b7fbb718214b94740dbf9679f6ef93e85b5a2e861761
+commons-daemon.bin.checksum.value=0d7ced8f5d6fd3e8781146ee47c37046c6ccd2f364138f89d137eea5f0255e1b2afae5faf7005164c077087cb08203fd44478d5c14c57c7df449feb324443447
-# checksums for commons-daemon-1.2.1-native-src.tar.gz,
commons-daemon-1.2.1-bin-windows.zip
+# checksums for commons-daemon-1.2.3-native-src.tar.gz,
commons-daemon-1.2.3-bin-windows.zip
commons-daemon.native.src.checksum.enabled=true
commons-daemon.native.src.checksum.algorithm=SHA-512
-commons-daemon.native.src.checksum.value=45ad856a8a6b024e80905cfac5a741a57ab86479ecd65adab9641f5444d3a2362bb13d1ea38ec3db5eb89d30c29f2f6d3b0e48cbf2f60c081c4df2451acd1ab4
+commons-daemon.native.src.checksum.value=5f223ee3c133f673fe698f575d7cfb15f27fbbb8acf2e6db292e0e1690a20d636b35312187aa1091b315062f2434788eec9cde167e2ae1d7e673ebdd2ddb41f6
commons-daemon.native.win.checksum.enabled=true
commons-daemon.native.win.checksum.algorithm=SHA-512
-commons-daemon.native.win.checksum.value=16e7a6fc5bc83ada3bcf9e10cc69ef21400dc019d1f2be00caec0bce72c3bc5a7c72116878e12b4851a15bb473c0948a9c14e1a86b6addcefa6c20638dbcc88c
+commons-daemon.native.win.checksum.value=c79ee31a367addc5d49db474aabe084cebcd4f7f0f0f9ddc7999c02d4de5cd6ace6d5f55a230f399cfaaf780179b6f9808739efc7500b18c27cdb963daaef8d5
commons-daemon.home=${base.path}/commons-daemon-${commons-daemon.version}
commons-daemon.jar=${commons-daemon.home}/commons-daemon-${commons-daemon.version}.jar
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 41d0df4..15add9d 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -146,6 +146,13 @@
Update the internal fork of Apache Commons FileUpload to c25a4e3
(2020-08-26, 2.0-SNAPSHOT). Code clean-up and RFC 2231 support. (markt)
+
+Update to Commons Daemon 1.2.3. This adds support to jsvc for
+--enable-preview and native memory tracking (Procrun
+already supported these features), adds some addition debug logging and
+adds a new feature to Procrun that outputs the commnd to (re-)configure
+the service with the current settings. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] amanjain201 commented on pull request #332: Support sending the 100 continue response when the servlet reads the …
amanjain201 commented on pull request #332: URL: https://github.com/apache/tomcat/pull/332#issuecomment-691970309 Hi, which version of 9.0.x will this be available and by when ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on pull request #332: Support sending the 100 continue response when the servlet reads the …
martin-g commented on pull request #332: URL: https://github.com/apache/tomcat/pull/332#issuecomment-691976571 9.0.38 The vote is still running: https://markmail.org/message/qsvkf45gp2og5aok If there are no issues found then it will be released in the next few days. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] reliveyy opened a new pull request #363: Fix Chinese translation of word "war"
reliveyy opened a new pull request #363: URL: https://github.com/apache/tomcat/pull/363 This PR Fixes Chinese translation of word "war". The Chinese world "战争" means the real war not a web archive. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Plans for Servlet 5.1
On 12/09/2020 22:56, Filip Hanik wrote: > > > On 9/10/20, 01:17, "Mark Thomas" wrote: > > Hi all, > > It looks like at least one of the specs Tomcat implements, Servlets, is > going to have at least one release between Jakarta EE 9 / Servlet 5.0 / > Tomcat 10.0 and Jakarta EE 10/ Servlet 6.0 / Tomcat 10.1 > > The current plan is for Servlet 5.1 to add same site cookie > configuration and pick up any other low hanging fruit (mostly clean-up & > clarification) from the issues list. > > I'm currently trying to figure out what this means in terms of Tomcat > releases. It may be that other specs do something similar. If enough > specs do that, it may turn into a relatively quick Jakarta EE 10. > > My current thinking is treat such releases the way we used to treat > maintenance releases of the specs. That would mean updating Tomcat to > the 5.1 release once available but not change in major or minor version. > Another way of looking at it is that Tomcat 10.0.x will support the > latest released version of Servlet 5.x and Tomcat 10.1.x will support > the latest released version of Servlet 6.x. > > Sounds good. Should we go to 10.5 rather than 10.1? While the numbers don't > mean much, we haven't had anything but .0 and .5 in a fairly long time. The choice of version number of somewhat arbitrary. There were several iterations of numbering scheme before we settled on this one. For reference: https://tomcat.markmail.org/thread/fzty4ymric7waw2s https://tomcat.markmail.org/thread/isa6m53zv6rugebb 10.1.x vs 10.5.x wasn't explicitly discussed (that I can recall or can find). Historically (5.5.x and 8.5.x) we have used the x.5.y releases to indicate a major refactoring and discontinuing support for x.0.y releases. That is slightly different from what is proposed for 10.0.x and 10.1.x. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.0.0-M8
On Wed, Sep 9, 2020 at 10:57 AM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0-M8 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > Applications that run on Tomcat 9 will not run on Tomcat 10 without > changes. > > The notable changes compared to 10.0.0-M7 are: > > - For requests containing the Expect: 100-continue header, optional > support has been added to delay sending an intermediate 100 status > response until the servlet reads the request body, allowing the > servlet the opportunity to respond without asking for the request > body. Based on a pull request by malaysf. > > - Add support for a read idle timeout and a write idle timeout to the > WebSocket session via custom properties in the user properties > instance associated with the session. Based on a pull request by > sakshamverma. > > - Update the packaged version of the Tomcat Native Library to 1.2.25 > > Along with lots of other bug fixes and improvements. > > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat10/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.0-M8/ > The Maven staging repo is: > > https://repository.apache.org/content/repositories/orgapachetomcatrepo-1276/ > The tag is: > https://github.com/apache/tomcat/tree/10.0.0-M8 > b3f5e0d88336d81a61a767fc10ab06930c9587ee > > The proposed 10.0.0-M8 release is: > [ ] Broken - do not release > [x] Alpha - go ahead and release as 10.0.0-M8 > +1 > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 9.0.38
On Thu, Sep 10, 2020 at 5:03 AM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.38 release is now available for voting. > > The notable changes compared to the 9.0.37 release are: > > - For requests containing the Expect: 100-continue header, optional > support has been added to delay sending an intermediate 100 status > response until the servlet reads the request body, allowing the > servlet the opportunity to respond without asking for the request > body. Based on a pull request by malaysf. > > - Add support for a read idle timeout and a write idle timeout to the > WebSocket session via custom properties in the user properties > instance associated with the session. Based on a pull request by > sakshamverma. > > - Update the packaged version of the Tomcat Native Library to 1.2.25 > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.38/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1277/ > The tag is: > https://github.com/apache/tomcat/tree/9.0.38 > 48b6a87171e502cc0becbb4c96e2266de4e805e7 > > The proposed 9.0.38 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 9.0.38 > +1 > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 10.0.0-M8
> [x] Alpha - go ahead and release as 10.0.0-M8 +1 - Ray
Re: [VOTE] Release Apache Tomcat 9.0.38
> > [x] Stable - go ahead and release as 9.0.38 > +1 - Ray
Re: [VOTE][RESULT] Release Apache Tomcat 10.0.0-M8
The following votes were cast: Binding: +1: markt, remm, kfujino, mgrigorov, fhanik, csutherl Non-binding: +1: Raymond Auge The vote therefore passes. Thanks to everyone who contributed to this release. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r41448 - /dev/tomcat/tomcat-10/v10.0.0-M8/ /release/tomcat/tomcat-10/v10.0.0-M8/
Author: markt Date: Mon Sep 14 18:37:56 2020 New Revision: 41448 Log: Release Apache Tomcat 10.0.0-M8 Added: release/tomcat/tomcat-10/v10.0.0-M8/ - copied from r41447, dev/tomcat/tomcat-10/v10.0.0-M8/ Removed: dev/tomcat/tomcat-10/v10.0.0-M8/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/02: Don't send an HTTP/2 ping when the connection is known to be closing
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 58c072aecbe99a4025308f9e2e6be2b6cf0866ff
Author: Mark Thomas
AuthorDate: Mon Sep 14 18:47:17 2020 +0100
Don't send an HTTP/2 ping when the connection is known to be closing
---
java/org/apache/coyote/http2/Http2UpgradeHandler.java | 13 +++--
webapps/docs/changelog.xml| 8
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
index b4b6fda..0d72451 100644
--- a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
@@ -316,10 +316,15 @@ class Http2UpgradeHandler extends AbstractStream
implements InternalHttpUpgradeH
SocketState result = SocketState.CLOSED;
try {
-pingManager.sendPing(false);
-
switch(status) {
case OPEN_READ:
+synchronized (socketWrapper) {
+if (!socketWrapper.canWrite()) {
+// Only send a ping if there is no other data waiting
to be sent.
+// Ping manager will ensure they aren't sent too
frequently.
+pingManager.sendPing(false);
+}
+}
try {
// There is data to read so use the read timeout while
// reading frames ...
@@ -827,6 +832,10 @@ class Http2UpgradeHandler extends AbstractStream
implements InternalHttpUpgradeH
synchronized (socketWrapper) {
if (socketWrapper.flush(false)) {
socketWrapper.registerWriteInterest();
+} else {
+// Only send a ping if there is no other data waiting to be
sent.
+// Ping manager will ensure they aren't sent too frequently.
+pingManager.sendPing(false);
}
}
}
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 895fa31..b840206 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -53,6 +53,14 @@
+
+
+
+Do not send an HTTP/2 PING frame to measure round-trip time when it is
+known that the HTTP/2 connection is not in a good state. (markt)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated (c2b35b6 -> 83a03b4)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from c2b35b6 Update to Commons Daemon 1.2.3 new 58c072a Don't send an HTTP/2 ping when the connection is known to be closing new 83a03b4 Use UPGRADED to ensure timeouts are processed The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: java/org/apache/coyote/AbstractProtocol.java | 2 +- java/org/apache/coyote/http2/Http2UpgradeHandler.java | 13 +++-- webapps/docs/changelog.xml| 11 +++ 3 files changed, 23 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 02/02: Use UPGRADED to ensure timeouts are processed
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 83a03b434cb8d9b561656cd1dfaf2f91a0bf79cc
Author: Mark Thomas
AuthorDate: Mon Sep 14 18:48:13 2020 +0100
Use UPGRADED to ensure timeouts are processed
---
java/org/apache/coyote/AbstractProtocol.java | 2 +-
webapps/docs/changelog.xml | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/java/org/apache/coyote/AbstractProtocol.java
b/java/org/apache/coyote/AbstractProtocol.java
index 248a26b..e214f80 100644
--- a/java/org/apache/coyote/AbstractProtocol.java
+++ b/java/org/apache/coyote/AbstractProtocol.java
@@ -901,7 +901,7 @@ public abstract class AbstractProtocol implements
ProtocolHandler,
if (httpUpgradeHandler instanceof
InternalHttpUpgradeHandler) {
if (((InternalHttpUpgradeHandler)
httpUpgradeHandler).hasAsyncIO()) {
// The handler will initiate all further
I/O
-state = SocketState.LONG;
+state = SocketState.UPGRADED;
}
}
}
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index b840206..e10a44d 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -59,6 +59,9 @@
Do not send an HTTP/2 PING frame to measure round-trip time when it is
known that the HTTP/2 connection is not in a good state. (markt)
+
+Ensure HTTP/2 timeouts are processed for idle connections. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Deprecated JDBCRealm
All, I'd like to proposed the following: - Deprecated the JDBCRealm in 7.0.x, 8.5.x and 9.0.x - Remove the JDBCRealm in 10.0.x The reasons for this are: - The JDBCRealm is single threaded - The DataSourceRealm is a better solution Thoughts? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Deprecated JDBCRealm
Easy choice. +1 On Mon, Sep 14, 2020 at 11:53 Mark Thomas wrote: > All, > > > > I'd like to proposed the following: > > - Deprecated the JDBCRealm in 7.0.x, 8.5.x and 9.0.x > > - Remove the JDBCRealm in 10.0.x > > > > The reasons for this are: > > - The JDBCRealm is single threaded > > - The DataSourceRealm is a better solution > > > > Thoughts? > > > > Mark > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > >
Re: Deprecated JDBCRealm
Am 14. September 2020 20:53:15 MESZ schrieb Mark Thomas : >All, > >I'd like to proposed the following: >- Deprecated the JDBCRealm in 7.0.x, 8.5.x and 9.0.x >- Remove the JDBCRealm in 10.0.x > >The reasons for this are: >- The JDBCRealm is single threaded >- The DataSourceRealm is a better solution > >Thoughts? Good idea Felix > >Mark > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
