[GitHub] [tomcat] markt-asf commented on a change in pull request #322: fix module names to reflect Java EE origin
markt-asf commented on a change in pull request #322:
URL: https://github.com/apache/tomcat/pull/322#discussion_r455000264
##
File path: res/bnd/tomcat-embed-core.jar.tmp.bnd
##
@@ -131,15 +131,15 @@ Provide-Capability: \
access=32;\
version=${Bundle-Version};\
modules='\
-jakarta.ejb-api,\
-jakarta.mail,\
-jakarta.persistence-api,\
-jakarta.xml.rpc-api,\
-java.xml.ws'
+javax.ejb.api,\
+javax.mail,\
+javax.persistence.api,\
+javax.xml.rpc.api,\
+javax.xml.ws.api'
-jpms-module-info-options: \
${module.name};substitute=tomcat-embed-core,\
-jakarta.ejb-api;static=true,\
-jakarta.mail;static=true,\
-jakarta.persistence-api;static=true,\
-jakarta.xml.rpc-api;static=true,\
-java.xml.ws;static=true
+javax.ejb.api;static=true,\
+javax.mail;static=true,\
+javax.persistence.api;static=true,\
+javax.xml.rpc.api;static=true,\
+javax.xml.ws.api;static=true
Review comment:
This looks to have a module name of `javax.xml.ws` in Java EE 8
##
File path: res/bnd/catalina.jar.tmp.bnd
##
@@ -55,15 +55,15 @@ Export-Package: \
access=32;\
version=${Bundle-Version};\
modules='\
-jakarta.ejb-api,\
-jakarta.mail,\
-jakarta.persistence-api,\
-jakarta.xml.rpc-api,\
+javax.ejb.api,\
+javax.mail,\
Review comment:
I think you need another `.api` here. Java EE 8 doesn't define a module
name and Jakarta EE uses `jakarta.mail.api` so I think it is reasonable to use
`javax.mail.api` here. The bundle sumbolic name is `javax.mail-api`
##
File path: res/bnd/tomcat-embed-core.jar.tmp.bnd
##
@@ -131,15 +131,15 @@ Provide-Capability: \
access=32;\
version=${Bundle-Version};\
modules='\
-jakarta.ejb-api,\
-jakarta.mail,\
-jakarta.persistence-api,\
-jakarta.xml.rpc-api,\
-java.xml.ws'
+javax.ejb.api,\
+javax.mail,\
+javax.persistence.api,\
+javax.xml.rpc.api,\
+javax.xml.ws.api'
-jpms-module-info-options: \
${module.name};substitute=tomcat-embed-core,\
-jakarta.ejb-api;static=true,\
-jakarta.mail;static=true,\
-jakarta.persistence-api;static=true,\
-jakarta.xml.rpc-api;static=true,\
-java.xml.ws;static=true
+javax.ejb.api;static=true,\
+javax.mail;static=true,\
+javax.persistence.api;static=true,\
Review comment:
This looks to have a module name of `java.persistence` in Java EE 8
##
File path: res/bnd/annotations-api.jar.tmp.bnd
##
@@ -35,9 +35,9 @@ Provide-Capability: \
Specification-Version=1.3
-jpms-module-info: \
-jakarta.annotation;\
+javax.annotation.api;\
access=32;\
version=${annotation.spec.version}
-jpms-module-info-options: \
-jakarta.annotation;\
+javax.annotation.api;\
Review comment:
The Java EE 8 JAR uses `java.annotation` as the module name
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on a change in pull request #322: fix module names to reflect Java EE origin
rotty3000 commented on a change in pull request #322:
URL: https://github.com/apache/tomcat/pull/322#discussion_r455085770
##
File path: res/bnd/catalina.jar.tmp.bnd
##
@@ -55,15 +55,15 @@ Export-Package: \
access=32;\
version=${Bundle-Version};\
modules='\
-jakarta.ejb-api,\
-jakarta.mail,\
-jakarta.persistence-api,\
-jakarta.xml.rpc-api,\
+javax.ejb.api,\
+javax.mail,\
Review comment:
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on a change in pull request #322: fix module names to reflect Java EE origin
rotty3000 commented on a change in pull request #322:
URL: https://github.com/apache/tomcat/pull/322#discussion_r455085850
##
File path: res/bnd/tomcat-embed-core.jar.tmp.bnd
##
@@ -131,15 +131,15 @@ Provide-Capability: \
access=32;\
version=${Bundle-Version};\
modules='\
-jakarta.ejb-api,\
-jakarta.mail,\
-jakarta.persistence-api,\
-jakarta.xml.rpc-api,\
-java.xml.ws'
+javax.ejb.api,\
+javax.mail,\
+javax.persistence.api,\
+javax.xml.rpc.api,\
+javax.xml.ws.api'
-jpms-module-info-options: \
${module.name};substitute=tomcat-embed-core,\
-jakarta.ejb-api;static=true,\
-jakarta.mail;static=true,\
-jakarta.persistence-api;static=true,\
-jakarta.xml.rpc-api;static=true,\
-java.xml.ws;static=true
+javax.ejb.api;static=true,\
+javax.mail;static=true,\
+javax.persistence.api;static=true,\
+javax.xml.rpc.api;static=true,\
+javax.xml.ws.api;static=true
Review comment:
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on a change in pull request #322: fix module names to reflect Java EE origin
rotty3000 commented on a change in pull request #322:
URL: https://github.com/apache/tomcat/pull/322#discussion_r455086114
##
File path: res/bnd/annotations-api.jar.tmp.bnd
##
@@ -35,9 +35,9 @@ Provide-Capability: \
Specification-Version=1.3
-jpms-module-info: \
-jakarta.annotation;\
+javax.annotation.api;\
access=32;\
version=${annotation.spec.version}
-jpms-module-info-options: \
-jakarta.annotation;\
+javax.annotation.api;\
Review comment:
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on a change in pull request #322: fix module names to reflect Java EE origin
rotty3000 commented on a change in pull request #322:
URL: https://github.com/apache/tomcat/pull/322#discussion_r455086401
##
File path: res/bnd/tomcat-embed-core.jar.tmp.bnd
##
@@ -131,15 +131,15 @@ Provide-Capability: \
access=32;\
version=${Bundle-Version};\
modules='\
-jakarta.ejb-api,\
-jakarta.mail,\
-jakarta.persistence-api,\
-jakarta.xml.rpc-api,\
-java.xml.ws'
+javax.ejb.api,\
+javax.mail,\
+javax.persistence.api,\
+javax.xml.rpc.api,\
+javax.xml.ws.api'
-jpms-module-info-options: \
${module.name};substitute=tomcat-embed-core,\
-jakarta.ejb-api;static=true,\
-jakarta.mail;static=true,\
-jakarta.persistence-api;static=true,\
-jakarta.xml.rpc-api;static=true,\
-java.xml.ws;static=true
+javax.ejb.api;static=true,\
+javax.mail;static=true,\
+javax.persistence.api;static=true,\
Review comment:
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 opened a new pull request #323: fix module names to reflect Jakarta EE origin
rotty3000 opened a new pull request #323: URL: https://github.com/apache/tomcat/pull/323 Signed-off-by: Raymond Augé This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #323: fix module names to reflect Jakarta EE origin
rotty3000 commented on pull request #323: URL: https://github.com/apache/tomcat/pull/323#issuecomment-658814002 @markt-asf note there are distinct differences with this PR as I'm trying to follow the request you made in the Jakarta mailing list to use .api consistently. Also, in catalina, I was not sure about persistence name. Would it retain the `java.persistence` or follow the new jakarta "_convention_"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[CONF] Apache Tomcat > Jakarta EE TCKs
Title: Message Title There's 1 new edit on this page Jakarta EE TCKs Mark Thomas edited this page Here's what changed: ... JSP TCK (2.3 & 3.0) Servlet TCK 4.0 Servlet TCK 5.0 WebSocket 1.1 TCK WebSocket 2.0 TCK Other TCKs to follow Go to page history View page Stop watching space • Manage notifications This message was sent by Atlassian Confluence 7.5.0
[CONF] Apache Tomcat > WebSocket 2.0 TCK
Title: Message Title There's 1 new edit on this page WebSocket 2.0 TCK Mark Thomas edited this page Here's what changed: ... A default 10.0.x build (as of 2020-0507-1315) running with the nightly local TCK build (as of 2020-0507-1315) triggers 10 1 test failures: The PRs have been applied. This TCK needs to be re-run to confirm the fixes. 2 unclear specification 2 x URI https://github.com/eclipse-ee4j/websocket-api/issues/228 PR to exclude https://github.com/eclipse-ee4j/jakartaee-tck/pull/263 3 faulty testsfailure: 1 faulty test 1 x signature teststest PR to update signatures in TCK https://github.com/eclipse-ee4j/jakartaee-tck/pull/2562 x faulty timeout tests https://github.com/eclipse-ee4j/jakartaee-tck/issues/260 PR to fix the tests https://github.com/eclipse-ee4j/jakartaee-tck/pull/261TCK TBC 5 Tests 'fixed' by appropriate system property configuration (see above). ... Go to page history View page Stop watching space • Manage notifications This message was sent by Atlassian Confluence 7.5.0
[CONF] Apache Tomcat > WebSocket 2.0 TCK
Title: Message Title There's 1 new edit on this page WebSocket 2.0 TCK Mark Thomas edited this page Here's what changed: ... 1 x signature testPR to update signatures in TCK TBCTCK https://github.com/eclipse-ee4j/jakartaee-tck/pull/359 5 Tests 'fixed' by appropriate system property configuration (see above). ... Go to page history View page Stop watching space • Manage notifications This message was sent by Atlassian Confluence 7.5.0
