[Bug 63612] New: PooledConnection#connectUsingDriver, Thread.currentThread().getContextClassLoader() is null

2019-07-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=63612

Bug ID: 63612
   Summary: PooledConnection#connectUsingDriver,
Thread.currentThread().getContextClassLoader() is null
   Product: Tomcat Modules
   Version: unspecified
  Hardware: All
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: jdbc-pool
  Assignee: dev@tomcat.apache.org
  Reporter: clemens...@mysign.ch
  Target Milestone: ---

>From time to time we are facing the follwing exception (call stack):
...
Caused by: java.sql.SQLException: Unable to load class: org.mariadb.jdbc.Driver
from ClassLoader:http://java.net.URLClassLoader@4c873330;ClassLoader:null
at
org.apache.tomcat.jdbc.pool.PooledConnection.connectUsingDriver(PooledConnection.java:292)
at
org.apache.tomcat.jdbc.pool.PooledConnection.connect(PooledConnection.java:212)
at
org.apache.tomcat.jdbc.pool.ConnectionPool.createConnection(ConnectionPool.java:736)
at
org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:668)
at
org.apache.tomcat.jdbc.pool.ConnectionPool.getConnection(ConnectionPool.java:198)
at
org.apache.tomcat.jdbc.pool.DataSourceProxy.getConnection(DataSourceProxy.java:132)
at org.apache.torque.Torque.getConnection(Torque.java:924)
... 53 common frames omitted
Caused by: java.lang.ClassNotFoundException: Unable to load class:
org.mariadb.jdbc.Driver from
ClassLoader:http://java.net.URLClassLoader@4c873330;ClassLoader:null
at
org.apache.tomcat.jdbc.pool.ClassLoaderUtil.loadClass(ClassLoaderUtil.java:56)
at
org.apache.tomcat.jdbc.pool.PooledConnection.connectUsingDriver(PooledConnection.java:280)
... 59 common frames omitted
Caused by: java.lang.ClassNotFoundException: Classloader is null
at
org.apache.tomcat.jdbc.pool.ClassLoaderUtil.loadClass(ClassLoaderUtil.java:40)
... 60 common frames omitted

According to the code (in PooledConnection# connectUsingDriver)
Thread.currentThread().getContextClassLoader() returns null

Googling for " Thread.currentThread().getContextClassLoader() is null" the
common demoniator seems to be `getContextClassLoader can be null`. If this is
true there should be
a) a null-check in PooledConnection#connectUsingDriver
b) if null, then there should be a fallback-Classloader (the system class
laoder?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63612] PooledConnection#connectUsingDriver, Thread.currentThread().getContextClassLoader() is null

2019-07-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=63612

clemens...@mysign.ch changed:

   What|Removed |Added

   Severity|normal  |critical

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63612] PooledConnection#connectUsingDriver, Thread.currentThread().getContextClassLoader() is null

2019-07-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=63612

--- Comment #1 from clemens...@mysign.ch ---
Context:
Debian GNU/Linux 9 \n \l
java version 1.8.0_162
Tomcat 8.5.35

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63612] PooledConnection#connectUsingDriver, Thread.currentThread().getContextClassLoader() may be null

2019-07-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=63612

clemens...@mysign.ch changed:

   What|Removed |Added

Summary|PooledConnection#connectUsi |PooledConnection#connectUsi
   |ngDriver,   |ngDriver,
   |Thread.currentThread().getC |Thread.currentThread().getC
   |ontextClassLoader() is null |ontextClassLoader() may be
   ||null

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.96

2019-07-26 Thread Violeta Georgieva 
На ср, 24.07.2019 г. в 16:56 ч. Violeta Georgieva 
написа:
>
> The proposed Apache Tomcat 7.0.96 release is now available for voting.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat7/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.96/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1224/
> The git tag is:
> https://github.com/apache/tomcat/tree/7.0.96
> 5277b175db2e575022672856797240976ad23bcf
>
> The proposed 7.0.96 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.96 Stable

Regards,
Violeta

>

[tomcat] branch master updated: Read all the certificates from /var/run/secrets/kubernetes.io/serviceaccount/ca.crt and add them.

2019-07-26 Thread jfclere 
This is an automated email from the ASF dual-hosted git repository.

jfclere pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 7988d73  Read all the certificates from 
/var/run/secrets/kubernetes.io/serviceaccount/ca.crt and add them.
7988d73 is described below

commit 7988d7313c04080dc9989f003a3c480b4ff4234a
Author: Jean-Frederic Clere 
AuthorDate: Fri Jul 26 10:31:07 2019 +0200

Read all the certificates from 
/var/run/secrets/kubernetes.io/serviceaccount/ca.crt
and add them.
---
 .../tribes/membership/cloud/AbstractStreamProvider.java  | 12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git 
a/java/org/apache/catalina/tribes/membership/cloud/AbstractStreamProvider.java 
b/java/org/apache/catalina/tribes/membership/cloud/AbstractStreamProvider.java
index a3da2d7..1aa68bf 100644
--- 
a/java/org/apache/catalina/tribes/membership/cloud/AbstractStreamProvider.java
+++ 
b/java/org/apache/catalina/tribes/membership/cloud/AbstractStreamProvider.java
@@ -28,6 +28,8 @@ import java.security.KeyStore;
 import java.security.cert.CertificateException;
 import java.security.cert.CertificateFactory;
 import java.security.cert.X509Certificate;
+import java.util.Collection;
+import java.util.Iterator;
 import java.util.Map;
 
 import javax.net.ssl.HttpsURLConnection;
@@ -113,13 +115,17 @@ public abstract class AbstractStreamProvider implements 
StreamProvider {
 if (caCertFile != null) {
 try (InputStream pemInputStream = new BufferedInputStream(new 
FileInputStream(caCertFile))) {
 CertificateFactory certFactory = 
CertificateFactory.getInstance("X509");
-X509Certificate cert = 
(X509Certificate)certFactory.generateCertificate(pemInputStream);
 
 KeyStore trustStore = KeyStore.getInstance("JKS");
 trustStore.load(null);
 
-String alias = cert.getSubjectX500Principal().getName();
-trustStore.setCertificateEntry(alias, cert);
+Collection c = 
certFactory.generateCertificates(pemInputStream);
+Iterator i = c.iterator();
+while (i.hasNext()) {
+   X509Certificate cert = (X509Certificate)i.next();
+   String alias = cert.getSubjectX500Principal().getName();
+   trustStore.setCertificateEntry(alias, cert);
+}
 
 TrustManagerFactory trustManagerFactory = 
TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm());
 trustManagerFactory.init(trustStore);


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated (7988d73 -> 2250b8f)

2019-07-26 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git.


from 7988d73  Read all the certificates from 
/var/run/secrets/kubernetes.io/serviceaccount/ca.crt and add them.
 new 073a5bb  Add "embed" to the OSGi names.
 new 2250b8f  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63555 JPMS 
for embed

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 res/bnd/tomcat-dbcp.jar.tmp.bnd|  1 +
 res/bnd/tomcat-embed-core.jar.tmp.bnd  |  1 +
 res/bnd/tomcat-embed-el.jar.tmp.bnd|  1 +
 res/bnd/tomcat-embed-jasper.jar.tmp.bnd|  1 +
 res/bnd/tomcat-embed-websocket.jar.tmp.bnd |  5 +++--
 webapps/docs/changelog.xml | 12 
 6 files changed, 19 insertions(+), 2 deletions(-)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] 01/02: Add "embed" to the OSGi names.

2019-07-26 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 073a5bb296a78ed377840b3faa61338d9a81c316
Author: Mark Thomas 
AuthorDate: Fri Jul 26 13:59:42 2019 +0100

Add "embed" to the OSGi names.

Aligns with the other embed JARS and differentiates it from the standard
WebSocket JAR that does not include the API.
---
 res/bnd/tomcat-embed-websocket.jar.tmp.bnd | 4 ++--
 webapps/docs/changelog.xml | 7 +++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/res/bnd/tomcat-embed-websocket.jar.tmp.bnd 
b/res/bnd/tomcat-embed-websocket.jar.tmp.bnd
index 5c9b197..581152c 100644
--- a/res/bnd/tomcat-embed-websocket.jar.tmp.bnd
+++ b/res/bnd/tomcat-embed-websocket.jar.tmp.bnd
@@ -12,8 +12,8 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-Bundle-Name: tomcat-websocket
-Bundle-SymbolicName: org.apache.tomcat-websocket
+Bundle-Name: tomcat-embed-websocket
+Bundle-SymbolicName: org.apache.tomcat-embed-websocket
 Bundle-Version: @VERSION@
 Export-Package: \
 javax.websocket,\
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index d6f7fb1..5a3ca44 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -180,6 +180,13 @@
   
 Correct broken OSGi data in JAR file manifests. (markt)
   
+  
+Add "embed" to the Bundle-Name and
+Bundle-Symbolic-Name for the Tomact embedded WebSocket JAR
+to align the naming with the other embedded JARs and to differentiate 
it
+from the standard WebSocket JAR that does not include the API classes.
+(markt)
+  
 
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] 02/02: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63555 JPMS for embed

2019-07-26 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 2250b8f6ffbbc2deba62ad2b3bc766e7b78b6314
Author: Mark Thomas 
AuthorDate: Fri Jul 26 14:24:38 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63555 JPMS for embed

Add Automatic-Module-Name entries for each of the Tomcat provided JARs
included in the Tomcat embedded distribution.
---
 res/bnd/tomcat-dbcp.jar.tmp.bnd| 1 +
 res/bnd/tomcat-embed-core.jar.tmp.bnd  | 1 +
 res/bnd/tomcat-embed-el.jar.tmp.bnd| 1 +
 res/bnd/tomcat-embed-jasper.jar.tmp.bnd| 1 +
 res/bnd/tomcat-embed-websocket.jar.tmp.bnd | 1 +
 webapps/docs/changelog.xml | 5 +
 6 files changed, 10 insertions(+)

diff --git a/res/bnd/tomcat-dbcp.jar.tmp.bnd b/res/bnd/tomcat-dbcp.jar.tmp.bnd
index 9296416..f7d2b14 100644
--- a/res/bnd/tomcat-dbcp.jar.tmp.bnd
+++ b/res/bnd/tomcat-dbcp.jar.tmp.bnd
@@ -12,6 +12,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+Automatic-Module-Name: org.apache.tomcat-dbcp
 Bundle-Name: tomcat-dbcp
 Bundle-SymbolicName: org.apache.tomcat-dbcp
 Bundle-Version: @VERSION@
diff --git a/res/bnd/tomcat-embed-core.jar.tmp.bnd 
b/res/bnd/tomcat-embed-core.jar.tmp.bnd
index c3e4d5b..301c4bb 100644
--- a/res/bnd/tomcat-embed-core.jar.tmp.bnd
+++ b/res/bnd/tomcat-embed-core.jar.tmp.bnd
@@ -12,6 +12,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+Automatic-Module-Name: org.apache.tomcat-embed-core
 Bundle-Name: tomcat-embed-core
 Bundle-SymbolicName: org.apache.tomcat-embed-core
 Bundle-Version: @VERSION@
diff --git a/res/bnd/tomcat-embed-el.jar.tmp.bnd 
b/res/bnd/tomcat-embed-el.jar.tmp.bnd
index b6a72d5..06c09fb 100644
--- a/res/bnd/tomcat-embed-el.jar.tmp.bnd
+++ b/res/bnd/tomcat-embed-el.jar.tmp.bnd
@@ -12,6 +12,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+Automatic-Module-Name: org.apache.tomcat-embed-jasper-el
 Bundle-Name: tomcat-embed-jasper-el
 Bundle-SymbolicName: org.apache.tomcat-embed-jasper-el
 Bundle-Version: @VERSION@
diff --git a/res/bnd/tomcat-embed-jasper.jar.tmp.bnd 
b/res/bnd/tomcat-embed-jasper.jar.tmp.bnd
index 6ae519b..cd6170f 100644
--- a/res/bnd/tomcat-embed-jasper.jar.tmp.bnd
+++ b/res/bnd/tomcat-embed-jasper.jar.tmp.bnd
@@ -12,6 +12,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+Automatic-Module-Name: org.apache.tomcat-embed-jasper
 Bundle-Name: tomcat-embed-jasper
 Bundle-SymbolicName: org.apache.tomcat-embed-jasper
 Bundle-Version: @VERSION@
diff --git a/res/bnd/tomcat-embed-websocket.jar.tmp.bnd 
b/res/bnd/tomcat-embed-websocket.jar.tmp.bnd
index 581152c..7b80f60 100644
--- a/res/bnd/tomcat-embed-websocket.jar.tmp.bnd
+++ b/res/bnd/tomcat-embed-websocket.jar.tmp.bnd
@@ -12,6 +12,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+Automatic-Module-Name: org.apache.tomcat-embed-websocket
 Bundle-Name: tomcat-embed-websocket
 Bundle-SymbolicName: org.apache.tomcat-embed-websocket
 Bundle-Version: @VERSION@
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 5a3ca44..1d6d689 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -187,6 +187,11 @@
 from the standard WebSocket JAR that does not include the API classes.
 (markt)
   
+  
+63555: Add Automatic-Module-Name entries for
+each of the Tomcat provided JARs included in the Tomcat embedded
+distribution. (markt)
+  
 
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63555] embedded jar manifests missing automatic module names

2019-07-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=63555

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Mark Thomas  ---
The feature that implements this in bnd isn't in a released version yet. There
are also a number of open questions:
- What requirements will Jakarta EE add around JPMS in future versions?
- If Tomcat provides a spec JAR (e.g. Servlet spec) should it use the same JPMS
name as the Jakarta EE provide JAR or a different one?
- How to handle the fact that some Tomcat JARs - e.g. bootstrap.jar - break the
packaging rules JPMS expects?

Given all of the above, I have added Automatic-Module-Name entries for all the
Tomcat controlled JARs in the embedded distribution but have deliberately not
added names for the other JARs to see how the above issues play out first.

This has been fixed in master for 9.0.23 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Fix IDE warnings

2019-07-26 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 40c7a7f  Fix IDE warnings
40c7a7f is described below

commit 40c7a7f215c713a5bdee37432ea9d1c37dfdc74d
Author: Mark Thomas 
AuthorDate: Fri Jul 26 14:38:20 2019 +0100

Fix IDE warnings
---
 .../catalina/tribes/membership/cloud/AbstractStreamProvider.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/java/org/apache/catalina/tribes/membership/cloud/AbstractStreamProvider.java 
b/java/org/apache/catalina/tribes/membership/cloud/AbstractStreamProvider.java
index 1aa68bf..1c0d60b 100644
--- 
a/java/org/apache/catalina/tribes/membership/cloud/AbstractStreamProvider.java
+++ 
b/java/org/apache/catalina/tribes/membership/cloud/AbstractStreamProvider.java
@@ -25,6 +25,7 @@ import java.io.InputStream;
 import java.net.URL;
 import java.net.URLConnection;
 import java.security.KeyStore;
+import java.security.cert.Certificate;
 import java.security.cert.CertificateException;
 import java.security.cert.CertificateFactory;
 import java.security.cert.X509Certificate;
@@ -119,8 +120,8 @@ public abstract class AbstractStreamProvider implements 
StreamProvider {
 KeyStore trustStore = KeyStore.getInstance("JKS");
 trustStore.load(null);
 
-Collection c = 
certFactory.generateCertificates(pemInputStream);
-Iterator i = c.iterator();
+Collection c = 
certFactory.generateCertificates(pemInputStream);
+Iterator i = c.iterator();
 while (i.hasNext()) {
X509Certificate cert = (X509Certificate)i.next();
String alias = cert.getSubjectX500Principal().getName();


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Update bnd to 4.2.0

2019-07-26 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 3c8ce03  Update bnd to 4.2.0
3c8ce03 is described below

commit 3c8ce03ee388e4c69aac4b7a26b13ffa17050c16
Author: Mark Thomas 
AuthorDate: Fri Jul 26 14:43:55 2019 +0100

Update bnd to 4.2.0
---
 build.properties.default   | 6 +++---
 webapps/docs/changelog.xml | 3 +++
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/build.properties.default b/build.properties.default
index 86c46cf..14ef092 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -285,16 +285,16 @@ 
saaj-api.loc=${base-maven.loc}/javax/xml/soap/saaj-api/${saaj-api.version}/saaj-
 
 # - bnd & bndlib, version 4.0.0 or later  -
 # - provides OSGI metadata for JARs   -
-bnd.version=4.0.0
+bnd.version=4.2.0
 
 # checksums for biz.aQute.bnd-4.0.0.jar, biz.aQute.bndlib-4.0.0.jar
 bnd.checksum.enabled=true
 bnd.checksum.algorithm=MD5|SHA-1
-bnd.checksum.value=ddf578a4413ffa0eb6dc5b9476318fe2|fa7746eb710852498ce1afe5227be3fbfddaf09e
+bnd.checksum.value=ca26a671ea67bf75d83b1588bdd68923|d4bc96b2619f95e596bbf3f725f3b077e96c5d43
 
 bndlib.checksum.enabled=true
 bndlib.checksum.algorithm=MD5|SHA-1
-bndlib.checksum.value=7aa264bf3b6b32a11eea4a6cf43a9aaa|21e1d6fd1874d9bc201f2de1d0a48e84bff4149d
+bndlib.checksum.value=7519e890783ade99bb74608d0efbf8c4|c4fa30ac11cc0bf27b1f706ac8ebae8cec358e77
 
 bnd.home=${base.path}/bnd-${bnd.version}
 bnd.jar=${bnd.home}/biz.aQute.bnd-${bnd.version}.jar
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 1d6d689..3796900 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -192,6 +192,9 @@
 each of the Tomcat provided JARs included in the Tomcat embedded
 distribution. (markt)
   
+  
+Update dependency on bnd to 4.2.0. (markt)
+  
 
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63550

2019-07-26 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 77a0829  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63550
77a0829 is described below

commit 77a08291707fc0c769697f48c01dcc5766b4f2c8
Author: Mark Thomas 
AuthorDate: Fri Jul 26 14:59:57 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63550

Only use the alternateURL for the JNDIRealm when it has been specified
---
 java/org/apache/catalina/realm/JNDIRealm.java | 4 
 webapps/docs/changelog.xml| 4 
 2 files changed, 8 insertions(+)

diff --git a/java/org/apache/catalina/realm/JNDIRealm.java 
b/java/org/apache/catalina/realm/JNDIRealm.java
index a518c38..5707cbf 100644
--- a/java/org/apache/catalina/realm/JNDIRealm.java
+++ b/java/org/apache/catalina/realm/JNDIRealm.java
@@ -2389,6 +2389,10 @@ public class JNDIRealm extends RealmBase {
 context = createDirContext(getDirectoryContextEnvironment());
 
 } catch (Exception e) {
+if (alternateURL == null || alternateURL.length() == 0) {
+// No alternate URL. Re-throw the exception.
+throw e;
+}
 
 connectionAttempt = 1;
 
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 3796900..f96bdfe 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -47,6 +47,10 @@
 
   
 
+  
+63550: Only try the alternateURL in the
+JNDIRealm if one has been specified. (markt)
+  
   
 63556: Mark request as forwarded in RemoteIpValve and
 RemoteIpFilter (michaelo)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63550

2019-07-26 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 2deeecc  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63550
2deeecc is described below

commit 2deeecc4d93455e4cb516276a9dd9bb744158d4b
Author: Mark Thomas 
AuthorDate: Fri Jul 26 14:59:57 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63550

Only use the alternateURL for the JNDIRealm when it has been specified
---
 java/org/apache/catalina/realm/JNDIRealm.java | 4 
 webapps/docs/changelog.xml| 4 
 2 files changed, 8 insertions(+)

diff --git a/java/org/apache/catalina/realm/JNDIRealm.java 
b/java/org/apache/catalina/realm/JNDIRealm.java
index 950ee8a..a69dd71 100644
--- a/java/org/apache/catalina/realm/JNDIRealm.java
+++ b/java/org/apache/catalina/realm/JNDIRealm.java
@@ -2404,6 +2404,10 @@ public class JNDIRealm extends RealmBase {
 context = createDirContext(getDirectoryContextEnvironment());
 
 } catch (Exception e) {
+if (alternateURL == null || alternateURL.length() == 0) {
+// No alternate URL. Re-throw the exception.
+throw e;
+}
 
 connectionAttempt = 1;
 
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index f798aee..f93082f 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -47,6 +47,10 @@
 
   
 
+  
+63550: Only try the alternateURL in the
+JNDIRealm if one has been specified. (markt)
+  
   
 63556: Mark request as forwarded in RemoteIpValve and
 RemoteIpFilter (michaelo)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63550

2019-07-26 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new 7b1a92a  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63550
7b1a92a is described below

commit 7b1a92ad2b848a9bdfa075c4508d2533c9803bc0
Author: Mark Thomas 
AuthorDate: Fri Jul 26 14:59:57 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63550

Only use the alternateURL for the JNDIRealm when it has been specified
---
 java/org/apache/catalina/realm/JNDIRealm.java | 4 
 webapps/docs/changelog.xml| 8 
 2 files changed, 12 insertions(+)

diff --git a/java/org/apache/catalina/realm/JNDIRealm.java 
b/java/org/apache/catalina/realm/JNDIRealm.java
index ddd07ae..5d46cfc 100644
--- a/java/org/apache/catalina/realm/JNDIRealm.java
+++ b/java/org/apache/catalina/realm/JNDIRealm.java
@@ -2461,6 +2461,10 @@ public class JNDIRealm extends RealmBase {
 context = createDirContext(getDirectoryContextEnvironment());
 
 } catch (Exception e) {
+if (alternateURL == null || alternateURL.length() == 0) {
+// No alternate URL. Re-throw the exception.
+throw e;
+}
 
 connectionAttempt = 1;
 
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 95dee23..d2cd6c9 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -60,6 +60,14 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  
+63550: Only try the alternateURL in the
+JNDIRealm if one has been specified. (markt)
+  
+
+  
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Fix back-port

2019-07-26 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new 32f0bbe  Fix back-port
32f0bbe is described below

commit 32f0bbed9f6b5829b4ee58c87c79da9e4f145b9c
Author: Mark Thomas 
AuthorDate: Fri Jul 26 15:33:38 2019 +0100

Fix back-port
---
 java/org/apache/catalina/realm/JNDIRealm.java | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/catalina/realm/JNDIRealm.java 
b/java/org/apache/catalina/realm/JNDIRealm.java
index 5d46cfc..1b83276 100644
--- a/java/org/apache/catalina/realm/JNDIRealm.java
+++ b/java/org/apache/catalina/realm/JNDIRealm.java
@@ -2463,7 +2463,13 @@ public class JNDIRealm extends RealmBase {
 } catch (Exception e) {
 if (alternateURL == null || alternateURL.length() == 0) {
 // No alternate URL. Re-throw the exception.
-throw e;
+if (e instanceof NamingException) {
+throw (NamingException) e;
+} else if (e instanceof RuntimeException) {
+throw (RuntimeException) e;
+}
+// Not possible to reach this point and not throw an exception.
+// Later versions of Java allow us to simply use "throw e" 
here.
 }
 
 connectionAttempt = 1;


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63550] LDAP non standard port leads to JNDIRealm erratic behaviour

2019-07-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=63550

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #7 from Mark Thomas  ---
I opted to fix this by only using the alternateURL if one was specified.

My thinking regarding retrying the connectionURL was that some users might not
want a retry and those that do can use the same value for alternateURL as
connectionURL.

Fixed in:
- master for 9.0.23 onwards
- 8.5.x for 8.5.44 onwards
- 7.0.x for 7.0.97 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63555] embedded jar manifests missing automatic module names

2019-07-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=63555

--- Comment #3 from Raymond Augé  ---
When you get back to this let me know if I can help with bnd.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Bug 63555] embedded jar manifests missing automatic module names

2019-07-26 Thread Raymond Auge 
.. maybe I can play with it over the next months.

- Ray

On Fri, Jul 26, 2019 at 11:24 AM  wrote:

> https://bz.apache.org/bugzilla/show_bug.cgi?id=63555
>
> --- Comment #3 from Raymond Augé  ---
> When you get back to this let me know if I can help with bnd.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

-- 
*Raymond Augé* 
 (@rotty3000)
Senior Software Architect *Liferay, Inc.* 
 (@Liferay)
Board Member & EEG Co-Chair, OSGi Alliance  (@OSGiAlliance)

Re: [Bug 63555] embedded jar manifests missing automatic module names

2019-07-26 Thread Mark Thomas 
On 26/07/2019 16:27, Raymond Auge wrote:
> .. maybe I can play with it over the next months.

Thanks. Much appreciated. We'll at least need to wait for a bnd 4.3.0
release. Although I suspect that will happen before Jakarta EE makes any
decision regarding JPMS.

Cheers,

Mark


> 
> - Ray
> 
> On Fri, Jul 26, 2019 at 11:24 AM  > wrote:
> 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=63555
> 
> --- Comment #3 from Raymond Augé  > ---
> When you get back to this let me know if I can help with bnd.
> 
> -- 
> You are receiving this mail because:
> You are the assignee for the bug.
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> 
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 
> 
> 
> 
> -- 
> *Raymond Augé*
>  (@rotty3000)
> Senior Software Architect *Liferay, Inc.*
>  (@Liferay)
> Board Member & EEG Co-Chair, OSGi Alliance  (@OSGiAlliance)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] bokken commented on a change in pull request #143: Apply deduplication to certain loaded and created Strings

2019-07-26 Thread GitBox 
bokken commented on a change in pull request #143: Apply deduplication to 
certain loaded and created Strings
URL: https://github.com/apache/tomcat/pull/143#discussion_r307798580
 
 

 ##
 File path: java/org/apache/tomcat/util/digester/SetPropertiesRule.java
 ##
 @@ -62,7 +59,7 @@ public void begin(String namespace, String theName, 
Attributes attributes)
 if ("".equals(name)) {
 name = attributes.getQName(i);
 }
-String value = attributes.getValue(i);
+String value = attributes.getValue(i).intern();
 
 Review comment:
   So Aleksey's article was used to determine that de-dup could help and then 
implemented it in the exact way that Aleksey proved was terrible?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Bug 63555] embedded jar manifests missing automatic module names

2019-07-26 Thread Raymond Auge 
On Fri, Jul 26, 2019 at 11:33 AM Mark Thomas  wrote:

> On 26/07/2019 16:27, Raymond Auge wrote:
> > .. maybe I can play with it over the next months.
>
> Thanks. Much appreciated. We'll at least need to wait for a bnd 4.3.0
> release. Although I suspect that will happen before Jakarta EE makes any
> decision regarding JPMS.
>

Certainly. The currently timeline for release is end of August.

- Ray


>
> Cheers,
>
> Mark
>
>
> >
> > - Ray
> >
> > On Fri, Jul 26, 2019 at 11:24 AM  > > wrote:
> >
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=63555
> >
> > --- Comment #3 from Raymond Augé  > > ---
> > When you get back to this let me know if I can help with bnd.
> >
> > --
> > You are receiving this mail because:
> > You are the assignee for the bug.
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > 
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> > 
> >
> >
> >
> > --
> > *Raymond Augé*
> >  (@rotty3000)
> > Senior Software Architect *Liferay, Inc.*
> >  (@Liferay)
> > Board Member & EEG Co-Chair, OSGi Alliance 
> (@OSGiAlliance)
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

-- 
*Raymond Augé* 
 (@rotty3000)
Senior Software Architect *Liferay, Inc.* 
 (@Liferay)
Board Member & EEG Co-Chair, OSGi Alliance  (@OSGiAlliance)

[GitHub] [tomcat] markt-asf commented on a change in pull request #143: Apply deduplication to certain loaded and created Strings

2019-07-26 Thread GitBox 
markt-asf commented on a change in pull request #143: Apply deduplication to 
certain loaded and created Strings
URL: https://github.com/apache/tomcat/pull/143#discussion_r307809324
 
 

 ##
 File path: java/org/apache/tomcat/util/digester/SetPropertiesRule.java
 ##
 @@ -62,7 +59,7 @@ public void begin(String namespace, String theName, 
Attributes attributes)
 if ("".equals(name)) {
 name = attributes.getQName(i);
 }
-String value = attributes.getValue(i);
+String value = attributes.getValue(i).intern();
 
 Review comment:
   For the relatively small number of strings concerned, we did not observe any 
performance issues and intern() was considered to be a reasonable approach. 
Happy to review contrary data, should any be provided.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] bokken commented on a change in pull request #143: Apply deduplication to certain loaded and created Strings

2019-07-26 Thread GitBox 
bokken commented on a change in pull request #143: Apply deduplication to 
certain loaded and created Strings
URL: https://github.com/apache/tomcat/pull/143#discussion_r307868511
 
 

 ##
 File path: java/org/apache/tomcat/util/digester/SetPropertiesRule.java
 ##
 @@ -62,7 +59,7 @@ public void begin(String namespace, String theName, 
Attributes attributes)
 if ("".equals(name)) {
 name = attributes.getQName(i);
 }
-String value = attributes.getValue(i);
+String value = attributes.getValue(i).intern();
 
 Review comment:
   What was the observed benefit from using String.intern()?
   My take away from Aleksey's article was that String.intern should 
effectively never be used.
   If the only observed benefit was removal of long lived "duplicate" strings, 
then the [G1 string dedup](http://openjdk.java.net/jeps/192) already provides 
the majority of that benefit with none of the drawbacks of intern usage. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] markt-asf commented on a change in pull request #143: Apply deduplication to certain loaded and created Strings

2019-07-26 Thread GitBox 
markt-asf commented on a change in pull request #143: Apply deduplication to 
certain loaded and created Strings
URL: https://github.com/apache/tomcat/pull/143#discussion_r307876106
 
 

 ##
 File path: java/org/apache/tomcat/util/digester/SetPropertiesRule.java
 ##
 @@ -62,7 +59,7 @@ public void begin(String namespace, String theName, 
Attributes attributes)
 if ("".equals(name)) {
 name = attributes.getQName(i);
 }
-String value = attributes.getValue(i);
+String value = attributes.getValue(i).intern();
 
 Review comment:
   See previous comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.96

2019-07-26 Thread Rainer Jung 

Am 24.07.2019 um 15:56 schrieb Violeta Georgieva:

The proposed Apache Tomcat 7.0.96 release is now available for voting.

For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat7/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.96/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1224/
The git tag is:
https://github.com/apache/tomcat/tree/7.0.96
5277b175db2e575022672856797240976ad23bcf

The proposed 7.0.96 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.96 Stable


I observed the same hang on three different Linux systems when using 
OpenJDK 13-ea+29. Surely early access. The hang is always in 
TestAbstractAjpProcessor for NIO in test testKeepAlive. The hanging JVM 
process only shows the AJP client:


"main" #1 prio=5 os_prio=0 cpu=1497.40ms elapsed=18779.47s 
tid=0x7ff040017800 nid=0x7ea3 runnable  [0x7ff046b74000]

   java.lang.Thread.State: RUNNABLE
at sun.nio.ch.SocketDispatcher.read0(java.base@13-ea/Native Method)
at 
sun.nio.ch.SocketDispatcher.read(java.base@13-ea/SocketDispatcher.java:47)
at 
sun.nio.ch.NioSocketImpl.tryRead(java.base@13-ea/NioSocketImpl.java:262)
at 
sun.nio.ch.NioSocketImpl.implRead(java.base@13-ea/NioSocketImpl.java:313)
at 
sun.nio.ch.NioSocketImpl.read(java.base@13-ea/NioSocketImpl.java:351)
at 
sun.nio.ch.NioSocketImpl$1.read(java.base@13-ea/NioSocketImpl.java:802)
at 
java.net.Socket$SocketInputStream.read(java.base@13-ea/Socket.java:919)
at 
org.apache.coyote.ajp.SimpleAjpClient.read(SimpleAjpClient.java:390)
at 
org.apache.coyote.ajp.SimpleAjpClient.readMessage(SimpleAjpClient.java:365)
at 
org.apache.coyote.ajp.SimpleAjpClient.cping(SimpleAjpClient.java:350)
at 
org.apache.coyote.ajp.TestAbstractAjpProcessor.testKeepAlive(TestAbstractAjpProcessor.java:526)

...

but the log indicates a problem:

INFO: Starting test case [testKeepAlive]
Jul 26, 2019 5:20:37 PM org.apache.coyote.AbstractProtocol init
INFO: Initializing ProtocolHandler ["ajp-nio-127.0.0.1-auto-6"]
Jul 26, 2019 5:20:37 PM org.apache.coyote.AbstractProtocol init
SEVERE: Failed to initialize end point associated with ProtocolHandler 
["ajp-nio-127.0.0.1-auto-6-34726"]

java.lang.IllegalArgumentException: timeout < 0
at 
java.base/sun.nio.ch.ServerSocketAdaptor.setSoTimeout(ServerSocketAdaptor.java:153)
at 
org.apache.tomcat.util.net.NioEndpoint.bind(NioEndpoint.java:477)
at 
org.apache.tomcat.util.net.AbstractEndpoint.init(AbstractEndpoint.java:728)
at 
org.apache.coyote.AbstractProtocol.init(AbstractProtocol.java:452)
at 
org.apache.catalina.connector.Connector.initInternal(Connector.java:978)
at 
org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:102)
at 
org.apache.catalina.core.StandardService.initInternal(StandardService.java:560)
at 
org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:102)
at 
org.apache.catalina.core.StandardServer.initInternal(StandardServer.java:840)
at 
org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:102)
at 
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:135)

at org.apache.catalina.startup.Tomcat.start(Tomcat.java:449)
at 
org.apache.catalina.startup.TomcatBaseTest$TomcatWithFastSessionIDs.start(TomcatBaseTest.java:808)
at 
org.apache.coyote.ajp.TestAbstractAjpProcessor.testKeepAlive(TestAbstractAjpProcessor.java:513)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.base/java.lang.reflect.Method.invoke(Method.java:567)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)

at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)

at org.junit.runne

Re: [VOTE] Release Apache Tomcat 7.0.96

2019-07-26 Thread Rainer Jung 




Am 26.07.2019 um 22:57 schrieb Rainer Jung:

Am 24.07.2019 um 15:56 schrieb Violeta Georgieva:

The proposed Apache Tomcat 7.0.96 release is now available for voting.

For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat7/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.96/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1224/
The git tag is:
https://github.com/apache/tomcat/tree/7.0.96
5277b175db2e575022672856797240976ad23bcf

The proposed 7.0.96 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.96 Stable


I observed the same hang on three different Linux systems when using 
OpenJDK 13-ea+29. Surely early access. The hang is always in 
TestAbstractAjpProcessor for NIO in test testKeepAlive. The hanging JVM 
process only shows the AJP client:


"main" #1 prio=5 os_prio=0 cpu=1497.40ms elapsed=18779.47s 
tid=0x7ff040017800 nid=0x7ea3 runnable  [0x7ff046b74000]

    java.lang.Thread.State: RUNNABLE
     at sun.nio.ch.SocketDispatcher.read0(java.base@13-ea/Native 
Method)
     at 
sun.nio.ch.SocketDispatcher.read(java.base@13-ea/SocketDispatcher.java:47)
     at 
sun.nio.ch.NioSocketImpl.tryRead(java.base@13-ea/NioSocketImpl.java:262)
     at 
sun.nio.ch.NioSocketImpl.implRead(java.base@13-ea/NioSocketImpl.java:313)
     at 
sun.nio.ch.NioSocketImpl.read(java.base@13-ea/NioSocketImpl.java:351)
     at 
sun.nio.ch.NioSocketImpl$1.read(java.base@13-ea/NioSocketImpl.java:802)
     at 
java.net.Socket$SocketInputStream.read(java.base@13-ea/Socket.java:919)
     at 
org.apache.coyote.ajp.SimpleAjpClient.read(SimpleAjpClient.java:390)
     at 
org.apache.coyote.ajp.SimpleAjpClient.readMessage(SimpleAjpClient.java:365)
     at 
org.apache.coyote.ajp.SimpleAjpClient.cping(SimpleAjpClient.java:350)
     at 
org.apache.coyote.ajp.TestAbstractAjpProcessor.testKeepAlive(TestAbstractAjpProcessor.java:526) 


...

but the log indicates a problem:

INFO: Starting test case [testKeepAlive]
Jul 26, 2019 5:20:37 PM org.apache.coyote.AbstractProtocol init
INFO: Initializing ProtocolHandler ["ajp-nio-127.0.0.1-auto-6"]
Jul 26, 2019 5:20:37 PM org.apache.coyote.AbstractProtocol init
SEVERE: Failed to initialize end point associated with ProtocolHandler 
["ajp-nio-127.0.0.1-auto-6-34726"]

java.lang.IllegalArgumentException: timeout < 0
     at 
java.base/sun.nio.ch.ServerSocketAdaptor.setSoTimeout(ServerSocketAdaptor.java:153) 

     at 
org.apache.tomcat.util.net.NioEndpoint.bind(NioEndpoint.java:477)
     at 
org.apache.tomcat.util.net.AbstractEndpoint.init(AbstractEndpoint.java:728)
     at 
org.apache.coyote.AbstractProtocol.init(AbstractProtocol.java:452)
     at 
org.apache.catalina.connector.Connector.initInternal(Connector.java:978)
     at 
org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:102)
     at 
org.apache.catalina.core.StandardService.initInternal(StandardService.java:560) 

     at 
org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:102)
     at 
org.apache.catalina.core.StandardServer.initInternal(StandardServer.java:840) 

     at 
org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:102)
     at 
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:135)

     at org.apache.catalina.startup.Tomcat.start(Tomcat.java:449)
     at 
org.apache.catalina.startup.TomcatBaseTest$TomcatWithFastSessionIDs.start(TomcatBaseTest.java:808) 

     at 
org.apache.coyote.ajp.TestAbstractAjpProcessor.testKeepAlive(TestAbstractAjpProcessor.java:513) 

     at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
     at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 

     at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 


     at java.base/java.lang.reflect.Method.invoke(Method.java:567)
     at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) 

     at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) 

     at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) 

     at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) 

     at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) 

     at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)

     at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
     at org.junit.rules.RunRules.evaluate(RunRules.java:20)
     at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
     at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)