Re: [GUMP@vmgump-vm3]: Project tomcat-trunk (in module tomcat-trunk) failed
On 17/01/2019 02:09, Bill Barker wrote: > [javac] symbol: class ExtensibilityElement > [javac] location: class ServiceRefFactory > [javac] > /srv/gump/public/workspace/tomcat-trunk/java/org/apache/naming/factory/webservices/ServiceRefFactory.java:328: > error: cannot find symbol Gump appears to be missing the the JAR files required to build the extras code that was merged into the core build. I've made an attempt to fix it. I'll check the next build. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #12 from Remy Maucherat --- Ok, so this turns out rather mysterious. The executor used has an unlimited queue and any execution rejection or error is supposed to be logged anyway, so there shouldn't be a problem. Can you try another value for startStopThreads on your opteron server, like "16" ? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #13 from Peter --- We are getting closer. I testet with startStopThreads="2", startStopThreads="4" and startStopThreads="8" In these cases autodeploy is working fine. Only startStopThreads="0" has the problem. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #14 from Konstantin Kolinko --- 1. Have you looked into Tomcat log files? 2. A comment says: This means that the actual number depends on your hardware. I wonder what is the actual number of cores that Java reports for you. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #15 from Remy Maucherat --- (In reply to Konstantin Kolinko from comment #14) > 1. Have you looked into Tomcat log files? > > 2. A comment says: > > > This means that the actual number depends on your hardware. > I wonder what is the actual number of cores that Java reports for you. That was before, I changed it (and documented) to Runtime.getRuntime().availableProcessors() / 2 now since CPUs have smt and I thought the previous default was way too high for the tasks at hand. Not this opteron though ;) Runtime.getRuntime().availableProcessors() is supposed to return 16, so the new default should be 8, and before it was 16. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1851580 - /tomcat/trunk/java/org/apache/coyote/http2/Stream.java
Author: markt
Date: Thu Jan 17 20:46:16 2019
New Revision: 1851580
URL: http://svn.apache.org/viewvc?rev=1851580&view=rev
Log:
Rename for clarity
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Stream.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Stream.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Stream.java?rev=1851580&r1=1851579&r2=1851580&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Stream.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Stream.java Thu Jan 17 20:46:16
2019
@@ -934,7 +934,7 @@ class Stream extends AbstractStream impl
// 'write mode'.
private volatile ByteBuffer inBuffer;
private volatile boolean readInterest;
-private boolean reset = false;
+private boolean resetReceived = false;
@Override
public final int doRead(ApplicationBufferHandler
applicationBufferHandler)
@@ -954,7 +954,7 @@ class Stream extends AbstractStream impl
log.debug(sm.getString("stream.inputBuffer.empty"));
}
inBuffer.wait();
-if (reset) {
+if (resetReceived) {
throw new
IOException(sm.getString("stream.inputBuffer.reset"));
}
} catch (InterruptedException e) {
@@ -1080,7 +1080,7 @@ class Stream extends AbstractStream impl
private final void receiveReset() {
if (inBuffer != null) {
synchronized (inBuffer) {
-reset = true;
+resetReceived = true;
inBuffer.notifyAll();
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1851581 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/Stream.java
Author: markt Date: Thu Jan 17 20:46:49 2019 New Revision: 1851581 URL: http://svn.apache.org/viewvc?rev=1851581&view=rev Log: Rename for clarity Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Stream.java Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Thu Jan 17 20:46:49 2019 @@ -1,2 +1,2 @@ /tomcat/tc8.0.x/trunk:1809644 -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409 ,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747 404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1 756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205 3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,1763529,1763559,1763565,1763568,1763574,1763619,1763634-1763635,1763718,1763748
svn commit: r1851582 - /tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java
Author: markt
Date: Thu Jan 17 20:49:58 2019
New Revision: 1851582
URL: http://svn.apache.org/viewvc?rev=1851582&view=rev
Log:
Add debug logging of ClientAbortExceptions
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java?rev=1851582&r1=1851581&r2=1851582&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java Thu
Jan 17 20:49:58 2019
@@ -202,6 +202,11 @@ final class StandardWrapperValve
}
} catch (ClientAbortException e) {
+if (container.getLogger().isDebugEnabled()) {
+container.getLogger().debug(sm.getString(
+"standardWrapper.serviceException", wrapper.getName(),
+context.getName()), e);
+}
throwable = e;
exception(request, response, e);
} catch (IOException e) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1851583 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/Stream.java
Author: markt Date: Thu Jan 17 20:51:24 2019 New Revision: 1851583 URL: http://svn.apache.org/viewvc?rev=1851583&view=rev Log: Fix back-port Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Stream.java Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Thu Jan 17 20:51:24 2019 @@ -1,2 +1,2 @@ /tomcat/tc8.0.x/trunk:1809644 -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409 ,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747 404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1 756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205 3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,1763529,1763559,1763565,1763568,1763574,1763619,1763634-1763635,1763718,1763748,1763
svn commit: r1851584 - /tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardWrapperValve.java
Author: markt
Date: Thu Jan 17 20:51:39 2019
New Revision: 1851584
URL: http://svn.apache.org/viewvc?rev=1851584&view=rev
Log:
Add debug logging of ClientAbortExceptions
Modified:
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardWrapperValve.java
Modified:
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardWrapperValve.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardWrapperValve.java?rev=1851584&r1=1851583&r2=1851584&view=diff
==
---
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardWrapperValve.java
(original)
+++
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardWrapperValve.java
Thu Jan 17 20:51:39 2019
@@ -202,6 +202,11 @@ final class StandardWrapperValve
}
} catch (ClientAbortException e) {
+if (container.getLogger().isDebugEnabled()) {
+container.getLogger().debug(sm.getString(
+"standardWrapper.serviceException", wrapper.getName(),
+context.getName()), e);
+}
throwable = e;
exception(request, response, e);
} catch (IOException e) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #16 from Coty Sutherland --- Are you able to reproduce the problem 100% of the time? How large are your webapps and how long does it take to deploy/undeploy? Does the same webapp fail repeatedly, or are you able to reproduce with different webapps? Could you try reproducing with the webapps provided with vanilla tomcat (i.e. examples, ROOT)? Using a vanilla webapp will help rule out/pinpoint anything weird happening with the webapp you're currently reproducing with. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1851587 - in /tomcat/trunk: java/org/apache/catalina/core/StandardServer.java webapps/docs/changelog.xml webapps/docs/config/server.xml
Author: remm
Date: Thu Jan 17 21:46:32 2019
New Revision: 1851587
URL: http://svn.apache.org/viewvc?rev=1851587&view=rev
Log:
Use Runtime.getRuntime().availableProcessors() again as the base value for
utility thread counts, it has been used that way for too long and shouldn't
have been changed.
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardServer.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/server.xml
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardServer.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardServer.java?rev=1851587&r1=1851586&r2=1851587&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardServer.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardServer.java Thu Jan 17
21:46:32 2019
@@ -416,29 +416,24 @@ public final class StandardServer extend
*/
private static int getUtilityThreadsInternal(int utilityThreads) {
int result = utilityThreads;
-if (result > 0) {
-return result;
-}
-
-// Zero == Runtime.getRuntime().availableProcessors() / 2
-// -ve == Runtime.getRuntime().availableProcessors() / 2 + value
-// These two are the same
-result = (Runtime.getRuntime().availableProcessors() / 2) + result;
-if (result < 1) {
-result = 1;
+if (result <= 0) {
+result = Runtime.getRuntime().availableProcessors() + result;
+if (result < 1) {
+result = 1;
+}
}
return result;
}
+
@Override
public void setUtilityThreads(int utilityThreads) {
-if (getUtilityThreadsInternal(utilityThreads) <
getUtilityThreadsInternal(this.utilityThreads)) {
+// Use local copies to ensure thread safety
+int oldUtilityThreads = this.utilityThreads;
+if (getUtilityThreadsInternal(utilityThreads) <
getUtilityThreadsInternal(oldUtilityThreads)) {
return;
}
-int oldUtilityThreads = this.utilityThreads;
this.utilityThreads = utilityThreads;
-
-// Use local copies to ensure thread safety
if (oldUtilityThreads != utilityThreads && utilityExecutor != null) {
reconfigureUtilityExecutor(getUtilityThreadsInternal(utilityThreads));
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1851587&r1=1851586&r2=1851587&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jan 17 21:46:32 2019
@@ -88,6 +88,10 @@
Log a message when using a Connector that requires Apr without enabling
the AprLifecycleListener first. (csutherl)
+
+Utility thread count for special negative or zero values will again be
+based on Runtime.getRuntime().availableProcessors(). (remm)
+
Modified: tomcat/trunk/webapps/docs/config/server.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/server.xml?rev=1851587&r1=1851586&r2=1851587&view=diff
==
--- tomcat/trunk/webapps/docs/config/server.xml (original)
+++ tomcat/trunk/webapps/docs/config/server.xml Thu Jan 17 21:46:32 2019
@@ -90,9 +90,9 @@
The number of threads this Service will use for
various utility tasks, including recurring ones. The special value
of 0 will result in the value of
- Runtime.getRuntime().availableProcessors()/2 being
+ Runtime.getRuntime().availableProcessors() being
used. Negative values will result in
- Runtime.getRuntime().availableProcessors()/2 + value being
+ Runtime.getRuntime().availableProcessors() + value being
used unless this is less than 1 in which case 1 thread will be used.
The default value is 1.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #17 from Remy Maucherat --- Negative or zero values will now again use (Runtime.getRuntime().availableProcessors() + value) in Tomcat 9.0.15. It's not really related to the mysterious behavior, but it shouldn't have been changed as this default value had been in place for a long while (I approached the item with a "all my CPUs of the past 10 years have SMT so this is wasteful" thinking). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1851588 - in /tomcat/trunk: java/org/apache/catalina/connector/InputBuffer.java webapps/docs/changelog.xml
Author: markt
Date: Thu Jan 17 22:04:07 2019
New Revision: 1851588
URL: http://svn.apache.org/viewvc?rev=1851588&view=rev
Log:
Treat I/O errors during request body reads the same way as I/O errors during
response body writes. The errors are treated as client side errors rather than
server side errors and only logged at debug level.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java?rev=1851588&r1=1851587&r2=1851588&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java Thu Jan 17
22:04:07 2019
@@ -332,9 +332,13 @@ public class InputBuffer extends Reader
state = BYTE_STATE;
}
-int result = coyoteRequest.doRead(this);
-
-return result;
+try {
+return coyoteRequest.doRead(this);
+} catch (IOException ioe) {
+// An IOException on a read is almost always due to
+// the remote client aborting the request.
+throw new ClientAbortException(ioe);
+}
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1851588&r1=1851587&r2=1851588&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jan 17 22:04:07 2019
@@ -92,6 +92,12 @@
Utility thread count for special negative or zero values will again be
based on Runtime.getRuntime().availableProcessors(). (remm)
+
+Treat I/O errors during request body reads the same way as I/O errors
+during response body writes. The errors are treated as client side
+errors rather than server side errors and only logged at debug level.
+(markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1851589 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/InputBuffer.java webapps/docs/changelog.xml
Author: markt Date: Thu Jan 17 22:05:14 2019 New Revision: 1851589 URL: http://svn.apache.org/viewvc?rev=1851589&view=rev Log: Treat I/O errors during request body reads the same way as I/O errors during response body writes. The errors are treated as client side errors rather than server side errors and only logged at debug level. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/connector/InputBuffer.java tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Thu Jan 17 22:05:14 2019 @@ -1,2 +1,2 @@ /tomcat/tc8.0.x/trunk:1809644 -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409 ,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747 404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1 756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205 3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,17
svn commit: r1851592 - /tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
Author: markt
Date: Thu Jan 17 23:10:36 2019
New Revision: 1851592
URL: http://svn.apache.org/viewvc?rev=1851592&view=rev
Log:
Correct tense (reported via POEditor)
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties?rev=1851592&r1=1851591&r2=1851592&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
[UTF-8] Thu Jan 17 23:10:36 2019
@@ -57,7 +57,7 @@ endpoint.apr.maxConnections.running=The
endpoint.apr.maxConnections.unlimited=The APR endpoint does not support
unlimited connections. The existing value of [{0}] will continue to be used.
endpoint.apr.noSendfileWithSSL=Sendfile is not supported for the APR/native
connector when SSL is enabled
endpoint.apr.noSslCertFile=Connector attribute SSLCertificateFile must be
defined when using SSL with APR
-endpoint.apr.pollAddInvalid=Invalid attempted to add a socket [{0}] to the
poller
+endpoint.apr.pollAddInvalid=Invalid attempt to add a socket [{0}] to the poller
endpoint.apr.pollError=Poller failed with error [{0}] : [{1}]
endpoint.apr.pollMergeEvents=Merge poller event [{1}] for socket [{0}] to
create merged event [{2}]
endpoint.apr.pollUnknownEvent=A socket was returned from the poller with an
unrecognized event [{0}]
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1851593 - /tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
Author: markt
Date: Thu Jan 17 23:13:08 2019
New Revision: 1851593
URL: http://svn.apache.org/viewvc?rev=1851593&view=rev
Log:
Improve wording. Reported via POEditor
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties?rev=1851593&r1=1851592&r2=1851593&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
[UTF-8] Thu Jan 17 23:13:08 2019
@@ -126,7 +126,7 @@ endpoint.socketOptionsError=Error settin
endpoint.timeout.err=Error processing socket timeout
endpoint.unknownSslHostName=The SSL host name [{0}] is not recognised for this
endpoint
endpoint.warn.executorShutdown=The executor associated with thread pool [{0}]
has not fully shutdown. Some application threads may still be running.
-endpoint.warn.incorrectConnectionCount=Incorrect connection count, multiple
socket.close called on the same socket.
+endpoint.warn.incorrectConnectionCount=Incorrect connection count, multiple
calls to socket.close for the same socket.
endpoint.warn.noLocalAddr=Unable to determine local address for socket [{0}]
endpoint.warn.noLocalName=Unable to determine local host name for socket [{0}]
endpoint.warn.noLocalPort=Unable to determine local port for socket [{0}]
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #18 from Peter --- We operate more than 30 of tomcat server with many different webapps. All server run in a big blade environments in virtual maschines. New versions of these webapps from many developer gets automatically deployed in the test environment. The number of cores Runtime.getRuntime().availableProcessors() reports on these test maschines is allways between 2 and 8 (depending on the VM settings). After I updated Tomcat to Version 9.0.14 the automatic deployment did not work anymore. Some webapps are very small with only a few libraries, others are rather large (spring boot with many libs). It was a generell Problem of all maschines. Without parallel deployment, the tomcats needed significantly longer to start, since a view of them host more than 20 different webapps. Now I changed the value to startStopThreads="4" and my problem is solved. Thanks to all of you who helped to find the reason and for providing the tomcat server software. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
