[Bug 63022] Nio2Endpoint(SocketProcessorBase) for async request doesn't decrement LimitLatch while handling socket that is already closed
https://bz.apache.org/bugzilla/show_bug.cgi?id=63022 Remy Maucherat changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Remy Maucherat --- During async there's no IO operation going on, so no way to detect a socket disconnect. As a result, nothing will actually get closed magically. You need to perform an IO operation to find it out, otherwise you can remain in async mode forever. So the test closes the socket, and then async completes. The problem is that the wrapper isClosed() now returns true, which will prevent the async complete processing (SocketProcessorBase.run calls isClosed()). This is not normal, but closing using introspection is not either. So maybe there's a "problem" here, but the test is not a representation of a bug which needs to be fixed. Also maybe SocketWrapper.isClosed() shouldn't check the socket state and this could solve this situation along with more legitimate ones, but this needs to be carefully reviewed. Set need info to investigate and review some more, just in case. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 62799] mod_jk doesn't handle the EINPROGRESS state appropriately for non-blocking sockets.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62799 m...@blackmans.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |LATER --- Comment #10 from m...@blackmans.org --- this did get rolled out to the prod environment, but the reporting user has moved to mod_proxy_ajp and I have no had time to run my own tests, but I would say this is a weakly positive improvement. I would like to test this sometime, but not sure when I can. I'll reopen if I find any negative feedback. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63022] Nio2Endpoint(SocketProcessorBase) for async request doesn't decrement LimitLatch while handling socket that is already closed
https://bz.apache.org/bugzilla/show_bug.cgi?id=63022 --- Comment #3 from Remy Maucherat --- Created attachment 36340 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36340&action=edit NIO2 close patch Simplify the socket close for NIO2, which would probably fix bad side effects like seen here. This builds on previous close refactorings and looking at all the callers this should clearly should work fine now. Please review. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] New committer: Woonsan Ko
Congratulations and Welcome Woonsan! On Wed, Dec 19, 2018 at 9:08 PM Keiichi Fujino wrote: > Congratulations! > Welcome Woonsan! > > 2018年12月19日(水) 18:56 Mark Thomas : > > > On behalf of the Tomcat committers I am pleased to announce that > > Woonsan Ko (woonsan) has been voted in as a new Tomcat committer. > > > > Please join me in welcoming him. > > > > Kind regards, > > > > Mark > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > -- > Keiichi.Fujino >
[Bug 63026] New: JNDIRealm fails to authenticate user with 2 trailing spaces CN
https://bz.apache.org/bugzilla/show_bug.cgi?id=63026
Bug ID: 63026
Summary: JNDIRealm fails to authenticate user with 2 trailing
spaces CN
Product: Tomcat 8
Version: 8.0.33
Hardware: PC
Status: NEW
Severity: minor
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: david.anuszew...@cerner.com
Target Milestone:
Using JNDIRealm to authenticate users against Microsoft Active Directory fails
if the AD user object has 2 trailing spaces in it's cn. Realm is configured
with adCompat="true" and userSearch="(sAMAccountName={0})".
Debugging through the code the getUserBySearch() method ldap search returns a
result with only the last space escaped, but the method getDistinquishedName()
returns a dn with both spaces escaped. In this scenario the bindAsUser()
method will return false resulting in an authentication failure. If I modify
the dn returned from getDistinquishedName() to only escape the last space in
the cn the bindAsUser() method will return true and the authentication will be
successful.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1849428 - /tomcat/native/trunk/native/Makefile.in
Author: csutherl Date: Thu Dec 20 18:48:22 2018 New Revision: 1849428 URL: http://svn.apache.org/viewvc?rev=1849428&view=rev Log: Copy header files into the includedir to match behavior of httpd's Makefile Modified: tomcat/native/trunk/native/Makefile.in Modified: tomcat/native/trunk/native/Makefile.in URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/Makefile.in?rev=1849428&r1=1849427&r2=1849428&view=diff == --- tomcat/native/trunk/native/Makefile.in (original) +++ tomcat/native/trunk/native/Makefile.in Thu Dec 20 18:48:22 2018 @@ -80,6 +80,7 @@ install: $(TARGET_LIB) $(APR_MKDIR) $(DESTDIR)$(includedir) $(DESTDIR)$(libdir)/pkgconfig \ $(DESTDIR)$(libdir) $(DESTDIR)$(bindir) $(INSTALL_DATA) tcnative.pc $(DESTDIR)$(libdir)/pkgconfig/$(TCNATIVE_PCFILE) + $(INSTALL_DATA) include/*.h $(DESTDIR)$(includedir) list='$(INSTALL_SUBDIRS)'; for i in $$list; do \ ( cd $$i ; $(MAKE) DESTDIR=$(DESTDIR) install ); \ done - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
tomcat-native include directory name
Hi all,
Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the
include directory instead of tomcat-native? I just pushed
http://svn.apache.org/r1849428 so that make now copies the header files
into _includedir, and noticed that the directory is named 'apr' rather than
'tomcat-native'.
$ grep includedir native/config.layout
includedir:${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
includedir:${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
includedir:${prefix}/include
includedir:${prefix}/include+
includedir:
/System/Library/Frameworks/apr.framework/Versions/2.0/Headers
includedir:${prefix}/include+
includedir:${prefix}/include/apr
includedir:${prefix}/include
includedir:${prefix}/include
includedir:${prefix}/include/apr
includedir:${exec_prefix}/include/apr
includedir:${exec_prefix}/include
includedir:${exec_prefix}/lib/apr/include
includedir:${exec_prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
Thanks,
Coty
[Bug 63022] Nio2Endpoint(SocketProcessorBase) for async request doesn't decrement LimitLatch while handling socket that is already closed
https://bz.apache.org/bugzilla/show_bug.cgi?id=63022 Pankaj changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #4 from Pankaj --- Thanks for the quick reply. I have applied the patch on tomcat 9.0.14, it resolves the bug and connectionCount does get decremented. Although I was not able to apply the same patch against 8.5.34 since Nio2Endpoint class has changed between releases. Changing bug state to new, please let me know if you need any other information. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1849311 - in /tomcat/trunk: java/org/apache/catalina/startup/LocalStrings.properties java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/startup/TestTomcat.java weba
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 12/19/18 14:14, Rémy Maucherat wrote: > On Wed, Dec 19, 2018 at 5:13 PM wrote: > >> Author: markt Date: Wed Dec 19 16:13:46 2018 New Revision: >> 1849311 >> >> URL: http://svn.apache.org/viewvc?rev=1849311&view=rev Log: Fix >> https://bz.apache.org/bugzilla/show_bug.cgi?id=54741 Add a new >> method, Tomcat.addWebapp(String,URL), that allows a web >> application to be deployed from a URL when using Tomcat in >> embedded mode. >> > > Another nice addition for Tomcat embedded ! Yeah, but of course it *still* won't allow me to deploy my WAR file from within a JAR file inside another WAR file from a web server with a file-URL proxy on it. When will the Tomcat devs stop being such a bunch of old codgers and support URL schemes like this: https://example.com/file://C:\TEMP\ALLAPPS.WAR!/deps/app1-contents.jar!/ ROOT.WAR Until this is implemented, Tomcat is basically garbage. Oh and there's no way in hell I'm going to escape all those characters in the URL. Tomcat can DIAF if it can't read URLs that normal humans can type and read. - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlwcVBQACgkQHPApP6U8 pFjmtw/+MjcYqvuq3Ctb69i3jeC5FBRcWb2aV7bAUVASBsRGXyi86j2K8Wla9png PjWPHLPYVmVkzX0ct/Bk3Xn8N3HU5zN+2FkaeDf/JHFj1sxL9ffFRYtiOIJn6SBT q1lEvebqukDRbMoEtUGSXywUzPhU0qDXR2etUlcQFY6F7K0l2F4+LB56jHMHgZjb OjXzRozRYOXRA+qFubXlUt/z64Bca5gP4bj6Z+2eX0fntMvCbXsXb7P8WNx6SKjh EQ82ZjtAJg5Rh08SqIEfEuG9NDa28pNQBbXgelBwV97SNKb/nJFWOtaDN4oN7foF lVawCI3jxMCp+f4SLduckyGFebUf4F5Pal0t7Kqoj1SOWycnmI3Grf8fB+xo1X3g yBWDdiGf+1oIsi99gWor/iYn5JvLJZ6Z4LCWSVBISOGZVtk08FMzk+z8+wrBbOSG mj2W+cwjTk1GqJRCNXKtrw+8nmPYhoTZkB+8n4VRiOLLJg6j4tkndLlD9fUWcdBN NWv6duiVrabNaK4PwE5IE+krOt3NE/tgIfHUTCZ4X30pYN5UjaDMP7JyWirZgSnp i6z0+UtY/igDoaTWomIwzrZnbaPi3/ghKbCTWqnv2UjAMLKwb9GnL41qZqxsyX1i I9fZLBt/izdxIroUBSMZ+X+pEUWLtr1PM1vcq+8jfYo0P08ZALM= =Vj28 -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63026] JNDIRealm fails to authenticate user with 2 trailing spaces CN
https://bz.apache.org/bugzilla/show_bug.cgi?id=63026 Christopher Schultz changed: What|Removed |Added OS||All --- Comment #1 from Christopher Schultz --- Sounds miserable. Any reason this user's username includes two – or even one – trailing space? Since you debugged so successfully, would you care to prepare a patch for the JNDIRealm? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] New committer: Woonsan Ko
Congratulations! Yuki On 2018/12/19 18:56, Mark Thomas wrote: > On behalf of the Tomcat committers I am pleased to announce that > Woonsan Ko (woonsan) has been voted in as a new Tomcat committer. > > Please join me in welcoming him. > > Kind regards, > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > -- 日本電信電話株式会社 ソフトウェアイノベーションセンタ OSS推進プロジェクト（NTT OSSセンタ） 応用技術ユニット Web担当 本橋 祐輝 〒108-8019 東京都港区港南1-9-1 NTT品川TWINS オフィス棟 11F TEL: 03-5860-5105 E-mail: motohashi.y...@lab.ntt.co.jp - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: svn commit: r1849311 - in /tomcat/trunk: java/org/apache/catalina/startup/LocalStrings.properties java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/startup/TestTomcat.java weba
> From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Subject: Re: svn commit: r1849311 - in /tomcat/trunk: > java/org/apache/catalina/startup/LocalStrings.properties > java/org/apache/catalina/startup/Tomcat.java > test/org/apache/catalina/startup/TestTomcat.java > webapps/docs/changelog.xml > Yeah, but of course it *still* won't allow me to deploy my WAR file > from within a JAR file inside another WAR file from a web server with > a file-URL proxy on it. > When will the Tomcat devs stop being such a bunch of old codgers and > support URL schemes like this: > https://example.com/file://C:\TEMP\ALLAPPS.WAR!/deps/app1-contents.jar!/ > ROOT.WAR > Until this is implemented, Tomcat is basically garbage. > Oh and there's no way in hell I'm going to escape all those characters > in the URL. Tomcat can DIAF if it can't read URLs that normal humans > can type and read. Looks like Bo hacked into Chris' head... - Chuck smime.p7s Description: S/MIME cryptographic signature
