Re: [Bug 63009] Content-Length header is dropped when HTTP2 is used
On 14/12/2018 22:30, Rémy Maucherat wrote: > On Fri, Dec 14, 2018 at 11:05 PM Caldarale, Charles R < > chuck.caldar...@unisys.com> wrote: > >>> From: Christopher Schultz [mailto:ch...@christopherschultz.net] >>> Subject: Re: [Bug 63009] Content-Length header is dropped when HTTP2 is >> used >> >>> Is this bad enough to pull and re-roll the latest 8.5.x release? >>> Missing Content-Type is ... pretty bad. >> >> The fix was for a missing (and optional) Content-Length, not Content-Type. >> Or did I miss something? >> > > Yes no panic, Chris probably misread the title. > > So ... I wanted to add I have nothing against the add even if it is > optional (like reason phrase :) ), since hpack should make that > addition as efficient as possible. Fair point. I did consider rejecting the bug but a little googling identified a number of reasons to provide the content-length including providing download progress information and more efficient caching. I guess it could be made configurable but I'm not sure that is worth the effort. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Deploying JK Site Docs
On 14/12/2018 18:18, Coty Sutherland wrote: > Thanks! > > On Fri, Dec 14, 2018 at 12:22 PM Mark Thomas wrote: > >> On 14/12/2018 17:16, Coty Sutherland wrote: >>> Hi, >>> >>> I made a bunch of changes to the JK site yesterday so that it uses the >>> updated Tomcat site's stylesheets to unify the UI between the two project >>> sites. >> >> A very welcome change. >> > > I noticed it was older and thought it would be pretty quick/easy to > update...I proved myself wrong on that one :) > > >> >>> Unfortunately, I can't figure out how to deploy it. The >>> HOWTO-RELEASE.txt doc says to copy the build/docs output >>> to people.apache.org:/x1/www/tomcat.apache.org/connectors-doc, but that >>> doesn't seem to exist anymore? Can anyone help me deploy these changes? >> Or >>> should I revert them and leave it be haha >> >> That is VERY out of date. >> > > Should that text file be removed? I haven't tried any of the other stuff, > but the docs in JK are way outdated in a lot of places (i.e. refs to httpd > 1.3 and Windows 98). JK goes back a loong way. Anything that can be done towards bringing them up to date has to be a good thing. Rather than delete that file, I'd suggest replacing the documentation with a reference to site/trunk/README.txt >> Try these instructions: >> https://svn.apache.org/viewvc/tomcat/site/trunk/README.txt?view=markup > > > That worked. After pushing I notice that I broke the links in the navbar, > so fixing that now. ACK. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 63009] Content-Length header is dropped when HTTP2 is used
On Sat, Dec 15, 2018 at 9:13 PM Mark Thomas wrote: > > So ... I wanted to add I have nothing against the add even if it is > > optional (like reason phrase :) ), since hpack should make that > > addition as efficient as possible. > > Fair point. > > I did consider rejecting the bug but a little googling identified a > number of reasons to provide the content-length including providing > download progress information and more efficient caching. > > I guess it could be made configurable but I'm not sure that is worth the > effort. > I'm 100% ok with it, no need for config. Rémy
