Re: [VOTE] Release Apache Tomcat 8.5.35
Hi, На сб, 3.11.2018 г. в 19:55 ч. Mark Thomas написа: > > The proposed Apache Tomcat 8.5.35 release is now available for voting. > > The major changes compared to the 8.5.34 release are: > > - support for TLSv1.3 when used with a JRE or OpenSSl version that > supports it > > - multiple improvements to the RewriteValve > > - correct several regressions in the JSP compiler > > > Along with lots of other bug fixes and improvements. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.35/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1197/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_35/ > > The proposed 8.5.35 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.35 +1 Regards, Violeta
Re: [VOTE] Release Apache Tomcat 8.5.35
I got two issues when building Tomcat 8.5.35 with OpenJDK 11 and OpenSSL 1.1.1 in Debian. 1. testClientCertPost and testClientCertGet in TestClientCertTls13 failed with the three NIO/NIO2/APR connectors: javax.net.ssl.SSLHandshakeException: Received fatal alert: protocol_version at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:128) at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:117) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:308) at java.base/sun.security.ssl.Alert$AlertConsumer.consume(Alert.java:279) at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:181) at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:164) at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1152) at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1063) at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:402) at java.base/sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:567) at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:185) at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:163) at org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:782) at org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:748) at org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:722) at org.apache.tomcat.util.net.TestClientCertTls13.testClientCertPost(TestClientCertTls13.java:75) 2. testAbortedUploadLimitedNoSwallow and testAbortedPOST413NoSwallow failed with NIO only: Testcase: testAbortedUploadLimitedNoSwallow took 0.106 sec FAILED Limited upload with swallow disabled does not generate client exception junit.framework.AssertionFailedError: Limited upload with swallow disabled does not generate client exception at org.apache.catalina.core.TestSwallowAbortedUploads.testAbortedUploadLimitedNoSwallow(TestSwallowAbortedUploads.java:130) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Testcase: testAbortedPOST413NoSwallow took 0.036 sec FAILED Limited upload with swallow disabled does not generate client exception junit.framework.AssertionFailedError: Limited upload with swallow disabled does not generate client exception at org.apache.catalina.core.TestSwallowAbortedUploads.testAbortedPOST413NoSwallow(TestSwallowAbortedUploads.java:176) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Emmanuel Bourg Le 03/11/2018 à 18:55, Mark Thomas a écrit : > The proposed Apache Tomcat 8.5.35 release is now available for voting. > > The major changes compared to the 8.5.34 release are: > > - support for TLSv1.3 when used with a JRE or OpenSSl version that > supports it > > - multiple improvements to the RewriteValve > > - correct several regressions in the JSP compiler > > > Along with lots of other bug fixes and improvements. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.35/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1197/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_35/ > > The proposed 8.5.35 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 8.5.35 > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.35
On 06/11/2018 09:28, Emmanuel Bourg wrote: > I got two issues when building Tomcat 8.5.35 with OpenJDK 11 > and OpenSSL 1.1.1 in Debian. > > 1. testClientCertPost and testClientCertGet in TestClientCertTls13 >failed with the three NIO/NIO2/APR connectors: > > javax.net.ssl.SSLHandshakeException: Received fatal alert: protocol_version I think some re-work is required around those tests to cover the various permutations and combinations. It isn't quite right at the moment. > 2. testAbortedUploadLimitedNoSwallow and testAbortedPOST413NoSwallow >failed with NIO only: > > Testcase: testAbortedUploadLimitedNoSwallow took 0.106 sec > FAILED > Limited upload with swallow disabled does not generate client exception > junit.framework.AssertionFailedError: Limited upload with swallow disabled > does not generate client exception > at > org.apache.catalina.core.TestSwallowAbortedUploads.testAbortedUploadLimitedNoSwallow(TestSwallowAbortedUploads.java:130) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > Testcase: testAbortedPOST413NoSwallow took 0.036 sec > FAILED > Limited upload with swallow disabled does not generate client exception > junit.framework.AssertionFailedError: Limited upload with swallow disabled > does not generate client exception > at > org.apache.catalina.core.TestSwallowAbortedUploads.testAbortedPOST413NoSwallow(TestSwallowAbortedUploads.java:176) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Interesting. I see those with 8.5.x as well but not with 9.0.x. More investigation required. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1845893 - in /tomcat/trunk/test/org/apache/tomcat/util/net: TestClientCertTls13.java TestSsl.java TesterSupport.java jsse/TesterBug50640SslImpl.java
Author: markt
Date: Tue Nov 6 11:16:48 2018
New Revision: 1845893
URL: http://svn.apache.org/viewvc?rev=1845893&view=rev
Log:
Make tests more robust when running with different JREs and APR/native
connectors built with different versions of OpenSSL.
Modified:
tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCertTls13.java
tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java
tomcat/trunk/test/org/apache/tomcat/util/net/TesterSupport.java
tomcat/trunk/test/org/apache/tomcat/util/net/jsse/TesterBug50640SslImpl.java
Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCertTls13.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCertTls13.java?rev=1845893&r1=1845892&r2=1845893&view=diff
==
--- tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCertTls13.java
(original)
+++ tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCertTls13.java Tue
Nov 6 11:16:48 2018
@@ -25,9 +25,7 @@ import org.junit.Test;
import org.apache.catalina.connector.Connector;
import org.apache.catalina.startup.Tomcat;
import org.apache.catalina.startup.TomcatBaseTest;
-import org.apache.tomcat.jni.SSL;
import org.apache.tomcat.util.buf.ByteChunk;
-import org.apache.tomcat.util.compat.TLS;
/**
* The keys and certificates used in this file are all available in svn and
were
@@ -42,13 +40,7 @@ public class TestClientCertTls13 extends
@Test
public void testClientCertGet() throws Exception {
-Assume.assumeTrue(TLS.isTlsv13Available());
Tomcat tomcat = getTomcatInstance();
-Connector connector = tomcat.getConnector();
-if (connector.getProtocolHandlerClassName().contains("Apr")) {
-Assume.assumeTrue(SSL.version() >= 0x1010100f);
-}
-
tomcat.start();
ByteChunk res = getUrl("https://localhost:"; + getPort() +
"/protected");
Assert.assertEquals("OK-" + TesterSupport.ROLE, res.toString());
@@ -56,13 +48,7 @@ public class TestClientCertTls13 extends
@Test
public void testClientCertPost() throws Exception {
-Assume.assumeTrue(TLS.isTlsv13Available());
Tomcat tomcat = getTomcatInstance();
-Connector connector = tomcat.getConnector();
-if (connector.getProtocolHandlerClassName().contains("Apr")) {
-Assume.assumeTrue(SSL.version() >= 0x1010100f);
-}
-
tomcat.start();
int size = 32 * 1024;
@@ -84,9 +70,12 @@ public class TestClientCertTls13 extends
Tomcat tomcat = getTomcatInstance();
+Connector connector = tomcat.getConnector();
+
Assume.assumeTrue(TesterSupport.isDefaultTLSProtocolForTesting13(connector));
+
TesterSupport.configureClientCertContext(tomcat);
// Need to override some of the previous settings
-tomcat.getConnector().setProperty("sslEnabledProtocols", "TLSv1.3");
+tomcat.getConnector().setProperty("sslEnabledProtocols",
Constants.SSL_PROTO_TLSv1_3);
// And add force authentication to occur on the initial handshake
tomcat.getConnector().setProperty("clientAuth", "required");
Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java?rev=1845893&r1=1845892&r2=1845893&view=diff
==
--- tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java Tue Nov 6
11:16:48 2018
@@ -39,7 +39,6 @@ import org.apache.catalina.startup.Teste
import org.apache.catalina.startup.Tomcat;
import org.apache.catalina.startup.TomcatBaseTest;
import org.apache.tomcat.util.buf.ByteChunk;
-import org.apache.tomcat.util.compat.TLS;
import org.apache.tomcat.websocket.server.WsContextListener;
/**
@@ -111,13 +110,13 @@ public class TestSsl extends TomcatBaseT
tomcat.start();
SSLContext sslCtx;
-if (TLS.isTlsv13Available()) {
+if
(TesterSupport.isDefaultTLSProtocolForTesting13(tomcat.getConnector())) {
// Force TLS 1.2 if TLS 1.3 is available as JSSE's TLS 1.3
// implementation doesn't support Post Handshake Authentication
// which is required for this test to pass.
-sslCtx = SSLContext.getInstance("TLSv1.2");
+sslCtx = SSLContext.getInstance(Constants.SSL_PROTO_TLSv1_2);
} else {
-sslCtx = SSLContext.getInstance("TLS");
+sslCtx = SSLContext.getInstance(Constants.SSL_PROTO_TLS);
}
sslCtx.init(null, TesterSupport.getTrustManagers(), null);
SSLSocketFactory socketFactory = sslCtx.getSocketFactory();
Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TesterSupport.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org
svn commit: r1845894 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/net/ test/org/apache/tomcat/util/net/jsse/
Author: markt Date: Tue Nov 6 11:25:57 2018 New Revision: 1845894 URL: http://svn.apache.org/viewvc?rev=1845894&view=rev Log: Make tests more robust when running with different JREs and APR/native connectors built with different versions of OpenSSL. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestClientCertTls13.java tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestSsl.java tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TesterSupport.java tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/jsse/TesterBug50640SslImpl.java Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Nov 6 11:25:57 2018 @@ -1,2 +1,2 @@ /tomcat/tc8.0.x/trunk:1809644 -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409 ,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747 404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1 756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205 3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,
svn commit: r1845896 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/util/net/TestClientCertTls13.java test/org/apache/tomcat/util/net/TestSsl.java test/org/apache/tomcat/util/net/TesterSupport.
Author: markt Date: Tue Nov 6 11:32:53 2018 New Revision: 1845896 URL: http://svn.apache.org/viewvc?rev=1845896&view=rev Log: Make tests more robust when running with different JREs and APR/native connectors built with different versions of OpenSSL. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/net/TestClientCertTls13.java tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/net/TestSsl.java tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/net/TesterSupport.java Propchange: tomcat/tc7.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Nov 6 11:32:53 2018 @@ -1,3 +1,3 @@ /tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988 ,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702 739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1 725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281 4,1803618,1806107,1806733,1807082-1807083,1808707,1808884,1809267,1809644,1809832,1809904,1809915,1809924,1810283,1810328,1810574,1810576-1810577,1810584,1810588,1811141,1811842,1812090,1812096,1812150,1812511,1814976,1814983,1815072,1815453,1815946,1815957,
svn commit: r1845897 - /tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestSwallowAbortedUploads.java
Author: markt
Date: Tue Nov 6 11:41:13 2018
New Revision: 1845897
URL: http://svn.apache.org/viewvc?rev=1845897&view=rev
Log:
Make test more robust. It now passes when running on Java 8 and Java 11.
Modified:
tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestSwallowAbortedUploads.java
Modified:
tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestSwallowAbortedUploads.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestSwallowAbortedUploads.java?rev=1845897&r1=1845896&r2=1845897&view=diff
==
---
tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestSwallowAbortedUploads.java
(original)
+++
tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestSwallowAbortedUploads.java
Tue Nov 6 11:41:13 2018
@@ -40,6 +40,7 @@ import org.junit.Test;
import org.apache.catalina.Context;
import org.apache.catalina.Wrapper;
+import org.apache.catalina.connector.Connector;
import org.apache.catalina.startup.SimpleHttpClient;
import org.apache.catalina.startup.Tomcat;
import org.apache.catalina.startup.TomcatBaseTest;
@@ -228,7 +229,7 @@ public class TestSwallowAbortedUploads e
private static final String URI = "/uploadAborted";
private static final String servletName = "uploadAborted";
private static final int limitSize = 100;
-private static final int hugeSize = 200;
+private static final int hugeSize = 1000;
private Context context;
@@ -252,8 +253,12 @@ public class TestSwallowAbortedUploads e
context.addServletMappingDecoded(URI, servletName);
context.setSwallowAbortedUploads(swallow);
+Connector c = tomcat.getConnector();
+c.setMaxPostSize(2 * hugeSize);
+c.setProperty("maxSwallowSize", Integer.toString(hugeSize));
+
tomcat.start();
-setPort(tomcat.getConnector().getLocalPort());
+setPort(c.getLocalPort());
}
private Exception doRequest(boolean limited, boolean swallow) {
@@ -344,7 +349,7 @@ public class TestSwallowAbortedUploads e
private static final String URI = "/uploadAborted";
private static final String servletName = "uploadAborted";
-private static final int hugeSize = 200;
+private static final int hugeSize = 1000;
private Context context;
@@ -362,7 +367,11 @@ public class TestSwallowAbortedUploads e
tomcat.start();
-setPort(tomcat.getConnector().getLocalPort());
+Connector c = tomcat.getConnector();
+c.setMaxPostSize(2 * hugeSize);
+c.setProperty("maxSwallowSize", Integer.toString(hugeSize));
+
+setPort(c.getLocalPort());
}
private Exception doRequest(int status, boolean swallow) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1845898 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/catalina/core/TestSwallowAbortedUploads.java
Author: markt Date: Tue Nov 6 11:41:48 2018 New Revision: 1845898 URL: http://svn.apache.org/viewvc?rev=1845898&view=rev Log: Refactor to avoid SpotBugs warning Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestSwallowAbortedUploads.java Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Nov 6 11:41:48 2018 @@ -1,2 +1,2 @@ /tomcat/tc8.0.x/trunk:1809644 -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409 ,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747 404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1 756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205 3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,1763529,1763559,1763565,1763568,1763574,17
svn commit: r1845899 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/catalina/connector/TestRequest.java test/org/apache/catalina/core/TestStandardContext.java test/org/apache/catalina/core/TestSwallow
Author: markt Date: Tue Nov 6 11:42:59 2018 New Revision: 1845899 URL: http://svn.apache.org/viewvc?rev=1845899&view=rev Log: Fix various tests that would break if stricter Host header validation was applied. (mainly applied to align 8.5.x with 9.0.x) Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/catalina/connector/TestRequest.java tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestStandardContext.java tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestSwallowAbortedUploads.java Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Nov 6 11:42:59 2018 @@ -1,2 +1,2 @@ /tomcat/tc8.0.x/trunk:1809644 -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409 ,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747 404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1 756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205 3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1
[Bug 62843] Tomcat Russian localization
https://bz.apache.org/bugzilla/show_bug.cgi?id=62843 --- Comment #2 from Ivan Krasnov --- Good day! I created a new class and package to localize the home page. However, I was never able to achieve the creation of a new .jar file for my package during the bulding phase. The home page is crashing because of this. I solved this problem by inserting my new class into an already existing package. Now everything works fine, index page completely internationalized. If you are not satisfied with this way of avoiding the ".jar "problem or are not satisfied with the package in which I added my class, I will try to do it differently. About Manager App - yes, there was a typo there, in my diff file i am correcting this mistake -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.35
On 06/11/2018 10:17, Mark Thomas wrote: > On 06/11/2018 09:28, Emmanuel Bourg wrote: >> I got two issues when building Tomcat 8.5.35 with OpenJDK 11 >> and OpenSSL 1.1.1 in Debian. >> >> 1. testClientCertPost and testClientCertGet in TestClientCertTls13 >>failed with the three NIO/NIO2/APR connectors: >> >> javax.net.ssl.SSLHandshakeException: Received fatal alert: protocol_version > > I think some re-work is required around those tests to cover the various > permutations and combinations. It isn't quite right at the moment. Should be fixed now. >> 2. testAbortedUploadLimitedNoSwallow and testAbortedPOST413NoSwallow >>failed with NIO only: > Interesting. I see those with 8.5.x as well but not with 9.0.x. More > investigation required. There were some robustness fixes in 9.0.x that had not been back-ported. I've just done that. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 62843] Tomcat Russian localization
https://bz.apache.org/bugzilla/show_bug.cgi?id=62843 --- Comment #3 from Ivan Krasnov --- Created attachment 36246 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36246&action=edit Home Page Localisation V1.1 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1845903 - /tomcat/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java
Author: markt
Date: Tue Nov 6 12:06:58 2018
New Revision: 1845903
URL: http://svn.apache.org/viewvc?rev=1845903&view=rev
Log:
Logging depends on ${catalina.base} so ensure it is created before logging is
configured
Modified:
tomcat/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java
Modified: tomcat/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java?rev=1845903&r1=1845902&r2=1845903&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java Tue Nov
6 12:06:58 2018
@@ -55,7 +55,7 @@ public abstract class LoggingBaseTest {
protected Log log;
-private File tempDir;
+private static File tempDir;
private List deleteOnTearDown = new ArrayList<>();
@@ -104,6 +104,16 @@ public abstract class LoggingBaseTest {
@BeforeClass
public static void setUpPerTestClass() throws Exception {
+// Create catalina.base directory
+File tempBase = new File(System.getProperty("tomcat.test.temp",
"output/tmp"));
+if (!tempBase.mkdirs() && !tempBase.isDirectory()) {
+Assert.fail("Unable to create base temporary directory for tests");
+}
+Path tempBasePath =
FileSystems.getDefault().getPath(tempBase.getAbsolutePath());
+tempDir = Files.createTempDirectory(tempBasePath, "test").toFile();
+
+System.setProperty("catalina.base", tempDir.getAbsolutePath());
+
// Configure logging
System.setProperty("java.util.logging.manager",
"org.apache.juli.ClassLoaderLogManager");
@@ -115,16 +125,6 @@ public abstract class LoggingBaseTest {
@Before
public void setUp() throws Exception {
-// Create catalina.base directory
-File tempBase = new File(System.getProperty("tomcat.test.temp",
"output/tmp"));
-if (!tempBase.mkdirs() && !tempBase.isDirectory()) {
-Assert.fail("Unable to create base temporary directory for tests");
-}
-Path tempBasePath =
FileSystems.getDefault().getPath(tempBase.getAbsolutePath());
-tempDir = Files.createTempDirectory(tempBasePath, "test").toFile();
-
-System.setProperty("catalina.base", tempDir.getAbsolutePath());
-
log = LogFactory.getLog(getClass());
log.info("Starting test case [" + testName.getMethodName() + "]");
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1845904 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/catalina/startup/LoggingBaseTest.java
Author: markt
Date: Tue Nov 6 12:07:27 2018
New Revision: 1845904
URL: http://svn.apache.org/viewvc?rev=1845904&view=rev
Log:
Logging depends on ${catalina.base} so ensure it is created before logging is
configured
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomcat/tc8.5.x/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java
Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Nov 6 12:07:27 2018
@@ -1,2 +1,2 @@
/tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,176
svn commit: r1845905 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/startup/LoggingBaseTest.java
Author: markt
Date: Tue Nov 6 12:09:16 2018
New Revision: 1845905
URL: http://svn.apache.org/viewvc?rev=1845905&view=rev
Log:
Logging depends on ${catalina.base} so ensure it is created before logging is
configured
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java
Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Nov 6 12:09:16 2018
@@ -1,3 +1,3 @@
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281
4,1803618,1806107,1806733,1807082-1807083,1808707,1808884,1809267,1809644,1809832,1809904,1809915,1809924,1810283,1810328,1810574,1810576-1810577,1810584,1810588,1811141,1811842,1812090,1812096,1812150,1812511,1814976,1814983,1815072,1815453,1815946,1815957,1816143,1816682,1817229,1817287,1820200,1820209,1820283,1820305,1821303-1821311,1821313,1821316,1821330,1821365,1822235,1823165,1823341,1823490,1823493,1823498,1824299,1824313,1825715,1
buildbot failure in on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3710 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch tomcat/trunk] 1845903 Blamelist: markt BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: libtcnative w/custom OpenSSL on MacOS
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/5/18 17:32, Mark Thomas wrote: > On 05/11/2018 19:48, Christopher Schultz wrote: >> On 11/5/18 13:05, Rainer Jung wrote: >>> Am 05.11.2018 um 18:44 schrieb Christopher Schultz: > > > What am I missing, here? >> >>> Try setting test.openssl.path in build.properties to the full >>> path to the openssl binary (.../bin/openssl). >> >>> See r1614560 and r1614587. >> >> Aha! That was it! >> >> I was confused because I was thinking that the version was being >> properly-detected by Tomcat. But the tests were using the >> "openssl ciphers" command to pull the lists of ciphers instead of >> doing it using JNI. >> >> Would it be worth it to use JNI to pull-back the list of >> supported ciphers instead of running an external command? > > The purpose of the tests is to ensure that the Tomcat code that > replicates OpenSSL's cipher selection behaves the same way as the > latest OpenSSL code. I don't see that it matters whether we > determine the OpenSSL behaviour via an external command or JNI. > > The upside is more consistent tests and one less build parameter > to configure. It also reduces potential confusion and unexpected failure. I didn't realize that the unit tests were launching "openssl" using the default shell PATH (which in my case obviously was running libressl's utility), and so there was confusion between the JVM's view of the world (through java.library.path) and Process.exec()'s view of the world (through $PATH). That may be splitting hairs mentioning that effect, but it's quite a thick piece of hair IMO. > The downside is APR/native becomes required for those tests. > Running those tests for all three connectors is fairly pointless so > only running them with APR might be an upside. > > I haven't checked to see if the API we'd need to use is accessible > via the current JNI API or whether we'd need to extend it. > > Is it worth it? For me this in the the category of it looks to be > a worthwhile itch to scratch if someone wants to scratch it. I'll have a look at what is available and what must be available in order to support it. On the up-side, the source code for the "ciphers" command[1] is mercifully short and easy to understand. - -chris [1] https://github.com/openssl/openssl/blob/master/apps/ciphers.c -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvhneoACgkQHPApP6U8 pFgBPQ//a3u1Dnl+aN7ZcHb+ziWlT31llONXr47CNj3CUXKjpDXxqcIq9LE8jJTV rZ3IG/A5HXj5ZpiOpivgIb/95X1whNKtzStoNqNkveZLL1s4PmIgP/4sKQG0NtKc qaqCul43Rrbss9Cd8n3ZEg056ACMTHL/h/5z5FWoJ3WABNJ5X9WMCTfayZWZq3pG OoYh1wsKPAxDPmzhl/yPqXU7eWmuWFQGfkHx23By6Yi2EbXSZXyzAFc2RTQd6RfU /C17R+Opo/2iCBjI/M4qCzyQPmP/IEOQzVZMPW1XZ439vp/jlPA912jCAmKiJpZD JCt+y6RTsqSVczYxsC/5WU467WcJRqJRG8pM3cXFeGZbUL+J7Fv3x3b+cJtwX2E4 zZbM3fNlJ8SQ3AuXvCKGMtthM9djE6fqWtk33G7F9hZRIlB7Y3sFugUslmF7EbZA DkHeOHoDb/GAWUfOq0DqJQWJp8NjV7pmFINtHmeOv3K2H1B/+ylMUFV3LxX27oCz 5GCeS36RkqUpj4DFz7O2EEzecMdwvgluAxQHKuG4/VY5QG6xtfXVv7aIkls7n6CP qifgYypa1FUea6/++L8bjtFmSq1TfzyilCgLibttmvzkKQ7MoWHM2ih4E2BsnuzY Ci/7E0ZVwchvCuCzPHxy+Yu/Nd7T1CWPchRVDsRLLH9ifJrg4l0= =UYUZ -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.35
Le 06/11/2018 à 12:44, Mark Thomas a écrit : > Should be fixed now. > There were some robustness fixes in 9.0.x that had not been back-ported. > I've just done that. I confirm it works, thank you. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.35
Le 03/11/2018 à 18:55, Mark Thomas a écrit : > The proposed 8.5.35 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.35 +1 Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.35
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Emmanuel, On 11/6/18 09:00, Emmanuel Bourg wrote: > Le 06/11/2018 à 12:44, Mark Thomas a écrit : > >> Should be fixed now. > >> There were some robustness fixes in 9.0.x that had not been >> back-ported. I've just done that. > > I confirm it works, thank you. Just to confirm: the problem was with the unit tests and not the server, right? - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvhoccACgkQHPApP6U8 pFi4wBAAjMvga7JEDDLbL6bq01gcOnhCH/Ky3GcC3tGU1y+33lOyYPC+eSBoaDOw M4FFzMxuF5ZGxKLq85IMEj6482Ney4UFkQpUB73ZAw3f+vOUoxWlQPuAc69lbzsv kpQmMSWFs+kS01L084I25/6HR6RZ77xOhu3T4bUYUgk6yPxPjRpZ4MSZ49okBKNS 0VI8IXVAgErhJTS416lT/KZ1hWp6khPnBsFtHURvbGC/Wn+yW4p9gFwRD0V646/P T0UcKFJ6+iyxyutcQCX1yPYiUPPKE+PbljVy/dICul9OrVHtrDubdCm08olVkkgE I2fvc+10WPWTJf73PyREZJDALmlgULk1GjHXRA+FkbV/So41vU7cIA7pe6j9F891 iFWUUQI3xZbLn80R2MnX0yz/FhwLSMKMNyzNBg3nyoNk8gbEd/D8c/xMsclOiZKi aDMEgPWyYpLppxfmMgPq6kGKUbpsbo4cnP7VQtYrAPWgAW7c6p/opCxrSgJb6O4B z3+Lop2N7msmLHqSct5Ecnj5wgJGuzwwAp8W0Y9gMwfJIrYLrWHBfiTrlTOIukDn d1Rwk8b92EBQfIIYWI+Cq8rRBqDYMwC/Ev4XjhQNTv4S0HGaMcD8FpJyJSA1S+MM /yDbnxTTVGnoZBq+DH0N6Kh3/UlIcm/MoHp/N//U9sGlyTUtB90= =iAg+ -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1845923 - /tomcat/trunk/test/org/apache/juli/TestFileHandlerNonRotatable.java
Author: markt
Date: Tue Nov 6 14:19:21 2018
New Revision: 1845923
URL: http://svn.apache.org/viewvc?rev=1845923&view=rev
Log:
Fix regression (NPE) caused by r1845903
Modified:
tomcat/trunk/test/org/apache/juli/TestFileHandlerNonRotatable.java
Modified: tomcat/trunk/test/org/apache/juli/TestFileHandlerNonRotatable.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/juli/TestFileHandlerNonRotatable.java?rev=1845923&r1=1845922&r2=1845923&view=diff
==
--- tomcat/trunk/test/org/apache/juli/TestFileHandlerNonRotatable.java
(original)
+++ tomcat/trunk/test/org/apache/juli/TestFileHandlerNonRotatable.java Tue Nov
6 14:19:21 2018
@@ -31,6 +31,8 @@ public class TestFileHandlerNonRotatable
@BeforeClass
public static void setUpPerTestClass() throws Exception {
+LoggingBaseTest.setUpPerTestClass();
+
System.setProperty("java.util.logging.manager",
"org.apache.juli.ClassLoaderLogManager");
String configLoggingPath = TestFileHandlerNonRotatable.class
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in on tomcat-7-trunk
The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1217 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-7-commit' triggered this build Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1845905 Blamelist: markt BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1845924 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/juli/TestFileHandlerNonRotatable.java
Author: markt Date: Tue Nov 6 14:20:39 2018 New Revision: 1845924 URL: http://svn.apache.org/viewvc?rev=1845924&view=rev Log: Fix regression (NPE) caused by r1845904 Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/juli/TestFileHandlerNonRotatable.java Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Nov 6 14:20:39 2018 @@ -1,2 +1,2 @@ /tomcat/tc8.0.x/trunk:1809644 -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409 ,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747 404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1 756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205 3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,1763529,1763559,1763565,1763568,1763574,17636
svn commit: r1845925 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/juli/TestFileHandlerNonRotatable.java
Author: markt Date: Tue Nov 6 14:21:49 2018 New Revision: 1845925 URL: http://svn.apache.org/viewvc?rev=1845925&view=rev Log: Fix regression (NPE) caused by r1845905 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/juli/TestFileHandlerNonRotatable.java Propchange: tomcat/tc7.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Nov 6 14:21:49 2018 @@ -1,3 +1,3 @@ /tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988 ,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702 739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1 725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281 4,1803618,1806107,1806733,1807082-1807083,1808707,1808884,1809267,1809644,1809832,1809904,1809915,1809924,1810283,1810328,1810574,1810576-1810577,1810584,1810588,1811141,1811842,1812090,1812096,1812150,1812511,1814976,1814983,1815072,1815453,1815946,1815957,1816143,1816682,1817229,1817287,1820200,1820209,1820283,1820305,1821303-1821311,1821313,1821316,1821330,1821365,1822235,1823165,1823341,1823490,1823493,1823498,1824299,1824313,1825715,1825874,1826367,1826379,1826690,1826830,1826874-182
Re: [VOTE] Release Apache Tomcat 8.5.35
On 06/11/2018 14:14, Christopher Schultz wrote: > Emmanuel, > > On 11/6/18 09:00, Emmanuel Bourg wrote: >> Le 06/11/2018 à 12:44, Mark Thomas a écrit : > >>> Should be fixed now. > >>> There were some robustness fixes in 9.0.x that had not been >>> back-ported. I've just done that. > >> I confirm it works, thank you. > > Just to confirm: the problem was with the unit tests and not the > server, right? Correct. It was a unit test bug. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.35
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/6/18 09:22, Mark Thomas wrote: > On 06/11/2018 14:14, Christopher Schultz wrote: >> Emmanuel, >> >> On 11/6/18 09:00, Emmanuel Bourg wrote: >>> Le 06/11/2018 à 12:44, Mark Thomas a écrit : >> Should be fixed now. >> There were some robustness fixes in 9.0.x that had not been back-ported. I've just done that. >> >>> I confirm it works, thank you. >> >> Just to confirm: the problem was with the unit tests and not the >> server, right? > > Correct. It was a unit test bug. +1 Confirmed myself on MacOS Mojave, JDK 11, 8.5.35 + back-ports for tests. + support. The whole unit test suite completes successfully in the above environmen t. - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvhqKgACgkQHPApP6U8 pFgLeg//a84sAqiq7/xBeFYBvI9lXapA+c+5dFLV2XTjQ6ZbwyFYJteeJJKco/kG FEB8wxdvTpnR7mLEk2orHlX1X/VnvGryiAPT9u5ohsfyvH9OIFUM5+GTxc7X+Sls 1UYyELgUHjw32pG5vo87ngAd6yOGEHiDthcCm6b20LEWkDl4J3yPCMKqLi7u+n9s HQq2q+1I5VNje1+0Y44qyfnnrfomhDxyawMBCe62q9mJqOXsQJnT3pryuoHpSwJm IV/fgCVq4lTF95rACCpX51xtnRJGbG/vgUjtHvxRRpEgkoDBCzVPyiW5z04TXRhE GkjrlDM88X91gYI8KemYnAFL6CleBXl2SAiI6ULfhbjfeunDmxucVwHBo6cNe5Wc pCNyTyHghqjfHEYYBX96Y7VcuUsbUbgDsz1BFd1D2/wg1nGX5tep4inQdbLnuTO/ MbxmLi8tntOY197nHA6MjK+PH3QpTRD3N551ljXZwSUwxE9InXx04SSseozjhrRp 3Y0ovqDJGMFx37sQL7UB4dFOxee/MazyHHdU61hbD5DaswkQLoo5YUzBq+Oupn1g KEn9K4ScViHPfQbdmlm+IgLw5p2MVsOS4BBGcReQ7+ig1hS7TpceQMw0QcWCFb7P 1vkd9qFkPb3OR+KOfg063osL88qAN8sq1ejRO2Bf1R8Hrlq7s6I= =QOeR -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3711 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch tomcat/trunk] 1845923 Blamelist: markt Build succeeded! Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1845929 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/catalina/startup/LoggingBaseTest.java
Author: markt Date: Tue Nov 6 14:59:22 2018 New Revision: 1845929 URL: http://svn.apache.org/viewvc?rev=1845929&view=rev Log: Fix Windows reporting files cannot be deleted when unit tests complete Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Nov 6 14:59:22 2018 @@ -1,2 +1,2 @@ /tomcat/tc8.0.x/trunk:1809644 -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409 ,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747 404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1 756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205 3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,1763529,176355
[Tomcat Wiki] Update of "Building Tomcat on MacOS" by ChristopherSchultz
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "Building Tomcat on MacOS" page has been changed by ChristopherSchultz:
https://wiki.apache.org/tomcat/Building%20Tomcat%20on%20MacOS?action=diff&rev1=4&rev2=5
Building Tomcat from source on MacOS can require some additional work,
especially if you want to build all of the optional items such as
{{{libtcnative}}}.
- == Building Tomcat==
+ == Building Tomcat ==
- Building Tomcat itself is fairly straightforward. Simply download the source
distribution of Tomcat and follow the indtructions in the BUILDING.txt file
bundled with the distribution.
+ Building Tomcat itself is fairly straightforward. Simply download the source
distribution of Tomcat and follow the instructions in the BUILDING.txt file
bundled with the distribution.
Briefly, you'll need:
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "Building Tomcat on MacOS" by ChristopherSchultz
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "Building Tomcat on MacOS" page has been changed by ChristopherSchultz:
https://wiki.apache.org/tomcat/Building%20Tomcat%20on%20MacOS?action=diff&rev1=5&rev2=6
While you can set {{{ld.library.path}}} to include libraries from all over
the place, I recommend that you copy everything into one place so you can
easily find everything and it won't interfere with anything else on your system.
First, copy the {{{libtcnative}}} binaries from where they were built:
+
{{{ $ cp -aR tomcat-native-x.y.z/native/.libs/*
apache-tomcat-x.y.z-src/output/build/bin/}}}
Next, copy the APR libraries:
- {{{ $ cp -a$ $APR_HOME/libexec/lib/*
apache-tomcat-x.y.z-src/output/build/bin/}}}
+ {{{ $ cp -aR $APR_HOME/libexec/lib/*
apache-tomcat-x.y.z-src/output/build/bin/}}}
Finally, if you are using a custom OpenSSL build, copy those libraries as
well:
- {{{ $ cp -a$ $OPENSSL_HOME/lib/* apache-tomcat-x.y.z-src/output/build/bin/}}}
+ {{{ $ cp -aR $OPENSSL_HOME/lib/* apache-tomcat-x.y.z-src/output/build/bin/}}}
== Running Tomcat with libtcnative ==
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Building (and running) Tomcat on MacOS
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Periodically, some folks ask how to get Tomcat running on MacOS. In order to fully-test the most recent version of Tomcat 8.5.x being voted on, I built a new environment on my Mac from scratch and documented everything. I put all of my notes into the Tomcat Wiki which can be found here: https://wiki.apache.org/tomcat/Building%20Tomcat%20on%20MacOS Comments and modifications are welcome. It would be even better if some folks with Macs who aren't running Tomcat would actually try following the instructions and let me know if anything in particular doesn't work for you. - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvhrc0ACgkQHPApP6U8 pFjGVA//XYi0+dnb1cmGGtrrZuXPHefRV2LiIf5VIHgQ1oZsiKleqadlsx7mYnD3 xwcR0Br9HU4x1z2o9a6JY6pdErLVxJSLsvXcBn0bhZAMe1TXXQk0VzxJo+zbTcQK Hh3S2XJDjA/U2cTs0z9FTT+mKvFxMUmI4ZnvBrmFXqQH5IgrMv5ajl20xhoKR899 K30q0J67YjzR42E7XCpBSRlPQhFrkVzXsIfublDc+M59riCisRC6M3cNG6CPGdO6 ArGVUCxTC+I0+ibdvuhUhWCC8YSm7sqn9/xUHEBhRta3ux+1LwCM1J4TijzOsPo0 AL3T+H1PElL+5jQXj6JQPcc5oRBfzNX04WJYEvoow3DaKUKX5/yqCVw6krdeGsTo gW0IhA/k2h5p6/g1IKZxjYIHkn2YQAUJtL+M7JopJp1xXYPI6xdorhlfylN/D1ms T+HgscItBWEG/o25Agydu6Wlpc8rIN0PIe1lMPFsfUHZf/PjUsj6f0+urnE0Cutx sIxvMBBzXd76PXYC8k5q50dQdaZONZdvGxHXBcRut4SwDSj9OAQf4R1DfIPcqEkl krF6Q04iuwAr6KewG57HkE3xh6kVbthPaVoXHVYmByBbRClZ6IpXRWax+Cvi/ROF AgvEV6Z+iQWwKMSX8nSNooifVOLvjZ9tVcI6fiBQLJAVHXeAsmo= =tqi1 -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Threads
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 10/15/18 10:49, Rémy Maucherat wrote: > Hi, > > Looking at threads since there's a proliferation of executors and > loose threads, I notice a possible refactoring: - > start/stopExecutor is an obvious target, but by default is not > there. However, it does not delegate to the parent container if not > there. - The background thread is a loose thread, if the > start/stopExecutor or whatever it is was a > ScheduledThreadPoolExecutor, then it can probably be refactored. - > Some executors in the clustering code, they could be run by that > "start/stopExecutor" of thir parent container. - As for the > catalina.Executor(s) in the Service, it could still wrap all this > stuff, *if* our ThreadPoolExecutor used a > ScheduledThreadPoolExecutor instead (at least as an option). > > So .. Options are: a) Do nothing. b) Merge everything except > catalina.Executor into a new ScheduledThreadPoolExecutor at the > Container level (and delegate to parent), so the Engine will have > it by default. Given how the background thread delay config and how > startStopThreads work, this can remain mostly compatible, except > some internal API from the start/stop executor is going to be > gone. c) Merge everything into one executor. Hopefully NIO2 users > remember they should give their connector its own executor. > > So personally, I think b) is nice as the Excecutor is more for > connector pools configuration and we shouldn't pollute that with > side uses. Is that doable in 9, or should it be added to the "10" > todo list ? > > Comments ? This reply is quite late, I'm sorry for that. I'm not sure if this has changed since a while back, but it used to be that an application could inadvertently kill the background thread. One way to do that would be to trigger OOME or StackOverflowError on the thread during some operation. An OOME that wasn't actually fatal for the JVM because the objects were all local to the thread and collectable once the exception was thrown. If the background thread died, sessions would no longer expire, which would eventually take everything down. If we are going to re-organize threads, I think it would be best if there were protections against the above scenario... basically, another thead watching the background threads. I think you get that already with an ExecutorService and a periodic job, so perhaps there isn't much to talk about. I just wanted to keep that in mind. Thanks, - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvhsLQACgkQHPApP6U8 pFhweRAAg3KnU+ThVhHMu+tKrXZwh7p7R4QmfokAIzLL08V1O1DW0fHtH+Z1KN0g PsCjoKulluGUa8ByhSVFHKbACXP6aD5LpFFB9dyZZsGkI1SeRPEzm37ptIkzl7lV /2wSydZ36XCb7+DoxUllgLu3lTT0FcoSXKWM3VcjjqeO2ChRUPJdygMpDUAfIcRo yVfXpnfbWND0r6b9OG3UpFES6vw3NWHf7YP7IuWiB6tA+P4kBAZ2poQ0V/8stVJm bbSu6t8sDH3jGGlMMmhpanSi9789IanyUi2hink/0MZwg25u8xqJly7Yz76nrwt6 +9shVGehBgZIHjEp9j77vePaigXXE9hK51j23Pk+98FEQ1PJiS5ZVZB8vag2d3Yq C7ROAzMmZGMh3ymLcwWQgBV/FL1h5YNpHqGyL7IiqnSQKynkMm/2DmDYVgPoxymC SwzLz2bPRHKMHIkqP20izj6lBo4KMHAFAqI7EFCeeCK7l/M2rGR0qeO/DrXwW0vd nZt+2f+5WXxsH5oH+GP19EKB1blT9T0yD5AV02dBeDcjkhO/3ZITw4+Lp8J38LVi 4mwlhSuodJVq1Ei6Ur3+LBBkPh6mBBnFChlJf0d2NmVwdNHhjfJuK4KnPIRvNdzk oNgpEVCC0It9csaz8O8JTFpifiyMfIjqDQDypTKUDUXkEr6Sw60= =1fzA -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in on tomcat-7-trunk
The Buildbot has detected a restored build on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1218 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-7-commit' triggered this build Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1845925 Blamelist: markt Build succeeded! Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Threads
On Tue, Nov 6, 2018 at 4:18 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > This reply is quite late, I'm sorry for that. > > I'm not sure if this has changed since a while back, but it used to be > that an application could inadvertently kill the background thread. > One way to do that would be to trigger OOME or StackOverflowError on > the thread during some operation. An OOME that wasn't actually fatal > for the JVM because the objects were all local to the thread and > collectable once the exception was thrown. > > If the background thread died, sessions would no longer expire, which > would eventually take everything down. > > If we are going to re-organize threads, I think it would be best if > there were protections against the above scenario... basically, > another thead watching the background threads. I think you get that > already with an ExecutorService and a periodic job, so perhaps there > isn't much to talk about. > The executor will deal with auto respawning up to its core threads, of course. Otherwise, at the moment, the behavior is the same as before: if an exception remains uncaught like your OOM or ThreadDeath or whatever, it will cancel the scheduling (and I haven't added the code to add it back). I have chosen to use scheduleWithFixedDelay (subtle tweaks can be made here: some of the calls could use scheduleAtFixedRate instead, maybe like the connector async timeout), and the javadoc says: If any execution of the task encounters an exception, subsequent executions are suppressed. So you think adding back the scheduling after a problem is better ? Rémy > > I just wanted to keep that in mind. > > Thanks, > - -chris > -BEGIN PGP SIGNATURE- > Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ > > iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvhsLQACgkQHPApP6U8 > pFhweRAAg3KnU+ThVhHMu+tKrXZwh7p7R4QmfokAIzLL08V1O1DW0fHtH+Z1KN0g > PsCjoKulluGUa8ByhSVFHKbACXP6aD5LpFFB9dyZZsGkI1SeRPEzm37ptIkzl7lV > /2wSydZ36XCb7+DoxUllgLu3lTT0FcoSXKWM3VcjjqeO2ChRUPJdygMpDUAfIcRo > yVfXpnfbWND0r6b9OG3UpFES6vw3NWHf7YP7IuWiB6tA+P4kBAZ2poQ0V/8stVJm > bbSu6t8sDH3jGGlMMmhpanSi9789IanyUi2hink/0MZwg25u8xqJly7Yz76nrwt6 > +9shVGehBgZIHjEp9j77vePaigXXE9hK51j23Pk+98FEQ1PJiS5ZVZB8vag2d3Yq > C7ROAzMmZGMh3ymLcwWQgBV/FL1h5YNpHqGyL7IiqnSQKynkMm/2DmDYVgPoxymC > SwzLz2bPRHKMHIkqP20izj6lBo4KMHAFAqI7EFCeeCK7l/M2rGR0qeO/DrXwW0vd > nZt+2f+5WXxsH5oH+GP19EKB1blT9T0yD5AV02dBeDcjkhO/3ZITw4+Lp8J38LVi > 4mwlhSuodJVq1Ei6Ur3+LBBkPh6mBBnFChlJf0d2NmVwdNHhjfJuK4KnPIRvNdzk > oNgpEVCC0It9csaz8O8JTFpifiyMfIjqDQDypTKUDUXkEr6Sw60= > =1fzA > -END PGP SIGNATURE- > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: Threads
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 11/6/18 11:06 AM, Rémy Maucherat wrote: > On Tue, Nov 6, 2018 at 4:18 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> This reply is quite late, I'm sorry for that. >> >> I'm not sure if this has changed since a while back, but it used >> to be that an application could inadvertently kill the background >> thread. One way to do that would be to trigger OOME or >> StackOverflowError on the thread during some operation. An OOME >> that wasn't actually fatal for the JVM because the objects were >> all local to the thread and collectable once the exception was >> thrown. >> >> If the background thread died, sessions would no longer expire, >> which would eventually take everything down. >> >> If we are going to re-organize threads, I think it would be best >> if there were protections against the above scenario... >> basically, another thead watching the background threads. I think >> you get that already with an ExecutorService and a periodic job, >> so perhaps there isn't much to talk about. >> > > The executor will deal with auto respawning up to its core threads, > of course. > > Otherwise, at the moment, the behavior is the same as before: if > an exception remains uncaught like your OOM or ThreadDeath or > whatever, it will cancel the scheduling (and I haven't added the > code to add it back). I have chosen to use scheduleWithFixedDelay > (subtle tweaks can be made here: some of the calls could use > scheduleAtFixedRate instead, maybe like the connector async > timeout) I think scheduleWithFixedDelay makes more sense. If an application ties-up the background thread, you could have multiple background threads running on top of each other. Theoretically, everything those threads are doing should be thread-safe, but I think it's probably best to have only one running at a time. > , and the javadoc says: If any execution of the task encounters an > exception, subsequent executions are suppressed. > > So you think adding back the scheduling after a problem is better > ? Yes, I think so. The container should protect itself from applications, and this is a case where a misbehaving application can break the correct operation of the container. - -chris >> I just wanted to keep that in mind. >> >> Thanks, - -chris -BEGIN PGP SIGNATURE- Comment: Using >> GnuPG with Thunderbird - https://www.enigmail.net/ >> >> iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvhsLQACgkQHPApP6U8 >> pFhweRAAg3KnU+ThVhHMu+tKrXZwh7p7R4QmfokAIzLL08V1O1DW0fHtH+Z1KN0g >> PsCjoKulluGUa8ByhSVFHKbACXP6aD5LpFFB9dyZZsGkI1SeRPEzm37ptIkzl7lV >> /2wSydZ36XCb7+DoxUllgLu3lTT0FcoSXKWM3VcjjqeO2ChRUPJdygMpDUAfIcRo >> yVfXpnfbWND0r6b9OG3UpFES6vw3NWHf7YP7IuWiB6tA+P4kBAZ2poQ0V/8stVJm >> bbSu6t8sDH3jGGlMMmhpanSi9789IanyUi2hink/0MZwg25u8xqJly7Yz76nrwt6 >> +9shVGehBgZIHjEp9j77vePaigXXE9hK51j23Pk+98FEQ1PJiS5ZVZB8vag2d3Yq >> C7ROAzMmZGMh3ymLcwWQgBV/FL1h5YNpHqGyL7IiqnSQKynkMm/2DmDYVgPoxymC >> SwzLz2bPRHKMHIkqP20izj6lBo4KMHAFAqI7EFCeeCK7l/M2rGR0qeO/DrXwW0vd >> nZt+2f+5WXxsH5oH+GP19EKB1blT9T0yD5AV02dBeDcjkhO/3ZITw4+Lp8J38LVi >> 4mwlhSuodJVq1Ei6Ur3+LBBkPh6mBBnFChlJf0d2NmVwdNHhjfJuK4KnPIRvNdzk >> oNgpEVCC0It9csaz8O8JTFpifiyMfIjqDQDypTKUDUXkEr6Sw60= =1fzA >> -END PGP SIGNATURE- >> >> - >> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >> > -BEGIN PGP SIGNATURE- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvh0dwACgkQHPApP6U8 pFjbpQ//Z6BYDq32e9jkprGSyKYXJG1DaUUhYALvoxXuUYwRu0B2HGk7SIgPWLIw hf8NOMzokRzwoTrnLRtrX1Z8C20KSVBPdIOCgXP0QcwRy0Zf/J29SWxeOq8aOrGp URem/6bx8tQA60hDV4vF0atxHbkwco20O4Z6TPwvf2P9MygBMqjZX/z632wraL+/ nWeTWfVXL6bfnrGRDEUwJvmrl/9zrhYixA5ENXih/COi+K+WIyHrpoLgis9AzZVy lEW7KNMOJdtERMMfbCgCQK4/BltCJoTTK1Ct0kk8aNqdH7inEME34qbrZFCumUr8 lXhkqMSxZF0QlJKBu15rUQI7oxGG9eZD6w2WpJ1jLvDv4onGGT1LJaUl+SGy8ZVC NaNNvcYsHIZfPHD6jPMiFwEogc/Vs4bJIwqCCr9QaeQ4ZFmW1/skWMunfCBn83kR pa2H0IvcJNk0lND0Y4fbE5qN4JQuBCMZ5d17a/bn1rEcUb9bUglo1ec3Q3Hl0wBz s+IrFOdTXybC6HPgfP9Xk7w4Nwzf59ZLPMllxGUqOCaslLoTku3TI9SZvrIb7BlL B1ixVhKOcBzoSRpp2ERFmf2eb3NxyIYmTj+E+WqpuzDbeE6TLKsegHy78UGk5ATS y39SmVPAF3HaEX39G3xwDQZKavG/A8+utzV8SVVebQBmUmZ19DQ= =jXKM -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Does there exist a download URL that will redirect me to a mirror?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Does ASF host a web service that I can hit that requests a download of a particular resource, but first to redirect to a mirror? If I go to e.g. https://tomcat.apache.org/download-90.cgi, I'll get a bunch of links that point to a randomly-chosen mirror, but what I'd like to do is request e.g. https://tomcat.apache.org/download/tomcat-9/v9.0.12/bin/apache-tomcat-9. 0.12.zip and get a redirect to e.g.: http://ftp.naz.com/apache/tomcat/tomcat-9/v9.0.12/bin/apache-tomcat-9.0. 12.zip Does anything like that exist? If not, is it something worth building? I'm asking because I'd like to start scripting the release-builds, and it would be nice to fetch things like e.g. subversion with a well-known URL but not always hitting ASF directly (because mirrors are great!). Thanks, - -chris -BEGIN PGP SIGNATURE- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvh6l8ACgkQHPApP6U8 pFitjA//bcgpFe8JryxdQnzF2BRlqrz1L2wGEkUM+EJY982Z+MgrGwNdJp8cJgNc FlSH6cGji5U97rBVgOrWLmuElNJK7+JSXAO225pITS/S2/MmhK1GuR/qo6Ujw6Y4 d22jY+SqQJDMZ9Q2yGLeO1fvseErgvkPj9BuRFLAHXLCGll3U6mRQEKFTnQBzbGb qI2aXcZdHUovaHP+VNAvrbhReQ8NQOwHKsSwS44Jc8gc73Y5ADoHt4lrLghS2IXa b3VBQkmKP+H7My2DVsh3sbPHCTdHinM7K6cE9aHa7UPEgF+ZO+hELGnqCKvTL66w De30pudwYXG+dfg+CJVPPTE7q6VfRvxKNEIUOnitlLQQILEQYv+wnoITyAPx3xwN eIx9HQhoJUyikheMRWO174ErfomDzE+YxhKnNH9soQSiKSAKx9YGaSX38EjB0Ym8 Qz4e+ZJZtO5ZO7Yw4BYr9t5vqiLJcaEglsJ70QsoyQnJbxiDKhTr+EADoVhxewy8 EkKwyeoGlmiEmHIiCZ/2W21I/Ka4B1L4J5aJU6HDVbK0oWirDqGQvDgvJeBhbzlC FRfA/8JjlX7JwjVUEi2eCeHrctc7sPMs3Fkk7PIpxXxUF6JRY9lYhUK++Y4Syuox pLIcltmqW1frckPgq04SpkAvpN8tXhGE1OPHO09zgFHV9EVba3A= =WVUh -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Does there exist a download URL that will redirect me to a mirror?
On 06/11/2018 19:24, Christopher Schultz wrote: > All, > > Does ASF host a web service that I can hit that requests a download of > a particular resource, but first to redirect to a mirror? Look at the Tomcat 9 build script. In particular, the entry for base-apache.loc.1 in build.properties.default Mark > > If I go to e.g. https://tomcat.apache.org/download-90.cgi, I'll get a > bunch of links that point to a randomly-chosen mirror, but what I'd > like to do is request e.g. > > > https://tomcat.apache.org/download/tomcat-9/v9.0.12/bin/apache-tomcat-9. > 0.12.zip > > and get a redirect to e.g.: > > > http://ftp.naz.com/apache/tomcat/tomcat-9/v9.0.12/bin/apache-tomcat-9.0. > 12.zip > > Does anything like that exist? > > If not, is it something worth building? > > I'm asking because I'd like to start scripting the release-builds, and > it would be nice to fetch things like e.g. subversion with a > well-known URL but not always hitting ASF directly (because mirrors > are great!). > > Thanks, > -chris > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Release script for Tomcat 8.5.x
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I've been working this afternoon on a Powershell script to do pretty much everything for a release. I chose Powershell because (a) I will have to operate on Windows for releases until I get NSIS working elsewhere and (b) batch scripts are The Worst. Starting with The Process[1], I have everything working up through actually invoking "ant release". It's downloading everything it needs (except Java... grr Oracle), exporting from svn, etc. The Process says to use the latest release of the minimum Java version supported by the release. For 8.5.x, that means Java 7, but Java 7 has been EOL'd. So... should I grab an old Java 7 JDK for building the release, or should I use the latest supported version, which is Java 8? I haven't yet dealt with the GnuPG key management... I'm not sure the best way to do that at this point. I think for now, I'll just have toe script stop and say "please install your private key in [file]" to continue and then proceed when it's in place. It doesn't yet do any of the "preliminaty checks" and it doesn't create svn tags. It's not parameterized yet so it's all hard-coded for the 8.5.35 release and its dependencies (e.g. ant) are all version-dependent at this point as well. Once I extract the script from the Windows 10 VM I'm running it in and verify that it's actually runnable from a fresh box, I'll post it here for anyone to look at. I'll probably put it on GitHub in this general area https://github.com/ChristopherSchultz/apache-tomcat-stuff/tree/master/bi n If it makes sense to do so, we could even put it into svn, which is a bit of Inception. - -chris [1] https://wiki.apache.org/tomcat/ReleaseProcess -BEGIN PGP SIGNATURE- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlviGq0ACgkQHPApP6U8 pFisXg/+M1fiL0NCfQkldmx8Evfbdui0eU8tyauEqhir6IAQc6SZSyo1RpGa6iI/ /bSHj3HiSMX7C8zWg6E4aF2t3TLHP5wVjKwgIx16Vo7+9DPGcSZcmnWO3uAUbfRQ ZnKGN33sMiuObknF2BcBindP/KzpHuAg+avvuQdaZhUAsAeWemFgZXhDUcEfAFge sueptYh3JMrGKOl4XRq13MawoUKv9zqBUiTExVHvNHjo9y8sn8InIelw7g/BN4W2 cocKeMjYdCzcF+yYdqUkRrIL8ZyCOipZWidstaRv64G452xh+ZWDu81eRXaGAxBE s0WEMVtAYhHJ1P/23QteYtaXiW4Eyu3aUEiaYEdBy5qzfkzwANKNzuxD58Di9Ior F/5KmgIlDJEOrs2aAiWTAV5J8hhjcKewHU5lLjOh/qaaLaW07/R8j18oyUhLIbsB LWgVNXeF4P70N6gxjfKI2vyTJkP0XO7czLoDFP7QVPreXzvVC2zRl6Ry9JnSZV4m nf+3fvb4KkDX3ajftImS3/B1pAIsE7FOCUQF1kWJ0/2FaVEiO7DymVQeRbdNxsOf l5j4+wk2UYxUMbc6SRPMRnFn8iw9wystJSKDLqZ5TgKCj65XeJxck+Sf0XbPjzzQ 2j9VyK1E4HuzU6By2x3jLvBeYXDOhYcn/1bLyM/JUQzwSkDtPVY= =IbVx -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Threads
On Tue, Nov 6, 2018 at 6:39 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > > Otherwise, at the moment, the behavior is the same as before: if > > an exception remains uncaught like your OOM or ThreadDeath or > > whatever, it will cancel the scheduling (and I haven't added the > > code to add it back). I have chosen to use scheduleWithFixedDelay > > (subtle tweaks can be made here: some of the calls could use > > scheduleAtFixedRate instead, maybe like the connector async > > timeout) > > I think scheduleWithFixedDelay makes more sense. If an application > ties-up the background thread, you could have multiple background > threads running on top of each other. Theoretically, everything those > threads are doing should be thread-safe, but I think it's probably > best to have only one running at a time. > scheduleAtFixedRate does not concurrently execute, it is possible it runs late. Also, the container background threads are exclusive (they avoid entering a container which has one enabled too). As a result, it should be ok. I think scheduleAtFixedRate is only good for that async timeout though. > > > , and the javadoc says: If any execution of the task encounters an > > exception, subsequent executions are suppressed. > > > > So you think adding back the scheduling after a problem is better > > ? > > Yes, I think so. The container should protect itself from > applications, and this is a case where a misbehaving application can > break the correct operation of the container. > Ok, so it's harder, there's no API for it. I'll try to find a good solution. Rémy
[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-nio : Tomcat 9.x, a web server implementing the Java Servlet 4.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-NIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs -WARNING- No directory [/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs] The following work was performed: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build) Work ended in a state of : Failed Elapsed: 23 mins 43 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar -Dtest.reports=output/logs-NIO -Dexecute.test.nio2=false -Dexamples.sources.skip=true -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20181107/bin/openssl -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true -Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar -Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true -Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-4.1-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu ild/lib/tomcat-jni
RE: Release script for Tomcat 8.5.x
> From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Subject: Release script for Tomcat 8.5.x > It's downloading everything it needs (except Java... grr Oracle), > exporting from svn, etc. > The Process says to use the latest release of the minimum Java version > supported by the release. For 8.5.x, that means Java 7, but Java 7 has > been EOL'd. So... should I grab an old Java 7 JDK for building the > release, or should I use the latest supported version, which is Java 8? What about using the reference implementations available at jdk.java.net (e.g., https://jdk.java.net/java-se-ri/7)? These are GPLv2, so shouldn't have the licensing problems the current Oracle ones do. - Chuck THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus for use only by the intended recipient. If you received this in error, please contact the sender and delete the e-mail and its attachments from all computers. smime.p7s Description: S/MIME cryptographic signature
