date:20181029

On 29/10/18 00:50, Bill Barker wrote:
> To whom it may engage...
> 
> This is an automated request, but not an unsolicited one. For 
> more information please visit http://gump.apache.org/nagged.html, 
> and/or contact the folk at gene...@gump.apache.org.
> 
> Project tomcat-native-1.2-1.1.0-configure has an issue affecting its 
> community integration.
> This issue affects 3 projects,
>  and has been outstanding for 58 runs.

Hmm. Not sure where Gump got the '58 runs' figure from.

Anyway... the failure is caused by the failure of the OpenSSL 1.1.0
build which caused the Native build to fall back to the system OpenSSL
which is too old.

The OpenSSL 1.1.0 failure looks to be caused by an error in the
back-port for the fix for CVE-2018-0735 which I have reported to the
OpenSSL project.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: "Embedded" improvements

On Wed, Oct 24, 2018 at 11:54 AM Rémy Maucherat  wrote:

> Hi,
>
> I'm starting to review embedded. Maybe I won't make many changes in the
> end and won't need a separate API.
>
> However, I have another post 9.0.13 refactoring with a redoing of
> ConfigFileLoader and various places which try to load the configuration
> from seemingly random locations (the winner is "server-embed.xml", which
> IMO everyone forgot about aeons ago). So this redoes it with a pluggable
> API as ConfigFileLoader was not. Minor additional work is needed to use it
> in more places, since all configuration/resource loading from conf would
> need to go through it (ideally) (and except logging, since it's obviously
> pluggable enough).
>
>
> https://github.com/rmaucher/tomcat/commit/c386eb2fc3b2f42b3a307cbc2d0ab1a72581f56a
>
> Comments ?
>

I think I'm done (?) with the review. Even if not super modern, the
"Tomcat" class provides useful methods and ways to deploy your app embedded.
However, the process of configuring a Tomcat with code (and maintaining it)
is way way too involving (even for "basic" needs), and then degrades into
(partially) reinventing the code config files like the obvious server.xml.
So instead this new API allows providing that server.xml (and most others)
to the Tomcat class and then use its methods to do what you need to fill
the blanks and manage the lifecycle of the embedded server.

Not covered by the pluggability:
- jaspic uses load/store a bit too much, it would still need its regular
config file
- storeconfig
- other items that need files (OpenSSL, cloud)
- anything else I missed

Still at https://github.com/rmaucher/tomcat/commits/trunk

And the plan is still to add it post 9.0.13.

Rémy

svn commit: r1845099 - /tomcat/trunk/test/webapp/WEB-INF/test.tld

Author: markt
Date: Mon Oct 29 10:53:01 2018
New Revision: 1845099

URL: http://svn.apache.org/viewvc?rev=1845099&view=rev
Log:
Add missing word.
Reflow.
Based on a patch provided by mdfst13
This fixes #128

Modified:
tomcat/trunk/test/webapp/WEB-INF/test.tld

Modified: tomcat/trunk/test/webapp/WEB-INF/test.tld
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp/WEB-INF/test.tld?rev=1845099&r1=1845098&r2=1845099&view=diff
==
--- tomcat/trunk/test/webapp/WEB-INF/test.tld (original)
+++ tomcat/trunk/test/webapp/WEB-INF/test.tld Mon Oct 29 10:53:01 2018
@@ -43,8 +43,8 @@
   
 toArray
 org.apache.el.TesterFunctions
-
+
 
   java.lang.String toArray(java.lang.String,
java.lang.String)
@@ -54,8 +54,8 @@
   
 toArrayB
 org.apache.el.TesterFunctions
-
+
 
   java.lang.String toArray (java.lang.String,java.lang.String)
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #128: Add missing word for readability

2018-10-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/tomcat/pull/128


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845100 - in /tomcat/tc8.5.x/trunk: ./ test/webapp/WEB-INF/test.tld

Author: markt
Date: Mon Oct 29 10:53:47 2018
New Revision: 1845100

URL: http://svn.apache.org/viewvc?rev=1845100&view=rev
Log:
Add missing word.
Reflow.
Based on a patch provided by mdfst13

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/test/webapp/WEB-INF/test.tld

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Oct 29 10:53:47 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 
3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,1763529,1763559,1763565,1763568,1763574,1763619

svn commit: r1845101 - in /tomcat/tc7.0.x/trunk: ./ test/webapp-3.0/WEB-INF/test.tld

Author: markt
Date: Mon Oct 29 10:56:40 2018
New Revision: 1845101

URL: http://svn.apache.org/viewvc?rev=1845101&view=rev
Log:
Add missing word.
Reflow.
Based on a patch provided by mdfst13

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/test/webapp-3.0/WEB-INF/test.tld

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Oct 29 10:56:40 2018
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281
 
4,1803618,1806107,1806733,1807082-1807083,1808707,1808884,1809267,1809644,1809832,1809904,1809915,1809924,1810283,1810328,1810574,1810576-1810577,1810584,1810588,1811141,1811842,1812090,1812096,1812150,1812511,1814976,1814983,1815072,1815453,1815946,1815957,1816143,1816682,1817229,1817287,1820200,1820209,1820283,1820305,1821303-1821311,1821313,1821316,1821330,1821365,1822235,1823165,1823341,1823490,1823493,1823498,1824299,1824313,1825715,1825874,1826367,1826379,1826690,1826830,1826874-1

[GitHub] tomcat issue #125: Provide port offset functionality (BZ-61171)

2018-10-29 Thread markt-asf

Github user markt-asf commented on the issue:

https://github.com/apache/tomcat/pull/125
  
I've now spent some time looking at this more closely.

I like the idea of setting this once on the `Server` and then 
auto-magically setting this on the `Connector`s.

As I reviewed this, I noticed that we are still setting the port in 
multiple places. That seems wrong to me as it creates the possibility of having 
inconsistent settings. I am leaning towards refactoring `port` in the 
`Connector` so it always delegates to the `Endpoint`. `portOffset` would then 
be handled the same way.

I am a little concerned about having `portOffset` on the `Server` and the 
`Connector`. Again, there is scope there for the settings to become 
inconsistent. However, I don't see any easy way around that.

Finally, I am still mulling over the extent to which the currently used 
port is exposed as `portWithOffset` and when `port` and `offset` are exposed 
separately. I'm leaning towards a wider use of `portWithOffset` and separate 
log messages that provide `portWithOffset`, `port` and `offset`.

My current plan is to refactor port as describe above and then start to 
integrate this patch. I'm expecting to tweak a few things as I go and I'm still 
aiming for inclusion in 9.0.13. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #125: Provide port offset functionality (BZ-61171)

2018-10-29 Thread m-czernek

Github user m-czernek commented on the issue:

https://github.com/apache/tomcat/pull/125
  
@markt-asf I'll check your review into a lot more detail later, possibly 
tonight, but at this moment:

- You set `portOffset` on Server
- All connectors are offset

There is no portOffset on individual Connectors. When each connector gets 
initialized, it starts with `portWithOffset`, basically `port` and `offset` 
being exposed for legacy reasons. 

You suggest to provide `offset` for individual connectors as well? Because 
for that, we don't have to have a portOffset, we can just change the ports 
manually :). I think I'm just misunderstanding here; I'll have to check out the 
`Connector` <-> `Endpoint` relationship.

This is, by the way, in line with Wildfly, where you set one property with 
'portOffset' (or you specify it in the upper-most xml element of socket binding 
group) and all the ports get offset. Another possible, and very simple, 
solution is also to include in the default configuration some system property, 
that will be simply added to all ports if the property is set. Or, simply add 
the property value to all port numbers if the property exists... 


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845133 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/TokenStreamProvider.java

2018-10-29 Thread remm

Author: remm
Date: Mon Oct 29 14:50:17 2018
New Revision: 1845133

URL: http://svn.apache.org/viewvc?rev=1845133&view=rev
Log:
Code cleanup.

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/TokenStreamProvider.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/TokenStreamProvider.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/TokenStreamProvider.java?rev=1845133&r1=1845132&r2=1845133&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/TokenStreamProvider.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/TokenStreamProvider.java
 Mon Oct 29 14:50:17 2018
@@ -83,25 +83,20 @@ public class TokenStreamProvider extends
 
 private TrustManager[] configureCaCert(String caCertFile) throws Exception 
{
 if (caCertFile != null) {
-try {
-InputStream pemInputStream = new BufferedInputStream(new 
FileInputStream(caCertFile));
-try {
-CertificateFactory certFactory = 
CertificateFactory.getInstance("X509");
-X509Certificate cert = 
(X509Certificate)certFactory.generateCertificate(pemInputStream);
+try (InputStream pemInputStream = new BufferedInputStream(new 
FileInputStream(caCertFile))) {
+CertificateFactory certFactory = 
CertificateFactory.getInstance("X509");
+X509Certificate cert = 
(X509Certificate)certFactory.generateCertificate(pemInputStream);
 
-KeyStore trustStore = KeyStore.getInstance("JKS");
-trustStore.load(null);
+KeyStore trustStore = KeyStore.getInstance("JKS");
+trustStore.load(null);
 
-String alias = cert.getSubjectX500Principal().getName();
-trustStore.setCertificateEntry(alias, cert);
+String alias = cert.getSubjectX500Principal().getName();
+trustStore.setCertificateEntry(alias, cert);
 
-TrustManagerFactory trustManagerFactory = 
TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm());
-trustManagerFactory.init(trustStore);
+TrustManagerFactory trustManagerFactory = 
TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm());
+trustManagerFactory.init(trustStore);
 
-return trustManagerFactory.getTrustManagers();
-} finally {
-pemInputStream.close();
-}
+return trustManagerFactory.getTrustManagers();
 } catch (FileNotFoundException fnfe) {
 log.error(sm.getString("tokenStream.fileNotFound", 
caCertFile));
 throw fnfe;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845134 - /tomcat/trunk/test/org/apache/catalina/tribes/membership/cloud/TestKubernetesJson.java

2018-10-29 Thread remm

Author: remm
Date: Mon Oct 29 14:51:28 2018
New Revision: 1845134

URL: http://svn.apache.org/viewvc?rev=1845134&view=rev
Log:
Replace with real json test, more to come eventually (that helped sort out what 
was standard and others like "kind" which are pretty much optional).

Modified:

tomcat/trunk/test/org/apache/catalina/tribes/membership/cloud/TestKubernetesJson.java

Modified: 
tomcat/trunk/test/org/apache/catalina/tribes/membership/cloud/TestKubernetesJson.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/membership/cloud/TestKubernetesJson.java?rev=1845134&r1=1845133&r2=1845134&view=diff
==
--- 
tomcat/trunk/test/org/apache/catalina/tribes/membership/cloud/TestKubernetesJson.java
 (original)
+++ 
tomcat/trunk/test/org/apache/catalina/tribes/membership/cloud/TestKubernetesJson.java
 Mon Oct 29 14:51:28 2018
@@ -28,54 +28,259 @@ import org.apache.catalina.tribes.member
 
 public class TestKubernetesJson extends KubernetesMembershipProvider {
 
-private static final String JSON_POD_LIST = "{\n" +
-"  \"kind\": \"List\",\n" +
-"  \"apiVersion\": \"v1\",\n" +
-"  \"items\": [\n" +
-"{\n" +
-"  \"kind\": \"Pod\",\n" +
-"  \"apiVersion\": \"v1\",\n" +
-"  \"metadata\": {\n" +
-"\"name\": \"test_pod\",\n" +
-"\"namespace\": \"default\",\n" +
-"\"selfLink\": \"/api/v1/pods/foo\",\n" +
-"\"uid\": \"748932794874923\",\n" +
-"\"resourceVersion\": \"23\",\n" +
-"\"creationTimestamp\": \"2018-10-02T09:14:01Z\"\n" +
-"  },\n" +
-"  \"status\": {\n" +
-"\"phase\": \"Running\",\n" +
-"\"podIP\": \"192.168.0.2\"\n" +
-"  }\n" +
-"},\n" +
-"{\n" +
-"  \"kind\": \"Pod\",\n" +
-"  \"apiVersion\": \"v1\",\n" +
-"  \"metadata\": {\n" +
-"\"name\": \"test_pod_2\",\n" +
-"\"namespace\": \"default\",\n" +
-"\"selfLink\": \"/api/v1/pods/foo2\",\n" +
-"\"uid\": \"7489327944322341414923\",\n" +
-"\"resourceVersion\": \"18\",\n" +
-"\"creationTimestamp\": \"2018-10-01T09:14:01Z\"\n" +
-"  },\n" +
-"  \"status\": {\n" +
-"\"phase\": \"Running\",\n" +
-"\"podIP\": \"192.168.0.3\"\n" +
-"  }\n" +
-"}\n" +
-"  ]\n" +
-"}";
+private static final String OPENSHIFT_JSON_POD_LIST = "{\n"
++ "  \"kind\": \"PodList\",\n" + "  \"apiVersion\": \"v1\",\n"
++ "  \"metadata\": {\n"
++ "\"selfLink\": 
\"/api/v1/namespaces/tomcat-in-the-cloud/pods\",\n"
++ "\"resourceVersion\": \"1120453180\"\n" + "  },\n"
++ "  \"items\": [\n" + "{\n" + "  \"metadata\": {\n"
++ "\"name\": \"tomcat-in-the-cloud-5bc6dc7cf8-ndpdm\",\n"
++ "\"generateName\": 
\"tomcat-in-the-cloud-5bc6dc7cf8-\",\n"
++ "\"namespace\": \"tomcat-in-the-cloud\",\n"
++ "\"selfLink\": 
\"/api/v1/namespaces/tomcat-in-the-cloud/pods/tomcat-in-the-cloud-5bc6dc7cf8-ndpdm\",\n"
++ "\"uid\": \"29cc7dec-cc8d-11e8-943e-02ec8e61afcf\",\n"
++ "\"resourceVersion\": \"1120373053\",\n"
++ "\"creationTimestamp\": \"2018-10-10T13:05:29Z\",\n"
++ "\"labels\": {\n"
++ "  \"pod-template-hash\": \"1672873794\",\n"
++ "  \"run\": \"tomcat-in-the-cloud\"\n" + "},\n"
++ "\"annotations\": {\n"
++ "  \"kubernetes.io/limit-ranger\": \"LimitRanger plugin 
set: cpu, memory request for container tomcat-in-the-cloud; cpu, memory limit 
for container tomcat-in-the-cloud\",\n"
++ "  \"openshift.io/scc\": \"restricted\"\n"
++ "},\n" + "\"ownerReferences\": [\n"
++ "  {\n" + "\"apiVersion\": \"apps/v1\",\n"
++ "\"kind\": \"ReplicaSet\",\n"
++ "\"name\": \"tomcat-in-the-cloud-5bc6dc7cf8\",\n"
++ "\"uid\": 
\"12c4fa68-cc8d-11e8-943e-02ec8e61afcf\",\n"
++ "\"controller\": true,\n"
++ "\"blockOwnerDeletion\": true\n" + "  }\n"
++ "]\n" + "  },\n" + "  \"spec\": {\n"
++ "\"volumes\": [\n" + "  {\n"
++ "\"name\": \"default-token-n87wf\",\n"
++ "\"secret\": {

[GitHub] tomcat issue #125: Provide port offset functionality (BZ-61171)

2018-10-29 Thread isapir

Github user isapir commented on the issue:

https://github.com/apache/tomcat/pull/125
  
> Another possible, and very simple, solution is also to include in the 
default configuration some system property, that will be simply added to all 
ports if the property is set. Or, simply add the property value to all port 
numbers if the property exists...

I think that in general we avoid System properties, but for this feature it 
might make sense - the reason being that this feature is mostly useful in 
environments where there are many different instances of Tomcat, and in those 
cases the deployment is scripted.

For example, one of the organizations that I advise has about 200 instances 
of Tomcat, all deployed in the same manner, so a script generates all of the 
CATALINA_BASE directories, and in that case it's much easier to add a system 
property rather than patch server.xml.  In fact, the way that I usually address 
this is by setting a property and then specifying it server.xml, so that 
server.xml can be copied with no changes, e.g.

port="${tomcat.port}"



---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

Author: markt
Date: Mon Oct 29 15:17:01 2018
New Revision: 1845136

URL: http://svn.apache.org/viewvc?rev=1845136&view=rev
Log:
Refactor the Connector so that the port is obtained from the Endpoint rather 
than a local field that could end up out of sync.

Modified:
tomcat/trunk/java/org/apache/catalina/connector/Connector.java
tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=1845136&r1=1845135&r2=1845136&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Mon Oct 29 
15:17:01 2018
@@ -146,12 +146,6 @@ public class Connector extends Lifecycle
 
 
 /**
- * The port number on which we listen for requests.
- */
-protected int port = -1;
-
-
-/**
  * The server name to which we should pretend requests to this Connector
  * were directed.  This is useful when operating Tomcat behind a proxy
  * server, so that redirects get constructed accurately.  If not specified,
@@ -516,7 +510,12 @@ public class Connector extends Lifecycle
  * when the socket is bound.
  */
 public int getPort() {
-return this.port;
+Object port = getProperty("port");
+if (port == null) {
+return -1;
+} else {
+return ((Integer) port).intValue();
+}
 }
 
 
@@ -526,7 +525,6 @@ public class Connector extends Lifecycle
  * @param port The new port number
  */
 public void setPort(int port) {
-this.port = port;
 setProperty("port", String.valueOf(port));
 }
 

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java?rev=1845136&r1=1845135&r2=1845136&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Mon Oct 
29 15:17:01 2018
@@ -451,7 +451,7 @@ public abstract class AbstractEndpointhttp://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1845136&r1=1845135&r2=1845136&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Oct 29 15:17:01 2018
@@ -126,6 +126,11 @@
 Library.load(filename) to load a native library by a
 shared class loader so that more than one Webapp can use it. (isapir)
   
+  
+Refactor the Connector so that the port is obtained from
+the Endpoint rather than a local field that could end up
+out of sync. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #125: Provide port offset functionality (BZ-61171)

2018-10-29 Thread rmaucher

Github user rmaucher commented on the issue:

https://github.com/apache/tomcat/pull/125
  
Ok, so I'm guilty for all the system properties in Tomcat ... Sorry. So 
now, it's not good anymore. System properties are still fine for end users, but 
only by using ${...} property replacement in server.xml.


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

On Mon, Oct 29, 2018 at 4:17 PM  wrote:

> Author: markt
> Date: Mon Oct 29 15:17:01 2018
> New Revision: 1845136
>
> URL: http://svn.apache.org/viewvc?rev=1845136&view=rev
> Log:
> Refactor the Connector so that the port is obtained from the Endpoint
> rather than a local field that could end up out of sync.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/connector/Connector.java
> tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
> tomcat/trunk/webapps/docs/changelog.xml
>

I have the feeling that duplication was there because port was used a bit
more than other things (like in the two "security" valves) and the lookup
is more expensive now.

Rémy

Re: svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml


On 29/10/2018 16:41, Rémy Maucherat wrote:

On Mon, Oct 29, 2018 at 4:17 PM  wrote:


Author: markt
Date: Mon Oct 29 15:17:01 2018
New Revision: 1845136

URL: http://svn.apache.org/viewvc?rev=1845136&view=rev
Log:
Refactor the Connector so that the port is obtained from the Endpoint
rather than a local field that could end up out of sync.

Modified:
 tomcat/trunk/java/org/apache/catalina/connector/Connector.java
 tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
 tomcat/trunk/webapps/docs/changelog.xml



I have the feeling that duplication was there because port was used a bit
more than other things (like in the two "security" valves) and the lookup
is more expensive now.


Good point. I need to rethink that / maybe revert it.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845144 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java

Author: markt
Date: Mon Oct 29 17:12:12 2018
New Revision: 1845144

URL: http://svn.apache.org/viewvc?rev=1845144&view=rev
Log:
Improve performance of refactoring

Modified:
tomcat/trunk/java/org/apache/catalina/connector/Connector.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=1845144&r1=1845143&r2=1845144&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Mon Oct 29 
17:12:12 2018
@@ -30,6 +30,7 @@ import org.apache.catalina.LifecycleStat
 import org.apache.catalina.Service;
 import org.apache.catalina.core.AprLifecycleListener;
 import org.apache.catalina.util.LifecycleMBeanBase;
+import org.apache.coyote.AbstractProtocol;
 import org.apache.coyote.Adapter;
 import org.apache.coyote.ProtocolHandler;
 import org.apache.coyote.UpgradeProtocol;
@@ -510,12 +511,18 @@ public class Connector extends Lifecycle
  * when the socket is bound.
  */
 public int getPort() {
+// Try shortcut that should work for nearly all uses first as it does
+// not use reflection and is therefore faster.
+if (protocolHandler instanceof AbstractProtocol) {
+return ((AbstractProtocol) protocolHandler).getPort();
+}
+// Fall back for custom protocol handlers not based on AbstractProtocol
 Object port = getProperty("port");
-if (port == null) {
-return -1;
-} else {
+if (port instanceof Integer) {
 return ((Integer) port).intValue();
 }
+// Usually means an invalid protocol has been configured
+return -1;
 }
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml


On 29/10/2018 16:56, Mark Thomas wrote:

On 29/10/2018 16:41, Rémy Maucherat wrote:

On Mon, Oct 29, 2018 at 4:17 PM  wrote:


Author: markt
Date: Mon Oct 29 15:17:01 2018
New Revision: 1845136

URL: http://svn.apache.org/viewvc?rev=1845136&view=rev
Log:
Refactor the Connector so that the port is obtained from the Endpoint
rather than a local field that could end up out of sync.

Modified:
 tomcat/trunk/java/org/apache/catalina/connector/Connector.java
 tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
 tomcat/trunk/webapps/docs/changelog.xml



I have the feeling that duplication was there because port was used a bit
more than other things (like in the two "security" valves) and the lookup
is more expensive now.


Good point. I need to rethink that / maybe revert it.


I've updated that code.

The really slow part (the reflection) will be skipped when using a 
standard protocol implementation.


Do you think it is OK now or would you prefer I revert the changes?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

On Mon, Oct 29, 2018 at 6:13 PM Mark Thomas  wrote:

> On 29/10/2018 16:56, Mark Thomas wrote:
> > On 29/10/2018 16:41, Rémy Maucherat wrote:
> >> On Mon, Oct 29, 2018 at 4:17 PM  wrote:
> >>
> >>> Author: markt
> >>> Date: Mon Oct 29 15:17:01 2018
> >>> New Revision: 1845136
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=1845136&view=rev
> >>> Log:
> >>> Refactor the Connector so that the port is obtained from the Endpoint
> >>> rather than a local field that could end up out of sync.
> >>>
> >>> Modified:
> >>>  tomcat/trunk/java/org/apache/catalina/connector/Connector.java
> >>>  tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
> >>>  tomcat/trunk/webapps/docs/changelog.xml
> >>>
> >>
> >> I have the feeling that duplication was there because port was used a
> bit
> >> more than other things (like in the two "security" valves) and the
> lookup
> >> is more expensive now.
> >
> > Good point. I need to rethink that / maybe revert it.
>
> I've updated that code.
>
> The really slow part (the reflection) will be skipped when using a
> standard protocol implementation.
>
> Do you think it is OK now or would you prefer I revert the changes?
>

It's good. It's only used in  RemoteAddr/HostValve with an optional
configuration where the port is used.

Rémy

Re: "Embedded" improvements


On 29/10/2018 10:52, Rémy Maucherat wrote:

On Wed, Oct 24, 2018 at 11:54 AM Rémy Maucherat  wrote:


Hi,

I'm starting to review embedded. Maybe I won't make many changes in the
end and won't need a separate API.

However, I have another post 9.0.13 refactoring with a redoing of
ConfigFileLoader and various places which try to load the configuration
from seemingly random locations (the winner is "server-embed.xml", which
IMO everyone forgot about aeons ago). So this redoes it with a pluggable
API as ConfigFileLoader was not. Minor additional work is needed to use it
in more places, since all configuration/resource loading from conf would
need to go through it (ideally) (and except logging, since it's obviously
pluggable enough).


https://github.com/rmaucher/tomcat/commit/c386eb2fc3b2f42b3a307cbc2d0ab1a72581f56a

Comments ?



I think I'm done (?) with the review. Even if not super modern, the
"Tomcat" class provides useful methods and ways to deploy your app embedded.
However, the process of configuring a Tomcat with code (and maintaining it)
is way way too involving (even for "basic" needs), and then degrades into
(partially) reinventing the code config files like the obvious server.xml.
So instead this new API allows providing that server.xml (and most others)
to the Tomcat class and then use its methods to do what you need to fill
the blanks and manage the lifecycle of the embedded server.

Not covered by the pluggability:
- jaspic uses load/store a bit too much, it would still need its regular
config file
- storeconfig
- other items that need files (OpenSSL, cloud)
- anything else I missed

Still at https://github.com/rmaucher/tomcat/commits/trunk


The commits at the moment appear to revert a number of unrelated changes 
(o.a.t.jni.[Library|SSL] are the ones that jumped out at me). Worth a 
careful check when applying these changes.


Overall, looks good.


And the plan is still to add it post 9.0.13.


+1

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: "Embedded" improvements

On Mon, Oct 29, 2018 at 6:46 PM Mark Thomas  wrote:

> On 29/10/2018 10:52, Rémy Maucherat wrote:
> > On Wed, Oct 24, 2018 at 11:54 AM Rémy Maucherat  wrote:
> >
> >> Hi,
> >>
> >> I'm starting to review embedded. Maybe I won't make many changes in the
> >> end and won't need a separate API.
> >>
> >> However, I have another post 9.0.13 refactoring with a redoing of
> >> ConfigFileLoader and various places which try to load the configuration
> >> from seemingly random locations (the winner is "server-embed.xml", which
> >> IMO everyone forgot about aeons ago). So this redoes it with a pluggable
> >> API as ConfigFileLoader was not. Minor additional work is needed to use
> it
> >> in more places, since all configuration/resource loading from conf would
> >> need to go through it (ideally) (and except logging, since it's
> obviously
> >> pluggable enough).
> >>
> >>
> >>
> https://github.com/rmaucher/tomcat/commit/c386eb2fc3b2f42b3a307cbc2d0ab1a72581f56a
> >>
> >> Comments ?
> >>
> >
> > I think I'm done (?) with the review. Even if not super modern, the
> > "Tomcat" class provides useful methods and ways to deploy your app
> embedded.
> > However, the process of configuring a Tomcat with code (and maintaining
> it)
> > is way way too involving (even for "basic" needs), and then degrades into
> > (partially) reinventing the code config files like the obvious
> server.xml.
> > So instead this new API allows providing that server.xml (and most
> others)
> > to the Tomcat class and then use its methods to do what you need to fill
> > the blanks and manage the lifecycle of the embedded server.
> >
> > Not covered by the pluggability:
> > - jaspic uses load/store a bit too much, it would still need its regular
> > config file
> > - storeconfig
> > - other items that need files (OpenSSL, cloud)
> > - anything else I missed
> >
> > Still at https://github.com/rmaucher/tomcat/commits/trunk
>
> The commits at the moment appear to revert a number of unrelated changes
> (o.a.t.jni.[Library|SSL] are the ones that jumped out at me). Worth a
> careful check when applying these changes.
>

Yes, it's fixed in the next commit, sorry, so there's no actual change
there. I'll use svn to commit anyway so it should be ok.

Rémy


>
> Overall, looks good.
>
> > And the plan is still to add it post 9.0.13.
>
> +1
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: "Embedded" improvements





On 29/10/2018 18:01, Rémy Maucherat wrote:

On Mon, Oct 29, 2018 at 6:46 PM Mark Thomas  wrote:


On 29/10/2018 10:52, Rémy Maucherat wrote:

On Wed, Oct 24, 2018 at 11:54 AM Rémy Maucherat  wrote:


Hi,

I'm starting to review embedded. Maybe I won't make many changes in the
end and won't need a separate API.

However, I have another post 9.0.13 refactoring with a redoing of
ConfigFileLoader and various places which try to load the configuration
from seemingly random locations (the winner is "server-embed.xml", which
IMO everyone forgot about aeons ago). So this redoes it with a pluggable
API as ConfigFileLoader was not. Minor additional work is needed to use

it

in more places, since all configuration/resource loading from conf would
need to go through it (ideally) (and except logging, since it's

obviously

pluggable enough).




https://github.com/rmaucher/tomcat/commit/c386eb2fc3b2f42b3a307cbc2d0ab1a72581f56a


Comments ?



I think I'm done (?) with the review. Even if not super modern, the
"Tomcat" class provides useful methods and ways to deploy your app

embedded.

However, the process of configuring a Tomcat with code (and maintaining

it)

is way way too involving (even for "basic" needs), and then degrades into
(partially) reinventing the code config files like the obvious

server.xml.

So instead this new API allows providing that server.xml (and most

others)

to the Tomcat class and then use its methods to do what you need to fill
the blanks and manage the lifecycle of the embedded server.

Not covered by the pluggability:
- jaspic uses load/store a bit too much, it would still need its regular
config file
- storeconfig
- other items that need files (OpenSSL, cloud)
- anything else I missed

Still at https://github.com/rmaucher/tomcat/commits/trunk


The commits at the moment appear to revert a number of unrelated changes
(o.a.t.jni.[Library|SSL] are the ones that jumped out at me). Worth a
careful check when applying these changes.



Yes, it's fixed in the next commit, sorry, so there's no actual change
there. I'll use svn to commit anyway so it should be ok.


Ah. I missed that. Sorry for the noise.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845157 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/ webapps/docs/ webapps/docs/config/

2018-10-29 Thread schultz

Author: schultz
Date: Mon Oct 29 18:11:57 2018
New Revision: 1845157

URL: http://svn.apache.org/viewvc?rev=1845157&view=rev
Log:
Add EncryptInterceptor for clustering.

Added:

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptorMBean.java

tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java
Modified:

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/cluster-interceptor.xml

Added: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java?rev=1845157&view=auto
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 (added)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 Mon Oct 29 18:11:57 2018
@@ -0,0 +1,356 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.tribes.group.interceptors;
+
+import java.security.GeneralSecurityException;
+import java.security.SecureRandom;
+
+import javax.crypto.BadPaddingException;
+import javax.crypto.Cipher;
+import javax.crypto.IllegalBlockSizeException;
+import javax.crypto.spec.IvParameterSpec;
+import javax.crypto.spec.SecretKeySpec;
+
+import org.apache.catalina.tribes.Channel;
+import org.apache.catalina.tribes.ChannelException;
+import org.apache.catalina.tribes.ChannelMessage;
+import org.apache.catalina.tribes.Member;
+import org.apache.catalina.tribes.group.ChannelInterceptorBase;
+import org.apache.catalina.tribes.group.InterceptorPayload;
+import org.apache.catalina.tribes.io.XByteBuffer;
+import org.apache.catalina.tribes.util.StringManager;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
+import org.apache.tomcat.util.buf.HexUtils;
+
+/**
+ * Adds encryption using a pre-shared key.
+ *
+ * The length of the key (in bytes) must be acceptable for the encryption
+ * algorithm being used. For example, for AES, you must use a key of either
+ * 16 bytes (128 bits, 24 bytes 192 bits), or 32 bytes (256 bits).
+ *
+ * You can supply the raw key bytes by calling {@link 
#setEncryptionKey(byte[])}
+ * or the hex-encoded binary bytes by calling
+ * {@link #setEncryptionKey(String)}.
+ */
+public class EncryptInterceptor extends ChannelInterceptorBase implements 
EncryptInterceptorMBean {
+
+private static final Log log = LogFactory.getLog(EncryptInterceptor.class);
+protected static final StringManager sm = 
StringManager.getManager(EncryptInterceptor.class);
+
+private static final String DEFAULT_ENCRYPTION_ALGORITHM = 
"AES/CBC/PKCS5Padding";
+
+private String providerName;
+private String encryptionAlgorithm = DEFAULT_ENCRYPTION_ALGORITHM;
+private byte[] encryptionKeyBytes;
+
+private Cipher encryptionCipher;
+private Cipher decryptionCipher;
+
+public EncryptInterceptor() {
+}
+
+@Override
+public void start(int svc) throws ChannelException {
+if(Channel.SND_TX_SEQ == (svc & Channel.SND_TX_SEQ)) {
+try {
+initCiphers();
+} catch (GeneralSecurityException gse) {
+log.fatal(sm.getString("encryptInterceptor.init.failed"));
+throw new 
ChannelException(sm.getString("encryptInterceptor.init.failed"), gse);
+}
+}
+
+super.start(svc);
+}
+
+@Override
+public void sendMessage(Member[] destination, ChannelMessage msg, 
InterceptorPayload payload)
+throws ChannelException {
+try {
+byte[] data = msg.getMessage().getBytes();
+
+// See #encrypt(byte[]) for an explanation of the return value
+byte[][] bytes = encrypt(data);
+
+XByteBuffer xbb = msg.getMessage();
+
+// Completely replace the message
+xbb.se

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-29 Thread Christopher Schultz

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Rémy et al,

On 10/25/18 11:54, Rémy Maucherat wrote:
> On Thu, Oct 25, 2018 at 5:15 PM Christopher Schultz < 
> ch...@christopherschultz.net> wrote:
> 
>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256
>> 
>> All,
>> 
>> Bump.
>> 
>> I have a full patch at this point (still without documentation),
>> but this one includes resolution of the IV issue and also a set
>> of unit tests which pass.
>> 
>> I'd appreciate it if someone could install this into their
>> cluster and see if it works. Just configure the interceptor into
>> your interceptor chain and set an encryption key (e.g.
>> "cafebabecafebabe").
> 
> 
> IMO  you should commit it and people will test it then (you did and
> it works for you, right ?). With my storeconfig hat on, the
> encryptionKey should be more bean like, the poor thing will break
> otherwise (again ;) ).

I've incorporated the feedback from Keiichi into my patch and
committed it to Tomcat trunk. Feedback is welcome and encouraged.

- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvXTbsACgkQHPApP6U8
pFhsog//a/UjfptHMgYkoIvCdayD1fq4MwKPKZgqV6z0Xox6okP0i0pGkX4/SsJY
siYRbKy2oVxjs/EmDHPjrkYBYkreKcxm8qPbkkq7GwLIRL/AFt5S+GJ+d5F5wyVL
WutC5umBweOrybe2W4VIvd4I1G6A9b4oH75lWRezvsoEUV8v45Z8BPx+6SJ0Ty5p
jwKTKm3wglF7RxfgZ+SRjO7ZDKt4ZdD8aySGZD4Vof0W4cOvy1pz11uJG/olFGrl
9lVtzn4pBVfyxRBffwhhihnS0R482I9BxOXmjUDtGzQIQh5xBrgskFan/+h8vB0a
+30H0xjcCnutNkXk8nJhX4EYi7IIPpnv0KXTECEU5PyZYtCJS1Pdb08FKTTKq9FX
XJaKkyt2EzLWKKwzSWsaHhSUG+J1BZ+j07jK70FSRVK0Wpkb12dmP6nmzsbEx56K
QERuDNnr3EEEflgo2/Hnj+n/OcRYUg4mgOpp96EDlmz+i/2tZu0101aEDKRp3hzt
a4SayK6XBYXsF9DEZgPIc20jU4rTPpLjVXeVHLA4ptzlipe5XrNZ1x0Aeg70iqDw
mIzHIH1rib8nojTfrtm73KkoRbJ6rQmWP+V4A8Vhmgm9PfBIHS+MCblAPjiBx+TM
L3t9Nbjv36HefWB5vDnPj6+G8JyjvmaAL4Aql+popLnLJ2jeJMo=
=arhG
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-trunk

2018-10-29 Thread buildbot

The Buildbot has detected a new failure on builder tomcat-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3686

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1845157
Blamelist: schultz

BUILD FAILED: failed compile

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845158 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

Author: markt
Date: Mon Oct 29 18:35:36 2018
New Revision: 1845158

URL: http://svn.apache.org/viewvc?rev=1845158&view=rev
Log:
Add standard license header

Modified:

tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

Modified: 
tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java?rev=1845158&r1=1845157&r2=1845158&view=diff
==
--- 
tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java
 (original)
+++ 
tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java
 Mon Oct 29 18:35:36 2018
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.apache.catalina.tribes.group.interceptors;
 
 import static org.junit.Assert.*;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845159 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

Author: markt
Date: Mon Oct 29 18:37:55 2018
New Revision: 1845159

URL: http://svn.apache.org/viewvc?rev=1845159&view=rev
Log:
Fix IDE/checkstyle warnings for imports

Modified:

tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

Modified: 
tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java?rev=1845159&r1=1845158&r2=1845159&view=diff
==
--- 
tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java
 (original)
+++ 
tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java
 Mon Oct 29 18:37:55 2018
@@ -16,9 +16,12 @@
  */
 package org.apache.catalina.tribes.group.interceptors;
 
-import static org.junit.Assert.*;
-
 import java.nio.charset.StandardCharsets;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
 import org.apache.catalina.tribes.Channel;
 import org.apache.catalina.tribes.ChannelException;
 import org.apache.catalina.tribes.ChannelInterceptor;
@@ -29,8 +32,6 @@ import org.apache.catalina.tribes.group.
 import org.apache.catalina.tribes.io.ChannelData;
 import org.apache.catalina.tribes.io.XByteBuffer;
 import org.apache.tomcat.util.buf.HexUtils;
-import org.junit.Before;
-import org.junit.Test;
 
 /**
  * Tests the EncryptInterceptor.
@@ -66,7 +67,7 @@ public class TestEncryptInterceptor {
 
 String testInput = "The quick brown fox jumps over the lazy dog.";
 
-assertEquals("Basic roundtrip failed",
+Assert.assertEquals("Basic roundtrip failed",
  testInput,
  roundTrip(testInput, src, dest));
 }
@@ -78,7 +79,7 @@ public class TestEncryptInterceptor {
 
 String testInput = "x";
 
-assertEquals("Tiny payload roundtrip failed",
+Assert.assertEquals("Tiny payload roundtrip failed",
  testInput,
  roundTrip(testInput, src, dest));
 }
@@ -90,7 +91,7 @@ public class TestEncryptInterceptor {
 
 byte[] bytes = new byte[1073741824]; // 1MiB, all zeros
 
-assertArrayEquals("Tiny payload roundtrip failed",
+Assert.assertArrayEquals("Tiny payload roundtrip failed",
   bytes,
   roundTrip(bytes, src, dest));
 }
@@ -104,7 +105,7 @@ public class TestEncryptInterceptor {
 
 String testInput = "The quick brown fox jumps over the lazy dog.";
 
-assertEquals("Failed to set custom provider name",
+Assert.assertEquals("Failed to set custom provider name",
  testInput,
  roundTrip(testInput, src, dest));
 }
@@ -118,7 +119,7 @@ public class TestEncryptInterceptor {
 
 String testInput = "The quick brown fox jumps over the lazy dog.";
 
-assertEquals("Failed to set custom provider name",
+Assert.assertEquals("Failed to set custom provider name",
  testInput,
  roundTrip(testInput, src, dest));
 }
@@ -132,7 +133,7 @@ public class TestEncryptInterceptor {
 
 String testInput = "The quick brown fox jumps over the lazy dog.";
 
-assertEquals("Failed to set custom provider name",
+Assert.assertEquals("Failed to set custom provider name",
  testInput,
  roundTrip(testInput, src, dest));
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845160 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

Author: markt
Date: Mon Oct 29 18:38:33 2018
New Revision: 1845160

URL: http://svn.apache.org/viewvc?rev=1845160&view=rev
Log:
Add @Override markers

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java?rev=1845160&r1=1845159&r2=1845160&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 Mon Oct 29 18:38:33 2018
@@ -145,6 +145,7 @@ public class EncryptInterceptor extends
  *
  * @param algorithm The algorithm to use.
  */
+@Override
 public void setEncryptionAlgorithm(String algorithm) {
 if(null == getEncryptionAlgorithm())
 throw new 
IllegalStateException(sm.getString("encryptInterceptor.algorithm.required"));
@@ -165,6 +166,7 @@ public class EncryptInterceptor extends
  *
  * @return The algorithm being used, including the algorithm mode and 
padding.
  */
+@Override
 public String getEncryptionAlgorithm() {
 return encryptionAlgorithm;
 }
@@ -175,6 +177,7 @@ public class EncryptInterceptor extends
  *
  * @param key The encryption key.
  */
+@Override
 public void setEncryptionKey(byte[] key) {
 if(null == key)
 key = null;
@@ -202,6 +205,7 @@ public class EncryptInterceptor extends
  *
  * @return The encryption key.
  */
+@Override
 public byte[] getEncryptionKey() {
 byte[] key = getEncryptionKeyInternal();
 
@@ -222,6 +226,7 @@ public class EncryptInterceptor extends
  *
  * @param provider The name of the JCA provider.
  */
+@Override
 public void setProviderName(String provider) {
 providerName = provider;
 }
@@ -233,6 +238,7 @@ public class EncryptInterceptor extends
  *
  * @return The name of the JCA provider.
  */
+@Override
 public String getProviderName() {
 return providerName;
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845161 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

Author: markt
Date: Mon Oct 29 18:39:18 2018
New Revision: 1845161

URL: http://svn.apache.org/viewvc?rev=1845161&view=rev
Log:
Fix copy/paste javadoc errors

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java?rev=1845161&r1=1845160&r2=1845161&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 Mon Oct 29 18:39:18 2018
@@ -191,7 +191,7 @@ public class EncryptInterceptor extends
  * will be shown as "ab". The length of the string in characters will
  * be twice the length of the key in bytes.
  *
- * @return The encryption key.
+ * @param keyBytes The encryption key.
  */
 public void setEncryptionKey(String keyBytes) {
 if(null == keyBytes)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845162 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

Author: markt
Date: Mon Oct 29 18:40:16 2018
New Revision: 1845162

URL: http://svn.apache.org/viewvc?rev=1845162&view=rev
Log:
Fix redundant assignment warning.

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java?rev=1845162&r1=1845161&r2=1845162&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 Mon Oct 29 18:40:16 2018
@@ -179,10 +179,11 @@ public class EncryptInterceptor extends
  */
 @Override
 public void setEncryptionKey(byte[] key) {
-if(null == key)
-key = null;
-else
+if (null == key) {
+encryptionKeyBytes = null;
+} else {
 encryptionKeyBytes = key.clone();
+}
 }
 
 /**



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1845162 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java


On 29/10/2018 18:40, ma...@apache.org wrote:

Author: markt
Date: Mon Oct 29 18:40:16 2018
New Revision: 1845162

URL: http://svn.apache.org/viewvc?rev=1845162&view=rev
Log:
Fix redundant assignment warning.


Chris,

I think this is what you intended. Can you check my change here please?

Thanks,

Mark




Modified:
 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java?rev=1845162&r1=1845161&r2=1845162&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 Mon Oct 29 18:40:16 2018
@@ -179,10 +179,11 @@ public class EncryptInterceptor extends
   */
  @Override
  public void setEncryptionKey(byte[] key) {
-if(null == key)
-key = null;
-else
+if (null == key) {
+encryptionKeyBytes = null;
+} else {
  encryptionKeyBytes = key.clone();
+}
  }
  
  /**




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845163 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

Author: markt
Date: Mon Oct 29 18:42:52 2018
New Revision: 1845163

URL: http://svn.apache.org/viewvc?rev=1845163&view=rev
Log:
Fix Javadoc warning

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java?rev=1845163&r1=1845162&r2=1845163&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 Mon Oct 29 18:42:52 2018
@@ -138,8 +138,9 @@ public class EncryptInterceptor extends
 /**
  * Sets the encryption algorithm to be used for encrypting and decrypting
  * channel messages. You must specify the 
algorithm/mode/padding.
- * Information on what standard algorithm names are, please see
- * {@link 
https://docs.oracle.com/javase/8/docs/technotes/guides/security/StandardNames.html}.
+ * Information on standard algorithm names may be found in the
+ * https://docs.oracle.com/javase/8/docs/technotes/guides/security/StandardNames.html";>Java
+ * documentation.
  *
  * Default is AES/CBC/PKCS5Padding.
  *



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-trunk

2018-10-29 Thread buildbot

The Buildbot has detected a restored build on builder tomcat-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3687

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1845163
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1845162 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-10-29 Thread Christopher Schultz

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Mark,

On 10/29/18 14:40, Mark Thomas wrote:
> On 29/10/2018 18:40, ma...@apache.org wrote:
>> Author: markt Date: Mon Oct 29 18:40:16 2018 New Revision:
>> 1845162
>> 
>> URL: http://svn.apache.org/viewvc?rev=1845162&view=rev Log: Fix
>> redundant assignment warning.
> 
> Chris,
> 
> I think this is what you intended. Can you check my change here
> please?

It was. Thanks for the catch.

I would have fixed these individual issues myself; I just forgot to
run checkstyle.

Thanks,
- -chris

> 
> Thanks,
> 
> Mark
> 
> 
>> 
>> Modified:
>> 
>> tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/Encry
ptInterceptor.java
>>
>>
>>
>> 
Modified:
>> tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/Encry
ptInterceptor.java
>>
>>
>> 
URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tr
ibes/group/interceptors/EncryptInterceptor.java?rev=1845162&r1=1845161&r
2=1845162&view=diff
>>
>>
>> 

==
>> 
>> --- 
>> tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/Encry
ptInterceptor.java
>>
>> 
(original)
>> +++ 
>> tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/Encry
ptInterceptor.java
>>
>> 
Mon Oct 29 18:40:16 2018
>> @@ -179,10 +179,11 @@ public class EncryptInterceptor extends */ 
>> @Override public void setEncryptionKey(byte[] key) { -
>> if(null == key) -key = null; -else +
>> if (null == key) { +encryptionKeyBytes = null; +
>> } else { encryptionKeyBytes = key.clone(); +} } /**
>> 
>> 
>> 
>> -
>>
>> 
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>> 
> 
> -
>
> 
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvXW4sACgkQHPApP6U8
pFjXSBAAhg8mA5d+lLSYw75wznLTu/zTGD2JgY5SLFEzbS0/WR//655k4atgPbnz
arRRyT/61zriB+irwdyemuBVHVpLLa/I++Hzk8cWS3n3/BhmC7BqnoG5L+o6htZD
iRVvYhYwZO99B6iJYJg9dkbprUR5CalF3qVJoJNvBYRXUE8x18QN9b5PDPyI3p3u
7xb9kMD1KKRoFmrk1jix1NodvUitLQl5O5BWReNGeLjdTeRxjHDF2yQnyacbpxXU
gKjQPk7JAOlD4HM9rRkmW9lwLwGxkeAW78LdH1iPxt3ewHLWi9XhF3lV7zY6Aic5
DIucuIpRzNsValTz+nQa/WqE+aPNlNA+UJ1CL/O6UGUFknXVZG4pBuAG1Bk8Fnze
U7ruy2r3KfijJfmPhPddZRiEXUIEKhpWqhKilk1wFNeT6xUsItYyQ3GRmm1a8utD
CsUymj/JFrlxy6tU6PwA+XiYR7E/6Wx/IeYuGuRbL/ndSxfals9CB0Ug8+X9/WqD
LMG26sAjmZTPwXCkdb2YqV6ycdiv1FRtUXqKvr9ddg1WchvS1mKXroIqSB8vChND
qkRodgocBF6YatS0e2W0RJKXJlGkTLbERyi3OPXM+y9CAW1UAc7P79+4onxj5ijJ
zc+F9V6gM692N/9OF5LR+hxZbpJN2Qsx0zDDpQkgwo2KUGCMJkE=
=nco/
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1845162 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

On October 29, 2018 7:12:12 PM UTC, Christopher Schultz 
 wrote:
>-BEGIN PGP SIGNED MESSAGE-
>Hash: SHA256
>
>Mark,
>
>On 10/29/18 14:40, Mark Thomas wrote:
>> On 29/10/2018 18:40, ma...@apache.org wrote:
>>> Author: markt Date: Mon Oct 29 18:40:16 2018 New Revision:
>>> 1845162
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1845162&view=rev Log: Fix
>>> redundant assignment warning.
>> 
>> Chris,
>> 
>> I think this is what you intended. Can you check my change here
>> please?
>
>It was. Thanks for the catch.
>
>I would have fixed these individual issues myself; I just forgot to
>run checkstyle.

Np. The fixed were simple. There is one issue left - an illegal import as there 
is a depenendency on the o.a.tomcat package that needs to be fixed. You're 
welcome to fix that as I am now in meeting ;)

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 36 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.15-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.15-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/commons-beanutils/dist/commons-beanutils-20181029.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.9-SNAPSHOT.jar:/srv/gump/pu
 
blic/workspace/apache-commons/logging/target/commons-logging-20181029.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20181029.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-HEAD-jre-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-8.15-SNAPSHOT.jar

setproxy:

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
[checkstyle] Running Checkstyle 8.15-SNAPSHOT on  files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/config/cluster-interceptor.xml:216:
 Line matches the illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/config/cluster-interceptor.xml:220:
 Line matches the illegal pattern '\s+$'. [RegexpSingleline]

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:577: Got 2 errors and 0 
warnings.

Total time: 36 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/rss.xml
- Atom: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 20181029180006, vmgump-vm3.apache.org:vmgump:20181029180006
Gump E-mail Identifier (unique within run) #2.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump-vm3]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-native-1.2-1.1.0-configure (in module tomcat-native-1.2-1.1.0) failed

To whom it may engage...

This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-native-1.2-1.1.0-configure has an issue affecting its community
integration.
This issue affects 3 projects,
and has been outstanding for 4 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-native-1.2-1.1.0-configure : Tomcat native library using Apache
Portable Runtime
- tomcat-native-1.2-1.1.0-make : Tomcat native library using Apache
Portable Runtime
- tomcat-native-1.2-1.1.0-make-install : Tomcat native library using
Apache Portable Runtime

Full details are available at:

http://vmgump-vm3.apache.org/tomcat-native-1.2-1.1.0/tomcat-native-1.2-1.1.0-configure/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were
provided:
-INFO- Made directory
[/srv/gump/public/workspace/tomcat-native-1.2-1.1.0/dest-20181030]
-INFO- Failed with reason build failed

The following work was performed:
http://vmgump-vm3.apache.org/tomcat-native-1.2-1.1.0/tomcat-native-1.2-1.1.0-configure/gump_work/build_tomcat-native-1.2-1.1.0_tomcat-native-1.2-1.1.0-configure.html
Work Name: build_tomcat-native-1.2-1.1.0_tomcat-native-1.2-1.1.0-configure
(Type: Build)
Work ended in a state of : Failed
Elapsed:
Command Line:
/srv/gump/public/workspace/tomcat-native-1.2-1.1.0/native/configure
--with-apr=/srv/gump/public/workspace/apr-1/dest-20181030
--with-ssl=/srv/gump/public/workspace/openssl-1.1.0/dest-20181030
--prefix=/srv/gump/public/workspace/tomcat-native-1.2-1.1.0/dest-20181030
[Working Directory: /srv/gump/public/workspace/tomcat-native-1.2-1.1.0/native]
-
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking target system type... x86_64-pc-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking for working mkdir -p... yes
Tomcat Native Version: 1.2.19
checking for chosen layout... tcnative
checking for APR... yes
configure: APR 1.7.0 detected.
setting CC to "gcc"
setting CPP to "gcc -E"
setting LIBTOOL to
"/srv/gump/public/workspace/apr-1/dest-20181030/build-1/libtool"
adding "-I/usr/lib/jvm/java-8-oracle/include" to TCNATIVE_PRIV_INCLUDES
checking for JDK os include directory... linux
adding "-I/usr/lib/jvm/java-8-oracle/include/linux" to TCNATIVE_PRIV_INCLUDES
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for OpenSSL library... using openssl from
/srv/gump/public/workspace/openssl-1.1.0/dest-20181030/${exec_prefix}/lib and
/srv/gump/public/workspace/openssl-1.1.0/dest-20181030/include
checking OpenSSL library version >= 1.0.2...

Found OPENSSL_VERSION_NUMBER 0x1000106f (OpenSSL 1.0.1f 6 Jan 2014)
Require OPENSSL_VERSION_NUMBER 0x1000200f or greater (1.0.2)

configure: error: Your version of OpenSSL is not compatible with this version
of tcnative
-

To subscribe to this information via syndicated feeds:
- RSS:
http://vmgump-vm3.apache.org/tomcat-native-1.2-1.1.0/tomcat-native-1.2-1.1.0-configure/rss.xml
- Atom:
http://vmgump-vm3.apache.org/tomcat-native-1.2-1.1.0/tomcat-native-1.2-1.1.0-configure/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2018103021, vmgump-vm3.apache.org:vmgump:2018103021
Gump E-mail Identifier (unique within run) #4.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump-vm3]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 32 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.15-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.15-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/commons-beanutils/dist/commons-beanutils-20181030.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.9-SNAPSHOT.jar:/srv/gump/pu
 
blic/workspace/apache-commons/logging/target/commons-logging-20181030.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20181030.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-HEAD-jre-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-8.15-SNAPSHOT.jar

setproxy:

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
[checkstyle] Running Checkstyle 8.15-SNAPSHOT on  files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/config/cluster-interceptor.xml:216:
 Line matches the illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/config/cluster-interceptor.xml:220:
 Line matches the illegal pattern '\s+$'. [RegexpSingleline]

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:577: Got 2 errors and 0 
warnings.

Total time: 32 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/rss.xml
- Atom: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2018103021, vmgump-vm3.apache.org:vmgump:2018103021
Gump E-mail Identifier (unique within run) #7.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump-vm3]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 mins 10 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO -Dexecute.test.nio2=false 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20181030/bin/openssl
 -Dtest.temp=output/test-tmp-NIO 
 -Dtest.accesslog=true -Dexecute.test.nio=true 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-4.1-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu
 
ild/lib/tomcat-jni

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 23 mins 38 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20181030/bin/openssl
 -Dtest.temp=output/test-tmp-NIO2
  -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-4.1-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu
 
ild/lib

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed