Re: [VOTE] Release Apache Tomcat Native 1.2.18

2018-10-18 Thread Eric Lilja
On Thu, Oct 18, 2018 at 12:19 AM Mark Thomas  wrote:

> Version 1.2.18 includes the following changes compared to 1.2.17:
>
> - Windows binaries built with OpenSSL 1.0.2p and APR 1.6.5
> - Windows binaries built with OpenSSL 1.1.1 and APR 1.6.5
> - TLSv1.3 support when built with OpenSSL 1.1.1
>
> Various other fixes and improvements. See the changelog for details.
> [snip]


Where is the changelog? Thanks for the release!

- Eric L


Re: [VOTE] Release Apache Tomcat Native 1.2.18

2018-10-18 Thread Mark Thomas
On 18/10/18 10:54, Eric Lilja wrote:
> On Thu, Oct 18, 2018 at 12:19 AM Mark Thomas  wrote:
> 
>> Version 1.2.18 includes the following changes compared to 1.2.17:
>>
>> - Windows binaries built with OpenSSL 1.0.2p and APR 1.6.5
>> - Windows binaries built with OpenSSL 1.1.1 and APR 1.6.5
>> - TLSv1.3 support when built with OpenSSL 1.1.1
>>
>> Various other fixes and improvements. See the changelog for details.
>> [snip]
> 
> 
> Where is the changelog? Thanks for the release!

https://svn.apache.org/viewvc/tomcat/native/trunk/xdocs/miscellaneous/changelog.xml?view=annotate

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62833] New: Support for using underscores in host

2018-10-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62833

Bug ID: 62833
   Summary: Support for using underscores in host
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Util
  Assignee: dev@tomcat.apache.org
  Reporter: i...@sunisle.org
  Target Milestone: 

In the previous version, such as 8.5.16, supported for using underscores in
host.

The recent version has made some refactorings for Httpparser and has not added
support for it.

The code is corrected as follows:

[org.apache.tomcat.util.http.parser.HttpParser]


public DomainParseState next(int c) {
...
// Add '_' condition
} else if (c == '-' || c == '_') {
if (allowsHyphen) {
return HYPHEN;
} else {
throw new
IllegalArgumentException(sm.getString("http.invalidCharacterDomain",
Character.toString((char) c), errorLocation));
}
} else {
throw new IllegalArgumentException(sm.getString(
"http.illegalCharacterDomain", Character.toString((char) c)));
}
}


-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62833] Support for using underscores in host

2018-10-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62833

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Mark Thomas  ---
As RFC 7230 which ultimately refers to section 3.5 of RFC1034 and section 2.1
of RFC1123, the underscore character is not permitted in any part of a host
name or a fully qualified domain name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62833] Support for using underscores in host

2018-10-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62833

--- Comment #2 from gudaoxuri  ---
Can you provide compatibility options? The one-size-fits-all approach is too
strong:-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.2.18

2018-10-18 Thread Rémy Maucherat
On Thu, Oct 18, 2018 at 12:19 AM Mark Thomas  wrote:

> Version 1.2.18 includes the following changes compared to 1.2.17:
>
> - Windows binaries built with OpenSSL 1.0.2p and APR 1.6.5
> - Windows binaries built with OpenSSL 1.1.1 and APR 1.6.5
> - TLSv1.3 support when built with OpenSSL 1.1.1
>
> Various other fixes and improvements. See the changelog for details.
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.18 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...
>
> But no TLS 1.3 / OpenSSL 1.1.1 testing here, only compatibility with older
items.

Rémy


Re: [VOTE] Release Apache Tomcat Native 1.2.18

2018-10-18 Thread Coty Sutherland
On Wed, Oct 17, 2018 at 6:19 PM Mark Thomas  wrote:

> Version 1.2.18 includes the following changes compared to 1.2.17:
>
> - Windows binaries built with OpenSSL 1.0.2p and APR 1.6.5
> - Windows binaries built with OpenSSL 1.1.1 and APR 1.6.5
> - TLSv1.3 support when built with OpenSSL 1.1.1
>
> Various other fixes and improvements. See the changelog for details.
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.18 is
>  [x] Stable, go ahead and release
>  [ ] Broken because of ...
>

+1, tested with openssl-1.1.0i-fips and apr-1.6.3 on fc28.


>
> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.18/
> [2]
> https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_18
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-10-18 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 8 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 mins 9 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20181019/bin/openssl
 -Dtest.temp=output/test-tmp-NIO2
  -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-4.0-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/works