Tagging JK 1.2.45
All, With the regression (Bz 62689) and the additional improvements to path parameter handling I think we need a 1.2.45 release. I plan to check everything is ready for the tag and then tag later today. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1840901 - /tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java
On 17/09/18 22:13, Christopher Schultz wrote: > Mark, > > On 9/17/18 08:34, Mark Thomas wrote: >> On 17/09/18 10:50, Konstantin Kolinko wrote: > >> > >>> Implementing auto-reloading has a caveat: there is a race >>> condition between an editor (that is used to update the file) and >>> Tomcat. It may be that Tomcat will try to read an incompletely >>> written file. >>> >>> Also using a SAX parser + Digester, it does not check whether the >>> XML file is well-formed beforehand. It stops on the first >>> encountered error, but side effect from whatever methods it has >>> called thus far will be visible. > >> There is some code that handles a similar case for updated WAR >> files. We should be able to make that generic and re-use it here. > > Also, when using SAX+digester, a new object should be created for the > user database and only brought into service when it's been completely > (and properly) loaded. I wouldn't suggest reading the XML directly > into the live structure. > > I'm not saying that's how the code IS written... just saying how it > ought to be written, given your concerns for such a race-condition. Ideally, yes. Unfortunately that would require some additional refactoring. I think I'll go for the simpler option of clearing the users, roles and groups if there is an error. The lock that is now in place will ensure the data isn't used during the load. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1841213 - /tomcat/jk/trunk/native/STATUS.txt
Author: markt Date: Tue Sep 18 09:47:32 2018 New Revision: 1841213 URL: http://svn.apache.org/viewvc?rev=1841213&view=rev Log: Format nit Modified: tomcat/jk/trunk/native/STATUS.txt Modified: tomcat/jk/trunk/native/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/STATUS.txt?rev=1841213&r1=1841212&r2=1841213&view=diff == --- tomcat/jk/trunk/native/STATUS.txt (original) +++ tomcat/jk/trunk/native/STATUS.txt Tue Sep 18 09:47:32 2018 @@ -19,7 +19,7 @@ Last modified at [$Date$] Release: 1.2.45 : development in progress -1.2.44 : released September 1,2018 +1.2.44 : released September 1, 2018 1.2.43 : released March 6, 2018 1.2.42 : released October 5, 2016 1.2.41 : released August 11, 2015 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 62731] New: HandshakeRequest has a relative URL
https://bz.apache.org/bugzilla/show_bug.cgi?id=62731 Bug ID: 62731 Summary: HandshakeRequest has a relative URL Product: Tomcat 9 Version: 9.0.12 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: boris_pet...@live.com Target Milestone: - I opened an issue in CometD about a NPE in their code: https://github.com/cometd/cometd/issues/791 According to the supporter of CometD, this is actually an issue with Tomcat: https://github.com/cometd/cometd/issues/791#issuecomment-422322833 He's saying that "request.getRequestURI()" should return an absolute URI in order to be able to get the schema as there is no other API for that. Please check the link for his exact words. I could probably come up with a reproduction project if one is needed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1841214 - in /tomcat/jk/trunk/xdocs: index.xml news/20180301.xml
Author: markt Date: Tue Sep 18 09:50:41 2018 New Revision: 1841214 URL: http://svn.apache.org/viewvc?rev=1841214&view=rev Log: Add initial information for 1.2.45 release Modified: tomcat/jk/trunk/xdocs/index.xml tomcat/jk/trunk/xdocs/news/20180301.xml Modified: tomcat/jk/trunk/xdocs/index.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/index.xml?rev=1841214&r1=1841213&r2=1841214&view=diff == --- tomcat/jk/trunk/xdocs/index.xml (original) +++ tomcat/jk/trunk/xdocs/index.xml Tue Sep 18 09:50:41 2018 @@ -63,12 +63,12 @@ manual is described in more detail below -JK-1.2.44 released +JK-1.2.45 released The Apache Tomcat team is proud to announce the immediate availability - of Tomcat Connectors 1.2.44 Stable. This release contains improvements and + of Tomcat Connectors 1.2.45 Stable. This release contains improvements and bug fixes for issues found in previous releases. -Download the JK 1.2.44 +Download the JK 1.2.45 release. Modified: tomcat/jk/trunk/xdocs/news/20180301.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/news/20180301.xml?rev=1841214&r1=1841213&r2=1841214&view=diff == --- tomcat/jk/trunk/xdocs/news/20180301.xml (original) +++ tomcat/jk/trunk/xdocs/news/20180301.xml Tue Sep 18 09:50:41 2018 @@ -31,6 +31,18 @@ + +The Apache Tomcat team is proud to announce the immediate availability + of Tomcat Connectors 1.2.45. This is a maintenance release. + +Please see the ChangeLog + for a full list of changes. + +If you find any bugs while using this release, please fill in the +https://bz.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%20Connectors";>Bugzilla +Bug Report. + + The Apache Tomcat team is proud to announce the immediate availability of Tomcat Connectors 1.2.44. This is a maintenance release. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1841215 - in /tomcat/jk/tags/JK_1_2_45: ./ native/STATUS.txt native/common/jk_version.h
Author: markt Date: Tue Sep 18 10:00:24 2018 New Revision: 1841215 URL: http://svn.apache.org/viewvc?rev=1841215&view=rev Log: Tag 1.2.45 Added: tomcat/jk/tags/JK_1_2_45/ - copied from r1841214, tomcat/jk/trunk/ Modified: tomcat/jk/tags/JK_1_2_45/native/STATUS.txt tomcat/jk/tags/JK_1_2_45/native/common/jk_version.h Modified: tomcat/jk/tags/JK_1_2_45/native/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_45/native/STATUS.txt?rev=1841215&r1=1841214&r2=1841215&view=diff == --- tomcat/jk/tags/JK_1_2_45/native/STATUS.txt (original) +++ tomcat/jk/tags/JK_1_2_45/native/STATUS.txt Tue Sep 18 10:00:24 2018 @@ -18,7 +18,7 @@ Last modified at [$Date$] Release: -1.2.45 : development in progress +1.2.45 : release in progress 1.2.44 : released September 1, 2018 1.2.43 : released March 6, 2018 1.2.42 : released October 5, 2016 Modified: tomcat/jk/tags/JK_1_2_45/native/common/jk_version.h URL: http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_45/native/common/jk_version.h?rev=1841215&r1=1841214&r2=1841215&view=diff == --- tomcat/jk/tags/JK_1_2_45/native/common/jk_version.h (original) +++ tomcat/jk/tags/JK_1_2_45/native/common/jk_version.h Tue Sep 18 10:00:24 2018 @@ -29,7 +29,7 @@ #define JK_VERFIX 45 /* set JK_VERISRELEASE to 1 when release (do not forget to commit!) */ -#define JK_VERISRELEASE 0 +#define JK_VERISRELEASE 1 /* Beta number */ #define JK_VERBETA 0 #define JK_BETASTRING "0" - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 62731] HandshakeRequest has a relative URL
https://bz.apache.org/bugzilla/show_bug.cgi?id=62731 --- Comment #1 from Mark Thomas --- Similar to https://github.com/eclipse-ee4j/websocket-api/issues/228 On balance the full, undecoded, unnormalized URI including query string looks to the the right thing to return. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r29475 - in /dev/tomcat/tomcat-connectors/jk: ./ binaries/ binaries/windows/ binaries/windows/symbols/
Author: markt Date: Tue Sep 18 11:20:15 2018 New Revision: 29475 Log: Upload Apache Tomcat JK 1.2.45 for voting Added: dev/tomcat/tomcat-connectors/jk/HEADER.html - copied unchanged from r29251, release/tomcat/tomcat-connectors/jk/HEADER.html dev/tomcat/tomcat-connectors/jk/README.html - copied, changed from r29251, release/tomcat/tomcat-connectors/jk/README.html dev/tomcat/tomcat-connectors/jk/binaries/README.html - copied unchanged from r29251, release/tomcat/tomcat-connectors/jk/binaries/README.html dev/tomcat/tomcat-connectors/jk/binaries/windows/HEADER.html - copied unchanged from r29251, release/tomcat/tomcat-connectors/jk/binaries/windows/HEADER.html dev/tomcat/tomcat-connectors/jk/binaries/windows/README.html - copied, changed from r29251, release/tomcat/tomcat-connectors/jk/binaries/windows/README.html dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/HEADER.html - copied unchanged from r29251, release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/HEADER.html dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/README.html - copied unchanged from r29251, release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/README.html dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-i386-symbols.zip (with props) dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-i386-symbols.zip.asc dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-i386-symbols.zip.sha512 dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-x86_64-symbols.zip (with props) dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-x86_64-symbols.zip.asc dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-x86_64-symbols.zip.sha512 dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-i386-iis.zip (with props) dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-i386-iis.zip.asc dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-i386-iis.zip.sha512 dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-x86_64-iis.zip (with props) dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-x86_64-iis.zip.asc dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-x86_64-iis.zip.sha512 dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.tar.gz (with props) dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.tar.gz.asc dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.tar.gz.sha512 dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.zip (with props) dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.zip.asc dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.zip.sha512 Copied: dev/tomcat/tomcat-connectors/jk/README.html (from r29251, release/tomcat/tomcat-connectors/jk/README.html) == --- release/tomcat/tomcat-connectors/jk/README.html (original) +++ dev/tomcat/tomcat-connectors/jk/README.html Tue Sep 18 11:20:15 2018 @@ -47,13 +47,13 @@ nearest mirror site! % pgpk -a KEYS -% pgpv tomcat-connectors-1.2.44-src.tar.gz.asc +% pgpv tomcat-connectors-1.2.45-src.tar.gz.asc or, % pgp -ka KEYS -% pgp tomcat-connectors-1.2.44-src.tar.gz.asc +% pgp tomcat-connectors-1.2.45-src.tar.gz.asc or, % gpg --import KEYS -% gpg --verify tomcat-connectors-1.2.44-src.tar.gz.asc +% gpg --verify tomcat-connectors-1.2.45-src.tar.gz.asc We offer SHA1 and SHA512 hashes as alternatives to validate the integrity Copied: dev/tomcat/tomcat-connectors/jk/binaries/windows/README.html (from r29251, release/tomcat/tomcat-connectors/jk/binaries/windows/README.html) == --- release/tomcat/tomcat-connectors/jk/binaries/windows/README.html (original) +++ dev/tomcat/tomcat-connectors/jk/binaries/windows/README.html Tue Sep 18 11:20:15 2018 @@ -22,7 +22,7 @@ connector to fail. -The current stable release is 1.2.44 +The current stable release is 1.2.45 See the Apache Tomcat Connectors http://tomcat.apache.org/connectors-doc/miscellaneous/changelog.html";>changelog Added: dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-i386-symbols.zip == Binary file - no diff available. Propchange: dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-i386-symbols.zip --
[VOTE] Release JK 1.2.45
Tag: http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_45/ Source: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/ This is a maintenance release to address a regression in 1.2.44 and to provide general improvements to the handling of path parameters. It also includes Windows binaries for IIS. The proposed JK 1.2.45 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 1.2.45 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 62731] HandshakeRequest has a relative URL
https://bz.apache.org/bugzilla/show_bug.cgi?id=62731 --- Comment #2 from Remy Maucherat --- But then actually using this sort of input is highly risky :( -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.91
Am 13.09.2018 um 22:28 schrieb Violeta Georgieva: The proposed Apache Tomcat 7.0.91 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.91/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1195/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_91/ The proposed 7.0.91 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 7.0.91 Stable Regards, Felix Regards, Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
docs for web.xml.defaults
Hi all, today I looked for documentation about the usage of host specific web.xml variations like the one provided by context.xml.default. I found no documentation, but it is implemented in all supported versions of tomcat. Is there any reason for not telling our users about that feature? I think it would fit on the page about virtual hosts (together with a remark about the context.xml.default files, which are only mentioned in the conf/context page). When there are no objections, I will add it. Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 62688] RewriteMap with custom map function does not work
https://bz.apache.org/bugzilla/show_bug.cgi?id=62688
ITASSIST changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|INVALID |---
--- Comment #2 from ITASSIST ---
We have tested this very carefully on version 9.0.12 and if we use a variable
inside rewritemap inside a rewriterule we get a different behaviour than
before. Before in version 9.0.11 it did not give any error. It did just not
pick up the variable. When we use it now, it does abviously a syntax check and
claims that variable written in the rewrite rule is invalid. For us it seems
like the parser of this does not understand this syntax:
RewriteRule .* ${portals:%{HTTP_HOST}}
Gives in catalin.oput startup file:
Caused by: java.lang.IllegalArgumentException: %{HTTP_HOST
portals is a rewritemap type and we have tested that it works if we replace the
%{HTTP_HOST} variable with a hardcoded value, it works correct.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
