svn commit: r1840535 - in /tomcat/trunk: java/org/apache/catalina/webresources/war/WarURLConnection.java webapps/docs/changelog.xml

2018-09-11 Thread remm
Author: remm
Date: Tue Sep 11 09:21:34 2018
New Revision: 1840535

URL: http://svn.apache.org/viewvc?rev=1840535&view=rev
Log:
62687: Expose content length information for resources when using a compressed 
war.

Modified:
tomcat/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java?rev=1840535&r1=1840534&r2=1840535&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java 
Tue Sep 11 09:21:34 2018
@@ -63,4 +63,17 @@ public class WarURLConnection extends UR
 public long getLastModified() {
 return wrappedJarUrlConnection.getLastModified();
 }
+
+
+@Override
+public int getContentLength() {
+return wrappedJarUrlConnection.getContentLength();
+}
+
+
+@Override
+public long getContentLengthLong() {
+return wrappedJarUrlConnection.getContentLengthLong();
+}
+
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1840535&r1=1840534&r2=1840535&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Sep 11 09:21:34 2018
@@ -45,6 +45,14 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  
+62687: Expose content length information for resources
+when using a compressed war. (remm)
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1840536 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/webresources/war/WarURLConnection.java webapps/docs/changelog.xml

2018-09-11 Thread remm
Author: remm
Date: Tue Sep 11 09:24:02 2018
New Revision: 1840536

URL: http://svn.apache.org/viewvc?rev=1840536&view=rev
Log:
62687: Expose content length information for resources when using a compressed 
war.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 11 09:24:02 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 
3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,17

[Bug 62687] WarURLConnection always returns -1 from getContentLength() and getContentLengthLong() which causes a 416 when request includes a Range header

2018-09-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62687

Remy Maucherat  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Remy Maucherat  ---
Ok, this is reasonable. The fix will be in 9.0.13 and 8.5.35.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1840541 - in /tomcat/site/trunk: ./ docs/ xdocs/

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 11:27:18 2018
New Revision: 1840541

URL: http://svn.apache.org/viewvc?rev=1840541&view=rev
Log:
Update (excluding docs) for 9.0.12 release

Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-90.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-9.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-90.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-9.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1840541&r1=1840540&r2=1840541&view=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Tue Sep 11 11:27:18 2018
@@ -39,7 +39,7 @@ tomcat.loc=http://www.apache.org/dist/to
 tomcat70=7.0.90
 tomcat80=8.0.53
 tomcat85=8.5.33
-tomcat90=9.0.11
+tomcat90=9.0.12
 
 # - Download destination -
 tomcat-site-docs.home=${base.path}/tomcat-site-docs/

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1840541&r1=1840540&r2=1840541&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Tue Sep 11 11:27:18 2018
@@ -60,8 +60,8 @@
 
   
 Latest Stable 9.0.x Release
-2018-04-07
-9.0.7
+2018-09-10
+9.0.12
   
 
 

Modified: tomcat/site/trunk/docs/download-90.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-90.html?rev=1840541&r1=1840540&r2=1840541&view=diff
==
--- tomcat/site/trunk/docs/download-90.html (original)
+++ tomcat/site/trunk/docs/download-90.html Tue Sep 11 11:27:18 2018
@@ -225,7 +225,7 @@
 Quick Navigation
 
 
-[define v]9.0.11[end]
+[define v]9.0.12[end]
 https://www.apache.org/dist/tomcat/tomcat-9/KEYS";>KEYS |
 [v] |
 Browse |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1840541&r1=1840540&r2=1840541&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Tue Sep 11 11:27:18 2018
@@ -248,66 +248,56 @@ project logo are trademarks of the Apach
 
 
 
-
-2018-09-01 Tomcat Connectors 1.2.44 
Released
+
+2018-09-10 Tomcat 9.0.12 Released
 
 
 
-The Apache Tomcat Project is proud to announce the release of version 1.2.44 of
-Apache Tomcat Connectors.
-This version fixes a number of bugs found in previous releases.
-
+The Apache Tomcat Project is proud to announce the release of version 9.0.12
+of Apache Tomcat. The notable changes compared to 9.0.11 include:
 
-
+
 
-https://tomcat.apache.org/download-connectors.cgi";>Download |
-ChangeLog for 1.2.44
+Fix multiple issues associated with using the asynchronous Servlet API in
+combination with HTTP/2.
 
-
+Add recursion to rewrite substitution parsing.
 
-
-
-2018-08-17 Tomcat 9.0.11 Released
-
+Expand the information in the documentation web application regarding the
+use of CATALINA_HOME and CATALINA_BASE. Patch provided by Marek
+Czernek.
 
-
-The Apache Tomcat Project is proud to announce the release of version 9.0.11
-of Apache Tomcat. The notable changes compared to 9.0.10 include:
+
 
-
 
-Correctly decode URL paths (+ should not be decoded to a space
-in the path) in the RequestDispatcher and the web application class
-loader.
-
-Add a default location for the native library:
-${catalina.home}/bin
-
-
-Make the Jasper (JSP Engine) Java file generation process multi-threaded.
-By default, one thread will be used per core. Based on a patch by Dan
-Fabulich.
+
+Full details of these changes, and all the other changes, are available in the
+Tomcat 9
+changelog.
+
 
-
 
+
 
-
+https://tomcat.apache.org/download-90.cgi";>Download
 
-Note: A number of known issues remain using Servlet
-asynchronous support with HTTP/2. These will be fixed in the next release.
 
 
+
+
+2018-09-01 Tomcat Connectors 1.2.44 
Released
+
 
 
-Full details of these changes, and all the other changes, are available in the
-Tomcat 9
-changelog.
+The Apache Tomcat Project is proud to announce the release of version 1.2.44 of
+Apache Tomcat Connectors.
+This version fixes a number of bugs found in previous releases.
 
 
-
 
 
-https://tomcat.apache.org/download-90.cgi";>Download
+https://tomc

svn commit: r29271 - /release/tomcat/tomcat-9/v9.0.11/

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 11:28:33 2018
New Revision: 29271

Log:
Drop 9.0.11 from mirror network

Removed:
release/tomcat/tomcat-9/v9.0.11/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1840542 - in /tomcat/site/trunk/docs/tomcat-9.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 11:34:59 2018
New Revision: 1840542

URL: http://svn.apache.org/viewvc?rev=1840542&view=rev
Log:
Update docs for 9.0.12 release


[This commit notification would consist of 64 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[ANN] Apache Tomcat 9.0.12 available

2018-09-11 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache
Tomcat 9.0.12.

Apache Tomcat 9 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language, Java
WebSocket and JASPIC technologies.

Apache Tomcat 9.0.12 is a bugfix and feature release. The notable
changes compared to 9.0.11 include:

- Fix multiple issues associated with using the asynchronous Servlet
  API in combination with HTTP/2

- Add recursion to rewrite substitution parsing

- Expand the information in the documentation web application
  regarding the use of CATALINA_HOME and CATALINA_BASE.
  Patch provided by Marek Czernek.

Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-9.0-doc/changelog.html


Downloads:
http://tomcat.apache.org/download-90.cgi

Migration guides from Apache Tomcat 7.x and 8.x:
http://tomcat.apache.org/migration.html

Enjoy!

- The Apache Tomcat team

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1840552 - in /tomcat/site/trunk: ./ docs/ xdocs/

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 12:45:41 2018
New Revision: 1840552

URL: http://svn.apache.org/viewvc?rev=1840552&view=rev
Log:
Update (excluding docs) for 8.5.34 release

Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-80.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-85.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-80.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-85.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1840552&r1=1840551&r2=1840552&view=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Tue Sep 11 12:45:41 2018
@@ -38,7 +38,7 @@ tomcat.loc=http://www.apache.org/dist/to
 # - Tomcat versions -
 tomcat70=7.0.90
 tomcat80=8.0.53
-tomcat85=8.5.33
+tomcat85=8.5.34
 tomcat90=9.0.12
 
 # - Download destination -

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1840552&r1=1840551&r2=1840552&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Tue Sep 11 12:45:41 2018
@@ -67,8 +67,8 @@
 
   
 Latest Stable 8.5.x Release
-2018-04-07
-8.5.30
+2018-09-10
+8.5.34
   
 
 

Modified: tomcat/site/trunk/docs/download-80.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-80.html?rev=1840552&r1=1840551&r2=1840552&view=diff
==
--- tomcat/site/trunk/docs/download-80.html (original)
+++ tomcat/site/trunk/docs/download-80.html Tue Sep 11 12:45:41 2018
@@ -233,7 +233,7 @@
 Quick Navigation
 
 
-[define v]8.5.33[end]
+[define v]8.5.34[end]
 [define w]8.0.53[end]
 https://www.apache.org/dist/tomcat/tomcat-8/KEYS";>KEYS |
 [v] |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1840552&r1=1840551&r2=1840552&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Tue Sep 11 12:45:41 2018
@@ -284,63 +284,34 @@ changelog.
 
 
 
-
-2018-09-01 Tomcat Connectors 1.2.44 
Released
+
+2018-09-10 Tomcat 8.5.34 Released
 
 
 
-The Apache Tomcat Project is proud to announce the release of version 1.2.44 of
-Apache Tomcat Connectors.
-This version fixes a number of bugs found in previous releases.
-
-
-
-
-https://tomcat.apache.org/download-connectors.cgi";>Download |
-ChangeLog for 1.2.44
-
-
-
-
-
-2018-08-17 Tomcat 8.5.33 Released
-
-
-
-The Apache Tomcat Project is proud to announce the release of version 8.5.33
+The Apache Tomcat Project is proud to announce the release of version 8.5.34
 of Apache Tomcat. Apache Tomcat 8.5.x replaces 8.0.x and includes new features
 pulled forward from Tomcat 9.0.x. The minimum Java version and implemented
 specification versions remain unchanged. The notable changes compared
-to 8.5.32 include:
+to 8.5.33 include:
 
 
 
-Correctly decode URL paths (+ should not be decoded to a space
-in the path) in the RequestDispatcher and the web application class
-loader.
-
-When pre-compiling with JspC, report all compilation errors rather
-than stopping after the first error. A new option -failFast
-can be used to restore the previous behaviour of stopping after the first
-error. Based on a patch provided by Marc Pompl.
-
-Make the Jasper (JSP Engine) Java file generation process multi-threaded.
-By default, one thread will be used per core. Based on a patch by Dan
-Fabulich.
+Fix multiple issues associated with using the asynchronous Servlet API in
+combination with HTTP/2.
 
-
+Add recursion to rewrite substitution parsing.
 
+Expand the information in the documentation web application regarding the
+use of CATALINA_HOME and CATALINA_BASE. Patch provided by Marek
+Czernek.
 
-
-
-Note: A number of known issues remain using Servlet
-asynchronous support with HTTP/2. These will be fixed in the next release.
-
+
 
 
 
 Full details of these changes, and all the other changes, are available in the
-Tomcat 8.5
+Tomcat 8.5
 changelog.
 
 
@@ -351,6 +322,24 @@ changelog.
 
 
 
+
+
+2018-09-01 Tomcat Connectors 1.2.44 
Released
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 1.2.44

svn commit: r29272 - /release/tomcat/tomcat-8/v8.5.33/

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 12:46:39 2018
New Revision: 29272

Log:
Drop Apache Tomcat 8.5.33 from mirrors

Removed:
release/tomcat/tomcat-8/v8.5.33/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[ANN] Apache Tomcat 8.5.34 available

2018-09-11 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache
Tomcat 8.5.34.

Apache Tomcat 8 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language, Java
WebSocket and Java Authentication Service Provider Interface for
Containers technologies.

Apache Tomcat 8.5.x replaces 8.0.x and includes new features pulled
forward from the 9.0.x branch. The notable changes since 8.5.33 include:

- Fix multiple issues associated with using the asynchronous Servlet
  API in combination with HTTP/2

- Add recursion to rewrite substitution parsing

- Expand the information in the documentation web application
  regarding the use of CATALINA_HOME and CATALINA_BASE.
  Patch provided by Marek Czernek.

Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-8.5-doc/changelog.html

Downloads:
http://tomcat.apache.org/download-80.cgi

Migration guides from Apache Tomcat 7.x and 8.0.x:
http://tomcat.apache.org/migration.html

Enjoy!

- The Apache Tomcat team


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1840553 - in /tomcat/site/trunk/docs/tomcat-8.5-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 12:53:01 2018
New Revision: 1840553

URL: http://svn.apache.org/viewvc?rev=1840553&view=rev
Log:
Update docs for 8.5.34 release


[This commit notification would consist of 61 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Securing temporary file-uploads

2018-09-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Konstantin,

On 9/6/18 12:18, Konstantin Kolinko wrote:
> пт, 17 авг. 2018 г. в 17:34, Christopher Schultz
> :
>> 
>> All,
>> 
>> A presentation at DEFCON[1] last week showed how many Android 
>> applications were improperly using shared external storage on
>> Android devices and could be vulnerable due to improper handling
>> of temporary files.
>> 
>> This was your basic:
>> 
>> 1. Download a file from a trusted source (e.g.
>> properly-authenticated, encrypted web connection) 2. Buffer the
>> file in temporary storage 3. Read the file back from temporary
>> storage
>> 
>> type setup.
>> 
>> The problem is that step 2b. might be "an attacker modifies the
>> file".
>> 
>> If step 4 is "use the file to update your own application", and
>> the storage system is untrustworthy (which is the case on
>> Android, since it's shared among all apps running on the device),
>> then there is an opportunity to exploit that application.
>> 
>> This got me to thinking about how Tomcat handles file uploads.
>> Since Servlet 3.0, containers must provide the facility and
>> Tomcat uses commons-fileupload to handle most of the
>> heavy-lifting. One feature of that facility is the ability to
>> buffer the file on a local disk if it exceeds some defined size
>> -- to avoid creating large in-memory buffers for file uploads.
>> 
>> So Tomcat does some form of the steps 1-3 above, except that the
>> file isn't being downloaded... it's being uploaded. Now, it's
>> really up to the application developer to be sure that the user
>> should be allowed to upload a file, but assuming that user has
>> been authenticated, then the application should be able to trust
>> that Tomcat hasn't been subverted during steps 2-3.
>> 
>> If the filesystem is hostile (yes, I know you have lots of
>> problems if that's the case), then Tomcat might end up not
>> delivering the same bytes to the application that were originally
>> uploaded by the user.
>> 
>> I'm curious whether anyone cares to look at this scenario in
>> order to mitigate it. I can think of a few ways to mitigate such
>> a potential vulnerability:
>> 
>> 1. Tomcat computes a signature of the file as it's being
>> written-out, computes the signature of the file as it's being
>> read back-in for the application, and throws an exception if the
>> file appears to be corrupted. Problems with this solution include
>> not being able to detect the problem until most of the bytes have
>> already been sent to the application.
>> 
>> 2. Tomcat encrypts the file as its being written to the disk with
>> a temporary symmetric key. Problems with this solution are
>> additional resources (CPU) required for encryption.
>> 
>> The LOE for either of the above doesn't seem very high.
>> 
>> Is there any appetite for hardening of this type in Tomcat?
>> Situations where the filesystem (or other programs running on the
>> server) is untrustworthy are probably few and far-between, but
>> there are indeed environments where applications are running
>> under a security manager because those applications are
>> untrusted.
>> 
>> I didn't check to see whether Tomcat segregates temporary files
>> for uploads between different applications, but I can see a
>> scenario or two where Tomcat might want to protect an application
>> from having its uploads tampered with.
>> 
>> Thanks, - -chris
>> 
>> [1] 
>> https://blog.checkpoint.com/2018/08/12/man-in-the-disk-a-new-attack-s
urf
>>
>> 
ace-for-android-apps/
> 
> Keep it simple.
> 
> 1) If filesystem is not trustworthy, what prevents someone from 
> injecting compiled classes, JSPs, or modifying essential
> configuration files?

Signed/sealed WAR files?

> 2) Note that Tomcat does not use system temporary directory but
> has its own temp directory.

Sure, but there is conceptually no difference.

> 3) Each web application  has its own private temporary directory 
> (work/appname). The uploaded files are placed there, AFAIR.

Any webapp would be able to write to any other webapp's work
directory, if it knew the name of that directory. There is no
protection provided by Tomcat

> 4) If one is concerned, it is possible to run with a more
> restrictive umask (limiting access from other OS users to the
> created files) and with Security Manager (limiting access from
> other web applications to each other).

The umask should already be set to a sane value, but Tomcat won't
protect files from each other's web applications and, IIRC, a
SecurityManager can't enforce that kind of protection, either.

- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAluX2YMACgkQHPApP6U8
pFgayg//crXcXJm5vZSL/mhw+gclf7GPbx4RiktzS3U/184WA4ZMxjttZIqXaviO
W5oeywH4Vzvac6xOoFi1Dx62qxq9XGDoi6rZN3ILs98JvxEkQzSMUbvC2TdVkTi2
4UKT0N8RqJuhiTUDCutQIXBiXBib86qPYisKQtNgcVHMTnZ7zlFrzvpAFGaogycJ
RNeF2VLrE6htShuLiEhW4e8SxMUaKzQoKltd+HvvM/5xIuC4QpTPcgjvYO+qzYf/
eOuDIZ

Speakers needed for Apache DC Roadshow

2018-09-11 Thread Rich Bowen
We need your help to make the Apache Washington DC Roadshow on Dec 4th a 
success.


What do we need most? Speakers!

We're bringing a unique DC flavor to this event by mixing Open Source 
Software with talks about Apache projects as well as OSS CyberSecurity, 
OSS in Government and and OSS Career advice.


Please take a look at: http://www.apachecon.com/usroadshow18/

(Note: You are receiving this message because you are subscribed to one 
or more mailing lists at The Apache Software Foundation.)


Rich, for the ApacheCon Planners

--
rbo...@apache.org
http://apachecon.com
@ApacheCon

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62674] org.apache.jasper.JspC no longer compiles

2018-09-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #3 from Paul  ---
Also hangs in 8.5.34.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1840588 - in /tomcat/jk/trunk: native/apache-2.0/mod_jk.c native/common/jk_util.c native/common/jk_util.h xdocs/miscellaneous/changelog.xml

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 16:27:38 2018
New Revision: 1840588

URL: http://svn.apache.org/viewvc?rev=1840588&view=rev
Log:
Apache: Improve path parameter handling so that JkStripSession can remove 
session IDs that are specified on path parameters in any segment of the URI 
rather than only the final segment.

Modified:
tomcat/jk/trunk/native/apache-2.0/mod_jk.c
tomcat/jk/trunk/native/common/jk_util.c
tomcat/jk/trunk/native/common/jk_util.h
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/jk/trunk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/apache-2.0/mod_jk.c?rev=1840588&r1=1840587&r2=1840588&view=diff
==
--- tomcat/jk/trunk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/jk/trunk/native/apache-2.0/mod_jk.c Tue Sep 11 16:27:38 2018
@@ -4058,23 +4058,13 @@ static int jk_map_to_storage(request_rec
 jk_log(conf->log, JK_LOG_DEBUG,
"no match for %s found",
r->uri);
-if (conf->strip_session == JK_TRUE &&
-conf->strip_session_name) {
+if (conf->strip_session == JK_TRUE && 
conf->strip_session_name) {
 char *jsessionid;
 if (r->uri) {
-jsessionid = strstr(r->uri, conf->strip_session_name);
-if (jsessionid) {
-if (JK_IS_DEBUG_LEVEL(conf->log))
-jk_log(conf->log, JK_LOG_DEBUG,
-   "removing session identifier [%s] for 
non servlet url [%s]",
-   jsessionid, r->uri);
-*jsessionid = '\0';
-}
+   jk_strip_session_id(r->uri, conf->strip_session_name, 
conf->log);
 }
 if (r->filename) {
-jsessionid = strstr(r->filename, 
conf->strip_session_name);
-if (jsessionid)
-*jsessionid = '\0';
+   jk_strip_session_id(r->filename, 
conf->strip_session_name, conf->log);
 }
 return DECLINED;
 }

Modified: tomcat/jk/trunk/native/common/jk_util.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_util.c?rev=1840588&r1=1840587&r2=1840588&view=diff
==
--- tomcat/jk/trunk/native/common/jk_util.c (original)
+++ tomcat/jk/trunk/native/common/jk_util.c Tue Sep 11 16:27:38 2018
@@ -2282,6 +2282,42 @@ int jk_servlet_normalize(char *path, jk_
 return 0;
 }
 
+int jk_strip_session_id(char* path, char* session_name, jk_logger_t *logger) {
+
+   char *jsessionid;
+
+jsessionid = strstr(path, session_name);
+if (jsessionid) {
+if (JK_IS_DEBUG_LEVEL(logger)) {
+jk_log(logger, JK_LOG_DEBUG,
+   "removing session identifier for non servlet uri [%s]", 
path);
+}
+   // Found a session path parameter.
+   // Need to skip at least as many characters as there are in
+   // strip_session_name
+   int i = strlen(session_name);
+   int j = 0;
+   // Increment i until the first character after the parameter
+   while (jsessionid[i] != '\0' && jsessionid[i] != ';' && jsessionid[i] 
!= '/') {
+   i++;
+   }
+   // Copy until the end
+   while (jsessionid[i] != '\0') {
+   jsessionid[j++] = jsessionid[i++];
+   }
+   // Terminate
+   jsessionid[j] = '\0';
+
+if (JK_IS_DEBUG_LEVEL(logger)) {
+jk_log(logger, JK_LOG_DEBUG,
+   "result of removing session identifier for non servlet 
uri is [%s]", path);
+}
+return 1;
+}
+
+   return 0;
+}
+
 #ifdef _MT_CODE_PTHREAD
 jk_pthread_t jk_gettid()
 {

Modified: tomcat/jk/trunk/native/common/jk_util.h
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_util.h?rev=1840588&r1=1840587&r2=1840588&view=diff
==
--- tomcat/jk/trunk/native/common/jk_util.h (original)
+++ tomcat/jk/trunk/native/common/jk_util.h Tue Sep 11 16:27:38 2018
@@ -60,7 +60,7 @@ int jk_log(jk_logger_t *l,
 
 int jk_check_attribute_length(const char *name, const char *value,
   jk_logger_t *l);
-
+
 const char *jk_get_worker_host(jk_map_t *m, const char *wname, const char 
*def);
 
 const char *jk_get_worker_source(jk_map_t *m, const char *wname, const char 
*def);
@@ -190,7 +190,7 @@ int jk_is_unique_property(const char *pr
 int jk_is_deprecated_property(const char *prp_name);
 
 int jk_check_buffer_size();
-
+
 int jk_is_valid_property(const char *prp_name);
 
 int jk_get_worker_std

svn commit: r1840592 - /tomcat/jk/trunk/native/common/jk_util.c

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 16:36:49 2018
New Revision: 1840592

URL: http://svn.apache.org/viewvc?rev=1840592&view=rev
Log:
Tweak patch to make Windows build happy.

Modified:
tomcat/jk/trunk/native/common/jk_util.c

Modified: tomcat/jk/trunk/native/common/jk_util.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_util.c?rev=1840592&r1=1840591&r2=1840592&view=diff
==
--- tomcat/jk/trunk/native/common/jk_util.c (original)
+++ tomcat/jk/trunk/native/common/jk_util.c Tue Sep 11 16:36:49 2018
@@ -2288,6 +2288,8 @@ int jk_strip_session_id(char* path, char
 
 jsessionid = strstr(path, session_name);
 if (jsessionid) {
+   int i;
+   int j;
 if (JK_IS_DEBUG_LEVEL(logger)) {
 jk_log(logger, JK_LOG_DEBUG,
"removing session identifier for non servlet uri [%s]", 
path);
@@ -2295,8 +2297,8 @@ int jk_strip_session_id(char* path, char
// Found a session path parameter.
// Need to skip at least as many characters as there are in
// strip_session_name
-   int i = strlen(session_name);
-   int j = 0;
+   i = (int) strlen(session_name);
+   j = 0;
// Increment i until the first character after the parameter
while (jsessionid[i] != '\0' && jsessionid[i] != ';' && jsessionid[i] 
!= '/') {
i++;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-09-11 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 26 mins 49 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.7-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20180911/bin/openssl
 -Dtest.temp=output/test-tmp-NIO2
  -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-t

Re: [ANN] Apache Tomcat 8.5.34 available

2018-09-11 Thread Michael Osipov

Am 2018-09-11 um 14:53 schrieb Mark Thomas:

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 8.5.34.

Apache Tomcat 8 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language, Java
WebSocket and Java Authentication Service Provider Interface for
Containers technologies.

Apache Tomcat 8.5.x replaces 8.0.x and includes new features pulled
forward from the 9.0.x branch. The notable changes since 8.5.33 include:

- Fix multiple issues associated with using the asynchronous Servlet
   API in combination with HTTP/2

- Add recursion to rewrite substitution parsing

- Expand the information in the documentation web application
   regarding the use of CATALINA_HOME and CATALINA_BASE.
   Patch provided by Marek Czernek.

Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-8.5-doc/changelog.html

Downloads:
http://tomcat.apache.org/download-80.cgi

Migration guides from Apache Tomcat 7.x and 8.0.x:
http://tomcat.apache.org/migration.html


Perfect, thank you. I have put it already in production three hours ago.

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



JDBC drivers in WEB-INF/lib

2018-09-11 Thread Michael Osipov

Hi folks,

in bug 62670 [1] -- contrary to my statement -- Mark pointed out that is 
it pefectly legal to have a JDBC driver in WEB-INF/lib. While I was 
living for years with the assumption that this is discouraged because 
the DriverManager is VM wide and not classloader-wide, plus numerous SO 
questions have been asked about this.


While reading [2] it is still not clear why this is a perfectly legal case.

How can we improve the docs to make it crystal clear for users under 
which circumstances a driver is valid in WEB-INF/lib?


[1] https://bz.apache.org/bugzilla/show_bug.cgi?id=62670#c2
[2] 
http://tomcat.apache.org/tomcat-9.0-doc/jndi-datasource-examples-howto.html


Regards,

Michael


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1840603 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 19:35:47 2018
New Revision: 1840603

URL: http://svn.apache.org/viewvc?rev=1840603&view=rev
Log:
IIS: Improve path parameter handling so that strip_session can remove session 
IDs that are specified on path parameters in any segment of the URI rather than 
only the final segment.

Modified:
tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/jk_isapi_plugin.c?rev=1840603&r1=1840602&r2=1840603&view=diff
==
--- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Tue Sep 11 19:35:47 2018
@@ -1750,10 +1750,10 @@ static DWORD handle_notify_event(PHTTP_F
 else
 query = NULL;
 }
-if (uri_select_option == URI_SELECT_OPT_UNPARSED) {
-/* Duplicate unparsed uri */
-uri_undec = jk_pool_strdup(&pool, uri);
-}
+
+/* Duplicate unparsed uri */
+   uri_undec = jk_pool_strdup(&pool, uri);
+
 rc = unescape_url(uri);
 if (rc == BAD_REQUEST) {
 jk_log(logger, JK_LOG_ERROR,
@@ -1927,21 +1927,14 @@ static DWORD handle_notify_event(PHTTP_F
 }
 else {
 if (JK_IS_DEBUG_LEVEL(logger))
-jk_log(logger, JK_LOG_DEBUG,
-   "[%s] is not a servlet url", uri);
+jk_log(logger, JK_LOG_DEBUG, "[%s] is not a servlet url", 
uri_undec);
 if (strip_session) {
-char *jsessionid = strstr(uri, JK_PATH_SESSION_IDENTIFIER);
-if (jsessionid) {
-if (JK_IS_DEBUG_LEVEL(logger))
-jk_log(logger, JK_LOG_DEBUG,
-   "removing session identifier [%s] for non servlet 
url [%s]",
-   jsessionid, uri);
-*jsessionid = '\0';
-pfp->SetHeader(pfc, "url", uri);
-}
+   if (jk_strip_session_id(uri_undec, JK_PATH_SESSION_IDENTIFIER, 
logger)) {
+   pfp->SetHeader(pfc, "url", uri_undec);
+   }
 }
 }
-cleanup:
+cleanup:c
 jk_close_pool(&pool);
 return rv;
 }

Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1840603&r1=1840602&r2=1840603&view=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Tue Sep 11 19:35:47 2018
@@ -67,6 +67,11 @@
 path parameters in any segment of the URI rather than only the final
 segment. (markt)
   
+  
+IIS: Improve path parameter handling so that strip_session
+can remove session IDs that are specified on path parameters in any
+segment of the URI rather than only the final segment. (markt)
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1840604 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 20:06:00 2018
New Revision: 1840604

URL: http://svn.apache.org/viewvc?rev=1840604&view=rev
Log:
Fix typo

Modified:
tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/jk_isapi_plugin.c?rev=1840604&r1=1840603&r2=1840604&view=diff
==
--- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Tue Sep 11 20:06:00 2018
@@ -1934,7 +1934,7 @@ static DWORD handle_notify_event(PHTTP_F
}
 }
 }
-cleanup:c
+cleanup:
 jk_close_pool(&pool);
 return rv;
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1840607 - /tomcat/jk/trunk/native/common/jk_uri_worker_map.c

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 20:27:59 2018
New Revision: 1840607

URL: http://svn.apache.org/viewvc?rev=1840607&view=rev
Log:
Remove unused code. All path parameters will have been removed by this point.

Modified:
tomcat/jk/trunk/native/common/jk_uri_worker_map.c

Modified: tomcat/jk/trunk/native/common/jk_uri_worker_map.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_uri_worker_map.c?rev=1840607&r1=1840606&r2=1840607&view=diff
==
--- tomcat/jk/trunk/native/common/jk_uri_worker_map.c (original)
+++ tomcat/jk/trunk/native/common/jk_uri_worker_map.c Tue Sep 11 20:27:59 2018
@@ -1164,12 +1164,6 @@ const char *map_uri_to_worker_ext(jk_uri
 }
 url[i + vhost_len] = '\0';
 
-if (JK_IS_DEBUG_LEVEL(l)) {
-char *url_rewrite = strstr(uri, JK_PATH_SESSION_IDENTIFIER);
-if (url_rewrite)
-jk_log(l, JK_LOG_DEBUG, "Found session identifier '%s' in url 
'%s'",
-   url_rewrite, uri);
-}
 if (JK_IS_DEBUG_LEVEL(l))
 jk_log(l, JK_LOG_DEBUG, "Attempting to map URI '%s' from %d maps",
url, IND_THIS(uw_map->size));



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1840610 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

2018-09-11 Thread markt
Author: markt
Date: Tue Sep 11 20:51:29 2018
New Revision: 1840610

URL: http://svn.apache.org/viewvc?rev=1840610&view=rev
Log:
With the improvements in path parameter handling for the mapping phase, ensure 
the original URI - with the parameters - is used as the basis for the URI 
passed to Tomcat.

Modified:
tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/jk_isapi_plugin.c?rev=1840610&r1=1840609&r2=1840610&view=diff
==
--- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Tue Sep 11 20:51:29 2018
@@ -1702,7 +1702,8 @@ static DWORD handle_notify_event(PHTTP_F
 jk_pool_t pool;
 
 char *uri_undec  = NULL;
-char *uri  = NULL;
+char *cleanuri  = NULL;
+char *uri = NULL;
 char *host = NULL;
 char *translate = NULL;
 char szHB[HDR_BUFFER_SIZE] = "/";
@@ -1771,7 +1772,8 @@ static DWORD handle_notify_event(PHTTP_F
 rv = SF_STATUS_REQ_FINISHED;
 goto cleanup;
 }
-if (jk_servlet_normalize(uri, logger)) {
+cleanuri = jk_pool_strdup(&pool, uri);
+if (jk_servlet_normalize(cleanuri, logger)) {
 write_error_response(pfc, 404);
 rv = SF_STATUS_REQ_FINISHED;
 goto cleanup;
@@ -1787,7 +1789,7 @@ static DWORD handle_notify_event(PHTTP_F
 else
 host = szHB;
 }
-worker = map_uri_to_worker_ext(uw_map, uri, host,
+worker = map_uri_to_worker_ext(uw_map, cleanuri, host,
&extensions, &worker_index, logger);
 /*
  * Check if somebody is feading us with his own TOMCAT data headers.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62674] org.apache.jasper.JspC no longer compiles

2018-09-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #4 from Christopher Schultz  ---
Can you post a thread-dump of JspC when it's "hung"? That might shed some light
on the situation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: JDBC drivers in WEB-INF/lib

2018-09-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Michael,

On 9/11/18 3:33 PM, Michael Osipov wrote:
> in bug 62670 [1] -- contrary to my statement -- Mark pointed out
> that is it pefectly legal to have a JDBC driver in WEB-INF/lib.
> While I was living for years with the assumption that this is
> discouraged because the DriverManager is VM wide and not
> classloader-wide, plus numerous SO questions have been asked about
> this.

Most answers are based upon speculation and age-old wisdom about
decades-old versions of Tomcat. Most of those questions haven't been
answered by anyone who actually knows the answers.

> While reading [2] it is still not clear why this is a perfectly
> legal case.

Putting a JDBC library into WEB-INF/lib is a supported use-case in
Tomcat, full stop. That's why it's a legal case: simply because we say
it is.

> How can we improve the docs to make it crystal clear for users
> under which circumstances a driver is valid in WEB-INF/lib?

I can't imagine a case where it should *not* be valid.

The documentation[2] simply says that the application won't be able to
rely on auto-registration of JDBC drivers (which has, in my
experience, always been flaky anyway) and you'll have to go back to
the practice of calling Class.forName(driverName) and possibly calling
newInstance() on the Class object, just like it was still 1995.

I haven't checked, but presumably both of the JDBC pools shipped with
Tomcat perform this operation for you, so you don't have to have a
ServletContextListener that does it, but you will want to take care to
de-register your JDBC driver when your application shuts-down, or you
will have a ClassLoader-pinning leak (DriverManager[app CL] -> JDBC
Driver Class [webapp CL] -> webapp CL -> all classes loaded for the
webapp).

There are some drivers (notably MySQL's Connector/J) that are
notoriously difficult to kill because they are written by people who
don't understand why drivers would ever have to be removed from
memory, but that's a different problem.

At $work, we still use CATALINA_BASE/lib for out JDBC drivers, but
that's simply due to historical deployment strategy.

- -chris

References left in-tact:
> [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=62670#c2 [2] 
> http://tomcat.apache.org/tomcat-9.0-doc/jndi-datasource-examples-howto
.html
-BEGIN PGP SIGNATURE-
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAluYOXQACgkQHPApP6U8
pFhBCBAAi+BqVwcKOqo7OQVK2RW5nODITckdVCMiX/qLrlUQ0smZc+cp74SVoup6
kCFrnICvuvPawI0Qt0tCnzkuMoagM5DpwTFWlud5Q5XNN5nZq38hvlzTrVb8hl/j
rniK+T9tgnCn406RFf09QpZA70b5QGa0O151Gv/ckZm3FmYIXo2MnzJ4vtsnC/CJ
/sSXt4sfL5IodI0iiqdEcuByrpHlvben47KM2n/+QTaxWiU61XQ7+D+khKo+kpDY
yxXlTzkWCDp2TFRLYYUrYHUZyCgXydQYIGH1jY+qtDclarP5+LTrFwkEYU+G4tIX
Pvr6gGG3a3NM2S9mbbLGYl5A8y2yiYPJQ8bYBbOvKk1a5AG4yfYDzx7oKjmbAP/O
DZgNhgFC/vZZvD75L/3dROErIQrQkJbBqDNLUpXlzVFlBLzaBNaqDRZ23ZDQ9lh1
hRO0OxHuOhNYQ0f2V1C9HueAwWE3ZfBj37L2eGvLAJQ9TP233lx9BD69jTVZChOd
TPYE/NUiViThj4XaYXBtHzmOk6vwOOWrEebUhaq7s8duaQAWBWDINAg792T6wX6l
YJRL6HW7uRfWJqpdJJjVZI9xjZ7kC1cHfGeIB02LC8r9d+ra68ZJFSk0DiaReKrH
RjZQ5rQJkOIr+n8Wyqu5P6Ge6fpLvDzHnsGOqxHQo7SdAdbXNJ0=
=8tx0
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1840618 - in /tomcat/site/trunk: docs/presentations.html xdocs/presentations.xml

2018-09-11 Thread isapir
Author: isapir
Date: Tue Sep 11 23:51:14 2018
New Revision: 1840618

URL: http://svn.apache.org/viewvc?rev=1840618&view=rev
Log:
Replaced broken audio links

Modified:
tomcat/site/trunk/docs/presentations.html
tomcat/site/trunk/xdocs/presentations.xml

Modified: tomcat/site/trunk/docs/presentations.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/presentations.html?rev=1840618&r1=1840617&r2=1840618&view=diff
==
--- tomcat/site/trunk/docs/presentations.html (original)
+++ tomcat/site/trunk/docs/presentations.html Tue Sep 11 23:51:14 2018
@@ -603,28 +603,28 @@ mailing list.
 
 Apache Tomcat and SSL – Mark Thomas,
 https://home.apache.org/~markt/presentations/2014-04-09-Tomcat-SSL.pdf";>slides,
-http://feathercast.apache.org/podcasts/ApacheConNA2014/blake/Blake_14_Mark-Thomas.mp3";>audio
+https://www.youtube.com/watch?v=rt7oZ-7QEEk";>audio
 
 
 Monitoring Apache Tomcat – Christopher Schultz,
 http://home.apache.org/~schultz/ApacheCon%20NA%202014/Monitoring%20Apache%20Tomcat%20with%20JMX.pdf";>slides,
-http://feathercast.apache.org/podcasts/ApacheConNA2014/blake/Blake_15_Christopher-Schultz.mp3";>audio
+https://www.youtube.com/watch?v=U2y_6j1Cgr8";>audio
 
 
 Migrating to Apache Tomcat 8 – Mark Thomas,
 https://home.apache.org/~markt/presentations/2014-04-09-Migrating-to-Apache-Tomcat-8.pdf";>slides,
-http://feathercast.apache.org/podcasts/ApacheConNA2014/blake/Blake_16_Mark%20Thomas.mp3";>audio
+https://www.youtube.com/watch?v=JrbH5zQusM0";>audio
 
 
 Connecting Tomcat to the World: Performance and other considerations when
 selecting a Tomcat connector – Christopher Schultz, Jean-Frederic 
Clere,
 slides not available,
-http://feathercast.apache.org/podcasts/ApacheConNA2014/blake/Blake_17_Shultz-Clere.mp3";>audio
+https://www.youtube.com/watch?v=KKVO_xgRKbA";>audio
 
 
 A Practical use of Servlet 3.1: Implementing WebSocket – Mark Thomas,
 https://home.apache.org/~markt/presentations/2014-04-09-WebSocket-on-Servlet31.pdf";>slides,
-http://feathercast.apache.org/podcasts/ApacheConNA2014/blake/Blake_18_Mark%20Thomas.mp3";>audio
+https://www.youtube.com/watch?v=9PbN2K8eO2w";>audio
 
 
 

Modified: tomcat/site/trunk/xdocs/presentations.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/presentations.xml?rev=1840618&r1=1840617&r2=1840618&view=diff
==
--- tomcat/site/trunk/xdocs/presentations.xml (original)
+++ tomcat/site/trunk/xdocs/presentations.xml Tue Sep 11 23:51:14 2018
@@ -234,20 +234,20 @@ mailing list.
 
 Apache Tomcat and SSL – Mark Thomas,
 https://home.apache.org/~markt/presentations/2014-04-09-Tomcat-SSL.pdf";>slides,
-http://feathercast.apache.org/podcasts/ApacheConNA2014/blake/Blake_14_Mark-Thomas.mp3";>audio
+https://www.youtube.com/watch?v=rt7oZ-7QEEk";>audio
 Monitoring Apache Tomcat – Christopher Schultz,
 http://home.apache.org/~schultz/ApacheCon%20NA%202014/Monitoring%20Apache%20Tomcat%20with%20JMX.pdf";>slides,
-http://feathercast.apache.org/podcasts/ApacheConNA2014/blake/Blake_15_Christopher-Schultz.mp3";>audio
+https://www.youtube.com/watch?v=U2y_6j1Cgr8";>audio
 Migrating to Apache Tomcat 8 – Mark Thomas,
 https://home.apache.org/~markt/presentations/2014-04-09-Migrating-to-Apache-Tomcat-8.pdf";>slides,
-http://feathercast.apache.org/podcasts/ApacheConNA2014/blake/Blake_16_Mark%20Thomas.mp3";>audio
+https://www.youtube.com/watch?v=JrbH5zQusM0";>audio
 Connecting Tomcat to the World: Performance and other considerations when
 selecting a Tomcat connector – Christopher Schultz, Jean-Frederic Clere,
 slides not available,
-http://feathercast.apache.org/podcasts/ApacheConNA2014/blake/Blake_17_Shultz-Clere.mp3";>audio
+https://www.youtube.com/watch?v=KKVO_xgRKbA";>audio
 A Practical use of Servlet 3.1: Implementing WebSocket – Mark Thomas,
 https://home.apache.org/~markt/presentations/2014-04-09-WebSocket-on-Servlet31.pdf";>slides,
-http://feathercast.apache.org/podcasts/ApacheConNA2014/blake/Blake_18_Mark%20Thomas.mp3";>audio
+https://www.youtube.com/watch?v=9PbN2K8eO2w";>audio
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: JDBC drivers in WEB-INF/lib

2018-09-11 Thread Igal Sapir

On 9/11/2018 2:53 PM, Christopher Schultz wrote:

On 9/11/18 3:33 PM, Michael Osipov wrote:

... plus numerous SO questions have been asked about
this.

... Most of those questions haven't been
answered by anyone who actually knows the answers.


Sad but true.

Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62687] WarURLConnection always returns -1 from getContentLength() and getContentLengthLong() which causes a 416 when request includes a Range header

2018-09-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62687

--- Comment #2 from Douglas Paul <3wvzs26...@liamekaens.com> ---
Excellent, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62705] New: tomcat 8.5.33+ requires jdk 9

2018-09-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62705

Bug ID: 62705
   Summary: tomcat 8.5.33+ requires jdk 9
   Product: Tomcat 8
   Version: 8.5.33
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Packaging
  Assignee: dev@tomcat.apache.org
  Reporter: bsut...@noojee.com.au
  Target Milestone: 

My build from tomcat trunk stopped working a little while ago with the error:

build/build.xml:675: javac doesn't support the "release" attribute

Originally I though the problem was that I need the latest version of ant so I
upgraded to ant  1.10.5 .

The problem however persisted.

This leads me to the conclusion that the problem is that the ant scripts now
actually require a minimum of jdk 9 as they are passing the -release flag to
javac.

It was my understanding that tomcat 8 could be built with java 7 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2018-09-11 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 27 mins 58 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.7-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO -Dexecute.test.nio2=false 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20180912/bin/openssl
 -Dtest.temp=output/test-tmp-NIO 
 -Dtest.accesslog=true -Dexecute.test.nio=true 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu
 
ild/lib/tomcat-jni

[Bug 62705] tomcat 8.5.33+ requires jdk 9

2018-09-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62705

--- Comment #1 from Igal Sapir  ---
I actually just got that same error a couple of hours ago building 9.0.13-dev
using Java 1.8.0_172 and Ant 1.9.7 on Windows.

I upgraded to ant 1.10.5 and it solved the issue for me.

Are you sure that the correct version of Ant is on the path?  Can you confirm
by running the command:

  ant -version

?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-09-11 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 3 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 27 mins 34 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.7-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20180912/bin/openssl
 -Dtest.temp=output/test-tmp-NIO2
  -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/work

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2018-09-11 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-apr has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 30 mins 32 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dtest.temp=output/test-tmp-APR 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dtest.accesslog=true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.7-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20180912/bin/openssl
 -Dexecute.test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dexecute.test.apr=true -Dtest.r
 eports=output/logs-APR -Dexecute.test.nio2=false 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-trunk/dest-20180912/lib 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/t

[Bug 62705] tomcat 8.5.33+ requires jdk 9

2018-09-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62705

--- Comment #2 from Igal Sapir  ---
I just built again with Java 1.8.0_181 and Ant 1.10.5 on Fedora 28 with no
issue.

Ant output shows that the --release switch is ignored on a sub-9 Java version:

[javac] Support for javac --release has been added in Java9 ignoring it

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62705] tomcat 8.5.33+ requires jdk 9

2018-09-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62705

Konstantin Kolinko  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #3 from Konstantin Kolinko  ---
> build/build.xml:675: javac doesn't support the "release" attribute

The above message means that the "javac" task of Ant does not know the
"release" attribute, cannot process the build file. Support for "release"
attribute was added in Ant 1.9.8 and 1.10.0.

The required minimum version of Ant is documented in BUILDING.txt file of
Tomcat.


The official release of Tomcat 8.5.34 was built with Ant 1.9.9 and JDK 7u80,
as can be seen in MANIFEST.MF files in jars.

The release of Tomcat 9.0.12 was built with Ant 1.9.9 and JDK 8u181.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org