[RESULT][VOTE] Release JK 1.2.44

2018-09-01 Thread Mark Thomas

The following votes were cast:

binding:
+1: markt, rjung,kfujino

non-binding:
+1: Martin Knoblauch

No other votes were cast.

This vote therefore passes. Thanks to everyone who contributed to this 
release.


Mark


On 24/08/2018 17:56, Mark Thomas wrote:

Tag:
http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_44/

Source:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/


This is a maintenance release with a handful of bug fixes and some
clean-up. It also includes Windows binaries for IIS.


The proposed JK 1.2.44 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 1.2.44

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r29079 - /dev/tomcat/tomcat-connectors/jk/ /dev/tomcat/tomcat-connectors/jk/binaries/ /dev/tomcat/tomcat-connectors/jk/binaries/windows/ /dev/tomcat/tomcat-connectors/jk/binaries/windows/s

2018-09-01 Thread markt
Author: markt
Date: Sat Sep  1 11:19:28 2018
New Revision: 29079

Log:
Release Tomcat Connectors JK 1.2.44

Added:
release/tomcat/tomcat-connectors/jk/HEADER.html
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/HEADER.html
release/tomcat/tomcat-connectors/jk/README.html
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/README.html
release/tomcat/tomcat-connectors/jk/binaries/README.html
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/README.html
release/tomcat/tomcat-connectors/jk/binaries/windows/HEADER.html
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/HEADER.html
release/tomcat/tomcat-connectors/jk/binaries/windows/README.html
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/README.html
release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/HEADER.html
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/HEADER.html
release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/README.html
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/README.html

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-i386-symbols.zip
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-i386-symbols.zip

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-i386-symbols.zip.asc
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-i386-symbols.zip.asc

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-i386-symbols.zip.sha512
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-i386-symbols.zip.sha512

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-x86_64-symbols.zip
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-x86_64-symbols.zip

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-x86_64-symbols.zip.asc
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-x86_64-symbols.zip.asc

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-x86_64-symbols.zip.sha512
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.44-windows-x86_64-symbols.zip.sha512

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-i386-iis.zip
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-i386-iis.zip

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-i386-iis.zip.asc
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-i386-iis.zip.asc

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-i386-iis.zip.sha512
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-i386-iis.zip.sha512

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-x86_64-iis.zip
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-x86_64-iis.zip

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-x86_64-iis.zip.asc
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-x86_64-iis.zip.asc

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-x86_64-iis.zip.sha512
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.44-windows-x86_64-iis.zip.sha512
release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.44-src.tar.gz
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.44-src.tar.gz
release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.44-src.tar.gz.asc
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.44-src.tar.gz.asc

release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.44-src.tar.gz.sha512
  - copied unchanged from r29078, 
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.44-src.tar.gz.sha512
release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.44-src.

svn commit: r1839820 - /tomcat/jk/trunk/native/STATUS.txt

2018-09-01 Thread markt
Author: markt
Date: Sat Sep  1 11:30:29 2018
New Revision: 1839820

URL: http://svn.apache.org/viewvc?rev=1839820&view=rev
Log:
Update release date

Modified:
tomcat/jk/trunk/native/STATUS.txt

Modified: tomcat/jk/trunk/native/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/STATUS.txt?rev=1839820&r1=1839819&r2=1839820&view=diff
==
--- tomcat/jk/trunk/native/STATUS.txt (original)
+++ tomcat/jk/trunk/native/STATUS.txt Sat Sep  1 11:30:29 2018
@@ -19,7 +19,7 @@ Last modified at [$Date$]
 Release:
 
 1.2.45  : development in progress
-1.2.44  : release in progress
+1.2.44  : released September 1,2018
 1.2.43  : released March 6, 2018
 1.2.42  : released October 5, 2016
 1.2.41  : released August 11, 2015



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62669] New: ResponseIncludeWrapper.getContentType() never returns NULL and sets the field

2018-09-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62669

Bug ID: 62669
   Summary: ResponseIncludeWrapper.getContentType() never returns
NULL and sets the field
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: svenuh...@web.de
  Target Milestone: 

Hello,

according to the documentation
org.apache.catalina.ssi.ResponseIncludeWrapper.getContentType() should return
NULL if the content type is not known. However a fallback to
"application/x-octet-stream" is implemented and it actually sets the content
type field of the object.

I had a quick look into the SVN repository and it seems this code was
introduced in or before 2006. Because this was 12 years ago and because I could
not find any report regarding this issue, I guess everyone else can work with
that and only the documentation needs to be adapted.

However I actually prefer to get NULL. First of all for me it is bad practice
to set a value in a getter (if it is not called "lazy..."). But let me try to
explain the real problem.

The control flow of SSIFilter is:
* ...
* Wrap the actual response with ResponseIncludeWrapper
* Continue and complete the filter chain
* Check the content type
* ...

The problem is when the filter chain is continued and completed, other filters
that get the content type from the response (ResponseIncludeWrapper) actually
change the content type of the response even though this is most likely NOT
what the other filters want to do. It happens by accident, just by calling
getContentType.

Also some filters rely on the fact that the getContentType returns NULL if it
is not known, in order to check if they should set it on their own. They never
set the content type because with the current implementation it always return a
value other than NULL.

Best regards,
Sven.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Download Link on the Tomcat website

2018-09-01 Thread Konstantin Kolinko
пт, 31 авг. 2018 г. в 20:49, Igal Sapir :
>
> Currently links to the Download pages can be either to the whichversion
> [1] page or the version-specific pages, e.g. "Tomcat 9" [2] etc.  It
> will be very useful to have a generic download.html that is
> future-proof.  For example, I am writing a blog post ATM and I want to
> link to a download page that will work also for future versions of
> Tomcat.  We can either create a new page for that, or add links to the
> whichversion page, which would be easier but not necessarily better.
>
> I can do that myself but wanted your feedback before I make any updates
> to the site.

IMHO, just link to the top page, "can be downloaded from tomcat.apache.org".

I do not think that common landing page for downloads is necessary,
though I have seen projects that have one.

We can discuss what good examples are there.

One certain thing: if such page is made, please make it static so that
Release Managers wouldn't be required to update it for each release.

Also we have other projects besides Tomcat here (mod_jk, taglibs, maven plugin).
The top page has one (latest) announcement for each project and those
have a download link.

> Also, is Tomcat 9 considered the current Stable version or is it still
> in Beta?  I don't recall seeing any announcements about it being Stable
> but it's possible that I just missed that.

It was not so long ago, though it feels like a lot of time has passed.

All announcements can be found in the "old news" link on the web site,
as well as in multiple archives of the "announcement@tomcat" mailing list.

The actual votes are available in archives of the "VOTE" threads of
dev@. Once a version is votes as "stable", it is announced as stable.
There is not much magic here.

Releases up to 9.0.0.M26 (2017-08-08) were alpha,
9.0.1 (2017-11-30) and 9.0.2 (2017-11-30) were beta,
9.0.4 (2018-01-22) was the first stable release.

http://tomcat.apache.org/oldnews.html
http://tomcat.apache.org/oldnews-2017.html

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62669] ResponseIncludeWrapper.getContentType() never returns NULL and sets the field

2018-09-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62669

--- Comment #1 from Mark Thomas  ---
Going back this far in svn requires a little knowledge of the project history
and how the repos have been structured over time.

There was a big re-organisation between 5.5.x and 6.0.x. The files were copied
without history so if you want to go back further than 6.0.x you need to look
into 5.5.x (then 5.0.x and then 4.1.x).

Looking in 5.5.x shows that this change was part of a patch submitted under bug
33106. Next step is to check that bug, review the patch and see if there is a
reason for this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Download Link on the Tomcat website

2018-09-01 Thread Igal Sapir

On 9/1/2018 7:33 AM, Konstantin Kolinko wrote:

пт, 31 авг. 2018 г. в 20:49, Igal Sapir :

Currently links to the Download pages can be either to the whichversion
[1] page or the version-specific pages, e.g. "Tomcat 9" [2] etc.  It
will be very useful to have a generic download.html that is
future-proof.  For example, I am writing a blog post ATM and I want to
link to a download page that will work also for future versions of
Tomcat.  We can either create a new page for that, or add links to the
whichversion page, which would be easier but not necessarily better.

I can do that myself but wanted your feedback before I make any updates
to the site.

IMHO, just link to the top page, "can be downloaded from tomcat.apache.org".


Yes, for now I will do that.  I think that a good solution might be to 
link either the Column "Apache Tomcat Version" or "Latest Released 
Version" (better, IMO) to the corresponding version download pages.


If no one has an objection I can go ahead and add those links.


I do not think that common landing page for downloads is necessary,
though I have seen projects that have one.

We can discuss what good examples are there.

One certain thing: if such page is made, please make it static so that
Release Managers wouldn't be required to update it for each release.


Definitely.  I wouldn't want to make anyone's life harder.


Also we have other projects besides Tomcat here (mod_jk, taglibs, maven plugin).
The top page has one (latest) announcement for each project and those
have a download link.


Also, is Tomcat 9 considered the current Stable version or is it still
in Beta?  I don't recall seeing any announcements about it being Stable
but it's possible that I just missed that.

It was not so long ago, though it feels like a lot of time has passed.

All announcements can be found in the "old news" link on the web site,
as well as in multiple archives of the "announcement@tomcat" mailing list.

The actual votes are available in archives of the "VOTE" threads of
dev@. Once a version is votes as "stable", it is announced as stable.
There is not much magic here.

Releases up to 9.0.0.M26 (2017-08-08) were alpha,
9.0.1 (2017-11-30) and 9.0.2 (2017-11-30) were beta,
9.0.4 (2018-01-22) was the first stable release.

http://tomcat.apache.org/oldnews.html
http://tomcat.apache.org/oldnews-2017.html

Best regards,
Konstantin Kolinko


Thanks!  That's the information I was looking for.

Best,

Igal


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62670] New: driverManagerProtection in JreMemoryLeakPreventionListener results in java.sql.SQLException: No suitable driver found

2018-09-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62670

Bug ID: 62670
   Summary: driverManagerProtection in
JreMemoryLeakPreventionListener results in
java.sql.SQLException: No suitable driver found
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: srp.na...@gmail.com
  Target Milestone: 

Created attachment 36128
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36128&action=edit
index.jsp file - can be dropped in any example webapps

Tomcat shows "java.sql.SQLException: No suitable driver found for
jdbc:postgresql://localhost:5432/postgres ..." (applies to other drivers too)
when the driver class is not explicitly loaded using Class.forName("...")

The DriverManager
(https://docs.oracle.com/javase/8/docs/api/java/sql/DriverManager.html) spec
states that this is not required (The jdbc4+ drivers use service loaders to
register themselves)

This seems to be because of driverManagerProtection in
JreMemoryLeakPreventionListener. When this flag is set to 'false' in
conf/server.xml, the database connection works as expected. 

The bug was observed when postgresql-42.2.2.jar was placed in CATALINA_HOME/lib
or in CATALINA_HOME/webapps/examples/WEB-INF/lib/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org