[Bug 62662] New: Multithreaded JSP compilation generates invalid web.xml

2018-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62662

Bug ID: 62662
   Summary: Multithreaded JSP compilation generates invalid
web.xml
   Product: Tomcat 8
   Version: 8.5.33
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Jasper
  Assignee: dev@tomcat.apache.org
  Reporter: apa...@nospam.obeliks.de
  Target Milestone: 

The multi-threaded JSP compilation introduced in 8.5.33 with Bug 53492 can
create race conditions that lead to invalid web.xml (fragments) to be
generated. 

Since access of output streams in `generateWebMapping` is not thread-safe, this
can cause mappings to be interleaved, like in this (real-life) example:


>
>
> org.apache.jsp.WEB_002dINF.jsp.admin.seoKeywordsCmsTable_jsp
>
>
>
> org.apache.jsp.WEB_002dINF.jsp.admin.seo.seokeywordtable_jsp
>
> /WEB-INF/jsp/admin/seo/seoKeywordsCmsTable.jsp/WEB-INF/jsp/admin/seo/seokeywordtable.jsp
>
>
>

Obviously, this causes an error on startup.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62662] Multithreaded JSP compilation generates invalid web.xml

2018-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62662

--- Comment #1 from Bernhard Frauendienst  ---
Created attachment 36122
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36122&action=edit
Patch to synchronize multi-threaded access to output streams

Attached patch should be sufficient to prevent chunks getting mixed up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62664] New: @MultipartConfig, getParts(), and getParameter() on PUT requests

2018-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62664

Bug ID: 62664
   Summary: @MultipartConfig, getParts(), and getParameter() on
PUT requests
   Product: Tomcat 9
   Version: 9.0.11
  Hardware: Macintosh
Status: NEW
  Severity: normal
  Priority: P2
 Component: Servlet
  Assignee: dev@tomcat.apache.org
  Reporter: schn...@gmail.com
  Target Milestone: -

Created attachment 36123
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36123&action=edit
HttpServlet subclass which will echo parameters for POST and for PUT before and
after calling getParts()

This is about a servlet annotated with @MultipartConfig.

For POST requests, "parts with form-data as the Content-Disposition but without
a filename" are available to getParameter*.

For PUT requests, such parts are not initially available to getParameter*.  If
I call getParameter* before getParts(), they are never available to
getParameter*, even after calling getParts().  If I call getParts() first, then
they are available to getParameter*.

The servlet spec does not appear to require that PUT and POST should behave
differently for multipart requests in servlets annotated with @MultipartConfig.
 Even if it did, it seems very surprising that the call order of getParts() vs
getParameter* would affect which parameters were available.

Tried on Tomcat 9.0.11 (and also some earlier versions), with Oracle Java 8.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62666] New: More tomcat localization for ServerStatus page

2018-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62666

Bug ID: 62666
   Summary: More tomcat localization for ServerStatus page
   Product: Tomcat 9
   Version: 9.0.x
  Hardware: PC
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Servlet
  Assignee: dev@tomcat.apache.org
  Reporter: a.chebykin.moroz...@gmail.com
  Target Milestone: -

Created attachment 36125
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36125&action=edit
patch for tomcat 9

Hello, 
I would like  to suggest a patch for tomcat 9 for more localization of
theServerStatus web-page. I changed filesStatusTransformer and
StatusManagerServlet, so now you can internationalize part of ServerStatus
web-page like you can ilocalize ManagerApp, HostManager and ServerStatus(some
part) web-pages. I mean that part of ServerStatus that was written only in
HTML, now you can internationalize it. At the moment I've updated  localization
for English and Russian languages

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org