Re: [Git migration] Documentation

2018-08-28 Thread Christopher Schultz 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Mark,

On 8/27/18 16:42, Mark Thomas wrote:
> We refer to svn in various places. Main web site, docs,
> BUILDING.txt etc.
> 
> The issue is when do we update the various docs. The main website
> we can update whenever, but the version specific docs normally only
> get updated when we do a release.
> 
> My suggested solution is to do the migration and once we are happy
> that the git repo is correct and we formally make it the master
> then we: - update the main web site ASAP - [ANNOUNCE] email to the
> community - Release 9.0.x, 8.5.x and 7.0.x ASAP with updated docs
> that refer to git rather than svn.
> 
> An added benefit is going through the release process soon after
> the migration should highlight any issues (I'm not expecting any)
> quickly.

Shall we do a special doc-only release with a short voting window? I'm
sure if we schedule it, we could do a vote in a few hours and push it
out immediately, rather than waiting the traditional 72 hours.

- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAluFUp0ACgkQHPApP6U8
pFgphBAApks0G+ReWP5XsPIXawWXiO0H/gUzdeAa1dR/JgRY+xpiBgsKkHtqnv86
+ZMCRQr9uvHDuqjEHFlmvaZSKCo18M6TniCcI1mB72TqbGoON6zj/z+fdA1qq6ur
4j24GbebudUYN6uf8RDyqEBqtsfPE33AyADbtyuLrl5fLZ1z0uRNqiXdpNEQ5fpQ
0efOfQoRZ0krhmFNjqDFS8XlCZNHDSYHcXeC1s0OpwE2TVL+l+SBK5ExwtKleQuz
xes98wJSiydsnN9mkNlYoMxh3YbeHleuuO5p7jywvcERj5R7QIVv1dyQP6QnMwyj
zV/jKxvTO8Q+H3heiLAGteKWCKPyKTTgBC+B6OhBP1CkwAK7MCQNLiLio47Bxw6a
IU8RVpSgpk6vOG0e/8XsvnoAhCko+rsqWlDYcR8T7jyv5y/+jhMhp3MDz9DD5q1L
hl2GmvG36ky29UNTH7v/GnqhjeduL1bxPWWIH0QC5j6Zeh13pK7mdP/H2JxohfIg
ZHxnocdJcKrgRmFaoGDUVgBS8Bl232hq16VS8HOjSmaJbAfjxomijHoIVroW2z5q
Ar34Mft9RiZquHSqZrQdMUpukPbS5QkHKGT4gwm+gBkwcQUuAuwWJ7ek9+29CHfQ
UXarViaPRttj8G8pMbeqfuYLxONvp3TStkx9KPqz2XMVWM0jt7Y=
=kifR
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release JK 1.2.44

2018-08-28 Thread Martin Knoblauch 
On Fri, Aug 24, 2018 at 6:56 PM Mark Thomas  wrote:

> Tag:
> http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_44/
>
> Source:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/
>
>
> This is a maintenance release with a handful of bug fixes and some
> clean-up. It also includes Windows binaries for IIS.
>
>
> The proposed JK 1.2.44 release is:
> [ ] Broken - do not release
> [ x] Stable - go ahead and release as 1.2.44
>
>  +1

Built/running on SLES11SP3 with HTTPD-2.4.34.

Cheers
Martin
-- 
--
Martin Knoblauch
email: k n o b i AT knobisoft DOT de
www: http://www.knobisoft.de

Re: [VOTE] Release JK 1.2.44

2018-08-28 Thread Mark Thomas 
On 24/08/18 17:56, Mark Thomas wrote:
> Tag:
> http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_44/
> 
> Source:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/
> 
> 
> This is a maintenance release with a handful of bug fixes and some
> clean-up. It also includes Windows binaries for IIS.
> 
> 
> The proposed JK 1.2.44 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 1.2.44

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1839513 - /tomcat/trunk/test/org/apache/catalina/core/TestApplicationContextGetRequestDispatcher.java

2018-08-28 Thread markt 
Author: markt
Date: Tue Aug 28 23:17:52 2018
New Revision: 1839513

URL: http://svn.apache.org/viewvc?rev=1839513&view=rev
Log:
Correct default servlet mapping

Modified:

tomcat/trunk/test/org/apache/catalina/core/TestApplicationContextGetRequestDispatcher.java

Modified: 
tomcat/trunk/test/org/apache/catalina/core/TestApplicationContextGetRequestDispatcher.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestApplicationContextGetRequestDispatcher.java?rev=1839513&r1=1839512&r2=1839513&view=diff
==
--- 
tomcat/trunk/test/org/apache/catalina/core/TestApplicationContextGetRequestDispatcher.java
 (original)
+++ 
tomcat/trunk/test/org/apache/catalina/core/TestApplicationContextGetRequestDispatcher.java
 Tue Aug 28 23:17:52 2018
@@ -380,7 +380,7 @@ public class TestApplicationContextGetRe
 
 // Add a default servlet to return 404 for not found resources
 Tomcat.addServlet(ctx, "Default", new Default404Servlet());
-ctx.addServletMappingDecoded("/*", "Default");
+ctx.addServletMappingDecoded("/", "Default");
 
 // Add a target servlet to dispatch to
 Tomcat.addServlet(ctx, "target", new TargetServlet());
@@ -414,7 +414,7 @@ public class TestApplicationContextGetRe
 }
 
 
-private static class Default404Servlet extends HttpServlet {
+static class Default404Servlet extends HttpServlet {
 
 private static final long serialVersionUID = 1L;
 private static final String DEFAULT_404 = "DEFAULT-404";



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-trunk

2018-08-28 Thread buildbot 
The Buildbot has detected a new failure on builder tomcat-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3543

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1839513
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release JK 1.2.44

2018-08-28 Thread Keiichi Fujino 
2018年8月25日(土) 1:56 Mark Thomas :

> Tag:
> http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_44/
>
> Source:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/
>
>
> This is a maintenance release with a handful of bug fixes and some
> clean-up. It also includes Windows binaries for IIS.
>
>
> The proposed JK 1.2.44 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 1.2.44
>
> Build successfully and a simple testing(status worker and ajp worker)
works fine.
Build on RHEL 7.5.


-
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> --
> Keiichi.Fujino
>

svn commit: r1839543 - in /tomcat/trunk/java/org/apache/catalina/tribes: membership/MemberImpl.java tipis/AbstractReplicatedMap.java

2018-08-28 Thread kfujino 
Author: kfujino
Date: Wed Aug 29 06:45:30 2018
New Revision: 1839543

URL: http://svn.apache.org/viewvc?rev=1839543&view=rev
Log:
Fix toString method

Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java

tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java?rev=1839543&r1=1839542&r2=1839543&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java Wed 
Aug 29 06:45:30 2018
@@ -540,7 +540,7 @@ public class MemberImpl implements Membe
 buf.append("id=").append(bToS(this.uniqueId)).append(", ");
 buf.append("payload=").append(bToS(this.payload,8)).append(", ");
 buf.append("command=").append(bToS(this.command,8)).append(", ");
-buf.append("domain=").append(bToS(this.domain,8)).append(", ");
+buf.append("domain=").append(bToS(this.domain,8));
 buf.append("]");
 return buf.toString();
 }

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java?rev=1839543&r1=1839542&r2=1839543&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java 
Wed Aug 29 06:45:30 2018
@@ -1422,6 +1422,7 @@ public abstract class AbstractReplicated
 buf.append(key);
 buf.append("; value=");
 buf.append(value);
+buf.append("]");
 return buf.toString();
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1839544 - in /tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes: membership/MemberImpl.java tipis/AbstractReplicatedMap.java

2018-08-28 Thread kfujino 
Author: kfujino
Date: Wed Aug 29 06:46:20 2018
New Revision: 1839544

URL: http://svn.apache.org/viewvc?rev=1839544&view=rev
Log:
Fix toString method

Modified:

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java?rev=1839544&r1=1839543&r2=1839544&view=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java 
(original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java 
Wed Aug 29 06:46:20 2018
@@ -540,7 +540,7 @@ public class MemberImpl implements Membe
 buf.append("id=").append(bToS(this.uniqueId)).append(", ");
 buf.append("payload=").append(bToS(this.payload,8)).append(", ");
 buf.append("command=").append(bToS(this.command,8)).append(", ");
-buf.append("domain=").append(bToS(this.domain,8)).append(", ");
+buf.append("domain=").append(bToS(this.domain,8));
 buf.append("]");
 return buf.toString();
 }

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java?rev=1839544&r1=1839543&r2=1839544&view=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
 Wed Aug 29 06:46:20 2018
@@ -1421,6 +1421,7 @@ public abstract class AbstractReplicated
 buf.append(key);
 buf.append("; value=");
 buf.append(value);
+buf.append("]");
 return buf.toString();
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1839545 - in /tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes: membership/MemberImpl.java tipis/AbstractReplicatedMap.java

2018-08-28 Thread kfujino 
Author: kfujino
Date: Wed Aug 29 06:47:07 2018
New Revision: 1839545

URL: http://svn.apache.org/viewvc?rev=1839545&view=rev
Log:
Fix toString method

Modified:

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java?rev=1839545&r1=1839544&r2=1839545&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java 
(original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java 
Wed Aug 29 06:47:07 2018
@@ -549,7 +549,7 @@ public class MemberImpl implements Membe
 buf.append("id=").append(bToS(this.uniqueId)).append(", ");
 buf.append("payload=").append(bToS(this.payload,8)).append(", ");
 buf.append("command=").append(bToS(this.command,8)).append(", ");
-buf.append("domain=").append(bToS(this.domain,8)).append(", ");
+buf.append("domain=").append(bToS(this.domain,8));
 buf.append("]");
 return buf.toString();
 }

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java?rev=1839545&r1=1839544&r2=1839545&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
 (original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
 Wed Aug 29 06:47:07 2018
@@ -1441,6 +1441,7 @@ public abstract class AbstractReplicated
 buf.append(key);
 buf.append("; value=");
 buf.append(value);
+buf.append("]");
 return buf.toString();
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org