[Bug 62527] Lookupname Validation in ResourceBase

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62527

--- Comment #1 from Remy Maucherat  ---
I think r1831256 should be partially reverted due to this existing use. I plan
to do it shortly unless there's a disagreement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62527] Lookupname Validation in ResourceBase

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62527

Mark Thomas  changed:

   What|Removed |Added

   Severity|normal  |enhancement

--- Comment #2 from Mark Thomas  ---
This behaviour is required by the Java EE spec. I am therefore moving this to
an enhancement to add an option to ignore the specification requirement.

Implementation looks to be non-trivial. If implemented, moving the check to the
NamingContextListener looks like the best option as that has access to the
Context/Server so this could be configured per Context rather than globally.

Fixing the non-specification compliant usage would be a better solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62527] Lookupname Validation in ResourceBase

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62527

--- Comment #3 from Remy Maucherat  ---
Well, ok, but there is existing use and I don't see a benefit of being strict
here (it's not like a URL or HTTP element where security issues can occur). So
the fix sounds more like a regression than an improvement to me. I think it
would be ok to do it in Tomcat.next, but probably not here, at least not by
default.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62527] Lookupname Validation in ResourceBase

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62527

--- Comment #4 from romain.manni-bucau  ---
Yes, issue is really it breaks a lot of users (we already lived that years ago
and all apps needed to be reconfigured).

There is a flag for strict compliance in tomcat already so maybe this is a
behavior falling into that "disabled by default but activable" behavior. Will
not hurt users. Also note that it conflicts with JNDI spec which enables to
have any namespace so you can read the spec from the point of view matching
your need in such a case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62527] Lookupname Validation in ResourceBase

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62527

--- Comment #5 from Mark Thomas  ---
I've had another read of the relevant bits of the Java EE spec and I can't see
a clear reason for this limitation. There are some hints that suggest it is to
do with the scopes of the various defined namespaces and making sure the
application sees the JNDI context it expects. But I don't see why that should
stop some other namespace being used - obviously with the onus on the user to
make sure they are using it correctly / it behaves as they expect w.r.t.
returned types, shared/unique instances, visibility scope etc.

Given that this change was only applied because it was noticed that the
validation was missing while reviewing the lookup name implementation - rather
than as a result of a bug report or similar - then I've no objection to the
validation being reverted if that is the preferred option. Note it would need
to be reverted from all current versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57665] support x-forwarded-host

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665

frank.michael.busin...@gmail.com changed:

   What|Removed |Added

 CC||frank.michael.business@gmai
   ||l.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1835543 - in /tomcat/trunk: java/org/apache/tomcat/util/descriptor/web/LocalStrings.properties java/org/apache/tomcat/util/descriptor/web/ResourceBase.java webapps/docs/changelog.xml

[remm]

Author: remm
Date: Tue Jul 10 12:14:58 2018
New Revision: 1835543

URL: http://svn.apache.org/viewvc?rev=1835543&view=rev
Log:
62527: Revert restriction of JNDI to the java: namespace.

Modified:

tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/LocalStrings.properties
tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/LocalStrings.properties?rev=1835543&r1=1835542&r2=1835543&view=diff
==
--- 
tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/LocalStrings.properties 
(original)
+++ 
tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/LocalStrings.properties 
Tue Jul 10 12:14:58 2018
@@ -15,7 +15,6 @@
 
 filterDef.invalidFilterName=Invalid  [{0}] in filter definition.
 
-resourceBase.lookupNotJava=Lookup-name values must explicitly reference the 
java: namespace but [{0}] does not
 securityConstraint.uncoveredHttpMethod=For security constraints with URL 
pattern [{0}] only the HTTP methods [{1}] are covered. All other methods are 
uncovered.
 securityConstraint.uncoveredHttpMethodFix=Adding security constraints with URL 
pattern [{0}] to deny access with the uncovered HTTP methods that are not one 
of the following [{1}]
 securityConstraint.uncoveredHttpOmittedMethod=For security constraints with 
URL pattern [{0}] the HTTP methods [{1}] are uncovered.

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java?rev=1835543&r1=1835542&r2=1835543&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java 
Tue Jul 10 12:14:58 2018
@@ -91,15 +91,10 @@ public class ResourceBase implements Ser
 }
 
 public void setLookupName(String lookupName) {
-// EE.5.3.3: Must explicitly use java: namespace
 if (lookupName == null || lookupName.length() == 0) {
 this.lookupName = null;
 return;
 }
-if (!lookupName.startsWith("java:")) {
-throw new IllegalArgumentException(
-sm.getString("resourceBase.lookupNotJava", lookupName));
-}
 this.lookupName = lookupName;
 }
 

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1835543&r1=1835542&r2=1835543&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Jul 10 12:14:58 2018
@@ -66,6 +66,10 @@
 filter and improve the cacheability of requests that pass through the
 COPRS filter. (markt)
   
+  
+62527: Revert restriction of JNDI to the java:
+namespace. (remm)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1835544 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/descriptor/web/LocalStrings.properties java/org/apache/tomcat/util/descriptor/web/ResourceBase.java webapps/docs/changel

[remm]

Author: remm
Date: Tue Jul 10 12:17:11 2018
New Revision: 1835544

URL: http://svn.apache.org/viewvc?rev=1835544&view=rev
Log:
 62527: Revert restriction of JNDI to the java: namespace.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/descriptor/web/LocalStrings.properties

tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jul 10 12:17:11 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 
3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-17

svn commit: r1835545 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/descriptor/web/LocalStrings.properties java/org/apache/tomcat/util/descriptor/web/ResourceBase.java webapps/docs/changel

[remm]

Author: remm
Date: Tue Jul 10 12:20:00 2018
New Revision: 1835545

URL: http://svn.apache.org/viewvc?rev=1835545&view=rev
Log:
 62527: Revert restriction of JNDI to the java: namespace.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/descriptor/web/LocalStrings.properties

tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jul 10 12:20:00 2018
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1779898,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693,1802805,1806799,1807079-1807080,1808880,1809831,1812093,1812143,1812145,1812319,1814975,1815945,1815956,1820207,1822186,1823164,1823497,1824960,1826872-1826873,1827862,1829310,1829777,1829796,1829935,1830215,1830991,1831042,1831557,1831569,1832269,1832271,1832693,1832967,1833809,1833919
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679

svn commit: r1835547 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/LocalStrings.properties java/org/apache/catalina/deploy/ResourceBase.java webapps/docs/changelog.xml

[remm]

Author: remm
Date: Tue Jul 10 12:22:47 2018
New Revision: 1835547

URL: http://svn.apache.org/viewvc?rev=1835547&view=rev
Log:
 62527: Revert restriction of JNDI to the java: namespace.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/deploy/LocalStrings.properties
tomcat/tc7.0.x/trunk/java/org/apache/catalina/deploy/ResourceBase.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jul 10 12:22:47 2018
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281
 
4,1803618,1806107,1806733,1807082-1807083,1808707,1808884,1809267,1809644,1809832,1809904,1809915,1809924,1810283,1810328,1810574,1810576-1810577,1810584,1810588,1811141,1811842,1812090,1812096,1812150,1812511,1814976,1814983,1815072,1815453,1815946,1815957,1816143,1816682,1817229,1817287,1820200,1820209,1820283,1820305,1821303-1821311,1821313,

[Bug 62527] Lookupname Validation in ResourceBase

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62527

Remy Maucherat  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #6 from Remy Maucherat  ---
Nice, it's a lot simpler this way !
The fix will be in 9.0.11, 8.5.33, 8.0.54 and 7.0.91.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1835548 - in /tomcat/trunk/bin: makebase.bat makebase.sh

[markt]

Author: markt
Date: Tue Jul 10 12:39:46 2018
New Revision: 1835548

URL: http://svn.apache.org/viewvc?rev=1835548&view=rev
Log:
Update usage info

Modified:
tomcat/trunk/bin/makebase.bat
tomcat/trunk/bin/makebase.sh

Modified: tomcat/trunk/bin/makebase.bat
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.bat?rev=1835548&r1=1835547&r2=1835548&view=diff
==
--- tomcat/trunk/bin/makebase.bat (original)
+++ tomcat/trunk/bin/makebase.bat Tue Jul 10 12:39:46 2018
@@ -22,7 +22,7 @@ rem
 rem If the file %CATALINA_HOME%/bin/setenv.sh exists then it is copied to
 rem the target directory as well.
 rem
-rem Usage: makebase 
+rem Usage: makebase  [-w | --webapps]
 
 setlocal
 

Modified: tomcat/trunk/bin/makebase.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.sh?rev=1835548&r1=1835547&r2=1835548&view=diff
==
--- tomcat/trunk/bin/makebase.sh (original)
+++ tomcat/trunk/bin/makebase.sh Tue Jul 10 12:39:46 2018
@@ -23,7 +23,7 @@
 # If the file $CATALINA_HOME/bin/setenv.sh exists then it is copied to
 # the target directory as well.
 #
-# Usage: makebase 
+# Usage: makebase  [-w | --webapps]
 
 # resolve links - $0 may be a softlink
 PRG="$0"



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1835554 - /tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java

[markt]

Author: markt
Date: Tue Jul 10 13:48:54 2018
New Revision: 1835554

URL: http://svn.apache.org/viewvc?rev=1835554&view=rev
Log:
Trivial commit to trigger CI build

Modified:
tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java?rev=1835554&r1=1835553&r2=1835554&view=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java 
(original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java Tue 
Jul 10 13:48:54 2018
@@ -44,5 +44,4 @@ public class ServerinfoTask extends Abst
 execute("/serverinfo");
 
 }
-
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1835555 - /tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java

[markt]

Author: markt
Date: Tue Jul 10 13:55:39 2018
New Revision: 183

URL: http://svn.apache.org/viewvc?rev=183&view=rev
Log:
Trivial commit to trigger CI build

Modified:
tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java?rev=183&r1=1835554&r2=183&view=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java 
(original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/ant/ServerinfoTask.java Tue 
Jul 10 13:55:39 2018
@@ -14,8 +14,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-
 package org.apache.catalina.ant;
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1835584 - /tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java

[markt]

Author: markt
Date: Tue Jul 10 17:14:02 2018
New Revision: 1835584

URL: http://svn.apache.org/viewvc?rev=1835584&view=rev
Log:
Remove unused code

Modified:
tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java?rev=1835584&r1=1835583&r2=1835584&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/ResourceBase.java 
Tue Jul 10 17:14:02 2018
@@ -23,8 +23,6 @@ import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 
-import org.apache.tomcat.util.res.StringManager;
-
 
 /**
  * Representation of an Context element
@@ -35,8 +33,6 @@ public class ResourceBase implements Ser
 
 private static final long serialVersionUID = 1L;
 
-private static final StringManager sm = 
StringManager.getManager(ResourceBase.class);
-
 
 // - Properties
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62526] Tomcat fails in a strange way when key store is missing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62526

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Mark Thomas  ---
This looks like a malformed key store.

Steps to reproduce (or at least to create the keystore) please.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62526] Tomcat fails in a strange way when key store is missing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62526

--- Comment #2 from Fabrice Bacchella  ---
I generated this key store using http://keystore-explorer.org.

I switched many times between empty password, defined password for store or the
key. From the 4 possible configurations, only the one where
certificateKeystorePassword is defined works. As soon as I remove it, I got
this exception. When I put it back, it's ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62526] Tomcat fails in a strange way when key store is missing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62526

--- Comment #3 from Mark Thomas  ---
Which version of Java are you running Tomcat with?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62526] Tomcat fails in a strange way when key store is missing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62526

--- Comment #4 from Fabrice Bacchella  ---
Oracle 1.8.0_162

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62526] Tomcat fails in a strange way when key store is missing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62526

Mark Thomas  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #5 from Mark Thomas  ---
Thanks. I can now see what is happening.

In Java 6 and earlier, the KeyStore implementation didn't support the empty
String as a valid password. Tomcat therefore converted it to null. KeyStore
doesn't return certificates if null is provided for the KeyStore password.

As of Java 7 (the latest version at least), KeyStore does support empty
passwords. We need to make some changes to allow empty passwords to be used.
For 8.5.x onwards it should be fairly easy since they require Java 7 as a
minimum. 7.0.x will be a little trickier as it has a minimum requirement of
Java 6.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Feature Request: Add a YUM Package for Tomcat

[Michel Feinstein]

 Hi developers, I just want  to post here a feature request.

There are several tutorials online on how to get Tomcat (any version)
running on a server. They will be mostly about using "wget" to download the
binaries and adding SystemV or systemd init files.

Those are fine, they work, but it makes harder to update Tomcat and a YUM
package is just a lot easier to manage, install, update, etc.

I am using AWS EC2 with an Amazon Linux AMI 2, so a systemd Linux
distribution that supports YUM and there isn't a YUM package for Tomcat 9
(at least not one that I can find anywhere).

I am not an experienced Linux user, so I don't know much about the
difficulties of YUM packaging or setting up an external YUM repository
(outside from the AWS managed one I mean), but I think the effort of adding
such a product into the Tomcat development process will be very much
welcome.

Thank you!

svn commit: r1835602 - /tomcat/tc8.0.x/trunk/res/maven/mvn-pub.xml

[rjung]

Author: rjung
Date: Tue Jul 10 23:59:17 2018
New Revision: 1835602

URL: http://svn.apache.org/viewvc?rev=1835602&view=rev
Log:
Fix the maven release deploy task: signing fails
for the zip binary artefact, because the zip
file name suffix was missing.

The problem is specific for TC 8.0.x, older
branches use a very different task file,
newer versions do not contain this bug.

Modified:
tomcat/tc8.0.x/trunk/res/maven/mvn-pub.xml

Modified: tomcat/tc8.0.x/trunk/res/maven/mvn-pub.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/res/maven/mvn-pub.xml?rev=1835602&r1=1835601&r2=1835602&view=diff
==
--- tomcat/tc8.0.x/trunk/res/maven/mvn-pub.xml (original)
+++ tomcat/tc8.0.x/trunk/res/maven/mvn-pub.xml Tue Jul 10 23:59:17 2018
@@ -170,8 +170,8 @@
 
 
 
-  
-  
+  
+  
 
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62164] Build for Eclipse IDE does not work

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62164

--- Comment #8 from Jaikiran Pai  ---
FWIW - a vote for releasing Ant with this fix is in progress, if anyone wants
to try it out https://www.mail-archive.com/dev@ant.apache.org/msg47371.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org