Bug report for Tomcat 9 [2018/07/01]

2018-07-01 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|57505|New|Enh|2015-01-27|Add integration tests for JspC|
|57661|New|Enh|2015-03-04|Delay sending of 100 continue response until appli|
|58242|New|Enh|2015-08-13|Scanning jars in classpath to get annotations in p|
|58530|New|Enh|2015-10-23|Proposal for new Manager HTML GUI |
|58548|New|Enh|2015-10-26|support certifcate transparency   |
|58590|New|Enh|2015-11-05|org.apache.catalina.realm.MemoryRealm can use back|
|58859|New|Enh|2016-01-14|Allow to limit charsets / encodings supported by T|
|59203|New|Enh|2016-03-21|Try to call Thread.interrupt before calling Thread|
|59344|Ver|Enh|2016-04-18|PEM file support for JSSE |
|59750|New|Enh|2016-06-24|Amend "authenticate" method with context by means |
|59901|New|Enh|2016-07-26|Reduce I/O associated with JSP compilation|
|60997|New|Enh|2017-04-17|Enhance SemaphoreValve to support denied status an|
|61171|New|Enh|2017-06-09|Add port offset attribute (portOffset?) to Server |
|61692|New|Enh|2017-10-28|CGIServlet should handle additional HTTP methods, |
|61971|New|Enh|2018-01-06|documentation for using tomcat with systemd   |
|62048|New|Enh|2018-01-25|Missing logout function in Manager and Host-Manage|
|62072|New|Enh|2018-02-01|Add support for request compression   |
|62140|New|Enh|2018-02-27|catalina.sh should document the verbs it accepts a|
|62312|New|Enh|2018-04-18|Add Proxy Authentication support to websocket clie|
|62405|New|Enh|2018-05-23|Add Rereadable Request Filter |
|62453|New|Enh|2018-06-14|Tomcat tries to resolve uninitialized tag attribut|
|62488|New|Enh|2018-06-25|Obtain dependencies from Maven Central where possi|
|62500|New|Nor|2018-06-27|Add Shell Script to Create CATALINA_BASE Directori|
+-+---+---+--+--+
| Total   23 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat Modules [2018/07/01]

2018-07-01 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen|
|51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho|
|51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods   |
|52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o|
|53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe|
|54437|New|Enh|2013-01-16|Update PoolProperties javadoc for ConnectState int|
|54929|Inf|Nor|2013-05-05|jdbc-pool cannot be used with Java 1.5, "java.lang|
|55078|New|Nor|2013-06-07|Configuring a DataSource Resource with dataSourceJ|
|55662|New|Enh|2013-10-17|Add a way to set an instance of java.sql.Driver di|
|56046|New|Enh|2014-01-21|org.apache.tomcat.jdbc.pool.XADataSource InitSQL p|
|56088|New|Maj|2014-01-29|AbstractQueryReport$StatementProxy throws exceptio|
|56310|Inf|Maj|2014-03-25|PooledConnection and XAConnection not handled corr|
|56586|New|Nor|2014-06-02|initSQL should be committed if defaultAutoCommit =|
|56775|New|Nor|2014-07-28|PoolCleanerTime schedule issue|
|56779|New|Nor|2014-07-28|Allow multiple connection initialization statement|
|56790|New|Nor|2014-07-29|Resizing pool.maxActive to a higher value at runti|
|56798|New|Nor|2014-07-31|Idle eviction strategy could perform better (and i|
|56804|New|Nor|2014-08-02|Use a default validationQueryTimeout other than "f|
|56805|New|Nor|2014-08-02|datasource.getConnection() may be unnecessarily bl|
|56837|New|Nor|2014-08-11|if validationQuery have error with timeBetweenEvic|
|56970|New|Nor|2014-09-11|MaxActive vs. MaxTotal for commons-dbcp and tomcat|
|56974|New|Nor|2014-09-12|jdbc-pool validation query defaultAutoCommit statu|
|57460|New|Nor|2015-01-19|[DB2]Connection broken after few hours but not rem|
|57729|New|Enh|2015-03-20|Add QueryExecutionReportInterceptor to log query e|
|58489|Opn|Maj|2015-10-08|QueryStatsComparator throws IllegalArgumentExcepti|
|59077|New|Nor|2016-02-26|DataSourceFactory creates a neutered data source  |
|59569|New|Nor|2016-05-18|isWrapperFor/unwrap implementations incorrect |
|59879|New|Nor|2016-07-18|StatementCache interceptor returns ResultSet objec|
|60195|New|Nor|2016-10-02|No javadoc in Maven Central   |
|60522|New|Nor|2016-12-27|An option for setting if the transaction should be|
|60524|Inf|Nor|2016-12-28|NPE in SlowQueryReport in tomcat-jdbc-7.0.68  |
|60645|New|Nor|2017-01-25|StatementFinalizer is not thread-safe |
|61032|New|Nor|2017-04-24|min pool size is not being respected  |
|61103|New|Nor|2017-05-18|StatementCache potentially caching non-functional |
|61302|New|Enh|2017-07-15|Refactoring of DataSourceProxy|
|61303|New|Enh|2017-07-15|Refactoring of ConnectionPool |
|62432|New|Nor|2018-06-06|Memory Leak in Statement Finalizer?   |
+-+---+---+--+--+
| Total   37 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Taglibs [2018/07/01]

2018-07-01 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field   |
|38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)|
|42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements   |
|46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l|
|48333|New|Enh|2009-12-02|TLD generator |
|57548|New|Min|2015-02-08|Auto-generate the value for org.apache.taglibs.sta|
|57684|New|Min|2015-03-10|Version info should be taken from project version |
|59359|New|Enh|2016-04-20|(Task) Extend validity period for signing KEY - be|
|59668|New|Nor|2016-06-06|x:forEach retains the incorrect scope when used in|
|61875|New|Nor|2017-12-08|Investigate whether Xalan can be removed  |
+-+---+---+--+--+
| Total   10 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat Native [2018/07/01]

2018-07-01 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration|
|56378|New|Nor|2014-04-09|Cert load fails if cert is located in path with no|
|57815|New|Enh|2015-04-15|Improve error message when OpenSSL does not suppor|
|58194|Inf|Maj|2015-07-30|Tomcat crash EXCEPTION_ACCESS_VIOLATION in tcnativ|
|59286|New|Nor|2016-04-07|Socket binding failures when using APR|
+-+---+---+--+--+
| Total5 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat 8 [2018/07/01]

2018-07-01 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|53737|Opn|Enh|2012-08-18|Use ServletContext.getJspConfigDescriptor() in Jas|
|53930|New|Enh|2012-09-24|allow capture of catalina stdout/stderr to a comma|
|54741|New|Enh|2013-03-22|Add org.apache.catalina.startup.Tomcat#addWebapp(S|
|55243|New|Enh|2013-07-11|Add special search string for nested roles|
|55252|New|Enh|2013-07-12|Separate Ant and command-line wrappers for JspC   |
|55383|New|Enh|2013-08-07|Improve markup and design of Tomcat's HTML pages  |
|9|New|Enh|2013-09-14|UserDatabaseRealm enhacement: may use local JNDI  |
|55675|New|Enh|2013-10-18|Checking and handling invalid configuration option|
|55788|New|Enh|2013-11-16|TagPlugins should key on tag QName rather than imp|
|55969|New|Enh|2014-01-07|Security-related enhancements to the Windows Insta|
|56166|New|Enh|2014-02-20|Suggestions for exception handling (avoid potentia|
|56361|New|Enh|2014-04-08|org.apache.tomcat.websocket.WsWebSocketContainer#b|
|56398|New|Enh|2014-04-11|Support Arquillian-based unit testing |
|56399|New|Enh|2014-04-11|Re-factor request/response recycling so Coyote and|
|56402|New|Enh|2014-04-11|Add support for HTTP Upgrade to AJP components|
|56448|New|Enh|2014-04-23|Implement a robust solution for client initiated S|
|56522|Opn|Enh|2014-05-14|jasper-el 8 does not comply to EL Spec 3.0 regardi|
|56546|New|Enh|2014-05-19|Improve thread trace logging in WebappClassLoader.|
|56713|New|Enh|2014-07-12|Limit time that incoming request waits while webap|
|56724|New|Enh|2014-07-15|Restart Container background thread if it died une|
|56890|Inf|Maj|2014-08-26|getRealPath returns null  |
|56966|New|Enh|2014-09-11|AccessLogValve's elapsed time has 15ms precision o|
|57130|New|Enh|2014-10-22|Allow digest.sh to accept password from a file or |
|57287|New|Enh|2014-11-29|Sort files listed by DefaultServlet   |
|57421|New|Enh|2015-01-07|Farming default directories   |
|57486|New|Enh|2015-01-23|Improve reuse of ProtectedFunctionMapper instances|
|57665|New|Enh|2015-03-05|support x-forwarded-host  |
|57701|New|Enh|2015-03-13|Implement "[Redeploy]" button for a web applicatio|
|57830|New|Enh|2015-04-18|Add support for ProxyProtocol |
|58052|Opn|Enh|2015-06-19|RewriteValve: Implement additional RewriteRule dir|
|58072|New|Enh|2015-06-23|ECDH curve selection  |
|58143|Opn|Enh|2015-07-15|The WebppClassLoader doesn't call transformers on |
|58433|New|Enh|2015-09-21|RemoteIpValve not activated on redirect from mappi|
|58577|New|Enh|2015-11-03|JMX Proxy Servlet can't handle overloaded methods |
|58837|New|Enh|2016-01-12|support "X-Content-Security-Policy" a.k.a as "CSP"|
|58935|Opn|Enh|2016-01-29|Re-deploy from war without deleting context   |
|59232|New|Enh|2016-03-24|Make the context name of an app available via JNDI|
|59423|New|Enh|2016-05-03|amend "No LoginModules configured for ..." with hi|
|59758|New|Enh|2016-06-27|Add http proxy username-password credentials suppo|
|60281|Ver|Nor|2016-10-20|Pathname of uploaded WAR file should not be contai|
|60721|Ver|Nor|2017-02-10|Unable to find key spec if more applications use b|
|60781|New|Nor|2017-02-27|Access Log Valve does not escape the same as mod_l|
|60849|New|Enh|2017-03-13|Tomcat NIO Connector not able to handle SSL renego|
|61668|Ver|Min|2017-10-26|Possible NullPointerException in org.apache.coyote|
|61877|New|Enh|2017-12-08|use web.xml from CATALINA_HOME by default |
|61917|New|Enh|2017-12-19|AddDefaultCharsetFilter only supports text/* respo|
|62150|New|Enh|2018-03-01|Behavior of relative paths with RequestDispatcher |
|62214|New|Enh|2018-03-22|The "userSubtree=true" and "roleSubtree=true" in J|
|62245|New|Enh|2018-04-02|[Documentation] Mention contextXsltFile in Default|
|62376|Inf|Nor|2018-05-15|PropertyNotFoundException since 8.5.25|
|62496|New|Enh|2018-06-27|Add possibility write remote user/auth type to res|
|62507|

Bug report for Tomcat Connectors [2018/07/01]

2018-07-01 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca|
|47327|New|Enh|2009-06-07|Return tomcat authenticated user back to mod_jk (A|
|47750|New|Maj|2009-08-27|ISAPI: Loss of worker settings when changing via j|
|47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit|
|48564|New|Enh|2010-01-18|Allow to turn off retries for LB worker   |
|48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv|
|49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work|
|49822|New|Enh|2010-08-25|Add hash lb worker method |
|49903|New|Enh|2010-09-09|Make workers file reloadable  |
|52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus|
|53883|New|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe  on the p|
|53977|New|Maj|2012-10-07|32bits isapi connector cannot work in wow64 mode  |
|54027|New|Cri|2012-10-18|isapi send request to outside address instead of i|
|54117|New|Maj|2012-11-08|access violation exception in isapi_redirect.dll  |
|54621|New|Enh|2013-02-28|[PATCH] custom mod_jk availability checks |
|56489|New|Enh|2014-05-05|Include a directory for configuration files   |
|56576|New|Enh|2014-05-29|Websocket support |
|57402|New|Enh|2014-12-30|Provide correlation ID between mod_jk log and acce|
|57403|New|Enh|2014-12-30|Persist configuration changes made via status work|
|57407|New|Enh|2014-12-31|Make session_cookie, session_path and session_cook|
|57790|New|Enh|2015-04-03|Check worker names for typos  |
|57946|New|Nor|2015-05-23|Configuration example for mod_jk should be updated|
|58287|New|Nor|2015-08-26|Questionable use of "Global" objects on Windows   |
|59897|New|Nor|2016-07-25|Buffer Overflow in FD_SET in nb_connect (jk_connec|
|60240|New|Min|2016-10-11|Duplicate initialization log entry in mod_jk.log  |
|60745|New|Nor|2017-02-18|False positive: Somebody try to hack into the site|
|61476|New|Enh|2017-09-01|Allow reset of an individual worker stat value|
|61621|New|Enh|2017-10-15|Content-Type is forced to lowercase when it goes t|
|62093|New|Enh|2018-02-09|Allow use_server_errors to apply to specific statu|
|62169|New|Nor|2018-03-09|Not able to compile mod_jk on MacOS   |
|62408|New|Nor|2018-05-24|(New feature) Make configurable the number of retr|
|62459|New|Nor|2018-06-15|mod_jk: Forwarding URLs containing escaped slashes|
+-+---+---+--+--+
| Total   32 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat 7 [2018/07/01]

2018-07-01 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|50944|Ver|Blk|2011-03-18|JSF: java.lang.NullPointerException at com.sun.fac|
|53492|New|Enh|2012-07-01|Make JspC shell multithreaded |
|53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from |
|53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l|
|54499|New|Enh|2013-01-29|Implementation of Extensible EL Interpreter   |
|54802|New|Enh|2013-04-04|Provide location information for exceptions thrown|
|55104|New|Enh|2013-06-16|Allow passing arguments with spaces to Commons Dae|
|55470|New|Enh|2013-08-23|Help users for ClassNotFoundExceptions during star|
|55477|New|Enh|2013-08-23|Add a solution to map an realm name to a security |
|56148|New|Enh|2014-02-17|support (multiple) ocsp stapling  |
|56181|New|Enh|2014-02-23|RemoteIpValve & RemoteIpFilter: HttpServletRequest|
|56300|New|Enh|2014-03-22|[Tribes] No useful examples, lack of documentation|
|56438|New|Enh|2014-04-21|If jar scan does not find context config or TLD co|
|56614|New|Enh|2014-06-12|Add a switch to ignore annotations detection on ta|
|56787|New|Enh|2014-07-29|Simplified jndi name parsing  |
|57367|New|Enh|2014-12-18|If JAR scan experiences a stack overflow, give the|
|57827|New|Enh|2015-04-17|Enable adding/removing of members via jmx in a sta|
|57872|New|Enh|2015-04-29|Do not auto-switch session cookie to version=1 due|
|57892|New|Enh|2015-05-05|Log once a warning if a symbolic link is ignored (|
|58338|New|Nor|2015-09-07|BasicDataSourceFactory uses wrong attribute name  |
|59716|New|Enh|2016-06-17|Allow JNDI configuration of CorsFilter|
|60597|New|Enh|2017-01-17|Add ability to set cipher suites for websocket cli|
+-+---+---+--+--+
| Total   22 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Slides for ApacheCon EU Roadshow 2018

2018-07-01 Thread Rainer Jung

Am 01.07.2018 um 08:30 schrieb Huxing Zhang:

 From the youtube playlist[1] of Apache EU roadshow, I can see Rainer's
topic about Apache Web Server[2].

But I did not find any tomcat related topics there.

So I guess not every talk is getting recorded?


Correct. I think it dependens on the room which hosted the track. Tomcat 
was in a room without video recording, httpd got video recording. I 
think this is true for the whole track.



[1] https://www.youtube.com/playlist?list=PLU2OcwpQkYCyuV8Fza7dVAEg5FW2Pzg-8
[2] 
https://www.youtube.com/watch?v=MRx0PZilMBY&index=15&list=PLU2OcwpQkYCyuV8Fza7dVAEg5FW2Pzg-8&t=219s


Regards,

Rainer


On Wed, Jun 27, 2018 at 3:39 PM, Rainer Jung  wrote:

Am 27.06.2018 um 01:40 schrieb Huxing Zhang:


Hi All,

I have check the presentation page[1] but could only find slide of
Mark's "State of the Cat" topic.

Do we have slides/recordings for the other topics?

[1] http://tomcat.apache.org/presentations.html



Thanks for asking. I just added my two presentations.

More to come from others?

Regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org







--
kippdata
informationstechnologie GmbH   Tel: 0228 98549 -0
Bornheimer Str. 33aFax: 0228 98549 -50
53111 Bonn www.kippdata.de

HRB 8018 Amtsgericht Bonn / USt.-IdNr. DE 196 457 417
Geschäftsführer: Dr. Thomas Höfer, Rainer Jung, Sven Maurmann

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1834798 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-01 Thread isapir
Author: isapir
Date: Sun Jul  1 18:44:38 2018
New Revision: 1834798

URL: http://svn.apache.org/viewvc?rev=1834798&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62500
Added scripts to create CATALINA_BASE directory

Added:
tomcat/trunk/bin/makebase.bat
tomcat/trunk/bin/makebase.sh

Added: tomcat/trunk/bin/makebase.bat
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.bat?rev=1834798&view=auto
==
--- tomcat/trunk/bin/makebase.bat (added)
+++ tomcat/trunk/bin/makebase.bat Sun Jul  1 18:44:38 2018
@@ -0,0 +1,63 @@
+:: Licensed to the Apache Software Foundation (ASF) under one or more
+:: contributor license agreements.  See the NOTICE file distributed with
+:: this work for additional information regarding copyright ownership.
+:: The ASF licenses this file to You under the Apache License, Version 2.0
+:: (the "License"); you may not use this file except in compliance with
+:: the License.  You may obtain a copy of the License at
+::
+:: http://www.apache.org/licenses/LICENSE-2.0
+::
+:: Unless required by applicable law or agreed to in writing, software
+:: distributed under the License is distributed on an "AS IS" BASIS,
+:: WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+:: See the License for the specific language governing permissions and
+:: limitations under the License.
+
+:: This script creates the directory structure required for running Tomcat 
+:: in a separate directory by pointing %CATALINA_BASE% to it. It copies the
+:: conf directory from %CATALINA_HOME%, and creates empty directories for
+:: logs, temp, and work.
+::
+:: If the file %CATALINA_HOME%/bin/setenv.sh exists then it is copied to
+:: the target directory as well.
+
+@echo off
+
+:: first arg is the target directory
+set BASE_TGT=%1
+
+if %BASE_TGT%.==. (
+:: target directory not provided; exit
+echo "Usage: makebase "
+goto :EOF
+)
+
+set CURR_DIR=%~dp0
+set HOME_DIR=%CURR_DIR%..\
+
+if exist %BASE_TGT% (
+  :: target directory exists
+  echo directory exists
+
+:: exit if target directory is not empty
+for /F %%i in ('dir /b "%BASE_TGT%\*.*"') do (
+echo target directory is not empty
+goto :EOF
+)
+) else ( 
+:: create the target directory
+mkdir %BASE_TGT%
+)
+
+:: create empty directories for bin, logs, temp, and work
+mkdir %BASE_TGT%\bin %BASE_TGT%\logs %BASE_TGT%\temp %BASE_TGT%\work
+
+:: copy conf directory
+robocopy %HOME_DIR%\conf %BASE_TGT%\conf > nul
+
+:: copy setenv.bat if exists
+robocopy %HOME_DIR%\bin %BASE_TGT%\bin setenv.bat > nul
+
+echo created CATALINA_BASE directory at $BASE_TGT
+
+:EOF

Added: tomcat/trunk/bin/makebase.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.sh?rev=1834798&view=auto
==
--- tomcat/trunk/bin/makebase.sh (added)
+++ tomcat/trunk/bin/makebase.sh Sun Jul  1 18:44:38 2018
@@ -0,0 +1,64 @@
+#!/bin/sh
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This script creates the directory structure required for running Tomcat 
+# in a separate directory by pointing $CATALINA_BASE to it. It copies the
+# conf directory from $CATALINA_HOME, and creates empty directories for
+# bin, logs, temp, and work.
+#
+# If the file $CATALINA_HOME/bin/setenv.sh exists then it is copied to
+# the target directory as well.
+
+# first arg is the target directory
+BASE_TGT=$1
+
+if [ -z ${BASE_TGT} ]; then
+# target directory not provided; exit
+echo "Usage: makebase "
+exit 1
+fi
+
+HOME_DIR="$(dirname $(dirname $0))"
+
+if [ -d ${BASE_TGT} ]; then
+  # target directory exists
+  echo directory exists
+
+# exit if target directory is not empty
+[ "$(ls -A ${BASE_TGT})" ] && \
+echo "target directory is not empty" && \
+exit 1
+else 
+# create the target directory
+mkdir -p ${BASE_TGT}
+fi
+
+for dir in bin logs temp work; 
+do 
+# copy directory with permissions and delete contents if any
+cp -a "${HOME_DIR}/${dir}" "${BASE_TGT}/${dir}"
+rm -fr "${BASE_TGT}/${dir}"/*
+done
+
+# copy conf directory recursively and preserve permissions
+cp -a "$

[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

2018-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

Igal Sapir  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #16 from Igal Sapir  ---
I added the scripts `makebase.bat` and `makebase.sh` in
http://svn.apache.org/viewvc?view=revision&revision=1834798

The scripts are documented with comments.  I am not sure if there are other
places where documentation is required.

I'd be happy to add docs or modify script names and/or contents if needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1834798 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-01 Thread Michael Osipov

Am 2018-07-01 um 20:44 schrieb isa...@apache.org:

Author: isapir
Date: Sun Jul  1 18:44:38 2018
New Revision: 1834798

URL: http://svn.apache.org/viewvc?rev=1834798&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62500
Added scripts to create CATALINA_BASE directory

Added:
 tomcat/trunk/bin/makebase.bat
 tomcat/trunk/bin/makebase.sh

Added: tomcat/trunk/bin/makebase.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.sh?rev=1834798&view=auto
==
--- tomcat/trunk/bin/makebase.sh (added)
+++ tomcat/trunk/bin/makebase.sh Sun Jul  1 18:44:38 2018
@@ -0,0 +1,64 @@
+#!/bin/sh
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This script creates the directory structure required for running Tomcat
+# in a separate directory by pointing $CATALINA_BASE to it. It copies the
+# conf directory from $CATALINA_HOME, and creates empty directories for
+# bin, logs, temp, and work.
+#
+# If the file $CATALINA_HOME/bin/setenv.sh exists then it is copied to
+# the target directory as well.
+
+# first arg is the target directory
+BASE_TGT=$1


Why not call it CATALINA_BASE?


+if [ -z ${BASE_TGT} ]; then
+# target directory not provided; exit
+echo "Usage: makebase "
+exit 1
+fi
+
+HOME_DIR="$(dirname $(dirname $0))"


Why not call it CATALINA_HOME?


+if [ -d ${BASE_TGT} ]; then
+  # target directory exists
+  echo directory exists


Why no double quotes? Why not "target directory exists"?


+# exit if target directory is not empty
+[ "$(ls -A ${BASE_TGT})" ] && \
+echo "target directory is not empty" && \
+exit 1
+else
+# create the target directory
+mkdir -p ${BASE_TGT}
+fi
+
+for dir in bin logs temp work;


Why not webapps? The default Tomcat config (server.xml) refers to 
webapps in CATALINA_BASE. lib is missing: catalina.properties 
common.loader refers to it.



+do
+# copy directory with permissions and delete contents if any
+cp -a "${HOME_DIR}/${dir}" "${BASE_TGT}/${dir}"
+rm -fr "${BASE_TGT}/${dir}"/*
+done


Why do you copy and then delete? Why not mkdir directory directly?


+# copy conf directory recursively and preserve permissions
+cp -a "${HOME_DIR}/conf" "${BASE_TGT}/"


Preserving permissions will fail if the target is not under root's 
control. E.g., a user wants a private Tomcat. He won't be able to work with.



+# copy setenv.sh if exists
+[ -f "${HOME_DIR}/bin/setenv.sh" ] && \
+cp -p "${HOME_DIR}/bin/setenv.sh" "${BASE_TGT}/bin/"


Here you ignore -p.


+echo created CATALINA_BASE directory at $BASE_TGT


Not quoted again.

You should also warn that the ports in the server.xml are likely bound 
already.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1834798 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-01 Thread Igal Sapir

On 7/1/2018 12:18 PM, Michael Osipov wrote:

Am 2018-07-01 um 20:44 schrieb isa...@apache.org:

Author: isapir
Date: Sun Jul  1 18:44:38 2018
New Revision: 1834798

URL: http://svn.apache.org/viewvc?rev=1834798&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62500
Added scripts to create CATALINA_BASE directory

Added:
 tomcat/trunk/bin/makebase.bat
 tomcat/trunk/bin/makebase.sh

Added: tomcat/trunk/bin/makebase.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.sh?rev=1834798&view=auto
== 


--- tomcat/trunk/bin/makebase.sh (added)
+++ tomcat/trunk/bin/makebase.sh Sun Jul  1 18:44:38 2018
@@ -0,0 +1,64 @@
+#!/bin/sh
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, 
Version 2.0

+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This script creates the directory structure required for running 
Tomcat
+# in a separate directory by pointing $CATALINA_BASE to it. It 
copies the

+# conf directory from $CATALINA_HOME, and creates empty directories for
+# bin, logs, temp, and work.
+#
+# If the file $CATALINA_HOME/bin/setenv.sh exists then it is copied to
+# the target directory as well.
+
+# first arg is the target directory
+BASE_TGT=$1


Why not call it CATALINA_BASE?


+if [ -z ${BASE_TGT} ]; then
+    # target directory not provided; exit
+    echo "Usage: makebase "
+    exit 1
+fi
+
+HOME_DIR="$(dirname $(dirname $0))"


Why not call it CATALINA_HOME?


I was thinking that if CATALINA_BASE or CATALINA_HOME are already set 
then I shouldn't mess with them.





+if [ -d ${BASE_TGT} ]; then
+  # target directory exists
+  echo directory exists


Why no double quotes? Why not "target directory exists"?


Will update accordingly, but do the quotes add anything?  It seems to 
work fine without them.





+    # exit if target directory is not empty
+    [ "$(ls -A ${BASE_TGT})" ] && \
+    echo "target directory is not empty" && \
+    exit 1
+else
+    # create the target directory
+    mkdir -p ${BASE_TGT}
+fi
+
+for dir in bin logs temp work;


Why not webapps? The default Tomcat config (server.xml) refers to 
webapps in CATALINA_BASE. lib is missing: catalina.properties 
common.loader refers to it.


webapps make sense, though we might want to allow to create an empty 
directory rather than copy the contents of the original webapps.


I don't believe that `lib` is required.  I have deployed many instances 
without `lib` and never noticed an issue.  Am I missing something?





+do
+    # copy directory with permissions and delete contents if any
+    cp -a "${HOME_DIR}/${dir}" "${BASE_TGT}/${dir}"
+    rm -fr "${BASE_TGT}/${dir}"/*
+done


Why do you copy and then delete? Why not mkdir directory directly?


On Windows I create the directories.  On *nix the permissions were 
different so I did it that way to copy the original permissions.  I was 
also thinking of using `chmod` as a different option.





+# copy conf directory recursively and preserve permissions
+cp -a "${HOME_DIR}/conf" "${BASE_TGT}/"


Preserving permissions will fail if the target is not under root's 
control. E.g., a user wants a private Tomcat. He won't be able to work 
with.


So should I not preserve permissions and instead use `mkdir` and `chmod`?




+# copy setenv.sh if exists
+[ -f "${HOME_DIR}/bin/setenv.sh" ] && \
+    cp -p "${HOME_DIR}/bin/setenv.sh" "${BASE_TGT}/bin/"


Here you ignore -p.


+echo created CATALINA_BASE directory at $BASE_TGT


Not quoted again.

You should also warn that the ports in the server.xml are likely bound 
already.


I'll add that


Igal


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1834801 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-01 Thread isapir
Author: isapir
Date: Sun Jul  1 19:51:28 2018
New Revision: 1834801

URL: http://svn.apache.org/viewvc?rev=1834801&view=rev
Log:
Updated output of makebase script per feedback

Modified:
tomcat/trunk/bin/makebase.bat
tomcat/trunk/bin/makebase.sh

Modified: tomcat/trunk/bin/makebase.bat
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.bat?rev=1834801&r1=1834800&r2=1834801&view=diff
==
--- tomcat/trunk/bin/makebase.bat (original)
+++ tomcat/trunk/bin/makebase.bat Sun Jul  1 19:51:28 2018
@@ -16,7 +16,7 @@
 :: This script creates the directory structure required for running Tomcat 
 :: in a separate directory by pointing %CATALINA_BASE% to it. It copies the
 :: conf directory from %CATALINA_HOME%, and creates empty directories for
-:: logs, temp, and work.
+:: logs, temp, webapps, and work.
 ::
 :: If the file %CATALINA_HOME%/bin/setenv.sh exists then it is copied to
 :: the target directory as well.
@@ -37,11 +37,11 @@ set HOME_DIR=%CURR_DIR%..\
 
 if exist %BASE_TGT% (
   :: target directory exists
-  echo directory exists
+  echo "Target directory exists"
 
 :: exit if target directory is not empty
 for /F %%i in ('dir /b "%BASE_TGT%\*.*"') do (
-echo target directory is not empty
+echo "Target directory is not empty"
 goto :EOF
 )
 ) else ( 
@@ -49,8 +49,8 @@ if exist %BASE_TGT% (
 mkdir %BASE_TGT%
 )
 
-:: create empty directories for bin, logs, temp, and work
-mkdir %BASE_TGT%\bin %BASE_TGT%\logs %BASE_TGT%\temp %BASE_TGT%\work
+:: create empty directories for bin, logs, temp, webapps, and work
+mkdir %BASE_TGT%\bin %BASE_TGT%\logs %BASE_TGT%\temp %BASE_TGT%\webapps 
%BASE_TGT%\work
 
 :: copy conf directory
 robocopy %HOME_DIR%\conf %BASE_TGT%\conf > nul
@@ -58,6 +58,10 @@ robocopy %HOME_DIR%\conf %BASE_TGT%\conf
 :: copy setenv.bat if exists
 robocopy %HOME_DIR%\bin %BASE_TGT%\bin setenv.bat > nul
 
-echo created CATALINA_BASE directory at $BASE_TGT
+echo "Created CATALINA_BASE directory at $BASE_TGT"
+
+echo "Attention: The ports in server.xml might be bound by a "
+echo "   different instance. Each instance must bind "
+echo "   to a unique host:port combination."
 
 :EOF

Modified: tomcat/trunk/bin/makebase.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.sh?rev=1834801&r1=1834800&r2=1834801&view=diff
==
--- tomcat/trunk/bin/makebase.sh (original)
+++ tomcat/trunk/bin/makebase.sh Sun Jul  1 19:51:28 2018
@@ -18,7 +18,7 @@
 # This script creates the directory structure required for running Tomcat 
 # in a separate directory by pointing $CATALINA_BASE to it. It copies the
 # conf directory from $CATALINA_HOME, and creates empty directories for
-# bin, logs, temp, and work.
+# bin, logs, temp, webapps, and work.
 #
 # If the file $CATALINA_HOME/bin/setenv.sh exists then it is copied to
 # the target directory as well.
@@ -36,18 +36,18 @@ HOME_DIR="$(dirname $(dirname $0))"
 
 if [ -d ${BASE_TGT} ]; then
   # target directory exists
-  echo directory exists
+  echo "Target directory exists"
 
 # exit if target directory is not empty
 [ "$(ls -A ${BASE_TGT})" ] && \
-echo "target directory is not empty" && \
+echo "Target directory is not empty" && \
 exit 1
 else 
 # create the target directory
 mkdir -p ${BASE_TGT}
 fi
 
-for dir in bin logs temp work; 
+for dir in bin logs temp webapps work; 
 do 
 # copy directory with permissions and delete contents if any
 cp -a "${HOME_DIR}/${dir}" "${BASE_TGT}/${dir}"
@@ -59,6 +59,10 @@ cp -a "${HOME_DIR}/conf" "${BASE_TGT}/"
 
 # copy setenv.sh if exists
 [ -f "${HOME_DIR}/bin/setenv.sh" ] && \
-cp -p "${HOME_DIR}/bin/setenv.sh" "${BASE_TGT}/bin/"
+cp "${HOME_DIR}/bin/setenv.sh" "${BASE_TGT}/bin/"
 
-echo created CATALINA_BASE directory at $BASE_TGT
+echo "Created CATALINA_BASE directory at $BASE_TGT"
+
+echo "Attention: The ports in server.xml might be bound by a "
+echo "   different instance. Each instance must bind "
+echo "   to a unique host:port combination."



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1834798 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-01 Thread Michael Osipov

Am 2018-07-01 um 21:33 schrieb Igal Sapir:

On 7/1/2018 12:18 PM, Michael Osipov wrote:

Am 2018-07-01 um 20:44 schrieb isa...@apache.org:

Author: isapir
Date: Sun Jul  1 18:44:38 2018
New Revision: 1834798

URL: http://svn.apache.org/viewvc?rev=1834798&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62500
Added scripts to create CATALINA_BASE directory

Added:
 tomcat/trunk/bin/makebase.bat
 tomcat/trunk/bin/makebase.sh

Added: tomcat/trunk/bin/makebase.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.sh?rev=1834798&view=auto 

== 


--- tomcat/trunk/bin/makebase.sh (added)
+++ tomcat/trunk/bin/makebase.sh Sun Jul  1 18:44:38 2018
@@ -0,0 +1,64 @@
+#!/bin/sh
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, 
Version 2.0

+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This script creates the directory structure required for running 
Tomcat
+# in a separate directory by pointing $CATALINA_BASE to it. It 
copies the

+# conf directory from $CATALINA_HOME, and creates empty directories for
+# bin, logs, temp, and work.
+#
+# If the file $CATALINA_HOME/bin/setenv.sh exists then it is copied to
+# the target directory as well.
+
+# first arg is the target directory
+BASE_TGT=$1


Why not call it CATALINA_BASE?


+if [ -z ${BASE_TGT} ]; then
+    # target directory not provided; exit
+    echo "Usage: makebase "
+    exit 1
+fi
+
+HOME_DIR="$(dirname $(dirname $0))"


Why not call it CATALINA_HOME?


I was thinking that if CATALINA_BASE or CATALINA_HOME are already set 
then I shouldn't mess with them.


You could test that and make it idiotproof, but at the end you can 
ignore an external CATALINA_HOME because this script is an 
implementation detail of the parent CATALINA_HOME and shall not be seen 
as portable. CATALINA_BASE could be an alternative to $1: 
CATALINA_BASE=${CATALINA_BASE:1} or similar.





+if [ -d ${BASE_TGT} ]; then
+  # target directory exists
+  echo directory exists


Why no double quotes? Why not "target directory exists"?


Will update accordingly, but do the quotes add anything?  It seems to 
work fine without them.


You should make your strings consistent. Look below, they are quoted.




+    # exit if target directory is not empty
+    [ "$(ls -A ${BASE_TGT})" ] && \
+    echo "target directory is not empty" && \
+    exit 1
+else
+    # create the target directory
+    mkdir -p ${BASE_TGT}
+fi
+
+for dir in bin logs temp work;


Why not webapps? The default Tomcat config (server.xml) refers to 
webapps in CATALINA_BASE. lib is missing: catalina.properties 
common.loader refers to it.


webapps make sense, though we might want to allow to create an empty 
directory rather than copy the contents of the original webapps.


I don't expect you to copy the webapps itself, but have webapps/ dir 
created already. The user can decide to link or to copy manager/. I do 
link only at work because my manager app is globally configured.


I don't believe that `lib` is required.  I have deployed many instances 
without `lib` and never noticed an issue.  Am I missing something?


It is not required, but if a user wants to have private libs or override 
something from Tomcat, this should work out of the box. 
catalina.properties allows that.





+do
+    # copy directory with permissions and delete contents if any
+    cp -a "${HOME_DIR}/${dir}" "${BASE_TGT}/${dir}"
+    rm -fr "${BASE_TGT}/${dir}"/*
+done


Why do you copy and then delete? Why not mkdir directory directly?


On Windows I create the directories.  On *nix the permissions were 
different so I did it that way to copy the original permissions.  I was 
also thinking of using `chmod` as a different option.


I wouldn't preserve the permissions because you shouldn't make any 
assumptions on the target. If you want to go that route with chmod, 
you'll need for files *and* directories, plus for consistency, I'd 
expect you to have chown support too. Leave both to the user for now.





+# copy conf directory recursively and preserve permissions
+cp -a "${HOME_DIR}/conf" "${BASE_TGT}/"


Preserving permissions will fail if the target is not under root's 
control. E.g., a user wants a private Tomcat. He won't be able to work 
with.


S

Re: svn commit: r1834801 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-01 Thread Michael Osipov

Am 2018-07-01 um 21:51 schrieb isa...@apache.org:

Author: isapir
Date: Sun Jul  1 19:51:28 2018
New Revision: 1834801
Modified: tomcat/trunk/bin/makebase.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.sh?rev=1834801&r1=1834800&r2=1834801&view=diff
==
--- tomcat/trunk/bin/makebase.sh (original)
+++ tomcat/trunk/bin/makebase.sh Sun Jul  1 19:51:28 2018



-echo created CATALINA_BASE directory at $BASE_TGT
+echo "Created CATALINA_BASE directory at $BASE_TGT"
+
+echo "Attention: The ports in server.xml might be bound by a "
+echo "   different instance. Each instance must bind "
+echo "   to a unique host:port combination."


I am not sure whether "host:port" is enough. Please have look at the 
default server.xml. It binds at least three ports: shutdown, http, and 
ajp. Maybe leave the second sentence our and say: "Please revise your 
configuration.".


Michael

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in on tomcat-trunk

2018-07-01 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3414

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1834801
Blamelist: isapir

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2018-07-01 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 92 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 39 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.12-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.12-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/commons-beanutils/dist/commons-beanutils-20180702.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.8-SNAPSHOT.jar:/srv/gump/pu
 
blic/workspace/apache-commons/logging/target/commons-logging-20180702.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20180702.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-HEAD-jre-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-8.12-SNAPSHOT.jar

setproxy:

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
[checkstyle] Running Checkstyle 8.12-SNAPSHOT on 3288 files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/bin/makebase.bat:16: Line matches the 
illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/bin/makebase.bat:47: Line matches the 
illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/bin/makebase.sh:18: Line matches the 
illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/bin/makebase.sh:45: Line matches the 
illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/bin/makebase.sh:50: Line matches the 
illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/bin/makebase.sh:51: Line matches the 
illegal pattern '\s+$'. [RegexpSingleline]

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:569: Got 6 errors and 0 
warnings.

Total time: 39 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/rss.xml
- Atom: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2018070206, vmgump-vm3.apache.o

svn commit: r1834817 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-01 Thread isapir
Author: isapir
Date: Mon Jul  2 06:03:21 2018
New Revision: 1834817

URL: http://svn.apache.org/viewvc?rev=1834817&view=rev
Log:
Updated makebase scripts per feedback

Modified:
tomcat/trunk/bin/makebase.bat
tomcat/trunk/bin/makebase.sh

Modified: tomcat/trunk/bin/makebase.bat
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.bat?rev=1834817&r1=1834816&r2=1834817&view=diff
==
--- tomcat/trunk/bin/makebase.bat (original)
+++ tomcat/trunk/bin/makebase.bat Mon Jul  2 06:03:21 2018
@@ -16,10 +16,12 @@
 :: This script creates the directory structure required for running Tomcat 
 :: in a separate directory by pointing %CATALINA_BASE% to it. It copies the
 :: conf directory from %CATALINA_HOME%, and creates empty directories for
-:: logs, temp, webapps, and work.
+:: bin, lib, logs, temp, webapps, and work.
 ::
 :: If the file %CATALINA_HOME%/bin/setenv.sh exists then it is copied to
 :: the target directory as well.
+::
+:: Usage: makebase 
 
 @echo off
 
@@ -49,8 +51,10 @@ if exist %BASE_TGT% (
 mkdir %BASE_TGT%
 )
 
-:: create empty directories for bin, logs, temp, webapps, and work
-mkdir %BASE_TGT%\bin %BASE_TGT%\logs %BASE_TGT%\temp %BASE_TGT%\webapps 
%BASE_TGT%\work
+:: create empty directories for bin, lib, logs, temp, webapps, and work
+for %%d in (bin, lib, logs, temp, webapps, work) do (
+mkdir "%BASE_TGT%\%%d"
+)
 
 :: copy conf directory
 robocopy %HOME_DIR%\conf %BASE_TGT%\conf > nul
@@ -60,8 +64,8 @@ robocopy %HOME_DIR%\bin %BASE_TGT%\bin s
 
 echo "Created CATALINA_BASE directory at $BASE_TGT"
 
-echo "Attention: The ports in server.xml might be bound by a "
-echo "   different instance. Each instance must bind "
-echo "   to a unique host:port combination."
+echo "Attention: The ports in conf/server.xml might be bound by a "
+echo "   different instance. Please review your config files "
+echo "   and update them where necessary."
 
 :EOF

Modified: tomcat/trunk/bin/makebase.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.sh?rev=1834817&r1=1834816&r2=1834817&view=diff
==
--- tomcat/trunk/bin/makebase.sh (original)
+++ tomcat/trunk/bin/makebase.sh Mon Jul  2 06:03:21 2018
@@ -18,10 +18,12 @@
 # This script creates the directory structure required for running Tomcat 
 # in a separate directory by pointing $CATALINA_BASE to it. It copies the
 # conf directory from $CATALINA_HOME, and creates empty directories for
-# bin, logs, temp, webapps, and work.
+# bin, lib, logs, temp, webapps, and work.
 #
 # If the file $CATALINA_HOME/bin/setenv.sh exists then it is copied to
 # the target directory as well.
+#
+# Usage: makebase 
 
 # first arg is the target directory
 BASE_TGT=$1
@@ -47,11 +49,10 @@ else
 mkdir -p ${BASE_TGT}
 fi
 
-for dir in bin logs temp webapps work; 
+for dir in bin lib logs temp webapps work; 
 do 
 # copy directory with permissions and delete contents if any
-cp -a "${HOME_DIR}/${dir}" "${BASE_TGT}/${dir}"
-rm -fr "${BASE_TGT}/${dir}"/*
+mkdir "${BASE_TGT}/${dir}"
 done
 
 # copy conf directory recursively and preserve permissions
@@ -63,6 +64,6 @@ cp -a "${HOME_DIR}/conf" "${BASE_TGT}/"
 
 echo "Created CATALINA_BASE directory at $BASE_TGT"
 
-echo "Attention: The ports in server.xml might be bound by a "
-echo "   different instance. Each instance must bind "
-echo "   to a unique host:port combination."
+echo "Attention: The ports in conf/server.xml might be bound by a "
+echo "   different instance. Please review your config files "
+echo "   and update them where necessary."



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in on tomcat-trunk

2018-07-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3415

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1834817
Blamelist: isapir

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org