[RESULT] [VOTE] Release Apache Tomcat Native 1.2.17
The following votes were cast: Binding: +1: markt, ebourg, remm, rjung, csutherl, jfclere The vote therefore passes. Thanks to everyone who contributed to this release. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r27417 - /dev/tomcat/tomcat-connectors/native/1.2.17/ /release/tomcat/tomcat-connectors/native/1.2.17/
Author: markt Date: Wed Jun 13 07:35:46 2018 New Revision: 27417 Log: Release 1.2.17 Added: release/tomcat/tomcat-connectors/native/1.2.17/ - copied from r27416, dev/tomcat/tomcat-connectors/native/1.2.17/ Removed: dev/tomcat/tomcat-connectors/native/1.2.17/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1833443 - in /tomcat/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java webapps/docs/changelog.xml
Author: kfujino
Date: Wed Jun 13 08:19:28 2018
New Revision: 1833443
URL: http://svn.apache.org/viewvc?rev=1833443&view=rev
Log:
When logValidationErrors is set to true, the connection validation error is
logged as SEVERE instead of WARNING.
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
tomcat/trunk/webapps/docs/changelog.xml
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java?rev=1833443&r1=1833442&r2=1833443&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
Wed Jun 13 08:19:28 2018
@@ -546,7 +546,7 @@ public class PooledConnection implements
return true;
} catch (Exception ex) {
if (getPoolProperties().getLogValidationErrors()) {
-log.warn("SQL Validation error", ex);
+log.error("SQL Validation error", ex);
} else if (log.isDebugEnabled()) {
log.debug("Unable to validate object:",ex);
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1833443&r1=1833442&r2=1833443&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jun 13 08:19:28 2018
@@ -303,6 +303,15 @@
+
+
+
+When logValidationErrors is set to true, the connection
+validation error is logged as SEVERE instead of
+WARNING. (kfujino)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1833444 - in /tomcat/tc8.5.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java webapps/docs/changelog.xml
Author: kfujino
Date: Wed Jun 13 08:20:19 2018
New Revision: 1833444
URL: http://svn.apache.org/viewvc?rev=1833444&view=rev
Log:
When logValidationErrors is set to true, the connection validation error is
logged as SEVERE instead of WARNING.
Modified:
tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
Modified:
tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java?rev=1833444&r1=1833443&r2=1833444&view=diff
==
---
tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
(original)
+++
tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
Wed Jun 13 08:20:19 2018
@@ -546,7 +546,7 @@ public class PooledConnection implements
return true;
} catch (Exception ex) {
if (getPoolProperties().getLogValidationErrors()) {
-log.warn("SQL Validation error", ex);
+log.error("SQL Validation error", ex);
} else if (log.isDebugEnabled()) {
log.debug("Unable to validate object:",ex);
}
Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1833444&r1=1833443&r2=1833444&view=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Wed Jun 13 08:20:19 2018
@@ -250,6 +250,15 @@
+
+
+
+When logValidationErrors is set to true, the connection
+validation error is logged as SEVERE instead of
+WARNING. (kfujino)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1833445 - in /tomcat/tc8.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java webapps/docs/changelog.xml
Author: kfujino
Date: Wed Jun 13 08:21:29 2018
New Revision: 1833445
URL: http://svn.apache.org/viewvc?rev=1833445&view=rev
Log:
When logValidationErrors is set to true, the connection validation error is
logged as SEVERE instead of WARNING.
Modified:
tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
Modified:
tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java?rev=1833445&r1=1833444&r2=1833445&view=diff
==
---
tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
(original)
+++
tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
Wed Jun 13 08:21:29 2018
@@ -529,7 +529,7 @@ public class PooledConnection {
return true;
} catch (Exception ex) {
if (getPoolProperties().getLogValidationErrors()) {
-log.warn("SQL Validation error", ex);
+log.error("SQL Validation error", ex);
} else if (log.isDebugEnabled()) {
log.debug("Unable to validate object:",ex);
}
Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1833445&r1=1833444&r2=1833445&view=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Wed Jun 13 08:21:29 2018
@@ -223,6 +223,15 @@
+
+
+
+When logValidationErrors is set to true, the connection
+validation error is logged as SEVERE instead of
+WARNING. (kfujino)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1833446 - in /tomcat/tc7.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java webapps/docs/changelog.xml
Author: kfujino
Date: Wed Jun 13 08:22:05 2018
New Revision: 1833446
URL: http://svn.apache.org/viewvc?rev=1833446&view=rev
Log:
When logValidationErrors is set to true, the connection validation error is
logged as SEVERE instead of WARNING.
Modified:
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Modified:
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java?rev=1833446&r1=1833445&r2=1833446&view=diff
==
---
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
(original)
+++
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
Wed Jun 13 08:22:05 2018
@@ -486,7 +486,7 @@ public class PooledConnection {
return true;
} catch (Exception ex) {
if (getPoolProperties().getLogValidationErrors()) {
-log.warn("SQL Validation error", ex);
+log.error("SQL Validation error", ex);
} else if (log.isDebugEnabled()) {
log.debug("Unable to validate object:",ex);
}
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1833446&r1=1833445&r2=1833446&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed Jun 13 08:22:05 2018
@@ -175,6 +175,15 @@
+
+
+
+When logValidationErrors is set to true, the connection
+validation error is logged as SEVERE instead of
+WARNING. (kfujino)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r27421 - in /release/tomcat/tomcat-connectors/native/1.2.17: binaries/ source/
Author: markt Date: Wed Jun 13 14:37:41 2018 New Revision: 27421 Log: remove MD5s Removed: release/tomcat/tomcat-connectors/native/1.2.17/binaries/tomcat-native-1.2.17-ocsp-win32-bin.zip.md5 release/tomcat/tomcat-connectors/native/1.2.17/binaries/tomcat-native-1.2.17-win32-bin.zip.md5 release/tomcat/tomcat-connectors/native/1.2.17/source/tomcat-native-1.2.17-src.tar.gz.md5 release/tomcat/tomcat-connectors/native/1.2.17/source/tomcat-native-1.2.17-win32-src.zip.md5 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 62453] New: Tomcat tries to resolve uninitialized tag attributes in EL as java class names and this behavior causes performance problems.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62453
Bug ID: 62453
Summary: Tomcat tries to resolve uninitialized tag attributes
in EL as java class names and this behavior causes
performance problems.
Product: Tomcat 9
Version: 9.0.8
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: EL
Assignee: dev@tomcat.apache.org
Reporter: katsut...@worksap.co.jp
Target Milestone: -
an example of tag file
/WEB-INF/tags/sample.tag
{{{
<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"; %>
<%@ attribute name="foo" required="true" %>
<%@ attribute name="bar" %>
<%@ attribute name="baz" %>
foo: ${foo.toString()}
bar: ${bar.toString()}
baz: ${baz.toString()}
}}}
an example of jsp file calling tag without "bar" and "baz" attributes
{{{
<%@ taglib prefix="tags" tagdir="/WEB-INF/tags" %>
Example of Uninitialized Tag Attributes
}}}
I found that the uninitialized attributes were NOT set into context in Java
files generated from tag file.
Besides, when the uninitialized attributes were called in EL,
ScopedAttributeELResolver tries to resolve attributes name as java class names.
ref. getValue method in
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_8/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
I have already confirmed that the uninitialized attributes actually affect
performance.
I got jfr to compare between there are uninitialized attributes or not.
It was confirmed that lock wait occurs in java.util.jar.JarFile class and
sun.misc.URLClassPath class only when there are uninitialized attributes in
tag.
the related bug
Performance issue evaluating EL in custom tags (tagx) due to inefficient calls
to java.lang.Class.forName()
https://bz.apache.org/bugzilla/show_bug.cgi?id=57583
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
