svn commit: r1831478 - in /tomcat/site/trunk: ./ docs/ xdocs/

2018-05-12 Thread violetagg
Author: violetagg
Date: Sat May 12 13:18:22 2018
New Revision: 1831478

URL: http://svn.apache.org/viewvc?rev=1831478&view=rev
Log:
Updates (excluding docs) for 7.0.88 release

Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-70.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-7.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-70.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-7.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1831478&r1=1831477&r2=1831478&view=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Sat May 12 13:18:22 2018
@@ -36,7 +36,7 @@ tomcat.loc=http://www.apache.org/dist/to
 
 
 # - Tomcat versions -
-tomcat70=7.0.86
+tomcat70=7.0.88
 tomcat80=8.0.52
 tomcat85=8.5.31
 tomcat90=9.0.8

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1831478&r1=1831477&r2=1831478&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Sat May 12 13:18:22 2018
@@ -81,8 +81,8 @@
 
   
 Latest Stable 7.0.x Release
-2018-04-13
-7.0.86
+2018-05-11
+7.0.88
   
 
 

Modified: tomcat/site/trunk/docs/download-70.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-70.html?rev=1831478&r1=1831477&r2=1831478&view=diff
==
--- tomcat/site/trunk/docs/download-70.html (original)
+++ tomcat/site/trunk/docs/download-70.html Sat May 12 13:18:22 2018
@@ -225,7 +225,7 @@
 Quick Navigation
 
 
-[define v]7.0.86[end]
+[define v]7.0.88[end]
 https://www.apache.org/dist/tomcat/tomcat-7/KEYS";>KEYS |
 [v] |
 Browse |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1831478&r1=1831477&r2=1831478&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Sat May 12 13:18:22 2018
@@ -248,6 +248,46 @@ project logo are trademarks of the Apach
 
 
 
+
+2018-05-11 Tomcat 7.0.88 Released
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 7.0.88 of
+Apache Tomcat. This release contains a number of bug fixes and improvements
+compared to version 7.0.86. The notable changes compared to 7.0.86 include:
+
+
+
+Correct a regression in handling DataSource resources that do not specify
+a factory.
+
+Implement configuration options to work-around specification non-compliant
+user agents (including all the major browsers) that do not correctly %nn
+encode URI paths and query strings as required by RFC 7230 and RFC 
3986
+
+Enable the CrawlerSessionManagerValve to correctly handle bots that crawl
+multiple hosts and/or web applications when the Valve is configured on a
+Host or an Engine.
+
+Add support for annotation scanning of classes built with Java 11 EA
+
+
+
+
+
+Full details of these changes, and all the other changes, are available in the
+Tomcat 7 
changelog.
+
+
+
+
+
+https://tomcat.apache.org/download-70.cgi";>Download
+
+
+
+
 
 2018-05-08 Tomcat 8.0.52 Released
 
@@ -368,48 +408,6 @@ changelog.
 
 
 
-
-
-2018-04-13 Tomcat 7.0.86 Released
-
-
-
-The Apache Tomcat Project is proud to announce the release of version 7.0.86 of
-Apache Tomcat. This release contains a number of bug fixes and improvements
-compared to version 7.0.85. The notable changes compared to 7.0.85 include:
-
-
-
-Add support for the maxDays attribute to the AccessLogValve 
and
-ExtendedAccessLogValve. This allows the maximum number of days
-for which rotated access logs should be retained before deletion to be
-defined.
-
-Avoid infinite recursion, when trying to validate a session while loading
-it with PersistentManager.
-
-
-
-
-
-Full details of these changes, and all the other changes, are available in the
-Tomcat 7 
changelog.
-
-
-
-
-Warning: There is a regression in handling of DataSource
-resources that do not specify a factory. A simple configuration workaround
-is available. See bug https://bz.apache.org/bugzilla/show_bug.cgi?id=62316";>62316. This 
will be fixed in 7.0.87.
-
-
-
-
-
-https://tomcat.apache.org/download-70.cgi";>Download
-
-
-
 
 
 

svn commit: r1831479 - in /tomcat/site/trunk/docs: ./ tomcat-7.0-doc/ tomcat-7.0-doc/api/ tomcat-7.0-doc/api/org/apache/catalina/ tomcat-7.0-doc/api/org/apache/catalina/ant/ tomcat-7.0-doc/api/org/apa

2018-05-12 Thread violetagg
Author: violetagg
Date: Sat May 12 13:42:36 2018
New Revision: 1831479

URL: http://svn.apache.org/viewvc?rev=1831479&view=rev
Log:
Update docs for Apache Tomcat 7.0.88 release.


[This commit notification would consist of 64 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r26875 - /release/tomcat/tomcat-7/v7.0.86/

2018-05-12 Thread violetagg
Author: violetagg
Date: Sat May 12 13:46:34 2018
New Revision: 26875

Log:
Remove 7.0.86

Removed:
release/tomcat/tomcat-7/v7.0.86/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[ANN] Apache Tomcat 7.0.88 released

2018-05-12 Thread Violeta Georgieva
The Apache Tomcat team announces the immediate availability of Apache
Tomcat 7.0.88.

Apache Tomcat is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Expression Language and Java
WebSocket technologies.

This release contains a number of bug fixes and improvements compared to
version 7.0.86. The notable changes since 7.0.86 include:


- Correct a regression in handling of DataSource resources that do not
  specify a factory.

- Implement configuration options to work-around specification
  non-compliant user agents (including all the major browsers) that do
  not correctly %nn encode URI paths and query strings as required by
  RFC 7230 and RFC 3986

- Enable the CrawlerSessionManagerValve to correctly handle bots that
  crawl multiple hosts and/or web applications when the Valve is
  configured on a Host or an Engine.

- Add support for annotation scanning of classes built with Java 11 EA


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-7.0-doc/changelog.html

Apache Tomcat website:
http://tomcat.apache.org

Downloads:
http://tomcat.apache.org/download-70.cgi

Migration guides from Apache Tomcat 5.5.x and 6.0.x:
http://tomcat.apache.org/migration.html

Enjoy

The Apache Tomcat team


[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

--- Comment #6 from Mark Thomas  ---
(In reply to Robert Rettig from comment #4)
> Created attachment 35931 [details]
> Fixes hyphen validation

This patch is not consistent with the RFCs for host / domain names. I'm
currently -1 on applying it for that reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

--- Comment #7 from Mark Thomas  ---
(In reply to Mark Thomas from comment #6)
> (In reply to Robert Rettig from comment #4)
> > Created attachment 35931 [details]
> > Fixes hyphen validation
> 
> This patch is not consistent with the RFCs for host / domain names. I'm
> currently -1 on applying it for that reason.

While Tomcat doesn't have a formal policy, the general expectation is that
clients confirm to the relevant RFCs. Therefore, Tomcat does, from time to
time, tighten up the validation of input data (In reply to Robert Rettig from
comment #5)
> This effects version 8.5.31 too, which has much bigger impact to other
> projects!
> 
> see:
> http://svn.apache.org/viewvc/tomcat/tc8.5.x/tags/TOMCAT_8_5_31/java/org/
> apache/tomcat/util/http/parser/HttpParser.java?r1=1830182&r2=1830188
> 
> This validation is a new feature introduced in a minor version change!
> 
> Please check if such changes really correspond to your project policies.

While Tomcat doesn't have a formal policy, the general expectation is that
clients confirm to the relevant RFCs. Therefore, Tomcat does, from time to
time, tighten up the validation of input data when gaps in validation are
identified.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

--- Comment #8 from Mark Thomas  ---
My limited understanding after reading the Docket documentation is that
tasks. is used (via DNS) to get a list of all of the tasks
backing the service.

Why would there be a HTTP request to "tasks." rather than
""?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1831483 - in /tomcat/trunk: java/org/apache/tomcat/util/http/parser/HttpParser.java test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java

2018-05-12 Thread markt
Author: markt
Date: Sat May 12 17:01:11 2018
New Revision: 1831483

URL: http://svn.apache.org/viewvc?rev=1831483&view=rev
Log:
Simplify HostParser after reviewing code.
Add additional test case.

Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java?rev=1831483&r1=1831482&r2=1831483&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java Sat 
May 12 17:01:11 2018
@@ -844,28 +844,26 @@ public class HttpParser {
 
 
 private enum DomainParseState {
-NEW(   true, false, false,  AllowsEnd.NEVER,  AllowsEnd.NEVER, " 
at the start of"),
-ALL_ALPHA( true,  true,  true, AllowsEnd.ALWAYS, AllowsEnd.ALWAYS, " 
after a letter in"),
-ALPHA( true,  true,  true,  AllowsEnd.FIRST,  AllowsEnd.FIRST, " 
after a letter in"),
-NUMERIC(   true,  true,  true,  AllowsEnd.FIRST,  AllowsEnd.FIRST, " 
after a number in"),
-PERIOD(true, false, false,  AllowsEnd.NEVER,  AllowsEnd.NEVER, " 
after a period in"),
-HYPHEN(true,  true, false,  AllowsEnd.NEVER,  AllowsEnd.NEVER, " 
after a hypen in"),
-COLON(false, false, false,  AllowsEnd.NEVER,  AllowsEnd.NEVER, " 
after a colon in"),
-END(  false, false, false,  AllowsEnd.NEVER,  AllowsEnd.NEVER, " 
at the end of");
+NEW(   true, false, false,  AllowsEnd.NEVER, " at the start of"),
+ALL_ALPHA( true,  true,  true, AllowsEnd.ALWAYS, " after a letter in"),
+ALPHA( true,  true,  true,  AllowsEnd.FIRST, " after a letter in"),
+NUMERIC(   true,  true,  true,  AllowsEnd.FIRST, " after a number in"),
+PERIOD(true, false, false,  AllowsEnd.NEVER, " after a period in"),
+HYPHEN(true,  true, false,  AllowsEnd.NEVER, " after a hypen in"),
+COLON(false, false, false,  AllowsEnd.NEVER, " after a colon in"),
+END(  false, false, false,  AllowsEnd.NEVER, " at the end of");
 
 private final boolean mayContinue;
 private final boolean allowsHyphen;
 private final boolean allowsPeriod;
-private final AllowsEnd allowsColon;
 private final AllowsEnd allowsEnd;
 private final String errorLocation;
 
 private DomainParseState(boolean mayContinue, boolean allowsHyphen, 
boolean allowsPeriod,
-AllowsEnd allowsColon, AllowsEnd allowsEnd, String 
errorLocation) {
+AllowsEnd allowsEnd, String errorLocation) {
 this.mayContinue = mayContinue;
 this.allowsHyphen = allowsHyphen;
 this.allowsPeriod = allowsPeriod;
-this.allowsColon = allowsColon;
 this.allowsEnd = allowsEnd;
 this.errorLocation = errorLocation;
 }
@@ -891,8 +889,8 @@ public class HttpParser {
 Character.toString((char) c), errorLocation));
 }
 } else if (c == ':') {
-if (allowsColon == AllowsEnd.ALWAYS ||
-allowsColon == AllowsEnd.FIRST && segmentIndex == 0) {
+if (allowsEnd == AllowsEnd.ALWAYS ||
+allowsEnd == AllowsEnd.FIRST && segmentIndex == 0) {
 return COLON;
 } else {
 throw new 
IllegalArgumentException(sm.getString("http.invalidCharacterDomain",

Modified: 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java?rev=1831483&r1=1831482&r2=1831483&view=diff
==
--- 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java 
(original)
+++ 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java 
Sat May 12 17:01:11 2018
@@ -91,6 +91,7 @@ public class TestHttpParserHost {
 result.add(new Object[] { TestType.IPv4, "123", Integer.valueOf(-1), 
null} );
 result.add(new Object[] { TestType.IPv4, "123:8080", 
Integer.valueOf(3), null} );
 result.add(new Object[] { TestType.IPv4, "myapp-t.mydomain.com", 
Integer.valueOf(-1), null} );
+result.add(new Object[] { TestType.IPv4, "myapp-t.my-domain.com", 
Integer.valueOf(-1), null} );
 // Domain Name - invalid
 result.add(new Object[] { TestType.IPv4, ".", Integer.valueOf(-1), 
IAE} );
 result.add(new Object[] { TestType.IPv4, ".:8080", 
Integer.valueOf(-1), IAE} );
@@ -202,6 +203,7 @@ public class Te

[Bug 56143] Allow "service.bat install" to be used in an non-UAC cmd.exe session

2018-05-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56143

jerson viveros  changed:

   What|Removed |Added

 CC||jerv...@gmail.com

--- Comment #6 from jerson viveros  ---
Created attachment 35932
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35932&action=edit
tomcat7

no encuentro esta aplicacion en los servicios de este programa

don`t find this apllication in the service menu on hsscp.exe

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56438] If jar scan does not find context config or TLD config, log a message

2018-05-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56438

jerson viveros  changed:

   What|Removed |Added

 OS|Linux   |Windows 10

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56143] Allow "service.bat install" to be used in an non-UAC cmd.exe session

2018-05-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56143

--- Comment #7 from Mark Thomas  ---
The content of attachment 35932 has been deleted for the following reason:

Not relevant. Potential malware.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

--- Comment #9 from Robert Rettig  ---
(In reply to Mark Thomas from comment #8)
> My limited understanding after reading the Docket documentation is that
> tasks. is used (via DNS) to get a list of all of the tasks
> backing the service.
> 
> Why would there be a HTTP request to "tasks." rather than
> ""?

(In reply to Mark Thomas from comment #6)
> (In reply to Robert Rettig from comment #4)
> > Created attachment 35931 [details]
> > Fixes hyphen validation
> 
> This patch is not consistent with the RFCs for host / domain names. I'm
> currently -1 on applying it for that reason.

I totally agree not to applying that patch. I tried just to show what would
work for the hyphen problem as it will be the one which will fail now in many
environments. I just checked docker swarm, or even openshift deployments.
in openshift there is really a hostname declared as  maybe
'data-service.tenant1-apps.svc' that worked before tomcat 8.5.31 
This is just relevant because many microservices are deploped with spring boot
and the current relase pulls in tomcat 8.5.31 which stops working wihtout
reporting clear errors about the failures:
https://mvnrepository.com/artifact/org.springframework.boot/spring-boot-starter-web/2.0.2.RELEASE

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1831486 - in /tomcat/trunk: java/org/apache/tomcat/util/http/parser/HttpParser.java java/org/apache/tomcat/util/http/parser/LocalStrings.properties test/org/apache/tomcat/util/http/parser

2018-05-12 Thread markt
Author: markt
Date: Sat May 12 17:58:17 2018
New Revision: 1831486

URL: http://svn.apache.org/viewvc?rev=1831486&view=rev
Log:
Better error message when segment / domain name ends in an invalid state.
Add an additional test case and remove debug code added in previous commit.

Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
tomcat/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java?rev=1831486&r1=1831485&r2=1831486&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java Sat 
May 12 17:58:17 2018
@@ -901,8 +901,14 @@ public class HttpParser {
 allowsEnd == AllowsEnd.FIRST && segmentIndex == 0) {
 return END;
 } else {
-throw new 
IllegalArgumentException(sm.getString("http.invalidCharacterDomain",
-Character.toString((char) c), errorLocation));
+String msg;
+if (allowsEnd == AllowsEnd.NEVER) {
+msg = sm.getString("http.invalidSegmentEndState", 
this.name());
+} else {
+// allowsEnd == AllowsEnd.FIRST && segmentIndex > 0
+msg = sm.getString("http.invalidEndState", 
this.name());
+}
+throw new IllegalArgumentException(msg);
 }
 } else if (c == '-') {
 if (allowsHyphen) {

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties?rev=1831486&r1=1831485&r2=1831486&view=diff
==
--- 
tomcat/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties 
(original)
+++ 
tomcat/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties 
Sat May 12 17:58:17 2018
@@ -26,9 +26,11 @@ http.illegalCharacterDomain=The characte
 http.illegalCharacterIpv4=The character [{0}] is never valid in an IPv4 
address.
 http.illegalCharacterIpv6=The character [{0}] is never valid in an IPv6 
address.
 http.invalidCharacterDomain=The character [{0}] is not valid{1} a domain name.
+http.invalidEndState=The state [{0}] is not valid for the end of a domain name.
 http.invalidHextet=Invalid hextet. A hextet must consist of 4 or less hex 
characters.
 http.invalidIpv4Location=The IPv6 address contains an embedded IPv4 address at 
an invalid location.
 http.invalidOctet=Invalid octet [{0}]. The valid range for IPv4 octets is 0 to 
255.
+http.invalidSegmentEndState=The state [{0}] is not valid for the end of a 
segment.
 http.noClosingBracket=The IPv6 address is missing a closing bracket.
 http.noOpeningBracket=The IPv6 address is missing an opening bracket.
 http.singleColonEnd=An IPv6 address may not end with a single ':'.

Modified: 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java?rev=1831486&r1=1831485&r2=1831486&view=diff
==
--- 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java 
(original)
+++ 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java 
Sat May 12 17:58:17 2018
@@ -112,6 +112,7 @@ public class TestHttpParserHost {
 result.add(new Object[] { TestType.IPv4, "0.0.0.0com", 
Integer.valueOf(-1), IAE} );
 result.add(new Object[] { TestType.IPv4, "foo.bar.0com", 
Integer.valueOf(-1), IAE} );
 result.add(new Object[] { TestType.IPv4, "foo.bar.0com:8080", 
Integer.valueOf(-1), IAE} );
+result.add(new Object[] { TestType.IPv4, "myapp-t.my-domain.c-om", 
Integer.valueOf(-1), IAE} );
 // IPv6 - valid
 result.add(new Object[] { TestType.IPv6, "[::1]", Integer.valueOf(-1), 
null} );
 result.add(new Object[] { TestType.IPv6, "[::1]:8080", 
Integer.valueOf(5), null} );
@@ -203,7 +204,6 @@ public class TestHttpParserHost {
 
 }
 } catch (Exception e) {
-e.printStackTrace();
 exceptionClass = e.getClass();
 }
 Assert.assertEquals(input, expectedResult.intValue(), result);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additio

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

--- Comment #10 from Robert Rettig  ---
(In reply to Mark Thomas from comment #8)
> My limited understanding after reading the Docket documentation is that
> tasks. is used (via DNS) to get a list of all of the tasks
> backing the service.
> 
> Why would there be a HTTP request to "tasks." rather than
> ""?

For example in a docker swarm environment the service-name will resolve to a
virtual-ip (loadbalanced). Some applications have the requirements to get the
address of a dedicated service task. Therefore the "hostname"(which is
misleading) would be 'tasks.service-name'. It will resolve to a list of
dedicated ip. in most cases the first will be used and maybe cached for further
requests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

--- Comment #11 from Mark Thomas  ---
'data-service.tenant1-apps.svc' is a valid domain name so that should be OK.

I don't know enough about docker to know if using 'tasks.service-name' in that
way is a valid usage or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

--- Comment #12 from Robert Rettig  ---
(In reply to Mark Thomas from comment #11)
> 'data-service.tenant1-apps.svc' is a valid domain name so that should be OK.
> 
> I don't know enough about docker to know if using 'tasks.service-name' in
> that way is a valid usage or not.

I think you are right. The docker feature for resolving tasks with dns should
just be used in special cases like discovery
https://github.com/docker/docker.github.io/pull/6420/files 

But even in that case is there are possibility to disable the new host domain
validation in tomcat (environment, java runtime system property)?

Here are some additional observations within docker swarm from a debian
container with 'getent' from libc-bin package and 'host' binary from bind9-host
package.

:::RESOLVE (A)
::libc-bin::
root@a9348509c12f:/# /usr/bin/getent hosts data-service
10.0.0.21   data-service
root@a9348509c12f:/# /usr/bin/getent hosts tasks.data-service
10.0.0.13   tasks.data-service

::bind9-host::
root@a9348509c12f:/# /usr/bin/host data-service
data-service has address 10.0.0.21
Host data-service not found: 3(NXDOMAIN)
root@a9348509c12f:/# /usr/bin/host tasks.data-service
tasks.data-service has address 10.0.0.13
Host tasks.data-service not found: 3(NXDOMAIN)

:::REVERSE (PTR)
::libc-bin::
root@a9348509c12f:/# /usr/bin/getent hosts 10.0.0.21   
root@a9348509c12f:/# /usr/bin/getent hosts 10.0.0.13
10.0.0.13  
data-test_data-service.1.j37493y41n0t9eehio3dze3vl.data-test_backend

::bind9-host::
root@a9348509c12f:/# /usr/bin/host -t PTR 10.0.0.21
Host 21.0.0.10.in-addr.arpa. not found: 3(NXDOMAIN)
root@a9348509c12f:/# /usr/bin/host -t PTR 10.0.0.13
13.0.0.10.in-addr.arpa domain name pointer
data-test_data-service.1.j37493y41n0t9eehio3dze3vl.data-test_backend.



:::RESOLVE (A) the name from reverse
::libc-bin::
root@a9348509c12f:/# /usr/bin/getent hosts
data-test_data-service.1.j37493y41n0t9eehio3dze3vl.data-test_backend
10.0.0.13  
data-test_data-service.1.j37493y41n0t9eehio3dze3vl.data-test_backend
::bind9-host::
root@a9348509c12f:/# /usr/bin/host
data-test_data-service.1.j37493y41n0t9eehio3dze3vl.data-test_backend
data-test_data-service.1.j37493y41n0t9eehio3dze3vl.data-test_backend has
address 10.0.0.13
Host data-test_data-service.1.j37493y41n0t9eehio3dze3vl.data-test_backend not
found: 3(NXDOMAIN)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org