Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2017-12-15 Thread Mark Thomas
On 15/12/2017 05:06, Bill Barker wrote:



> Project tomcat-trunk-test-apr has an issue affecting its community 
> integration.
> This issue affects 1 projects,
>  and has been outstanding for 10 runs.
> The current state of this project is 'Failed', with reason 'Build Failed'.
> For reference only, the following projects are affected by this:
> - tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
> Servlet 4.0,



>[concat] Testsuites with failed tests:
>[concat] TEST-org.apache.coyote.http11.upgrade.TestUpgrade.APR.txt

The warning issues seem to be fixed :).

The trunk/APR run has been failing on this test for a few runs. I'm
taking a look now.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1816887 - in /tomcat/trunk: java/org/apache/coyote/http11/upgrade/UpgradeServletInputStream.java webapps/docs/changelog.xml

2017-12-15 Thread Mark Thomas
On 01/12/2017 16:54, r...@apache.org wrote:
> Author: remm
> Date: Fri Dec  1 16:54:38 2017
> New Revision: 1816887
> 
> URL: http://svn.apache.org/viewvc?rev=1816887&view=rev
> Log:
> Do not call onDataAvailable without data to read. I tried method with less 
> side effects, but they all caused problems elsewhere, while this one passes 
> the testsuite and everything else I could test it with.

This commit is what triggered the failure in TestUpgrade that Gump is
current complaining about for APR/native.

I can reproduce this failure on OSX. I haven't tried on other platforms.

The patch looks right to me. I'm wondering if this change has simply
exposed an issue somewhere in the APR/native connector. I'll take a look.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1818271 - in /tomcat/site/trunk: ./ docs/ xdocs/

2017-12-15 Thread violetagg
Author: violetagg
Date: Fri Dec 15 11:51:03 2017
New Revision: 1818271

URL: http://svn.apache.org/viewvc?rev=1818271&view=rev
Log:
Updates (excluding docs) for 8.0.48 release

Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-80.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-8.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-80.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-8.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1818271&r1=1818270&r2=1818271&view=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Fri Dec 15 11:51:03 2017
@@ -37,7 +37,7 @@ tomcat.loc=http://www.apache.org/dist/to
 
 # - Tomcat versions -
 tomcat70=7.0.82
-tomcat80=8.0.47
+tomcat80=8.0.48
 tomcat85=8.5.24
 tomcat90=9.0.2
 

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1818271&r1=1818270&r2=1818271&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Fri Dec 15 11:51:03 2017
@@ -67,8 +67,8 @@
 
   
 Latest Stable 8.0.x Release
-2017-10-03
-8.0.47
+2017-12-12
+8.0.48
   
 
 

Modified: tomcat/site/trunk/docs/download-80.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-80.html?rev=1818271&r1=1818270&r2=1818271&view=diff
==
--- tomcat/site/trunk/docs/download-80.html (original)
+++ tomcat/site/trunk/docs/download-80.html Fri Dec 15 11:51:03 2017
@@ -225,7 +225,7 @@
 
 
 [define v]8.5.24[end]
-[define w]8.0.47[end]
+[define w]8.0.48[end]
 https://www.apache.org/dist/tomcat/tomcat-8/KEYS";>KEYS |
 [v] |
 [w] |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1818271&r1=1818270&r2=1818271&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Fri Dec 15 11:51:03 2017
@@ -239,6 +239,47 @@ project logo are trademarks of the Apach
 
 
 
+
+2017-12-12 Tomcat 8.0.48 Released
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 8.0.48
+of Apache Tomcat. Apache Tomcat 8.0.48 includes fixes for issues identified in
+8.0.47 as well as other enhancements and changes. The notable changes
+compared to 8.0.47 include:
+
+
+
+Java 9 is fully supported
+
+Updated the packaged version of the Tomcat Native Library to 1.2.16 to pick
+up the latest Windows binaries built with APR 1.6.3 and OpenSSL 1.0.2m
+
+
+
+
+
+Full details of these changes, and all the other changes, are available in the
+Tomcat 8
+changelog.
+
+
+
+
+Note: End of life date for Apache Tomcat 8.0.x is announced.
+Read more...
+
+
+
+
+
+
+https://tomcat.apache.org/download-80.cgi";>Download
+
+
+
+
 
 2017-11-30 Tomcat 8.5.24 Released
 
@@ -373,51 +414,6 @@ Full details of these changes, and all t
 
 
 
-
-
-2017-10-03 Tomcat 8.0.47 Released
-
-
-
-The Apache Tomcat Project is proud to announce the release of version 8.0.47
-of Apache Tomcat. Apache Tomcat 8.0.47 includes fixes for issues identified in
-8.0.46 as well as other enhancements and changes. The notable changes
-compared to 8.0.46 include:
-
-
-
-A fix for CVE-2017-12617.
-
-Add ExtractingRoot, a new WebResourceRoot implementation that extracts JARs
-to the work directory for improved performance when deploying packed WAR
-files.
-
-Update the packaged version of the Tomcat Native Library to 1.2.14 to pick
-up the latest Windows binaries built with APR 1.6.2 and OpenSSL 
1.0.2l.
-
-
-
-
-
-Full details of these changes, and all the other changes, are available in the
-Tomcat 8
-changelog.
-
-
-
-
-Note: End of life date for Apache Tomcat 8.0.x is announced.
-Read more...
-
-
-
-
-
-
-https://tomcat.apache.org/download-80.cgi";>Download
-
-
-
 
 
 2016-10-05 Tomcat Connectors 1.2.42 
Released

Modified: tomcat/site/trunk/docs/migration-8.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-8.html?rev=1818271&r1=1818270&r2=1818271&view=diff
==
--- tomcat/site/trunk/docs/migration-8.html (original)
+++ tomcat/site/trunk/docs/migrat

svn commit: r1818276 - in /tomcat/site/trunk/docs/tomcat-8.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2017-12-15 Thread violetagg
Author: violetagg
Date: Fri Dec 15 12:10:30 2017
New Revision: 1818276

URL: http://svn.apache.org/viewvc?rev=1818276&view=rev
Log:
Update docs for Apache Tomcat 8.0.48 release.


[This commit notification would consist of 355 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r23745 - /release/tomcat/tomcat-8/v8.0.47/

2017-12-15 Thread violetagg
Author: violetagg
Date: Fri Dec 15 12:22:17 2017
New Revision: 23745

Log:
Remove 8.0.47

Removed:
release/tomcat/tomcat-8/v8.0.47/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[ANN] Apache Tomcat 8.0.48 released

2017-12-15 Thread Violeta Georgieva
The Apache Tomcat team announces the immediate availability of Apache
Tomcat 8.0.48.

Please note that Tomcat 8.x users should normally be using 8.5.x
releases in preference to 8.0.x releases. The Apache Tomcat team
announced that support for Apache Tomcat 8.0.x will end on
30 June 2018.

Apache Tomcat 8.0 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language and Java
WebSocket technologies.

Apache Tomcat 8.0.48 includes fixes for issues identified in 8.0.47 as
well as other enhancements and changes. The notable changes since
8.0.47 include:


- Java 9 is fully supported

- Update the packaged version of the Tomcat Native Library to
  1.2.16 to pick up the latest Windows binaries built with
  APR 1.6.3 and OpenSSL 1.0.2m


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-8.0-doc/changelog.html

Downloads:
http://tomcat.apache.org/download-80.cgi

Migration guides from Apache Tomcat 5.5.x, 6.0.x and 7.0.x:
http://tomcat.apache.org/migration.html

Enjoy

The Apache Tomcat team


Re: svn commit: r1816887 - in /tomcat/trunk: java/org/apache/coyote/http11/upgrade/UpgradeServletInputStream.java webapps/docs/changelog.xml

2017-12-15 Thread Rémy Maucherat
On Fri, Dec 15, 2017 at 12:33 PM, Mark Thomas  wrote:

> On 01/12/2017 16:54, r...@apache.org wrote:
> > Author: remm
> > Date: Fri Dec  1 16:54:38 2017
> > New Revision: 1816887
> >
> > URL: http://svn.apache.org/viewvc?rev=1816887&view=rev
> > Log:
> > Do not call onDataAvailable without data to read. I tried method with
> less side effects, but they all caused problems elsewhere, while this one
> passes the testsuite and everything else I could test it with.
>
> This commit is what triggered the failure in TestUpgrade that Gump is
> current complaining about for APR/native.
>
> I can reproduce this failure on OSX. I haven't tried on other platforms.
>
> The patch looks right to me. I'm wondering if this change has simply
> exposed an issue somewhere in the APR/native connector. I'll take a look.
>
> Oops, sorry. I didn't see TestUpgrade failing on CI, so that was it for
me, I usually don't test APR anymore.

Since it fails for me too, I debugged it, and the server IO events are the
same for APR (3 onDataAvailable calls), with the data written being the
same as well (2*16 bytes in onWritePossible). I'm not sure yet why the
client fails to read it with the patch in place.

Rémy


[Bug 61910] New: Description for allowLinking is innacurate

2017-12-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61910

Bug ID: 61910
   Summary: Description for allowLinking is innacurate
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
OS: Mac OS X 10.1
Status: NEW
  Severity: normal
  Priority: P2
 Component: Documentation
  Assignee: dev@tomcat.apache.org
  Reporter: mo...@ohrt.com
  Target Milestone: 

The description for allowLinking is inaccurate on this page:

https://tomcat.apache.org/tomcat-8.0-doc/config/resources.html#Attributes

"If the value of this flag is true, symlinks will be allowed inside the web
application, pointing to resources outside the web application base path. If
not specified, the default value of the flag is false."

This makes an assumption that symlinks to resources *inside* the web
application base path should work, regardless of this flag. However, they do
not. NO symlinks work unless the allowLinking flag is set, whether they fall
inside our outside the application base path.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Change HTTP status code for DefaultServlet with readOnly set to true

2017-12-15 Thread Ken Dombeck
Currently if you invoke PUT or DELETE on the DefaultServlet with
readOnly set to true it will return a 403. This implies that the
client can reauthorize the request and try again. But there is nothing
the user can do to actually invoke either of these two methods.

The proposed change is to return a 405 rather than the 403 since
neither of these methods is allowed when the readOnly flag is set to
true.

markt-asf has a nice writeup in the following PR with more details
https://github.com/apache/tomcat/pull/96

What I am looking for here is if there is consensus amongst the rest
of the development team for this change.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1817993 - /gump/metadata/project/tomcat-trunk.xml

2017-12-15 Thread sebb
On 14 December 2017 at 15:20, Mark Thomas  wrote:
> On 14/12/17 13:18, Konstantin Kolinko wrote:
>> Hi, Mark!
>>
>> To dev@tomcat, cc: general@gump.
>>
>>
>> The result of this change is that Gump building Tomcat downloads
>> tar.gz for Commons-Daemon from mirrors.
>
> Drat. That wasn't the intention at all.
>
> 
>
>> The "mvn package" command used by Gump does not build the src.tar.gz file.
>>
>> The file can be built by "mvn assembly:single" command, [4]
>> but HOWTO-RELEASE.txt file does not mention it so I wonder what is
>> actually used by Commons Daemon here.
>
> The command 'mvn deploy -Prelease' creates it. I suspect that isn't
> appropriate for Gump.

FTR:

You can add the following options to deploy to target/deploy and not
sign the artifacts:

-Ptest-deploy -Dgpg.skip

Documented here:

http://commons.apache.org/releases/prepare.html#Create_the_Release_Candidate

>> So this can be fixed by updating Gump configuration for commons-daemon to do
>>  and
>> >  id="native-distro" />
>>
>>
>> Alternatively, a question is whether the "deploy" target in Tomcat
>> actually has a need to copy the *.tar.gz files to CATALINA_HOME/bin/.
>> Those source file are needed when redistributing Tomcat, but they are
>> not actually needed when running it.
>
> Good point.
>
> The Windows binaries are only copied to /bin for the dist-static target.
> I can't see a reason not to treat the *.tar.gz src files the same way.
>
> Mark
>
> -
> To unsubscribe, e-mail: general-unsubscr...@gump.apache.org
> For additional commands, e-mail: general-h...@gump.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump-vm3]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2017-12-15 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-apr has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 14 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 mins 8 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.7-SNAPSHOT.jar
 -Dtest.reports=output/logs-APR -Dexecute.test.nio2=false 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-trunk/dest-20171216/lib 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-
 master/dest-20171216/bin/openssl -Dexecute.test.apr=true 
-Dtest.excludePerformance=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.6-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu
 
ild/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-u