Re: [VOTE] Release Apache Tomcat 8.5.20
Hi, 2017-08-03 1:10 GMT+03:00 Mark Thomas : > > The proposed Apache Tomcat 8.5.20 release is now available for voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain multiple > keys where each key has a separate password. Based on a patch by Frank > Taffelt. > > - Make asynchronous error handling more robust. In particular ensure > that onError() is called for any registered AsyncListeners after an > I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors when > accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.20/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1148/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_20/ > > The proposed 8.5.20 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.20 +1 My tests passed Regards, Violeta > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
Re: [VOTE] Release Apache Tomcat 9.0.0.M26
> The proposed 9.0.0.M26 release is: > [ ] Broken - do not release > [X] Alpha - go ahead and release as 9.0.0.M26 Unit tests pass for NIO, NIO2 and APR/native (1.2.12) on Windows, Linux and MacOS. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.20
> The proposed 8.5.20 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.20 Unit tests pass for NIO, NIO2 and APR/native (1.2.12) on Windows, Linux and MacOS. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1804300 - in /tomcat/site/trunk: docs/conference.html xdocs/conference.xml
Author: markt Date: Mon Aug 7 09:11:12 2017 New Revision: 1804300 URL: http://svn.apache.org/viewvc?rev=1804300&view=rev Log: Add the registration link. Update the session descriptions. Note: This page is public but not (yet) linked. Modified: tomcat/site/trunk/docs/conference.html tomcat/site/trunk/xdocs/conference.xml Modified: tomcat/site/trunk/docs/conference.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/conference.html?rev=1804300&r1=1804299&r2=1804300&view=diff == --- tomcat/site/trunk/docs/conference.html (original) +++ tomcat/site/trunk/docs/conference.html Mon Aug 7 09:11:12 2017 @@ -241,7 +241,7 @@ -Registration +https://www.eventbrite.com/e/tomcatcon-london-2017-tickets-36683639754";>Registration for TomcatCon London is now open. @@ -262,30 +262,51 @@ TODO: Short description 09.20 State of the Cat +Mark Thomas (markt) A review of the past year or so for Apache Tomcat and a look forward to what is expected in the coming 12 months. In particular, this will include the progress of Tomcat 9 towards its first stable release. 10.20 New and upcoming +Rémy Maucherat (remm) TODO: Short description 11.20 Break -11.40 Proxies, Load-balancing & Clustering Part 1 -TODO: Short description +11.40 Reverse Proxies, Load-Balancing & Clustering - Part 1 +Mark Thomas (markt) +Apache Tomcat provides many options for expanding a Tomcat installation +beyond a single instance. In this pair of presentations, Mark will review +the options for load-balancing requests across multiple instances and for +replicating session data between those instances. The pros and cons of each +of the options will be discussed to enable attendees to make the right +choices for their environment. The presentations will also cover common +misconceptions and configuration mistakes to enable attendees to avoid those +pitfalls. 12.40 Lunch -13.40 Proxies, Load-balancing & Clustering Part 2 -TODO: Short description +13.40 Reverse Proxies, Load-Balancing & Clustering - Part 2 +Mark Thomas (markt) +See above. 14.40 Fault Finding and Diagnostics -TODO: Short description +Mark Thomas (markt) +In this session Mark will discuss the types of problems that can occur in a +production Tomcat deployment and the tools you can use to help you track +down the root cause. Drawing on real-world examples, this session will cover +performance issues, memory leaks, garbage collection as well as some rather +more unusual issues Mark has encountered while providing support for Apache +Tomcat. 15.40 Break 16.00 Ask Us Anything -TODO: Short description +Mark Thomas (markt) and Rémy Maucherat (remm) +This is your opportunity to ask Mark and Rémy anything about working with +Apache Tomcat. In addition to being able to ask any questions that occur to +you during the day, there will be an opportunity to provide your questions +in advance during this registration process. Modified: tomcat/site/trunk/xdocs/conference.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/conference.xml?rev=1804300&r1=1804299&r2=1804300&view=diff == --- tomcat/site/trunk/xdocs/conference.xml (original) +++ tomcat/site/trunk/xdocs/conference.xml Mon Aug 7 09:11:12 2017 @@ -28,7 +28,7 @@ It also offers an opportunity to discuss the current Tomcat roadmap and help inform future development. -Registration +https://www.eventbrite.com/e/tomcatcon-london-2017-tickets-36683639754";>Registration for TomcatCon London is now open. @@ -40,22 +40,43 @@ 09.00 Welcome TODO: Short description 09.20 State of the Cat +Mark Thomas (markt) A review of the past year or so for Apache Tomcat and a look forward to what is expected in the coming 12 months. In particular, this will include the progress of Tomcat 9 towards its first stable release. 10.20 New and upcoming +Rémy Maucherat (remm) TODO: Short description 11.20 Break -11.40 Proxies, Load-balancing & Clustering Part 1 -TODO: Short description +11.40 Reverse Proxies, Load-Balancing & Clustering - Part 1 +Mark Thomas (markt) +Apache Tomcat provides many options for expanding a Tomcat installation +beyond a single instance. In this pair of presentations, Mark will review +the options for load-balancing requests across multiple instances and for +replicating session data between those instances. The pros and cons of each +of the options will be discussed to enable attendees to make the right +choices for their environment. The presentations will also cover common +misconceptions and configuration mistakes to enable attendees to avoid those +pitfalls. 12.40 Lunch -13.40 Proxies, Load-balanc
[GitHub] tomcat issue #72: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59901
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/72 Tomcat provides (by default) a static content cache in the resources layer so I do wonder if there is much benefit in caching the content in the JSP engine as well. The proposed cache appears to be unbounded which is likely to be a problem for larger installations. Also, there is no need to cache the JSP content once it has been processed. My original thinking was more along the lines of some refactoring to allow re-use of a single buffered input stream with some limit on the buffer size that could mean the stream did need to be re-opened for large JSPs. It may be that the static content cache provided in the resources layer provides sufficient benefit that tidying up the multiple input streams provides minimal additional benefit in most cases. Where I would expect it to help is the case when (for whatever reason) caching in the resource layer is disabled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1804306 - /tomcat/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Author: markt
Date: Mon Aug 7 09:46:21 2017
New Revision: 1804306
URL: http://svn.apache.org/viewvc?rev=1804306&view=rev
Log:
Fix a couple of minor FindBugs warnings
Modified:
tomcat/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Modified:
tomcat/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java?rev=1804306&r1=1804305&r2=1804306&view=diff
==
---
tomcat/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
(original)
+++
tomcat/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Mon Aug 7 09:46:21 2017
@@ -45,17 +45,18 @@ public class CompressionFilter extends G
/**
* Minimal reasonable threshold.
*/
-private final int minThreshold = 128;
+private static final int MIN_THRESHOLD = 128;
/**
- * The threshold number to compress.
+ * Minimal reasonable buffer.
*/
-protected int compressionThreshold = 0;
+// 8KB is what tomcat would use by default anyway
+private static final int MIN_BUFFER = 8192;
/**
- * Minimal reasonable buffer.
+ * The threshold number to compress.
*/
-private final int minBuffer = 8192; // 8KB is what tomcat would use by
default anyway
+protected int compressionThreshold = 0;
/**
* The compression buffer size to avoid chunking.
@@ -82,24 +83,24 @@ public class CompressionFilter extends G
str = getInitParameter("compressionThreshold");
if (str != null) {
compressionThreshold = Integer.parseInt(str);
-if (compressionThreshold != 0 && compressionThreshold <
minThreshold) {
+if (compressionThreshold != 0 && compressionThreshold <
MIN_THRESHOLD) {
if (debug > 0) {
-System.out.println("compressionThreshold should be either
0 - no compression or >= " + minThreshold);
-System.out.println("compressionThreshold set to " +
minThreshold);
+System.out.println("compressionThreshold should be either
0 - no compression or >= " + MIN_THRESHOLD);
+System.out.println("compressionThreshold set to " +
MIN_THRESHOLD);
}
-compressionThreshold = minThreshold;
+compressionThreshold = MIN_THRESHOLD;
}
}
str = getInitParameter("compressionBuffer");
if (str != null) {
compressionBuffer = Integer.parseInt(str);
-if (compressionBuffer < minBuffer) {
+if (compressionBuffer < MIN_BUFFER) {
if (debug > 0) {
-System.out.println("compressionBuffer should be >= " +
minBuffer);
-System.out.println("compressionBuffer set to " +
minBuffer);
+System.out.println("compressionBuffer should be >= " +
MIN_BUFFER);
+System.out.println("compressionBuffer set to " +
MIN_BUFFER);
}
-compressionBuffer = minBuffer;
+compressionBuffer = MIN_BUFFER;
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1804307 - in /tomcat/tc8.5.x/trunk: ./ webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Author: markt Date: Mon Aug 7 09:48:20 2017 New Revision: 1804307 URL: http://svn.apache.org/viewvc?rev=1804307&view=rev Log: Fix a couple of minor FindBugs warnings Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Aug 7 09:48:20 2017 @@ -1 +1 @@ -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501 ,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747 536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1 756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216 8,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,1763529,1763559,1763565,1763568,1763574,1763619,1763634-1763635,1763718,17
svn commit: r1804310 - /tomcat/tc8.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Author: markt
Date: Mon Aug 7 09:50:16 2017
New Revision: 1804310
URL: http://svn.apache.org/viewvc?rev=1804310&view=rev
Log:
Fix a couple of minor FindBugs warnings
Modified:
tomcat/tc8.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Modified:
tomcat/tc8.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java?rev=1804310&r1=1804309&r2=1804310&view=diff
==
---
tomcat/tc8.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
(original)
+++
tomcat/tc8.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Mon Aug 7 09:50:16 2017
@@ -50,17 +50,18 @@ public class CompressionFilter implement
/**
* Minimal reasonable threshold.
*/
-private final int minThreshold = 128;
+private static final int MIN_THRESHOLD = 128;
/**
- * The threshold number to compress.
+ * Minimal reasonable buffer.
*/
-protected int compressionThreshold = 0;
+// 8KB is what tomcat would use by default anyway
+private static final int MIN_BUFFER = 8192;
/**
- * Minimal reasonable buffer.
+ * The threshold number to compress.
*/
-private final int minBuffer = 8192; // 8KB is what tomcat would use by
default anyway
+protected int compressionThreshold = 0;
/**
* The compression buffer size to avoid chunking.
@@ -95,24 +96,24 @@ public class CompressionFilter implement
String str = filterConfig.getInitParameter("compressionThreshold");
if (str!=null) {
compressionThreshold = Integer.parseInt(str);
-if (compressionThreshold != 0 && compressionThreshold <
minThreshold) {
+if (compressionThreshold != 0 && compressionThreshold <
MIN_THRESHOLD) {
if (debug > 0) {
-System.out.println("compressionThreshold should be
either 0 - no compression or >= " + minThreshold);
-System.out.println("compressionThreshold set to " +
minThreshold);
+System.out.println("compressionThreshold should be
either 0 - no compression or >= " + MIN_THRESHOLD);
+System.out.println("compressionThreshold set to " +
MIN_THRESHOLD);
}
-compressionThreshold = minThreshold;
+compressionThreshold = MIN_THRESHOLD;
}
}
str = filterConfig.getInitParameter("compressionBuffer");
if (str!=null) {
compressionBuffer = Integer.parseInt(str);
-if (compressionBuffer < minBuffer) {
+if (compressionBuffer < MIN_BUFFER) {
if (debug > 0) {
-System.out.println("compressionBuffer should be >= " +
minBuffer);
-System.out.println("compressionBuffer set to " +
minBuffer);
+System.out.println("compressionBuffer should be >= " +
MIN_BUFFER);
+System.out.println("compressionBuffer set to " +
MIN_BUFFER);
}
-compressionBuffer = minBuffer;
+compressionBuffer = MIN_BUFFER;
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1804312 - /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Author: markt
Date: Mon Aug 7 09:52:52 2017
New Revision: 1804312
URL: http://svn.apache.org/viewvc?rev=1804312&view=rev
Log:
Fix a couple of minor FindBugs warnings
Modified:
tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Modified:
tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java?rev=1804312&r1=1804311&r2=1804312&view=diff
==
---
tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
(original)
+++
tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Mon Aug 7 09:52:52 2017
@@ -42,25 +42,26 @@ import javax.servlet.http.HttpServletRes
public class CompressionFilter implements Filter {
/**
- * The filter configuration object we are associated with. If this value
- * is null, this filter instance is not currently configured.
+ * Minimal reasonable threshold.
*/
-private FilterConfig config = null;
+private static final int MIN_THRESHOLD = 128;
/**
- * Minimal reasonable threshold.
+ * Minimal reasonable buffer.
*/
-private int minThreshold = 128;
+// 8KB is what tomcat would use by default anyway
+private static final int MIN_BUFFER = 8192;
/**
- * The threshold number to compress.
+ * The filter configuration object we are associated with. If this value
+ * is null, this filter instance is not currently configured.
*/
-protected int compressionThreshold = 0;
+private FilterConfig config = null;
/**
- * Minimal reasonable buffer.
+ * The threshold number to compress.
*/
-private int minBuffer = 8192; // 8KB is what tomcat would use by default
anyway
+protected int compressionThreshold = 0;
/**
* The compression buffer size to avoid chunking.
@@ -95,24 +96,24 @@ public class CompressionFilter implement
String str = filterConfig.getInitParameter("compressionThreshold");
if (str!=null) {
compressionThreshold = Integer.parseInt(str);
-if (compressionThreshold != 0 && compressionThreshold <
minThreshold) {
+if (compressionThreshold != 0 && compressionThreshold <
MIN_THRESHOLD) {
if (debug > 0) {
-System.out.println("compressionThreshold should be
either 0 - no compression or >= " + minThreshold);
-System.out.println("compressionThreshold set to " +
minThreshold);
+System.out.println("compressionThreshold should be
either 0 - no compression or >= " + MIN_THRESHOLD);
+System.out.println("compressionThreshold set to " +
MIN_THRESHOLD);
}
-compressionThreshold = minThreshold;
+compressionThreshold = MIN_THRESHOLD;
}
}
str = filterConfig.getInitParameter("compressionBuffer");
if (str!=null) {
compressionBuffer = Integer.parseInt(str);
-if (compressionBuffer < minBuffer) {
+if (compressionBuffer < MIN_BUFFER) {
if (debug > 0) {
-System.out.println("compressionBuffer should be >= " +
minBuffer);
-System.out.println("compressionBuffer set to " +
minBuffer);
+System.out.println("compressionBuffer should be >= " +
MIN_BUFFER);
+System.out.println("compressionBuffer set to " +
MIN_BUFFER);
}
-compressionBuffer = minBuffer;
+compressionBuffer = MIN_BUFFER;
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58489] QueryStatsComparator throws IllegalArgumentException: Comparison method violates its general contract!
https://bz.apache.org/bugzilla/show_bug.cgi?id=58489 --- Comment #9 from Michael Osipov <1983-01...@gmx.net> --- We still suffer from this on Tomcat 8.5.x. I would go for option two as Felix has proposed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.20
On Wed, Aug 2, 2017 at 6:10 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.20 release is now available for voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain multiple > keys where each key has a separate password. Based on a patch by Frank > Taffelt. > > - Make asynchronous error handling more robust. In particular ensure > that onError() is called for any registered AsyncListeners after an > I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors when > accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.20/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1148/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_20/ > > The proposed 8.5.20 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 8.5.20 +1 > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.20
Hi, The proposed 8.5.20 release is: [ ] Broken - do not release [ X ] Stable - go ahead and release as 8.5.20 Unit test passed. Our test web application works fine. -- From:Mark Thomas Time:2017 Aug 3 (Thu) 06:10 To:Tomcat Developers List Subject:[VOTE] Release Apache Tomcat 8.5.20 The proposed Apache Tomcat 8.5.20 release is now available for voting. The major changes compared to the 8.5.16 release are: - Enable TLS connectors to use Java key stores that contain multiple keys where each key has a separate password. Based on a patch by Frank Taffelt. - Make asynchronous error handling more robust. In particular ensure that onError() is called for any registered AsyncListeners after an I/O error on a non-container thread. - Sync SSL session access for the APR connector to prevent errors when accessing the session. Along with lots of other bug fixes and improvements. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.20/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1148/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_20/ The proposed 8.5.20 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.5.20 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #72: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59901
Github user zemian commented on the issue: https://github.com/apache/tomcat/pull/72 Hi Mark, > Tomcat provides (by default) a static content cache in the resources layer so I do wonder if there is much benefit in caching the content in the JSP engine as well. Are you referring to `org.apache.catalina.webresources.Cache`? To me this enhancement is at jasper level, so I thought it make more sense to keep it self contained. Also, is okay to bring catalina classes into jasper package? But any rate, if you do decide we go this route, please confirm and I will look into it more. > The proposed cache appears to be unbounded which is likely to be a problem for larger installations. Also, there is no need to cache the JSP content once it has been processed. I thought about this, but my current proposed cache is already bounded by `ParserController` instance, and it is already per request only. You still think we should limit cache further? If we do this, then we add much more complexity to caching though. Please confirm if we need this. > My original thinking was more along the lines of some refactoring to allow re-use of a single buffered input stream with some limit on the buffer size that could mean the stream did need to be re-opened for large JSPs. I am not clear on this suggestion yet. Do tell me more if you strongly feel that's more the right direction. My current proposed solution is to cache the jsp file content as char array, then re-feed into different Stream/Reader that is used by jasper parser. The previous code will perform two reads per single jsp file processing: once for `ParserController#parseDirectives` and another for `JspDocumentParser#parse`. The proposed code will reduce these to one file read only. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.0.M26
Hi, 2017-08-03 0:30 GMT+03:00 Mark Thomas : > > The proposed Apache Tomcat 9.0.0.M26 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 > > Note that the 9.0.0.M23 and 9.0.0.M24 release votes were cancelled due > to regressions. The 9.0.0.M25 vote passed but a regression was found > shortly afterwards. > > The major changes compared to the 9.0.0.M22 release are: > > - Correct a regression in 9.0.0.M22 that prevented Tomcat from shutting > down cleanly. > > - Add LoadBalancerDrainingValve, a Valve designed to reduce the amount > of time required for a node to drain its authenticated users. > > - When generating JSP runtime error messages that quote the relevant JSP > source code, switch from using the results of the JSP page parsing > process to using the JSR 045 source map data to identify the correct > part of the JSP source from the stack trace. This significantly > reduces the memory footprint of Jasper in development mode, provides a > small performance improvement for error page generation and enables > source quotes to continue to be provided after a Tomcat restart. > > - Add support for a Tomcat specific deployment descriptor, > /WEB-INF/tomcat-web.xml > > - Add ExtractingRoot, a new WebResourceRoot implementation that extracts > JARs to the work directory for improved performance when deploying > packed WAR files. > > Along with lots of other bug fixes and improvements. > > > For full details, see the changelog: > http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M26/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1147/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M26/ > > The proposed 9.0.0.M26 release is: > [ ] Broken - do not release > [X] Alpha - go ahead and release as 9.0.0.M26 Regards, Violeta > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
