Re: [VOTE] Release Apache Tomcat 6.0.53
Hi, 2017-04-02 11:19 GMT+03:00 Violeta Georgieva : > > The proposed Apache Tomcat 6.0.53 release is now available for voting. > > Note: This is the last Tomcat 6 release. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.53/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1130/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_53/ > > The proposed 6.0.53 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 6.0.53 Stable We need more votes here... Thanks, Violeta
svn commit: r1790119 - in /tomcat/trunk: java/org/apache/catalina/util/ExtensionValidator.java java/org/apache/catalina/webresources/JarWarResourceSet.java test/org/apache/catalina/webresources/TestJa
Author: markt
Date: Tue Apr 4 14:04:21 2017
New Revision: 1790119
URL: http://svn.apache.org/viewvc?rev=1790119&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60940
Improve the handling of the META-INF/ and META-INF/MANIFEST.MF entries for Jar
files located in /WEB-INF/lib when running a web application from a packed WAR
file.
Added:
tomcat/trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java
Modified:
tomcat/trunk/java/org/apache/catalina/util/ExtensionValidator.java
tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/util/ExtensionValidator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/util/ExtensionValidator.java?rev=1790119&r1=1790118&r2=1790119&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/util/ExtensionValidator.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/util/ExtensionValidator.java Tue Apr
4 14:04:21 2017
@@ -150,12 +150,11 @@ public final class ExtensionValidator {
if (manifestResource.isFile()) {
// Primarily used for error reporting
String jarName = manifestResource.getURL().toExternalForm();
-Manifest jmanifest = null;
-try (InputStream is = manifestResource.getInputStream()) {
-jmanifest = new Manifest(is);
-ManifestResource mre = new ManifestResource(jarName,
-jmanifest, ManifestResource.APPLICATION);
-appManifestResources.add(mre);
+Manifest jmanifest = manifestResource.getManifest();
+if (jmanifest != null) {
+ ManifestResource mre = new ManifestResource(jarName,
+ jmanifest, ManifestResource.APPLICATION);
+ appManifestResources.add(mre);
}
}
}
Modified:
tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java?rev=1790119&r1=1790118&r2=1790119&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java
Tue Apr 4 14:04:21 2017
@@ -107,11 +107,28 @@ public class JarWarResourceSet extends A
try (JarInputStream jarIs = new JarInputStream(jarFileIs))
{
JarEntry entry = jarIs.getNextJarEntry();
+boolean hasMetaInf = false;
while (entry != null) {
+ if (!hasMetaInf &&
entry.getName().startsWith("META-INF/")) {
+ hasMetaInf = true;
+ }
archiveEntries.put(entry.getName(), entry);
entry = jarIs.getNextJarEntry();
}
setManifest(jarIs.getManifest());
+ // Hacks to work-around JarInputStream swallowing these
+// entries. The attributes for these entries will be
+// incomplete. Making the attributes available would
+// require (re-)reading the stream as a ZipInputStream
+// and creating JarEntry objects from the ZipEntries.
+if (hasMetaInf) {
+ JarEntry metaInfDir = new JarEntry("META-INF/");
+ archiveEntries.put(metaInfDir.getName(),
metaInfDir);
+}
+if (jarIs.getManifest() != null) {
+ JarEntry manifest = new
JarEntry("META-INF/MANIFEST.MF");
+ archiveEntries.put(manifest.getName(),
manifest);
+}
}
} catch (IOException ioe) {
// Should never happen
Added:
tomcat/trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java?rev=1790119&view=auto
==
---
tomcat/trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java
(added)
+++
tomcat/trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java
Tue Apr 4 14:04:21 2017
@@ -0,0 +1,40 @@
+package org.apache.catalina.webresources;
+
+import java.io.File;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.jun
svn commit: r1790121 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/util/ java/org/apache/catalina/webresources/ test/org/apache/catalina/webresources/ webapps/docs/
Author: markt Date: Tue Apr 4 14:05:57 2017 New Revision: 1790121 URL: http://svn.apache.org/viewvc?rev=1790121&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60940 Improve the handling of the META-INF/ and META-INF/MANIFEST.MF entries for Jar files located in /WEB-INF/lib when running a web application from a packed WAR file. Added: tomcat/tc8.5.x/trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java - copied unchanged from r1790119, tomcat/trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/util/ExtensionValidator.java tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Apr 4 14:05:57 2017 @@ -1 +1 @@ -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501 ,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747 924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1 756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,
svn commit: r1790125 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/util/ java/org/apache/catalina/webresources/ test/org/apache/catalina/webresources/ webapps/docs/
Author: markt Date: Tue Apr 4 14:10:34 2017 New Revision: 1790125 URL: http://svn.apache.org/viewvc?rev=1790125&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60940 Improve the handling of the META-INF/ and META-INF/MANIFEST.MF entries for Jar files located in /WEB-INF/lib when running a web application from a packed WAR file. Added: tomcat/tc8.0.x/trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java - copied unchanged from r1790119, tomcat/trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/util/ExtensionValidator.java tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc8.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Apr 4 14:10:34 2017 @@ -1,2 +1,2 @@ /tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335 -/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886 ,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657 592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1 666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679
Hang in TestSsl testRenegotiateWorks for NIO2 (was Re: [VOTE] Release Apache Tomcat 8.0.43)
Hi Rainer, 2017-03-30 23:59 GMT+03:00 Rainer Jung : > > > > Am 28.03.2017 um 17:28 schrieb Violeta Georgieva: >> >> The proposed Apache Tomcat 8.0.43 release is now available for voting. >> >> It can be obtained from: >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.43/ >> The Maven staging repo is: >> https://repository.apache.org/content/repositories/orgapachetomcat-1127/ >> The svn tag is: >> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_43/ >> >> The proposed 8.0.43 release is: >> [ ] Broken - do not release >> [X] Stable - go ahead and release as 8.0.43 > > > +1 to release but note one hang in TestSsl testRenegotiateWorks for NIO2. I cannot reproduce this hanging test neither on MAC nor Ubuntu. Is it possible that it is related to something with your setup? Also Buildbot and Gump are OK. Regards, Violeta > Same as with 8.0.42 so likely reproducible. > > Details > === > > - MD5 OK > - signatures OK > - key in KEYS file > - gz and zip for src and bin consistent > - src completely consistent with svn tag > - builds fine > - warning about unchecked calls or conversions in: > - org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java > - org/apache/tomcat/jdbc/pool/PoolProperties.java > Not a regression > - build result looks consistent with binaries > - no checkstyle complaints > - no Javadoc warnings > > - Unit tests: Hang for NIO2 in TestSsl testRenegotiateWorks. > Same as for 8.0.42, see my vote mail there for stack and logs. > No other failures. > - ERROR message: > - more "Incomplete jul log message ... (only message)" (4 versus 6) > - more "ERROR:null" (4 versus 6) > > - WARN messages: > - less Tribes warnings (68 versus 58) > - more org.apache.catalina.loader.WebappClassLoaderBase.clearReferencesThreads > > - SEVERE messages > - new org.apache.catalina.connector.CoyoteAdapter.asyncDispatch Exception while processing an asynchronous request" (bio 1) > > - Exceptions: not compared > > - JMX MBean Comparison with 8.0.42: > - ThreadPool MBean attribute currentThreadCount changed > from 0 to 10 (ajp) resp. 1 to 10 (http) > - Threading MBean analogously shows 19 more daemon threads > - ProtocolHandler MBean for http new attribute > "compressibleMimeType: text/html,text/xml,text/plain,text/css,text/javascript,application/javascript" > > Build and tests were done using Java 1.7.0_80. OS was Solaris 10 Sparc, tcnative was 1.2.12 based on APR 1.5.2 and OpenSSL 1.0.2k. > > Thanks for RM and regards, > > Rainer > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
[Bug 60940] "unpackWARs=false" causes different behavior of classloader
https://bz.apache.org/bugzilla/show_bug.cgi?id=60940 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED OS||All --- Comment #1 from Mark Thomas --- Thanks for the report and the test case. This has been fixed in: - trunk for 9.0.0.M20 onwards - 8.5.x for 8.5.14 onwards - 8.0.x for 8.0.44 onwards 7.0.x is not affected -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 60944] Tomcat Production Issue connections in CLOSE_WAIT
https://bz.apache.org/bugzilla/show_bug.cgi?id=60944 Mark Thomas changed: What|Removed |Added Severity|critical|normal Status|NEW |NEEDINFO --- Comment #3 from Mark Thomas --- 8.0.37 is 6+ months old. Generally, we ask that issues are tested against the latest release of the appropriate major version before bugs are reported. You'll need to provide the steps to reproduce this on a clean install of any of the latest 7.0.x, 8.0.x, 8.5.x or 9.0.x releases. Without the steps to reproduce the issue, this will eventually get resolved as INVALID or WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 60892] Ability to remove Tomcat cache (work dir)
https://bz.apache.org/bugzilla/show_bug.cgi?id=60892 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Mark Thomas --- It has been a couple of weeks with no further comment. Closing this as WONTFIX. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 60944] Tomcat Production Issue connections in CLOSE_WAIT
https://bz.apache.org/bugzilla/show_bug.cgi?id=60944 --- Comment #4 from Adil A --- I was hoping this was know bug in tomcat 7 and 8 versions. Do you suggest to install latest 8 release and test ? This issue appears to be overtime. It works fine without restarting for a month and then the issue appears suddenly by itself. Not sure how to reproduce the issue. I have to wait to have enough traffic hitting tomcat servers and then probably it appears. The issue seems to be with high traffic on the servers since I haven't encountered this in any QA or Cert -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58970] http NIO connector crash after update from 8.0.27 to 8.0.30
https://bz.apache.org/bugzilla/show_bug.cgi?id=58970 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #16 from Mark Thomas --- No further response from OP, no info on how to reproduce this and no similar reports from other users. If you believe you are experiencing this issue or one similar, please open a new issue with the steps to reproduce the issue on clean install of the latest 7.0.x, 8.0.x, 8.5.x or 9.0.x release. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 41679] SemaphoreValve should be able to filter on url pattern or request attribute value pattern
https://bz.apache.org/bugzilla/show_bug.cgi?id=41679 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Mark Thomas --- 10 years without an updated patch - I think it is time to close this issue. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 43979] Add abstraction for Java and Classfile output
https://bz.apache.org/bugzilla/show_bug.cgi?id=43979 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #10 from Mark Thomas --- No response. Assume the answer is no. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 43400] enum support for tag libs
https://bz.apache.org/bugzilla/show_bug.cgi?id=43400 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Mark Thomas --- This will work out of the box with Java 7 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 44199] expose current backlog queue size
https://bz.apache.org/bugzilla/show_bug.cgi?id=44199 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Mark Thomas --- The code has moved on since this patch was provided. Applying it - or something like it - would require significant refactoring. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 44312] Warn when overwritting docBase of the default Host, with docBase of an alias with the same name..
https://bz.apache.org/bugzilla/show_bug.cgi?id=44312 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #9 from Mark Thomas --- Tomcat 6 reached EOL without this patch being applied. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 45014] Request and Response classes should have wrappers for use in Valves
https://bz.apache.org/bugzilla/show_bug.cgi?id=45014 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #25 from Mark Thomas --- As per Remy's, closing as WONTFIX. Note: There have been several changes to the Request API in 9.0.x in the 2+ years since comment #23. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hang in TestSsl testRenegotiateWorks for NIO2 (was Re: [VOTE] Release Apache Tomcat 8.0.43)
Hi Violeta, Am 04.04.2017 um 16:12 schrieb Violeta Georgieva: Hi Rainer, 2017-03-30 23:59 GMT+03:00 Rainer Jung : Am 28.03.2017 um 17:28 schrieb Violeta Georgieva: The proposed Apache Tomcat 8.0.43 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.43/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1127/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_43/ The proposed 8.0.43 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.0.43 +1 to release but note one hang in TestSsl testRenegotiateWorks for NIO2. I cannot reproduce this hanging test neither on MAC nor Ubuntu. Is it possible that it is related to something with your setup? Also Buildbot and Gump are OK. For me it fails about 50% of the time (NIO2). I added some debug logging: the handshake in the TesterHandshakeListener happens during the first request in the loop in TestSsl.testRenegotiateWorks(), but then when executing the second request in the loop it hangs when trying to read the first character of the first response line. Here's a log using FINEST log level. The SEVERE lines are not errors, but the log output I added to the test class: 00:18:21.141 FINE [main] org.apache.catalina.util.LifecycleBase.setStateInternal Setting state for [Connector[org.apache.coyote.http11.Http11Nio2Protocol-auto-3]] to [STARTING_PREP] 00:18:21.141 FINE [main] org.apache.catalina.util.LifecycleBase.setStateInternal Setting state for [Connector[org.apache.coyote.http11.Http11Nio2Protocol-auto-3]] to [STARTING] 00:18:21.142 INFO [main] org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler ["http-nio2-127.0.0.1-auto-3-35749"] 00:18:21.156 FINE [main] org.apache.catalina.util.LifecycleBase.setStateInternal Setting state for [Connector[org.apache.coyote.http11.Http11Nio2Protocol-auto-3]] to [STARTED] 00:18:21.156 FINE [main] org.apache.catalina.util.LifecycleBase.setStateInternal Setting state for [StandardService[Tomcat]] to [STARTED] 00:18:21.157 FINE [main] org.apache.catalina.util.LifecycleBase.setStateInternal Setting state for [StandardServer[-1]] to [STARTED] 00:18:21.163 FINE [http-nio2-127.0.0.1-auto-3-Acceptor-0] org.apache.tomcat.util.threads.LimitLatch.countUpOrAwait Counting up[http-nio2-127.0.0.1-auto-3-Acceptor-0] latch=0 00:18:21.194 FINE [http-nio2-127.0.0.1-auto-3-Acceptor-0] org.apache.tomcat.util.threads.LimitLatch.countUpOrAwait Counting up[http-nio2-127.0.0.1-auto-3-Acceptor-0] latch=1 00:18:21.197 SEVERE [main] org.apache.tomcat.util.net.TestSsl.testRenegotiateWorks begin request before socket.startHandshake 00:18:21.198 SEVERE [main] org.apache.tomcat.util.net.TestSsl.doRequest begin request 00:18:21.289 FINE [http-nio2-127.0.0.1-auto-3-exec-4] org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.register Register Tomcat:type=RequestProcessor,worker="http-nio2-127.0.0.1-auto-3-35749",name=HttpRequest1 00:18:21.290 FINE [http-nio2-127.0.0.1-auto-3-exec-4] org.apache.tomcat.util.modeler.Registry.registerComponent Managed= Tomcat:type=RequestProcessor,worker="http-nio2-127.0.0.1-auto-3-35749",name=HttpRequest1 00:18:21.291 FINER [http-nio2-127.0.0.1-auto-3-exec-4] com.sun.jmx.mbeanserver.Repository.contains name = Tomcat:type=RequestProcessor,worker="http-nio2-127.0.0.1-auto-3-35749",name=HttpRequest1 00:18:21.291 FINER [http-nio2-127.0.0.1-auto-3-exec-4] com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean ObjectName = Tomcat:type=RequestProcessor,worker="http-nio2-127.0.0.1-auto-3-35749",name=HttpRequest1 00:18:21.291 FINE [http-nio2-127.0.0.1-auto-3-exec-4] org.apache.tomcat.util.modeler.BaseModelMBean.preRegister preRegister org.apache.coyote.RequestInfo@1c22e0 Tomcat:type=RequestProcessor,worker="http-nio2-127.0.0.1-auto-3-35749",name=HttpRequest1 00:18:21.291 FINER [http-nio2-127.0.0.1-auto-3-exec-4] com.sun.jmx.mbeanserver.Repository.addMBean name = Tomcat:type=RequestProcessor,worker="http-nio2-127.0.0.1-auto-3-35749",name=HttpRequest1 00:18:21.292 FINER [http-nio2-127.0.0.1-auto-3-exec-4] com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.addObject Send create notification of object Tomcat:name=HttpRequest1,type=RequestProcessor,worker="http-nio2-127.0.0.1-auto-3-35749" 00:18:21.292 FINER [http-nio2-127.0.0.1-auto-3-exec-4] com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.sendNotification JMX.mbean.registered Tomcat:type=RequestProcessor,worker="http-nio2-127.0.0.1-auto-3-35749",name=HttpRequest1 00:18:21.293 FINE [http-nio2-127.0.0.1-auto-3-exec-4] org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process Socket: [org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper@1b4ba80:org.apache.tomcat.util.net.SecureNio2Channel@32156a:sun.nio.ch.UnixAsynchronousSocketChannelImpl[connected local=/127.0.0.1:35749 remote=/127.0.0.1:35750]], Status
[GUMP@vmgump-vm3]: Project tomcat-trunk-validate-eoln (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate-eoln has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate-eoln : Tomcat 9.x, a web server implementing the Java Servlet 4.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate-eoln/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate-eoln/gump_work/build_tomcat-trunk_tomcat-trunk-validate-eoln.html Work Name: build_tomcat-trunk_tomcat-trunk-validate-eoln (Type: Build) Work ended in a state of : Failed Elapsed: 6 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml validate-eoln [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/classes [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/bin [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/conf [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/lib [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/logs [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/webapps compile-prepare: [copy] Copying 1 file to /srv/gump/public/workspace/tomcat-trunk/java/org/apache/catalina/startup [copy] Copying 1 file to /srv/gump/public/workspace/tomcat-trunk/webapps/docs validate-eoln: [javac] Compiling 1 source file to /srv/gump/public/workspace/tomcat-trunk/output/classes [checkeol] Checking line ends in 3061 file(s) [checkeol] Checking line ends in 96 file(s) [checkeol] Done line ends check in 3157 file(s), 1 error(s) found. [checkeol] The following files have wrong line ends: [ [checkeol] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java: uses CRLF on line 1] BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:612: The following files have wrong line ends: [ /srv/gump/public/workspace/tomcat-trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java: uses CRLF on line 1] Total time: 6 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate-eoln/rss.xml - Atom: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate-eoln/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2017040505, vmgump-vm3.apache.org:vmgump:2017040505 Gump E-mail Identifier (unique within run) #3. -- Apache Gump http://gump.apache.org/ [Instance: vmgump-vm3] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-validate-eoln (in module tomcat-8.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-validate-eoln has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc8.0.x-validate-eoln : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate-eoln/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate-eoln/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-validate-eoln.html Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-validate-eoln (Type: Build) Work ended in a state of : Failed Elapsed: 7 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml validate-eoln [Working Directory: /srv/gump/public/workspace/tomcat-8.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar - Buildfile: /srv/gump/public/workspace/tomcat-8.0.x/build.xml build-prepare: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/classes [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/build [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/build/bin [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/build/conf [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/build/lib [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/build/logs [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps compile-prepare: [copy] Copying 1 file to /srv/gump/public/workspace/tomcat-8.0.x/java/org/apache/catalina/startup [copy] Copying 1 file to /srv/gump/public/workspace/tomcat-8.0.x/webapps/docs validate-eoln: [javac] Compiling 1 source file to /srv/gump/public/workspace/tomcat-8.0.x/output/classes [checkeol] Checking line ends in 2966 file(s) [checkeol] Checking line ends in 96 file(s) [checkeol] Done line ends check in 3062 file(s), 1 error(s) found. [checkeol] The following files have wrong line ends: [ [checkeol] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/catalina/webresources/TestJarWarResourceSet.java: uses CRLF on line 1] BUILD FAILED /srv/gump/public/workspace/tomcat-8.0.x/build.xml:623: The following files have wrong line ends: [ /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/catalina/webresources/TestJarWarResourceSet.java: uses CRLF on line 1] Total time: 7 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate-eoln/rss.xml - Atom: http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate-eoln/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2017040505, vmgump-vm3.apache.org:vmgump:2017040505 Gump E-mail Identifier (unique within run) #2. -- Apache Gump http://gump.apache.org/ [Instance: vmgump-vm3] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-validate has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc8.0.x-validate : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-validate.html Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-validate (Type: Build) Work ended in a state of : Failed Elapsed: 18 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.7-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-8.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.7-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20170405.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.6-SNAPSHOT.jar :/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20170405.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20170405.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-22.0-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-8.0.x/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-8.0.x/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-7.7-SNAPSHOT.jar setproxy: downloadfile: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/res/checkstyle [checkstyle] Running Checkstyle 7.7-SNAPSHOT on 3025 files [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/java/org/apache/catalina/util/ExtensionValidator.java:153:1: File contains tab characters (this is the first instance). [FileTabCharacter] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/java/org/apache/catalina/webresources/JarWarResourceSet.java:112:25: File contains tab characters (this is the first instance). [FileTabCharacter] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/catalina/webresources/TestJarWarResourceSet.java:1: Line does not match expected header line of '^(rem)?\W*Licensed to the Apache Software Foundation \(ASF\) under one or more$'. [RegexpHeader] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/catalina/webresources/TestJarWarResourceSet.java:22: Line matches the illegal pattern '\s+$'. [RegexpSingleline] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/catalina/webresources/TestJarWarResourceSet.java:23:1: File contains tab characters (this is the first instance). [FileTabCharacter] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/catalina/webresources/TestJarWarResourceSet.java:29: Line matches the illegal pattern '\s+$'. [RegexpSingleline] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/catalina/webresources/TestJarWarResourceSet.java:33: Line matches the illegal pa
[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 9.x, a web server implementing the Java Servlet 4.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 19 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.7-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.7-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20170405.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.6-SNAPSHOT.jar :/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20170405.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20170405.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-22.0-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-7.7-SNAPSHOT.jar setproxy: downloadfile: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle [checkstyle] Running Checkstyle 7.7-SNAPSHOT on 3110 files [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/catalina/util/ExtensionValidator.java:155:1: File contains tab characters (this is the first instance). [FileTabCharacter] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java:112:25: File contains tab characters (this is the first instance). [FileTabCharacter] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java:1: Line does not match expected header line of '^(rem)?\W*Licensed to the Apache Software Foundation \(ASF\) under one or more$'. [RegexpHeader] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java:22: Line matches the illegal pattern '\s+$'. [RegexpSingleline] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java:23:1: File contains tab characters (this is the first instance). [FileTabCharacter] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java:29: Line matches the illegal pattern '\s+$'. [RegexpSingleline] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/catalina/webresources/TestJarWarResourceSet.java:33: Line matches the illegal pattern '\s+$'.
Re: Host header validation
> > Applied. Many thanks. > > If you'd like to work on this further then can I suggest you take a look > at Konstantin's comments: > > http://markmail.org/message/vp5voob7elspflax I looked at the comments and it seems there are things to be clarified before going in this direction: - should we introduce a flag for turn on/off validation and in which cases - zone id support in IPv6 addresses - IPvFuture support (for this one Konstantin has already proposed to be postponed for a while) If you think this is the right time to work on the first two, let me know and I can prepare a patch. Other possibilities are: > > - performance improvements for the Host header validation > > - improving code coverage generally for any of the HTTP parsing code > > - any that attracts your interest I'm looking at the code coverage and will take a look at host validation performance. Kind regards, Katya
