[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2017-03-20 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-nio2 :  Tomcat 8.x, a web server implementing the 
Java Servlet 3.1,
...


Full details are available at:

http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 20 mins 15 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dexecute.test.nio2=true -Dtest.temp=output/test-tmp-NIO2 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dtest.accesslog=true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170320.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20170320/bin/openssl
 -Dexecute.test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dexecute.test.apr=false -Dexecute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170320-native-src.tar.gz
 -Dtest.repor
 ts=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170320-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.0.x/true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/wo

svn commit: r1787701 - in /tomcat/trunk/java: javax/servlet/http/PushBuilder.java org/apache/catalina/core/ApplicationPushBuilder.java

2017-03-20 Thread markt 
Author: markt
Date: Mon Mar 20 09:55:52 2017
New Revision: 1787701

URL: http://svn.apache.org/viewvc?rev=1787701&view=rev
Log:
PushBuilder updates from Servlet EG
Remove eTag, conditional and lastModified

Modified:
tomcat/trunk/java/javax/servlet/http/PushBuilder.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java

Modified: tomcat/trunk/java/javax/servlet/http/PushBuilder.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/http/PushBuilder.java?rev=1787701&r1=1787700&r2=1787701&view=diff
==
--- tomcat/trunk/java/javax/servlet/http/PushBuilder.java (original)
+++ tomcat/trunk/java/javax/servlet/http/PushBuilder.java Mon Mar 20 09:55:52 
2017
@@ -34,9 +34,6 @@ import java.util.Set;
  * The referer header will be set to
  * {@link HttpServletRequest#getRequestURL()} plus, if present, the query
  * string from {@link HttpServletRequest#getQueryString()}.
- * If either of the headers {@code If-Modified-Since} or
- * {@code If-None-Match} were present then {@link #isConditional()} will be
- * set to {@code true}.
  * 
  *
  * @since Servlet 4.0
@@ -87,17 +84,6 @@ public interface PushBuilder {
 PushBuilder sessionId(String sessionId);
 
 /**
- * Sets if the request will be conditional. If {@code true} the values from
- * {@link #getETag()} and {@link #getLastModified()} will be used to
- * construct appropriate headers.
- *
- * @param conditional Should generated push requests be conditional
- *
- * @return This builder instance
- */
-PushBuilder conditional(boolean conditional);
-
-/**
  * Sets a HTTP header on the request. Any existing headers of the same name
  * are first remove.
  *
@@ -143,28 +129,6 @@ public interface PushBuilder {
 PushBuilder path(String path);
 
 /**
- * Sets the eTag to be used for conditional push requests. This will be
- * set to {@code null} after a call to {@link #push()} so it must be
- * explicitly set for every push request that requires it.
- *
- * @param eTag The eTag use for the push request
- *
- * @return This builder instance
- */
-PushBuilder eTag(String eTag);
-
-/**
- * Sets the last modified to be used for conditional push requests. This
- * will be set to {@code null} after a call to {@link #push()} so it must 
be
- * explicitly set for every push request that requires it.
- *
- * @param lastModified The last modified value to use for the push request
- *
- * @return This builder instance
- */
-PushBuilder lastModified(String lastModified);
-
-/**
  * Generates the push request and sends it to the client unless pushes are
  * not available for some reason. After calling this method the following
  * fields are set to {@code null}:
@@ -205,14 +169,6 @@ public interface PushBuilder {
 String getSessionId();
 
 /**
- * Will push requests generated by future calls to {@code push()} be
- * conditional.
- *
- * @return {@code true} if push requests will be conditional
- */
-boolean isConditional();
-
-/**
  * @return The current set of names of HTTP headers to be used the next 
time
  * {@code push()} is called.
  */
@@ -237,21 +193,4 @@ public interface PushBuilder {
  * @return The path value that will be associated with the next push 
request
  */
 String getPath();
-
-/**
- * Obtain the eTag that will be used for the push request that will be
- * generated by the next call to {@code push()}.
- *
- * @return The eTag value that will be associated with the next push 
request
- */
-String getETag();
-
-/**
- * Obtain the last modified that will be used for the push request that 
will
- * be generated by the next call to {@code push()}.
- *
- * @return The last modified value that will be associated with the next
- * push request
- */
-String getLastModified();
 }

Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java?rev=1787701&r1=1787700&r2=1787701&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java Mon 
Mar 20 09:55:52 2017
@@ -72,11 +72,8 @@ public class ApplicationPushBuilder impl
 private final List cookies = new ArrayList<>();
 private String method = "GET";
 private String path;
-private String eTag;
-private String lastModified;
 private String queryString;
 private String sessionId;
-private boolean conditional;
 
 
 public ApplicationPushBuilder(HttpServletRequest r

svn commit: r1787702 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ApplicationPushBuilder.java java/org/apache/catalina/servlet4preview/http/PushBuilder.java

2017-03-20 Thread markt 
Author: markt
Date: Mon Mar 20 09:59:40 2017
New Revision: 1787702

URL: http://svn.apache.org/viewvc?rev=1787702&view=rev
Log:
PushBuilder updates from Servlet EG
Remove eTag, conditional and lastModified

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/servlet4preview/http/PushBuilder.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Mar 20 09:59:40 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,1762168,176217
 
2,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763

svn commit: r1787703 - /tomcat/trunk/webapps/docs/changelog.xml

2017-03-20 Thread markt 
Author: markt
Date: Mon Mar 20 10:00:52 2017
New Revision: 1787703

URL: http://svn.apache.org/viewvc?rev=1787703&view=rev
Log:
Update changelog

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1787703&r1=1787702&r2=1787703&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Mar 20 10:00:52 2017
@@ -75,6 +75,10 @@
 pathInfo associated with it. This was a regression in the changes in
 9.0.0.M18 for the Servlet 4.0 API changes. (markt)
   
+  
+Align PushBuilder API with changes from Servlet expert
+group. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1787704 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml

2017-03-20 Thread markt 
Author: markt
Date: Mon Mar 20 10:01:13 2017
New Revision: 1787704

URL: http://svn.apache.org/viewvc?rev=1787704&view=rev
Log:
Update changelog

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Mar 20 10:01:13 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,1762168,176217
 
2,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,1763529,1763559,1763565,1763568,1763574,1763619,1763634-1763635,1763718,1763786,1763798-1763799,1763810,1763813,1763815,1763819,1763831,1764083,1764425,17

svn commit: r1787705 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java java/org/apache/tomcat/util/descriptor/web/WebRuleSet.java java/org/apache/tomcat/util/descriptor/web/WebXm

2017-03-20 Thread markt 
Author: markt
Date: Mon Mar 20 10:07:29 2017
New Revision: 1787705

URL: http://svn.apache.org/viewvc?rev=1787705&view=rev
Log:
Servlet 4.0 updates for web.xml parsing
request-encoding -> request-character-encoding
response-encoding -> response-character-encoding

Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/WebRuleSet.java
tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/WebXml.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java?rev=1787705&r1=1787704&r2=1787705&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Mon Mar 20 
10:07:29 2017
@@ -1299,7 +1299,7 @@ public class ContextConfig implements Li
 webxml.getMimeMappings().entrySet()) {
 context.addMimeMapping(entry.getKey(), entry.getValue());
 }
-context.setRequestCharacterEncoding(webxml.getRequestEncoding());
+
context.setRequestCharacterEncoding(webxml.getRequestCharacterEncoding());
 // Name is just used for ordering
 for (ContextResourceEnvRef resource :
 webxml.getResourceEnvRefs().values()) {
@@ -1308,7 +1308,7 @@ public class ContextConfig implements Li
 for (ContextResource resource : webxml.getResourceRefs().values()) {
 context.getNamingResources().addResource(resource);
 }
-context.setResponseCharacterEncoding(webxml.getResponseEncoding());
+
context.setResponseCharacterEncoding(webxml.getResponseCharacterEncoding());
 boolean allAuthenticatedUsersIsAppRole =
 webxml.getSecurityRoles().contains(
 SecurityConstraint.ROLE_ALL_AUTHENTICATED_USERS);

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/WebRuleSet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/WebRuleSet.java?rev=1787705&r1=1787704&r2=1787705&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/WebRuleSet.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/WebRuleSet.java Mon 
Mar 20 10:07:29 2017
@@ -195,9 +195,11 @@ public class WebRuleSet extends RuleSetB
 digester.addCallMethod(fullPrefix + "/absolute-ordering/others",
"addAbsoluteOrderingOthers");
 digester.addRule(fullPrefix + "/deny-uncovered-http-methods",
-new SetDenyUncoveredHttpMethodsRule());
-digester.addCallMethod(fullPrefix + "/request-encoding", 
"setRequestEncoding", 0);
-digester.addCallMethod(fullPrefix + "/response-encoding", 
"setResponseEncoding", 0);
+ new SetDenyUncoveredHttpMethodsRule());
+digester.addCallMethod(fullPrefix + "/request-character-encoding",
+   "setRequestCharacterEncoding", 0);
+digester.addCallMethod(fullPrefix + "/response-character-encoding",
+   "setResponseCharacterEncoding", 0);
 }
 
 digester.addCallMethod(fullPrefix + "/context-param",

Modified: tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/WebXml.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/WebXml.java?rev=1787705&r1=1787704&r2=1787705&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/WebXml.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/WebXml.java Mon Mar 
20 10:07:29 2017
@@ -610,34 +610,34 @@ public class WebXml extends XmlEncodingB
 return new JspConfigDescriptorImpl(descriptors, tlds);
 }
 
-private String requestEncoding;
-public String getRequestEncoding() {
-return requestEncoding;
+private String requestCharacterEncoding;
+public String getRequestCharacterEncoding() {
+return requestCharacterEncoding;
 }
-public void setRequestEncoding(String requestEncoding) {
-if (requestEncoding != null) {
+public void setRequestCharacterEncoding(String requestCharacterEncoding) {
+if (requestCharacterEncoding != null) {
 try {
-B2CConverter.getCharset(requestEncoding);
+B2CConverter.getCharset(requestCharacterEncoding);
 } catch (UnsupportedEncodingException e) {
 throw new IllegalArgumentException(e);
 }
 }
-this.requestEncoding = re

Re: JDK 9 EA Build 159 and JDK 8u152 is available on java.net

2017-03-20 Thread Rory O'Donnell 

Hi Remy,

Not sure I understand the issue or if it is likely to addressed, the 
best place

to explain the issue/discuss would be on the openjdk nio-dev mailing list.
Please subscribe first.

Rgds,Rory

On 19/03/2017 09:51, Rémy Maucherat wrote:

2017-03-03 12:23 GMT+01:00 Rory O'Donnell :


Hi Mark,

*JDK 9 Early Access* b159   is available
on java.net, summary of  changes are listed here <
http://download.java.net/java/jdk9/changes/jdk-9+159.html>.

Can you confirm fix in b159 for  JDK-8175261 : Per-protocol cache setting
not working for JAR URLConnection

There have been a number of fixes to bugs reported by Open Source projects
since the last availability email  :

  * b158 - JDK-8173028 : Incorrect processing of supplementary-plane
characters in text fields
  * b158 - JDK-8172967 : [macosx] Exception while working with layout
for text containing unmappable character
  * b158 - JDK-8173804 : javadoc throws UnsupportedOperationException:
should not happen
  * b157 - JDK-8174073 : NPE caused by @link reference to class
  * b156 - JDK-8172726 : ForkJoin common pool retains a reference to the
thread context class loader

The following changeset is included in jdk-9+158:
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/8b0d55e02f54

If you have a user-defined Policy implementation that grants
FilePermission on ${user.dir}/-, reading a file in the current directory
using its base name will fail.  Still the same solution: Ensure that the
path used in permission granting has the same style as the one how you
access the file.

Setting -Djdk.security.filePermCompat=true will take you back to the
jdk-9+140 behavior.
Setting -Djdk.io.permissionsUseCanonicalPath=true will take you back to
the jdk8 behavior.
Feedback is welcome on jdk9-...@openjdk.java.net

*JDK 8u152 **Early Access b01  *is
available on java.net

Other areas of interest

  * JDK 9 Developer Guide [1]
  * JDK 9 Migration Guide [2]
  * JDK Cryptographic Roadmap [3]

Finaly, Dalibor and I gave a presentation at FOSDEM the video is available
here [*4*]


This BZ https://bz.apache.org/bugzilla/show_bug.cgi?id=60560 caught my
attention about support for System.inheritedChannel. NIO is supported, but
for some reason NIO2 support was never added. Due to its limitations (only
one channel) the API isn't particularly helpful so many it's because it is
considered almost deprecated. Any comments ?

Thanks,
Rémy


Rgds,Rory

[1] http://docs.oracle.com/javase/9/javase-docs.htm
[2] https://docs.oracle.com/javase/9/migrate/toc.htm#JSMIG-GUID-
7744EF96-5899-4FB2-B34E-86D49B2E89B6
[3] https://www.java.com/en/jre-jdk-cryptoroadmap.html
[4] https://fosdem.org/2017/schedule/event/outreach/

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland




--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland

[Bug 60875] Process Request null pointer exception.

2017-03-20 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60875

--- Comment #2 from Aaron  ---
I am using SpringBoot. And deploy war to tomcat. All request processed in
Controller. No code related to request and response. Can you provide more
details about this problem? thx!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Read events suspend/resume logic in websocket impl to achieve backpressure

2017-03-20 Thread Violeta Georgieva 
Hi,

2017-02-27 16:50 GMT+02:00 Mark Thomas :
>
> On 27/02/17 11:55, Violeta Georgieva wrote:
>
> 
>
> >> A new patch is available based on the provided comments.
> >> Can you please review it.
> >
> > Any feedback for the latest changes
>
> Sorry for the delay.
>
> On a minor/style point, I'd prefer SUSPENDED rather than READ_SUSPENDED
> since the socket won't be eligible for read or write.

Ok

> Thinking some more about that, could that cause problems? Does the patch
> need to ensure write operations aren't attempted? Non-blocking writes
> should be OK but a blocking write would be problematic.

I was thinking something
around org.apache.tomcat.websocket.WsRemoteEndpointBasic.send* methods.
If the reading is suspended then these methods will do nothing and log
error.
What do you think?

> I think there is still a timing / concurrency issue around resume().
> Consider the following sequence:
> - incoming message is being processed in WsFrameServer
> - suspend() is called on another thread
> - while loop ends and onDataAvailable returns
> - resume() is called on another thread
> - then WsHttpUpgradeHandler checks if the thread is suspended
>
> The problem is between onDataAvailable returning and
> WsHttpUpgradeHandler checking if the thread is suspended. If resume() is
> called and processed during that admittedly narrow gap, the socket will
> end up in the Poller twice which - from past experience - will cause
> problems.

I fixed that. The PR https://github.com/apache/tomcat/pull/42 is updated.

> Overall, I like the approach and would support apply a patch along these
> lines once the timing issues are resolved.

Thanks for the review,
Violeta

> 
>
> >>> This approach would mean some internal API changes but that is fine
for
> > 9.0.x and I don't see a problem with 8.5.x either. Whether this is
> > back-ported to 8.0.x and 7.0.x is TBD. It also opens up the possibility
of
> > being able to suspend/resume other protocols but I haven't thought a
great
> > deal about how that might work.
> >>
> >> I need this functionality only for 9.0.x and 8.5.x.
>
> Then let's not back-port this any earlier than 8.5.x.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2017-03-20 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-nio2 :  Tomcat 8.x, a web server implementing the 
Java Servlet 3.1,
...


Full details are available at:

http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 20 mins 20 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dexecute.test.nio2=true -Dtest.temp=output/test-tmp-NIO2 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dtest.accesslog=true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170320.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20170320/bin/openssl
 -Dexecute.test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dexecute.test.apr=false -Dexecute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170320-native-src.tar.gz
 -Dtest.repor
 ts=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170320-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.0.x/true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/wo

[Bug 60892] New: Ability to remove Tomcat cache (work dir)

2017-03-20 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60892

Bug ID: 60892
   Summary: Ability to remove Tomcat cache (work dir)
   Product: Tomcat 8
   Version: 8.0.42
  Hardware: Other
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: czacha...@gmail.com
  Target Milestone: 

I would like to make a feature request that will allow Tomcat to clear the
"work" directory in context destroy (shutdown/undeploy).  This feature exists
in JBoss.  Would be great to have this in Tomcat so manual cleanup is not
needed.

This can be done is JBoss this way:

-Dorg.jboss.as.web.deployment.DELETE_WORK_DIR_ONCONTEXTDESTROY=true

Would be a good feature to have something similar in Tomcat.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org