svn commit: r1779149 - in /tomcat/trunk: java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/mbeans-descriptors.xml webapps/docs/changelog.xml webapps/docs/confi

2017-01-17 Thread kfujino
Author: kfujino
Date: Tue Jan 17 08:35:29 2017
New Revision: 1779149

URL: http://svn.apache.org/viewvc?rev=1779149&view=rev
Log:
Make the accessTimeout configurable in BackupManager.
The accessTimeout is used as a timeout period for PING in replication map.

Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java
tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/cluster-manager.xml

Modified: tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java?rev=1779149&r1=1779148&r2=1779149&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java Tue Jan 
17 08:35:29 2017
@@ -69,6 +69,11 @@ public class BackupManager extends Clust
 private boolean terminateOnStartFailure = false;
 
 /**
+ * The timeout for a ping message in replication map.
+ */
+private long accessTimeout = 5000;
+
+/**
  * Constructor, just calls super()
  *
  */
@@ -144,6 +149,7 @@ public class BackupManager extends Clust
 this, cluster.getChannel(), rpcTimeout, getMapName(),
 getClassLoaders(), terminateOnStartFailure);
 map.setChannelSendOptions(mapSendOptions);
+map.setAccessTimeout(accessTimeout);
 this.sessions = map;
 }  catch ( Exception x ) {
 log.error(sm.getString("backupManager.startUnable", getName()),x);
@@ -215,6 +221,14 @@ public class BackupManager extends Clust
 return terminateOnStartFailure;
 }
 
+public long getAccessTimeout() {
+return accessTimeout;
+}
+
+public void setAccessTimeout(long accessTimeout) {
+this.accessTimeout = accessTimeout;
+}
+
 @Override
 public String[] getInvalidatedSessions() {
 return new String[0];
@@ -227,6 +241,7 @@ public class BackupManager extends Clust
 result.mapSendOptions = mapSendOptions;
 result.rpcTimeout = rpcTimeout;
 result.terminateOnStartFailure = terminateOnStartFailure;
+result.accessTimeout = accessTimeout;
 return result;
 }
 

Modified: 
tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml?rev=1779149&r1=1779148&r2=1779149&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml Tue 
Jan 17 08:35:29 2017
@@ -536,6 +536,10 @@
   name="warnOnSessionAttributeFilterFailure"
   description="Should a WARN level log message be generated if a session 
attribute fails to match sessionAttributeNameFilter or 
sessionAttributeClassNameFilter?"
   type="boolean"/>
+
 http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1779149&r1=1779148&r2=1779149&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Jan 17 08:35:29 2017
@@ -57,6 +57,15 @@
   
 
   
+  
+
+  
+Make the accessTimeout configurable in
+BackupManager. The accessTimeout is used as a
+timeout period for PING in replication map. (kfujino)
+  
+
+  
   
 
   

Modified: tomcat/trunk/webapps/docs/config/cluster-manager.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/cluster-manager.xml?rev=1779149&r1=1779148&r2=1779149&view=diff
==
--- tomcat/trunk/webapps/docs/config/cluster-manager.xml (original)
+++ tomcat/trunk/webapps/docs/config/cluster-manager.xml Tue Jan 17 08:35:29 
2017
@@ -265,6 +265,11 @@
 false unless a SecurityManager is enabled in
 which case the default will be true.
   
+  
+The timeout for a ping message. If a remote map does not respond within
+this timeout period, its regarded as disappeared.
+Default value is 5000 milliseconds.
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779150 - in /tomcat/tc8.5.x/trunk: java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/mbeans-descriptors.xml webapps/docs/changelog.xml webapps/do

2017-01-17 Thread kfujino
Author: kfujino
Date: Tue Jan 17 08:37:33 2017
New Revision: 1779150

URL: http://svn.apache.org/viewvc?rev=1779150&view=rev
Log:
Make the accessTimeout configurable in BackupManager.
The accessTimeout is used as a timeout period for PING in replication map.

Modified:
tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.5.x/trunk/webapps/docs/config/cluster-manager.xml

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java?rev=1779150&r1=1779149&r2=1779150&view=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java 
(original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java 
Tue Jan 17 08:37:33 2017
@@ -69,6 +69,11 @@ public class BackupManager extends Clust
 private boolean terminateOnStartFailure = false;
 
 /**
+ * The timeout for a ping message in replication map.
+ */
+private long accessTimeout = 5000;
+
+/**
  * Constructor, just calls super()
  *
  */
@@ -144,6 +149,7 @@ public class BackupManager extends Clust
 this, cluster.getChannel(), rpcTimeout, getMapName(),
 getClassLoaders(), terminateOnStartFailure);
 map.setChannelSendOptions(mapSendOptions);
+map.setAccessTimeout(accessTimeout);
 this.sessions = map;
 }  catch ( Exception x ) {
 log.error(sm.getString("backupManager.startUnable", getName()),x);
@@ -215,6 +221,14 @@ public class BackupManager extends Clust
 return terminateOnStartFailure;
 }
 
+public long getAccessTimeout() {
+return accessTimeout;
+}
+
+public void setAccessTimeout(long accessTimeout) {
+this.accessTimeout = accessTimeout;
+}
+
 @Override
 public String[] getInvalidatedSessions() {
 return new String[0];
@@ -227,6 +241,7 @@ public class BackupManager extends Clust
 result.mapSendOptions = mapSendOptions;
 result.rpcTimeout = rpcTimeout;
 result.terminateOnStartFailure = terminateOnStartFailure;
+result.accessTimeout = accessTimeout;
 return result;
 }
 

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml?rev=1779150&r1=1779149&r2=1779150&view=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
(original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
Tue Jan 17 08:37:33 2017
@@ -536,6 +536,10 @@
   name="warnOnSessionAttributeFilterFailure"
   description="Should a WARN level log message be generated if a session 
attribute fails to match sessionAttributeNameFilter or 
sessionAttributeClassNameFilter?"
   type="boolean"/>
+
 http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1779150&r1=1779149&r2=1779150&view=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Tue Jan 17 08:37:33 2017
@@ -57,6 +57,15 @@
   
 
   
+  
+
+  
+Make the accessTimeout configurable in
+BackupManager. The accessTimeout is used as a
+timeout period for PING in replication map. (kfujino)
+  
+
+  
   
 
   

Modified: tomcat/tc8.5.x/trunk/webapps/docs/config/cluster-manager.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/config/cluster-manager.xml?rev=1779150&r1=1779149&r2=1779150&view=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/config/cluster-manager.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/config/cluster-manager.xml Tue Jan 17 
08:37:33 2017
@@ -265,6 +265,11 @@
 false unless a SecurityManager is enabled in
 which case the default will be true.
   
+  
+The timeout for a ping message. If a remote map does not respond within
+this timeout period, its regarded as disappeared.
+Default value is 5000 milliseconds.
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779152 - in /tomcat/tc8.0.x/trunk: java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/mbeans-descriptors.xml webapps/docs/changelog.xml webapps/do

2017-01-17 Thread kfujino
Author: kfujino
Date: Tue Jan 17 08:39:57 2017
New Revision: 1779152

URL: http://svn.apache.org/viewvc?rev=1779152&view=rev
Log:
Make the accessTimeout configurable in BackupManager.
The accessTimeout is used as a timeout period for PING in replication map.

Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.0.x/trunk/webapps/docs/config/cluster-manager.xml

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java?rev=1779152&r1=1779151&r2=1779152&view=diff
==
--- tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java 
(original)
+++ tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java 
Tue Jan 17 08:39:57 2017
@@ -69,6 +69,11 @@ public class BackupManager extends Clust
 private boolean terminateOnStartFailure = false;
 
 /**
+ * The timeout for a ping message in replication map.
+ */
+private long accessTimeout = 5000;
+
+/**
  * Constructor, just calls super()
  *
  */
@@ -144,6 +149,7 @@ public class BackupManager extends Clust
 this, cluster.getChannel(), rpcTimeout, getMapName(),
 getClassLoaders(), terminateOnStartFailure);
 map.setChannelSendOptions(mapSendOptions);
+map.setAccessTimeout(accessTimeout);
 this.sessions = map;
 }  catch ( Exception x ) {
 log.error(sm.getString("backupManager.startUnable", getName()),x);
@@ -215,6 +221,14 @@ public class BackupManager extends Clust
 return terminateOnStartFailure;
 }
 
+public long getAccessTimeout() {
+return accessTimeout;
+}
+
+public void setAccessTimeout(long accessTimeout) {
+this.accessTimeout = accessTimeout;
+}
+
 @Override
 public String[] getInvalidatedSessions() {
 return new String[0];
@@ -227,6 +241,7 @@ public class BackupManager extends Clust
 result.mapSendOptions = mapSendOptions;
 result.rpcTimeout = rpcTimeout;
 result.terminateOnStartFailure = terminateOnStartFailure;
+result.accessTimeout = accessTimeout;
 return result;
 }
 

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml?rev=1779152&r1=1779151&r2=1779152&view=diff
==
--- 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
(original)
+++ 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
Tue Jan 17 08:39:57 2017
@@ -560,6 +560,10 @@
   name="warnOnSessionAttributeFilterFailure"
   description="Should a WARN level log message be generated if a session 
attribute fails to match sessionAttributeNameFilter or 
sessionAttributeClassNameFilter?"
   type="boolean"/>
+
 http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1779152&r1=1779151&r2=1779152&view=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Tue Jan 17 08:39:57 2017
@@ -45,6 +45,15 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  
+Make the accessTimeout configurable in
+BackupManager. The accessTimeout is used as a
+timeout period for PING in replication map. (kfujino)
+  
+
+  
 
 
   

Modified: tomcat/tc8.0.x/trunk/webapps/docs/config/cluster-manager.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/config/cluster-manager.xml?rev=1779152&r1=1779151&r2=1779152&view=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/config/cluster-manager.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/config/cluster-manager.xml Tue Jan 17 
08:39:57 2017
@@ -285,6 +285,11 @@
 false unless a SecurityManager is enabled in
 which case the default will be true.
   
+  
+The timeout for a ping message. If a remote map does not respond within
+this timeout period, its regarded as disappeared.
+Default value is 5000 milliseconds.
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779153 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/mbeans-descriptors.xml webapps/docs/changelog.xml webapps/do

2017-01-17 Thread kfujino
Author: kfujino
Date: Tue Jan 17 08:41:46 2017
New Revision: 1779153

URL: http://svn.apache.org/viewvc?rev=1779153&view=rev
Log:
Make the accessTimeout configurable in BackupManager.
The accessTimeout is used as a timeout period for PING in replication map.

Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc7.0.x/trunk/webapps/docs/config/cluster-manager.xml

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java?rev=1779153&r1=1779152&r2=1779153&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java 
Tue Jan 17 08:41:46 2017
@@ -77,6 +77,11 @@ public class BackupManager extends Clust
 private boolean terminateOnStartFailure = false;
 
 /**
+ * The timeout for a ping message in replication map.
+ */
+private long accessTimeout = 5000;
+
+/**
  * Constructor, just calls super()
  *
  */
@@ -172,6 +177,7 @@ public class BackupManager extends Clust
 cluster.getChannel(), rpcTimeout, getMapName(),
 getClassLoaders(), terminateOnStartFailure);
 map.setChannelSendOptions(mapSendOptions);
+map.setAccessTimeout(accessTimeout);
 this.sessions = map;
 }  catch ( Exception x ) {
 log.error(sm.getString("backupManager.startUnable", getName()),x);
@@ -243,6 +249,14 @@ public class BackupManager extends Clust
 return terminateOnStartFailure;
 }
 
+public long getAccessTimeout() {
+return accessTimeout;
+}
+
+public void setAccessTimeout(long accessTimeout) {
+this.accessTimeout = accessTimeout;
+}
+
 @Override
 public String[] getInvalidatedSessions() {
 return new String[0];
@@ -256,6 +270,7 @@ public class BackupManager extends Clust
 result.mapSendOptions = mapSendOptions;
 result.rpcTimeout = rpcTimeout;
 result.terminateOnStartFailure = terminateOnStartFailure;
+result.accessTimeout = accessTimeout;
 return result;
 }
 

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml?rev=1779153&r1=1779152&r2=1779153&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
(original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
Tue Jan 17 08:41:46 2017
@@ -592,6 +592,10 @@
   name="warnOnSessionAttributeFilterFailure"
   description="Should a WARN level log message be generated if a session 
attribute fails to match sessionAttributeNameFilter or 
sessionAttributeClassNameFilter?"
   type="boolean"/>
+
 http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1779153&r1=1779152&r2=1779153&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Jan 17 08:41:46 2017
@@ -58,6 +58,15 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  
+Make the accessTimeout configurable in
+BackupManager. The accessTimeout is used as a
+timeout period for PING in replication map. (kfujino)
+  
+
+  
 
 
   

Modified: tomcat/tc7.0.x/trunk/webapps/docs/config/cluster-manager.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/config/cluster-manager.xml?rev=1779153&r1=1779152&r2=1779153&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/config/cluster-manager.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/config/cluster-manager.xml Tue Jan 17 
08:41:46 2017
@@ -290,6 +290,11 @@
 false unless a SecurityManager is enabled in
 which case the default will be true.
   
+  
+The timeout for a ping message. If a remote map does not respond within
+this timeout period, its regarded as disappeared.
+Default value is 5000 milliseconds.
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.40

2017-01-17 Thread Keiichi Fujino
2017-01-13 21:39 GMT+09:00 Violeta Georgieva :

> The proposed Apache Tomcat 8.0.40 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.40/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1116/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_40/
>
> The proposed 8.0.40 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.40
>
> +1
Tested on my test apps (enable BackupManager)


> Regards,
> Violeta
>
> --
> Keiichi.Fujino
>


Re: [VOTE] Release Apache Tomcat 7.0.74

2017-01-17 Thread Keiichi Fujino
2017-01-13 19:55 GMT+09:00 Violeta Georgieva :

> The proposed Apache Tomcat 7.0.74 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.74/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1115/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_74/
>
> The proposed 7.0.74 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.74 Stable
>
> +1
Tested on my test apps (enable BackupManager)


> Regards,
> Violeta
>
> --
> Keiichi.Fujino
>


Re: [VOTE] Release Apache Tomcat 7.0.74

2017-01-17 Thread Konstantin Kolinko
2017-01-13 13:55 GMT+03:00 Violeta Georgieva :
> The proposed Apache Tomcat 7.0.74 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.74/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1115/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_74/
>
> The proposed 7.0.74 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.74 Stable


Unit tests OK (all connectors, Java 6/7/8 32-bit on Windows 10)
Smoke testing OK.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2017-01-17 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-nio2 :  Tomcat 8.x, a web server implementing the 
Java Servlet 3.1,
...


Full details are available at:

http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 19 mins 35 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dexecute.test.nio2=true -Dtest.temp=output/test-tmp-NIO2 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dtest.accesslog=true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170117.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20170117/bin/openssl
 -Dexecute.test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dexecute.test.apr=false -Dexecute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170117-native-src.tar.gz
 -Dtest.repor
 ts=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170117-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.0.x/true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/wo

[Bug 60596] New: Improve performance of DefaultServlet.checkSendfile() when SendFile feature is disabled on a connector

2017-01-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60596

Bug ID: 60596
   Summary: Improve performance of DefaultServlet.checkSendfile()
when SendFile feature is disabled on a connector
   Product: Tomcat 9
   Version: 9.0.0.M17
  Hardware: PC
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: knst.koli...@gmail.com
  Target Milestone: -

Reviewing SendFile support in DefaultServlet,
the feature is implemented with the following code in current trunk:

// method DefaultServlet.checkSendfile()

if (sendfileSize > 0
&& resource.isFile()
&& length > sendfileSize
&& (resource.getCanonicalPath() != null)
&&
(Boolean.TRUE.equals(request.getAttribute(Globals.SENDFILE_SUPPORTED_ATTR)))
&&
(request.getClass().getName().equals("org.apache.catalina.connector.RequestFacade"))
&&
(response.getClass().getName().equals("org.apache.catalina.connector.ResponseFacade")))
{
request.setAttribute(Globals.SENDFILE_FILENAME_ATTR,
resource.getCanonicalPath());


Notes:

1. It is better to check for
request.getAttribute(Globals.SENDFILE_SUPPORTED_ATTR) flag first.

Calling resource.isFile() and resource.getCanonicalPath() incurs I/O processing
that is not needed when send file feature is disabled on a Connector.

2. resource.getCanonicalPath() is calculated twice. First time to check that it
is not null, second time to set SENDFILE_FILENAME_ATTR attribute.


In general, all this activity will be followed by File I/O, so performance
improvement may be small compared to the rest of I/O.

Duplicate evaluation of getCanonicalPath() is not a matter for Tomcat 7 and
earlier, as in the old JNDI implementation of resources the value of canonical
path is cached (see
org.apache.naming.resources.FileResourceAttributes.getCanonicalPath()).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60126] The code of method invoke0(JspWriter) is exceeding the 65535 bytes limit

2017-01-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60126

--- Comment #6 from Ralf Hauser  ---
we got that problem when upgrading from tc8.0.14 to 8.5.9 for several jsp pages
that before didn't have it (and not change to the jsp).

1) the jsp generation got less efficient!

before 8.0.14: wc outboxmessage_005fen_jsp.java
  20511   97184 1708876 outboxmessage_005fen_jsp.java

now 8.5.9: wc outboxmessage_005fen_jsp.java
  20874   98766 1651642 outboxmessage_005fen_jsp.java

(although interestingly bytes do not behave the same as words)

2) rights and date have changed, before it was the correct date, now we see
sometimes 

  $ sudo ls -lart 
  -rw-r- 1 root root 1651642 Jan  1  1970 /var/cache/tomcat8...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60126] The code of method invoke0(JspWriter) is exceeding the 65535 bytes limit

2017-01-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60126

Ralf Hauser  changed:

   What|Removed |Added

 CC||hau...@acm.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60597] New: Add ability to set cipher suites for websocket connections

2017-01-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60597

Bug ID: 60597
   Summary: Add ability to set cipher suites for websocket
connections
   Product: Tomcat 7
   Version: 7.0.73
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P2
 Component: WebSocket
  Assignee: dev@tomcat.apache.org
  Reporter: michaelomich...@gmail.com
  Target Milestone: ---

Created attachment 34633
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34633&action=edit
Proposed patch to add SSL_CIPHER_SUITES property

There is a user property "org.apache.tomcat.websocket.SSL_PROTOCOLS"
that you can use to provide the list of permitted SSL protocols when
connecting to a websocket with WsWebSocketContainer.  

I was expecting that there would be a similar property to allow you to set the
list of permitted SSL cipher suites as well (e.g.
"org.apache.tomcat.websocket.SSL_CIPHER_SUITES"), but such a property doesn't
exist in 7.0.73.

I've attached a proposed patch to add the latter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Need to consider a replacement for */ in WAR URLs

2017-01-17 Thread Christopher Schultz
Mark,

On 1/16/17 6:24 AM, Mark Thomas wrote:
> For the background see:
> https://github.com/spring-projects/spring-boot/issues/7949
> 
> The short version is:
> 
> * is seen as a wild card in some environments.
> 
> The options are:
> $ & ' ( ) * , - . : ; @ _ ~
> (all followed by /)

Obviously you can't use "." since that is in 99% of WAR filenames. The
";" character is used for file-versions in VMS. I'm not sure how many
VMS environments are running Tomcat, but ... it's a thing. Hyphen (-)
and underscore (_) are probably too popular. I'd say that $ & : @ * are
good contenders. But we are trying to replace * no?

> Ideally we want a character that:
> - is unlikely to appear in a file name (particularly at the end)
> - does not have a special meaning that could conflict when using it in
> combination with / in a URI to mark the start of the internal WAR path.
> 
> Thoughts, comments, reasons for excluding one or more of these
> characters welcome.

So you want a character that can be used in the WAR file name that
converts to a "*" in the context-path? Or you want a character in a
war:// URL that can be used as the barrier between the physical filename
and the logical file within the WAR file? If the latter, what's wrong
with the jar:// usage of "!/" ?

We are already using # for / and IMO that can be buggy since # has
meaning in URLs. What about using an escape-character instead of a stand-in?

-chris





signature.asc
Description: OpenPGP digital signature


[Bug 60126] The code of method invoke0(JspWriter) is exceeding the 65535 bytes limit

2017-01-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60126

--- Comment #7 from Christopher Schultz  ---
(In reply to Ralf Hauser from comment #5)
> see also bug 60578#c3

I'm not sure these bugs are related in any way.

I'm surprised to see a file owned by root. That should not be possible unless
your process permissions are for admin (which is a terrible idea). I don't
believe Tomcat attempts to adjust permissions or file timestamps.

I you are having the "bytes exceeded" problem, your only recourse is to re-work
the JSP to be shorter or more modular.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-01-17 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.5-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.5-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20170117.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.6-SNAPSHOT.jar
 
:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20170117.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20170117.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-22.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-7.5-SNAPSHOT.jar

setproxy:

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
[checkstyle] Running Checkstyle 7.5-SNAPSHOT on 3095 files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml:542:
 Line matches the illegal pattern '\s+$'. [RegexpSingleline]

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:540: Got 1 errors and 0 
warnings.

Total time: 17 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/rss.xml
- Atom: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 20170117180005, vmgump-vm3.apache.org:vmgump:20170117180005
Gump E-mail Identifier (unique within run) #1.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump-vm3]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Need to consider a replacement for */ in WAR URLs

2017-01-17 Thread Mark Thomas
On 17/01/2017 18:07, Christopher Schultz wrote:
> Mark,
> 
> On 1/16/17 6:24 AM, Mark Thomas wrote:
>> For the background see:
>> https://github.com/spring-projects/spring-boot/issues/7949
>>
>> The short version is:
>>
>> * is seen as a wild card in some environments.
>>
>> The options are:
>> $ & ' ( ) * , - . : ; @ _ ~
>> (all followed by /)
> 
> Obviously you can't use "." since that is in 99% of WAR filenames. The
> ";" character is used for file-versions in VMS. I'm not sure how many
> VMS environments are running Tomcat, but ... it's a thing. Hyphen (-)
> and underscore (_) are probably too popular. I'd say that $ & : @ * are
> good contenders. But we are trying to replace * no?
> 
>> Ideally we want a character that:
>> - is unlikely to appear in a file name (particularly at the end)
>> - does not have a special meaning that could conflict when using it in
>> combination with / in a URI to mark the start of the internal WAR path.
>>
>> Thoughts, comments, reasons for excluding one or more of these
>> characters welcome.
> 
> So you want a character that can be used in the WAR file name that
> converts to a "*" in the context-path? Or you want a character in a
> war:// URL that can be used as the barrier between the physical filename
> and the logical file within the WAR file? If the latter, what's wrong
> with the jar:// usage of "!/" ?

We need to be able to reference resources in JARs in WARs. Experience
has shown that nest jar URLs don't work. We needed a dedicated war URL
format. We currently use:
war://...*/...

We previously used
war://...^/...

The former has issues in some use cases. The latter results in invalid URLs.

> We are already using # for / and IMO that can be buggy since # has
> meaning in URLs. What about using an escape-character instead of a stand-in?

It has to be a character that Java will expect in a URL.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779247 - in /tomcat/site/trunk: docs/whichversion.html xdocs/whichversion.xml

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:06:37 2017
New Revision: 1779247

URL: http://svn.apache.org/viewvc?rev=1779247&view=rev
Log:
Note that 6.0.x is now EOL

Modified:
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/docs/whichversion.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1779247&r1=1779246&r2=1779247&view=diff
==
--- tomcat/site/trunk/docs/whichversion.html (original)
+++ tomcat/site/trunk/docs/whichversion.html Tue Jan 17 20:06:37 2017
@@ -549,9 +549,9 @@ following improvements:
 
 
 
-Users of Tomcat 6 should be aware that the Tomcat team have announced the
-end of life date for Tomcat 6.x. Users of
-Tomcat 6.x should plan to upgrade before Tomcat 6.x reaches end of life.
+Users of Tomcat 6 should be aware that Tomcat 6 has now reached
+end of life. Users of Tomcat 6.x should
+upgrade to Tomcat 7.x or later.
 
 
 

Modified: tomcat/site/trunk/xdocs/whichversion.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whichversion.xml?rev=1779247&r1=1779246&r2=1779247&view=diff
==
--- tomcat/site/trunk/xdocs/whichversion.xml (original)
+++ tomcat/site/trunk/xdocs/whichversion.xml Tue Jan 17 20:06:37 2017
@@ -263,9 +263,9 @@ following improvements:
 Refactored clustering
 
 
-Users of Tomcat 6 should be aware that the Tomcat team have announced the
-end of life date for Tomcat 6.x. Users of
-Tomcat 6.x should plan to upgrade before Tomcat 6.x reaches end of life.
+Users of Tomcat 6 should be aware that Tomcat 6 has now reached
+end of life. Users of Tomcat 6.x should
+upgrade to Tomcat 7.x or later.
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779249 - in /tomcat/site/trunk: docs/ xdocs/

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:15:56 2017
New Revision: 1779249

URL: http://svn.apache.org/viewvc?rev=1779249&view=rev
Log:
Update for 8.5.9 and 9.0.0.M17 releases (excluding Javadoc)

Modified:
tomcat/site/trunk/docs/download-80.html
tomcat/site/trunk/docs/download-90.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-85.html
tomcat/site/trunk/docs/migration-9.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/download-80.xml
tomcat/site/trunk/xdocs/download-90.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-85.xml
tomcat/site/trunk/xdocs/migration-9.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/docs/download-80.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-80.html?rev=1779249&r1=1779248&r2=1779249&view=diff
==
--- tomcat/site/trunk/docs/download-80.html (original)
+++ tomcat/site/trunk/docs/download-80.html Tue Jan 17 20:15:56 2017
@@ -222,7 +222,7 @@
 Quick Navigation
 
 
-[define v]8.5.9[end]
+[define v]8.5.11[end]
 [define w]8.0.39[end]
 https://www.apache.org/dist/tomcat/tomcat-8/KEYS";>KEYS |
 [v] |

Modified: tomcat/site/trunk/docs/download-90.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-90.html?rev=1779249&r1=1779248&r2=1779249&view=diff
==
--- tomcat/site/trunk/docs/download-90.html (original)
+++ tomcat/site/trunk/docs/download-90.html Tue Jan 17 20:15:56 2017
@@ -222,7 +222,7 @@
 Quick Navigation
 
 
-[define v]9.0.0.M15[end]
+[define v]9.0.0.M17[end]
 https://www.apache.org/dist/tomcat/tomcat-9/KEYS";>KEYS |
 [v] |
 Browse |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1779249&r1=1779248&r2=1779249&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Tue Jan 17 20:15:56 2017
@@ -246,32 +246,34 @@ project logo are trademarks of the Apach
 
 
 
-2016-12-08 Tomcat 8.5.9 Released
+2017-01-16 Tomcat 8.5.9 Released
 
 
 
-The Apache Tomcat Project is proud to announce the release of version 8.5.9
+The Apache Tomcat Project is proud to announce the release of version 8.5.11
 of Apache Tomcat. Apache Tomcat 8.5.x is intended to replace 8.0.x and includes
 new features pulled forward from Tomcat 9.0.x. The minimum Java version and
 implemented specification versions remain unchanged. The notable changes
-compared to 8.5.8 include:
+compared to 8.5.9 include:
 
 
 
-Improvements to SPNEGO authentication. Patches provided by Michael
-Osipov.
+HTTP/2 fixes and improvements
 
-Correct regression in I/O buffer handling.
+Improve the logic that selects an address to use to unlock the Acceptor to
+take account of platforms what do not listen on all local addresses when
+configured with an address of 0.0.0.0 or ::
+
 
-Improve handling of varargs in UEL expressions. Based on a patch by
-Ben.
+Fix a bug in APR/native socket close handling that resulted in unexpected
+errors for upgraded connections
 
 
 
 
 
 Full details of these changes, and all the other changes, are available in the
-Tomcat 8.5
+Tomcat 8.5
 changelog.
 
 
@@ -283,33 +285,35 @@ changelog.
 
 
 
-
-2016-12-08 Tomcat 9.0.0.M15 (alpha) 
Released
+
+2017-01-16 Tomcat 9.0.0.M17 (alpha) 
Released
 
 
 
-The Apache Tomcat Project is proud to announce the release of version 9.0.0.M15
+The Apache Tomcat Project is proud to announce the release of version 9.0.0.M17
 (alpha) of Apache Tomcat. The is a milestone release of the 9.0.x branch and 
has
 been made to provide users with early access to the new features in Apache
 Tomcat 9.0.x so that they may provide feedback. The notable changes compared to
-9.0.0.M13 include:
+9.0.0.M15 include:
 
 
 
-Improvements to SPNEGO authentication. Patches provided by Michael
-Osipov.
+HTTP/2 fixes and improvements
 
-Correct regression in I/O buffer handling.
+Improve the logic that selects an address to use to unlock the Acceptor to
+take account of platforms what do not listen on all local addresses when
+configured with an address of 0.0.0.0 or ::
+
 
-Improve handling of varargs in UEL expressions. Based on a patch by
-Ben.
+Fix a bug in APR/native socket close handling that resulted in unexpected
+errors for upgraded connections
 
 
 
 
 
 Full details of these changes, and all the other changes, are available in the
-Tomcat 9
+Tomcat 9
 changelog.
 
 

Modified: tomcat/site/trunk/docs/migration-85.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-85.html?rev=1779249&r1=1779248&r2=1779249&view=d

Re: svn commit: r1779249 - in /tomcat/site/trunk: docs/ xdocs/

2017-01-17 Thread Konstantin Kolinko
2017-01-17 23:15 GMT+03:00  :
> Author: markt
> Date: Tue Jan 17 20:15:56 2017
> New Revision: 1779249
>
> URL: http://svn.apache.org/viewvc?rev=1779249&view=rev
> Log:
> Update for 8.5.9 and 9.0.0.M17 releases (excluding Javadoc)

Mark, it is 8.5.11


> Modified:
> tomcat/site/trunk/docs/download-80.html
> tomcat/site/trunk/docs/download-90.html
> tomcat/site/trunk/docs/index.html
> tomcat/site/trunk/docs/migration-85.html
> tomcat/site/trunk/docs/migration-9.html
> tomcat/site/trunk/docs/oldnews.html
> tomcat/site/trunk/docs/whichversion.html
> tomcat/site/trunk/xdocs/download-80.xml
> tomcat/site/trunk/xdocs/download-90.xml
> tomcat/site/trunk/xdocs/index.xml
> tomcat/site/trunk/xdocs/migration-85.xml
> tomcat/site/trunk/xdocs/migration-9.xml
> tomcat/site/trunk/xdocs/oldnews.xml
> tomcat/site/trunk/xdocs/whichversion.xml
>
> Modified: tomcat/site/trunk/docs/download-80.html
> Modified: tomcat/site/trunk/docs/download-90.html
> Modified: tomcat/site/trunk/docs/index.html
> URL: 
> http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1779249&r1=1779248&r2=1779249&view=diff
> ==
> --- tomcat/site/trunk/docs/index.html (original)
> +++ tomcat/site/trunk/docs/index.html Tue Jan 17 20:15:56 2017
> @@ -246,32 +246,34 @@ project logo are trademarks of the Apach
>
>  
>  
> -2016-12-08 Tomcat 8.5.9 Released
> +2017-01-16 Tomcat 8.5.9 Released

Should be 8.5.11 above.

>  
>
>  
> -The Apache Tomcat Project is proud to announce the release of version 8.5.9
> +The Apache Tomcat Project is proud to announce the release of version 8.5.11
>  of Apache Tomcat. Apache Tomcat 8.5.x is intended to replace 8.0.x and 
> includes
>  new features pulled forward from Tomcat 9.0.x. The minimum Java version and
>  implemented specification versions remain unchanged. The notable changes
> -compared to 8.5.8 include:
> +compared to 8.5.9 include:


All other places and files in this commit are OK.

Missing doap_Tomcat.rdf, but 8.5 an 9.0 are not listed there (yet).

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779252 - in /tomcat/site/trunk/docs/tomcat-8.5-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:27:49 2017
New Revision: 1779252

URL: http://svn.apache.org/viewvc?rev=1779252&view=rev
Log:
Update docs for 8.5.11 release


[This commit notification would consist of 74 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779254 - in /tomcat/site/trunk/docs/tomcat-9.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:39:48 2017
New Revision: 1779254

URL: http://svn.apache.org/viewvc?rev=1779254&view=rev
Log:
Update docs for 9.0.0.M17 release


[This commit notification would consist of 88 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779256 - /tomcat/site/trunk/build.properties.default

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:41:16 2017
New Revision: 1779256

URL: http://svn.apache.org/viewvc?rev=1779256&view=rev
Log:
Update doc versions

Modified:
tomcat/site/trunk/build.properties.default

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1779256&r1=1779255&r2=1779256&view=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Tue Jan 17 20:41:16 2017
@@ -39,8 +39,8 @@ tomcat.loc=http://www.apache.org/dist/to
 tomcat60=6.0.48
 tomcat70=7.0.73
 tomcat80=8.0.39
-tomcat85=8.5.9
-tomcat90=9.0.0.M15
+tomcat85=8.5.11
+tomcat90=9.0.0.M17
 
 # - Download destination -
 tomcat-site-docs.home=${base.path}/tomcat-site-docs/



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779255 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:40:57 2017
New Revision: 1779255

URL: http://svn.apache.org/viewvc?rev=1779255&view=rev
Log:
Missed version update

Modified:
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/xdocs/index.xml

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1779255&r1=1779254&r2=1779255&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Tue Jan 17 20:40:57 2017
@@ -245,8 +245,8 @@ project logo are trademarks of the Apach
 
 
 
-
-2017-01-16 Tomcat 8.5.9 Released
+
+2017-01-16 Tomcat 8.5.11 Released
 
 
 

Modified: tomcat/site/trunk/xdocs/index.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/index.xml?rev=1779255&r1=1779254&r2=1779255&view=diff
==
--- tomcat/site/trunk/xdocs/index.xml (original)
+++ tomcat/site/trunk/xdocs/index.xml Tue Jan 17 20:40:57 2017
@@ -39,7 +39,7 @@ project logo are trademarks of the Apach
 
 
 
-
+
 
 The Apache Tomcat Project is proud to announce the release of version 8.5.11
 of Apache Tomcat. Apache Tomcat 8.5.x is intended to replace 8.0.x and includes



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779257 - /tomcat/site/trunk/xdocs/doap_Tomcat.rdf

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:43:26 2017
New Revision: 1779257

URL: http://svn.apache.org/viewvc?rev=1779257&view=rev
Log:
Add 8.5.x release line

Modified:
tomcat/site/trunk/xdocs/doap_Tomcat.rdf

Modified: tomcat/site/trunk/xdocs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/doap_Tomcat.rdf?rev=1779257&r1=1779256&r2=1779257&view=diff
==
--- tomcat/site/trunk/xdocs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/xdocs/doap_Tomcat.rdf Tue Jan 17 20:43:26 2017
@@ -59,6 +59,13 @@
 
 
   
+Latest Stable 8.5.x Release
+2017-01-16
+8.5.11
+  
+
+
+  
 Latest Stable 8.0.x Release
 2016-11-14
 8.0.39



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779259 - /tomcat/site/trunk/docs/doap_Tomcat.rdf

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:45:59 2017
New Revision: 1779259

URL: http://svn.apache.org/viewvc?rev=1779259&view=rev
Log:
...and the generated file

Modified:
tomcat/site/trunk/docs/doap_Tomcat.rdf

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1779259&r1=1779258&r2=1779259&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Tue Jan 17 20:45:59 2017
@@ -59,6 +59,13 @@
 
 
   
+Latest Stable 8.5.x Release
+2017-01-16
+8.5.11
+  
+
+
+  
 Latest Stable 8.0.x Release
 2016-11-14
 8.0.39



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779261 - /tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:51:42 2017
New Revision: 1779261

URL: http://svn.apache.org/viewvc?rev=1779261&view=rev
Log:
ws police

Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml?rev=1779261&r1=1779260&r2=1779261&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml Tue 
Jan 17 20:51:42 2017
@@ -539,7 +539,7 @@
 
+  type="long"/>
 

svn commit: r1779262 - /tomcat/trunk/webapps/docs/changelog.xml

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:52:07 2017
New Revision: 1779262

URL: http://svn.apache.org/viewvc?rev=1779262&view=rev
Log:
Add release date

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1779262&r1=1779261&r2=1779262&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Jan 17 20:52:07 2017
@@ -86,7 +86,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1779263 - /tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:52:56 2017
New Revision: 1779263

URL: http://svn.apache.org/viewvc?rev=1779263&view=rev
Log:
ws police

Modified:

tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml?rev=1779263&r1=1779262&r2=1779263&view=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
(original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
Tue Jan 17 20:52:56 2017
@@ -539,7 +539,7 @@
 
+  type="long"/>
 

svn commit: r1779264 - /tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

2017-01-17 Thread markt
Author: markt
Date: Tue Jan 17 20:53:33 2017
New Revision: 1779264

URL: http://svn.apache.org/viewvc?rev=1779264&view=rev
Log:
Add release date

Modified:
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1779264&r1=1779263&r2=1779264&view=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Tue Jan 17 20:53:33 2017
@@ -86,7 +86,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60391] Problem resolving resources inside jar

2017-01-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60391

--- Comment #3 from Mark Thomas  ---
It has already been fixed in 8.0.x for 8.0.40 onwards (release currently in
progress)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Need to consider a replacement for */ in WAR URLs

2017-01-17 Thread Konstantin Kolinko
2017-01-17 22:19 GMT+03:00 Mark Thomas :
> On 17/01/2017 18:07, Christopher Schultz wrote:
>> Mark,
>>
>> On 1/16/17 6:24 AM, Mark Thomas wrote:
>>> For the background see:
>>> https://github.com/spring-projects/spring-boot/issues/7949
>>>
>>> The short version is:
>>>
>>> * is seen as a wild card in some environments.
>>>
>>> The options are:
>>> $ & ' ( ) * , - . : ; @ _ ~
>>> (all followed by /)
>>
>> Obviously you can't use "." since that is in 99% of WAR filenames. The
>> ";" character is used for file-versions in VMS. I'm not sure how many
>> VMS environments are running Tomcat, but ... it's a thing. Hyphen (-)
>> and underscore (_) are probably too popular. I'd say that $ & : @ * are
>> good contenders. But we are trying to replace * no?
>>
>>> Ideally we want a character that:
>>> - is unlikely to appear in a file name (particularly at the end)
>>> - does not have a special meaning that could conflict when using it in
>>> combination with / in a URI to mark the start of the internal WAR path.
>>>
>>> Thoughts, comments, reasons for excluding one or more of these
>>> characters welcome.
>>
>> So you want a character that can be used in the WAR file name that
>> converts to a "*" in the context-path? Or you want a character in a
>> war:// URL that can be used as the barrier between the physical filename
>> and the logical file within the WAR file? If the latter, what's wrong
>> with the jar:// usage of "!/" ?
>
> We need to be able to reference resources in JARs in WARs. Experience
> has shown that nest jar URLs don't work. We needed a dedicated war URL
> format. We currently use:
> war://...*/...
>
> We previously used
> war://...^/...
>
> The former has issues in some use cases. The latter results in invalid URLs.
>
>> We are already using # for / and IMO that can be buggy since # has
>> meaning in URLs. What about using an escape-character instead of a stand-in?
>
> It has to be a character that Java will expect in a URL.


1. The original bug report was about some embedding of Tomcat.

Maybe it will be enough to make the value configurable?


2. Are we limited to US-ASCII?  (If it were unicode, there are a lot
of funny characters to choose from.)

I see that these URLs can be used in catalina.policy (there is an
example there), so it looks that we are limited.


3. We can use a delimiter that is longer than 2 characters. We are not
limited to "char + '/'".


4. If the file part must refer an existing file, we can look for
".war/" incrementally and check whether it is an existing file.

Though depending on how this is implemented it this may lead to false
positives on Windows because of case-insensivity.

(I remember how years ago I observed collision of "manager" package vs
"Manager" class in isPackage() check during compilation of JSPs,
trying to run Tomcat as compiled by Eclipse (as a set of classes, not
packed into .jars)
https://bz.apache.org/bugzilla/show_bug.cgi?id=47323
)

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1779249 - in /tomcat/site/trunk: docs/ xdocs/

2017-01-17 Thread Mark Thomas
On 17/01/2017 20:27, Konstantin Kolinko wrote:
> 2017-01-17 23:15 GMT+03:00  :



> Should be 8.5.11 above.

Thanks. Fixed.



> Missing doap_Tomcat.rdf, but 8.5 an 9.0 are not listed there (yet).

I added 8.5.x. I wasn't sure about 9.0.x. I was wondering if we wanted
to wait until we had a stable release.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Need to consider a replacement for */ in WAR URLs

2017-01-17 Thread Mark Thomas
On 17/01/2017 21:08, Konstantin Kolinko wrote:
> 2017-01-17 22:19 GMT+03:00 Mark Thomas :
>> On 17/01/2017 18:07, Christopher Schultz wrote:
>>> Mark,
>>>
>>> On 1/16/17 6:24 AM, Mark Thomas wrote:
 For the background see:
 https://github.com/spring-projects/spring-boot/issues/7949

 The short version is:

 * is seen as a wild card in some environments.

 The options are:
 $ & ' ( ) * , - . : ; @ _ ~
 (all followed by /)
>>>
>>> Obviously you can't use "." since that is in 99% of WAR filenames. The
>>> ";" character is used for file-versions in VMS. I'm not sure how many
>>> VMS environments are running Tomcat, but ... it's a thing. Hyphen (-)
>>> and underscore (_) are probably too popular. I'd say that $ & : @ * are
>>> good contenders. But we are trying to replace * no?
>>>
 Ideally we want a character that:
 - is unlikely to appear in a file name (particularly at the end)
 - does not have a special meaning that could conflict when using it in
 combination with / in a URI to mark the start of the internal WAR path.

 Thoughts, comments, reasons for excluding one or more of these
 characters welcome.
>>>
>>> So you want a character that can be used in the WAR file name that
>>> converts to a "*" in the context-path? Or you want a character in a
>>> war:// URL that can be used as the barrier between the physical filename
>>> and the logical file within the WAR file? If the latter, what's wrong
>>> with the jar:// usage of "!/" ?
>>
>> We need to be able to reference resources in JARs in WARs. Experience
>> has shown that nest jar URLs don't work. We needed a dedicated war URL
>> format. We currently use:
>> war://...*/...
>>
>> We previously used
>> war://...^/...
>>
>> The former has issues in some use cases. The latter results in invalid URLs.
>>
>>> We are already using # for / and IMO that can be buggy since # has
>>> meaning in URLs. What about using an escape-character instead of a stand-in?
>>
>> It has to be a character that Java will expect in a URL.
> 
> 
> 1. The original bug report was about some embedding of Tomcat.
> 
> Maybe it will be enough to make the value configurable?

That might be a solution. It is certainly worth of some further thought.

> 2. Are we limited to US-ASCII?  (If it were unicode, there are a lot
> of funny characters to choose from.)

Yes, we are limited to US-ASCII.

> I see that these URLs can be used in catalina.policy (there is an
> example there), so it looks that we are limited.
> 
> 
> 3. We can use a delimiter that is longer than 2 characters. We are not
> limited to "char + '/'".

True. The main reason for a single character was consistency with the
JAR handling.

> 4. If the file part must refer an existing file, we can look for
> ".war/" incrementally and check whether it is an existing file.
> 
> Though depending on how this is implemented it this may lead to false
> positives on Windows because of case-insensivity.

Interesting idea. The check for an existing file could be relatively
expensive though.

Mark


> 
> (I remember how years ago I observed collision of "manager" package vs
> "Manager" class in isPackage() check during compilation of JSPs,
> trying to run Tomcat as compiled by Eclipse (as a set of classes, not
> packed into .jars)
> https://bz.apache.org/bugzilla/show_bug.cgi?id=47323
> )
> 
> Best regards,
> Konstantin Kolinko
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

2017-01-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594

Mark Thomas  changed:

   What|Removed |Added

   Severity|regression  |enhancement

--- Comment #1 from Mark Thomas  ---
Given that using an unencoded '{' or '}' in a URL is contrary to the RFCs and
that the fix that tightened the validation rules was in response to a security
vulnerability (CVE-2016-6816) I think it is unlikely that an option will be
introduced to make this validation optional.

It is quite likely that some sites could safely tolerate some characters.
However, it is also likely that the 'safe' set of invalid characters will vary
from site to site. That would therefore require a more complex configuration
option than simply allowing or disallowing a fixed set of characters.

Those interested in proposing a patch should look at lines 74-78 of
org.apache.tomcat.util.http.parser.HttpParser although I'll repeat I think it
is unlikely such a patch would be accepted.

All that code is static which means configuration via system properties -
something I'd prefer to see less of rather than more of in Tomcat.

For completeness, '|' seems to be another character that is fairly widely used
in unecoded form when it should be encoded.

Finally, changes related conformance to the relevant RFCs and Java EE
specifications are not treated as regressions. Therefore, I have moved this to
an enhancement request.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org