[Bug 60490] Several improvements to the ErrorReportValve

2016-12-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60490

Michael Osipov <1983-01...@gmx.net> changed:

   What|Removed |Added

  Attachment #34531|0   |1
is obsolete||

--- Comment #3 from Michael Osipov <1983-01...@gmx.net> ---
Created attachment 34537
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34537&action=edit
Patch for ErrorReportValve

Updated patch

* Line endings normalized
* message is already escaped at the start of report()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Deprecated attributes in error messages

2016-12-20 Thread Emmanuel Bourg
Hi,

I misconfigured a certificate with Tomcat 8.5.9 and received this
message in catalina.out

"Connector attribute SSLCertificateFile must be defined when using SSL
with APR"

(I tried to use a PKCS12 keystore with the APR connector instead of PEM
files)

Since the 'SSLCertificateFile' attribute is deprecated I guess the error
message should mention 'certificateFile' now? I haven't checked if other
error messages contain deprecated fields.

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60497] JSP custom tags returned to the tag pools to be reused without executing the doEndTag method

2016-12-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60497

--- Comment #6 from Remy Maucherat  ---
Created attachment 34540
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34540&action=edit
Change reuse logic

I'm not convinced by the explanation. Adding some more complexity to the
generated code if the issue is found to be legitimate. And for review too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org