svn commit: r1761535 - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2016-09-20 Thread violetagg
Author: violetagg
Date: Tue Sep 20 07:34:10 2016
New Revision: 1761535

URL: http://svn.apache.org/viewvc?rev=1761535&view=rev
Log:
Update docs for Apache Tomcat 7.0.72 release.


[This commit notification would consist of 68 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r15456 - /release/tomcat/tomcat-7/v7.0.70/

2016-09-20 Thread violetagg
Author: violetagg
Date: Tue Sep 20 07:47:32 2016
New Revision: 15456

Log:
Remove 7.0.70

Removed:
release/tomcat/tomcat-7/v7.0.70/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[ANN] Apache Tomcat 7.0.72 released

2016-09-20 Thread Violeta Georgieva
The Apache Tomcat team announces the immediate availability of Apache
Tomcat 7.0.72.

Apache Tomcat is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Expression Language and Java
WebSocket technologies.

This release contains a number of bug fixes and improvements compared to
version 7.0.70. The notable changes since 7.0.70 include:


- Update the packaged version of the Tomcat Native Library to 1.2.8
- Treat paths used to obtain a request dispatcher as encoded (configurable)


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-7.0-doc/changelog.html

Downloads:
http://tomcat.apache.org/download-70.cgi

Migration guides from Apache Tomcat 5.5.x and 6.0.x:
http://tomcat.apache.org/migration.html

Enjoy

The Apache Tomcat team


[Bug 60151] JNDI Datasource lookup failure - throws javax.naming.NamingException

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60151

--- Comment #2 from Per Carlson  ---
Created attachment 34276
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34276&action=edit
server.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60151] JNDI Datasource lookup failure - throws javax.naming.NamingException

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60151

--- Comment #3 from Per Carlson  ---
Created attachment 34277
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34277&action=edit
svvint/datasource1-include.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60151] JNDI Datasource lookup failure - throws javax.naming.NamingException

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60151

--- Comment #4 from Per Carlson  ---
Created attachment 34278
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34278&action=edit
svvconf/context1-include.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60151] JNDI Datasource lookup failure - throws javax.naming.NamingException

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60151

--- Comment #5 from Per Carlson  ---
Added server.xml and the includes XML-files

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60151] JNDI Datasource lookup failure - throws javax.naming.NamingException

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60151

--- Comment #6 from Mark Thomas  ---
That doesn't show where the ResourceLink is created.

Tomcat 8.0.x has always documented that the type attribute of a ResourceLink is
required. As of 8.0.37 this requirement is enforced.

It looks appears from the stack trace that that type attribute is missing. The
ResourceLink configuration information should confirm that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60151] JNDI Datasource lookup failure - throws javax.naming.NamingException

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60151

--- Comment #7 from Per Carlson  ---
I assume you are referring to the following clause in the in the changelog:

"When retrieving an object via a ResourceLink, ensure that the object obtained
is of the expected type."

It might just be me, but I think this very potential breakage of bases is
under-communicated. I'd preferred a much more clear notification of the impacts
of this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Early Access build 136 for JDK 9 & JDK 9 with Project Jigsaw are available on java.net

2016-09-20 Thread Rory O'Donnell


Hi Mark,

Early Access b136  for JDK 9 is 
available on java.net, summary of  changes are listed here 
.
Early Access b136  (#5506) for JDK 9 with 
Project Jigsaw is available on java.net, summary of  changes are listed 
here 
.


There have been a number of fixes to bugs reported by Open Source 
projects since the last availability email  :


 * 8165723 - b136 - core-libs JarFile::isMultiRelease() method returns
   false when it should return true
 * 8165116 - b136 - xml redirect function is not allowed even with
   enableExtensionFunctions

NOTE:-  Build 135 included a fix for JDK-8161016 which *has introduced a 
behavioral change to HttpURLConnection, more info:*


The behavior of HttpURLConnection when using a ProxySelector has been 
modified with this JDK release. Currently, HttpURLConnection.connect() 
call would fallback to a DIRECT connection attempt if the configured 
proxy/proxies failed to make a connection. This release introduces a 
change whereby no DIRECT connection will be attempted in such a 
scenario. Instead, the HttpURLConnection.connect() method will fail and 
throw an IOException which occurred from the last proxy tested. This 
behavior now matches with the HTTP connections made by popular web 
browsers. But this change will bring compatibility issues for the 
applications expecting a DIRECT connection when a proxy server is down 
or when wrong proxies are provided.

*

JDK 9 Outreach Survey*

In order to encourage and receive additional feedback from developers 
testing their applications with JDK 9,
the OpenJDK Quality Outreach effort has put together a very brief survey 
about your experiences with JDK 9 so far.


It is available at***https://www.surveymonkey.de/r/JDK9EA*

We would love to hear feedback from you!


Rgds,Rory

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland



svn commit: r1761550 - in /tomcat/trunk: java/org/apache/catalina/webresources/CachedResource.java webapps/docs/changelog.xml

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 10:46:11 2016
New Revision: 1761550

URL: http://svn.apache.org/viewvc?rev=1761550&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=60146
https://bz.apache.org/bugzilla/show_bug.cgi?id=60146
Improve performance for resource retrieval by making calls to 
WebResource.getInputStream() trigger caching if the resource is small enough.
Patch provided by mohitchugh.

Modified:
tomcat/trunk/java/org/apache/catalina/webresources/CachedResource.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/webresources/CachedResource.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/CachedResource.java?rev=1761550&r1=1761549&r2=1761550&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/webresources/CachedResource.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/CachedResource.java Tue 
Sep 20 10:46:11 2016
@@ -264,7 +264,7 @@ public class CachedResource implements W
 
 @Override
 public InputStream getInputStream() {
-byte[] content = cachedContent;
+byte[] content = getContent();
 if (content == null) {
 // Can't cache InputStreams
 return webResource.getInputStream();

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1761550&r1=1761549&r2=1761550&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Sep 20 10:46:11 2016
@@ -73,6 +73,11 @@
 localized when using OneLineFormatter. Patch provided by
 Tatsuya Bessho. (kfujino)
   
+  
+60146: Improve performance for resource retrieval by making
+calls to WebResource.getInputStream() trigger caching if the resource 
is
+small enough. Patch provided by mohitchugh. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1761551 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/webresources/CachedResource.java webapps/docs/changelog.xml

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 10:46:52 2016
New Revision: 1761551

URL: http://svn.apache.org/viewvc?rev=1761551&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60146
Improve performance for resource retrieval by making calls to 
WebResource.getInputStream() trigger caching if the resource is small enough.
Patch provided by mohitchugh.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/CachedResource.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 20 10:46:52 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759611,1760005,1760300,1760446,1760454,1760640,1760648,1761422
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474

svn commit: r1761552 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/webresources/CachedResource.java webapps/docs/changelog.xml

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 10:47:40 2016
New Revision: 1761552

URL: http://svn.apache.org/viewvc?rev=1761552&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60146
Improve performance for resource retrieval by making calls to 
WebResource.getInputStream() trigger caching if the resource is small enough.
Patch provided by mohitchugh.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/CachedResource.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 20 10:47:40 2016
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 
7,1684549-1684550,1685556,1685591,1685739,1685744,1685772,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1687544,1687551,1688563,1688841

[Bug 60146] Performance issue as CachedResource#getInputStream() is not caching data correctly

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60146

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Mark Thomas  ---
Thanks for the report and the patch.

This has been fixed in the following branches:
- 9.0.x for 9.0.0.M11 onwards
- 8.5.x for 8.5.6 onwards
- 8.0.x for 8.0.38 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60152] New: Allow exceptions from Connector.start() to be caught and handled in code that embeds Tomcat

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60152

Bug ID: 60152
   Summary: Allow exceptions from Connector.start() to be caught
and handled in code that embeds Tomcat
   Product: Tomcat 9
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: awilkin...@pivotal.io

Currently, when a Connector fails to start, Tomcat logs the exception twice
(once in the protocol and once in the service) and then swallows the exception.
This isn't very friendly when embedding Tomcat as it means that handling of the
exception and reporting it to the user is out of the embedder's control. We'd
like a couple of things to be possible:

1. Catching the exception that's thrown when the Connector is started.
2. Tomcat not to log anything

This would allow an embedder to take complete control of how the problem is
reported to a user.

In discussing this with Mark Thomas, one possibility that he raised was a
Connector equivalent of failCtxIfServletStartFails that both StandardContext
and StandardHost have today.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60152] Allow exceptions from Connector.start() to be caught and handled in code that embeds Tomcat

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60152

--- Comment #1 from Remy Maucherat  ---
+1 for 1) if it's not too hard, however -1 for 2) (Tomcat logs errors and stuff
pretty much everywhere, there's no switch for any of them, and it doesn't make
sense; please adjust the logging configuration to use some custom logger of
your own instead).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1761553 - /tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 10:55:04 2016
New Revision: 1761553

URL: http://svn.apache.org/viewvc?rev=1761553&view=rev
Log:
Fix typo in i18n string name

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties?rev=1761553&r1=1761552&r2=1761553&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties Tue 
Sep 20 10:55:04 2016
@@ -127,6 +127,6 @@ sslHostConfigCertificate.mismatch=The pr
 
 sslImplementation.cnfe= Unable to create SSLImplementation for class [{0}]
 
-slUtilBase.noneSupported=None of the [{0}] specified are supported by the SSL 
engine : [{1}]
+sslUtilBase.noneSupported=None of the [{0}] specified are supported by the SSL 
engine : [{1}]
 sslUtilBase.active=The [{0}] that are active are : [{1}]
 sslUtilBase.skipped=Some of the specified [{0}] are not supported by the SSL 
engine and have been skipped: [{1}]



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1761554 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/LocalStrings.properties

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 10:55:36 2016
New Revision: 1761554

URL: http://svn.apache.org/viewvc?rev=1761554&view=rev
Log:
Fix typo in i18n string name

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 20 10:55:36 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759611,1760005,1760300,1760446,1760454,1760640,1760648,1761422,1761550
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,17411

buildbot exception in on tomcat-8-trunk

2016-09-20 Thread buildbot
The Buildbot has detected a build exception on builder tomcat-8-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/768

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1761552
Blamelist: markt

BUILD FAILED: exception upload_2

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60152] Allow exceptions from Connector.start() to be caught and handled in code that embeds Tomcat

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60152

--- Comment #2 from Andy Wilkinson  ---
>  and it doesn't make sense

The current behaviour makes sense given that Tomcat swallows the exception;
otherwise, there'd be no way to see that a problem has occurred. If a change is
made such that Tomcat can be configured to throw the exception, then I would
argue that it no longer makes sense for Tomcat to also log the exception.

> please adjust the logging configuration to use some custom logger of your own 
> instead

That would only work if it's possible for a logger to distinguish between
exceptions that Tomcat is going to swallow and those that it's also going to
throw to be caught by embedding code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60152] Allow exceptions from Connector.start() to be caught and handled in code that embeds Tomcat

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60152

--- Comment #3 from Remy Maucherat  ---
Ok so basically Tomcat needs to remove all logging I suppose. Nice. I don't
think all the necessary information to produce the best logging is contained in
the exception, also.
Ex: How do I know if it's a bind exception or a SSL configuration error ? Your
solution: dump the exception to the user and he'll figure it out.
So -1, sorry, you'll have to figure things out at the logging layer, even if
you don't like it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1761560 - /tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 11:44:42 2016
New Revision: 1761560

URL: http://svn.apache.org/viewvc?rev=1761560&view=rev
Log:
Fix some IDE warnings

Modified:

tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java

Modified: 
tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java?rev=1761560&r1=1761559&r2=1761560&view=diff
==
--- 
tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
 Tue Sep 20 11:44:42 2016
@@ -186,6 +186,10 @@ public class StatementCache extends Stat
 }
 
 /**
+ * @param sql The SQL to attempt to match to entires in the statement cache
+ *
+ * @return The CachedStatement for the given SQL
+ *
  * @deprecated Unused. Will be removed in Tomcat 9
  */
 @Deprecated
@@ -307,7 +311,7 @@ public class StatementCache extends Stat
 }
 return key;
 }
-
+
 
 private static final class CacheKey {
 private final String stmtType;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



How could I get involved into tomcat development?

2016-09-20 Thread Tiramisu Ling
hello everyone,

I'm a newbie in tomcat and I would like to get involved into it. Could you
tell me where to start with it? How could I find something like 'good first
bug'? Thank you very much :)

Best Regards,
MikeLing


RE: How could I get involved into tomcat development?

2016-09-20 Thread The Burgh Demolition
unsubscribe

-Original Message-
From: Tiramisu Ling [mailto:saberge...@gmail.com] 
Sent: Tuesday, September 20, 2016 8:28 AM
To: dev@tomcat.apache.org
Subject: How could I get involved into tomcat development?

hello everyone,

I'm a newbie in tomcat and I would like to get involved into it. Could you tell 
me where to start with it? How could I find something like 'good first bug'? 
Thank you very much :)

Best Regards,
MikeLing


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: How could I get involved into tomcat development?

2016-09-20 Thread Tiramisu Ling
what?

2016-09-20 20:29 GMT+08:00 The Burgh Demolition <
contrac...@pittsdemolition.com>:

> unsubscribe
>
> -Original Message-
> From: Tiramisu Ling [mailto:saberge...@gmail.com]
> Sent: Tuesday, September 20, 2016 8:28 AM
> To: dev@tomcat.apache.org
> Subject: How could I get involved into tomcat development?
>
> hello everyone,
>
> I'm a newbie in tomcat and I would like to get involved into it. Could you
> tell me where to start with it? How could I find something like 'good first
> bug'? Thank you very much :)
>
> Best Regards,
> MikeLing
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: How could I get involved into tomcat development?

2016-09-20 Thread Mark Thomas
On 20/09/2016 13:29, The Burgh Demolition wrote:
> unsubscribe

Done.

Please note, instructions on how to unsubscribe are appended to the end
of every email from the list.

Mark


> -Original Message-
> From: Tiramisu Ling [mailto:saberge...@gmail.com] 
> Sent: Tuesday, September 20, 2016 8:28 AM
> To: dev@tomcat.apache.org
> Subject: How could I get involved into tomcat development?
> 
> hello everyone,
> 
> I'm a newbie in tomcat and I would like to get involved into it. Could you 
> tell me where to start with it? How could I find something like 'good first 
> bug'? Thank you very much :)
> 
> Best Regards,
> MikeLing
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: How could I get involved into tomcat development?

2016-09-20 Thread Mark Thomas
On 20/09/2016 13:28, Tiramisu Ling wrote:
> hello everyone,
> 
> I'm a newbie in tomcat and I would like to get involved into it. Could you
> tell me where to start with it? How could I find something like 'good first
> bug'? Thank you very much :)

A good bug to get started on is usually one that you care about and/or
are interested in so you are motivated to fix it.

Some possibilities:
https://bz.apache.org/bugzilla/show_bug.cgi?id=55969
I'd recommend starting with item 3, then 2 and finally 1.

https://bz.apache.org/bugzilla/show_bug.cgi?id=6008
Not sure how complex fixing this would be. Just having a clear
explanation of what is going on would be useful.

Other than that, take a look at the open bugs and pick one you think is
interesting. Even if you can't fix it, if you can put together a patch
that adds a test case that demonstrates it that would be a huge help.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60138] protocol TLSV1.2 causes exception text sslUtilBase.noneSupported

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60138

--- Comment #1 from Mark Thomas  ---
It looks like we are mixing up default and supported protocols. I'm working on
a fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Deploying Tomcat on Snappy Ubuntu Core

2016-09-20 Thread Michael Hall
Hi Coty,

Have you had an opportunity to try this yet? If you need help please let
me know, or you could find help on #snappy on Freenode or
https://gitter.im/ubuntu/snappy-playpen (a new slack-like service
connected to github)

Michael Hall
mhall...@gmail.com

On 09/15/2016 10:06 AM, Michael Hall wrote:
> Hi Coty,
> 
> To learn more about snaps in general and how to make them you can go to
> http://snapcraft.io/
> 
> The tl;dr is that they are self-contained application bundles, including
> dependencies, that are packed into a squashfs that is then loop-mounted
> when installed. This means that the application's own files are
> read-only and isolated from other apps and the system, which makes
> updating them safe and simple. For Tomcat this means it includes a JRE,
> OpenSSL, and anything else needed for Tomcat to run.
> 
> I have attached the files needed to build a Tomcat snap using the the
> Snapcraft tool (only available on Ubuntu currently), just run "snapcraft
> snap" in the same directory as these files. The snapcrafy.yaml will pull
> Tomcat 8.5.5 binary tarball as it's source, so no re-compiling is
> needed. The run.sh simply sets some environment variables to their
> proper snap-environment locations, copies the server.xml into
> CATALINE_BASE (if it's not there), and starts Tomcat.
> 
> Because the snapcraft.yaml declares this to be a daemon, it will create
> a systemd service file upon installation and start it automatically.
> Then you can copy a .war files into $CATALINA_BASE/webapps/ and Tomcat
> will pick it up. I tested with the sample.war from
> https://tomcat.apache.org/tomcat-8.0-doc/appdev/sample/ and it works
> with the servlet portion, but not the JSP (I suspect the JSP compilation
> is trying write to use a read-only space, but haven't dug too far into it).
> 
> If you don't run Ubuntu the easiest way to build the snap is in a VM or
> container that has Ubuntu 16.04, just install the snapcraft package from
> the archive. If you just want to try a pre-built binary, you can
> download mine from http://people.ubuntu.com/~mhall119/snaps/
> 
> You can install it on Ubuntu 16.04 or a derivative right away with "snap
> install $snapfile --force-dangerous". The --force-dangerous is required
> because the resulting snap won't be signed. On non-Ubuntu distros you
> can get snaps running by following the instructions on
> http://snapcraft.io/docs/core/install
> 
> 
> Michael Hall
> mhall...@ubuntu.com
> 
> On 09/14/2016 11:23 PM, Coty Sutherland wrote:
>> Hi Micheal,
>>
>> I hadn't heard of snaps (or used Ubuntu much) but the concept seems
>> interesting to me. Would you be able to send me links to what you have
>> so far so I can check it out? I have a few questions, but I'll reserve
>> those until I get a chance to review what you have.
>>
>> Thanks!
>>
>>
>> On Sep 14, 2016 3:51 PM, "Michael Hall" > > wrote:
>>
>> Hi everyone,
>>
>> Ubuntu has developed a new platform for deploying applications using
>> bundled packages called "snaps". These make it easier to deploy and
>> update on Ubuntu independently of it's release cycle (and on non-Ubuntu
>> distros too for that matter). I would like to make Tomcat available in
>> this format so it can be more easily used on lightweight cloud instances
>> or devices like the Raspberry Pi.
>>
>> I have a working example of Tomcat as a snap, and it works really well
>> with a separate read-only CATALINE_HOME and a writable, versioned
>> CATALINA_BASE that will allow for atomic updates and rollbacks without
>> breaking application data, and it's very easy to use.
>>
>> The next step is to contribute this to upstream, where it can be
>> improved (I've only scratched the surface of what can be done with it)
>> and integrated with the CI system so that snap package can be
>> automatically created and uploaded for testers and users. This is where
>> I need help from somebody on this list, so please let me know if you are
>> interested and I will provide you the packaging files (there are only 2)
>> and a working binary package if you want to give it a try.
>>
>> Thanks.
>>
>> --
>> Michael Hall
>> mhall...@ubuntu.com 
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> 
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>> 
>>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1761572 - /tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 13:19:33 2016
New Revision: 1761572

URL: http://svn.apache.org/viewvc?rev=1761572&view=rev
Log:
Rename to avoid name conflict with constant

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java?rev=1761572&r1=1761571&r2=1761572&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java Tue Sep 20 
13:19:33 2016
@@ -48,7 +48,7 @@ public class SSLHostConfig implements Se
 private static final StringManager sm = 
StringManager.getManager(SSLHostConfig.class);
 
 protected static final String DEFAULT_SSL_HOST_NAME = "_default_";
-protected static final Set SSL_PROTO_ALL = new HashSet<>();
+protected static final Set SSL_PROTO_ALL_SET = new HashSet<>();
 
 static {
 /* Default used if protocols is not configured, also
@@ -57,10 +57,10 @@ public class SSLHostConfig implements Se
value comes from

org.apache.tomcat.util.net.jsse.JSSESocketFactory.defaultServerProtocols
(JSSE) resp. org.apache.tomcat.jni.SSL.SSL_PROTOCOL_ALL (OpenSSL)*/
-SSL_PROTO_ALL.add(Constants.SSL_PROTO_SSLv2Hello);
-SSL_PROTO_ALL.add(Constants.SSL_PROTO_TLSv1);
-SSL_PROTO_ALL.add(Constants.SSL_PROTO_TLSv1_1);
-SSL_PROTO_ALL.add(Constants.SSL_PROTO_TLSv1_2);
+SSL_PROTO_ALL_SET.add(Constants.SSL_PROTO_SSLv2Hello);
+SSL_PROTO_ALL_SET.add(Constants.SSL_PROTO_TLSv1);
+SSL_PROTO_ALL_SET.add(Constants.SSL_PROTO_TLSv1_1);
+SSL_PROTO_ALL_SET.add(Constants.SSL_PROTO_TLSv1_2);
 }
 
 private Type configType = null;
@@ -394,14 +394,14 @@ public class SSLHostConfig implements Se
 if (trimmed.charAt(0) == '+') {
 trimmed = trimmed.substring(1).trim();
 if (trimmed.equalsIgnoreCase(Constants.SSL_PROTO_ALL)) {
-protocols.addAll(SSL_PROTO_ALL);
+protocols.addAll(SSL_PROTO_ALL_SET);
 } else {
 protocols.add(trimmed);
 }
 } else if (trimmed.charAt(0) == '-') {
 trimmed = trimmed.substring(1).trim();
 if (trimmed.equalsIgnoreCase(Constants.SSL_PROTO_ALL)) {
-protocols.removeAll(SSL_PROTO_ALL);
+protocols.removeAll(SSL_PROTO_ALL_SET);
 } else {
 protocols.remove(trimmed);
 }
@@ -414,7 +414,7 @@ public class SSLHostConfig implements Se
  trimmed, getHostName()));
 }
 if (trimmed.equalsIgnoreCase(Constants.SSL_PROTO_ALL)) {
-protocols.addAll(SSL_PROTO_ALL);
+protocols.addAll(SSL_PROTO_ALL_SET);
 } else {
 protocols.add(trimmed);
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in on tomcat-trunk

2016-09-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/1698

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1761572
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1761574 - in /tomcat/trunk: java/org/apache/tomcat/util/net/jsse/JSSEUtil.java java/org/apache/tomcat/util/net/jsse/LocalStrings.properties webapps/docs/changelog.xml

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 13:39:30 2016
New Revision: 1761574

URL: http://svn.apache.org/viewvc?rev=1761574&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60138
Fix the SSLHostConfig so that the protocols attribute is limited to the 
protocols supported by the current JSSE implementation rather than the default 
protocols used by the implementation.

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEUtil.java
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/LocalStrings.properties
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEUtil.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEUtil.java?rev=1761574&r1=1761573&r2=1761574&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEUtil.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEUtil.java Tue Sep 20 
13:39:30 2016
@@ -49,8 +49,6 @@ import javax.net.ssl.CertPathTrustManage
 import javax.net.ssl.KeyManager;
 import javax.net.ssl.KeyManagerFactory;
 import javax.net.ssl.ManagerFactoryParameters;
-import javax.net.ssl.SSLServerSocket;
-import javax.net.ssl.SSLServerSocketFactory;
 import javax.net.ssl.SSLSessionContext;
 import javax.net.ssl.TrustManager;
 import javax.net.ssl.TrustManagerFactory;
@@ -95,29 +93,22 @@ public class JSSEUtil extends SSLUtilBas
 throw new IllegalArgumentException(e);
 }
 
-// There is no standard way to determine the default protocols and
-// cipher suites so create a server socket to see what the defaults are
-SSLServerSocketFactory ssf = context.getServerSocketFactory();
-implementedProtocols = new HashSet<>();
-try (SSLServerSocket socket = (SSLServerSocket) 
ssf.createServerSocket()) {
-// Filter out all the SSL protocols (SSLv2 and SSLv3) from the
-// defaults since they are no longer considered secure but allow
-// SSLv2Hello
-for (String protocol : socket.getEnabledProtocols()) {
-String protocolUpper = protocol.toUpperCase(Locale.ENGLISH);
-if (!"SSLV2HELLO".equals(protocolUpper)) {
-if (protocolUpper.contains("SSL")) {
-log.debug(sm.getString("jsse.excludeDefaultProtocol", 
protocol));
-continue;
-}
+String[] implementedProtocolsArray = 
context.getSupportedSSLParameters().getProtocols();
+implementedProtocols = new HashSet<>(implementedProtocolsArray.length);
+
+// Filter out all the SSL protocols (SSLv2 and SSLv3) from the list of
+// implemented protocols since they are no longer considered secure but
+// allow SSLv2Hello. This has the effect of making it impossible to use
+// SSLv2 or SSLv3 without source code changes.
+for (String protocol : implementedProtocolsArray) {
+String protocolUpper = protocol.toUpperCase(Locale.ENGLISH);
+if (!"SSLV2HELLO".equals(protocolUpper)) {
+if (protocolUpper.contains("SSL")) {
+log.debug(sm.getString("jsse.excludeProtocol", protocol));
+continue;
 }
-implementedProtocols.add(protocol);
 }
-} catch (IOException e) {
-// This is very likely to be fatal but there is a slim chance that
-// the JSSE implementation just doesn't like creating unbound
-// sockets so allow the code to proceed.
-
+implementedProtocols.add(protocol);
 }
 
 if (implementedProtocols.size() == 0) {

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/LocalStrings.properties?rev=1761574&r1=1761573&r2=1761574&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/jsse/LocalStrings.properties 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/jsse/LocalStrings.properties 
Tue Sep 20 13:39:30 2016
@@ -19,7 +19,7 @@ jsse.invalidTrustManagerClassName=The tr
 jsse.requested_ciphers_not_supported=None of the ciphers specified are 
supported by the SSL engine : {0}
 jsse.enableable_ciphers=Specified SSL ciphers that are supported and 
enableable are : {0}
 jsse.unsupported_ciphers=Some specified SSL ciphers are not supported by the 
SSL engine : {0}
-jsse.excludeDefaultProtocol=The SSL protocol [{0}] which is enabled by default 
in this JRE was excluded from the defaults used by Tomcat
+jsse.excludeProtocol=The SSL protocol [{0}] which is supported in this JRE was 
excluded from the protocols available to Tomcat
 jsse.noDefaultCiphers=Unable to determine a default for ciphers f

Re: How could I get involved into tomcat development?

2016-09-20 Thread Tiramisu Ling
Hey Mark, thank you for your help :) Do you mean
https://bz.apache.org/bugzilla/show_bug.cgi?id=60008 above instead of bug
6008? Because it tells me bug id is unavailable for https://bz.apache.org/
bugzilla/show_bug.cgi?id=6008.

2016-09-20 21:06 GMT+08:00 Mark Thomas :

> On 20/09/2016 13:28, Tiramisu Ling wrote:
> > hello everyone,
> >
> > I'm a newbie in tomcat and I would like to get involved into it. Could
> you
> > tell me where to start with it? How could I find something like 'good
> first
> > bug'? Thank you very much :)
>
> A good bug to get started on is usually one that you care about and/or
> are interested in so you are motivated to fix it.
>
> Some possibilities:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=55969
> I'd recommend starting with item 3, then 2 and finally 1.
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=6008
> Not sure how complex fixing this would be. Just having a clear
> explanation of what is going on would be useful.
>
> Other than that, take a look at the open bugs and pick one you think is
> interesting. Even if you can't fix it, if you can put together a patch
> that adds a test case that demonstrates it that would be a huge help.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: How could I get involved into tomcat development?

2016-09-20 Thread Mark Thomas
On 20/09/2016 15:40, Tiramisu Ling wrote:
> Hey Mark, thank you for your help :) Do you mean
> https://bz.apache.org/bugzilla/show_bug.cgi?id=60008 above instead of bug
> 6008? Because it tells me bug id is unavailable for https://bz.apache.org/
> bugzilla/show_bug.cgi?id=6008.

Sorry, I meant
https://bz.apache.org/bugzilla/show_bug.cgi?id=60087

The last digit was lost in the copy/paste.

Mark


> 
> 2016-09-20 21:06 GMT+08:00 Mark Thomas :
> 
>> On 20/09/2016 13:28, Tiramisu Ling wrote:
>>> hello everyone,
>>>
>>> I'm a newbie in tomcat and I would like to get involved into it. Could
>> you
>>> tell me where to start with it? How could I find something like 'good
>> first
>>> bug'? Thank you very much :)
>>
>> A good bug to get started on is usually one that you care about and/or
>> are interested in so you are motivated to fix it.
>>
>> Some possibilities:
>> https://bz.apache.org/bugzilla/show_bug.cgi?id=55969
>> I'd recommend starting with item 3, then 2 and finally 1.
>>
>> https://bz.apache.org/bugzilla/show_bug.cgi?id=6008
>> Not sure how complex fixing this would be. Just having a clear
>> explanation of what is going on would be useful.
>>
>> Other than that, take a look at the open bugs and pick one you think is
>> interesting. Even if you can't fix it, if you can put together a patch
>> that adds a test case that demonstrates it that would be a huge help.
>>
>> Mark
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: How could I get involved into tomcat development?

2016-09-20 Thread Tiramisu Ling
How could I take it if I do interest in that bug and want to work on it? I see 
those bugs been assigned to mail list already.

> 在 2016年9月20日,下午11:22,Mark Thomas  写道:
> 
>> On 20/09/2016 15:40, Tiramisu Ling wrote:
>> Hey Mark, thank you for your help :) Do you mean
>> https://bz.apache.org/bugzilla/show_bug.cgi?id=60008 above instead of bug
>> 6008? Because it tells me bug id is unavailable for https://bz.apache.org/
>> bugzilla/show_bug.cgi?id=6008.
> 
> Sorry, I meant
> https://bz.apache.org/bugzilla/show_bug.cgi?id=60087
> 
> The last digit was lost in the copy/paste.
> 
> Mark
> 
> 
>> 
>> 2016-09-20 21:06 GMT+08:00 Mark Thomas :
>> 
 On 20/09/2016 13:28, Tiramisu Ling wrote:
 hello everyone,
 
 I'm a newbie in tomcat and I would like to get involved into it. Could
>>> you
 tell me where to start with it? How could I find something like 'good
>>> first
 bug'? Thank you very much :)
>>> 
>>> A good bug to get started on is usually one that you care about and/or
>>> are interested in so you are motivated to fix it.
>>> 
>>> Some possibilities:
>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=55969
>>> I'd recommend starting with item 3, then 2 and finally 1.
>>> 
>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=6008
>>> Not sure how complex fixing this would be. Just having a clear
>>> explanation of what is going on would be useful.
>>> 
>>> Other than that, take a look at the open bugs and pick one you think is
>>> interesting. Even if you can't fix it, if you can put together a patch
>>> that adds a test case that demonstrates it that would be a huge help.
>>> 
>>> Mark
>>> 
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60013] Non-ASCII characters in querystring get mangled after URL Rewrite using RewriteValve

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60013

Tiago Oliveira  changed:

   What|Removed |Added

 CC||tiago...@gmail.com

--- Comment #37 from Tiago Oliveira  ---
Created attachment 34281
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34281&action=edit
fix for failure case (QSA)

Mark,

this is a small fix for the test "failure case for QSA (attachment 34247)"
provided by Santhana Preethi (comment 35)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: How could I get involved into tomcat development?

2016-09-20 Thread Martin Grigorov
Hi,

On Tue, Sep 20, 2016 at 5:50 PM, Tiramisu Ling  wrote:

> How could I take it if I do interest in that bug and want to work on it? I
> see those bugs been assigned to mail list already.
>

You can add a comment that you are working on it.
If you have any questions about the functionality you can ask them here
(dev@) or at us...@tomcat.apache.org if the answer could be known by a
non-committer, e.g. related to configuration, deployment, etc.

If you plan to hang around for longer time I'd recommend to read
https://wiki.apache.org/tomcat/FAQ/Tomcat_User too.

Have fun!

Martin


>
> > 在 2016年9月20日,下午11:22,Mark Thomas  写道:
> >
> >> On 20/09/2016 15:40, Tiramisu Ling wrote:
> >> Hey Mark, thank you for your help :) Do you mean
> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=60008 above instead of
> bug
> >> 6008? Because it tells me bug id is unavailable for
> https://bz.apache.org/
> >> bugzilla/show_bug.cgi?id=6008.
> >
> > Sorry, I meant
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=60087
> >
> > The last digit was lost in the copy/paste.
> >
> > Mark
> >
> >
> >>
> >> 2016-09-20 21:06 GMT+08:00 Mark Thomas :
> >>
>  On 20/09/2016 13:28, Tiramisu Ling wrote:
>  hello everyone,
> 
>  I'm a newbie in tomcat and I would like to get involved into it. Could
> >>> you
>  tell me where to start with it? How could I find something like 'good
> >>> first
>  bug'? Thank you very much :)
> >>>
> >>> A good bug to get started on is usually one that you care about and/or
> >>> are interested in so you are motivated to fix it.
> >>>
> >>> Some possibilities:
> >>> https://bz.apache.org/bugzilla/show_bug.cgi?id=55969
> >>> I'd recommend starting with item 3, then 2 and finally 1.
> >>>
> >>> https://bz.apache.org/bugzilla/show_bug.cgi?id=6008
> >>> Not sure how complex fixing this would be. Just having a clear
> >>> explanation of what is going on would be useful.
> >>>
> >>> Other than that, take a look at the open bugs and pick one you think is
> >>> interesting. Even if you can't fix it, if you can put together a patch
> >>> that adds a test case that demonstrates it that would be a huge help.
> >>>
> >>> Mark
> >>>
> >>>
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >>> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[Bug 60138] protocol TLSV1.2 causes exception text sslUtilBase.noneSupported

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60138

--- Comment #2 from Paul Scott  ---
Great news. Thanks you! Looking forward to fix so we can move forward.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60152] Allow exceptions from Connector.start() to be caught and handled in code that embeds Tomcat

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60152

--- Comment #4 from Christopher Schultz  ---
(Calm down, Rémy.)

I think the proper way to handle this is for Tomcat to change the way the
exceptions are handled, here. Instead of introducing a new option (c.f.
failCtxIfServletStartFails), why not just move the exception-handling to one
layer higher than an embedded controller would see?

That way, standalone Tomcat can still catch and log the exceptions which is
appropriate, and embedded controllers can do whatever they like.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60152] Allow exceptions from Connector.start() to be caught and handled in code that embeds Tomcat

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60152

--- Comment #5 from Mark Thomas  ---
The complication - and I need to dig through the archives to find the details -
is that there was a requirement that Tomcat started even if a connector failed.

What we have here is two requirements for exactly opposite behavior. I suspect
configuration will have to be part of the solution but if someone can find a
way to do this without a new option, great.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Deploying Tomcat on Snappy Ubuntu Core

2016-09-20 Thread Martin Grigorov
Hi Michael,

On Tue, Sep 20, 2016 at 3:10 PM, Michael Hall  wrote:

> Hi Coty,
>
> Have you had an opportunity to try this yet? If you need help please let
> me know, or you could find help on #snappy on Freenode or
> https://gitter.im/ubuntu/snappy-playpen (a new slack-like service
> connected to github)
>

I am an Ubuntu user and I've tried once Snap.
I've installed the featured Notes application and I was amazed to see that
it downloaded 60Mb for such a simple application! After being unzipped it
is 196MB !!
Then I removed it.
I hope Canonical will keep .deb around for the near future!

About your package:
I see it uses "plugs: [network-bind]" to be able to bind the ports, but
does this also allow to make connections to external resources like a
remote DB for example ?


Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov



>
> Michael Hall
> mhall...@gmail.com
>
> On 09/15/2016 10:06 AM, Michael Hall wrote:
> > Hi Coty,
> >
> > To learn more about snaps in general and how to make them you can go to
> > http://snapcraft.io/
> >
> > The tl;dr is that they are self-contained application bundles, including
> > dependencies, that are packed into a squashfs that is then loop-mounted
> > when installed. This means that the application's own files are
> > read-only and isolated from other apps and the system, which makes
> > updating them safe and simple. For Tomcat this means it includes a JRE,
> > OpenSSL, and anything else needed for Tomcat to run.
> >
> > I have attached the files needed to build a Tomcat snap using the the
> > Snapcraft tool (only available on Ubuntu currently), just run "snapcraft
> > snap" in the same directory as these files. The snapcrafy.yaml will pull
> > Tomcat 8.5.5 binary tarball as it's source, so no re-compiling is
> > needed. The run.sh simply sets some environment variables to their
> > proper snap-environment locations, copies the server.xml into
> > CATALINE_BASE (if it's not there), and starts Tomcat.
> >
> > Because the snapcraft.yaml declares this to be a daemon, it will create
> > a systemd service file upon installation and start it automatically.
> > Then you can copy a .war files into $CATALINA_BASE/webapps/ and Tomcat
> > will pick it up. I tested with the sample.war from
> > https://tomcat.apache.org/tomcat-8.0-doc/appdev/sample/ and it works
> > with the servlet portion, but not the JSP (I suspect the JSP compilation
> > is trying write to use a read-only space, but haven't dug too far into
> it).
> >
> > If you don't run Ubuntu the easiest way to build the snap is in a VM or
> > container that has Ubuntu 16.04, just install the snapcraft package from
> > the archive. If you just want to try a pre-built binary, you can
> > download mine from http://people.ubuntu.com/~mhall119/snaps/
> >
> > You can install it on Ubuntu 16.04 or a derivative right away with "snap
> > install $snapfile --force-dangerous". The --force-dangerous is required
> > because the resulting snap won't be signed. On non-Ubuntu distros you
> > can get snaps running by following the instructions on
> > http://snapcraft.io/docs/core/install
> >
> >
> > Michael Hall
> > mhall...@ubuntu.com
> >
> > On 09/14/2016 11:23 PM, Coty Sutherland wrote:
> >> Hi Micheal,
> >>
> >> I hadn't heard of snaps (or used Ubuntu much) but the concept seems
> >> interesting to me. Would you be able to send me links to what you have
> >> so far so I can check it out? I have a few questions, but I'll reserve
> >> those until I get a chance to review what you have.
> >>
> >> Thanks!
> >>
> >>
> >> On Sep 14, 2016 3:51 PM, "Michael Hall"  >> > wrote:
> >>
> >> Hi everyone,
> >>
> >> Ubuntu has developed a new platform for deploying applications using
> >> bundled packages called "snaps". These make it easier to deploy and
> >> update on Ubuntu independently of it's release cycle (and on
> non-Ubuntu
> >> distros too for that matter). I would like to make Tomcat available
> in
> >> this format so it can be more easily used on lightweight cloud
> instances
> >> or devices like the Raspberry Pi.
> >>
> >> I have a working example of Tomcat as a snap, and it works really
> well
> >> with a separate read-only CATALINE_HOME and a writable, versioned
> >> CATALINA_BASE that will allow for atomic updates and rollbacks
> without
> >> breaking application data, and it's very easy to use.
> >>
> >> The next step is to contribute this to upstream, where it can be
> >> improved (I've only scratched the surface of what can be done with
> it)
> >> and integrated with the CI system so that snap package can be
> >> automatically created and uploaded for testers and users. This is
> where
> >> I need help from somebody on this list, so please let me know if
> you are
> >> interested and I will provide you the packaging files (there are
> only 2)
> >> and a working binary package if you want to give it a try.
> >>
>

svn commit: r1761616 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/SSLHostConfig.java

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 19:02:06 2016
New Revision: 1761616

URL: http://svn.apache.org/viewvc?rev=1761616&view=rev
Log:
Rename to avoid name conflict with constant

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 20 19:02:06 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759611,1760005,1760300,1760446,1760454,1760640,1760648,1761422,1761550,1761553
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,174

svn commit: r1761617 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/jsse/JSSEUtil.java java/org/apache/tomcat/util/net/jsse/LocalStrings.properties webapps/docs/changelog.xml

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 19:02:49 2016
New Revision: 1761617

URL: http://svn.apache.org/viewvc?rev=1761617&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60138
Fix the SSLHostConfig so that the protocols attribute is limited to the 
protocols supported by the current JSSE implementation rather than the default 
protocols used by the implementation.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/jsse/JSSEUtil.java

tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/jsse/LocalStrings.properties
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 20 19:02:49 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759611,1760005,1760300,1760446,1760454,1760640,1760648,1761422,1761550,1761553,1761572
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738

[Bug 60138] protocol TLSV1.2 causes exception text sslUtilBase.noneSupported

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60138

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #3 from Mark Thomas  ---
This has been fixed in the following branches:
- 9.0.x for 9.0.0.M11 onwards
- 8.5.x for 8.5.6 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Time for 6.0.x?

2016-09-20 Thread Mark Thomas
All,

It has been a while since 6.0.x and the changelog is looking a tad long.
Any takers for RM'ing a release?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60152] Allow exceptions from Connector.start() to be caught and handled in code that embeds Tomcat

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60152

--- Comment #6 from Christopher Schultz  ---
(In reply to Mark Thomas from comment #5)
> The complication - and I need to dig through the archives to find the
> details - is that there was a requirement that Tomcat started even if a
> connector failed.

I apologize as I'm ignorant of the code in question, but isn't Tomcat's
bootstrap process circumvented by an embedded controller? In that case, Tomcat
can just try/catch around the Connector.start() calls and log there, no?

> What we have here is two requirements for exactly opposite behavior. I
> suspect configuration will have to be part of the solution but if someone
> can find a way to do this without a new option, great.

It's ugly, but we could also have a callback-registration that would indicate
errors for certain components that failed to start. Post-start, the embedded
controller could take remunerative action.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Deploying Tomcat on Snappy Ubuntu Core

2016-09-20 Thread Michael Hall
Hi Martin,


On 09/20/2016 02:56 PM, Martin Grigorov wrote:
> Hi Michael,
> 
> On Tue, Sep 20, 2016 at 3:10 PM, Michael Hall  wrote:
> 
>> Hi Coty,
>>
>> Have you had an opportunity to try this yet? If you need help please let
>> me know, or you could find help on #snappy on Freenode or
>> https://gitter.im/ubuntu/snappy-playpen (a new slack-like service
>> connected to github)
>>
> 
> I am an Ubuntu user and I've tried once Snap.
> I've installed the featured Notes application and I was amazed to see that
> it downloaded 60Mb for such a simple application! After being unzipped it
> is 196MB !!
> Then I removed it.
> I hope Canonical will keep .deb around for the near future!
> 

.deb package aren't going away, snaps are just a new option that bring a
lot of benefit. Desktop apps like Notes are currently quite large
because they bundle the whole GUI toolkit that they use. This is
something that has a solution underway, but it won't affect services
like tomcat nearly as much,

The Tomcat snap does include a JRE though, so you always know that one
is available and that Tomcat will work with it. Even with that the
resulting snap is only 48MB. Snaps are never "unzipped", instead they
are loop-mounted into your filesystem, so the download size is the
installed size.

> About your package: 
> I see it uses "plugs: [network-bind]" to be able to bind the ports, but
> does this also allow to make connections to external resources like a
> remote DB for example ?
> 

I would have to double check. There is a "network" interface that allows
only out-bound connection, which can be added if "network-bind" doesn't
already do that.

> 
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
> 
> 
> 
>>
>> Michael Hall
>> mhall...@gmail.com
>>
>> On 09/15/2016 10:06 AM, Michael Hall wrote:
>>> Hi Coty,
>>>
>>> To learn more about snaps in general and how to make them you can go to
>>> http://snapcraft.io/
>>>
>>> The tl;dr is that they are self-contained application bundles, including
>>> dependencies, that are packed into a squashfs that is then loop-mounted
>>> when installed. This means that the application's own files are
>>> read-only and isolated from other apps and the system, which makes
>>> updating them safe and simple. For Tomcat this means it includes a JRE,
>>> OpenSSL, and anything else needed for Tomcat to run.
>>>
>>> I have attached the files needed to build a Tomcat snap using the the
>>> Snapcraft tool (only available on Ubuntu currently), just run "snapcraft
>>> snap" in the same directory as these files. The snapcrafy.yaml will pull
>>> Tomcat 8.5.5 binary tarball as it's source, so no re-compiling is
>>> needed. The run.sh simply sets some environment variables to their
>>> proper snap-environment locations, copies the server.xml into
>>> CATALINE_BASE (if it's not there), and starts Tomcat.
>>>
>>> Because the snapcraft.yaml declares this to be a daemon, it will create
>>> a systemd service file upon installation and start it automatically.
>>> Then you can copy a .war files into $CATALINA_BASE/webapps/ and Tomcat
>>> will pick it up. I tested with the sample.war from
>>> https://tomcat.apache.org/tomcat-8.0-doc/appdev/sample/ and it works
>>> with the servlet portion, but not the JSP (I suspect the JSP compilation
>>> is trying write to use a read-only space, but haven't dug too far into
>> it).
>>>
>>> If you don't run Ubuntu the easiest way to build the snap is in a VM or
>>> container that has Ubuntu 16.04, just install the snapcraft package from
>>> the archive. If you just want to try a pre-built binary, you can
>>> download mine from http://people.ubuntu.com/~mhall119/snaps/
>>>
>>> You can install it on Ubuntu 16.04 or a derivative right away with "snap
>>> install $snapfile --force-dangerous". The --force-dangerous is required
>>> because the resulting snap won't be signed. On non-Ubuntu distros you
>>> can get snaps running by following the instructions on
>>> http://snapcraft.io/docs/core/install
>>>
>>>
>>> Michael Hall
>>> mhall...@ubuntu.com
>>>
>>> On 09/14/2016 11:23 PM, Coty Sutherland wrote:
 Hi Micheal,

 I hadn't heard of snaps (or used Ubuntu much) but the concept seems
 interesting to me. Would you be able to send me links to what you have
 so far so I can check it out? I have a few questions, but I'll reserve
 those until I get a chance to review what you have.

 Thanks!


 On Sep 14, 2016 3:51 PM, "Michael Hall" >>> > wrote:

 Hi everyone,

 Ubuntu has developed a new platform for deploying applications using
 bundled packages called "snaps". These make it easier to deploy and
 update on Ubuntu independently of it's release cycle (and on
>> non-Ubuntu
 distros too for that matter). I would like to make Tomcat available
>> in
 this format so it can be more easily used on lightweight cloud
>> instances
 or devices lik

Re: Deploying Tomcat on Snappy Ubuntu Core

2016-09-20 Thread Christopher Schultz
Martin,

On 9/20/16 2:56 PM, Martin Grigorov wrote:
> Hi Michael,
> 
> On Tue, Sep 20, 2016 at 3:10 PM, Michael Hall  wrote:
> 
>> Hi Coty,
>>
>> Have you had an opportunity to try this yet? If you need help please let
>> me know, or you could find help on #snappy on Freenode or
>> https://gitter.im/ubuntu/snappy-playpen (a new slack-like service
>> connected to github)
>>
> 
> I am an Ubuntu user and I've tried once Snap.
> I've installed the featured Notes application and I was amazed to see that
> it downloaded 60Mb for such a simple application! After being unzipped it
> is 196MB !!
> Then I removed it.
> I hope Canonical will keep .deb around for the near future!

If Ubuntu scraps .deb, then it won't really be Debian at the core and
will lose a lot of its appeal. I don't think that's going to happen.

I completely understand the "fat app" model, here. Honestly, it's
*exactly* like the "fat web app" model that we usually recommend around
here. If you try to use the same shared dependencies for all
applications, things quickly become mired in dependency hell: upgrading
one component breaks one app while leaving it on an older version
prohibits another app from running properly.

Using fat apps where the only system-wide libraries being used are e.g.
glibc makes for a much "easier" experience for a lot of people. Don't
forget that Ubuntu is focused on the end-user and not the administrator
(even though they'd be perfectly happy to have Ubuntu running servers
everywhere, too). Users just want stuff to work.

Of course, bundling libraries with applications means that every time a
security fix comes out for a particular library, every app using that
lib needs an update. Boo. It's hard to strike a balance between these
two irritating situations. Perhaps that's why Ubuntu offers both
traditional .deb packages as well as Snaps.

> About your package:
> I see it uses "plugs: [network-bind]" to be able to bind the ports, but
> does this also allow to make connections to external resources like a
> remote DB for example ?

Web services, JMS queues, non-JDBC Data sources, etc.

Honestly, I have no idea why anyone would want to install Tomcat as a
"Snap"... it's a server daemon. Is there a Snap for httpd? MySQL? *shrug*

-chris



signature.asc
Description: OpenPGP digital signature


svn commit: r1761625 - in /tomcat/trunk: java/org/apache/catalina/valves/rewrite/RewriteValve.java test/org/apache/catalina/valves/rewrite/TestRewriteValve.java webapps/docs/changelog.xml

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 19:20:46 2016
New Revision: 1761625

URL: http://svn.apache.org/viewvc?rev=1761625&view=rev
Log:
Another fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=60013
Fix QSA handling when there is no query string

Modified:
tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteValve.java
tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteValve.java?rev=1761625&r1=1761624&r2=1761625&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteValve.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteValve.java Tue 
Sep 20 19:20:46 2016
@@ -532,7 +532,8 @@ public class RewriteValve extends ValveB
 chunk = 
request.getCoyoteRequest().queryString().getCharChunk();
 chunk.recycle();
 chunk.append(ENCODER.encode(queryStringDecoded, 
uriEncoding));
-if (qsa) {
+if (qsa && originalQueryStringEncoded != null &&
+originalQueryStringEncoded.length() > 0) {
 chunk.append('&');
 chunk.append(originalQueryStringEncoded);
 }

Modified: 
tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java?rev=1761625&r1=1761624&r2=1761625&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java 
Tue Sep 20 19:20:46 2016
@@ -409,6 +409,15 @@ public class TestRewriteValve extends To
 
 
 @Test
+public void testUtf8WithRewriteQsFlagsQSA() throws Exception {
+// Note %C2%A1 == \u00A1
+doTestRewrite("RewriteRule ^/b/(.*)/(.*) /c/\u00A1$1?$2 [QSA]",
+"/b/%C2%A1/id=%C2%A1", "/c/%C2%A1%C2%A1",
+"id=%C2%A1");
+}
+
+
+@Test
 public void testUtf8FlagsNone() throws Exception {
 // Note %C2%A1 == \u00A1
 doTestRewrite("RewriteRule ^/b/(.*) /c/\u00A1$1", "/b/%C2%A1", 
"/c/%C2%A1%C2%A1");

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1761625&r1=1761624&r2=1761625&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Sep 20 19:20:46 2016
@@ -57,7 +57,7 @@
 the Rewrite Valve with mod_rewite. As part of this, provide an
 implementation for the B and NE flags and
 improve the handling for the QSA flag. Includes multiple
-test cases by Santhana Preethi. (markt)
+test cases by Santhana Preethiand a patch by Tiago Oliveira. (markt)
   
   
 60116: Fix a problem with the rewrite valve that caused back



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1761626 - /tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 19:21:18 2016
New Revision: 1761626

URL: http://svn.apache.org/viewvc?rev=1761626&view=rev
Log:
Fix typo.
Patch by  Tiago Oliveira.

Modified:
tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java

Modified: 
tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java?rev=1761626&r1=1761625&r2=1761626&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java 
Tue Sep 20 19:21:18 2016
@@ -529,8 +529,8 @@ public class TestRewriteValve extends To
 }
 
 if (expectedAttributeValue != null) {
-String attrbuteValue = requestDesc.getAttribute("X-Test");
-Assert.assertEquals(expectedAttributeValue, attrbuteValue);
+String attributeValue = requestDesc.getAttribute("X-Test");
+Assert.assertEquals(expectedAttributeValue, attributeValue);
 }
 }
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60013] Non-ASCII characters in querystring get mangled after URL Rewrite using RewriteValve

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60013

--- Comment #38 from Mark Thomas  ---
Comment on attachment 34281
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34281
fix for failure case (QSA)

Thanks variation of the patch applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Deploying Tomcat on Snappy Ubuntu Core

2016-09-20 Thread Martin Grigorov
Hi Michael,

On Tue, Sep 20, 2016 at 9:11 PM, Michael Hall  wrote:

> Hi Martin,
>
>
> On 09/20/2016 02:56 PM, Martin Grigorov wrote:
> > Hi Michael,
> >
> > On Tue, Sep 20, 2016 at 3:10 PM, Michael Hall 
> wrote:
> >
> >> Hi Coty,
> >>
> >> Have you had an opportunity to try this yet? If you need help please let
> >> me know, or you could find help on #snappy on Freenode or
> >> https://gitter.im/ubuntu/snappy-playpen (a new slack-like service
> >> connected to github)
> >>
> >
> > I am an Ubuntu user and I've tried once Snap.
> > I've installed the featured Notes application and I was amazed to see
> that
> > it downloaded 60Mb for such a simple application! After being unzipped it
> > is 196MB !!
> > Then I removed it.
> > I hope Canonical will keep .deb around for the near future!
> >
>
> .deb package aren't going away, snaps are just a new option that bring a
>

Yes, I know that .deb isn't going away.
I just said it to express my frustration with those 196MB.


> lot of benefit. Desktop apps like Notes are currently quite large
> because they bundle the whole GUI toolkit that they use. This is
> something that has a solution underway, but it won't affect services
> like tomcat nearly as much,
>
> The Tomcat snap does include a JRE though, so you always know that one
> is available and that Tomcat will work with it. Even with that the
>

What if I need different combination of Tomcat and JRE versions than what
your Snap versions provide ?
Let's say I experience some bug in the bundled JRE version (e.g. X) and
your next Snap version bundles JRE X+1 but also Tomcat Y+1.
What if I need JRE X+1 and Tomcat Y because there is a regression in Y+1 ?
Just thinking loud here.


> resulting snap is only 48MB. Snaps are never "unzipped", instead they
> are loop-mounted into your filesystem, so the download size is the
>

I haven't read about squashfs, so I'm not sure how exactly it works.
196MB is what "du" program reports.
If it is not disk size then I hope this 60MB download is not unzipped in
the RAM.
http://snapcraft.io/ says "That directory will be compressed into a
squashfs - a zipped directory - and then it will be mounted at
/snap//current when the snap is installed."


> installed size.
>
> > About your package:
> > I see it uses "plugs: [network-bind]" to be able to bind the ports, but
> > does this also allow to make connections to external resources like a
> > remote DB for example ?
> >
>
> I would have to double check. There is a "network" interface that allows
> only out-bound connection, which can be added if "network-bind" doesn't
> already do that.
>

Thanks!


>
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> >
> >
> >>
> >> Michael Hall
> >> mhall...@gmail.com
> >>
> >> On 09/15/2016 10:06 AM, Michael Hall wrote:
> >>> Hi Coty,
> >>>
> >>> To learn more about snaps in general and how to make them you can go to
> >>> http://snapcraft.io/
> >>>
> >>> The tl;dr is that they are self-contained application bundles,
> including
> >>> dependencies, that are packed into a squashfs that is then loop-mounted
> >>> when installed. This means that the application's own files are
> >>> read-only and isolated from other apps and the system, which makes
> >>> updating them safe and simple. For Tomcat this means it includes a JRE,
> >>> OpenSSL, and anything else needed for Tomcat to run.
> >>>
> >>> I have attached the files needed to build a Tomcat snap using the the
> >>> Snapcraft tool (only available on Ubuntu currently), just run
> "snapcraft
> >>> snap" in the same directory as these files. The snapcrafy.yaml will
> pull
> >>> Tomcat 8.5.5 binary tarball as it's source, so no re-compiling is
> >>> needed. The run.sh simply sets some environment variables to their
> >>> proper snap-environment locations, copies the server.xml into
> >>> CATALINE_BASE (if it's not there), and starts Tomcat.
> >>>
> >>> Because the snapcraft.yaml declares this to be a daemon, it will create
> >>> a systemd service file upon installation and start it automatically.
> >>> Then you can copy a .war files into $CATALINA_BASE/webapps/ and Tomcat
> >>> will pick it up. I tested with the sample.war from
> >>> https://tomcat.apache.org/tomcat-8.0-doc/appdev/sample/ and it works
> >>> with the servlet portion, but not the JSP (I suspect the JSP
> compilation
> >>> is trying write to use a read-only space, but haven't dug too far into
> >> it).
> >>>
> >>> If you don't run Ubuntu the easiest way to build the snap is in a VM or
> >>> container that has Ubuntu 16.04, just install the snapcraft package
> from
> >>> the archive. If you just want to try a pre-built binary, you can
> >>> download mine from http://people.ubuntu.com/~mhall119/snaps/
> >>>
> >>> You can install it on Ubuntu 16.04 or a derivative right away with
> "snap
> >>> install $snapfile --force-dangerous". The --force-dangerous is required
> >>> because the resulting snap won't be signed. On non-Ubuntu distros you
> >>

[Bug 60123] Tomcat JMX requestProcessingTime sometimes reports a request processor with decades of runtime (since 1-1-1970)

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60123

Mark Thomas  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Mark Thomas  ---
I can see a few ways this can happen. I'll look at making that code more
robust.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1761628 - in /tomcat/trunk: java/org/apache/coyote/RequestInfo.java webapps/docs/changelog.xml

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 19:37:45 2016
New Revision: 1761628

URL: http://svn.apache.org/viewvc?rev=1761628&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60123
Avoid potential threading issues that could cause excessively large vales to be 
returned for the processing time of a current request.

Modified:
tomcat/trunk/java/org/apache/coyote/RequestInfo.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/coyote/RequestInfo.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/RequestInfo.java?rev=1761628&r1=1761627&r2=1761628&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/RequestInfo.java (original)
+++ tomcat/trunk/java/org/apache/coyote/RequestInfo.java Tue Sep 20 19:37:45 
2016
@@ -123,8 +123,14 @@ public class RequestInfo  {
 }
 
 public long getRequestProcessingTime() {
-if ( getStage() == org.apache.coyote.Constants.STAGE_ENDED ) return 0;
-else return (System.currentTimeMillis() - req.getStartTime());
+// Not perfect, but good enough to avoid returning strange values due 
to
+// concurrent updates.
+long startTime = req.getStartTime();
+if (getStage() == org.apache.coyote.Constants.STAGE_ENDED || startTime 
< 0) {
+return 0;
+} else {
+return System.currentTimeMillis() - startTime;
+}
 }
 
 //  Statistical data  

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1761628&r1=1761627&r2=1761628&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Sep 20 19:37:45 2016
@@ -102,6 +102,11 @@
 Fail earlier if the client closes the connection during SNI processing.
 (markt)
   
+  
+60123: Avoid potential threading issues that could cause
+excessively large vales to be returned for the processing time of
+a current request. (markt)  
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1761629 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/RequestInfo.java webapps/docs/changelog.xml

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 19:38:22 2016
New Revision: 1761629

URL: http://svn.apache.org/viewvc?rev=1761629&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60123
Avoid potential threading issues that could cause excessively large vales to be 
returned for the processing time of a current request.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/coyote/RequestInfo.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 20 19:38:22 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759611,1760005,1760300,1760446,1760454,1760640,1760648,1761422,1761550,1761553,1761572,1761574
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,17397

svn commit: r1761630 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/RequestInfo.java webapps/docs/changelog.xml

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 19:38:51 2016
New Revision: 1761630

URL: http://svn.apache.org/viewvc?rev=1761630&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60123
Avoid potential threading issues that could cause excessively large vales to be 
returned for the processing time of a current request.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/coyote/RequestInfo.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 20 19:38:51 2016
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 
7,1684549-1684550,1685556,1685591,1685739,1685744,1685772,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1687544,1687551,1688563,1688841,1688878,165,1688896,1688901,1689345-1689346,16893

svn commit: r1761631 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/RequestInfo.java webapps/docs/changelog.xml

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 19:40:47 2016
New Revision: 1761631

URL: http://svn.apache.org/viewvc?rev=1761631&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60123
Avoid potential threading issues that could cause excessively large vales to be 
returned for the processing time of a current request.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/coyote/RequestInfo.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 20 19:40:47 2016
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565
-/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804,1740811,1740981,1741165,1741174,1741182,1741191,1741203,1741209,1741226,1741233,1741410,1742277,1743118,1743126,1743139-1743140,1743718,1743722,1743724,1744059,1744127,1744151,1744232,1744377,1744687,1744698,1744706,1745228,1746940,1748548,1748716,1749288,1749375,1749668-1749669,1750016,1750057,1750976,1751000,1751062,1751098,1754112,1754144,1754282,1754312,1754614,1754726,1754806,1754878,1754889,1754894,1754900,1754945,1754954,1754958,1755891,1755944,1756040,1756412,1756940,

svn commit: r1761632 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/coyote/RequestInfo.java webapps/docs/changelog.xml

2016-09-20 Thread markt
Author: markt
Date: Tue Sep 20 19:41:56 2016
New Revision: 1761632

URL: http://svn.apache.org/viewvc?rev=1761632&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60123
Avoid potential threading issues that could cause excessively large vales to be 
returned for the processing time of a current request.

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/java/org/apache/coyote/RequestInfo.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 20 19:41:56 2016
@@ -1,4 +1,4 @@
-/tomcat/tc7.0.x/trunk:1190476,1224802,1243045,1298635,1304471,1311997,1312007,1331772,1333164,1333176,1348992,1354866,1371298,1371302,1371620,1402110,1409014,1413553,1413557,1413563,1430083,1438415,1446641-1446660,1447013,1453106,1453119,1484919,1486877,1500065,1503852,1505844,1513151,1521040,1526470,1536524,1539176-1539177,1544469,1544473,1552805,1558894,1558917,1561368,1561382,1561386,1561552,1561561,1561636,1561641,1561643,1561737,1562748,1564317,1568922,1570163,1577328,1577464-1577465,1578814,1586659,1586897,1586960,1588199,1588997,1589740,1589851,1589997,1590019,1590028,1590337,1590492,1590651,1590838,1590845,1590848,1590912,1593262,1593288,1593371,1593835,1594230,1595174,1595366,1600956,1601333,1601856,1601909,1609079,1609606,1617364,1617374,1617433,1617457-1617458,1624249,1626579,1627420,1627469,1632586,1637686,1637711,1640675,1642045,1643515,1643540,1643572,1643585-1643586,1643642,1643647,1644019,1648817,1656301,1658815,1659523,1659564,1664001,1664176,1665087,1666968,1666989
 
,1668541,1668635,1669802,1676557,1681183,1681841,1681865,1681867,1685829,1693109,1694293,1694433,1694875,1696381,1701945,1710353,1712656,1713873,1714000,1714005,1714540,1715213,1716221,1716417,1717107,1717210,1717212,1720236,1720398,1720443,1720464,1721814,1721883,1722645,1722801,1723151,1724435,1724553,1724675,1724797,1724806,1725931,1726631,1726808,1726813,1726815,1726817,1726819,1726917,1726919,1726922-1726924,1727031,1727034,1727043,1727158,1727672,1727903,1728450,1729363,1731010,1731119,1731956,1731978,1732362,1732674-1732675,1733942,1734116,1734134,1734532,1737249,1737253,1737968,1738049,1738186,1739778,1741178,1741184,1741193,1741211,1741218,1741228,1741235,1742281,1743121,1743142,1743649,1744061,1744129,1744155,1744241,1744383,1744689,1745230,1746942,1746994,1749377,1750018,1750980,1751066,1754114,1754147,1754728,1754880,1754891,1754898,1754902,1756030,1756417,1756420,1756423,1756942,1757275,1757284,1757503,1758490,1758495
+/tomcat/tc7.0.x/trunk:1190476,1224802,1243045,1298635,1304471,1311997,1312007,1331772,1333164,1333176,1348992,1354866,1371298,1371302,1371620,1402110,1409014,1413553,1413557,1413563,1430083,1438415,1446641-1446660,1447013,1453106,1453119,1484919,1486877,1500065,1503852,1505844,1513151,1521040,1526470,1536524,1539176-1539177,1544469,1544473,1552805,1558894,1558917,1561368,1561382,1561386,1561552,1561561,1561636,1561641,1561643,1561737,1562748,1564317,1568922,1570163,1577328,1577464-1577465,1578814,1586659,1586897,1586960,1588199,1588997,1589740,1589851,1589997,1590019,1590028,1590337,1590492,1590651,1590838,1590845,1590848,1590912,1593262,1593288,1593371,1593835,1594230,1595174,1595366,1600956,1601333,1601856,1601909,1609079,1609606,1617364,1617374,1617433,1617457-1617458,1624249,1626579,1627420,1627469,1632586,1637686,1637711,1640675,1642045,1643515,1643540,1643572,1643585-1643586,1643642,1643647,1644019,1648817,1656301,1658815,1659523,1659564,1664001,1664176,1665087,1666968,1666989
 
,1668541,1668635,1669802,1676557,1681183,1681841,1681865,1681867,1685829,1693109,1694293,1694433,1694875,1696381,1701945,1710353,1712656,1713873,1714000,1714005,1714540,1715213,1716221,1716417,1717107,1717210,1717212,1720236,1720398,1720443,1720464,1721814,1721883,1722645,1722801,1723151,1724435,1724553,1724675,1724797,1724806,1725931,1726631,1726808,1726813,1726815,1726817,1726819,1726917,1726919,1726922-1726924,1727031,1727034,1727043,1727158,1727672,1727903,1728450,1729363,1731010,1731119,1731956,1731978,1732362,1732674-1732675,1733942,1734116,1734134,1734532,1737249,1737253,1737968,1738049,1738186,1739778,1741178,1741184,1741193,1741211,1741218,1741228,1741235,1742281,1743121,1743142,1743649,1744061,1744129,1744155,1744241,1744383,1744689,1745230,1746942,1746994,1749377,1750018,1750980,1751066,1754114,1754147,1754728,1754880,1754891,1754898,1754902,1756030,1756417,1756420,1756423,1756942,1757275,1757284,1757503,1758490,1758495,1761631
 
/tomcat/tc8.0.x/trunk:1637685,1637709,1640674,1641726,1641729-1641730,1643513,1643539,1643571,1643581-1643582,1644018,1648816,1656300,1658801-1658803,1658811,1659522,1663997,1664175,1665086,1666967,1666988,1668634,1669801,1676556,1681182,1681840,1681864,1685827,1689921,1693108,1694291,1694427,1694873,1696379,1701944,1710347,1712618,1712655,1713872,1713998,1714004,1714538,1715207,1715866,1716216-1716

[Bug 60123] Tomcat JMX requestProcessingTime sometimes reports a request processor with decades of runtime (since 1-1-1970)

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60123

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #2 from Mark Thomas  ---
This has been fixed in the following branches:
- 9.0.x for 9.0.0.M11 onwards
- 8.5.x for 8.5.6 onwards
- 8.0.x for 8.0.38 onwards
- 7.0.x for 7.0.73 onwards
- 6.0.x for 6.0.46 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in on tomcat-8-trunk

2016-09-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/769

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1761630
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59897] Buffer Overflow in FD_SET in nb_connect (jk_connect.c) leading to apache2 crash

2016-09-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59897

Max L  changed:

   What|Removed |Added

 CC||audiot...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Deploying Tomcat on Snappy Ubuntu Core

2016-09-20 Thread Christopher Schultz
Martin,

On 9/20/16 3:28 PM, Martin Grigorov wrote:
> Hi Michael,
> 
> On Tue, Sep 20, 2016 at 9:11 PM, Michael Hall  wrote:
> 
>> Hi Martin,
>>
>>
>> On 09/20/2016 02:56 PM, Martin Grigorov wrote:
>>> Hi Michael,
>>>
>>> On Tue, Sep 20, 2016 at 3:10 PM, Michael Hall 
>> wrote:
>>>
 Hi Coty,

 Have you had an opportunity to try this yet? If you need help please let
 me know, or you could find help on #snappy on Freenode or
 https://gitter.im/ubuntu/snappy-playpen (a new slack-like service
 connected to github)

>>>
>>> I am an Ubuntu user and I've tried once Snap.
>>> I've installed the featured Notes application and I was amazed to see
>> that
>>> it downloaded 60Mb for such a simple application! After being unzipped it
>>> is 196MB !!
>>> Then I removed it.
>>> I hope Canonical will keep .deb around for the near future!
>>>
>>
>> .deb package aren't going away, snaps are just a new option that bring a
>>
> 
> Yes, I know that .deb isn't going away.
> I just said it to express my frustration with those 196MB.
> 
> 
>> lot of benefit. Desktop apps like Notes are currently quite large
>> because they bundle the whole GUI toolkit that they use. This is
>> something that has a solution underway, but it won't affect services
>> like tomcat nearly as much,
>>
>> The Tomcat snap does include a JRE though, so you always know that one
>> is available and that Tomcat will work with it. Even with that the
>>
> 
> What if I need different combination of Tomcat and JRE versions than what
> your Snap versions provide ?
> Let's say I experience some bug in the bundled JRE version (e.g. X) and
> your next Snap version bundles JRE X+1 but also Tomcat Y+1.
> What if I need JRE X+1 and Tomcat Y because there is a regression in Y+1 ?
> Just thinking loud here.
> 
> 
>> resulting snap is only 48MB. Snaps are never "unzipped", instead they
>> are loop-mounted into your filesystem, so the download size is the
>>
> 
> I haven't read about squashfs, so I'm not sure how exactly it works.
> 196MB is what "du" program reports.
> If it is not disk size then I hope this 60MB download is not unzipped in
> the RAM.
> http://snapcraft.io/ says "That directory will be compressed into a
> squashfs - a zipped directory - and then it will be mounted at
> /snap//current when the snap is installed."

It's like an executable JAR file, except that the kernel loads the thing
as a filesystem. So 'du' will tell you it's bigger than it actually is
(it's bigger on the inside than it is on the outside).

That 60MiB download isn't being uncompressed elsewhere on the disk or
into RAM. It's being decompressed on the fly as necessary, just like a
remotely-mounted filesystem isn't copied locally whenever you access
files. Sore, a file or two might have some parts cached locally, but you
aren't sucking-down your entire multi-petabyte SAN contents when you
login to your corporate network.

-chris



signature.asc
Description: OpenPGP digital signature


Re: Deploying Tomcat on Snappy Ubuntu Core

2016-09-20 Thread Martin Grigorov
Hi Chris,

On Tue, Sep 20, 2016 at 10:51 PM, Christopher Schultz <
ch...@christopherschultz.net> wrote:

> Martin,
>
> On 9/20/16 3:28 PM, Martin Grigorov wrote:
> > Hi Michael,
> >
> > On Tue, Sep 20, 2016 at 9:11 PM, Michael Hall 
> wrote:
> >
> >> Hi Martin,
> >>
> >>
> >> On 09/20/2016 02:56 PM, Martin Grigorov wrote:
> >>> Hi Michael,
> >>>
> >>> On Tue, Sep 20, 2016 at 3:10 PM, Michael Hall 
> >> wrote:
> >>>
>  Hi Coty,
> 
>  Have you had an opportunity to try this yet? If you need help please
> let
>  me know, or you could find help on #snappy on Freenode or
>  https://gitter.im/ubuntu/snappy-playpen (a new slack-like service
>  connected to github)
> 
> >>>
> >>> I am an Ubuntu user and I've tried once Snap.
> >>> I've installed the featured Notes application and I was amazed to see
> >> that
> >>> it downloaded 60Mb for such a simple application! After being unzipped
> it
> >>> is 196MB !!
> >>> Then I removed it.
> >>> I hope Canonical will keep .deb around for the near future!
> >>>
> >>
> >> .deb package aren't going away, snaps are just a new option that bring a
> >>
> >
> > Yes, I know that .deb isn't going away.
> > I just said it to express my frustration with those 196MB.
> >
> >
> >> lot of benefit. Desktop apps like Notes are currently quite large
> >> because they bundle the whole GUI toolkit that they use. This is
> >> something that has a solution underway, but it won't affect services
> >> like tomcat nearly as much,
> >>
> >> The Tomcat snap does include a JRE though, so you always know that one
> >> is available and that Tomcat will work with it. Even with that the
> >>
> >
> > What if I need different combination of Tomcat and JRE versions than what
> > your Snap versions provide ?
> > Let's say I experience some bug in the bundled JRE version (e.g. X) and
> > your next Snap version bundles JRE X+1 but also Tomcat Y+1.
> > What if I need JRE X+1 and Tomcat Y because there is a regression in Y+1
> ?
> > Just thinking loud here.
> >
> >
> >> resulting snap is only 48MB. Snaps are never "unzipped", instead they
> >> are loop-mounted into your filesystem, so the download size is the
> >>
> >
> > I haven't read about squashfs, so I'm not sure how exactly it works.
> > 196MB is what "du" program reports.
> > If it is not disk size then I hope this 60MB download is not unzipped in
> > the RAM.
> > http://snapcraft.io/ says "That directory will be compressed into a
> > squashfs - a zipped directory - and then it will be mounted at
> > /snap//current when the snap is installed."
>
> It's like an executable JAR file, except that the kernel loads the thing
> as a filesystem. So 'du' will tell you it's bigger than it actually is
> (it's bigger on the inside than it is on the outside).


> That 60MiB download isn't being uncompressed elsewhere on the disk or
> into RAM. It's being decompressed on the fly as necessary, just like a
> remotely-mounted filesystem isn't copied locally whenever you access
> files. Sore, a file or two might have some parts cached locally, but you
> aren't sucking-down your entire multi-petabyte SAN contents when you
> login to your corporate network.
>

Thanks for the explanation!
But I think the example with reading data from SAN is not exactly the same
as executing a process in the kernel.
To start the process the kernel needs to load (big?!) part of the zipped
bundle. Everything else might be loaded if needed later.

1) Dealing with compressed data is definitely slower than dealing with
uncompressed data, and this is valid both for startup time and runtime.
2) Snaps share nothing, by design. So if more than one app needs the same
dependency then it is not just about the disk space but also duplicated
stuff in memory. This is advertized as Pros but for me is Cons.
3) I cannot find any information about a running Notes app (I've installed
it again for the testing!) neither with 'ps', nor with 'htop', nor with
'snap'. All I can find is a parent 'snapd' process with several forks. If I
need to install a spy software I'll pack it as a Snap :-)

So far I see more drawbacks than benefits. But I am a developer with a
desktop. I guess the points above might not be a problem for server
administrators.


>
> -chris
>
>


[GUMP@vmgump]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2016-09-20 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-validate has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-validate :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-validate.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 48 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20160921.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.5-SNAPSHOT.jar
 
:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20160921.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20160921.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-20.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-8.0.x/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-8.0.x/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-8.0.x/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar

setproxy:

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-8.0.x/output/res/checkstyle
[checkstyle] Running Checkstyle 7.2-SNAPSHOT on 3011 files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-8.0.x/webapps/docs/changelog.xml:95: Line 
matches the illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-8.0.x/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java:310:
 Line matches the illegal pattern '\s+$'. [RegexpSingleline]

BUILD FAILED
/srv/gump/public/workspace/tomcat-8.0.x/build.xml:545: Got 2 errors and 0 
warnings.

Total time: 47 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2016092109, vmgump.apache.org:vmgump:2016092109
Gump E-mail Identifier (unique within run) #5.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2016-09-20 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 47 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20160921.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.5-SNAPSHOT.jar
 
:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20160921.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20160921.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-20.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar

setproxy:

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
[checkstyle] Running Checkstyle 7.2-SNAPSHOT on 3085 files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/changelog.xml:77: Line 
matches the illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/changelog.xml:108: Line 
matches the illegal pattern '\s+$'. [RegexpSingleline]

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:534: Got 2 errors and 0 
warnings.

Total time: 46 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2016092109, vmgump.apache.org:vmgump:2016092109
Gump E-mail Identifier (unique within run) #6.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2016-09-20 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 30 mins 58 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.5-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160921-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160921.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160921-native-src.
 tar.gz -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true 
-Dexecute.test.nio=true 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20160921/bin/openssl
 -Dexecute.test.apr=false -Dtest.excludePerformance=true 
-Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/g