Re: [VOTE] Release Apache Tomcat 9.0.0.M8
2016-06-07 18:02 GMT+02:00 Mark Thomas : > The proposed 9.0.0.M8 release is: > [ ] Broken - do not release > [X] Alpha - go ahead and release as 9.0.0.M8 > > No testing issues for me. Rémy
Re: Using modern development tools for friendlier environment for newcomers
Hi, On Tue, Jun 7, 2016 at 11:33 AM, Mark Thomas wrote: > On 07/06/2016 10:17, Martin Grigorov wrote: > > Hi devs, > > > > Recently a colleague of mine asked me what it takes to become an Apache > > committer. > > I've explained him that he has to choose a project that is interesting to > > him and start participating in the mailing lists (helping others at > users@, > > giving opinion and testing releases at dev@), providing patches for open > > issues, etc. > > Few days later he came back with the following questions: > > > > 1) Why Tomcat still uses SVN? > > I've told him that this is the SCM tool most of the committers have > > experience with and there were some discussions to move to Git several > > months back. > > I've recommended him to use GitHub's Pull Requests for the time being - > PRs > > are monitored and merged if approved. Even if Tomcat was using Git, > Apache > > Infra doesn't provide tool with Pull Request support (GitLab, Gerrit, or > > similar) anyway so there is no big difference from a contributor point of > > view. > > If I recall correctly, the consensus last time around was that there was > merit in exploring the options for using git further with a view to > migrating if the majority were convinced there was a benefit to the move. > > There is an outstanding task (I need to chase it up) for the infra team > to look at if we could move to a single git repo for multiple branches > or would need multiple repos. > One repo should be possible. Even if there are some problems with the initial conversion from SVN to Git the person dealing with it could create N Git repos and then with the help of "git remote add" combine them into one with N branches and finally push those branches into a single repository. > > > 2) Why Tomcat uses Bugzilla? > > It is archaic and its UI is unfriendly - he said. > > To be honest I didn't have a good answer here. I also don't like > Bugzilla. > > Everybody knows how to use JIRA! It is hard to explain that Apache JIRA > > runs on Tomcat, but Tomcat project itself uses Perl software for issue > > tracking (no matter how good Bugzilla is). > > My personal view is Jira is overly complex and horribly slow. Bugzilla > I think JIRA is slower because the majority of the projects are there. But I guess it would be an overkill for Infra to maintain several instances of JIRA (e.g. sharded by project name). > just works. We don't need any of the extra features Jira offers. Do we > want any of them? None come to mind. Others may have a different view. > I personally like the JIRA plugins that integrate with the SCM tools. Committing with "PROJECT_NAME-1234" in the commit message automatically adds a comment to the respective ticket with a link to Git/SVN repo. It is very easy to explore the history of a ticket. Also it has a proper "Fix version" field. With it it is much easier to create a changelog. No need to maintain one manually. > > > I know that SVN, Git, JIRA, Bugzilla are just tools. We can do our work > > with any of them. > > Maybe there are more (and more important!) reasons why my colleague > didn't > > start contributing to Tomcat yet but I also agree with him that by moving > > to more modern tools Tomcat will become easier and friendlier for > newcomers. > > The Tomcat community tends to change development technology when it can > see some direct benefit from the change. It doesn't change just to use > the latest shiny new toy. > I totally agree with "see some benefit"! I don't agree with "new" :-) Both Git and JIRA are on the market for quite some time. > > git does have some benefits but also some potential complications. My > view is we are around the tipping point for svn -> git. > > Mark > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 9.0.0.M8
Hi, 2016-06-07 19:02 GMT+03:00 Mark Thomas : > > The proposed Apache Tomcat 9.0.0.M8 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 > > The major changes compared to the 9.0.0.M6 release are: > - Improvements to memory leak detection and prevention including the > change RMI memory leaks are now correctly treated as application bugs > rather than a JRE bug > - Fix a couple of memory leaks found in Tomcat > - The HTTP Server header is no longer set by default > > For full details, see the changelog: > http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M8/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1085/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M8/ > > The proposed 9.0.0.M8 release is: > [ ] Broken - do not release > [X] Alpha - go ahead and release as 9.0.0.M8 Regards, Violeta > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
Re: [VOTE] Release Apache Tomcat 9.0.0.M8
On 07/06/2016 17:02, Mark Thomas wrote: > The proposed Apache Tomcat 9.0.0.M8 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 > > The major changes compared to the 9.0.0.M6 release are: > - Improvements to memory leak detection and prevention including the > change RMI memory leaks are now correctly treated as application bugs > rather than a JRE bug > - Fix a couple of memory leaks found in Tomcat > - The HTTP Server header is no longer set by default > > For full details, see the changelog: > http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M8/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1085/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M8/ > > The proposed 9.0.0.M8 release is: > [ ] Broken - do not release > [X] Alpha - go ahead and release as 9.0.0.M8 CI systems pass Unit tests pass on OSX and Windows One crash in APR on Linux - I'm investigating Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1747404 - in /tomcat/trunk: java/org/apache/tomcat/util/net/ webapps/docs/
Author: markt Date: Wed Jun 8 14:52:58 2016 New Revision: 1747404 URL: http://svn.apache.org/viewvc?rev=1747404&view=rev Log: Fix a cause of multiple attempts to close the same socket. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/SocketProcessorBase.java tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1747404&r1=1747403&r2=1747404&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Wed Jun 8 14:52:58 2016 @@ -2437,6 +2437,14 @@ public class AprEndpoint extends Abstrac @Override +public boolean isClosed() { +synchronized (closedLock) { +return closed; +} +} + + +@Override protected void doWrite(boolean block) throws IOException { if (closed) { throw new IOException(sm.getString("socket.apr.closed", getSocket())); Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java?rev=1747404&r1=1747403&r2=1747404&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Wed Jun 8 14:52:58 2016 @@ -895,6 +895,13 @@ public class Nio2Endpoint extends Abstra getSocket().close(); } + +@Override +public boolean isClosed() { +return !getSocket().isOpen(); +} + + @Override public boolean hasAsyncIO() { return false; Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=1747404&r1=1747403&r2=1747404&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Wed Jun 8 14:52:58 2016 @@ -1186,6 +1186,12 @@ public class NioEndpoint extends Abstrac } +@Override +public boolean isClosed() { +return !getSocket().isOpen(); +} + + private int fillReadBuffer(boolean block) throws IOException { int nRead; NioChannel channel = getSocket(); Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketProcessorBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SocketProcessorBase.java?rev=1747404&r1=1747403&r2=1747404&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/SocketProcessorBase.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/SocketProcessorBase.java Wed Jun 8 14:52:58 2016 @@ -41,6 +41,14 @@ public abstract class SocketProcessorBas @Override public final void run() { synchronized (socketWrapper) { +// It is possible that processing may be triggered for read and +// write at the same time. The sync above makes sure that processing +// does not occur in parallel. The test below ensures that if the +// first event to be processed results in the socket being closed, +// the subsequent events are not processed. +if (socketWrapper.isClosed()) { +return; +} doRun(); } } Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java?rev=1747404&r1=1747403&r2=1747404&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java Wed Jun 8 14:52:58 2016 @@ -297,7 +297,7 @@ public abstract class SocketWrapperBase< public abstract void close() throws IOException; - +public abstract boolean isClosed(); /** * Writes the provided data to the socket, buffering any remaining data if @@ -852,5 +852,4 @@ public abstract class SocketWrapperBase<
svn commit: r1747454 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/ webapps/docs/
Author: markt Date: Wed Jun 8 21:02:11 2016 New Revision: 1747454 URL: http://svn.apache.org/viewvc?rev=1747454&view=rev Log: Fix a cause of multiple attempts to close the same socket. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/SocketProcessorBase.java tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Wed Jun 8 21:02:11 2016 @@ -1 +1 @@ -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677 ,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234 +/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677 ,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747404 Modified: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1747454&r1=1747453&r2=1747454&view=diff ===
[GUMP@vmgump]: Project tomcat-native-trunk-make (in module tomcat-native-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-native-trunk-make has an issue affecting its community integration. This issue affects 3 projects, and has been outstanding for 32 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-native-trunk-make : Tomcat native library using Apache Portable Runtime - tomcat-native-trunk-make-install : Tomcat native library using Apache Portable Runtime - tomcat-trunk-test-apr : Tomcat 9.x, a web server implementing the Java Servlet 4.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-native-trunk/tomcat-native-trunk-make/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-native-trunk/tomcat-native-trunk-make/gump_work/build_tomcat-native-trunk_tomcat-native-trunk-make.html Work Name: build_tomcat-native-trunk_tomcat-native-trunk-make (Type: Build) Work ended in a state of : Failed Elapsed: 36 secs Command Line: make [Working Directory: /srv/gump/public/workspace/tomcat-native-trunk/native] - make[1]: Entering directory `/srv/gump/public/workspace/tomcat-native-trunk/native' /bin/bash /srv/gump/public/workspace/apr-1/dest-20160609/build-1/libtool --silent --mode=compile gcc -g -O2 -pthread -DHAVE_CONFIG_H -DLINUX -D_REENTRANT -D_GNU_SOURCE -g -O2 -DHAVE_OPENSSL -DHAVE_POLLSET_WAKEUP -I/srv/gump/public/workspace/tomcat-native-trunk/native/include -I/usr/lib/jvm/java-8-oracle/include -I/usr/lib/jvm/java-8-oracle/include/linux -I/srv/gump/public/workspace/openssl-master/dest-20160609/include -I/srv/gump/public/workspace/apr-1/dest-20160609/include/apr-1 -o src/address.lo -c src/address.c && touch src/address.lo /bin/bash /srv/gump/public/workspace/apr-1/dest-20160609/build-1/libtool --silent --mode=compile gcc -g -O2 -pthread -DHAVE_CONFIG_H -DLINUX -D_REENTRANT -D_GNU_SOURCE -g -O2 -DHAVE_OPENSSL -DHAVE_POLLSET_WAKEUP -I/srv/gump/public/workspace/tomcat-native-trunk/native/include -I/usr/lib/jvm/java-8-oracle/include -I/usr/lib/jvm/java-8-oracle/include/linux -I/srv/gump/public/workspace/openssl-master/dest-20160609/include -I/srv/gump/public/workspace/apr-1/dest-20160609/include/apr-1 -o src/bb.lo -c src/bb.c && touch src/bb.lo /bin/bash /srv/gump/public/workspace/apr-1/dest-20160609/build-1/libtool --silent --mode=compile gcc -g -O2 -pthread -DHAVE_CONFIG_H -DLINUX -D_REENTRANT -D_GNU_SOURCE -g -O2 -DHAVE_OPENSSL -DHAVE_POLLSET_WAKEUP -I/srv/gump/public/workspace/tomcat-native-trunk/native/include -I/usr/lib/jvm/java-8-oracle/include -I/usr/lib/jvm/java-8-oracle/include/linux -I/srv/gump/public/workspace/openssl-master/dest-20160609/include -I/srv/gump/public/workspace/apr-1/dest-20160609/include/apr-1 -o src/dir.lo -c src/dir.c && touch src/dir.lo /bin/bash /srv/gump/public/workspace/apr-1/dest-20160609/build-1/libtool --silent --mode=compile gcc -g -O2 -pthread -DHAVE_CONFIG_H -DLINUX -D_REENTRANT -D_GNU_SOURCE -g -O2 -DHAVE_OPENSSL -DHAVE_POLLSET_WAKEUP -I/srv/gump/public/workspace/tomcat-native-trunk/native/include -I/usr/lib/jvm/java-8-oracle/include -I/usr/lib/jvm/java-8-oracle/include/linux -I/srv/gump/public/workspace/openssl-master/dest-20160609/include -I/srv/gump/public/workspace/apr-1/dest-20160609/include/apr-1 -o src/error.lo -c src/error.c && touch src/error.lo /bin/bash /srv/gump/public/workspace/apr-1/dest-20160609/build-1/libtool --silent --mode=compile gcc -g -O2 -pthread -DHAVE_CONFIG_H -DLINUX -D_REENTRANT -D_GNU_SOURCE -g -O2 -DHAVE_OPENSSL -DHAVE_POLLSET_WAKEUP -I/srv/gump/public/workspace/tomcat-native-trunk/native/include -I/usr/lib/jvm/java-8-oracle/include -I/usr/lib/jvm/java-8-oracle/include/linux -I/srv/gump/public/workspace/openssl-master/dest-20160609/include -I/srv/gump/public/workspace/apr-1/dest-20160609/include/apr-1 -o src/file.lo -c src/file.c && touch src/file.lo /bin/bash /srv/gump/public/workspace/apr-1/dest-20160609/build-1/libtool --silent --mode=compile gcc -g -O2 -pthread -DHAVE_CONFIG_H -DLINUX -D_REENTRANT -D_GNU_SOURCE -g -O2 -DHAVE_OPENSSL -DHAVE_POLLSET_WAKEUP -I/srv/gump/public/workspace/tomcat-native-trunk/native/include -I/usr/lib/jvm/java-8-oracle/include -I/usr/lib/jvm/java-8-oracle/include/linux -I/srv/gump/public/workspace/openssl-master/dest-20160609/include -I/srv/gump/public/workspace/apr-1/dest-20160609/include/apr-1 -o src/info.lo -c src/info.c && touch src/info.lo /bin/bash /srv/gump/public/workspace/apr-