svn commit: r1745735 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml
Author: markt Date: Fri May 27 10:05:07 2016 New Revision: 1745735 URL: http://svn.apache.org/viewvc?rev=1745735&view=rev Log: If a request processor in async mode experiences a read or write timeout, ensure that the request processor is removed from the set of waiting request processors else the async timeout thread may attempt to timeout the request processor after it has been recycled. Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java?rev=1745735&r1=1745734&r2=1745735&view=diff == --- tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java Fri May 27 10:05:07 2016 @@ -977,6 +977,7 @@ public abstract class AbstractProtocolhttp://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1745735&r1=1745734&r2=1745735&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Fri May 27 10:05:07 2016 @@ -98,6 +98,12 @@ 59564: Correct offset when reading into HTTP/2 input buffer that could cause problems reading request bodies. (violetagg/markt) + +If a request processor in async mode experiences a read or write +timeout, ensure that the request processor is removed from the set of +waiting request processors else the async timeout thread may attempt to +timeout the request processor after it has been recycled. (markt) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1745736 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml
Author: markt Date: Fri May 27 10:05:40 2016 New Revision: 1745736 URL: http://svn.apache.org/viewvc?rev=1745736&view=rev Log: If a request processor in async mode experiences a read or write timeout, ensure that the request processor is removed from the set of waiting request processors else the async timeout thread may attempt to timeout the request processor after it has been recycled. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Fri May 27 10:05:40 2016 @@ -1 +1 @@ -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677 ,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745576 +/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677 ,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745576,1745735 Modified: tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java?rev=1745736&r1=1745735&r2=1745736&view=diff == --- tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java (original) +++ tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java Fri May 27 10:05:40 2016 @@ -977,6 +977,7 @@ public abstract class AbstractProtocolhttp://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1745736&r1=1745735&r2=1745736&view=diff == --- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Fri May 27 10:05:40 2016 @@ -98,6 +98,12 @@ 59564: Correct offset when reading into HTTP/2 input buffer that could
buildbot failure in on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/1400 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch tomcat/trunk] 1745735 Blamelist: markt BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58626] Tomcat does not start at boot time due to SIGHUP
https://bz.apache.org/bugzilla/show_bug.cgi?id=58626 --- Comment #21 from Konstantin Kolinko --- (In reply to Michael Osipov from comment #20) > (In reply to Konstantin Kolinko from comment #19) > > I think this may change the meaning of pid value in $CATALINA_PID file. I > > think that it will be the process id of nohup process instead of java one. > > > > Known uses of pid value: > > > > - forcibly terminating Tomcat with shutdown.sh -force > > > > echo "Killing Tomcat with the PID: $PID" > > kill -9 $PID > > > > - asking java for a thread dump > > > > echo "To aid diagnostics a thread dump has been written to standard out." > > kill -3 `cat "$CATALINA_PID"` > > Are you certain about this? > > Here is the output of HP-UX: > Thank you for checking! I was just guessing. (I remember users reporting similar problem with wrong value in pid file in some old version of catalina.sh, ~4 years ago.) Apparently this means that this version of nohup is implemented as replacing the old process with a new one, preserving the pid. A feature of unix exec() function. OK, good. If you are using CATALINA_PID files, can you also check that they contain the expected value of process id? BTW, in POSIX.1-2008/2013 there is a recommendation to redirect stdin when invoking nohup. See 'RATIONALE' section in http://pubs.opengroup.org/onlinepubs/9699919799/utilities/nohup.html Their example: nohup make
svn commit: r1745744 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml
Author: markt Date: Fri May 27 12:32:24 2016 New Revision: 1745744 URL: http://svn.apache.org/viewvc?rev=1745744&view=rev Log: Revert r1745735 since it triggers a test failure. Further investigation is required. Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java?rev=1745744&r1=1745743&r2=1745744&view=diff == --- tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java Fri May 27 12:32:24 2016 @@ -977,7 +977,7 @@ public abstract class AbstractProtocolhttp://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1745744&r1=1745743&r2=1745744&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Fri May 27 12:32:24 2016 @@ -98,12 +98,6 @@ 59564: Correct offset when reading into HTTP/2 input buffer that could cause problems reading request bodies. (violetagg/markt) - -If a request processor in async mode experiences a read or write -timeout, ensure that the request processor is removed from the set of -waiting request processors else the async timeout thread may attempt to -timeout the request processor after it has been recycled. (markt) - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1745745 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml
Author: markt Date: Fri May 27 12:33:11 2016 New Revision: 1745745 URL: http://svn.apache.org/viewvc?rev=1745745&view=rev Log: Revert r1745736 since it triggers a test failure in 9.0.x. Further investigation is required. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Fri May 27 12:33:11 2016 @@ -1 +1 @@ -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677 ,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745576,1745735 +/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677 ,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745576,1745735,1745744 Modified: tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java?rev=1745745&r1=1745744&r2=1745745&view=diff == --- tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java (original) +++ tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java Fri May 27 12:33:11 2016 @@ -977,7 +977,7 @@ public abstract class AbstractProtocolhttp://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1745745&r1=1745744&r2=1745745&view=diff == --- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Fri May 27 12:33:11 2016 @@ -98,12 +98,6 @@ 59564: Correct offset when reading into HTTP/2 input buffer that could cause problems reading request bodies. (violetagg/markt) - -If a request processor in async mode experiences a read or write -t
buildbot success in on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/1401 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch tomcat/trunk] 1745744 Blamelist: markt Build succeeded! Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59334] .NET Application Pools requests hang because Jakarta/Tomcat uses a Named Mutex that is currently owned by a different process
https://bz.apache.org/bugzilla/show_bug.cgi?id=59334 --- Comment #7 from Christopher Schultz --- I'm confused: what fix did you apply? There is no fix attached to this bug report. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: Tomcat 8.5: Avoid NPE on bind for APR when using SSL.
No? 8.5 suffers from the same NPE. - Matt -Original Message- From: Rémy Maucherat [mailto:r...@apache.org] Sent: Wednesday, May 25, 2016 12:16 PM To: Tomcat Developers List Subject: Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL. 2016-05-25 19:11 GMT+02:00 Matt Cosentino : > This needs to be ported back to 8.5. > > http://svn.apache.org/viewvc?view=revision&revision=1726515 > > No. Rémy
Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL.
2016-05-27 17:45 GMT+02:00 Matt Cosentino : > No? 8.5 suffers from the same NPE. > > First, 8.5 was branched in March, then I am not happy about being spammed. Rémy
RE: Tomcat 8.5: Avoid NPE on bind for APR when using SSL.
It may have been branched in March, but wouldn't it have been branched from the 8.0 base? This change from 9.0 is not in the 8.5 code and the NPE still occurs. Bringing an issue to your attention is spamming? - Matt -Original Message- From: Rémy Maucherat [mailto:r...@apache.org] Sent: Friday, May 27, 2016 11:06 AM To: Tomcat Developers List Subject: Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL. 2016-05-27 17:45 GMT+02:00 Matt Cosentino : > No? 8.5 suffers from the same NPE. > > First, 8.5 was branched in March, then I am not happy about being spammed. Rémy
Re: [PROPOSAL] Remove StandardContext.clearReferencesStatic in 9.0.x
Mark, On 5/19/16 7:21 AM, Mark Thomas wrote: > As you are probably aware, I have been working through the memory leak > protection / detection code checking that the code is still relevant for > Tomcat 9. Having reviewed the history of clearReferencesStatic I'd like > to propose removing it in 9.0.x and deprecating it in 8.0.x. > > clearReferencesStatic was originally added to address unidentified > memory leaks including suspected GC bugs in early JDKs (1.3, 1.4 time > frame). It is disabled by default because it is known to break some > libraries such as log4j. My reasons for proposing removal are: > > 1. The presence of GC bugs was just a theory. My own theory is that >the suspected GC bugs were actually memory leaks where the root >cause had not been identified. > > 2. In the unlikely event some issues do remain, I'd prefer to identify >the root causes and work-around them rather than apply this general >fix which is as likely, if not more likely, to break things. > > 3. Disabling this by default has not caused an increase in the reports >of memory leaks. > > Thoughts? Objections? +1 to remove. Might want to deprecate in Tomcat 8.5, leave it alone in Tomcat 8? I suppose deprecating a method really changes nothing, so I have no objections to back-porting that deprecation as far as you'd care to. -chris signature.asc Description: OpenPGP digital signature
Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL.
> It may have been branched in March, but wouldn't it have been branched from > the 8.0 base? This change from 9.0 is not in the 8.5 code and the NPE still > occurs. No, 8.5 was branched from trunk and therefore included the revision that you pointed out. Please see the dev list thread titled "Tomcat 8.next" for more information on the 8.5 origin. Additionally, looking at the mergeinfo in svn (svn mergeinfo ^/tomcat/trunk@1726515) shows that it was forked from trunk. If you looked at the 8.5 AprEndpoint class and don't see the change, it's because it was changed by r1727667 on 1/29 (r1726515 was included on 1/24). On Fri, May 27, 2016 at 12:24 PM, Matt Cosentino wrote: > It may have been branched in March, but wouldn't it have been branched from > the 8.0 base? This change from 9.0 is not in the 8.5 code and the NPE still > occurs. > > Bringing an issue to your attention is spamming? > > - Matt > > > -Original Message- > From: Rémy Maucherat [mailto:r...@apache.org] > Sent: Friday, May 27, 2016 11:06 AM > To: Tomcat Developers List > Subject: Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL. > > 2016-05-27 17:45 GMT+02:00 Matt Cosentino : > >> No? 8.5 suffers from the same NPE. >> >> First, 8.5 was branched in March, then I am not happy about being spammed. > > Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59232] Make the context name of an app available via JNDI
https://bz.apache.org/bugzilla/show_bug.cgi?id=59232 --- Comment #3 from Christopher Schultz --- (In reply to Mark Thomas from comment #1) > - new StandardContext options "addNameToJndi" Why bother having an option for this? It's a one-time call to place a simple object into JNDI... why not do it unconditionally? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59179] HTTP Public Key Pinning for Tomcat
https://bz.apache.org/bugzilla/show_bug.cgi?id=59179
--- Comment #3 from Christopher Schultz ---
Nit:
HttpHeaderSecurityFilter:106 performs a StringBuilder.append("") which does
nothing. I think that line can be removed.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: Tomcat 8.5: Avoid NPE on bind for APR when using SSL.
I see, that explains why it isn't in 8.5, thanks for the helpful response. I'll investigate further why the NPE is still occurring. - Matt -Original Message- From: Coty Sutherland [mailto:csuth...@redhat.com] Sent: Friday, May 27, 2016 1:27 PM To: Tomcat Developers List Subject: Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL. > It may have been branched in March, but wouldn't it have been branched from > the 8.0 base? This change from 9.0 is not in the 8.5 code and the NPE still > occurs. No, 8.5 was branched from trunk and therefore included the revision that you pointed out. Please see the dev list thread titled "Tomcat 8.next" for more information on the 8.5 origin. Additionally, looking at the mergeinfo in svn (svn mergeinfo ^/tomcat/trunk@1726515) shows that it was forked from trunk. If you looked at the 8.5 AprEndpoint class and don't see the change, it's because it was changed by r1727667 on 1/29 (r1726515 was included on 1/24). On Fri, May 27, 2016 at 12:24 PM, Matt Cosentino wrote: > It may have been branched in March, but wouldn't it have been branched from > the 8.0 base? This change from 9.0 is not in the 8.5 code and the NPE still > occurs. > > Bringing an issue to your attention is spamming? > > - Matt > > > -Original Message- > From: Rémy Maucherat [mailto:r...@apache.org] > Sent: Friday, May 27, 2016 11:06 AM > To: Tomcat Developers List > Subject: Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL. > > 2016-05-27 17:45 GMT+02:00 Matt Cosentino : > >> No? 8.5 suffers from the same NPE. >> >> First, 8.5 was branched in March, then I am not happy about being spammed. > > Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[PATCH]
Hello, I am new to Apache Tomcat. While i was reading the code i found something that i could change. In org.apache.catalina.users.MemoryGroup and org.apache.catalina.users.MemoryUser i have change the ArrayList to HashSet because i think HashSet will have better performance in this case and does not have to search for duplicates. I am sorry if i have not follow the procedure of submitting a patch. I would be very thankful if anyone explain the procedure to me. Please find attached with this email the patch i have provided. Thank you, Sadik Kalia - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: [PATCH]
Good afternoon, Your emails back and forth are all going through our graduate admissions email, can you please find another place for your Bugzilla, Apache, Tomcat business. Thank you From: Sadik Kalia [mailto:kalia.sa...@gmail.com] Sent: Friday, May 27, 2016 3:36 PM To: dev@tomcat.apache.org Subject: [PATCH] Hello, I am new to Apache Tomcat. While i was reading the code i found something that i could change. In org.apache.catalina.users.MemoryGroup and org.apache.catalina.users.MemoryUser i have change the ArrayList to HashSet because i think HashSet will have better performance in this case and does not have to search for duplicates. I am sorry if i have not follow the procedure of submitting a patch. I would be very thankful if anyone explain the procedure to me. Please find attached with this email the patch i have provided. Thank you, Sadik Kalia
