svn commit: r1745576 - in /tomcat/trunk: java/org/apache/coyote/http2/Http2Parser.java webapps/docs/changelog.xml
Author: markt
Date: Thu May 26 08:44:07 2016
New Revision: 1745576
URL: http://svn.apache.org/viewvc?rev=1745576&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59564
Correct offset when reading into HTTP/2 input buffer that could cause problems
reading request bodies. Patch by violetagg.
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java?rev=1745576&r1=1745575&r2=1745576&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java Thu May 26
08:44:07 2016
@@ -561,7 +561,7 @@ class Http2Parser {
}
default boolean fill(boolean block, ByteBuffer data, int len) throws
IOException {
-boolean result = fill(block, data.array(), data.arrayOffset(),
len);
+boolean result = fill(block, data.array(), data.arrayOffset() +
data.position(), len);
if (result) {
data.position(data.position() + len);
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1745576&r1=1745575&r2=1745576&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu May 26 08:44:07 2016
@@ -94,6 +94,10 @@
attribute, serverRemoveAppProvidedValues may be used to
remove any Server header set by a web application. (markt)
+
+59564: Correct offset when reading into HTTP/2 input buffer
+that could cause problems reading request bodies. (violetagg/markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1745578 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/Http2UpgradeHandler.java test/org/apache/coyote/http2/Http2TestBase.java webapps/docs/changelog.xml
Author: markt
Date: Thu May 26 08:46:19 2016
New Revision: 1745578
URL: http://svn.apache.org/viewvc?rev=1745578&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59564
Correct offset when reading into HTTP/2 input buffer that could cause problems
reading request bodies. Patch by violetagg.
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
tomcat/tc8.5.x/trunk/test/org/apache/coyote/http2/Http2TestBase.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May 26 08:46:19 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745576
Modified:
tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1745578&r1=1745577&r2=1745578&view=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
(original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Thu May 26 08:46:19 2016
@@ -1065,7 +1065,7 @@ public class Http2UpgradeHandler extends
@Override
public boolean fill(boolean block, ByteBuffer data, int len) throws
IOException {
-boolean result = fill(block, data.array(), data.arrayOffset(), len);
+boolean result = fill(block, data.array(), data.arrayOffset() +
data.position(), len);
if (result) {
data.position(data.position() + len);
}
Modified: tomcat/tc8.5.x/trunk/test/org/apache/coyote/http2/Http2Tes
[Bug 59564] HttpServletRequest.getPart() always returns null with HTTP/2
https://bz.apache.org/bugzilla/show_bug.cgi?id=59564 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Mark Thomas --- Reproducible with: - Clean 9.0.x build - NIO + OpenSSL + HTTP/2 - ~40MB WAR (Spring Pet Clinic) Violeta's patch fixes this so I have applied it to 9.0.x for 9.0.0.M7 onwards and 8.5.x for 8.5.3 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59604] Invalid url-pattern in servlet mapping on s390x
https://bz.apache.org/bugzilla/show_bug.cgi?id=59604 --- Comment #16 from Mark Thomas --- Please try the following: Clean Tomcat install. Confirm problem exists. Remove apps one by one until only ROOT is left. Confirm problem still exists as each app is removed. Remove ROOT/WEB-INF/web.xml Confirm problem still exists. Remove content from conf/web.xml until you have the minimal conf/web.xml that triggers the problem. I'm expecting a minimal conf/web.xml with a single Servlet definition and associated Servlet mapping to trigger this issue. Experiment with different encodings for the XML prolog for conf/web.xml. Test UTF-8 and ISO-8859-1 as a minimum. Report your findings. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Difference in the behaviour of WebappClassLoaderBase.getResource for jar resources
On 06/05/2016 09:37, Violeta Georgieva wrote: > Let me summarize the findings till now. > > According to [1] > > 1) when Class.getResource(name) > "The resource name given to a Class method may have an initial starting "/" > that identifies it as an "absolute" name. Resource names that do not start > with a "/" are "relative". > Absolute names are stripped of their starting "/" and are passed, without > any further modification, to the appropriate ClassLoader method to locate > the resource. > Relative names are modified according to the convention described > previously and then are passed to a ClassLoader method." > > So when "name" is absolute the leading "/" slash will be removed and the > call will be delegated to ClassLoader.getResource(name) > > 2) when ClassLoader.getResource(name) > "The methods in ClassLoader use the given String as the name of the > resource without applying any absolute/relative transformation (see the > methods in Class). The name should not have a leading "/"." > > As we saw above (Konstantin's example) call with > - name without leading "/" is successful > - name with leading "/" returns null > > According to [2] > 3) when URLClassLoader.getResource(name) > "This class loader is used to load classes and resources from a search path > of URLs referring to both JAR files and directories. > findResource(name) > Finds the resource with the specified name on the URL search path." > > Now from the source code [3] > URLClassLoader.findResource delegates the call to the > sun.misc.URLClassPath.findResource > For resource in a jar file - URLClassPath.Loader is used. It just creates a > new url based on the jar file and the provided name. > When creating the URL - sun.net.www.protocol.jar.Handler (parseContextSpec) > removes the leading "/" and the URL to the resource is created successfully. > > So if we construct URLClassLoader and call with: > - name without leading "/" is successful > - name with leading "/" is again successful > > == > Now to the issue that the user reports. The > org.apache.naming.resources.ClasspathURLStreamHandler is implemented in a > way that > - when searching the web app loader the implementation uses > ClassLoader.getResource > - but when searches the Tomcat class loader it uses Class.getResource > > Because of this when the jar files are packed in the application and the > resource has leading "/" it cannot be found, but when moving the jar files > to the Tomcat lib the resource will be found. > > As WebappClassLoader extends URLClassLoader > We have to decide whether WebappClassLoader.getResource() should be > consistent with Java API of java.lang.ClassLoader.getResource() or > URLClassLoader.getResource() behavior. > A quick check to other web containers showed that they behave as Tomcat 8. > > I tend to implement Tomcat 7 behaviour as Tomcat 8 and support resource > names with leading "/". > But as this behaviour is not strictly specified I prefer to get more > opinions. > > With the introduction of ClasspathURLStreamHandler (7.0.66) we break user's > scenario that was working previously. > > [1] > https://docs.oracle.com/javase/8/docs/technotes/guides/lang/resources.html > [2] https://docs.oracle.com/javase/8/docs/api/java/net/URLClassLoader.html > [3] http://hg.openjdk.java.net/jdk8/jdk8/jdk/ Coming back to this. Having read through this thread and looked at the svn history, it looks like a back-port of r1539623 (any any related commits) is required. I'm planning on looking at this today. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58626] Tomcat does not start at boot time due to SIGHUP
https://bz.apache.org/bugzilla/show_bug.cgi?id=58626 --- Comment #19 from Konstantin Kolinko --- I think this may change the meaning of pid value in $CATALINA_PID file. I think that it will be the process id of nohup process instead of java one. Known uses of pid value: - forcibly terminating Tomcat with shutdown.sh -force echo "Killing Tomcat with the PID: $PID" kill -9 $PID - asking java for a thread dump echo "To aid diagnostics a thread dump has been written to standard out." kill -3 `cat "$CATALINA_PID"` -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1745599 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/loader/WebappClassLoaderBase.java webapps/docs/changelog.xml
Author: markt
Date: Thu May 26 12:48:24 2016
New Revision: 1745599
URL: http://svn.apache.org/viewvc?rev=1745599&view=rev
Log:
Make resourceEntries a ConcurrentHashMap else there is a risk of a threading
issues when different threads read and write at the same time.
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java?rev=1745599&r1=1745598&r2=1745599&view=diff
==
---
tomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java
(original)
+++
tomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java
Thu May 26 12:48:24 2016
@@ -56,6 +56,7 @@ import java.util.List;
import java.util.Map;
import java.util.ResourceBundle;
import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.concurrent.ThreadPoolExecutor;
import java.util.jar.Attributes;
@@ -335,7 +336,7 @@ public abstract class WebappClassLoaderB
* The cache of ResourceEntry for classes and resources we have loaded,
* keyed by resource name.
*/
-protected HashMap resourceEntries = new
HashMap();
+protected Map resourceEntries = new
ConcurrentHashMap();
/**
@@ -2301,9 +2302,8 @@ public abstract class WebappClassLoaderB
private final void clearReferencesStaticFinal() {
-@SuppressWarnings("unchecked") // resourceEntries is HashMap
-Collection values =
-((HashMap) resourceEntries.clone()).values();
+List values = new ArrayList();
+values.addAll(resourceEntries.values());
Iterator loadedClasses = values.iterator();
//
// walk through all loaded class to trigger initialization for
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1745599&r1=1745598&r2=1745599&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Thu May 26 12:48:24 2016
@@ -109,6 +109,10 @@
leaks is made. Log a warning if running on Java 9 with this check
enabled but without the command line option it requires. (markt)
+
+Fix potential concurrency issue with web application class loader with
+concurrent reads and writes of the resource cache. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58626] Tomcat does not start at boot time due to SIGHUP
https://bz.apache.org/bugzilla/show_bug.cgi?id=58626 --- Comment #20 from Michael Osipov <1983-01...@gmx.net> --- (In reply to Konstantin Kolinko from comment #19) > I think this may change the meaning of pid value in $CATALINA_PID file. I > think that it will be the process id of nohup process instead of java one. > > Known uses of pid value: > > - forcibly terminating Tomcat with shutdown.sh -force > > echo "Killing Tomcat with the PID: $PID" > kill -9 $PID > > - asking java for a thread dump > > echo "To aid diagnostics a thread dump has been written to standard out." > kill -3 `cat "$CATALINA_PID"` Are you certain about this? Here is the output of HP-UX: > root@blnn728x - / > 243 # ps -fu root | grep nohup > root 29012 17788 0 15:06:04 pts/3 0:00 grep nohup > > root@blnn728x - / > 244 # echo $USER > root > > root@blnn728x - / > 245 # ps -fu root | grep nohup > root 29088 17788 0 15:07:38 pts/3 0:00 grep nohup > > root@blnn728x - / > 246 # ps -fu smartld | grep nohup > > root@blnn728x - / > 247 # ps -fu smartld | grep java > smartld 17619 1 0 Mai 22 ?59:14 /opt/java7/bin/java > -Djava.util.logging.config.file=/var/opt/tomcat/conf/logging.properties > -Djava.util.logging.manager=org.apa > smartld 28268 1 0 12:03:17 pts/2 3:48 /opt/java7/bin/java > -Djava.util.logging.config.file=/var/opt/tomcat-services/conf/logging.properties > -Djava.util.logging.manage > -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59635] PerMessageDeflate.sendMassagePart() IllegalArgumentException using atmosphere
https://bz.apache.org/bugzilla/show_bug.cgi?id=59635 Mark Thomas changed: What|Removed |Added OS||All Severity|blocker |major --- Comment #1 from Mark Thomas --- Bug 59189 is unlikely to be related to this report. Bug 58414, r1703948 and r1732900 look more likely to be related. Given that the unit tests pass and the Autobahn tests pass, this looks like some form of edge case. A simple test case that demonstrates the problem would be very helpful. I'll continue to look into this but if I can't reproduce this or discover the problem via code inspection, a test case will be required. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1745608 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/loader/WebappClassLoaderBase.java webapps/docs/changelog.xml
Author: markt Date: Thu May 26 14:00:10 2016 New Revision: 1745608 URL: http://svn.apache.org/viewvc?rev=1745608&view=rev Log: Within the web application class loader, always use path as the key for the resource cache to improve the hit ration. This also fixes a problem exposed by the fix for bug 56777 that enabled file based configuration resources to be loaded from the class path. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc7.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Thu May 26 14:00:10 2016 @@ -1,3 +1,3 @@ /tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553 -1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702 744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1726171-1 726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272 /tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804,1740811,1740981,1741165,1741174,1741182,1741191,1741203,1741209,1741226,1741233,1741410,1742277,1743118,1743126,1743139-1743140,1743718,1743722,1743724,1744059,1744127,1744151,1744232,1744377,1744687,1744698,1744706,1745228 -/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722
[Bug 59619] Failed to read schema document 'classpath:/schema/shibboleth-2.0-services.xsd'
https://bz.apache.org/bugzilla/show_bug.cgi?id=59619 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Mark Thomas --- Fixed in 7.0.x for 7.0.70 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57665] support x-forwarded-host
https://bz.apache.org/bugzilla/show_bug.cgi?id=57665
--- Comment #2 from Robert ---
The best workaround so far (which is really just a hack) is to extend
Http11NioProtocol as shown below:
/**
* Custom Tomcat Protocol based off of Http11NioProtocol that looks for an
* X-Forwarded-Host header and sets the serverName in the request to that
* value.
*
* This couldn't be done in a Valve because a Valve is processed too late to
* handle a context name redirect. For example if the url
* `https://example.org/book` is requested. Really early in the request
* Tomcat will redirect this url to `https://example.org/book/`.
* This protocol will provide the X-Forwarded-Host header value even for that
* type of redirect.
*
* To use simply set this class as the value of the
* {@code Connector->protocol} attribute in server.xml
*/
public static class XForwardedHostHandlingHttp11NioProtocol extends
Http11NioProtocol
{
@Override
public void setAdapter(final Adapter adapter) {
Adapter adapterFacade = (Adapter) Proxy.newProxyInstance(
XForwardedHostHandlingHttp11NioProtocol.class.getClassLoader(),
new Class[] {Adapter.class}, (proxy, method, args) ->
{
if (method.getName().equals("service")) {
Request req = (Request)args[0];
String header = req.getHeader("X-Forwarded-Host");
if (header != null) {
req.serverName().setString(header);
}
}
return method.invoke(adapter, args);
});
super.setAdapter(adapterFacade);
}
}
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59604] Invalid url-pattern in servlet mapping on s390x
https://bz.apache.org/bugzilla/show_bug.cgi?id=59604 --- Comment #17 from Dave --- The problem still exists after each step: 1. as each app is removed 2. with only ROOT app 3. after removing ROOT/WEB-INF/web.xml 4. with a minimum conf/web.xml I will upload the minimum conf/web.xml and catalina.out -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59604] Invalid url-pattern in servlet mapping on s390x
https://bz.apache.org/bugzilla/show_bug.cgi?id=59604 --- Comment #18 from Dave --- Created attachment 33895 --> https://bz.apache.org/bugzilla/attachment.cgi?id=33895&action=edit minimum /conf/web.xml -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59604] Invalid url-pattern in servlet mapping on s390x
https://bz.apache.org/bugzilla/show_bug.cgi?id=59604 --- Comment #19 from Dave --- The problem still exits even with a "bare bones" conf/web.xml -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59604] Invalid url-pattern in servlet mapping on s390x
https://bz.apache.org/bugzilla/show_bug.cgi?id=59604 --- Comment #20 from Dave --- Created attachment 33896 --> https://bz.apache.org/bugzilla/attachment.cgi?id=33896&action=edit "bare bones" conf/web.xml -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59604] Invalid url-pattern in servlet mapping on s390x
https://bz.apache.org/bugzilla/show_bug.cgi?id=59604 --- Comment #21 from Dave --- Created attachment 33897 --> https://bz.apache.org/bugzilla/attachment.cgi?id=33897&action=edit log file with bare bones conf/web.xml -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59604] Invalid url-pattern in servlet mapping on s390x
https://bz.apache.org/bugzilla/show_bug.cgi?id=59604 --- Comment #22 from Dave --- By the way, switching between UTF-8 and ISO-8859-1 made no difference. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
