[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio (in module tomcat-8.0.x) failed

2016-04-28 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-nio has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 4 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-nio :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-nio/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 49 mins 59 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160428-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160428.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160428-native-src.tar.gz
 -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.t
 est.nio=true 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20160428/bin/openssl
 -Dexecute.test.bio=false -Dexecute.test.apr=false 
-Dtest.excludePerformance=true -Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build

svn commit: r1741389 - in /tomcat/native/trunk/xdocs: index.xml news/2016.xml

2016-04-28 Thread markt 
Author: markt
Date: Thu Apr 28 07:37:50 2016
New Revision: 1741389

URL: http://svn.apache.org/viewvc?rev=1741389&view=rev
Log:
Add details of 1.2.6 release

Modified:
tomcat/native/trunk/xdocs/index.xml
tomcat/native/trunk/xdocs/news/2016.xml

Modified: tomcat/native/trunk/xdocs/index.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/xdocs/index.xml?rev=1741389&r1=1741388&r2=1741389&view=diff
==
--- tomcat/native/trunk/xdocs/index.xml (original)
+++ tomcat/native/trunk/xdocs/index.xml Thu Apr 28 07:37:50 2016
@@ -64,9 +64,9 @@ manual is described in more detail below
 
 
 
-7 Mar 2016 - TC-Native-1.2.5 
released
+26 Apr 2016 - TC-Native-1.2.6 
released
 The Apache Tomcat team is proud to announce the immediate availability of
-Tomcat Native 1.2.5 Stable.
+Tomcat Native 1.2.6 Stable.
 
 The sources and the binaries for selected platforms are available from the
 Download page.

Modified: tomcat/native/trunk/xdocs/news/2016.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/xdocs/news/2016.xml?rev=1741389&r1=1741388&r2=1741389&view=diff
==
--- tomcat/native/trunk/xdocs/news/2016.xml (original)
+++ tomcat/native/trunk/xdocs/news/2016.xml Thu Apr 28 07:37:50 2016
@@ -29,6 +29,12 @@
 
 
 
+ 
+  The Apache Tomcat team is proud to announce the immediate availability
+  of Tomcat Native 1.2.6. This is a bug fix release and includes Windows
+  binaries built with OpenSSL 1.0.2g and APR 1.5.2.
+  
+ 
  
   The Apache Tomcat team is proud to announce the immediate availability
   of Tomcat Native 1.2.5. This is a bug fix release and includes Windows



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1741390 - in /tomcat: native/trunk/xdocs/miscellaneous/changelog.xml site/trunk/docs/native-doc/index.html site/trunk/docs/native-doc/miscellaneous/changelog.html site/trunk/docs/native-d

2016-04-28 Thread markt 
Author: markt
Date: Thu Apr 28 07:40:33 2016
New Revision: 1741390

URL: http://svn.apache.org/viewvc?rev=1741390&view=rev
Log:
Update tc-native docs for 1.2.6 release

Modified:
tomcat/native/trunk/xdocs/miscellaneous/changelog.xml
tomcat/site/trunk/docs/native-doc/index.html
tomcat/site/trunk/docs/native-doc/miscellaneous/changelog.html
tomcat/site/trunk/docs/native-doc/news/2016.html

Modified: tomcat/native/trunk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/xdocs/miscellaneous/changelog.xml?rev=1741390&r1=1741389&r2=1741390&view=diff
==
--- tomcat/native/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/native/trunk/xdocs/miscellaneous/changelog.xml Thu Apr 28 07:40:33 
2016
@@ -34,10 +34,6 @@
   This is the Changelog for Tomcat Native 1.2.
   
 
-
-  
-  
-
 
   
 

Modified: tomcat/site/trunk/docs/native-doc/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/native-doc/index.html?rev=1741390&r1=1741389&r2=1741390&view=diff
==
--- tomcat/site/trunk/docs/native-doc/index.html (original)
+++ tomcat/site/trunk/docs/native-doc/index.html Thu Apr 28 07:40:33 2016
@@ -32,9 +32,9 @@ manual is described in more detail below
 Headlines
 
 
-7 Mar 2016 - TC-Native-1.2.5 
released
+26 Apr 2016 - TC-Native-1.2.6 
released
 The Apache Tomcat team is proud to announce the immediate availability of
-Tomcat Native 1.2.5 Stable.
+Tomcat Native 1.2.6 Stable.
 
 The sources and the binaries for selected platforms are available from the
 Download page.

Modified: tomcat/site/trunk/docs/native-doc/miscellaneous/changelog.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/native-doc/miscellaneous/changelog.html?rev=1741390&r1=1741389&r2=1741390&view=diff
==
--- tomcat/site/trunk/docs/native-doc/miscellaneous/changelog.html (original)
+++ tomcat/site/trunk/docs/native-doc/miscellaneous/changelog.html Thu Apr 28 
07:40:33 2016
@@ -3,6 +3,36 @@
   
   This is the Changelog for Tomcat Native 1.2.
   
+Changes in 1.2.6
+  
+
+  Change the OpenSSL version check in configure
+  to be fatal. (rjung)
+
+
+  Use new OpenSSL 1.1.0 protocol version max and min API
+  when creating a new SSL context. (rjung)
+
+
+  Improve renegotiation code and make it compatible with
+  OpenSSL 1.1.0. (rjung)
+
+
+  OpenSSL 1.1.0 compatibility updates. (rjung)
+
+
+  Fix some compiler warnings in native ssl code. (rjung)
+
+
+  Add support for using Java keystores for certificate chains. (markt)
+
+
+  Remove the explicit CRL check when verifying certificates.
+  The checks were already part of the internal certification
+  verification since OpenSSL 0.9.7. Backport from mod_ssl.
+  (rjung)
+
+  
 Changes in 1.2.5
   
 

Modified: tomcat/site/trunk/docs/native-doc/news/2016.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/native-doc/news/2016.html?rev=1741390&r1=1741389&r2=1741390&view=diff
==
--- tomcat/site/trunk/docs/native-doc/news/2016.html (original)
+++ tomcat/site/trunk/docs/native-doc/news/2016.html Thu Apr 28 07:40:33 2016
@@ -1,5 +1,11 @@
 
 The Apache Tomcat Native - News - 2016 News and 
Statushttp://tomcat.apache.org/";>http://www.apache.org/"; target="_blank">The Apache Tomcat Native - 
NewsLinksDocs Home
 Miscellaneous 
DocumentationChangelogNews2016201520142013201220112010200920082016 News and Status2016 News & Status
+ 26 Apr 2016 - TC-Native-1.2.6 
released
+  The Apache Tomcat team is proud to announce the immediate availability
+  of Tomcat Native 1.2.6. This is a bug fix release and includes Windows
+  binaries built with OpenSSL 1.0.2g and APR 1.5.2.
+  
+ 
  7 Mar 2016 - TC-Native-1.2.5 
released
   The Apache Tomcat team is proud to announce the immediate availability
   of Tomcat Native 1.2.5. This is a bug fix release and includes Windows



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1741391 - in /tomcat/site/trunk: docs/download-native.html docs/index.html docs/oldnews.html xdocs/download-native.xml xdocs/index.xml xdocs/oldnews.xml

2016-04-28 Thread markt 
Author: markt
Date: Thu Apr 28 07:44:14 2016
New Revision: 1741391

URL: http://svn.apache.org/viewvc?rev=1741391&view=rev
Log:
Update news and downloads for 1.2.6 release

Modified:
tomcat/site/trunk/docs/download-native.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/xdocs/download-native.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/oldnews.xml

Modified: tomcat/site/trunk/docs/download-native.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-native.html?rev=1741391&r1=1741390&r2=1741391&view=diff
==
--- tomcat/site/trunk/docs/download-native.html (original)
+++ tomcat/site/trunk/docs/download-native.html Thu Apr 28 07:44:14 2016
@@ -285,14 +285,14 @@
 
 
   
-
-Native 1.2.5 Source Release tar.gz (e.g. Unix, Linux, Mac 
OS)
+
+Native 1.2.6 Source Release tar.gz (e.g. Unix, Linux, Mac 
OS)
 
   
 
-[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/source/tomcat-native-1.2.5-src.tar.gz.asc";>PGP],
-[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/source/tomcat-native-1.2.5-src.tar.gz.md5";>MD5],
-[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/source/tomcat-native-1.2.5-src.tar.gz.sha1";>SHA1]
+[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.6/source/tomcat-native-1.2.6-src.tar.gz.asc";>PGP],
+[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.6/source/tomcat-native-1.2.6-src.tar.gz.md5";>MD5],
+[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.6/source/tomcat-native-1.2.6-src.tar.gz.sha1";>SHA1]
   
 
 
@@ -301,14 +301,14 @@
 
 
   
-
-Native 1.2.5 Source Release zip (e.g. Windows)
+
+Native 1.2.6 Source Release zip (e.g. Windows)
 
   
 
-[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/source/tomcat-native-1.2.5-win32-src.zip.asc";>PGP],
-[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/source/tomcat-native-1.2.5-win32-src.zip.md5";>MD5],
-[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/source/tomcat-native-1.2.5-win32-src.zip.sha1";>SHA1]
+[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.6/source/tomcat-native-1.2.6-win32-src.zip.asc";>PGP],
+[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.6/source/tomcat-native-1.2.6-win32-src.zip.md5";>MD5],
+[https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.6/source/tomcat-native-1.2.6-win32-src.zip.sha1";>SHA1]
   
 
 
@@ -323,7 +323,7 @@
 
 You can find binaries release too.
 You may download them from
-  HERE
+  HERE
 
 
 
@@ -352,14 +352,14 @@
   
 
 
-
-  Native 1.2.5 Windows Binaries zip (recommended)
+
+  Native 1.2.6 Windows Binaries zip (recommended)
   
 
 
-  [https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/binaries/tomcat-native-1.2.5-win32-bin.zip.asc";>PGP],
-  [https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/binaries/tomcat-native-1.2.5-win32-bin.zip.md5";>MD5],
-  [https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/binaries/tomcat-native-1.2.5-win32-bin.zip.sha1";>SHA1]
+  [https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.6/binaries/tomcat-native-1.2.6-win32-bin.zip.asc";>PGP],
+  [https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.6/binaries/tomcat-native-1.2.6-win32-bin.zip.md5";>MD5],
+  [https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.6/binaries/tomcat-native-1.2.6-win32-bin.zip.sha1";>SHA1]
 
   
 
@@ -368,15 +368,15 @@
   
 
 
-
-  Native 1.2.5 Windows OCSP-enabled Binaries zip
+
+  Native 1.2.6 Windows OCSP-enabled Binaries zip
   
 
 
 
-  [https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/binaries/tomcat-native-1.2.5-ocsp-win32-bin.zip.asc";>PGP],
-  [https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/binaries/tomcat-native-1.2.5-ocsp-win32-bin.zip.md5";>MD5],
-  [https://www.apache.org/dist/tomcat/tomcat-connectors/native/1.2.5/binaries/tomcat-native-1.2.5-ocsp-win32-bin.zip.sha1";>SHA1]
+  [https://www.apache.org/dist/tomcat/tomcat-connecto

svn commit: r13446 - /release/tomcat/tomcat-connectors/native/1.2.5/

2016-04-28 Thread markt 
Author: markt
Date: Thu Apr 28 07:45:33 2016
New Revision: 13446

Log:
Drop tomcat-native 1.2.5 from the mirrors

Removed:
release/tomcat/tomcat-connectors/native/1.2.5/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59390] New: Tomcat systemd/systemctl status tomcat don't show catalina errors.

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59390

Bug ID: 59390
   Summary: Tomcat systemd/systemctl status tomcat don't show
catalina errors.
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: dmaioc...@suse.com

[Distros tested]

-opensuse
-fedora

[HOW to Reproduce]

installing tomcat. 
As user i want to setup tomcat with ssl.

I generate the keystore using the java tool but "accidentally" i put it in a
directory  that as the wrong permission. example "root/keystore"

So i setup tomcat and start it with systemctl start tomcat.

when i run systemctl status tomcat i got :

systemctl status tomcat.service 
● tomcat.service - Apache Tomcat Web Application Container
   Loaded: loaded (/usr/lib/systemd/system/tomcat.service; disabled; vendor
preset: disabled)
   Active: active (running) since Do 2016-04-28 08:35:44 CEST; 1h 31min ago
  Process: 2657 ExecStop=/usr/libexec/tomcat/server stop (code=exited,
status=0/SUCCESS)
 Main PID: 2693 (java)
   CGroup: /system.slice/tomcat.service
   └─2693 /usr/lib/jvm/jre/bin/java
-Djavax.sql.DataSource.Factory=org.apache.commons.dbcp.BasicDataSourceFactory
-classpath
/usr/share/tomcat/bin/bootstrap.jar:/usr/share/tomcat/bin/tomcat-juli.jar:/...

Apr 28 08:35:48 localhost.localdomain server[2693]: 28-Apr-2016 08:35:48.582
INFO [localhost-startStop-1]
org.apache.catalina.startup.HostConfig.deployDirectory Deployment of web
r[2693]: 28-Apr-2016 08:35:48.900 INFO [localhost-startStop-1]
org.apache.catalina.startup.HostConfig.deployDirectory Deploying web
application director.../webapps/docs
Apr 28 08:35:49 localhost.localdomain server[2693]: 28-Apr-2016 08:35:49.154
INFO [localhost-startStop-1] org.apache.jasper.servlet.TldScanner.scanJars At
least one JAR was scanned for TLDs yet contained no T...
Apr 28 08:35:49 localhost.localdomain server[2693]: 28-Apr-2016 08:35:49.157
INFO [localhost-startStop-1]
org.apache.catalina.startup.HostConfig.deployDirectory Deployment of web
application dire...hed in 257 ms
Apr 28 08:35:49 localhost.localdomain server[2693]: 28-Apr-2016 08:35:49.166
INFO [main] org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
["http-nio-8080"]
Apr 28 08:35:49 localhost.localdomain server[2693]: 28-Apr-2016 08:35:49.177
INFO [main] org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
["ajp-nio-8009"]
Apr 28 08:35:49 localhost.localdomain server[2693]: 28-Apr-2016 08:35:49.180
INFO [main] org.apache.catalina.startup.Catalina.start Server startup in 2804
ms


I would think that the status of tomcat with ssl is perfect and is working but, 
looking and catalina.log this is not the case.

grep /var/log/tomcat/catalina.2016-04-28.log 

SEVERE [main] org.apache.tomcat.util.net.jsse.JSSESocketFactory.getStore Failed
to load keystore type JKS with path /root/keystore due to /root/keystore (Keine
Berechtigung)  > (not Allowed).


[EXPECTED RESULTS]

I can expect 2 results:

1) If the configuration is broken for some reason, then systemctl start tomcat
should fail.
[ this could be a difficult approach if we have multiple hosts, or conf. Like
http and https. and https is bad configured , but http well configured.

So i'm thinking  about the second solution.



2)
systemctl status tomcat 

● tomcat.service - Apache Tomcat Web Application Container
   Loaded: loaded (/usr/lib/systemd/system/tomcat.service; disabled; vendor
preset: disabled)
   Active: active (running) since Do 2016-04-28 08:35:44 CEST; 1h 38min ago
  Process: 2657 ExecStop=/usr/libexec/tomcat/server stop (code=exited,
status=0/SUCCESS)
 Main PID: 2693 (java)
   CGroup: /system.slice/tomcat.service

Apr 28 08:35:48 localhost.localdomain server[2693]: 28-Apr-2016 08:35:48.900
INFO [localhost-startStop-1]
org.apache.catalina.startup.HostConfig.deployDirectory Deploying web applica

SEVERE [main] org.apache.tomcat.util.net.jsse.JSSESocketFactory.getStore Failed
to load keystore type JKS with path /root/keystore due to /root/keystore 


2) solution should be that systemctl status should report directly that ths ssl
configuration is failed, and the other configuration are fine, but starting
tomcat, unlike solution 1).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59390] Tomcat systemd/systemctl status tomcat don't show catalina errors.

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59390

dario maiocchi  changed:

   What|Removed |Added

 CC||dmaioc...@suse.com
Version|8.5.x-trunk |8.0.32

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59390] Tomcat systemd/systemctl status tomcat don't show catalina errors.

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59390

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Mark Thomas  ---
The Apache Tomcat project has no control over the status scripts that distros
may wrap around Tomcat.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59390] Tomcat systemd/systemctl status tomcat don't show catalina errors.

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59390

--- Comment #2 from dario maiocchi  ---
Ok thank you Mark for you answer  !  have nice day

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 47214] Inner classes that are explicitly referenced - should not be anonymous

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=47214

--- Comment #3 from Abdessamed MANSOURI  ---
Thank you for your advices and your time :), the problem is i'm not native
english speaker and english is my fourth language, so i didn't find good names,
but i will try my best, thank you again for your time :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 52952] Improve ExtensionValidator handling for embedded scenarios

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=52952

Abdessamed MANSOURI  changed:

   What|Removed |Added

  Attachment #33811|0   |1
is obsolete||

--- Comment #5 from Abdessamed MANSOURI  ---
Created attachment 33813
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33813&action=edit
Patch

Many unit test in the last patch didn't pass cause of many changes in the code,
in this patch i have reverted everything and focusing only in this bug, now all
unit tests pass :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59226] StandardJarScanner ignores jars in manifest Class-path header

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59226

--- Comment #3 from Ignacio del Valle Alles  ---
Hi Mark, this  problem comes for system (application) class loader, that is
responsible of handling class-path entries, not returning manifest jar urls
when executed as java -jar.

If there is a portable way of knowing the executable jar at runtime, the
solution would be trivial: just parse its manifest class path entries. But
there is not (AFAIK)

The suggested change does not get jar entries from the class-path header of the
manifest, instead it infers jar entries from the enumeration of manifest that
it sees (and its parent don't)

It is true that it requires jars referenced in the manifest of the executable
jar to have a manifest in order to be scanned, but this improves the current
behavior of not scanning them at all

For code simplicity I added the same processing for every class loader in
Tomcat, but it is true, that I adds a little overhead, so I have just created a
new pull request that applies the hack only to the system class loader.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59226] StandardJarScanner ignores jars in manifest Class-path header

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59226

--- Comment #4 from Mark Thomas  ---
(In reply to Ignacio del Valle Alles from comment #3)
> Hi Mark, this  problem comes for system (application) class loader, that is
> responsible of handling class-path entries, not returning manifest jar urls
> when executed as java -jar.

No, the problem is wider than that. See the second of my notes in comment #2
above.

> If there is a portable way of knowing the executable jar at runtime, the
> solution would be trivial: just parse its manifest class path entries. But
> there is not (AFAIK).

Not relevant. See above.

> The suggested change does not get jar entries from the class-path header of
> the manifest, instead it infers jar entries from the enumeration of manifest
> that it sees (and its parent don't).
>
> It is true that it requires jars referenced in the manifest of the
> executable jar to have a manifest in order to be scanned, but this improves
> the current behavior of not scanning them at all

It is arguable whether a flawed solution is better than no solution. My
preference is to fix it properly.

> For code simplicity I added the same processing for every class loader in
> Tomcat, but it is true, that I adds a little overhead, so I have just
> created a new pull request that applies the hack only to the system class
> loader.

Limiting the scan to the system class loader is as flawed as including the web
application class loader.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59226] StandardJarScanner ignores jars in manifest Class-path header

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59226

--- Comment #5 from Mark Thomas  ---
Hint: Rather than inferring the JARs added to the class path via one or more
manifests, process the manifests and determine the JARs that have been added.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1741406 - in /tomcat/site/trunk: docs/images/msdn.png docs/tools.html xdocs/images/msdn.png xdocs/tools.xml

2016-04-28 Thread markt 
Author: markt
Date: Thu Apr 28 10:50:45 2016
New Revision: 1741406

URL: http://svn.apache.org/viewvc?rev=1741406&view=rev
Log:
Microsoft are no longer providing committers with MSDN licenses.

Removed:
tomcat/site/trunk/docs/images/msdn.png
tomcat/site/trunk/xdocs/images/msdn.png
Modified:
tomcat/site/trunk/docs/tools.html
tomcat/site/trunk/xdocs/tools.xml

Modified: tomcat/site/trunk/docs/tools.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/tools.html?rev=1741406&r1=1741405&r2=1741406&view=diff
==
--- tomcat/site/trunk/docs/tools.html (original)
+++ tomcat/site/trunk/docs/tools.html Thu Apr 28 10:50:45 2016
@@ -353,21 +353,6 @@ and a committer should be able to fix it
 
 
   
-http://msdn.microsoft.com/"; rel="nofollow">
-  
-  
-Microsoft kindly provide free MSDN licenses to Apache committers that
-  have a requirement for them. MSDN is primarily used to provide build and
-  test environments for the ISAPI redirector and the Windows APR/native
-  connector but it is also used to provide test platforms for Windows
-  specific Tomcat issues such as those related to the Windows 
Installer.
-   
-
-
-
-
-
-  
 http://www.structure101.com/"; rel="nofollow">
   
   

Modified: tomcat/site/trunk/xdocs/tools.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/tools.xml?rev=1741406&r1=1741405&r2=1741406&view=diff
==
--- tomcat/site/trunk/xdocs/tools.xml (original)
+++ tomcat/site/trunk/xdocs/tools.xml Thu Apr 28 10:50:45 2016
@@ -88,16 +88,6 @@ and a committer should be able to fix it
   
 
 
-  http://msdn.microsoft.com/"; rel="nofollow">
-  
-  Microsoft kindly provide free MSDN licenses to Apache committers that
-  have a requirement for them. MSDN is primarily used to provide build and
-  test environments for the ISAPI redirector and the Windows APR/native
-  connector but it is also used to provide test platforms for Windows
-  specific Tomcat issues such as those related to the Windows 
Installer.
-   
-
-
   http://www.structure101.com/"; rel="nofollow">
   
   Headway software kindly provide free licenses for Structure 101 to 
open



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1741409 - /tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

2016-04-28 Thread markt 
Author: markt
Date: Thu Apr 28 11:11:23 2016
New Revision: 1741409

URL: http://svn.apache.org/viewvc?rev=1741409&view=rev
Log:
Fix another root cause of this test failing (primarily on Gump).
If the server is really slow (and Gump is) the session might not have been 
opened by the time the test checked to see if it had been closed. This led to a 
failure since the server code was still processing when the test ended.

Modified:
tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

Modified: 
tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java?rev=1741409&r1=1741408&r2=1741409&view=diff
==
--- tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java 
(original)
+++ tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java 
Thu Apr 28 11:11:23 2016
@@ -60,10 +60,20 @@ public class TestCloseBug58624 extends W
 URI uri = new URI("ws://localhost:" + getPort() + 
Bug58624ServerConfig.PATH);
 
 Session session = wsContainer.connectToServer(client, uri);
+
+// Wait for session to open on the server
+int count = 0;
+while (count < 50 && Bug58624ServerEndpoint.getOpenSessionCount() == 
0) {
+count++;
+Thread.sleep(100);
+}
+Assert.assertNotEquals(0,  
Bug58624ServerEndpoint.getOpenSessionCount());
+
+// Now close the session
 session.close();
 
 // Wait for session to close on the server
-int count = 0;
+count = 0;
 while (count < 50 && Bug58624ServerEndpoint.getOpenSessionCount() > 0) 
{
 count++;
 Thread.sleep(100);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1741410 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

2016-04-28 Thread markt 
Author: markt
Date: Thu Apr 28 11:12:00 2016
New Revision: 1741410

URL: http://svn.apache.org/viewvc?rev=1741410&view=rev
Log:
Fix another root cause of this test failing (primarily on Gump).
If the server is really slow (and Gump is) the session might not have been 
opened by the time the test checked to see if it had been closed. This led to a 
failure since the server code was still processing when the test ended.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Apr 28 11:12:00 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409

Modified: 
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java?rev=1741410&r1=1741409&r2=1741410&view=diff
==
--- 
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
 Thu Apr 28 11:12:00 2016
@@ -60,10 +60,20 @@ public class TestCloseBug58624 extends W
 URI uri = new URI("ws://localhost:" + getPort() + 
Bug58624ServerConfig.PATH);
 
 Session session = wsContainer.connectToServer(client, uri);
+
+// Wait for session to open on the server
+int count = 0;
+while (count < 50 && Bug58624ServerEndpoint.getOpenSessionCount() == 
0) {
+count++;
+Thread.sleep(100);
+}
+Assert.assertNotEquals(0,  
Bug58624ServerEndpoint.getOpenSessionCount());
+
+// Now close the session
 session.close();
 
 // Wait for session to close on the server
-int count = 0;
+count = 0;
 while (count < 50 && Bug58624ServerEndpoint.getOpenSessionCount() > 0) 
{
 count++;
 Thread.sleep(100);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1741411 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

2016-04-28 Thread markt 
Author: markt
Date: Thu Apr 28 11:12:24 2016
New Revision: 1741411

URL: http://svn.apache.org/viewvc?rev=1741411&view=rev
Log:
Fix another root cause of this test failing (primarily on Gump).
If the server is really slow (and Gump is) the session might not have been 
opened by the time the test checked to see if it had been closed. This led to a 
failure since the server code was still processing when the test ended.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Apr 28 11:12:24 2016
@@ -1,2 +1,2 @@
 /tomcat/tc8.5.x/trunk:1735042,1737966
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 
7,1684549-1684550,1685556,1685591,1685739,1685744,1685772,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1687544,1687551,1688563,1688841,1688878,165,1688896,1688901,1689345-16893

svn commit: r1741412 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

2016-04-28 Thread markt 
Author: markt
Date: Thu Apr 28 11:12:54 2016
New Revision: 1741412

URL: http://svn.apache.org/viewvc?rev=1741412&view=rev
Log:
Fix another root cause of this test failing (primarily on Gump).
If the server is really slow (and Gump is) the session might not have been 
opened by the time the test checked to see if it had been closed. This led to a 
failure since the server code was still processing when the test ended.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)

tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Apr 28 11:12:54 2016
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702
 
744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1726171-1
 
726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217
-/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804,1740811,1740981,1741165,1741174,1741182,1741191,1741203,1741209,1741226,1741233
-/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-

buildbot failure in on tomcat-trunk

2016-04-28 Thread buildbot 
The Buildbot has detected a new failure on builder tomcat-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/1318

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1741409
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59226] StandardJarScanner ignores jars in manifest Class-path header

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59226

--- Comment #6 from Ignacio del Valle Alles  ---
(In reply to Mark Thomas from comment #4)
> (In reply to Ignacio del Valle Alles from comment #3)
> > Hi Mark, this  problem comes for system (application) class loader, that is
> > responsible of handling class-path entries, not returning manifest jar urls
> > when executed as java -jar.
> 
> No, the problem is wider than that. See the second of my notes in comment #2
> above.
> 
> > If there is a portable way of knowing the executable jar at runtime, the
> > solution would be trivial: just parse its manifest class path entries. But
> > there is not (AFAIK).
> 
> Not relevant. See above.
> 
> > The suggested change does not get jar entries from the class-path header of
> > the manifest, instead it infers jar entries from the enumeration of manifest
> > that it sees (and its parent don't).
> >
> > It is true that it requires jars referenced in the manifest of the
> > executable jar to have a manifest in order to be scanned, but this improves
> > the current behavior of not scanning them at all
> 
> It is arguable whether a flawed solution is better than no solution. My
> preference is to fix it properly.
> 
> > For code simplicity I added the same processing for every class loader in
> > Tomcat, but it is true, that I adds a little overhead, so I have just
> > created a new pull request that applies the hack only to the system class
> > loader.
> 
> Limiting the scan to the system class loader is as flawed as including the
> web application class loader.

My reasoning was based on the wrong assumption that these entries were only
read by the System class loader and only when executed as "java -jar" (don't
ask me why). So yes, the solution is simpler and can be implemented just by
scanning the manifest. I'll work on it and send a new PR

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 47214] Inner classes that are explicitly referenced - should not be anonymous

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=47214

--- Comment #4 from Christopher Schultz  ---
Your English is great. If there is confusion, we will ask for clarification.

Don't feel bad if we ask you to re-do your patch(es) several times. The goal is
to get the best patch possible, and make you into a successful patch-writer ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

OpenSSL issues and May releases.

2016-04-28 Thread Mark Thomas 
OpenSSL has just announced a security release next week. We won't know until 
then if any of the issues affect tomcat-native.

My current plan is not to delay the 9.0.x etc. tags for this. We can always 
make a new tomcat-native release if necessary. That said if the OpenSSL release 
drops before the tag we can easily pick it up if we need to.

Mark

[Bug 59334] .NET Application Pools requests hang because Jakarta/Tomcat uses a Named Mutex that is currently owned by a different process

2016-04-28 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59334

--- Comment #5 from Murilo  ---
Here's what's going on:

First callstack is:

00 `10b7deb8 `76ff9f20 ntdll!ZwWaitForSingleObject+0xa 
01 `10b7dec0 0001`8001b178 kernel32!WaitForSingleObjectEx+0x9c 
02 `10b7df80 07fe`fb7e1c9b isapi_redirect!HttpFilterProc+0x148
[c:\workplace\tomcat-connectors-1.2.40-src\native\iis\jk_isapi_plugin.c @ 2172]
03 `10b7e400 07fe`fb7e1f2d
filter!W3_FILTER_CONTEXT::NotifyFilters+0x149


This thread owns the critical section blocking everyone else.

Looking at source code we see that we’re stuck here:


if (!is_mapread) {
WaitForSingleObject(init_cs, INFINITE);
if (!is_mapread)
is_mapread = init_jk(serverName);
ReleaseMutex(init_cs);
}


We're stuck on that WaitForSingleObject line.  This code waits for “init_cs”
which is a Named Mutex to be released.  But this Named Mutex is currently
owned:

Handle 0278
  Type   Mutant
  Attributes 0
  GrantedAccess 0x1f0001:
 Delete,ReadControl,WriteDac,WriteOwner,Synch
 QueryState
  HandleCount  4
  PointerCount   8
  Name
\BaseNamedObjects\JK_C__PROGRAM_FILES_APACHE_SOFTWARE_FOUNDATION_JAKARTA_ISAPI_REDIRECTOR_BIN_ISAPI_REDIRECT_MUTEX
  Object specific information
Mutex is Owned
Mutant Owner 3048.2198


Note the owner is a thread inside this same process.  Owner PID is 0x3048
(decimal 12360 which is PID of this same process).  Thread 0x2198 is thread 3.

This is thread 3 in this same dump shows that the Named Mutex has leaked as its
callstack shows an idle thread not doing anything and with this callstack will
never release anything.


0:003> k
# Child-SP  RetAddr   Call Site
00 `022efa08 `76fedfbc ntdll!ZwRemoveIoCompletion+0xa
01 `022efa10 07fe`f76f2b0e kernel32!GetQueuedCompletionStatus+0x48
02 `022efa70 07fe`f76f1b95
w3tp!THREAD_POOL_DATA::ThreadPoolThread+0x56
03 `022efad0 `76fea4bd
w3tp!THREAD_MANAGER::ThreadManagerThread+0x5d
04 `022efb00 `77356461 kernel32!BaseThreadInitThunk+0xd
05 `022efb30 ` ntdll!RtlUserThreadStart+0x1d


Some code ran on this thread (inside Jakarta) that took ownership of the Named
Mutex and then something happened and that code did not release that Named
Mutex… so now this whole process is stuck.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1741501 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2016-04-28 Thread markt 
Author: markt
Date: Thu Apr 28 19:55:02 2016
New Revision: 1741501

URL: http://svn.apache.org/viewvc?rev=1741501&view=rev
Log:
Work around a known issue in OpenSSL 
(https://github.com/openssl/openssl/issues/188) that does not permit the TLS 
handshake to be failed if the ALPN negotiation fails.

Modified:
tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java?rev=1741501&r1=1741500&r2=1741501&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java Thu Apr 28 
19:55:02 2016
@@ -733,10 +733,27 @@ public abstract class AbstractProtocolhttp://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1741501&r1=1741500&r2=1741501&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Apr 28 19:55:02 2016
@@ -214,6 +214,11 @@
 JSSE+OpenSSL with the certificate chain stored in a Java KeyStore.
 (markt)
   
+  
+Work around https://github.com/openssl/openssl/issues/188";>a
+known issue in OpenSSL that does not permit the TLS handshake to be
+failed if the ALPN negotiation fails. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1741503 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2016-04-28 Thread markt 
Author: markt
Date: Thu Apr 28 19:56:49 2016
New Revision: 1741503

URL: http://svn.apache.org/viewvc?rev=1741503&view=rev
Log:
Work around a known issue in OpenSSL 
(https://github.com/openssl/openssl/issues/188) that does not permit the TLS 
handshake to be failed if the ALPN negotiation fails.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Apr 28 19:56:49 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501

Modified: tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java?rev=1741503&r1=1741502&r2=1741503&view=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java Thu Apr 
28 19:56:49 2016
@@ -733,10 +733,27 @@ public abstract class AbstractProtocolhttp://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1741503&r1=1741502&r2=1741503&view=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Thu Apr 28 19:56:49 2016
@@ -207,6 +207,11 @@
 JSSE+OpenSSL with the certificate chain stored in a Java KeyStore.
 (markt)
   
+  
+Work around https://github.com/openssl/openssl/issues/188";>a
+known issue in OpenSSL that does not permit the TLS handshake to be
+failed if the ALPN negotiation fails. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org