[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 3 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 56 mins 35 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160425-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160425.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160425-native-src.tar.gz
 -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute
 .test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20160425/bin/openssl
 -Dexecute.test.apr=false -Dtest.excludePerformance=true 
-Dexecute.test.nio2=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/g

Re: [VOTE] Release Apache Tomcat Native 1.2.6

[Rémy Maucherat]

2016-04-19 23:32 GMT+02:00 Mark Thomas :

> Version 1.2.6 includes the following changes:
>
> - Add support for using Java keystores for certificate chains
> - Fixes to allow continued building with master
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.6 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...
>
> Works for OpenSSL and APR. Good job on the OpenSSL 1.1 support and finding
out the API changes.

Rémy

svn commit: r1740803 - in /tomcat/trunk/test/org/apache/tomcat/websocket/server: TestCloseBug58264.java TestCloseBug58624.java

[markt]

Author: markt
Date: Mon Apr 25 10:56:52 2016
New Revision: 1740803

URL: http://svn.apache.org/viewvc?rev=1740803&view=rev
Log:
Correct typo in text class name

Added:
tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
  - copied, changed from r1740802, 
tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58264.java
Removed:
tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58264.java

Copied: 
tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java 
(from r1740802, 
tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58264.java)
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java?p2=tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java&p1=tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58264.java&r1=1740802&r2=1740803&rev=1740803&view=diff
==
--- tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58264.java 
(original)
+++ tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java 
Mon Apr 25 10:56:52 2016
@@ -39,7 +39,7 @@ import org.apache.catalina.servlets.Defa
 import org.apache.catalina.startup.Tomcat;
 import org.apache.tomcat.websocket.WebSocketBaseTest;
 
-public class TestCloseBug58264 extends WebSocketBaseTest {
+public class TestCloseBug58624 extends WebSocketBaseTest {
 
 @Test
 public void testOnErrorNotCalledWhenClosingConnection() throws Throwable {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1740804 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/websocket/server/TestCloseBug58264.java test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

[markt]

Author: markt
Date: Mon Apr 25 10:57:48 2016
New Revision: 1740804

URL: http://svn.apache.org/viewvc?rev=1740804&view=rev
Log:
Correct typo in text class name

Added:

tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
  - copied unchanged from r1740803, 
tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
Removed:

tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58264.java
Modified:
tomcat/tc8.5.x/trunk/   (props changed)

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Apr 25 10:57:48 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1740805 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/tomcat/websocket/server/TestCloseBug58264.java test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

[markt]

Author: markt
Date: Mon Apr 25 10:57:58 2016
New Revision: 1740805

URL: http://svn.apache.org/viewvc?rev=1740805&view=rev
Log:
Correct typo in text class name

Added:

tomcat/tc8.0.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
  - copied unchanged from r1740803, 
tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
Removed:

tomcat/tc8.0.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58264.java
Modified:
tomcat/tc8.0.x/trunk/   (props changed)

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Apr 25 10:57:58 2016
@@ -1,2 +1,2 @@
 /tomcat/tc8.5.x/trunk:1735042,1737966
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 
7,1684549-1684550,1685556,1685591,1685739,1685744,1685772,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1687544,1687551,1688563,1688841,1688878,165,1688896,1688901,1689345-1689346,1689357,1689656,1689675-1689677,16896

svn commit: r1740806 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/websocket/server/TestCloseBug58264.java test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

[markt]

Author: markt
Date: Mon Apr 25 10:58:39 2016
New Revision: 1740806

URL: http://svn.apache.org/viewvc?rev=1740806&view=rev
Log:
Correct typo in text class name

Added:

tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
  - copied unchanged from r1740804, 
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
Removed:

tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58264.java
Modified:
tomcat/tc7.0.x/trunk/   (props changed)

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Apr 25 10:58:39 2016
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702
 
744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1726171-1
 
726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726
-/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536
-/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-

svn commit: r1740810 - /tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

[markt]

Author: markt
Date: Mon Apr 25 11:14:08 2016
New Revision: 1740810

URL: http://svn.apache.org/viewvc?rev=1740810&view=rev
Log:
Add a wait for the session to close on the server. Some failures were observed 
on Gump when this hadn't happened by the time the test ended.
Add a check that no errors occurred on the server.

Modified:
tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

Modified: 
tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java?rev=1740810&r1=1740809&r2=1740810&view=diff
==
--- tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java 
(original)
+++ tomcat/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java 
Mon Apr 25 11:14:08 2016
@@ -17,6 +17,7 @@
 package org.apache.tomcat.websocket.server;
 
 import java.net.URI;
+import java.util.concurrent.atomic.AtomicInteger;
 
 import javax.servlet.ServletContextEvent;
 import javax.websocket.ClientEndpoint;
@@ -32,6 +33,7 @@ import javax.websocket.WebSocketContaine
 import javax.websocket.server.ServerContainer;
 import javax.websocket.server.ServerEndpointConfig;
 
+import org.junit.Assert;
 import org.junit.Test;
 
 import org.apache.catalina.Context;
@@ -60,6 +62,17 @@ public class TestCloseBug58624 extends W
 Session session = wsContainer.connectToServer(client, uri);
 session.close();
 
+// Wait for session to close on the server
+int count = 0;
+while (count < 50 && Bug58624ServerEndpoint.getOpenSessionCount() > 0) 
{
+count++;
+Thread.sleep(100);
+}
+Assert.assertEquals(0,  Bug58624ServerEndpoint.getOpenSessionCount());
+
+// Ensure no errors were reported on the server
+Assert.assertEquals(0,  Bug58624ServerEndpoint.getErrorCount());
+
 if (client.getError() != null) {
 throw client.getError();
 }
@@ -107,9 +120,20 @@ public class TestCloseBug58624 extends W
 
 public static class Bug58624ServerEndpoint {
 
+private static AtomicInteger openSessionCount = new AtomicInteger(0);
+private static AtomicInteger errorCount = new AtomicInteger(0);
+
+public static int getOpenSessionCount() {
+return openSessionCount.get();
+}
+
+public static int getErrorCount() {
+return errorCount.get();
+}
+
 @OnOpen
 public void onOpen() {
-System.out.println("Session opened");
+openSessionCount.incrementAndGet();
 }
 
 
@@ -121,14 +145,14 @@ public class TestCloseBug58624 extends W
 
 @OnError
 public void onError(Throwable t) {
-System.out.println("HERE");
+errorCount.incrementAndGet();
 t.printStackTrace();
 }
 
 
 @OnClose
-public void onClose(CloseReason cr) {
-System.out.println("Session closed: " + cr);
+public void onClose(@SuppressWarnings("unused") CloseReason cr) {
+openSessionCount.decrementAndGet();
 }
 }
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1740811 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

[markt]

Author: markt
Date: Mon Apr 25 11:15:14 2016
New Revision: 1740811

URL: http://svn.apache.org/viewvc?rev=1740811&view=rev
Log:
Add a wait for the session to close on the server. Some failures were observed 
on Gump when this hadn't happened by the time the test ended.
Add a check that no errors occurred on the server.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Apr 25 11:15:14 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810

Modified: 
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java?rev=1740811&r1=1740810&r2=1740811&view=diff
==
--- 
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java
 Mon Apr 25 11:15:14 2016
@@ -17,6 +17,7 @@
 package org.apache.tomcat.websocket.server;
 
 import java.net.URI;
+import java.util.concurrent.atomic.AtomicInteger;
 
 import javax.servlet.ServletContextEvent;
 import javax.websocket.ClientEndpoint;
@@ -32,6 +33,7 @@ import javax.websocket.WebSocketContaine
 import javax.websocket.server.ServerContainer;
 import javax.websocket.server.ServerEndpointConfig;
 
+import org.junit.Assert;
 import org.junit.Test;
 
 import org.apache.catalina.Context;
@@ -60,6 +62,17 @@ public class TestCloseBug58624 extends W
 Session session = wsContainer.connectToServer(client, uri);
 session.close();
 
+// Wait for session to close on the server
+int count = 0;
+while (count < 50 && Bug58624ServerEndpoint.getOpenSessionCount() > 0) 
{
+count++;
+Thread.sleep(100);
+}
+Assert.assertEquals(0,  Bug58624ServerEndpoint.getOpenSessionCount());
+
+// Ensure no errors were reported on the server
+Assert.assertEquals(0,  Bug58624ServerEndpoint.getErrorCount());
+
 if (client.getError() != null) {
 throw client.getError();
 }
@@ -107,9 +120,20 @@ public class TestCloseBug58624 extends W
 
 public static class Bug58624ServerEndpoint {
 
+private static AtomicInteger openSessionCount = new AtomicInteger(0);
+private static AtomicInteger errorCount = new AtomicInteger(0);
+
+public static int getOpenSessionCount() {
+return openSessionCount.get();
+}
+
+public static int getErrorCount() {
+return errorCount.get();
+}
+
 @OnOpen
 public void onOpen() {
-System.out.println("Session opened");
+openSessionCount.incrementAndGet();
 }
 
 
@@ -121,14 +145,14 @@ public class TestCloseBug58624 extends W
 
 @OnError
 public void onError(Throwable t) {
-System.out.println("HERE");
+errorCount.incrementAndGet();
 t.printStackTrace();
 }
 
 
 @OnClose
-public void onClose(CloseReason cr) {
-System.out.println("Session closed: " + cr);
+public void onClo

svn commit: r1740812 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

[markt]

Author: markt
Date: Mon Apr 25 11:15:26 2016
New Revision: 1740812

URL: http://svn.apache.org/viewvc?rev=1740812&view=rev
Log:
Add a wait for the session to close on the server. Some failures were observed 
on Gump when this hadn't happened by the time the test ended.
Add a check that no errors occurred on the server.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Apr 25 11:15:26 2016
@@ -1,2 +1,2 @@
 /tomcat/tc8.5.x/trunk:1735042,1737966
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 
7,1684549-1684550,1685556,1685591,1685739,1685744,1685772,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1687544,1687551,1688563,1688841,1688878,165,1688896,1688901,1689345-1689346,1689357,1689656,1689675-1689677,1689679,1689687,1689825,1689856,1689918,1690011,1690021,1690054,16

svn commit: r1740813 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

[markt]

Author: markt
Date: Mon Apr 25 11:16:09 2016
New Revision: 1740813

URL: http://svn.apache.org/viewvc?rev=1740813&view=rev
Log:
Add a wait for the session to close on the server. Some failures were observed 
on Gump when this hadn't happened by the time the test ended.
Add a check that no errors occurred on the server.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)

tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/server/TestCloseBug58624.java

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Apr 25 11:16:09 2016
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702
 
744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1726171-1
 
726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726
-/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804
-/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222329,1222332-1222401,1222405-1222795,1222850-1222950,12229

buildbot failure in on tomcat-8-trunk

[buildbot]

The Buildbot has detected a new failure on builder tomcat-8-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/585

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1740812
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59219] AsyncListener#onError not called on exception during async processing

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59219

Abdessamed MANSOURI  changed:

   What|Removed |Added

  Attachment #33796|0   |1
is obsolete||

--- Comment #13 from Abdessamed MANSOURI  ---
Created attachment 33802
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33802&action=edit
Unit test of bug 59219

Inserting timeout.

About refactoring, of course there's some duplicate code as the servlets,
ServletB can do what ServletA do, but i think like its better, because its more
clear and more explicit for point 2, or not?? :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1740841 - /tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java

[markt]

Author: markt
Date: Mon Apr 25 14:07:31 2016
New Revision: 1740841

URL: http://svn.apache.org/viewvc?rev=1740841&view=rev
Log:
Fix intermittent CI failure

Modified:

tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java?rev=1740841&r1=1740840&r2=1740841&view=diff
==
--- 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
 (original)
+++ 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
 Mon Apr 25 14:07:31 2016
@@ -42,6 +42,7 @@ public class Nio2ServletInputStream exte
 private boolean flipped = false;
 private volatile boolean readPending = false;
 private volatile boolean interest = true;
+private volatile boolean swallowEOF = false;
 
 public Nio2ServletInputStream(SocketWrapper wrapper, 
AbstractEndpoint endpoint0) {
 this.endpoint = endpoint0;
@@ -52,7 +53,7 @@ public class Nio2ServletInputStream exte
 public void completed(Integer nBytes, SocketWrapper 
attachment) {
 boolean notify = false;
 synchronized (completionHandler) {
-if (nBytes.intValue() < 0) {
+if (!swallowEOF && nBytes.intValue() < 0) {
 failed(new EOFException(), attachment);
 } else {
 readPending = false;
@@ -180,6 +181,11 @@ public class Nio2ServletInputStream exte
 
 @Override
 protected void doClose() throws IOException {
+// Closing the channel will trigger an EOF. This is expected so set the
+// flag to swallow it.
+if (readPending) {
+swallowEOF = true;
+}
 channel.close();
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59344] PEM file support for JSSE

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59344

--- Comment #11 from Remy Maucherat  ---
This does create a side effect on the configuration checking though, which
becomes rather messy. Basically, all connectors can now use the OpenSSL style,
but they cannot mix and match for the certificate definition.

So I now agree that the OpenSSL type should be removed from CertificateKeyFile,
CertificateFile and CertificateChainFile, but I'll add an extra check to cause
an error if for example both CertificateKeystorePassword and
CertificateChainFile are defined.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-bio (in module tomcat-8.0.x) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-bio has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-bio :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-bio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-BIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-BIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-BIO/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-bio/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-bio.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-bio (Type: Build)
Work ended in a state of : Failed
Elapsed: 48 mins 50 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-BIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160425-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160425.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160425-native-src.tar.gz
 -Dtest.temp=output/test-tmp-BIO -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dtest.ope
 nssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20160425/bin/openssl 
-Dexecute.test.bio=true -Dexecute.test.apr=false -Dtest.excludePerformance=true 
-Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-8.0.x/out

tomcat 7 broken on java 7 for linux distro

[Romain Manni-Bucau]

Hi guys,

tomcat uses ConcurrentHashMap in few places and doesn't rely on
ConcurrentMap API  (ApplicationContext IIRC for instance was the case I
encounter). This means if you build tomcat with java 8 and run on java 7 it
is broken cause of this new KeyViewSet API used on java 8 (returned type is
used for method lookup at runtime).

Why would you do it? Not sure but several linux distribution do it.

I know we could easily ask all linux distro to build using java 7 but at
least fedora/redhat/ubuntu are impacted and tomcat can easily without
loosing any feature make it passing for that case using the interface
instead of the implementation as field type.

Do you think it is possible or would you just move it over linux distro? If
this last one: how to ensure we don't get more regression in the future due
to another build process for user binaries?

Thanks,
Romain Manni-Bucau
@rmannibucau  |  Blog
 | Github  |
LinkedIn  | Tomitriber
 | JavaEE Factory

Re: tomcat 7 broken on java 7 for linux distro

[Emmanuel Bourg]

Le 25/04/2016 17:42, Romain Manni-Bucau a écrit :

> I know we could easily ask all linux distro to build using java 7 but at
> least fedora/redhat/ubuntu are impacted and tomcat can easily without
> loosing any feature make it passing for that case using the interface
> instead of the implementation as field type.

Debian and Ubuntu usually build and run Tomcat with the same version of
Java. For example Ubuntu 16.04 LTS and the upcoming Debian 9 default to
Java 8 (Java 7 has been removed). Tomcat 7 is no longer supported for
these versions (Ubuntu switched to Tomcat 8 and Debian will remove it in
a few months, the general rule is to keep only one version of Java and
Tomcat per major release). In the previous release Tomcat 7 was built
with Java 7.

This issue may arise if the user installs its own Java 7 and use it to
run Tomcat instead of the JRE provided by the distribution. I can
address that in Debian by ensuring the package dependencies are more
strict (please file a bug against the tomcat8 package if it's affected too).

Emmanuel Bourg


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: tomcat 7 broken on java 7 for linux distro

[Romain Manni-Bucau]

Only met it on previous LTS (16.04 is still fresh so was 14 one). So sounds
it was a no luck case.

Maybe a page on tomcat website dealing with main integrations and things to
check (/etc/defaults/tomcatX JAVA_HOME etc...) can be enough for this
issue. What do you think?


Romain Manni-Bucau
@rmannibucau  |  Blog
 | Github  |
LinkedIn  | Tomitriber
 | JavaEE Factory


2016-04-25 18:18 GMT+02:00 Emmanuel Bourg :

> Le 25/04/2016 17:42, Romain Manni-Bucau a écrit :
>
> > I know we could easily ask all linux distro to build using java 7 but at
> > least fedora/redhat/ubuntu are impacted and tomcat can easily without
> > loosing any feature make it passing for that case using the interface
> > instead of the implementation as field type.
>
> Debian and Ubuntu usually build and run Tomcat with the same version of
> Java. For example Ubuntu 16.04 LTS and the upcoming Debian 9 default to
> Java 8 (Java 7 has been removed). Tomcat 7 is no longer supported for
> these versions (Ubuntu switched to Tomcat 8 and Debian will remove it in
> a few months, the general rule is to keep only one version of Java and
> Tomcat per major release). In the previous release Tomcat 7 was built
> with Java 7.
>
> This issue may arise if the user installs its own Java 7 and use it to
> run Tomcat instead of the JRE provided by the distribution. I can
> address that in Debian by ensuring the package dependencies are more
> strict (please file a bug against the tomcat8 package if it's affected
> too).
>
> Emmanuel Bourg
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: tomcat 7 broken on java 7 for linux distro

[Stefan Huehner]

On Mon, Apr 25, 2016 at 06:18:53PM +0200, Emmanuel Bourg wrote:
> Le 25/04/2016 17:42, Romain Manni-Bucau a écrit :
> 
> > I know we could easily ask all linux distro to build using java 7 but at
> > least fedora/redhat/ubuntu are impacted and tomcat can easily without
> > loosing any feature make it passing for that case using the interface
> > instead of the implementation as field type.
> 
> Debian and Ubuntu usually build and run Tomcat with the same version of
> Java. For example Ubuntu 16.04 LTS and the upcoming Debian 9 default to
> Java 8 (Java 7 has been removed). Tomcat 7 is no longer supported for
> these versions (Ubuntu switched to Tomcat 8 and Debian will remove it in
> a few months, the general rule is to keep only one version of Java and
> Tomcat per major release). In the previous release Tomcat 7 was built
> with Java 7.
> 
> This issue may arise if the user installs its own Java 7 and use it to
> run Tomcat instead of the JRE provided by the distribution. I can
> address that in Debian by ensuring the package dependencies are more
> strict (please file a bug against the tomcat8 package if it's affected too).

Hi,
i'd like to jump in as a user having such a use case.

In our jenkins systems we daily test our software against various java+tomcat 
versions we still (need to) support.

I.e. java 6..8 and tomcat 6..8

So far without planning we have kind of paired
1.) java6 + tomcat 6 (using Ubuntu 12.04 LTS)
2.) java7 + tomcat 7 (using Ubuntu 14.04 LTS)
3.) java8 + tomcat 7 (by using 16.04 LTS in future)

So never noticed that issue above.

However as system requirement of tomcat allowed seems to allow to mix it would 
be nice to keep that flexibility.

If not maybe we should add a note here:
http://tomcat.apache.org/whichversion.html

By adding the restriction there to let people know.

Note that was even possible inside distro as i.e. Ubuntu 14.04  shipped java 6 
+ 7 (if you enable universe part of the repo).

No big deal to us, but i think important to document.

Regards,
Stefan Hühner

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: tomcat 7 broken on java 7 for linux distro

[Emmanuel Bourg]

Le 25/04/2016 18:32, Romain Manni-Bucau a écrit :
> Only met it on previous LTS (16.04 is still fresh so was 14 one). So sounds
> it was a no luck case.

That's odd because Ubuntu 14.04 LTS doesn't have Java 8 [1]. It first
appeared in Ubuntu 15.10. Tomcat 7 in Ubuntu 14.04 LTS is built with Java 7.

Emmanuel Bourg

http://packages.ubuntu.com/search?keywords=openjdk-8-jre-headless


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: tomcat 7 broken on java 7 for linux distro

[Romain Manni-Bucau]

Just to make it clearer: 14.04 had java 7 as expected but tomcat7 package
was compiled with java 8.


Romain Manni-Bucau
@rmannibucau  |  Blog
 | Github  |
LinkedIn  | Tomitriber
 | JavaEE Factory


2016-04-25 18:45 GMT+02:00 Emmanuel Bourg :

> Le 25/04/2016 18:32, Romain Manni-Bucau a écrit :
> > Only met it on previous LTS (16.04 is still fresh so was 14 one). So
> sounds
> > it was a no luck case.
>
> That's odd because Ubuntu 14.04 LTS doesn't have Java 8 [1]. It first
> appeared in Ubuntu 15.10. Tomcat 7 in Ubuntu 14.04 LTS is built with Java
> 7.
>
> Emmanuel Bourg
>
> http://packages.ubuntu.com/search?keywords=openjdk-8-jre-headless
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

svn commit: r1740874 - /tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java

[markt]

Author: markt
Date: Mon Apr 25 18:18:32 2016
New Revision: 1740874

URL: http://svn.apache.org/viewvc?rev=1740874&view=rev
Log:
Revert r1740841. This isn't fixing the root cause.

Modified:

tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java?rev=1740874&r1=1740873&r2=1740874&view=diff
==
--- 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
 (original)
+++ 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
 Mon Apr 25 18:18:32 2016
@@ -42,7 +42,6 @@ public class Nio2ServletInputStream exte
 private boolean flipped = false;
 private volatile boolean readPending = false;
 private volatile boolean interest = true;
-private volatile boolean swallowEOF = false;
 
 public Nio2ServletInputStream(SocketWrapper wrapper, 
AbstractEndpoint endpoint0) {
 this.endpoint = endpoint0;
@@ -53,7 +52,7 @@ public class Nio2ServletInputStream exte
 public void completed(Integer nBytes, SocketWrapper 
attachment) {
 boolean notify = false;
 synchronized (completionHandler) {
-if (!swallowEOF && nBytes.intValue() < 0) {
+if (nBytes.intValue() < 0) {
 failed(new EOFException(), attachment);
 } else {
 readPending = false;
@@ -181,11 +180,6 @@ public class Nio2ServletInputStream exte
 
 @Override
 protected void doClose() throws IOException {
-// Closing the channel will trigger an EOF. This is expected so set the
-// flag to swallow it.
-if (readPending) {
-swallowEOF = true;
-}
 channel.close();
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-8-trunk

[buildbot]

The Buildbot has detected a restored build on builder tomcat-8-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/587

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1740874
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1740876 - /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

[markt]

Author: markt
Date: Mon Apr 25 19:03:25 2016
New Revision: 1740876

URL: http://svn.apache.org/viewvc?rev=1740876&view=rev
Log:
Port fix for multiple socket close warning from trunk

Modified:
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

Modified: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java?rev=1740876&r1=1740875&r2=1740876&view=diff
==
--- tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java 
(original)
+++ tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Mon 
Apr 25 19:03:25 2016
@@ -633,27 +633,38 @@ public class Nio2Endpoint extends Abstra
 processSocket0(socket, status, false);
 }
 }
+} catch (Throwable e) {
+ExceptionUtils.handleThrowable(e);
+if (log.isDebugEnabled()) log.error("",e);
+}
+try {
 handler.release(socket);
-try {
-if (socket.getSocket() != null) {
-socket.getSocket().close(true);
-}
-} catch (Exception e){
-if (log.isDebugEnabled()) {
-log.debug(sm.getString(
-"endpoint.debug.socketCloseFail"), e);
+} catch (Throwable e) {
+ExceptionUtils.handleThrowable(e);
+if (log.isDebugEnabled()) log.error("",e);
+}
+try {
+if (socket.getSocket() != null) {
+synchronized (socket.getSocket()) {
+if (socket.getSocket() != null && 
socket.getSocket().isOpen()) {
+countDownConnection();
+socket.getSocket().close(true);
+}
 }
 }
+} catch (Exception e){
+if (log.isDebugEnabled()) {
+log.debug(sm.getString(
+"endpoint.debug.socketCloseFail"), e);
+}
+}
+try {
 Nio2SocketWrapper nio2Socket = (Nio2SocketWrapper) socket;
-try {
-if (nio2Socket.getSendfileData() != null
-&& nio2Socket.getSendfileData().fchannel != null
-&& nio2Socket.getSendfileData().fchannel.isOpen()) {
-nio2Socket.getSendfileData().fchannel.close();
-}
-} catch (Exception ignore) {
+if (nio2Socket.getSendfileData() != null
+&& nio2Socket.getSendfileData().fchannel != null
+&& nio2Socket.getSendfileData().fchannel.isOpen()) {
+nio2Socket.getSendfileData().fchannel.close();
 }
-countDownConnection();
 } catch (Throwable e) {
 ExceptionUtils.handleThrowable(e);
 if (log.isDebugEnabled()) log.error("",e);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1740877 - /tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java

[markt]

Author: markt
Date: Mon Apr 25 19:06:07 2016
New Revision: 1740877

URL: http://svn.apache.org/viewvc?rev=1740877&view=rev
Log:
Better fix for failing unit test

Modified:

tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java?rev=1740877&r1=1740876&r2=1740877&view=diff
==
--- 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
 (original)
+++ 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
 Mon Apr 25 19:06:07 2016
@@ -42,6 +42,7 @@ public class Nio2ServletInputStream exte
 private boolean flipped = false;
 private volatile boolean readPending = false;
 private volatile boolean interest = true;
+private volatile boolean closed = true;
 
 public Nio2ServletInputStream(SocketWrapper wrapper, 
AbstractEndpoint endpoint0) {
 this.endpoint = endpoint0;
@@ -53,7 +54,11 @@ public class Nio2ServletInputStream exte
 boolean notify = false;
 synchronized (completionHandler) {
 if (nBytes.intValue() < 0) {
-failed(new EOFException(), attachment);
+if (closed) {
+readPending = false;
+} else {
+failed(new EOFException(), attachment);
+}
 } else {
 readPending = false;
 if (interest && !Nio2Endpoint.isInline()) {
@@ -180,6 +185,7 @@ public class Nio2ServletInputStream exte
 
 @Override
 protected void doClose() throws IOException {
+closed = true;
 channel.close();
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-8-trunk

[buildbot]

The Buildbot has detected a new failure on builder tomcat-8-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/588

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1740877
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: tomcat 7 broken on java 7 for linux distro

[Emmanuel Bourg]

Le 25/04/2016 18:50, Romain Manni-Bucau a écrit :
> Just to make it clearer: 14.04 had java 7 as expected but tomcat7 package
> was compiled with java 8.

This shouldn't be possible. Ubuntu packages are built in a clean
environment with no packages or applications not in the distribution.
Ubuntu 14.04 doesn't have Java 8 and therefore official packages can't
be compiled with Java 8. If you look at the build log [1] for the
version of Tomcat 7 currently distributed for Ubuntu 14.04 you'll see
that Java 7 was used.

Emmanuel Bourg

[1]
https://launchpadlibrarian.net/209543797/buildlog_ubuntu-trusty-i386.tomcat7_7.0.52-1ubuntu0.3_BUILDING.txt.gz


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1740890 - /tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java

[markt]

Author: markt
Date: Mon Apr 25 20:17:27 2016
New Revision: 1740890

URL: http://svn.apache.org/viewvc?rev=1740890&view=rev
Log:
Correct initial state.

Modified:

tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java?rev=1740890&r1=1740889&r2=1740890&view=diff
==
--- 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
 (original)
+++ 
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java
 Mon Apr 25 20:17:27 2016
@@ -42,7 +42,7 @@ public class Nio2ServletInputStream exte
 private boolean flipped = false;
 private volatile boolean readPending = false;
 private volatile boolean interest = true;
-private volatile boolean closed = true;
+private volatile boolean closed = false;
 
 public Nio2ServletInputStream(SocketWrapper wrapper, 
AbstractEndpoint endpoint0) {
 this.endpoint = endpoint0;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-8-trunk

[buildbot]

The Buildbot has detected a restored build on builder tomcat-8-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/589

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1740890
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 52952] Improve ExtensionValidator handling for embedded scenarios

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=52952

--- Comment #2 from Abdessamed MANSOURI  ---
For checking for duplicates its better to use sets than lists for storing
Extension and ManifestResource inside ExtensionValidator and overriding equals
and hashcode, but HashSet its based on HashMap and when HashMap is used the
keys should be immutable, do i change Extension and ManifestResource to
immutable?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-nio2 :  Tomcat 8.x, a web server implementing the 
Java Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 36 mins 43 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160426-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160426.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160426-native-src.tar.gz
 -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true 
-Dexecute.test.nio=false -Dtest.o
 penssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20160426/bin/openssl 
-Dexecute.test.bio=false -Dexecute.test.apr=false 
-Dtest.excludePerformance=true -Dexecute.test.nio2=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/li

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-apr has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 7 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-apr :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-apr/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-apr.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 36 mins 10 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160426-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-12/dest-20160426/lib 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160426.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160426-native-src.tar.gz
 -Dtest.temp=
 output/test-tmp-APR -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20160426/bin/openssl
 -Dexecute.test.bio=false -Dexecute.test.apr=true 
-Dtest.excludePerformance=true -Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/worksp

Tomcat unresponsive, and http acceptor thread disappearing

[Mihir Patel]

Hello,

I would like to share my learnings on a recent issue I came across where
tomcat became unresponsive under load, and couldn't recover without
restart. More importantly, it was surprising to find tomcat acceptor thread
(http-bio-8080-acceptor-0) disappearing resulting into the unresponsive
state of the tomcat/app.

*Env:* Tomcat 7.0.29 on Java 1.7.0_51 on CentOS 6.3, with BIO (JioEndpoint)
connector

*Issue:* Came across an issue under heavy load (generated through Gatling)
where during the load test tomcat/application becomes unresponsive, and
doesn't recover even after load test. As a side effect, I see lots of TCP
sockets in CLOSE_WAIT state with non-empty Recv-Q.

*Observation:* I am able to telnet to the port, even curl works up to the
point of "sending request", but then hangs while receiving response from
server and eventually fails with "curl: (56) Recv failure: Connection reset
by peer". Gatling requests are failing with request timed out errors
consistently. It doesn't take more than 10 seconds to reproduce the error.
Application is all normal from threads and memory perspective while it's
unresponsive.

Luckily I was able to successfully reproduce the issue. So took heap dump
and thread dump before and after multiple load tests. There were no errors
in catalina.out or application logs. Suddenly, noticed that "after" we see
application in unresponsive state, thread "http-bio-8080-Acceptor" is not
in thread dump, it disappeared. So, thought that if thread is exiting it's
run method, then it would end and we won't see it in thread dump. Went back
and looked at source code of tomcat 7.0.29, remote debugged with tomcat in
following method in
*org/apache/tomcat/tomcat-coyote/7.0.29/tomcat-coyote-7.0.29.jar!/org/apache/tomcat/util/net/JIoEndpoint.class*
:

// --- Acceptor Inner Class
   /**
* The background thread that listens for incoming TCP/IP connections and
* hands them off to an appropriate processor.
*/
   protected class Acceptor extends AbstractEndpoint.Acceptor {

   @Override
   public void run() {

   int errorDelay = 0;

   // Loop until we receive a shutdown command
   while (running) {

   // Loop if endpoint is paused
   while (paused && running) {
   state = AcceptorState.PAUSED;
   try {
   Thread.sleep(50);
   } catch (InterruptedException e) {
   // Ignore
   }
   }

   if (!running) {
   break;
   }
   state = AcceptorState.RUNNING;

   try {
   //if we have reached max connections, wait
   countUpOrAwaitConnection();

   Socket socket = null;
   try {
   // Accept the next incoming connection from the
server
   // socket
   socket =
serverSocketFactory.acceptSocket(serverSocket);
   } catch (IOException ioe) {
   countDownConnection();
   // Introduce delay if necessary
   errorDelay = handleExceptionWithDelay(errorDelay);
   // re-throw
   throw ioe;
   }
   // Successful accept, reset the error delay
   errorDelay = 0;

   // Configure the socket
   if (running && !paused && setSocketOptions(socket)) {
   // Hand this socket off to an appropriate processor
   if (!processSocket(socket)) {
   countDownConnection();
   // Close socket right away
   closeSocket(socket);
   }
   } else {
   countDownConnection();
   // Close socket right away
   closeSocket(socket);
   }
   } catch (IOException x) {
   if (running) {
   log.error(sm.getString("endpoint.accept.fail"), x);
   }
   } catch (NullPointerException npe) {
   if (running) {
   log.error(sm.getString("endpoint.accept.fail"), npe);
   }
   } catch (Throwable t) {
   ExceptionUtils.handleThrowable(t);
   *log.error(sm.getString("endpoint.accept.fail"), t);*
   }
   }
   state = AcceptorState.ENDED;
   }
   }

Looking at the code above where tomcat is accepting socket connections, put
debug points within each catch block during load test (with remote debug),
and got the execution stopped in last catch (Throwable t) block. The
ExecptionUtils.handleThrowable checks for type of throwable and converts

Re: tomcat 7 broken on java 7 for linux distro

[Romain Manni-Bucau]

Not sure what happent, got the same it in one of my box (but was 15.10 so
can't explain the feedback i got with 14.04). Maybe a package update.


Romain Manni-Bucau
@rmannibucau  |  Blog
 | Github  |
LinkedIn  | Tomitriber
 | JavaEE Factory


2016-04-25 21:41 GMT+02:00 Emmanuel Bourg :

> Le 25/04/2016 18:50, Romain Manni-Bucau a écrit :
> > Just to make it clearer: 14.04 had java 7 as expected but tomcat7 package
> > was compiled with java 8.
>
> This shouldn't be possible. Ubuntu packages are built in a clean
> environment with no packages or applications not in the distribution.
> Ubuntu 14.04 doesn't have Java 8 and therefore official packages can't
> be compiled with Java 8. If you look at the build log [1] for the
> version of Tomcat 7 currently distributed for Ubuntu 14.04 you'll see
> that Java 7 was used.
>
> Emmanuel Bourg
>
> [1]
>
> https://launchpadlibrarian.net/209543797/buildlog_ubuntu-trusty-i386.tomcat7_7.0.52-1ubuntu0.3_BUILDING.txt.gz
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>