svn commit: r1717731 - /tomcat/trunk/test/org/apache/catalina/filters/TestRestCsrfPreventionFilter2.java
Author: markt Date: Thu Dec 3 09:42:56 2015 New Revision: 1717731 URL: http://svn.apache.org/viewvc?rev=1717731&view=rev Log: Authentication names should be in upper case. This doesn't affect this test now, but it does when porting to JASPIC. Modified: tomcat/trunk/test/org/apache/catalina/filters/TestRestCsrfPreventionFilter2.java Modified: tomcat/trunk/test/org/apache/catalina/filters/TestRestCsrfPreventionFilter2.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/filters/TestRestCsrfPreventionFilter2.java?rev=1717731&r1=1717730&r2=1717731&view=diff == --- tomcat/trunk/test/org/apache/catalina/filters/TestRestCsrfPreventionFilter2.java (original) +++ tomcat/trunk/test/org/apache/catalina/filters/TestRestCsrfPreventionFilter2.java Thu Dec 3 09:42:56 2015 @@ -79,7 +79,7 @@ public class TestRestCsrfPreventionFilte private static final String USER = "user"; private static final String PWD = "pwd"; private static final String ROLE = "role"; -private static final String METHOD = "Basic"; +private static final String METHOD = "BASIC"; private static final BasicCredentials CREDENTIALS = new BasicCredentials(METHOD, USER, PWD); private static final String CLIENT_AUTH_HEADER = "authorization"; - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57324] Change in Expect100Continue behaviour in Tomcat is breaking existing clients with "keepalive" connections
https://bz.apache.org/bugzilla/show_bug.cgi?id=57324 --- Comment #13 from Michael Osipov <1983-01...@gmx.net> --- Any ambitions to port this back to 6.0.x? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.30
2015-12-02 0:02 GMT+01:00 Mark Thomas : > The proposed 8.0.30 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.0.30 > > Rémy
svn commit: r1717740 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java
Author: remm
Date: Thu Dec 3 12:03:22 2015
New Revision: 1717740
URL: http://svn.apache.org/viewvc?rev=1717740&view=rev
Log:
Forgot to replicate the root redirect in the jaspic form code.
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java?rev=1717740&r1=1717739&r2=1717740&view=diff
==
---
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java
Thu Dec 3 12:03:22 2015
@@ -113,6 +113,19 @@ public class FormAuthModule extends Tomc
}
if (!isLoginActionRequest(request)) {
+// If this request was to the root of the context without a
trailing
+// '/', need to redirect to add it else the submit of the login
form
+// may not go to the correct web application
+if (request.getServletPath().length() == 0 &&
request.getPathInfo() == null) {
+StringBuilder location = new
StringBuilder(request.getDecodedRequestURI());
+location.append('/');
+if (request.getQueryString() != null) {
+location.append('?');
+location.append(request.getQueryString());
+}
+
response.sendRedirect(response.encodeRedirectURL(location.toString()));
+return AuthStatus.SEND_CONTINUE;
+}
return handleRedirectToLoginPage(request, response);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.30
+1 for non-binding. Testing environment: RHEL 6.2, JDK 1.7.0_67, tcnative 1.2.2, apr 1.5.2 Test results: All the test cases of BIO/NIO/NIO2/APR has successfully passed. Best, Huxing Zhang -- From:Rémy Maucherat Time:2015 Dec 3 (Thu) 19:51 To:Tomcat Developers List Subject:Re: [VOTE] Release Apache Tomcat 8.0.30 2015-12-02 0:02 GMT+01:00 Mark Thomas : > The proposed 8.0.30 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.0.30 > > Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58686] New: javax.xml.ws.WebServiceException: java.io.IOException: Error writing to server JAX-WS request with a payload over 2MB
https://bz.apache.org/bugzilla/show_bug.cgi?id=58686 Bug ID: 58686 Summary: javax.xml.ws.WebServiceException: java.io.IOException: Error writing to server JAX-WS request with a payload over 2MB Product: Tomcat 8 Version: 8.0.28 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Connectors Assignee: dev@tomcat.apache.org Reporter: b...@wolosek.com We have recently updated the tech stack of a JAX-WS webservice running on JRE 1.7.0_17/Tomcat7.0.39 to JRE 1.8.0_66/Tomcat 8.0.28. The web app runs on Windows Server 2012. The web service uses a Metro implementation for JAX-WS. The clients run on various windows versions using JRE 7 and the JAX-WS client API built into the JRE. The webservice is used to upload files from the client machines to the webservice which saves them in a document management system. The implementation worked pretty much flawlessly under Java 7/Tomcat 7 but we have run into a problem with larger payloads (2MB or larger) running under Java 8/Tomcat 8 server side. The stack trace from the client is: 12/02/2015 14:12:38.699 [AWT-EventQueue-0] ERROR DocumentImporterMainWindow$SwingAction.importDocument: Unexpected Problem trying to call the CustomerOrderDMService javax.xml.ws.WebServiceException: java.io.IOException: Error writing to server at com.sun.xml.internal.ws.transport.http.client.HttpClientTransport.readResponseCodeAndMessage(Unknown Source) at com.sun.xml.internal.ws.transport.http.client.HttpTransportPipe.createResponsePacket(Unknown Source) at com.sun.xml.internal.ws.transport.http.client.HttpTransportPipe.process(Unknown Source) at com.sun.xml.internal.ws.transport.http.client.HttpTransportPipe.processRequest(Unknown Source) at com.sun.xml.internal.ws.transport.DeferredTransportPipe.processRequest(Unknown Source) at com.sun.xml.internal.ws.api.pipe.Fiber.__doRun(Unknown Source) at com.sun.xml.internal.ws.api.pipe.Fiber._doRun(Unknown Source) at com.sun.xml.internal.ws.api.pipe.Fiber.doRun(Unknown Source) at com.sun.xml.internal.ws.api.pipe.Fiber.runSync(Unknown Source) at com.sun.xml.internal.ws.client.Stub.process(Unknown Source) at com.sun.xml.internal.ws.client.sei.SEIStub.doProcess(Unknown Source) at com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(Unknown Source) at com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(Unknown Source) at com.sun.xml.internal.ws.client.sei.SEIStub.invoke(Unknown Source) at com.sun.proxy.$Proxy30.importDocument(Unknown Source) at com.mycompany.documentimporter.DocumentImporterMainWindow$SwingAction.importDocument(DocumentImporterMainWindow.java:681) at com.mycompany.documentimporter.DocumentImporterMainWindow$SwingAction.actionPerformed(DocumentImporterMainWindow.java:612) at javax.swing.AbstractButton.fireActionPerformed(Unknown Source) at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source) at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source) at javax.swing.DefaultButtonModel.setPressed(Unknown Source) at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source) at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source) at java.awt.Component.processMouseEvent(Unknown Source) at javax.swing.JComponent.processMouseEvent(Unknown Source) at java.awt.Component.processEvent(Unknown Source) at java.awt.Container.processEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source) at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source) at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$500(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatch
[Bug 58686] javax.xml.ws.WebServiceException: java.io.IOException: Error writing to server JAX-WS request with a payload over 2MB
https://bz.apache.org/bugzilla/show_bug.cgi?id=58686 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID OS||All --- Comment #1 from Mark Thomas --- There is nothing in this report that demonstrates a bug in Apache Tomcat. Bugzilla is not a support forum. Please use the Apache Tomcat users' mailing list for support. If that discussion concludes that there is a bug then this can be re-opened and the relevant details added. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1717771 - /tomcat/native/trunk/native/src/ssl.c
Author: remm
Date: Thu Dec 3 14:25:35 2015
New Revision: 1717771
URL: http://svn.apache.org/viewvc?rev=1717771&view=rev
Log:
Expose SSL_renegotiate (the version in SSLSocket needs a socket associated with
it).
Modified:
tomcat/native/trunk/native/src/ssl.c
Modified: tomcat/native/trunk/native/src/ssl.c
URL:
http://svn.apache.org/viewvc/tomcat/native/trunk/native/src/ssl.c?rev=1717771&r1=1717770&r2=1717771&view=diff
==
--- tomcat/native/trunk/native/src/ssl.c (original)
+++ tomcat/native/trunk/native/src/ssl.c Thu Dec 3 14:25:35 2015
@@ -1366,6 +1366,19 @@ TCN_IMPLEMENT_CALL(jint, SSL, doHandshak
return SSL_do_handshake(ssl_);
}
+TCN_IMPLEMENT_CALL(jint, SSL, renegotiate)(TCN_STDARGS,
+ jlong ssl /* SSL * */) {
+SSL *ssl_ = J2P(ssl, SSL *);
+if (ssl_ == NULL) {
+tcn_ThrowException(e, "ssl is null");
+return 0;
+}
+
+UNREFERENCED(o);
+
+return SSL_renegotiate(ssl_);
+}
+
/* Read which protocol was negotiated for the given SSL *. */
TCN_IMPLEMENT_CALL(jstring, SSL, getNextProtoNegotiated)(TCN_STDARGS,
jlong ssl /* SSL *
*/) {
@@ -1987,6 +2000,12 @@ TCN_IMPLEMENT_CALL(jint, SSL, doHandshak
UNREFERENCED(o);
UNREFERENCED(ssl);
tcn_ThrowException(e, "Not implemented");
+}
+
+TCN_IMPLEMENT_CALL(jint, SSL, renegotiate)(TCN_STDARGS, jlong ssl) {
+ UNREFERENCED(o);
+ UNREFERENCED(ssl);
+ tcn_ThrowException(e, "Not implemented");
}
TCN_IMPLEMENT_CALL(jstring, SSL, getNextProtoNegotiated)(TCN_STDARGS, jlong
ssl) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57324] Change in Expect100Continue behaviour in Tomcat is breaking existing clients with "keepalive" connections
https://bz.apache.org/bugzilla/show_bug.cgi?id=57324 --- Comment #14 from Christopher Schultz --- I don't intend for this to sound confrontational, but would you care to submit a patch? Tomcat 7 and higher differ substantially from Tomcat 6 and so a back-port might not be trivial. If you are motivated to get this back-ported to Tomcat 6, you could try your hand at preparing a patch and help both yourself and The Community at large at the same time (not to mention the various committers who would otherwise have to prepare the patch themselves). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57489] java.util.concurrent.ExecutionException: java.io.IOException: Key must be cancelled
https://bz.apache.org/bugzilla/show_bug.cgi?id=57489 --- Comment #18 from Barry Coughlan --- Created attachment 33321 --> https://bz.apache.org/bugzilla/attachment.cgi?id=33321&action=edit Test cases for closing websockets -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57489] java.util.concurrent.ExecutionException: java.io.IOException: Key must be cancelled
https://bz.apache.org/bugzilla/show_bug.cgi?id=57489 --- Comment #19 from Barry Coughlan --- Created attachment 33322 --> https://bz.apache.org/bugzilla/attachment.cgi?id=33322&action=edit Websocket client for testing TCP behaviour -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57489] java.util.concurrent.ExecutionException: java.io.IOException: Key must be cancelled
https://bz.apache.org/bugzilla/show_bug.cgi?id=57489 --- Comment #20 from Barry Coughlan --- Test cases attached - there are a few TODO comments in the attached files that could do with a pair of eyes. It's a bit messier than I had hoped but the test results match up with my manual testing. Also, there is one scenario where the @OnMessage doesn't send a message but the @OnClose is not called - this happens only when a TCP reset is sent in the @OnMessage. This is captured in testTcpResetInOnMessage(). I'm not sure if the root cause is the same. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1717806 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
Author: remm
Date: Thu Dec 3 17:05:59 2015
New Revision: 1717806
URL: http://svn.apache.org/viewvc?rev=1717806&view=rev
Log:
Add matching renegotiate method. Note that this will cause an exception without
a new native, but however using it in the SSL engine right now will already
cause an exception, so no real change.
Modified:
tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
Modified: tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/jni/SSL.java?rev=1717806&r1=1717805&r2=1717806&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/jni/SSL.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/jni/SSL.java Thu Dec 3 17:05:59 2015
@@ -517,6 +517,12 @@ public final class SSL {
public static native int doHandshake(long ssl);
/**
+ * SSL_renegotiate
+ * @param ssl the SSL instance (SSL *)
+ */
+public static native int renegotiate(long ssl);
+
+/**
* SSL_in_init.
* @param SSL
*/
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1717808 - in /tomcat/trunk: build.xml java/org/apache/tomcat/util/net/openssl/OpenSSLContext.java java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java test/org/apache/tomcat/util/ne
Author: remm
Date: Thu Dec 3 17:14:57 2015
New Revision: 1717808
URL: http://svn.apache.org/viewvc?rev=1717808&view=rev
Log:
- Add some renegotiation code to the OpenSSL SSLEngine. It seems to do
something, but certificate extraction doesn't work (returns null).
- Allow using the OpenSSL engine with the testsuite using a
test.sslImplementation property (set to the sslImplementationName from
server.xml).
Modified:
tomcat/trunk/build.xml
tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLContext.java
tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
tomcat/trunk/test/org/apache/tomcat/util/net/TesterSupport.java
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1717808&r1=1717807&r2=1717808&view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Thu Dec 3 17:14:57 2015
@@ -1455,6 +1455,7 @@
+
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLContext.java?rev=1717808&r1=1717807&r2=1717808&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLContext.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLContext.java
Thu Dec 3 17:14:57 2015
@@ -445,6 +445,7 @@ public class OpenSSLContext implements o
SSLContext.free(ctx);
}
}
-destroyPools();
+//FIXME: this causes crashes in the testsuite
+//destroyPools();
}
}
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java?rev=1717808&r1=1717807&r2=1717808&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java Thu
Dec 3 17:14:57 2015
@@ -161,8 +161,8 @@ public final class OpenSSLEngine extends
private volatile String cipher;
private volatile String applicationProtocol;
-// We store this outside of the SslSession so we not need to create an
instance during verifyCertificates(...)
private volatile Certificate[] peerCerts;
+private volatile X509Certificate[] x509PeerCerts;
private volatile ClientAuthMode clientAuth = ClientAuthMode.NONE;
// SSL Engine status variables
@@ -629,18 +629,7 @@ public final class OpenSSLEngine extends
// check if SSL_read returned <= 0. In this case we need to check the
error and see if it was something
// fatal.
if (lastPrimingReadResult <= 0) {
-// Check for OpenSSL errors caused by the priming read
-long error = SSL.getLastErrorNumber();
-if (error != SSL.SSL_ERROR_NONE) {
-String err = SSL.getErrorString(error);
-if (logger.isDebugEnabled()) {
-logger.debug(sm.getString("engine.readFromSSLFailed",
Long.toString(error),
-Integer.toString(lastPrimingReadResult), err));
-}
-// There was an internal error -- shutdown
-shutdown();
-throw new SSLException(err);
-}
+checkLastError();
}
return SSL.pendingReadableBytesInSSL(ssl);
}
@@ -835,45 +824,6 @@ public final class OpenSSLEngine extends
}
}
-private Certificate[] initPeerCertChain() throws
SSLPeerUnverifiedException {
-byte[][] chain = SSL.getPeerCertChain(ssl);
-byte[] clientCert;
-if (!clientMode) {
-// if used on the server side SSL_get_peer_cert_chain(...) will
not include the remote peer certificate.
-// We use SSL_get_peer_certificate to get it in this case and add
it to our array later.
-//
-// See
https://www.openssl.org/docs/ssl/SSL_get_peer_cert_chain.html
-clientCert = SSL.getPeerCertificate(ssl);
-} else {
-clientCert = null;
-}
-
-if (chain == null && clientCert == null) {
-throw new
SSLPeerUnverifiedException(sm.getString("engine.unverifiedPeer"));
-}
-int len = 0;
-if (chain != null) {
-len += chain.length;
-}
-
-int i = 0;
-Certificate[] peerCerts;
-if (clientCert != null) {
-len++;
-peerCerts = new Certificate[len];
-peerCerts[i++] = new OpenSslX509Certificate(clientCert);
-} else {
-peerCerts = new Certificat
[Bug 57324] Change in Expect100Continue behaviour in Tomcat is breaking existing clients with "keepalive" connections
https://bz.apache.org/bugzilla/show_bug.cgi?id=57324 --- Comment #15 from Michael Osipov <1983-01...@gmx.net> --- (In reply to Christopher Schultz from comment #14) > I don't intend for this to sound confrontational, but would you care to > submit a patch? > > Tomcat 7 and higher differ substantially from Tomcat 6 and so a back-port > might not be trivial. If you are motivated to get this back-ported to Tomcat > 6, you could try your hand at preparing a patch and help both yourself and > The Community at large at the same time (not to mention the various > committers who would otherwise have to prepare the patch themselves). Hopefully, because I am a long year ASF committer and don't need a lecture on that. I don't mind to provide patches at all. I can try to backport that but I cannot compile Tomcat. The custom Ant build won't download the dependencies at work. It has either to be Maven or at least Aether Ant Tasks. Nothing else will work. All calls must be routed through Nexus. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1715633 - in /tomcat/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java webapps/docs/changelog.xml
Am 30.11.2015 um 16:43 schrieb Christopher Schultz:
Felix,
On 11/24/15 3:47 PM, Felix Schumacher wrote:
Am 23.11.2015 um 03:19 schrieb Huxing Zhang:
Hi fschumacher,
Just a friendly reminder that I had a discussion with kkolinko about
this before.
I seems that it is better to explicitly define the default value
rather than the Boolean.getBoolean syntactic sugar.
Thanks for the hint.
I will change it.
I'm not sure why Konstantin had a strong opinion on this;
Boolean.getBoolean has a well-defined default value of Boolean.FALSE. I
suppose it's a little more readable when you have the default explicitly
in there.
That was his main point.
But:
-
Boolean.getBoolean(System.getProperty("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader",
"false"));
This was definitely wrong... it's looking-up the system property called
"[something]" or "false" depending upon the value of
org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader. This is what
was intended:
Boolean.valueOf(System.getProperty("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader","false")
right.
+
Boolean.getBoolean("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader");
... and I have no objection to the above.
I will not change it back again :) but thanks for the review.
Regards,
Felix
-chris
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58433] RemoteIpValve not activated on redirect from mapping
https://bz.apache.org/bugzilla/show_bug.cgi?id=58433 --- Comment #4 from Karl von Randow --- We have encountered a similar issue. We have used the RemoteIpValve in our Context, which works well in our use cases (we didn't encounter your issue). However it does not work for error pages. It appears that error pages are handled after exiting from RemoteIpValve, in which case the Request settings have been reverted to their original values. On our error pages we still want to be able to test request.isSecure(), for example, to know whether to output secure or insecure URLs. Apologies for the tangent; I believe our issue would be solved by handling this in the adapter instead. Maybe this additional issues lends some weight to investigating that? Otherwise perhaps some advice? (We seem to be able to workaround the issue by using RemoteIpValve on the Engine instead, but we'd prefer to use it at the Context level). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 4 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc8.0.x-test-nio2 : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-8.0.x/output/logs-NIO2 -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs -WARNING- No directory [/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs] The following work was performed: http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2.html Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2 (Type: Build) Work ended in a state of : Failed Elapsed: 40 mins 7 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dtest.reports=output/logs-NIO2 -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151204-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20151204.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151204-native-src.tar.gz -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20151204/bin /openssl -Dexecute.test.bio=false -Dexecute.test.apr=false -Dtest.excludePerformance=true -Dexecute.test.nio2=true -Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-8.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/
Re: [VOTE] Release Apache Tomcat 8.0.30
On Wed, Dec 2, 2015 at 1:02 AM, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.30 release is now available for voting. > > The main changes since 8.0.29 are: > > - Location headers for redirects now use relative URIs. This can > be controlled by Context with the useRelativeRedirects attribute. > > - Correct a regression in 8.0.29 that broke redirects for context > roots. > > - Restore the default setting of quoteAttributeEL in Jasper to true > to align with 8.0.26/7.0.64 and earlier as well as other JSP > implementations. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.30/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1057/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_30/ > > The proposed 8.0.30 release is: > [ ] Broken - do not release > > [ X ] Stable - go ahead and release as 8.0.30 > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
