svn commit: r1710728 - in /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors: LocalStrings.properties StaticMembershipInterceptor.java

2015-10-27 Thread kfujino
Author: kfujino
Date: Tue Oct 27 07:40:22 2015
New Revision: 1710728

URL: http://svn.apache.org/viewvc?rev=1710728&view=rev
Log:
When starting the staticMembershipInterceptor, staticMembershipInterceptor 
checks the required Interceptors.
If the required Interceptor does not exist, it issues a warning log.

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties?rev=1710728&r1=1710727&r2=1710728&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties
 Tue Oct 27 07:40:22 2015
@@ -32,6 +32,8 @@ nonBlockingCoordinator.memberDisappeared
 nonBlockingCoordinator.heartbeat.inconsistency=Heartbeat found inconsistency, 
restart election
 nonBlockingCoordinator.heartbeat.failed=Unable to perform heartbeat.
 orderInterceptor.messageAdded.sameCounter=Message added has the same counter, 
synchronization bug. Disable the order interceptor
+staticMembershipInterceptor.no.failureDetector=There is no TcpFailureDetector. 
Automatic detection of static members does not work properly. By defining the 
StaticMembershipInterceptor under the TcpFailureDetector, automatic detection 
of the static members will work.
+staticMembershipInterceptor.no.pingInterceptor=There is no TcpPingInterceptor. 
The health check of static members does not work properly. By defining the 
TcpPingInterceptor, the health check of static members will work.
 tcpFailureDetector.memberDisappeared.verify=Received memberDisappeared[{0}] 
message. Will verify.
 tcpFailureDetector.already.disappeared=Verification complete. Member already 
disappeared[{0}]
 tcpFailureDetector.member.disappeared=Verification complete. Member 
disappeared[{0}]

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java?rev=1710728&r1=1710727&r2=1710728&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java
 Tue Oct 27 07:40:22 2015
@@ -20,12 +20,20 @@ import java.util.ArrayList;
 
 import org.apache.catalina.tribes.Channel;
 import org.apache.catalina.tribes.ChannelException;
+import org.apache.catalina.tribes.ChannelInterceptor;
 import org.apache.catalina.tribes.Member;
 import org.apache.catalina.tribes.group.AbsoluteOrder;
 import org.apache.catalina.tribes.group.ChannelInterceptorBase;
+import org.apache.catalina.tribes.util.StringManager;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
+
+public class StaticMembershipInterceptor extends ChannelInterceptorBase {
+
+private static final Log log = 
LogFactory.getLog(StaticMembershipInterceptor.class);
+protected static final StringManager sm =
+StringManager.getManager(StaticMembershipInterceptor.class);
 
-public class StaticMembershipInterceptor
-extends ChannelInterceptorBase {
 protected final ArrayList members = new ArrayList<>();
 protected Member localMember = null;
 
@@ -119,6 +127,22 @@ public class StaticMembershipInterceptor
 };
 t.start();
 super.start(svc & (~Channel.SND_RX_SEQ) & (~Channel.SND_TX_SEQ));
+
+// check required interceptors
+TcpFailureDetector failureDetector = null;
+TcpPingInterceptor pingInterceptor = null;
+ChannelInterceptor prev = getPrevious();
+while (prev != null) {
+if (prev instanceof TcpFailureDetector ) failureDetector = 
(TcpFailureDetector) prev;
+if (prev instanceof TcpPingInterceptor) pingInterceptor = 
(TcpPingInterceptor) prev;
+prev = prev.getPrevious();
+}
+if (failureDetector == null) {
+
log.warn(sm.getString("staticMembershipInterceptor.no.failureDetector"));
+}
+if (pingInterceptor == null) {
+
log.warn(sm.getString("staticMembershipInterceptor.no.pingInterceptor"));
+}
 }
 
 }
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710731 - in /tomcat/tc8.0.x/trunk: java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties java/org/apache/catalina/tribes/group/interceptors/StaticMembershipIntercept

2015-10-27 Thread kfujino
Author: kfujino
Date: Tue Oct 27 07:44:11 2015
New Revision: 1710731

URL: http://svn.apache.org/viewvc?rev=1710731&view=rev
Log:
When starting the StaticMembershipInterceptor, StaticMembershipInterceptor 
checks the required Interceptors.
If the required Interceptor does not exist, it issues warning logs.

Modified:

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties?rev=1710731&r1=1710730&r2=1710731&view=diff
==
--- 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties
 (original)
+++ 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties
 Tue Oct 27 07:44:11 2015
@@ -32,6 +32,8 @@ nonBlockingCoordinator.memberDisappeared
 nonBlockingCoordinator.heartbeat.inconsistency=Heartbeat found inconsistency, 
restart election
 nonBlockingCoordinator.heartbeat.failed=Unable to perform heartbeat.
 orderInterceptor.messageAdded.sameCounter=Message added has the same counter, 
synchronization bug. Disable the order interceptor
+staticMembershipInterceptor.no.failureDetector=There is no TcpFailureDetector. 
Automatic detection of static members does not work properly. By defining the 
StaticMembershipInterceptor under the TcpFailureDetector, automatic detection 
of the static members will work.
+staticMembershipInterceptor.no.pingInterceptor=There is no TcpPingInterceptor. 
The health check of static members does not work properly. By defining the 
TcpPingInterceptor, the health check of static members will work.
 tcpFailureDetector.memberDisappeared.verify=Received memberDisappeared[{0}] 
message. Will verify.
 tcpFailureDetector.already.disappeared=Verification complete. Member already 
disappeared[{0}]
 tcpFailureDetector.member.disappeared=Verification complete. Member 
disappeared[{0}]

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java?rev=1710731&r1=1710730&r2=1710731&view=diff
==
--- 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java
 (original)
+++ 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java
 Tue Oct 27 07:44:11 2015
@@ -20,12 +20,20 @@ import java.util.ArrayList;
 
 import org.apache.catalina.tribes.Channel;
 import org.apache.catalina.tribes.ChannelException;
+import org.apache.catalina.tribes.ChannelInterceptor;
 import org.apache.catalina.tribes.Member;
 import org.apache.catalina.tribes.group.AbsoluteOrder;
 import org.apache.catalina.tribes.group.ChannelInterceptorBase;
+import org.apache.catalina.tribes.util.StringManager;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
+
+public class StaticMembershipInterceptor extends ChannelInterceptorBase {
+
+private static final Log log = 
LogFactory.getLog(StaticMembershipInterceptor.class);
+protected static final StringManager sm =
+
StringManager.getManager(StaticMembershipInterceptor.class.getPackage().getName());
 
-public class StaticMembershipInterceptor
-extends ChannelInterceptorBase {
 protected final ArrayList members = new ArrayList<>();
 protected Member localMember = null;
 
@@ -119,6 +127,22 @@ public class StaticMembershipInterceptor
 };
 t.start();
 super.start(svc & (~Channel.SND_RX_SEQ) & (~Channel.SND_TX_SEQ));
+
+// check required interceptors
+TcpFailureDetector failureDetector = null;
+TcpPingInterceptor pingInterceptor = null;
+ChannelInterceptor prev = getPrevious();
+while (prev != null) {
+if (prev instanceof TcpFailureDetector ) failureDetector = 
(TcpFailureDetector) prev;
+if (prev instanceof TcpPingInterceptor) pingInterceptor = 
(TcpPingInterceptor) prev;
+prev = prev.getPrevious();
+}
+if (failureDetector == null) {
+
log.warn(sm.getString("staticMembershipInterceptor.no.failureDetector"));
+}
+if (pingInterceptor == null) {
+
log.warn(sm.getString("staticMembershipInterceptor.no.pingInterceptor"));
+}
 }
 
 }
\ No newline at end of file

Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://sv

svn commit: r1710732 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java webapps/docs/changelog.xml

2015-10-27 Thread kfujino
Author: kfujino
Date: Tue Oct 27 07:46:42 2015
New Revision: 1710732

URL: http://svn.apache.org/viewvc?rev=1710732&view=rev
Log:
When starting the StaticMembershipInterceptor, StaticMembershipInterceptor 
checks the required Interceptors.
If the required Interceptor does not exist, it issues warning logs.

Modified:

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java?rev=1710732&r1=1710731&r2=1710732&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java
 (original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/StaticMembershipInterceptor.java
 Tue Oct 27 07:46:42 2015
@@ -20,12 +20,17 @@ import java.util.ArrayList;
 
 import org.apache.catalina.tribes.Channel;
 import org.apache.catalina.tribes.ChannelException;
+import org.apache.catalina.tribes.ChannelInterceptor;
 import org.apache.catalina.tribes.Member;
 import org.apache.catalina.tribes.group.AbsoluteOrder;
 import org.apache.catalina.tribes.group.ChannelInterceptorBase;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
+
+public class StaticMembershipInterceptor extends ChannelInterceptorBase {
+
+private static final Log log = 
LogFactory.getLog(StaticMembershipInterceptor.class);
 
-public class StaticMembershipInterceptor
-extends ChannelInterceptorBase {
 protected ArrayList members = new ArrayList();
 protected Member localMember = null;
 
@@ -119,6 +124,26 @@ public class StaticMembershipInterceptor
 };
 t.start();
 super.start(svc & (~Channel.SND_RX_SEQ) & (~Channel.SND_TX_SEQ));
+
+// check required interceptors
+TcpFailureDetector failureDetector = null;
+TcpPingInterceptor pingInterceptor = null;
+ChannelInterceptor prev = getPrevious();
+while (prev != null) {
+if (prev instanceof TcpFailureDetector ) failureDetector = 
(TcpFailureDetector) prev;
+if (prev instanceof TcpPingInterceptor) pingInterceptor = 
(TcpPingInterceptor) prev;
+prev = prev.getPrevious();
+}
+if (failureDetector == null) {
+log.warn("There is no TcpFailureDetector. Automatic detection of 
static members does"
++ " not work properly. By defining the 
StaticMembershipInterceptor under the"
++ " TcpFailureDetector, automatic detection of the static 
members will work.");
+}
+if (pingInterceptor == null) {
+log.warn("There is no TcpPingInterceptor. The health check of 
static member does"
++ " not work properly. By defining the TcpPingInterceptor, 
the health check of"
++ " static member will work.");
+}
 }
 
 }
\ No newline at end of file

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1710732&r1=1710731&r2=1710732&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Oct 27 07:46:42 2015
@@ -116,6 +116,12 @@
 clearly. When handling shutdown payload, verification completion 
message
 is not required. (kfujino)
   
+  
+When starting the StaticMembershipInterceptor,
+StaticMembershipInterceptor checks  the required
+Interceptors. If the required Interceptor does not exist, it issues
+warning logs. (kfujino)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710734 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2015-10-27 Thread mgrigorov
Author: mgrigorov
Date: Tue Oct 27 07:50:01 2015
New Revision: 1710734

URL: http://svn.apache.org/viewvc?rev=1710734&view=rev
Log:
Add myself (mgrigorov) to the list of member/committers


Modified:
tomcat/site/trunk/docs/whoweare.html
tomcat/site/trunk/xdocs/whoweare.xml

Modified: tomcat/site/trunk/docs/whoweare.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whoweare.html?rev=1710734&r1=1710733&r2=1710734&view=diff
==
--- tomcat/site/trunk/docs/whoweare.html (original)
+++ tomcat/site/trunk/docs/whoweare.html Tue Oct 27 07:50:01 2015
@@ -399,6 +399,12 @@ A complete list of all the Apache Commit
 
 
 
+Martin Grigorov (mgrigorov at apache.org)
+
+
+
+
+
 Keith Wannamaker (keith at apache.org)
 
 

Modified: tomcat/site/trunk/xdocs/whoweare.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whoweare.xml?rev=1710734&r1=1710733&r2=1710734&view=diff
==
--- tomcat/site/trunk/xdocs/whoweare.xml (original)
+++ tomcat/site/trunk/xdocs/whoweare.xml Tue Oct 27 07:50:01 2015
@@ -124,6 +124,9 @@ A complete list of all the Apache Commit
 Mark Thomas (markt at apache.org)
 
 
+Martin Grigorov (mgrigorov at apache.org)
+
+
 Keith Wannamaker (keith at apache.org)
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-trunk

2015-10-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/527

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1710728
Blamelist: kfujino

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2015-10-27 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-apr has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 49 mins 19 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151027-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-trunk/dest-20151027/lib 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20151027.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151027-native-src.tar.gz
 -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true -
 Dexecute.test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20151027/bin/openssl
 -Dexecute.test.apr=true -Dtest.excludePerformance=true 
-Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/outpu

Re: [VOTE] Release Apache Tomcat Native 1.2.0

2015-10-27 Thread Violeta Georgieva
2015-10-22 13:47 GMT+03:00 Mark Thomas :
>
> Version 1.2.0 includes the following changes:
> - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.2d
> - ALPN support
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.0 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

+1

Regards,
Violeta

>  [1]
>
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.0/
>  [2]
> https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_0
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>


svn commit: r1710753 - in /tomcat/trunk/java/org/apache: catalina/ant/jmx/ catalina/connector/ catalina/core/ catalina/servlets/ catalina/session/ catalina/tribes/membership/ catalina/tribes/tipis/ ca

2015-10-27 Thread violetagg
Author: violetagg
Date: Tue Oct 27 09:43:40 2015
New Revision: 1710753

URL: http://svn.apache.org/viewvc?rev=1710753&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58547
Use static valueOf instead of inefficient Number constructor. Based on a patch 
provided by Anthony Whitford.

Modified:
tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java
tomcat/trunk/java/org/apache/catalina/connector/Request.java
tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
tomcat/trunk/java/org/apache/catalina/session/StandardManager.java
tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java

tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
tomcat/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMap.java
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioSender.java
tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java
tomcat/trunk/java/org/apache/el/lang/ELSupport.java
tomcat/trunk/java/org/apache/jasper/compiler/Node.java
tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java
tomcat/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java
tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java
tomcat/trunk/java/org/apache/naming/factory/BeanFactory.java
tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java
tomcat/trunk/java/org/apache/tomcat/util/http/FastHttpDateFormat.java
tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/SocketProperties.java
tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java

Modified: tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java?rev=1710753&r1=1710752&r2=1710753&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java Tue Oct 
27 09:43:40 2015
@@ -502,7 +502,7 @@ public class JMXAccessorTask extends Bas
 Object convertValue = value;
 if ("java.lang.Integer".equals(valueType) || "int".equals(valueType)) {
 try {
-convertValue = new Integer(value);
+convertValue = Integer.valueOf(value);
 } catch (NumberFormatException ex) {
 if (isEcho())
 handleErrorOutput("Unable to convert to integer:" + value);
@@ -510,7 +510,7 @@ public class JMXAccessorTask extends Bas
 } else if ("java.lang.Long".equals(valueType)
 || "long".equals(valueType)) {
 try {
-convertValue = new Long(value);
+convertValue = Long.valueOf(value);
 } catch (NumberFormatException ex) {
 if (isEcho())
 handleErrorOutput("Unable to convert to long:" + value);
@@ -521,7 +521,7 @@ public class JMXAccessorTask extends Bas
 } else if ("java.lang.Float".equals(valueType)
 || "float".equals(valueType)) {
 try {
-convertValue = new Float(value);
+convertValue = Float.valueOf(value);
 } catch (NumberFormatException ex) {
 if (isEcho())
 handleErrorOutput("Unable to convert to float:" + value);
@@ -529,7 +529,7 @@ public class JMXAccessorTask extends Bas
 } else if ("java.lang.Double".equals(valueType)
 || "double".equals(valueType)) {
 try {
-convertValue = new Double(value);
+convertValue = Double.valueOf(value);
 } catch (NumberFormatException ex) {
 if (isEcho())
 handleErrorOutput("Unable to convert to double:" + value);

Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1710753&r1=1710752&r2=1710753&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Tue Oct 27 
09:43:40 2015
@@ -3184,7 +3184,7 @@ public class Request implements HttpServ
 
 for (AcceptLanguage acceptLanguage : acceptLanguages) {
 // Add a new Locale to the list of Locales for this quality level
-Double key = new Double(-acceptLanguage.getQuality());  // Reverse 
the order
+Double key = Dou

svn commit: r1710754 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2015-10-27 Thread violetagg
Author: violetagg
Date: Tue Oct 27 09:48:26 2015
New Revision: 1710754

URL: http://svn.apache.org/viewvc?rev=1710754&view=rev
Log:
Add findbugs exception for generated code

Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1710754&r1=1710753&r2=1710754&view=diff
==
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Tue Oct 27 09:48:26 
2015
@@ -564,6 +564,17 @@
 
 
   
+  
+
+  
+  
+
+
+  
+  
+
+
+  
 
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710755 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/servlets/ java/org/apa

2015-10-27 Thread violetagg
Author: violetagg
Date: Tue Oct 27 09:58:26 2015
New Revision: 1710755

URL: http://svn.apache.org/viewvc?rev=1710755&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58547
Merged revision 1710753 from tomcat/trunk:
Use static valueOf instead of inefficient Number constructor. Based on a patch 
provided by Anthony Whitford.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/Request.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/StandardManager.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/McastService.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMap.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/bio/BioSender.java
tomcat/tc8.0.x/trunk/java/org/apache/el/lang/ELArithmetic.java
tomcat/tc8.0.x/trunk/java/org/apache/el/lang/ELSupport.java
tomcat/tc8.0.x/trunk/java/org/apache/jasper/compiler/Node.java
tomcat/tc8.0.x/trunk/java/org/apache/jasper/compiler/PageInfo.java
tomcat/tc8.0.x/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java
tomcat/tc8.0.x/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
tomcat/tc8.0.x/trunk/java/org/apache/jasper/runtime/PageContextImpl.java
tomcat/tc8.0.x/trunk/java/org/apache/naming/factory/BeanFactory.java
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java

tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/http/FastHttpDateFormat.java
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/modeler/Registry.java
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/SocketProperties.java

tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Oct 27 09:58:26 2015
@@ -1 +1 @@
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644892
 
,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657592,1657607,1657
 
609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662736,1662985,1662988-1662989,1663264,166

svn commit: r1710756 - in /tomcat/tc8.0.x/trunk: ./ res/findbugs/filter-false-positives.xml

2015-10-27 Thread violetagg
Author: violetagg
Date: Tue Oct 27 10:01:34 2015
New Revision: 1710756

URL: http://svn.apache.org/viewvc?rev=1710756&view=rev
Log:
Merged revision 1710754 from tomcat/trunk:
Add findbugs exception for generated code

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/res/findbugs/filter-false-positives.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Oct 27 10:01:34 2015
@@ -1 +1 @@
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644892
 
,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657592,1657607,1657
 
609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1666387,1666494,1666496,1666552,1666569,1666579,1
 
37,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-1684527,1684549-1684550,1685556,1685591,1685739,1685744,168577
 
2,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1688563,1688841,1688878,165,1688896,1688901,1689345-1689346,1689357,1689656,1689675-1689677,1689679,1689687,1689825,1689856,1689918,1690011,1690021,1690054,1690080,1690209,1691134,1691487,1691813,1692744-1692747,1692849,1693088,1693105,1693429,1693461,1694058,1694111,1694290,1694501,1694548,1694658,1694660,1694788,1694872,1694878,1695006,1695354,1695371,1695379,1695459,1695582,1695706,1695778,16961

buildbot success in ASF Buildbot on tomcat-trunk

2015-10-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/528

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1710754
Blamelist: violetagg

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710760 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/servlets/ java/org/apa

2015-10-27 Thread violetagg
Author: violetagg
Date: Tue Oct 27 10:17:55 2015
New Revision: 1710760

URL: http://svn.apache.org/viewvc?rev=1710760&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58547
Merged revision 1710753 from tomcat/trunk:
Use static valueOf instead of inefficient Number constructor. Based on a patch 
provided by Anthony Whitford.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Request.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/session/StandardManager.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/membership/McastService.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMap.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/bio/BioSender.java
tomcat/tc7.0.x/trunk/java/org/apache/el/lang/ELArithmetic.java
tomcat/tc7.0.x/trunk/java/org/apache/el/lang/ELSupport.java
tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Node.java
tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/PageInfo.java
tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java
tomcat/tc7.0.x/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
tomcat/tc7.0.x/trunk/java/org/apache/jasper/runtime/PageContextImpl.java
tomcat/tc7.0.x/trunk/java/org/apache/naming/factory/BeanFactory.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/digester/XercesParser.java

tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/FastHttpDateFormat.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/modeler/Registry.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/SocketProperties.java

tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Oct 27 10:17:55 2015
@@ -1,2 +1,2 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702744,1702
 
748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578
-/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646

Re: [VOTE] Release Apache Tomcat Native 1.2.0

2015-10-27 Thread jean-frederic clere
On 10/22/2015 12:47 PM, Mark Thomas wrote:
> Version 1.2.0 includes the following changes:
> - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.2d
> - ALPN support
> 
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The Apache Tomcat Native 1.2.0 is
>  [X] Stable, go ahead and release

We need to get more people using it ;-)

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710761 - in /tomcat/tc7.0.x/trunk: ./ res/findbugs/filter-false-positives.xml

2015-10-27 Thread violetagg
Author: violetagg
Date: Tue Oct 27 10:19:53 2015
New Revision: 1710761

URL: http://svn.apache.org/viewvc?rev=1710761&view=rev
Log:
Merged revision 1710754 from tomcat/trunk:
Add findbugs exception for generated code

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Oct 27 10:19:53 2015
@@ -1,2 +1,2 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702744,1702
 
748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578
-/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222329,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112,1240114
 
,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342320,1342476,1342
 
498,1342503,1342717,1342795,1342805,1343044-1343046,1343335,1343394,1343400,1343629,1343708,1343718,1343895,1344063,1344068,1344250,1344266,1344515,1344528,1344612,1344629,1344725,1344868,1344890,1344893,1344896,1344901,1345020,1345029,1345039,1345287-1345290,1345294,1345309,1345325,1345357,1345367,1345579-1345580,1

[Bug 58547] Avoid new Integer and new Long instances when doing conversions

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58547

Violeta Georgieva  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Violeta Georgieva  ---
Hi,

Thanks for the report and the patch.
I applied the same fix on other places in the code also.
The fix is available in trunk, 8.0.x (for 8.0.29 onwards) and 7.0.x (for 7.0.66
onwards)

Regards,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710779 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2015-10-27 Thread violetagg
Author: violetagg
Date: Tue Oct 27 11:19:56 2015
New Revision: 1710779

URL: http://svn.apache.org/viewvc?rev=1710779&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58534
Removed repeated conditional test. Patch provided by Anthony Whitford.

Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

Modified: 
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java?rev=1710779&r1=1710778&r2=1710779&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java 
Tue Oct 27 11:19:56 2015
@@ -94,7 +94,7 @@ public class PojoMethodMapping {
 open = method;
 } else {
 if (currentClazz == clazzPojo ||
-(currentClazz != clazzPojo && 
!isMethodOverride(open, method))) {
+!isMethodOverride(open, method)) {
 // Duplicate annotation
 throw new DeploymentException(sm.getString(
 "pojoMethodMapping.duplicateAnnotation",
@@ -107,7 +107,7 @@ public class PojoMethodMapping {
 close = method;
 } else {
 if (currentClazz == clazzPojo ||
-(currentClazz != clazzPojo && 
!isMethodOverride(close, method))) {
+!isMethodOverride(close, method)) {
 // Duplicate annotation
 throw new DeploymentException(sm.getString(
 "pojoMethodMapping.duplicateAnnotation",
@@ -120,7 +120,7 @@ public class PojoMethodMapping {
 error = method;
 } else {
 if (currentClazz == clazzPojo ||
-(currentClazz != clazzPojo && 
!isMethodOverride(error, method))) {
+!isMethodOverride(error, method)) {
 // Duplicate annotation
 throw new DeploymentException(sm.getString(
 "pojoMethodMapping.duplicateAnnotation",
@@ -135,8 +135,7 @@ public class PojoMethodMapping {
 if 
(messageHandler.targetsSameWebSocketMessageType(otherMessageHandler)) {
 found = true;
 if (currentClazz == clazzPojo ||
-(currentClazz != clazzPojo
-&& !isMethodOverride(messageHandler.m, 
otherMessageHandler.m))) {
+!isMethodOverride(messageHandler.m, 
otherMessageHandler.m)) {
 // Duplicate annotation
 throw new DeploymentException(sm.getString(
 
"pojoMethodMapping.duplicateAnnotation",



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710783 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java webapps/docs/changelog.xml

2015-10-27 Thread violetagg
Author: violetagg
Date: Tue Oct 27 11:27:06 2015
New Revision: 1710783

URL: http://svn.apache.org/viewvc?rev=1710783&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58534
Merged revision 1710779 from tomcat/trunk:
Removed repeated conditional test. Patch provided by Anthony Whitford.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Oct 27 11:27:06 2015
@@ -1 +1 @@
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644892
 
,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657592,1657607,1657
 
609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1666387,1666494,1666496,1666552,1666569,1666579,1
 
37,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-1684527,1684549-1684550,1685556,1685591,1685739,1685744,168577
 
2,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1688563,1688841,1688878,165,1688896,1688901,1689345-1689346,1689357,1689656,1689675-1689677,1689679,1689687,1689825,1689856,1689918,1690011,1690021,1690054,1690080,169

[Bug 56415] EXCEPTION_ACCESS_VIOLATION (0xc0000005) in tcnative-1.dll

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56415

Barry Coughlan  changed:

   What|Removed |Added

 CC||b.coughl...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1710734 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2015-10-27 Thread Konstantin Kolinko
2015-10-27 10:50 GMT+03:00  :
> Author: mgrigorov
> Date: Tue Oct 27 07:50:01 2015
> New Revision: 1710734
>
> URL: http://svn.apache.org/viewvc?rev=1710734&view=rev
> Log:
> Add myself (mgrigorov) to the list of member/committers
>
>
> Modified:
> tomcat/site/trunk/docs/whoweare.html
> tomcat/site/trunk/xdocs/whoweare.xml
>
> Modified: tomcat/site/trunk/docs/whoweare.html
> URL: 
> http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whoweare.html?rev=1710734&r1=1710733&r2=1710734&view=diff
> ==
> --- tomcat/site/trunk/docs/whoweare.html (original)
> +++ tomcat/site/trunk/docs/whoweare.html Tue Oct 27 07:50:01 2015
> @@ -399,6 +399,12 @@ A complete list of all the Apache Commit
>
>
>  
> +Martin Grigorov (mgrigorov at apache.org)
> +
> +
> +
> +
> +
>  Keith Wannamaker (keith at apache.org)
>  
>
>
> Modified: tomcat/site/trunk/xdocs/whoweare.xml
> URL: 
> http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whoweare.xml?rev=1710734&r1=1710733&r2=1710734&view=diff
> ==
> --- tomcat/site/trunk/xdocs/whoweare.xml (original)
> +++ tomcat/site/trunk/xdocs/whoweare.xml Tue Oct 27 07:50:01 2015
> @@ -124,6 +124,9 @@ A complete list of all the Apache Commit
>  Mark Thomas (markt at apache.org)
>  
>
> +Martin Grigorov (mgrigorov at apache.org)
> +
> +
>  Keith Wannamaker (keith at apache.org)
>  


This page is sorted by family name. So I expect yours to be between
Gomez and  Hanik.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [ANN] New committer: Martin Grigorov

2015-10-27 Thread Konstantin Kolinko
2015-10-26 17:35 GMT+03:00 Mark Thomas :
> On behalf of the Tomcat committers I am pleased to announce that
> Martin Grigorov (mgrigorov) has been voted in as a new Tomcat committer.
>

Welcome!


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710805 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2015-10-27 Thread mgrigorov
Author: mgrigorov
Date: Tue Oct 27 13:03:11 2015
New Revision: 1710805

URL: http://svn.apache.org/viewvc?rev=1710805&view=rev
Log:
Use the correct comparator.

The list of names is sorted by family name.


Modified:
tomcat/site/trunk/docs/whoweare.html
tomcat/site/trunk/xdocs/whoweare.xml

Modified: tomcat/site/trunk/docs/whoweare.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whoweare.html?rev=1710805&r1=1710804&r2=1710805&view=diff
==
--- tomcat/site/trunk/docs/whoweare.html (original)
+++ tomcat/site/trunk/docs/whoweare.html Tue Oct 27 13:03:11 2015
@@ -303,6 +303,12 @@ A complete list of all the Apache Commit
 
 
 
+Martin Grigorov (mgrigorov at apache.org)
+
+
+
+
+
 Filip Hanik (fhanik at apache.org)
 
 
@@ -397,12 +403,6 @@ A complete list of all the Apache Commit
 
 
 
-
-
-Martin Grigorov (mgrigorov at apache.org)
-
-
-
 
 
 Keith Wannamaker (keith at apache.org)

Modified: tomcat/site/trunk/xdocs/whoweare.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whoweare.xml?rev=1710805&r1=1710804&r2=1710805&view=diff
==
--- tomcat/site/trunk/xdocs/whoweare.xml (original)
+++ tomcat/site/trunk/xdocs/whoweare.xml Tue Oct 27 13:03:11 2015
@@ -76,6 +76,9 @@ A complete list of all the Apache Commit
 Henri Gomez (hgomez at apache.org)
 
 
+Martin Grigorov (mgrigorov at apache.org)
+
+
 Filip Hanik (fhanik at apache.org)
 
 
@@ -124,9 +127,6 @@ A complete list of all the Apache Commit
 Mark Thomas (markt at apache.org)
 
 
-Martin Grigorov (mgrigorov at apache.org)
-
-
 Keith Wannamaker (keith at apache.org)
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1710734 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2015-10-27 Thread Martin Grigorov
On Tue, Oct 27, 2015 at 2:59 PM, Konstantin Kolinko 
wrote:

> This page is sorted by family name. So I expect yours to be between
> Gomez and  Hanik.
>

Fixed!
Thanks!

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov


svn commit: r1710812 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java webapps/docs/changelog.xml

2015-10-27 Thread violetagg
Author: violetagg
Date: Tue Oct 27 13:36:03 2015
New Revision: 1710812

URL: http://svn.apache.org/viewvc?rev=1710812&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58534
Merged revision 1710779 from tomcat/trunk:
Removed repeated conditional test. Patch provided by Anthony Whitford.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Oct 27 13:36:03 2015
@@ -1,2 +1,2 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702744,1702
 
748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578
-/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222329,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112,1240114
 
,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342320,1342476,1342
 
498,1342503,1342717,1342795,1342805,1343044-1343046,1343335,1343394,1343400,1343629

[Bug 58194] Tomcat crash EXCEPTION_ACCESS_VIOLATION in tcnative-1.dll

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58194

--- Comment #2 from Barry Coughlan  ---
Also experiencing this issue with 8.0.28 / 1.1.33

We also see these exceptions in the logs:

27-Oct-2015 14:08:15.611 WARNING [http-apr-8081-Poller]
org.apache.tomcat.util.net.AprEndpoint$Poller.run Unexpected poller error
 java.lang.NullPointerException
at
org.apache.tomcat.util.net.AprEndpoint$AprSocketWrapper.access$400(AprEndpoint.java:2522)
at org.apache.tomcat.util.net.AprEndpoint$Poller.run(AprEndpoint.java:1837)
at java.lang.Thread.run(Unknown Source)

Sometimes we get heap dumps in the
tcnative_1!Java_org_apache_tomcat_jni_Poll_poll+235 (same as bug 57140 ), but
these could be unrelated issues.

Is there any more info we could provide that would help with this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58534] Repeated Conditional Test

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58534

Violeta Georgieva  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #3 from Violeta Georgieva  ---
Hi,

Thanks for the report and the patch.
The fix is available in trunk, 8.0.x (for 8.0.29 onwards) and 7.0.x (for 7.0.66
onwards)

Regards,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [ANN] New committer: Martin Grigorov

2015-10-27 Thread Martin Grigorov
On Tue, Oct 27, 2015 at 3:00 PM, Konstantin Kolinko 
wrote:

> 2015-10-26 17:35 GMT+03:00 Mark Thomas :
> > On behalf of the Tomcat committers I am pleased to announce that
> > Martin Grigorov (mgrigorov) has been voted in as a new Tomcat committer.
> >
>
> Welcome!
>
>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
Thank you everyone for the warm welcome!


svn commit: r1710834 - /tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

2015-10-27 Thread remm
Author: remm
Date: Tue Oct 27 15:05:45 2015
New Revision: 1710834

URL: http://svn.apache.org/viewvc?rev=1710834&view=rev
Log:
Remove "optimization" to avoid creating the SSLSession, since it is always used 
in Tomcat and looks cheap to create.

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java?rev=1710834&r1=1710833&r2=1710834&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java Tue 
Oct 27 15:05:45 2015
@@ -30,7 +30,6 @@ import java.util.List;
 import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;
-import java.util.concurrent.atomic.AtomicReferenceFieldUpdater;
 
 import javax.net.ssl.SSLEngine;
 import javax.net.ssl.SSLEngineResult;
@@ -107,7 +106,6 @@ public final class OpenSSLEngine extends
 RENEGOTIATION_UNSUPPORTED.setStackTrace(new StackTraceElement[0]);
 ENCRYPTED_PACKET_OVERSIZED.setStackTrace(new StackTraceElement[0]);
 DESTROYED_UPDATER = 
AtomicIntegerFieldUpdater.newUpdater(OpenSSLEngine.class, "destroyed");
-SESSION_UPDATER = 
AtomicReferenceFieldUpdater.newUpdater(OpenSSLEngine.class, SSLSession.class, 
"session");
 }
 
 private static final int MAX_PLAINTEXT_LENGTH = 16 * 1024; // 2^14
@@ -140,7 +138,6 @@ public final class OpenSSLEngine extends
 }
 
 private static final AtomicIntegerFieldUpdater 
DESTROYED_UPDATER;
-private static final AtomicReferenceFieldUpdater SESSION_UPDATER;
 
 private static final String INVALID_CIPHER = "SSL_NULL_WITH_NULL_NULL";
 
@@ -180,7 +177,7 @@ public final class OpenSSLEngine extends
 
 private String selectedProtocol = null;
 
-private volatile SSLSession session;
+private final OpenSSLSession session;
 
 /**
  * Creates a new instance
@@ -198,6 +195,7 @@ public final class OpenSSLEngine extends
 if (sslCtx == 0) {
 throw new 
IllegalArgumentException(sm.getString("engine.noSSLContext"));
 }
+session = new OpenSSLSession();
 ssl = SSL.newSSL(sslCtx, !clientMode);
 networkBIO = SSL.makeNetworkBIO(ssl);
 this.fallbackApplicationProtocol = fallbackApplicationProtocol;
@@ -427,12 +425,12 @@ public final class OpenSSLEngine extends
 // Do we have enough room in dst to write encrypted data?
 int capacity = dst.remaining();
 if (capacity < pendingNet) {
-return new 
SSLEngineResult(SSLEngineResult.Status.BUFFER_OVERFLOW, handshakeStatus, 0, 
bytesProduced);
+return new 
SSLEngineResult(SSLEngineResult.Status.BUFFER_OVERFLOW, handshakeStatus, 0, 0);
 }
 
 // Write the pending data from the network BIO into the dst buffer
 try {
-bytesProduced += readEncryptedData(dst, pendingNet);
+bytesProduced = readEncryptedData(dst, pendingNet);
 } catch (Exception e) {
 throw new SSLException(e);
 }
@@ -879,242 +877,6 @@ public final class OpenSSLEngine extends
 
 @Override
 public SSLSession getSession() {
-// A other methods on SSLEngine are thread-safe we also need to make 
this thread-safe...
-SSLSession session = this.session;
-if (session == null) {
-session = new SSLSession() {
-// SSLSession implementation seems to not need to be 
thread-safe so no need for volatile etc.
-private X509Certificate[] x509PeerCerts;
-
-// lazy init for memory reasons
-private Map values;
-
-@Override
-public byte[] getId() {
-// We don't cache that to keep memory usage to a minimum.
-byte[] id = SSL.getSessionId(ssl);
-if (id == null) {
-// The id should never be null, if it was null then 
the SESSION itself was not valid.
-throw new 
IllegalStateException(sm.getString("engine.noSession"));
-}
-return id;
-}
-
-@Override
-public SSLSessionContext getSessionContext() {
-return sessionContext;
-}
-
-@Override
-public long getCreationTime() {
-// We need ot multiple by 1000 as openssl uses seconds and 
we need milli-seconds.
-return SSL.getTime(ssl) * 1000L;
-}
-
-@Override
-public long getLastAccessedTime() {
-  

[Bug 58518] SSL connection failed (Time out)

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58518

--- Comment #2 from Christopher Schultz  ---
Potential (untested) workaround: use a "file:" URL to specify your keystore
file on the filesystem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Tomcat 9.0.x, tc-native and itanium support

2015-10-27 Thread Christopher Schultz
Mark,

On 10/22/15 6:31 AM, Mark Thomas wrote:
> I've been having problems building OpenSSL 1.0.2d for Windows Itanium
> 64-bit as part of building the tcnative binaries for Windows.
> 
> Given that the last Windows platform to support Itanium is Server 2008
> R2 and that that has already entered extended support (with that due to
> end in Jan 2020) how do folks feel about dropping the Itanium build from
> the binary packages for tcnative 1.2.x and Tomcat 9.0.x?

+1

I wouldn't bother actually /removing/ any of the Itanium support from
the build -- at least not yet. If someone complains, we can always add
it back.

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710835 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Endpoint.java SocketWrapperBase.java

2015-10-27 Thread remm
Author: remm
Date: Tue Oct 27 15:16:04 2015
New Revision: 1710835

URL: http://svn.apache.org/viewvc?rev=1710835&view=rev
Log:
- Add an extra async IO flag I used for testing.
- Blocking should block.

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java?rev=1710835&r1=1710834&r2=1710835&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Tue Oct 27 
15:16:04 2015
@@ -954,6 +954,11 @@ public class Nio2Endpoint extends Abstra
 }
 }
 
+@Override
+public boolean hasAsyncIO() {
+return false;
+}
+
 /**
  * Internal state tracker for scatter/gather operations.
  */
@@ -978,8 +983,8 @@ public class Nio2Endpoint extends Abstra
 this.check = check;
 this.handler = handler;
 }
-private long nBytes = 0;
-private CompletionState state = CompletionState.PENDING;
+private volatile long nBytes = 0;
+private volatile CompletionState state = CompletionState.PENDING;
 }
 
 private class ScatterReadCompletionHandler implements 
CompletionHandler> {
@@ -1127,6 +1132,9 @@ public class Nio2Endpoint extends Abstra
 } else {
 throw new WritePendingException();
 }
+if (block && state.state == CompletionState.PENDING && 
writePending.tryAcquire(timeout, unit)) {
+writePending.release();
+}
 } catch (InterruptedException e) {
 handler.failed(e, attachment);
 }

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java?rev=1710835&r1=1710834&r2=1710835&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java Tue Oct 
27 15:16:04 2015
@@ -662,6 +662,14 @@ public abstract class SocketWrapperBase<
 };
 
 /**
+ * Allows using NIO2 style read/write only for connectors that can
+ * efficiently support it.
+ */
+public boolean hasAsyncIO() {
+return false;
+}
+
+/**
  * Scatter read. The completion handler will be called once some
  * data has been read or an error occurred. If a CompletionCheck
  * object has been provided, the completion handler will only be



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Tomcat 9.0.x, tc-native and itanium support

2015-10-27 Thread Rémy Maucherat
2015-10-22 12:31 GMT+02:00 Mark Thomas :

> I've been having problems building OpenSSL 1.0.2d for Windows Itanium
> 64-bit as part of building the tcnative binaries for Windows.
>
> Given that the last Windows platform to support Itanium is Server 2008
> R2 and that that has already entered extended support (with that due to
> end in Jan 2020) how do folks feel about dropping the Itanium build from
> the binary packages for tcnative 1.2.x and Tomcat 9.0.x?
>
> +1 for removing.

Rémy


Re: Tomcat 9.0.x, tc-native and itanium support

2015-10-27 Thread jean-frederic clere
On 10/22/2015 12:31 PM, Mark Thomas wrote:
> how do folks feel about dropping the Itanium build from
> the binary packages for tcnative 1.2.x and Tomcat 9.0.x?


DROP IT!!!

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Tomcat Grid

2015-10-27 Thread Alarcón Vladimir
Hi guys,

Soon I'll have bandwidth to work on the Tomcat Grid. I think I can develop the 
proof of concept in short time so we can have a discussion on the features we 
could add later on. My idea is to divide this project in many small increments. 

So far I reached the basic operations to start/stop Tomcat instances from a 
centralized location and to get the basic JVM stats (resource utilization) 
through JMX. I developed two interfaces: a command line interface, and a simple 
web interface. All is written in Java including the grid agents. So far I'm 
using fair minimal configuration files, but I have the design of the 
comprehensive configuration files.

Well, I need to decide what would be the next steps, but before I do so, I 
would like to store the code in a repository. I hate to keep the code on my 
hard drive only. Can you provide me with a repo. I can easily do SVN or GIT. 

Thanks,
Vladimir


On Tue, 5/5/15, Alarcón Vladimir  wrote:

 Subject: Tomcat Grid
 To: dev@tomcat.apache.org
 Date: Tuesday, May 5, 2015, 1:55 PM
 
 Hi, for a few months I was wondering
 about an extension for Tomcat but I'm not sure if there
 would be interest from the part of the Tomcat team.
 
 It's about managing multiple Tomcat servers across multiple
 machines, from one (or more) centralized location, something
 like a "Grid Admin". Anyway, the thing is that when you have
 many Tomcat servers, it could be useful to perform basic
 operations from a web or command-line interface, so to
 start, stop, restart, and (sometimes) kill Tomcat servers.
 
 My work includes developing web applications and also
 managing production deployments for clusters of small
 clusters of 2 servers to clusters of 70 servers, and when
 you have that many, it's a pain in the neck to manage them
 one by one.
 
 I think I can write a basic proof of concept, but I would
 like to find out if it's worth it or not.
 
 Thank you,
 Vlad
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1710835 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Endpoint.java SocketWrapperBase.java

2015-10-27 Thread Rémy Maucherat
2015-10-27 16:16 GMT+01:00 :

> Author: remm
> Date: Tue Oct 27 15:16:04 2015
> New Revision: 1710835
>
> URL: http://svn.apache.org/viewvc?rev=1710835&view=rev
> Log:
> - Add an extra async IO flag I used for testing.
> - Blocking should block.
>
> It's possible I'll remove this code eventually.

SSL really gets in the way of possible gather optimizations (it wants a
direct buffer), and scatter is hard to use. I now think it will perform
worse. However, this sort of API could be used to produce a true async impl
of HTTP/2, while the current one is async/blocking, and also do away with
the plumbing for IO dispatches (they are a completion handler invocation,
end of story) and state tracking needed to avoid a true async impl.

Example (writing the GOAWAY frame):

try {
synchronized (socketWrapper) {
socketWrapper.write(true, payloadLength, 0,
payloadLength.length);
socketWrapper.write(true, GOAWAY, 0, GOAWAY.length);
socketWrapper.write(true, fixedPayload, 0, 8);
socketWrapper.flush(true);
}
} catch (IOException ioe) {
// This is fatal for the connection. Ignore it here. There
will be
// further attempts at I/O in upgradeDispatch() and it can
better
// handle the IO errors.
}

Becomes:

socketWrapper.write(true, getWriteTimeout(),
TimeUnit.MILLISECONDS, null, SocketWrapperBase.COMPLETE_WRITE, null,
ByteBuffer.wrap(payloadLength),
ByteBuffer.wrap(GOAWAY), ByteBuffer.wrap(fixedPayload));

The code looks nicer IMO (I did rewrite the Http2UpgradeHandler with that
to see if it helped me debug or solved the HTTP/2 issues).

So it's "meh" overall and I won't use it for now, but I'd like to keep it
for a possible async impl.

Rémy


[Bug 58538] McastServiceImpl run uses bitwise and

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58538

--- Comment #1 from Christopher Schultz  ---
http://stackoverflow.com/questions/1724205/effect-of-a-bitwise-operator-on-a-boolean-in-java

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58539] WsFrameBase processDataText uses bitwise and

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58539

--- Comment #1 from Christopher Schultz  ---
In contrast to bug #58538, this one does not require non-short-circuiting
evaluation semantics. I think in this case, it was probably intended to be a
logical && operation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-trunk

2015-10-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/530

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1710834
Blamelist: remm

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58508] role_name in tomcat-users.xml : invalid character

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58508

Fred 33  changed:

   What|Removed |Added

Version|6.0.44  |7.0.57
  Component|Catalina|Catalina
   Target Milestone|default |---
Product|Tomcat 6|Tomcat 7

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-trunk

2015-10-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/531

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1710835
Blamelist: remm

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Java 7 and 8 features

2015-10-27 Thread Vinicius Corrêa de Almeida
I analized some releases and i noticed that not using java 7 features like
multi catch and in java 8 do not use lambda expressions and others
features, so i came by this email to know why the developers not using this
features?


Re: Java 7 and 8 features

2015-10-27 Thread Oliver B. Fischer

Hi Vinicius,

it is mostly to allow people which are bound (for any reason) to older 
JDK versions to use our software. There is a plenty number of projects 
which are not able to use newer JDK versions. I know that this is a 
controversial topic I think that the majority of us would like to use 
all these features. But we must not forget the people using our software 
in their daily work.


BYe,

Oliver

Am 27.10.15 um 16:49 schrieb Vinicius Corrêa de Almeida:

I analized some releases and i noticed that not using java 7 features like
multi catch and in java 8 do not use lambda expressions and others
features, so i came by this email to know why the developers not using this
features?



--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fisc...@swe-blog.net
S oliver.b.fischer
J oliver.b.fisc...@jabber.org
X http://xing.to/obf



Re: Java 7 and 8 features

2015-10-27 Thread Gary Gregory
Hi,

What I see, is that most projects are struggling to move to Java 7, Java 8
seems out of range. There are a lot of opinions and both sides of each Java
version for and against. At the end of the day, it's about user feedback
and committer community involvement. The projects I help on also lack
manpower and maintaining more than one version is not I see folks wanting
to do. For myself, I usually want to work on the current version in
master/trunk and move that along. My work$ development is on Java 7 and
slated to switch to Java 8 in 2016 I would guess.

Gary

On Tue, Oct 27, 2015 at 9:37 AM, Oliver B. Fischer  wrote:

> Hi Vinicius,
>
> it is mostly to allow people which are bound (for any reason) to older JDK
> versions to use our software. There is a plenty number of projects which
> are not able to use newer JDK versions. I know that this is a
>  controversial topic I think that the majority of us would like to use all
> these features. But we must not forget the people using our software in
> their daily work.
>
> BYe,
>
> Oliver
>
> Am 27.10.15 um 16:49 schrieb Vinicius Corrêa de Almeida:
>
>> I analized some releases and i noticed that not using java 7 features like
>> multi catch and in java 8 do not use lambda expressions and others
>> features, so i came by this email to know why the developers not using
>> this
>> features?
>>
>>
> --
> N Oliver B. Fischer
> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> P +49 30 44793251
> M +49 178 7903538
> E o.b.fisc...@swe-blog.net
> S oliver.b.fischer
> J oliver.b.fisc...@jabber.org
> X http://xing.to/obf
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Java 7 and 8 features

2015-10-27 Thread Maxim Solodovnik
We are just moved to java7 and start using new features
I personally don't like the idea of moving all code to new java, I move the
areas I currently work on

On Tue, Oct 27, 2015 at 10:57 PM, Gary Gregory 
wrote:

> Hi,
>
> What I see, is that most projects are struggling to move to Java 7, Java 8
> seems out of range. There are a lot of opinions and both sides of each Java
> version for and against. At the end of the day, it's about user feedback
> and committer community involvement. The projects I help on also lack
> manpower and maintaining more than one version is not I see folks wanting
> to do. For myself, I usually want to work on the current version in
> master/trunk and move that along. My work$ development is on Java 7 and
> slated to switch to Java 8 in 2016 I would guess.
>
> Gary
>
> On Tue, Oct 27, 2015 at 9:37 AM, Oliver B. Fischer <
> o.b.fisc...@swe-blog.net> wrote:
>
>> Hi Vinicius,
>>
>> it is mostly to allow people which are bound (for any reason) to older
>> JDK versions to use our software. There is a plenty number of projects
>> which are not able to use newer JDK versions. I know that this is a
>>  controversial topic I think that the majority of us would like to use all
>> these features. But we must not forget the people using our software in
>> their daily work.
>>
>> BYe,
>>
>> Oliver
>>
>> Am 27.10.15 um 16:49 schrieb Vinicius Corrêa de Almeida:
>>
>>> I analized some releases and i noticed that not using java 7 features
>>> like
>>> multi catch and in java 8 do not use lambda expressions and others
>>> features, so i came by this email to know why the developers not using
>>> this
>>> features?
>>>
>>>
>> --
>> N Oliver B. Fischer
>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>> P +49 30 44793251
>> M +49 178 7903538
>> E o.b.fisc...@swe-blog.net
>> S oliver.b.fischer
>> J oliver.b.fisc...@jabber.org
>> X http://xing.to/obf
>>
>>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
WBR
Maxim aka solomax


Re: Java 7 and 8 features

2015-10-27 Thread Andrew Gaul
Related to Java versions, Apache jclouds uses modernizer-maven-plugin to
encourage use of modern Java APIs such as ArrayList,
String.getBytes(Charset), etc.:

https://github.com/andrewgaul/modernizer-maven-plugin

On Tue, Oct 27, 2015 at 01:49:41PM -0200, Vinicius Corrêa de Almeida wrote:
> I analized some releases and i noticed that not using java 7 features like
> multi catch and in java 8 do not use lambda expressions and others
> features, so i came by this email to know why the developers not using this
> features?

-- 
Andrew Gaul
http://gaul.org/

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58538] McastServiceImpl run uses bitwise and

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58538

Violeta Georgieva  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #2 from Violeta Georgieva  ---
Hi,

With this commit [1] this issue is specified as false positive.

I would recommend to filter your results using
http://svn.apache.org/repos/asf/tomcat/tc8.0.x/trunk/res/findbugs/filter-false-positives.xml

We update the filter as soon as we found that an issue is false positives.

Regards,
Violeta

[1] http://svn.apache.org/viewvc?view=revision&revision=1059342

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2015-10-27 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 48 mins 47 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151027-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20151027.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151027-native-src.tar.gz
 -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-ma
 ster/dest-20151027/bin/openssl -Dexecute.test.apr=false 
-Dtest.excludePerformance=true -Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib

Re: Adding request/session valve to Tomcat

2015-10-27 Thread Christopher Schultz


On 10/25/15 9:40 AM, Milo van der Zee wrote:
> Hello,
> 
> There are some default valves available with Tomcat. None of these
> expose the request to later phases in the request cycle. Is it an idea
> to add a valve that does this? And make this available through a
> callback in the jaas loginModule. Just like WebLogic and Websphere do
> it. Or just use a static threadlocal variable in the valve with a static
> getter.
> 
> Why?
> If the jaas login module needs to communicate anything to the filter or
> other request phases this is needed. When the request is available this
> info can (for example) be added to the session.
> Or when someone wants to use request info for jaas authentication this
> could also be used.
> 
> Thanks for any ideas or comments.

Are you asking about access to the internal Tomcat "Request" object, or
are you asking about the HttpServletRequest?

I know it's inconvenient in Tomcat authenticators not to be able to get
things like the remote user's IP address -- for example, to log a failed
login attempt.

There is some discussion going on right now about using JASPIC as an
authentication API; perhaps you could join that discussion and advocate
for access to some of this information.

I would certainly be interested in having access to information from the
user's request during authentication.

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58551] Support plain and ssl on the same port

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58551

--- Comment #5 from Christopher Schultz  ---
This is somewhat related to the long-standing request (can't find the
enhancement in BZ at the moment) to emit a plain-text error message from a TLS
connector that is contacted by a non-TLS client. This is something that Apache
httpd does right now and would be nice to have similar support in Tomcat. Many
recent changes in the way that TLS has been implemented in Tomcat make the
above possible at this point.

Once we are able to handle plaintext-over-TLS, it is theoretically possible to
be able to use plaintext for the whole conversation.

But right now, I'd say that I'm -1 on the idea of providing insecure and secure
communications over the same channel, excepting the use-case above, which is
*very* helpful for clients who are perhaps connecting to non-standard ports.

The HTTP spec had a recent revision, and nobody seems to have thought of
putting dual-use channels into the spec. It's just not that hard to configure
two separate ports.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.2.0

2015-10-27 Thread Christopher Schultz
Mark,

On 10/26/15 3:48 PM, Mark Thomas wrote:
> Ping.
> 
> Currently this release only has two votes. 9.0.x requires a 1.2.x
> tcnative so this is currently blocking any work on a 9.0.0.RC1 release.
> 
> Additional testing and votes would be very welcome.

I'll give it a try.

It would be great if some Windows users could weigh-in.

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58554] Cannot output html from jsp files inside of lambdas

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58554

--- Comment #1 from Christopher Schultz  ---
Should this usage of request.getContentLength be changed to use
request.getHeader("Content-Length") to avoid the 2GiB primitive int limit?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Tomcat Grid

2015-10-27 Thread Christopher Schultz
Vladimir,

On 10/27/15 11:30 AM, Alarcón Vladimir wrote:
> Soon I'll have bandwidth to work on the Tomcat Grid. I think I can
> develop the proof of concept in short time so we can have a
> discussion on the features we could add later on. My idea is to
> divide this project in many small increments.
> 
> So far I reached the basic operations to start/stop Tomcat instances
> from a centralized location and to get the basic JVM stats (resource
> utilization) through JMX. I developed two interfaces: a command line
> interface, and a simple web interface. All is written in Java
> including the grid agents. So far I'm using fair minimal
> configuration files, but I have the design of the comprehensive
> configuration files.
> 
> Well, I need to decide what would be the next steps, but before I do
> so, I would like to store the code in a repository. I hate to keep
> the code on my hard drive only. Can you provide me with a repo. I can
> easily do SVN or GIT.

I think the best place for you is probably GitHub. Unless there is wide
support for hosting your project within the Tomcat svn repo (which I
doubt at this point), getting into the ASF revision-control system is
going to take you a long time.

Just make sure you tell GitHub that you are developing an open-source
project and it will be free.

-chris

> 
> On Tue, 5/5/15, Alarcón Vladimir  wrote:
> 
>  Subject: Tomcat Grid
>  To: dev@tomcat.apache.org
>  Date: Tuesday, May 5, 2015, 1:55 PM
>  
>  Hi, for a few months I was wondering
>  about an extension for Tomcat but I'm not sure if there
>  would be interest from the part of the Tomcat team.
>  
>  It's about managing multiple Tomcat servers across multiple
>  machines, from one (or more) centralized location, something
>  like a "Grid Admin". Anyway, the thing is that when you have
>  many Tomcat servers, it could be useful to perform basic
>  operations from a web or command-line interface, so to
>  start, stop, restart, and (sometimes) kill Tomcat servers.
>  
>  My work includes developing web applications and also
>  managing production deployments for clusters of small
>  clusters of 2 servers to clusters of 70 servers, and when
>  you have that many, it's a pain in the neck to manage them
>  one by one.
>  
>  I think I can write a basic proof of concept, but I would
>  like to find out if it's worth it or not.
>  
>  Thank you,
>  Vlad
>  
>  
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58554] Cannot output html from jsp files inside of lambdas

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58554

--- Comment #2 from Christopher Schultz  ---
Obviously, comment #1 was attached to the wrong bug. Apologies for the noise.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58544] RequestDumperFilter contentLength inefficiently creating Integer

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58544

--- Comment #2 from Christopher Schultz  ---
Should this usage of request.getContentLength be changed to use
request.getHeader("Content-Length") to avoid the 2GiB primitive int limit?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58530] Proposal for new Manager HTML GUI

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58530

--- Comment #3 from Christopher Schultz  ---
This can easily degenerate into a holy war, but I do have a few comments:

(In reply to Ognjen Blagojevic from comment #2)
> I find "zebra stripes" a bit of a retro. Most products I use from large
> companies (meaning they are probably hiring professional designers) don't
> use zebra stripes (YMMV). E.g:
> 
> 1. Mozilla Thunderbird

tb still uses zebra stripes, though they are minimal (unless you have a theme
that removes them).

> 2. Microsoft Windows Explorer
> 3. Google GMail (*)
> 4. Adobe Acrobat Reader (*)
> 5. Atlassian JIRA (*)

I wouldn't use JIRA as an example of a good UI ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58551] Support plain and ssl on the same port

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58551

--- Comment #6 from romain.manni-bucau  ---
The "not that hard" is really dependent on your environment. Not being in the
spec is one thing and you seem to keep speaking of web applications where the
most common use case for such a feature is webservices IMO (allowing "internal"
not secured communication and "external" secured communications).

I wouldnt activate it by defaut as well but I would add a flag on the connector
to be able to do so (acceptPlain=true on a SSL connector for instance).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58551] Support plain and ssl on the same port

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58551

--- Comment #7 from Christopher Schultz  ---
(In reply to romain.manni-bucau from comment #6)
> The "not that hard" is really dependent on your environment.

Fair enough, but you mentioned embedded environment: very easy to add another
connector programmatically.

> Not being in
> the spec is one thing and you seem to keep speaking of web applications
> where the most common use case for such a feature is webservices

What's the difference between a "web application" and a "webservice"?

> IMO (allowing "internal" not secured communication and "external"
> secured communications)

I understand, and I operate such an environment. I also happen to operate in a
"cloud" environment where I have never had any problems connecting things
together, whether using HTTP or HTTPS.

> I wouldn't activate it by default as well but I would add a flag on the
> connector to be able to do so (acceptPlain=true on a SSL connector for
> instance).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58551] Support plain and ssl on the same port

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58551

--- Comment #8 from romain.manni-bucau  ---
A webservice doesnt have all the "browser" constraints and defaults (where all
comments are right).

I used few providers where you were not able to bind any other port than one in
a reliable manner - you can hardcode instead of using the environment variable
for such an additional port but then it can be forbidden or already used. Also
saw cases on AWS where you can only redirect a single port (using docker as
container of your tomcat).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2015-10-27 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-apr has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 51 mins 36 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151027-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-trunk/dest-20151027/lib 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20151027.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151027-native-src.tar.gz
 -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true -
 Dexecute.test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20151027/bin/openssl
 -Dexecute.test.apr=true -Dtest.excludePerformance=true 
-Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/outpu

[Bug 58551] Support plain and ssl on the same port

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58551

--- Comment #9 from Christopher Schultz  ---
(In reply to romain.manni-bucau from comment #8)
> A webservice doesnt have all the "browser" constraints and defaults (where
> all comments are right).

I think you are introducing a semantic difference where there is none: a web
service and a web application are the same thing. The fact that a browser is
one kind of client is irrelevant.

The point Mark was trying to make (if I may be so bold) was that "the web" (by
whatever definition) already recognizes separate official ports for HTTP and
HTTPS, so being able to switch protocols on a single port is inappropriate.

If you want to multiplex protocols over a single port, use some kind of service
out in front of Tomcat that understands how to do that, and leave Tomcat out of
it. This is unnecessary complexity for a product like Tomcat.

> I used few providers where you were not able to bind any other port than one
> in a reliable manner - you can hardcode instead of using the environment
> variable for such an additional port but then it can be forbidden or already
> used. Also saw cases on AWS where you can only redirect a single port (using
> docker as container of your tomcat).

Sounds like your suitcase of tools are failing you. AWS itself imposes no such
limitations.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58508] role_name in tomcat-users.xml : invalid character

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58508

Mark Thomas  changed:

   What|Removed |Added

   Target Milestone|--- |default
  Component|Catalina|Catalina
Version|7.0.57  |6.0.44
Product|Tomcat 7|Tomcat 6

--- Comment #2 from Mark Thomas  ---
Restore correct version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710924 - /tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java

2015-10-27 Thread markt
Author: markt
Date: Wed Oct 28 01:57:46 2015
New Revision: 1710924

URL: http://svn.apache.org/viewvc?rev=1710924&view=rev
Log:
Action kkolinko's review comments on r1710445
Remove unnecessary isFile() call and use a FileInputStream for a file rather 
than going via a URL

Modified:
tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java?rev=1710924&r1=1710923&r2=1710924&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java Wed Oct 
28 01:57:46 2015
@@ -18,6 +18,7 @@
 package org.apache.tomcat.util.file;
 
 import java.io.File;
+import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.net.URI;
@@ -57,31 +58,21 @@ public class ConfigFileLoader {
  * provided location
  */
 public static InputStream getInputStream(String location) throws 
IOException {
-// Absolute URIs will be left alone
-// Relative files will be resolved relative to catalina base
-// Absolute files will be converted to URIs
-
-URI uri = null;
-
 // Location was originally always a file before URI support was added 
so
 // try file first.
 
-// First guess, an absolute file path
 File f = new File(location);
-if (!f.isFile()) {
-// Second guess, a file path relative to CATALINA_BASE
-if (!f.isAbsolute()) {
-f = new File(CATALINA_BASE_FILE, location);
-}
+if (!f.isAbsolute()) {
+f = new File(CATALINA_BASE_FILE, location);
 }
 if (f.isFile()) {
-uri = f.getAbsoluteFile().toURI();
+return new FileInputStream(f);
 }
 
-if (uri == null) {
-// Third and final guess, a URI
-uri = CATALINA_BASE_URI.resolve(location);
-}
+// File didn't work so try URI.
+// Using resolve() enables the code to handle relative paths that did
+// not point to a file
+URI uri = CATALINA_BASE_URI.resolve(location);
 
 // Obtain the input stream we need
 URL url = uri.toURL();



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710925 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/file/ConfigFileLoader.java

2015-10-27 Thread markt
Author: markt
Date: Wed Oct 28 01:59:00 2015
New Revision: 1710925

URL: http://svn.apache.org/viewvc?rev=1710925&view=rev
Log:
Action kkolinko's review comments on r1710445
Remove unnecessary isFile() call and use a FileInputStream for a file rather 
than going via a URL

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Oct 28 01:59:00 2015
@@ -1 +1 @@
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644892
 
,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657592,1657607,1657
 
609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1666387,1666494,1666496,1666552,1666569,1666579,1
 
37,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-1684527,1684549-1684550,1685556,1685591,1685739,1685744,168577
 
2,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1688563,1688841,1688878,165,1688896,1688901,1689345-1689346,1689357,1689656,1689675-1689677,1689679,1689687,1689825,1689856,1689918,1690011,1690021,1690054,1690080,1690209,1691134,1691487,1691813,1692744-1692747,1692849,1693088,1693105,1693429,1693461,1694058,1694111,1694290,1694501,1694548,1694658,1694660,1694788,1694872,169487

[Bug 56777] Allow configuration resources to be loaded from places other than straight off the filesystem

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56777

--- Comment #17 from Mark Thomas  ---
Yep, that is pretty much the solution I came up with.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58530] Proposal for new Manager HTML GUI

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58530

--- Comment #4 from Mark Thomas  ---
Ah. I missed the row higlighting on hover. I'm going to blame viewing angle /
lack of sleep ;)

I tried uncommenting line 249 and I do think it looks better. But that is just
my opinon. This is your improvement so go with what you think looks best. I'm
sure it is going to be better than what we have at the moment. The highlight on
hover is sufficient for the user to be sure they are working with the app they
think they are.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE][RESULT] Release Apache Tomcat Native 1.2.0

2015-10-27 Thread Mark Thomas
The following votes were cast:

Binding:
+1: markt, remm, violetagg, jfclere

This vote therefore passes.

Thanks all.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r10947 - /dev/tomcat/tomcat-connectors/native/1.2.0/ /release/tomcat/tomcat-connectors/native/1.2.0/

2015-10-27 Thread markt
Author: markt
Date: Wed Oct 28 02:35:07 2015
New Revision: 10947

Log:
Release Tomcat native 1.2.0

Added:
release/tomcat/tomcat-connectors/native/1.2.0/
  - copied from r10946, dev/tomcat/tomcat-connectors/native/1.2.0/
Removed:
dev/tomcat/tomcat-connectors/native/1.2.0/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710930 - in /tomcat/trunk/java/org/apache: catalina/servlets/WebdavServlet.java catalina/tribes/membership/McastService.java jasper/compiler/PageInfo.java

2015-10-27 Thread kkolinko
Author: kkolinko
Date: Wed Oct 28 02:54:00 2015
New Revision: 1710930

URL: http://svn.apache.org/viewvc?rev=1710930&view=rev
Log:
For https://bz.apache.org/bugzilla/show_bug.cgi?id=58547 (reviewing r1710760)
Replace X.valueOf(String).xValue() with simple x.parseX().

Modified:
tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java
tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java

Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java?rev=1710930&r1=1710929&r2=1710930&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java Wed Oct 
28 02:54:00 2015
@@ -881,15 +881,13 @@ public class WebdavServlet
 lockDurationStr = lockDurationStr.substring(0,commaPos);
 }
 if (lockDurationStr.startsWith("Second-")) {
-lockDuration =
-(Integer.valueOf(lockDurationStr.substring(7))).intValue();
+lockDuration = Integer.parseInt(lockDurationStr.substring(7));
 } else {
 if (lockDurationStr.equalsIgnoreCase("infinity")) {
 lockDuration = MAX_TIMEOUT;
 } else {
 try {
-lockDuration =
-(Integer.valueOf(lockDurationStr)).intValue();
+lockDuration = Integer.parseInt(lockDurationStr);
 } catch (NumberFormatException e) {
 lockDuration = MAX_TIMEOUT;
 }

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java?rev=1710930&r1=1710929&r2=1710930&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java 
Wed Oct 28 02:54:00 2015
@@ -196,7 +196,7 @@ public class McastService implements Mem
 public int getRecoveryCounter(){
 String p = properties.getProperty("recoveryCounter");
 if(p != null){
-return Integer.valueOf(p).intValue();
+return Integer.parseInt(p);
 }
 return -1;
 }
@@ -208,7 +208,7 @@ public class McastService implements Mem
 public boolean getRecoveryEnabled() {
 String p = properties.getProperty("recoveryEnabled");
 if(p != null){
-return Boolean.valueOf(p).booleanValue();
+return Boolean.parseBoolean(p);
 }
 return false;
 }
@@ -220,7 +220,7 @@ public class McastService implements Mem
 public long getRecoverySleepTime(){
 String p = properties.getProperty("recoverySleepTime");
 if(p != null){
-return Long.valueOf(p).longValue();
+return Long.parseLong(p);
 }
 return -1;
 }
@@ -232,14 +232,14 @@ public class McastService implements Mem
 public boolean getLocalLoopbackDisabled() {
 String p = properties.getProperty("localLoopbackDisabled");
 if(p != null){
-return Boolean.valueOf(p).booleanValue();
+return Boolean.parseBoolean(p);
 }
 return false;
 }
 
 public int getPort() {
 String p = properties.getProperty("mcastPort");
-return Integer.valueOf(p).intValue();
+return Integer.parseInt(p);
 }
 
 public void setFrequency(long time) {
@@ -248,7 +248,7 @@ public class McastService implements Mem
 
 public long getFrequency() {
 String p = properties.getProperty("mcastFrequency");
-return Long.valueOf(p).longValue();
+return Long.parseLong(p);
 }
 
 public void setMcastDropTime(long time) {
@@ -260,7 +260,7 @@ public class McastService implements Mem
 
 public long getDropTime() {
 String p = properties.getProperty("memberDropTime");
-return Long.valueOf(p).longValue();
+return Long.parseLong(p);
 }
 
 /**
@@ -348,9 +348,9 @@ public class McastService implements Mem
 soTimeout,
 this,
 this,
-
Boolean.valueOf(properties.getProperty("localLoopbackDisabled","false")).booleanValue());
+
Boolean.parseBoolean(properties.getProperty("localLoopbackDisabled","false")));
 String value = properties.getProperty("recoveryEnabled","true");
-bool

[Bug 58559] New: Typo in 8.0.28 Changelog

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58559

Bug ID: 58559
   Summary: Typo in 8.0.28 Changelog
   Product: Tomcat 8
   Version: trunk
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P2
 Component: Documentation
  Assignee: dev@tomcat.apache.org
  Reporter: huxing.zh...@gmail.com

https://tomcat.apache.org/tomcat-8.0-doc/changelog.html
source code: webapps/docs/changelog.xml

Fix:  56777: Allow file based configuration resources (user database,
certificate revocation lists, keystores an dtrust stores) to be configured
using URLs as well as files. (markt)

"keystores an dtrust stores" should be "keystores and trust stores"

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58559] Typo in 8.0.28 Changelog

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58559

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Mark Thomas  ---
Fixed. Tx.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710931 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

2015-10-27 Thread markt
Author: markt
Date: Wed Oct 28 03:00:55 2015
New Revision: 1710931

URL: http://svn.apache.org/viewvc?rev=1710931&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58559
Fix typo

Modified:
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1710931&r1=1710930&r2=1710931&view=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Wed Oct 28 03:00:55 2015
@@ -162,7 +162,7 @@
   
   
 56777: Allow file based configuration resources (user
-database, certificate revocation lists, keystores an dtrust stores) to
+database, certificate revocation lists, keystores and trust stores) to
 be configured using URLs as well as files. (markt)
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56777] Allow configuration resources to be loaded from places other than straight off the filesystem

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56777

--- Comment #18 from Huxing Zhang  ---
Created attachment 33230
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33230&action=edit
patch including latest ConfigFileLoader enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1710933 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/servlets/ java/org/apache/catalina/sessio

2015-10-27 Thread kkolinko
Author: kkolinko
Date: Wed Oct 28 03:17:12 2015
New Revision: 1710933

URL: http://svn.apache.org/viewvc?rev=1710933&view=rev
Log:
Replace Boolean.valueOf(String).booleanValue()  with Boolean.parseBoolean().

Modified:
tomcat/trunk/java/org/apache/catalina/Globals.java
tomcat/trunk/java/org/apache/catalina/connector/Connector.java
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
tomcat/trunk/java/org/apache/catalina/connector/Response.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java
tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabaseFactory.java
tomcat/trunk/java/org/apache/catalina/valves/JDBCAccessLogValve.java
tomcat/trunk/java/org/apache/el/lang/ELSupport.java
tomcat/trunk/java/org/apache/el/util/Validation.java
tomcat/trunk/java/org/apache/jasper/Constants.java
tomcat/trunk/java/org/apache/jasper/compiler/AttributeParser.java
tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java
tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
tomcat/trunk/java/org/apache/jasper/runtime/BodyContentImpl.java
tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java
tomcat/trunk/java/org/apache/tomcat/util/buf/UDecoder.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java

Modified: tomcat/trunk/java/org/apache/catalina/Globals.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Globals.java?rev=1710933&r1=1710932&r2=1710933&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Globals.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Globals.java Wed Oct 28 03:17:12 2015
@@ -222,7 +222,7 @@ public final class Globals {
  * compliance.
  */
 public static final boolean STRICT_SERVLET_COMPLIANCE =
-
Boolean.valueOf(System.getProperty("org.apache.catalina.STRICT_SERVLET_COMPLIANCE",
 "false")).booleanValue();
+
Boolean.parseBoolean(System.getProperty("org.apache.catalina.STRICT_SERVLET_COMPLIANCE",
 "false"));
 
 
 /**

Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=1710933&r1=1710932&r2=1710933&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Wed Oct 28 
03:17:12 2015
@@ -55,7 +55,7 @@ public class Connector extends Lifecycle
  * Alternate flag to enable recycling of facades.
  */
 public static final boolean RECYCLE_FACADES =
-
Boolean.valueOf(System.getProperty("org.apache.catalina.connector.RECYCLE_FACADES",
 "false")).booleanValue();
+
Boolean.parseBoolean(System.getProperty("org.apache.catalina.connector.RECYCLE_FACADES",
 "false"));
 
 
 //  Constructor

Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?rev=1710933&r1=1710932&r2=1710933&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Wed Oct 
28 03:17:12 2015
@@ -79,7 +79,7 @@ public class CoyoteAdapter implements Ad
 
 
 protected static final boolean ALLOW_BACKSLASH =
-
Boolean.valueOf(System.getProperty("org.apache.catalina.connector.CoyoteAdapter.ALLOW_BACKSLASH",
 "false")).booleanValue();
+
Boolean.parseBoolean(System.getProperty("org.apache.catalina.connector.CoyoteAdapter.ALLOW_BACKSLASH",
 "false"));
 
 
 private static final ThreadLocal THREAD_NAME =

Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Response.java?rev=1710933&r1=1710932&r2=1710933&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Response.java (original)
+++ tomcat/trunk/java/org/apache/catalin

Re: svn commit: r1710933 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ ...

2015-10-27 Thread 张乎兴(望陶)
+
Boolean.parseBoolean(System.getProperty("org.apache.catalina.STRICT_SERVLET_COMPLIANCE",
 "false"));
Codes like this can be even 
shorter:Boolean.getBoolean("org.apache.catalina.STRICT_SERVLET_COMPLIANCE");According
 to the 
documentation:https://docs.oracle.com/javase/6/docs/api/java/lang/Boolean.htmlstatic
 boolean getBoolean(String name) 
  Returns true if and only if the system property named by the argument 
exists and is equal to the string "true".
Best Regards,Huxing 
Zhang--From:kkolinko
 Send Time:2015年10月28日(星期三) 11:17To:dev 
Subject:svn commit: r1710933 - in /tomcat/trunk: 
java/org/apache/catalina/ java/org/apache/catalina/connector/ 
java/org/apache/catalina/core/ java/org/apache/catalina/servlets/ 
java/org/apache/catalina/session/ java/org/apache/catalina/users/ 
java/org/apache/c...
Author: kkolinko
Date: Wed Oct 28 03:17:12 2015
New Revision: 1710933

URL: http://svn.apache.org/viewvc?rev=1710933&view=rev
Log:
Replace Boolean.valueOf(String).booleanValue()  with Boolean.parseBoolean().

Modified:
tomcat/trunk/java/org/apache/catalina/Globals.java
tomcat/trunk/java/org/apache/catalina/connector/Connector.java
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
tomcat/trunk/java/org/apache/catalina/connector/Response.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java
tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabaseFactory.java
tomcat/trunk/java/org/apache/catalina/valves/JDBCAccessLogValve.java
tomcat/trunk/java/org/apache/el/lang/ELSupport.java
tomcat/trunk/java/org/apache/el/util/Validation.java
tomcat/trunk/java/org/apache/jasper/Constants.java
tomcat/trunk/java/org/apache/jasper/compiler/AttributeParser.java
tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java
tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
tomcat/trunk/java/org/apache/jasper/runtime/BodyContentImpl.java
tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java
tomcat/trunk/java/org/apache/tomcat/util/buf/UDecoder.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java

Modified: tomcat/trunk/java/org/apache/catalina/Globals.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Globals.java?rev=1710933&r1=1710932&r2=1710933&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Globals.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Globals.java Wed Oct 28 03:17:12 2015
@@ -222,7 +222,7 @@ public final class Globals {
  * compliance.
  */
 public static final boolean STRICT_SERVLET_COMPLIANCE =
-
Boolean.valueOf(System.getProperty("org.apache.catalina.STRICT_SERVLET_COMPLIANCE",
 "false")).booleanValue();
+
Boolean.parseBoolean(System.getProperty("org.apache.catalina.STRICT_SERVLET_COMPLIANCE",
 "false"));
 
 
 /**

Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=1710933&r1=1710932&r2=1710933&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Wed Oct 28 
03:17:12 2015
@@ -55,7 +55,7 @@ public class Connector extends Lifecycle
  * Alternate flag to enable recycling of facades.
  */
 public static final boolean RECYCLE_FACADES =
-
Boolean.valueOf(System.getProperty("org.apache.catalina.connector.RECYCLE_FACADES",
 "false")).booleanValue();
+
Boolean.parseBoolean(System.getProperty("org.apache.catalina.connector.RECYCLE_FACADES",
 "false"));
 
 
 //  Constructor

Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?rev=1710933&r1=1710932&r2=1710933&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/connec

svn commit: r1710945 - in /tomcat/trunk: java/javax/el/ java/org/apache/el/lang/ java/org/apache/jasper/runtime/ test/org/apache/coyote/ajp/ test/org/apache/tomcat/websocket/

2015-10-27 Thread kkolinko
Author: kkolinko
Date: Wed Oct 28 05:36:20 2015
New Revision: 1710945

URL: http://svn.apache.org/viewvc?rev=1710945&view=rev
Log:
For https://bz.apache.org/bugzilla/show_bug.cgi?id=58547
Replace Integer.valueOf(String).intValue() with simple parseInt(), and similar 
methods.

Modified:
tomcat/trunk/java/javax/el/BeanELResolver.java
tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java
tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
tomcat/trunk/test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java
tomcat/trunk/test/org/apache/tomcat/websocket/TesterWsClientAutobahn.java

Modified: tomcat/trunk/java/javax/el/BeanELResolver.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/BeanELResolver.java?rev=1710945&r1=1710944&r2=1710945&view=diff
==
--- tomcat/trunk/java/javax/el/BeanELResolver.java (original)
+++ tomcat/trunk/java/javax/el/BeanELResolver.java Wed Oct 28 05:36:20 2015
@@ -40,20 +40,20 @@ public class BeanELResolver extends ELRe
 "org.apache.el.BeanELResolver.CACHE_SIZE";
 
 static {
+String cacheSizeStr;
 if (System.getSecurityManager() == null) {
-CACHE_SIZE = Integer.parseInt(
-System.getProperty(CACHE_SIZE_PROP, "1000"));
+cacheSizeStr = System.getProperty(CACHE_SIZE_PROP, "1000");
 } else {
-CACHE_SIZE = AccessController.doPrivileged(
-new PrivilegedAction() {
+cacheSizeStr = AccessController.doPrivileged(
+new PrivilegedAction() {
 
 @Override
-public Integer run() {
-return Integer.valueOf(
-System.getProperty(CACHE_SIZE_PROP, "1000"));
+public String run() {
+return System.getProperty(CACHE_SIZE_PROP, "1000");
 }
-}).intValue();
+});
 }
+CACHE_SIZE = Integer.parseInt(cacheSizeStr);
 }
 
 private final boolean readOnly;

Modified: tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java?rev=1710945&r1=1710944&r2=1710945&view=diff
==
--- tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java (original)
+++ tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java Wed Oct 28 
05:36:20 2015
@@ -55,20 +55,20 @@ public final class ExpressionBuilder imp
 "org.apache.el.ExpressionBuilder.CACHE_SIZE";
 
 static {
+String cacheSizeStr;
 if (System.getSecurityManager() == null) {
-CACHE_SIZE = Integer.parseInt(
-System.getProperty(CACHE_SIZE_PROP, "5000"));
+cacheSizeStr = System.getProperty(CACHE_SIZE_PROP, "5000");
 } else {
-CACHE_SIZE = AccessController.doPrivileged(
-new PrivilegedAction() {
+cacheSizeStr = AccessController.doPrivileged(
+new PrivilegedAction() {
 
 @Override
-public Integer run() {
-return Integer.valueOf(
-System.getProperty(CACHE_SIZE_PROP, "5000"));
+public String run() {
+return System.getProperty(CACHE_SIZE_PROP, "5000");
 }
-}).intValue();
+});
 }
+CACHE_SIZE = Integer.parseInt(cacheSizeStr);
 }
 
 private static final ConcurrentCache expressionCache =

Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java?rev=1710945&r1=1710944&r2=1710945&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java (original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java Wed Oct 28 
05:36:20 2015
@@ -42,7 +42,7 @@ public class JspFactoryImpl extends JspF
 private static final boolean USE_POOL =
 
Boolean.parseBoolean(System.getProperty("org.apache.jasper.runtime.JspFactoryImpl.USE_POOL",
 "true"));
 private static final int POOL_SIZE =
-
Integer.valueOf(System.getProperty("org.apache.jasper.runtime.JspFactoryImpl.POOL_SIZE",
 "8")).intValue();
+
Integer.parseInt(System.getProperty("org.apache.jasper.runtime.JspFactoryImpl.POOL_SIZE",
 "8"));
 
 private final ThreadLocal localPool = new ThreadLocal<>();
 

Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2015-10-27 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 42 mins 22 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151028-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20151028.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151028-native-src.tar.gz
 -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-ma
 ster/dest-20151028/bin/openssl -Dexecute.test.apr=false 
-Dtest.excludePerformance=true -Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/g

[jira] [Commented] (MTOMCAT-195) Plugin uploads WAR file twice

2015-10-27 Thread Raza (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977815#comment-14977815
 ] 

Raza commented on MTOMCAT-195:
--

I am also facing the similar issue:

[INFO] --- maven-war-plugin:2.6:war (default-war) @ EVOKE-Scraping ---
[INFO] Packaging webapp
[INFO] Assembling webapp [EVOKE-Scraping] in [E:\New Git 
Space\EVOKE-Scraping\EVOKE-Scraping\target\EVOKE-Scraping]
[INFO] Processing war project
[INFO] Copying webapp resources [E:\New Git 
Space\EVOKE-Scraping\EVOKE-Scraping\WebContent]
[INFO] Webapp assembled in [931 msecs]
[INFO] Building war: E:\softs\apache-tomcat-2\webapps\EVOKE-Scraping-war.war
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
EVOKE-Scraping ---
[WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources, 
i.e. build is platform dependent!
[INFO] Copying 12 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ EVOKE-Scraping 
---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
EVOKE-Scraping ---
[WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources, 
i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory E:\New Git 
Space\EVOKE-Scraping\EVOKE-Scraping\src\test\resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
EVOKE-Scraping ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ EVOKE-Scraping ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-war-plugin:2.6:war (default-war) @ EVOKE-Scraping ---
[INFO] Packaging webapp
[INFO] Assembling webapp [EVOKE-Scraping] in [E:\New Git 
Space\EVOKE-Scraping\EVOKE-Scraping\target\EVOKE-Scraping]
[INFO] Processing war project
[INFO] Copying webapp resources [E:\New Git 
Space\EVOKE-Scraping\EVOKE-Scraping\WebContent]
[INFO] Webapp assembled in [466 msecs]
[INFO] Building war: E:\softs\apache-tomcat-2\webapps\EVOKE-Scraping-war.war
[INFO] 
[INFO] --- maven-install-plugin:2.4:install (default-install) @ EVOKE-Scraping 
---
[INFO] No primary artifact to install, installing attached artifacts instead.
[INFO] Installing E:\New Git Space\EVOKE-Scraping\EVOKE-Scraping\pom.xml to 
C:\Users\raza\.m2\repository\com\jocata\EVOKE-Scraping\1.0-SNAPSHOT\EVOKE-Scraping-1.0-SNAPSHOT.pom
[INFO] Installing E:\softs\apache-tomcat-2\webapps\EVOKE-Scraping-war.war to 
C:\Users\raza\.m2\repository\com\jocata\EVOKE-Scraping\1.0-SNAPSHOT\EVOKE-Scraping-1.0-SNAPSHOT-war.war
[INFO] Installing E:\softs\apache-tomcat-2\webapps\EVOKE-Scraping-war.war to 
C:\Users\raza\.m2\repository\com\jocata\EVOKE-Scraping\1.0-SNAPSHOT\EVOKE-Scraping-1.0-SNAPSHOT-war.war
[INFO] 
[INFO] BUILD SUCCESS

> Plugin uploads WAR file twice
> -
>
> Key: MTOMCAT-195
> URL: https://issues.apache.org/jira/browse/MTOMCAT-195
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>  Components: tomcat6
>Affects Versions: 2.0
> Environment: Win7/64, Maven 3.0.4
>Reporter: George Smith
>Assignee: Olivier Lamy (*$^¨%`£)
>
> When I deploy my WAR using maven, the target war (exact the same one) is 
> being uploaded to the server twice. Can someone explain that?
> I am using this on my module:
> {code}clean install org.apache.tomcat.maven:tomcat6-maven-plugin:2.0:redeploy 
> {code}
> From the Log file
> {code =xml}
> [INFO] --- maven-war-plugin:2.1.1:war (default-war) @ mobile-server ---
> [INFO] Packaging webapp
> [INFO] Assembling webapp [mobile-server] in 
> [C:\develope\mobile\mobile-server\target\mobile-server]
> [INFO] Processing war project
> [INFO] Copying webapp resources 
> [C:\develope\mobile\mobile-server\src\main\webapp]
> [INFO] Webapp assembled in [241 msecs]
> [INFO] Building war: C:\develope\mobile\mobile-server\target\mobile-server.war
> [INFO] 
> [INFO] <<< tomcat6-maven-plugin:2.0:redeploy (default-cli) @ mobile-server <<<
> [INFO] 
> [INFO] --- tomcat6-maven-plugin:2.0:redeploy (default-cli) @ mobile-server 
> ---
> [INFO] Deploying war to http://myserver.eu/pra-mobile-server  
> Uploading: 
> http://myserver.eu/manager-test/deploy?path=%2Fmobile-server&update=true
> Uploaded: 
> http://myserver.eu/manager-test/deploy?path=%2Fmobile-server&update=true 
> (12678 KB at 49.3 KB/sec)
> Uploading: 
> http://myserver.eu/manager-test/deploy?path=%2Fmobile-server&update=true
> Uploaded: 
> http://myserver.eu/manager-test/deploy?path=%2Fmobile-server&update=true
> {code}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/mave

[Bug 58551] Support plain and ssl on the same port

2015-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58551

--- Comment #10 from romain.manni-bucau  ---
> I think you are introducing a semantic difference where there is none: a web 
> service and a web application are the same thing. The fact that a browser is 
> one kind of client is irrelevant.

On the technical stack there is none but on the usage there are. You have no
standard port in practise for a webservice (very very often in enterprises you
dont use 80 and 443).

> If you want to multiplex protocols over a single port, use some kind of 
> service out in front of Tomcat that understands how to do that, and leave 
> Tomcat out of it. This is unnecessary complexity for a product like Tomcat.

Why Tomcat couldn't get this? The code itself is very limited.

> Sounds like your suitcase of tools are failing you. AWS itself imposes no 
> such limitations.(by whatever definition) already recognizes separate 
> official ports for HTTP and HTTPS, so being able to switch protocols on a 
> single port is inappropriate.

This is not true when using EB typically.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org