[VOTE][RESULT] Release Apache Tomcat 8.0.27

2015-10-01 Thread Mark Thomas
The following votes were cast:

binding:
+1: markt, remm, jfarcand, violetagg, rjung

non-binding:
+1: fschumacher

This vote therefore passes.

Thanks to everyone who tested and voted.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r10694 - /dev/tomcat/tomcat-8/v8.0.27/ /release/tomcat/tomcat-8/v8.0.27/

2015-10-01 Thread markt
Author: markt
Date: Thu Oct  1 10:17:31 2015
New Revision: 10694

Log:
Release 8.0.27

Added:
release/tomcat/tomcat-8/v8.0.27/
  - copied from r10693, dev/tomcat/tomcat-8/v8.0.27/
Removed:
dev/tomcat/tomcat-8/v8.0.27/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2015-10-01 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 45 mins 15 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151001-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20151001.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151001-native-src.tar.gz
 -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-ma
 ster/dest-20151001/bin/openssl -Dexecute.test.apr=false 
-Dtest.excludePerformance=true -Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib

[Tomcat Wiki] Update of "Security/Ciphers" by OgnjenBlagojevic

2015-10-01 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "Security/Ciphers" page has been changed by OgnjenBlagojevic:
https://wiki.apache.org/tomcat/Security/Ciphers?action=diff&rev1=5&rev2=6

Comment:
Added information about 2048-bit DHE

  = TLS Cipher suite choice =
  
  There is no right choice since there are always trade-offs to make between 
better security better interoperability, better performance etc.. Where you 
choose to draw that line is a choice you need to make. The following 
information is provided to help you make that choice. The ratings provided are 
those calculated by the excellent [[https://www.ssllabs.com/ssltest|SSL Labs 
Test]]. Keep in mind that, as more vulnerabilities are discovered, these 
ratings are only ever going to get worse over time. The results shown on this 
page were correct at the time they were generated.
+ 
+ As of May 2015, 1024-bit DHE is 
[[https://www.schneier.com/blog/archives/2015/05/the_logjam_and_.html|considered]]
 [[https://weakdh.org/imperfect-forward-secrecy.pdf|breakable]] by nation-state 
adversaries. 2048-bit DHE is recommended. 2048-bit DHE may be configured with 
JSSE using JVM parameter, while latest released version of Apache Tomcat Native 
Library (1.1.33) does not support 2048-bit DHE. You may track native support 
[[https://bz.apache.org/bugzilla/show_bug.cgi?id=56108|here]]
+ 
  
  == JSSE (BIO/NIO/NIO2) Results (Default) ==
  
@@ -22, +25 @@

  
  == JSSE Settings for Improved Results ==
  
- To use these settings, set the ciphers attribute on your secure connector to 
the list of ciphers shown below. The list should be comma separated.
+ To use these settings:
  
+  1. Pass JVM parameter '''-Djdk.tls.ephemeralDHKeySize=2048''' to JVM running 
Tomcat.
+ 
+  1. Set the ciphers attribute on your secure connector to the list of ciphers 
shown below. The list should be comma separated.
+ 
-  * Java 5
+   * Java 5
-   * TLS_RSA_WITH_AES_128_CBC_SHA, TLS_DHE_RSA_WITH_AES_128_CBC_SHA, 
SSL_RSA_WITH_3DES_EDE_CBC_SHA, SSL_DHE_RSA_WITH_3DES_EDE_CBC_SHA
+* TLS_RSA_WITH_AES_128_CBC_SHA, TLS_DHE_RSA_WITH_AES_128_CBC_SHA, 
SSL_RSA_WITH_3DES_EDE_CBC_SHA, SSL_DHE_RSA_WITH_3DES_EDE_CBC_SHA
-  * Java 6
+   * Java 6
-   * TLS_RSA_WITH_AES_128_CBC_SHA, SSL_RSA_WITH_3DES_EDE_CBC_SHA
+* TLS_RSA_WITH_AES_128_CBC_SHA, SSL_RSA_WITH_3DES_EDE_CBC_SHA
-  * Java 7
+   * Java 7
-   * TLS_RSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, 
TLS_RSA_WITH_AES_128_CBC_SHA256, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, 
SSL_RSA_WITH_3DES_EDE_CBC_SHA, TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA
+ * TLS_RSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, 
TLS_RSA_WITH_AES_128_CBC_SHA256, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, 
SSL_RSA_WITH_3DES_EDE_CBC_SHA, TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA
-  * Java 8
+   * Java 8
-   * TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, 
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, 
TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA
+* TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, 
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, 
TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA
  
  ''(It might be nice to provide the OpenSSL-style cipher suites arcana for the 
versions of Tomcat that support it)''
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1706246 - in /tomcat/trunk/java/org/apache/coyote: AbstractProcessor.java ErrorState.java ajp/AjpProcessor.java http11/Http11Processor.java http2/StreamProcessor.java

2015-10-01 Thread markt
Author: markt
Date: Thu Oct  1 13:33:25 2015
New Revision: 1706246

URL: http://svn.apache.org/viewvc?rev=1706246&view=rev
Log:
First pass at differentiating between errors that are fatal to a multiplexed 
stream vs fatal to a multiplexed connection.

Modified:
tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java
tomcat/trunk/java/org/apache/coyote/ErrorState.java
tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java

Modified: tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java?rev=1706246&r1=1706245&r2=1706246&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java Thu Oct  1 
13:33:25 2015
@@ -237,7 +237,7 @@ public abstract class AbstractProcessor
 setErrorState(ErrorState.CLOSE_NOW, null);
 }
 } catch (InterruptedIOException e) {
-setErrorState(ErrorState.CLOSE_NOW, e);
+setErrorState(ErrorState.CLOSE_CONNECTION_NOW, e);
 } catch (Throwable t) {
 ExceptionUtils.handleThrowable(t);
 setErrorState(ErrorState.CLOSE_NOW, t);

Modified: tomcat/trunk/java/org/apache/coyote/ErrorState.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ErrorState.java?rev=1706246&r1=1706245&r2=1706246&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ErrorState.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ErrorState.java Thu Oct  1 13:33:25 2015
@@ -21,7 +21,7 @@ public enum ErrorState {
 /**
  * Not in an error state.
  */
-NONE(false, 0, true),
+NONE(false, 0, true, true),
 
 /**
  * The current request/response is in an error state and while it is safe 
to
@@ -29,22 +29,36 @@ public enum ErrorState {
  * existing connection which must be closed once the response has been
  * completed.
  */
-CLOSE_CLEAN(true, 1, true),
+CLOSE_CLEAN(true, 1, true, true),
 
 /**
  * The current request/response is in an error state and it is not safe to
- * continue to use the existing connection which must be closed 
immediately.
+ * continue to use them. For multiplexed protocols (such as HTTP/2) the
+ * stream/channel must be closed immediately but the connection may
+ * continue. For non-multiplexed protocols (AJP, HTTP/1.x) the current
+ * connection must be closed.
  */
-CLOSE_NOW(true, 2, false);
+CLOSE_NOW(true, 2, false, true),
+
+/**
+ * An error has been detected that impacts the underlying network
+ * connection. It is not safe to continue using the network connection 
which
+ * must be closed immediately. For multiplexed protocols (such as HTTP/2)
+ * this impacts all multiplexed channels.
+ */
+CLOSE_CONNECTION_NOW(true, 3, false, false);
 
 private final boolean error;
 private final int severity;
 private final boolean ioAllowed;
+private final boolean connectionIoAllowed;
 
-private ErrorState(boolean error, int severity, boolean ioAllowed) {
+private ErrorState(boolean error, int severity, boolean ioAllowed,
+boolean connectionIoAllowed) {
 this.error = error;
 this.severity = severity;
 this.ioAllowed = ioAllowed;
+this.connectionIoAllowed = connectionIoAllowed;
 }
 
 public boolean isError() {
@@ -71,4 +85,8 @@ public enum ErrorState {
 public boolean isIoAllowed() {
 return ioAllowed;
 }
+
+public boolean isConnectionIoAllowed() {
+return connectionIoAllowed;
+}
 }

Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=1706246&r1=1706245&r2=1706246&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Thu Oct  1 
13:33:25 2015
@@ -337,7 +337,7 @@ public class AjpProcessor extends Abstra
 // Validate and write response headers
 prepareResponse();
 } catch (IOException e) {
-setErrorState(ErrorState.CLOSE_NOW, e);
+setErrorState(ErrorState.CLOSE_CONNECTION_NOW, e);
 }
 }
 break;
@@ -347,7 +347,7 @@ public class AjpProcessor extends Abstra
 try {
 finish();
 } catch (IOException e) {
-setErrorState(ErrorState.CLOSE_NO

svn commit: r1706264 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2UpgradeHandler.java LocalStrings.properties Stream.java StreamProcessor.java

2015-10-01 Thread markt
Author: markt
Date: Thu Oct  1 14:32:56 2015
New Revision: 1706264

URL: http://svn.apache.org/viewvc?rev=1706264&view=rev
Log:
Complete some error handling TODOs

Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties
tomcat/trunk/java/org/apache/coyote/http2/Stream.java
tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java

Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1706264&r1=1706263&r2=1706264&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Thu Oct  
1 14:32:56 2015
@@ -402,7 +402,7 @@ public class Http2UpgradeHandler extends
 }
 
 
-private void closeStream(StreamException se) throws ConnectionException, 
IOException {
+void closeStream(StreamException se) throws ConnectionException, 
IOException {
 
 if (log.isDebugEnabled()) {
 log.debug(sm.getString("upgradeHandler.rst.debug", connectionId,
@@ -433,7 +433,7 @@ public class Http2UpgradeHandler extends
 }
 
 
-private void closeConnection(Http2Exception ce) {
+void closeConnection(Http2Exception ce) {
 // Write a GOAWAY frame.
 byte[] fixedPayload = new byte[8];
 ByteUtil.set31Bits(fixedPayload, 0, maxProcessedStreamId);

Modified: tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties?rev=1706264&r1=1706263&r2=1706264&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties Thu Oct  
1 14:32:56 2015
@@ -72,6 +72,8 @@ stream.write=Connection [{0}], Stream [{
 
 stream.outputBuffer.flush.debug=Connection [{0}], Stream [{1}], flushing 
output with buffer at position [{2}], writeInProgress [{3}] and closed [{4}]
 
+streamProcessor.error.connection=Connection [{0}], Stream [{1}], An error 
occurred during processing that was fatal to the connection
+streamProcessor.error.stream=Connection [{0}], Stream [{1}], An error occurred 
during processing that was fatal to the stream
 streamProcessor.httpupgrade.notsupported=HTTP upgrade is not supported within 
HTTP/2 streams
 streamProcessor.process.loopend=Connection [{0}], Stream [{1}], loop end, 
state [{2}], dispatches [{3}]
 streamProcessor.process.loopstart=Connection [{0}], Stream [{1}], loop start, 
status [{2}], dispatches [{3}]

Modified: tomcat/trunk/java/org/apache/coyote/http2/Stream.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Stream.java?rev=1706264&r1=1706263&r2=1706264&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Stream.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Stream.java Thu Oct  1 14:32:56 
2015
@@ -338,6 +338,25 @@ public class Stream extends AbstractStre
 return !state.isFrameTypePermitted(FrameType.DATA);
 }
 
+
+void close(Http2Exception http2Exception) {
+if (http2Exception instanceof StreamException) {
+try {
+handler.closeStream((StreamException) http2Exception);
+} catch (ConnectionException ce) {
+handler.closeConnection(ce);
+} catch (IOException ioe) {
+// TODO i18n
+ConnectionException ce = new ConnectionException("", 
Http2Error.PROTOCOL_ERROR);
+ce.initCause(ioe);
+handler.closeConnection(ce);
+}
+} else {
+handler.closeConnection(http2Exception);
+}
+}
+
+
 class StreamOutputBuffer implements OutputBuffer {
 
 private final ByteBuffer buffer = ByteBuffer.allocate(8 * 1024);

Modified: tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java?rev=1706264&r1=1706263&r2=1706264&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java Thu Oct  1 
14:32:56 2015
@@ -74,15 +74,19 @@ public class StreamProcessor extends Abs
 log.debug(sm.getString("streamProcessor.process.loopstart",
 stream.getConnectionId(), stream.getIdentifier(), 
status, dispatches));
 }
-// TODO CLOSE_NOW ?
-

Re: [VOTE] Release Apache Tomcat 8.0.27

2015-10-01 Thread Christopher Schultz
Mark,

On 9/28/15 7:26 AM, Mark Thomas wrote:
> The proposed Apache Tomcat 8.0.27 release is now available for voting.
> 
> The main changes since 8.0.26 are:
> 
> - Correctly handle \${ vs \$ escaping in JSP and EL
> 
> - Fix for issues with NIO + SSL + sendfile
> 
> - Various TLD parsing fixes
> 
> - Fix multiple (mostly rare and/or zero impact) concurrency issues
> 
> 
> Note: Due to an issues with the Symantec code signing service (the
>   certificates used to access the web-based admin GUI have all
>   expired and infra is having to jump through some hoops to get
>   new ones issues) the Windows Installer package has NOT been
>   signed for this release.
> 
> There is the usual collection of bug fixes, new features and
> performance improvements. For full details, see the changelog:
> http://svn.us.apache.org/repos/asf/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.27/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1051/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_27/
> 
> The proposed 8.0.27 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.27

It's after the vote has passed, but I'll add my straw to the lot.

Works fine in a moderately-used development environment.

Tribes-based unit tests are known to fail in my environment due to lack
of multicast setup. The OpenSSL/JSSE tests are pretty much expected to
fail in all environments but Mark's, AFAICT.

So everything looks good to me.

* Environment
*  Java (build): java version "1.8.0_60" Java(TM) SE Runtime
Environment (build 1.8.0_60-b27) Java HotSpot(TM) 64-Bit Server VM
(build 25.60-b23, mixed mode)
*  Java (test): java version "1.8.0_60" Java(TM) SE Runtime
Environment (build 1.8.0_60-b27) Java HotSpot(TM) 64-Bit Server VM
(build 25.60-b23, mixed mode)
*  OS:   Linux 2.6.32-312-ec2 x86_64
*  cc:   cc (Debian 4.7.2-5) 4.7.2
*  make: GNU Make 3.81
*  OpenSSL:  OpenSSL 1.0.1e 11 Feb 2013
*  APR:  1.4.6
*
* Valid MD5 signature for apache-tomcat-8.0.27.zip
* Valid GPG signature for apache-tomcat-8.0.27.zip
* Valid MD5 signature for apache-tomcat-8.0.27.tar.gz
* Valid GPG signature for apache-tomcat-8.0.27.tar.gz
* Valid MD5 signature for apache-tomcat-8.0.27.exe
* Valid GPG signature for apache-tomcat-8.0.27.exe
* Valid MD5 signature for apache-tomcat-8.0.27-src.zip
* Valid GPG signature for apache-tomcat-8.0.27-src.zip
* Valid MD5 signature for apache-tomcat-8.0.27-src.tar.gz
* Valid GPG signature for apache-tomcat-8.0.27-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: FAILED
*
* Tests that failed:
* org.apache.catalina.session.TestStandardSessionIntegration.APR.txt
* org.apache.catalina.session.TestStandardSessionIntegration.BIO.txt
* org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt
* org.apache.catalina.session.TestStandardSessionIntegration.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.BIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.BIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt
*
org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.BIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.BIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.BIO.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.BIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.

[Bug 58464] servletRequest.getHeaderNames() returns all header names in lower case

2015-10-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58464

--- Comment #4 from Christopher Schultz  ---
I'm not sure how many people care about this kind of thing, but I have to
interact with a web service that uses JSON to pass data back and forth. The
service has a way of being oddly case-insensitive in certain cases, so we have
to treat all key/value pairs as if the key were case-insensitive, but I do in
fact like to see what the server is actually sending.

So I've implemented a simple Map that will store the original case of the key
and use that for things like Map.keySet, but also stores a case-insensitive map
of the names for quick comparison/lookup.

I'm not sure what the performance implication of those additional lookups might
be, or the extra garbage that would be generated for each request, but it's
certainly possible to maintain the original case of the request headers and
also treat them case-insensitively.

If anyone is super interested in this kind of thing, it seems like it would be
easy to add a configuration option that would simply substitute a
case-insensitive Map (like that which I described above) for the current
lowercase-only Map.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1706271 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java

2015-10-01 Thread markt
Author: markt
Date: Thu Oct  1 15:15:55 2015
New Revision: 1706271

URL: http://svn.apache.org/viewvc?rev=1706271&view=rev
Log:
Fix regression in refactoring in r1706035

Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java?rev=1706271&r1=1706270&r2=1706271&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java Thu Oct  1 
15:15:55 2015
@@ -1773,6 +1773,7 @@ public class Http11Processor extends Abs
 }
 if (getErrorState().isIoAllowed()) {
 try {
+action(ActionCode.COMMIT, null);
 outputBuffer.endRequest();
 } catch (IOException e) {
 setErrorState(ErrorState.CLOSE_CONNECTION_NOW, e);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1706274 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11AprProtocol.java java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/config/http.xml

2015-10-01 Thread markt
Author: markt
Date: Thu Oct  1 15:39:02 2015
New Revision: 1706274

URL: http://svn.apache.org/viewvc?rev=1706274&view=rev
Log:
Remove unused code.

Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/trunk/webapps/docs/config/http.xml

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java?rev=1706274&r1=1706273&r2=1706274&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java Thu Oct  
1 15:39:02 2015
@@ -57,9 +57,6 @@ public class Http11AprProtocol extends A
 public int getSendfileSize() { return 
((AprEndpoint)getEndpoint()).getSendfileSize(); }
 public void setSendfileSize(int sendfileSize) { 
((AprEndpoint)getEndpoint()).setSendfileSize(sendfileSize); }
 
-public void setSendfileThreadCount(int sendfileThreadCount) { 
((AprEndpoint)getEndpoint()).setSendfileThreadCount(sendfileThreadCount); }
-public int getSendfileThreadCount() { return 
((AprEndpoint)getEndpoint()).getSendfileThreadCount(); }
-
 public boolean getDeferAccept() { return 
((AprEndpoint)getEndpoint()).getDeferAccept(); }
 public void setDeferAccept(boolean deferAccept) { 
((AprEndpoint)getEndpoint()).setDeferAccept(deferAccept); }
 

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1706274&r1=1706273&r2=1706274&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Thu Oct  1 
15:39:02 2015
@@ -173,14 +173,6 @@ public class AprEndpoint extends Abstrac
 
 
 /**
- * Sendfile thread count.
- */
-protected int sendfileThreadCount = 0;
-public void setSendfileThreadCount(int sendfileThreadCount) { 
this.sendfileThreadCount = sendfileThreadCount; }
-public int getSendfileThreadCount() { return sendfileThreadCount; }
-
-
-/**
  * The socket poller.
  */
 protected Poller poller = null;

Modified: tomcat/trunk/webapps/docs/config/http.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/http.xml?rev=1706274&r1=1706273&r2=1706274&view=diff
==
--- tomcat/trunk/webapps/docs/config/http.xml (original)
+++ tomcat/trunk/webapps/docs/config/http.xml Thu Oct  1 15:39:02 2015
@@ -895,13 +895,6 @@
 specified amount. The default value is 1024.
   
 
-  
-Number of threads used service sendfile sockets. On Windows the
-default is chosen so that the sockets managed by each thread is
-less than 1024. For Linux the default is 1. Changing the default on
-Windows is likely to have a negative performance impact.
-  
-
   
 (int)The priority of the acceptor and poller threads.
 The default value is 5 (the value of the



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1706276 - /tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java

2015-10-01 Thread markt
Author: markt
Date: Thu Oct  1 15:46:37 2015
New Revision: 1706276

URL: http://svn.apache.org/viewvc?rev=1706276&view=rev
Log:
Fix the other regression in the refactoring in r1706035

Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java

Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=1706276&r1=1706275&r2=1706276&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Thu Oct  1 
15:46:37 2015
@@ -749,6 +749,7 @@ public class AjpProcessor extends Abstra
 // Finish the response if not done yet
 if (!finished && getErrorState().isIoAllowed()) {
 try {
+action(ActionCode.COMMIT, null);
 finish();
 } catch (IOException ioe){
 setErrorState(ErrorState.CLOSE_CONNECTION_NOW, ioe);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-trunk

2015-10-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/384

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1706276
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1706292 - in /tomcat/site/trunk: ./ docs/ xdocs/

2015-10-01 Thread markt
Author: markt
Date: Thu Oct  1 16:59:28 2015
New Revision: 1706292

URL: http://svn.apache.org/viewvc?rev=1706292&view=rev
Log:
Update site for 8.0.27 release

Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-80.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-8.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-80.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-8.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1706292&r1=1706291&r2=1706292&view=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Thu Oct  1 16:59:28 2015
@@ -38,7 +38,7 @@ tomcat.loc=http://www.apache.org/dist/to
 # - Tomcat versions -
 tomcat60=6.0.43
 tomcat70=7.0.64
-tomcat80=8.0.26
+tomcat80=8.0.27
 
 
 # - Download destination -

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1706292&r1=1706291&r2=1706292&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Thu Oct  1 16:59:28 2015
@@ -60,8 +60,8 @@
 
   
 Latest Stable 8.0.x Release
-2015-08-21
-8.0.26
+2015-10-01
+8.0.27
   
 
 

Modified: tomcat/site/trunk/docs/download-80.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-80.html?rev=1706292&r1=1706291&r2=1706292&view=diff
==
--- tomcat/site/trunk/docs/download-80.html (original)
+++ tomcat/site/trunk/docs/download-80.html Thu Oct  1 16:59:28 2015
@@ -206,7 +206,7 @@
 Quick Navigation
 
 
-[define v]8.0.26[end]
+[define v]8.0.27[end]
 https://www.apache.org/dist/tomcat/tomcat-8/KEYS";>KEYS |
 [v] |
 Browse |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1706292&r1=1706291&r2=1706292&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Thu Oct  1 16:59:28 2015
@@ -228,75 +228,76 @@ project logo are trademarks of the Apach
 
 
 
-
-2015-08-25 Tomcat 7.0.64 Released
+
+2015-10-01 Tomcat 8.0.27 Released
 
 
 
-The Apache Tomcat Project is proud to announce the release of version 7.0.64 of
-Apache Tomcat. This release contains a number of bug fixes
-and improvements compared to version 7.0.63. The notable changes since 7.0.63
-include:
-
+The Apache Tomcat Project is proud to announce the release of version 8.0.27
+of Apache Tomcat. Apache Tomcat 8.0.27 includes a numerous fixes for issues
+identified in 8.0.26 as well as a number of other enhancements and changes. The
+notable changes since 8.0.26 include:
 
 
 
-Avoid an NPE when adding POJO WebSocket endpoints programmatically
+Correctly handle \${ vs \$ escaping in JSP and EL
 
-Improved handling of async timeouts
+Fix for issues with NIO + SSL + sendfile
 
-Facilitate weaving by allowing ClassFileTransformer to be added to
-WebappClassLoader
+Various TLD parsing fixes
+
+Fix multiple (mostly rare and/or zero impact) concurrency issues
 
 
 
 
 
 Full details of these changes, and all the other changes, are available in the
-Tomcat 7 changelog.
+Tomcat 8
+changelog.
 
 
 
 
 
-Download |
-ChangeLog for 7.0.64
+Download
 
 
 
 
-
-2015-08-21 Tomcat 8.0.26 Released
+
+2015-08-25 Tomcat 7.0.64 Released
 
 
 
-The Apache Tomcat Project is proud to announce the release of version 8.0.26
-of Apache Tomcat. Apache Tomcat 8.0.26 includes a numerous fixes for issues
-identified in 8.0.24 as well as a number of other enhancements and changes. The
-notable changes since 8.0.24 include:
+The Apache Tomcat Project is proud to announce the release of version 7.0.64 of
+Apache Tomcat. This release contains a number of bug fixes
+and improvements compared to version 7.0.63. The notable changes since 7.0.63
+include:
+
 
 
 
-Fix EOF handling in the AJP APR/native connector to avoid the tight loop
-that caused high CPU load
-
 Avoid an NPE when adding POJO WebSocket endpoints programmatically
 
 Improved handling of async timeouts
 
+Facilitate weaving by allowing ClassFileTransformer to be added to
+WebappClassLoader
+
 
 
 
 
 Full details of these changes, and all the other changes, are available in the
-Tomcat 8
-chan

svn commit: r1706293 - in /tomcat/site/trunk/docs/tomcat-8.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2015-10-01 Thread markt
Author: markt
Date: Thu Oct  1 17:12:36 2015
New Revision: 1706293

URL: http://svn.apache.org/viewvc?rev=1706293&view=rev
Log:
Update docs for 8.0.27


[This commit notification would consist of 61 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org