[Bug 58103] NIO2 warning: Incorrect connection count, multiple socket.close called on the same socket.

2015-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58103

--- Comment #7 from Ognjen Blagojevic  ---
Here is a minimal test case:

public static void main(String[] argv) throws Exception {
URL url = new
URL("http://localhost:84/examples/servlets/nonblocking/numberwriter";);
InputStream urlStream = url.openStream();
byte b[] = new byte[1000];
int numRead = urlStream.read(b);
while (numRead != -1) {
numRead = urlStream.read(b);
}
urlStream.close();
}

Log messages start to appear some 20-30s, after I execute this test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58104] APR log error: org.apache.tomcat.jni.Error: 20005: An invalid socket was returned

2015-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58104

--- Comment #5 from Violeta Georgieva  ---
The test case from bug 58103#c7 can be used for this issue also.
Once it is executed I can see the same exceptions that I posted earlier.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1692372 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2015-07-23 Thread kfujino
Author: kfujino
Date: Thu Jul 23 10:27:58 2015
New Revision: 1692372

URL: http://svn.apache.org/r1692372
Log:
Eliminate the dependence on maxActive of busy queues and idle queue in order to 
enable the expansion of the pool size via JMX.

Modified:

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1692372&r1=1692371&r2=1692372&view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 Thu Jul 23 10:27:58 2015
@@ -29,7 +29,6 @@ import java.util.Iterator;
 import java.util.Set;
 import java.util.Timer;
 import java.util.TimerTask;
-import java.util.concurrent.ArrayBlockingQueue;
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.ExecutionException;
@@ -439,7 +438,7 @@ public class ConnectionPool {
 }
 
 //make space for 10 extra in case we flow over a bit
-busy = new ArrayBlockingQueue<>(properties.getMaxActive(),false);
+busy = new LinkedBlockingQueue<>();
 //busy = new FairBlockingQueue();
 //make space for 10 extra in case we flow over a bit
 if (properties.isFairQueue()) {
@@ -448,7 +447,7 @@ public class ConnectionPool {
 //idle = new LinkedTransferQueue();
 //idle = new 
ArrayBlockingQueue(properties.getMaxActive(),false);
 } else {
-idle = new 
ArrayBlockingQueue<>(properties.getMaxActive(),properties.isFairQueue());
+idle = new LinkedBlockingQueue<>();
 }
 
 initializePoolCleaner(properties);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1692373 - in /tomcat/tc8.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

2015-07-23 Thread kfujino
Author: kfujino
Date: Thu Jul 23 10:30:15 2015
New Revision: 1692373

URL: http://svn.apache.org/r1692373
Log:
Eliminate the dependence on maxActive of busy queues and idle queue in order to 
enable the expansion of the pool size via JMX.

Modified:

tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1692373&r1=1692372&r2=1692373&view=diff
==
--- 
tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 (original)
+++ 
tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 Thu Jul 23 10:30:15 2015
@@ -29,7 +29,6 @@ import java.util.Iterator;
 import java.util.Set;
 import java.util.Timer;
 import java.util.TimerTask;
-import java.util.concurrent.ArrayBlockingQueue;
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.ExecutionException;
@@ -439,7 +438,7 @@ public class ConnectionPool {
 }
 
 //make space for 10 extra in case we flow over a bit
-busy = new ArrayBlockingQueue<>(properties.getMaxActive(),false);
+busy = new LinkedBlockingQueue<>();
 //busy = new FairBlockingQueue();
 //make space for 10 extra in case we flow over a bit
 if (properties.isFairQueue()) {
@@ -448,7 +447,7 @@ public class ConnectionPool {
 //idle = new LinkedTransferQueue();
 //idle = new 
ArrayBlockingQueue(properties.getMaxActive(),false);
 } else {
-idle = new 
ArrayBlockingQueue<>(properties.getMaxActive(),properties.isFairQueue());
+idle = new LinkedBlockingQueue<>();
 }
 
 initializePoolCleaner(properties);

Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1692373&r1=1692372&r2=1692373&view=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Thu Jul 23 10:30:15 2015
@@ -137,6 +137,11 @@
 via jmx, it should restart the pool cleaner because this attribute
 affects the execution interval of the pool cleaner. (kfujino)
   
+  
+Eliminate the dependence on maxActive of busy queues and
+idle queue in order to enable the expansion of the pool size via JMX.
+(kfujino)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1692375 - in /tomcat/tc7.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

2015-07-23 Thread kfujino
Author: kfujino
Date: Thu Jul 23 10:31:39 2015
New Revision: 1692375

URL: http://svn.apache.org/r1692375
Log:
Eliminate the dependence on maxActive of busy queues and idle queue in order to 
enable the expansion of the pool size via JMX.

Modified:

tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1692375&r1=1692374&r2=1692375&view=diff
==
--- 
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 (original)
+++ 
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 Thu Jul 23 10:31:39 2015
@@ -29,7 +29,6 @@ import java.util.Iterator;
 import java.util.Set;
 import java.util.Timer;
 import java.util.TimerTask;
-import java.util.concurrent.ArrayBlockingQueue;
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.ExecutionException;
@@ -441,7 +440,7 @@ public class ConnectionPool {
 }
 
 //make space for 10 extra in case we flow over a bit
-busy = new 
ArrayBlockingQueue(properties.getMaxActive(),false);
+busy = new LinkedBlockingQueue();
 //busy = new FairBlockingQueue();
 //make space for 10 extra in case we flow over a bit
 if (properties.isFairQueue()) {
@@ -450,7 +449,7 @@ public class ConnectionPool {
 //idle = new LinkedTransferQueue();
 //idle = new 
ArrayBlockingQueue(properties.getMaxActive(),false);
 } else {
-idle = new 
ArrayBlockingQueue(properties.getMaxActive(),properties.isFairQueue());
+idle = new LinkedBlockingQueue();
 }
 
 initializePoolCleaner(properties);

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1692375&r1=1692374&r2=1692375&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Thu Jul 23 10:31:39 2015
@@ -136,6 +136,11 @@
 via jmx, it should restart the pool cleaner because this attribute
 affects the execution interval of the pool cleaner. (kfujino)
   
+  
+Eliminate the dependence on maxActive of busy queues and
+idle queue in order to enable the expansion of the pool size via JMX.
+(kfujino)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot exception in ASF Buildbot on tomcat-trunk

2015-07-23 Thread buildbot
The Buildbot has detected a build exception on builder tomcat-trunk while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/71

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1692372
Blamelist: kfujino

BUILD FAILED: exception upload_2

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 51833] Tomcat doesn't strip jsessionid from the url

2015-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=51833

--- Comment #6 from Konstantin Kolinko  ---
Some person is currently asking about history of this change on the users@
list, comparing behaviour of some old Tomcat 6 and current Tomcat 7 versions.

(2015-07-23,
"Tomcat 7 (7.0.54) Login URL is Passing with JSESSION ID. | why there is
different behaviour in Tomcat 6 and Tomcat 7"
 http://markmail.org/message/jdwpyll2nl25me24
)

This change is listed in changelog, but it does not have a bug number with it.
I am taking this chance to better document it.

This change in changelog of 6.0.33:


   Improve handling of URLs with path parameters and prevent incorrect 404
   responses that could occur when path parameters were present. (kkolinko)




Comments:
1. The commit for this change:
2011-07-21
http://svn.apache.org/viewvc?view=revision&revision=1149220

"Fix path parameter handling. Prevent the following URL failing with a 404:
http://localhost:8080/examples/jsp/snp;x=y/snoop.jsp";


2. The change in behaviour of request.getRequestURI() is dictated by Servlet
specification. The new behaviour (exposing the path parameters as is) is the
correct behaviour. It is already mentioned above (comment 1) and have been
discussed several times on our mailing lists.

A request to clarify Servlet specification is [1].

The behaviour of getRequestURI is essentially clear: it is documented to return
original un-decoded request URI, that is on the first line of HTTP request. [2]
It is behaviour of other related methods that needs to be clarified in [1].

[1] https://java.net/jira/browse/SERVLET_SPEC-18

[2]
http://docs.oracle.com/javaee/6/api/javax/servlet/http/HttpServletRequest.html#getRequestURI%28%29


3. This change was backported from Tomcat 7, where it was a part of a different
fix that involved refactoring of path parameter handling.

The change to getRequestURI() is a side effect of that refactoring.


4. Original proposal for this fix is r1005192 (2010-10-06)

This proposal was discussed in "Re: r1005192" thread on dev@ list. After
several minor improvements (r1035976) it became the change committed in
r1149220.

Discussion thread "Re: r1005192":
http://tomcat.markmail.org/thread/i3m4amzrueafgvyv


5. Original commit that changed path parameter handling in Tomcat 7 is r944920
(2010-05-16, fix for bug 49299) with minor follow-up fixes such as r946584 and
r1035973.

In Tomcat 7 this change is part of Tomcat 7.0.0, so it is not listed in
changelog.


6. This change in getRequestURI() behaviour has caused regression in FORM
authentication:

Bug 53584 - Forms authentication without cookies requires double submission in
6.0.33

The FORM authentication issue was fixed in 6.0.36, 7.0.30.
(r1377878 in Tomcat 6, r1370537 + r1372390 in Tomcat 7)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1692377 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2015-07-23 Thread kkolinko
Author: kkolinko
Date: Thu Jul 23 11:18:04 2015
New Revision: 1692377

URL: http://svn.apache.org/r1692377
Log:
Improve changelog record for r1149220
> (Thu Jul 21 15:23:11 2011 UTC (4 years ago))
> Fix path parameter handling. Prevent the following URL failing with a 404: 
> http://localhost:8080/examples/jsp/snp;x=y/snoop.jsp

Modified:
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1692377&r1=1692376&r2=1692377&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Thu Jul 23 11:18:04 2015
@@ -1790,7 +1790,13 @@
   
   
 Improve handling of URLs with path parameters and prevent incorrect 404
-responses that could occur when path parameters were present. 
(kkolinko)
+responses that could occur when path parameters were present.
+The method getRequestURI() was fixed to comply with
+specification (chapter SRV.3.1 of Servlet Spec. 2.5, javadoc) and now
+returns original request URI line from a HTTP request including any
+path parameters (such as jsessionid). See issues 51833 and
+53584.
+(kkolinko/markt)
   
   
 51473: Fix concatenation of values in



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 51833] Tomcat doesn't strip jsessionid from the url

2015-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=51833

--- Comment #7 from Konstantin Kolinko  ---
I updated Tomcat 6 changelog in r1692377

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58174] New: SSL is not working on IE10

2015-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58174

Bug ID: 58174
   Summary: SSL is not working on IE10
   Product: Tomcat 6
   Version: 6.0.44
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: rick.hicks...@qlogic.com

Created attachment 32933
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32933&action=edit
server.xml

Same Server.xml working on Tomcat 6.0.41 release.

IE just display the page can't be loaded.  Non-SSL works as expected.

Note 1:  on Windows 2012 R2 you need to update the system to the latest IE
11.0.21 for it to work.

Note 2:  using Tomcat 6.0.41 all IE version are functional (no updates
required)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58174] SSL is not working on IE10

2015-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58174

Rick Hicksted  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Rick Hicksted  ---
Windows 2012 only updates to IE 10.0.29 and is unable to update to IE 11.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58174] SSL is not working on IE10

2015-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58174

Rick Hicksted  changed:

   What|Removed |Added

   Severity|normal  |regression

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58174] SSL is not working on IE10

2015-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58174

Rick Hicksted  changed:

   What|Removed |Added

 OS|All |Windows Server 2012

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org