Bug report for Tomcat Connectors [2014/10/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |46337|New|Nor|2008-12-04|real worker name is wrong | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_| |47714|Opn|Cri|2009-08-20|Response mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c| |52334|New|Maj|2011-12-14|recover_time is not properly used | |52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus| |52651|New|Nor|2012-02-13|JKSHMFile size limitation | |53883|New|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe on the p| |53977|New|Maj|2012-10-07|32bits isapi connector cannot work in wow64 mode | |54027|New|Cri|2012-10-18|isapi send request to outside address instead of i| |54112|Opn|Blk|2012-11-07|ISAPI redirector not working when IIS recycles| |54117|New|Maj|2012-11-08|access violation exception in isapi_redirect.dll | |54177|New|Nor|2012-11-20|jkmanager generates non-well-formed XML for certai| |54596|New|Nor|2013-02-22|Relative path functionality truncates last charact| |54621|New|Nor|2013-02-28|[PATCH] custom mod_jk availability checks | |54646|New|Trv|2013-03-06|socket_keepalive is sometimes 1 or true or True in| |54923|New|Nor|2013-05-03|nsapi_redirect.so does not work with iPlanet on So| |56005|New|Nor|2014-01-14|ISAPI redirector WEB-INF/META-INF Path Check false| |56452|New|Nor|2014-04-24|IPv6 address and log level debug caused crash | |56489|New|Enh|2014-05-05|Include a directory for configuration files | |56576|New|Enh|2014-05-29|Websocket support | |56618|
Bug report for Taglibs [2014/10/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | |55609|New|Enh|2013-09-28|c:forEach loop on integer range consumes unnecessa| +-+---+---+--+--+ | Total6 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Native [2014/10/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |52319|Inf|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da] sig| |52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i| |53605|Inf|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash | |53847|Inf|Nor|2012-09-10|High CPU usage in tomcat native 1.22+ | |53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration| |53952|Opn|Nor|2012-10-02|Add support for TLS 1.1 and 1.2 | |54085|New|Nor|2012-11-01|ssl_socket_recv sometimes loops infinitely with no| |54664|New|Reg|2013-03-11|[1.1.27 branch] Poll.remove incorrectly reports AP| |55087|New|Cri|2013-06-10|tomcat crashes in tcnative-1.dll with OCSP when OC| |55113|Inf|Nor|2013-06-18|FIPS-compatible OpenSSL fails fingerprint test in | |55114|New|Nor|2013-06-18|BUILDING file in win32 source package contains UNI| |55706|New|Nor|2013-10-25|broken apr version check in native v1.1.29 build; | |55771|New|Maj|2013-11-12|Memory leak and then crash in org.apache.tomcat.jn| |55797|Inf|Nor|2013-11-19|Tomcat 7.0.47 crashes using server jvm.dll and APR| |55938|New|Nor|2013-12-29|clang-analyzer report for 1.1.31 | |56027|Opn|Nor|2014-01-17|Unable to use TCN on RHEL6 boxes if box is booted | |56108|New|Nor|2014-02-04|Allow user-defined Diffie-Hellman parameters | |56313|New|Maj|2014-03-25|Tomcat 8 crashes in tcnative-1.dll+0x7923 | |56378|New|Nor|2014-04-09|Cert load fails if cert is located in path with no| |56415|New|Maj|2014-04-16|EXCEPTION_ACCESS_VIOLATION (0xc005) in tcnativ| |56844|New|Nor|2014-08-13|Update to OpenSSL 1.0.1j | |56878|New|Trv|2014-08-21|Checking whether unsigned int is less than zero is| |56997|New|Reg|2014-09-19|java.lang.UnsatisfiedLinkError: org.apache.tomcat.| |57140|New|Cri|2014-10-24|tcnative-1.dll 1.1.31 indicated in fatal error| +-+---+---+--+--+ | Total 26 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 8 [2014/10/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs| |53737|Opn|Enh|2012-08-18|Use ServletContext.getJspConfigDescriptor() in Jas| |53930|New|Enh|2012-09-24|allow capture of catalina stdout/stderr to a comma| |54503|New|Enh|2013-01-29|SAML2 based single sign on| |54700|New|Enh|2013-03-15|Improvement: Add support for system property to sp| |54741|New|Enh|2013-03-22|Add org.apache.catalina.startup.Tomcat#addWebapp(S| |55006|New|Enh|2013-05-22|Add http proxy support for ClientEndpoint using sy| |55243|New|Enh|2013-07-11|Add special search string for nested roles| |55252|New|Enh|2013-07-12|Separate Ant and command-line wrappers for JspC | |55383|New|Enh|2013-08-07|Improve markup and design of Tomcat's HTML pages | |55479|New|Enh|2013-08-24|JSR 196 (JASPIC) support in Tomcat| |9|New|Enh|2013-09-14|UserDatabaseRealm enhacement: may use local JNDI | |55675|New|Enh|2013-10-18|Checking and handling invalid configuration option| |55770|New|Enh|2013-11-12|Allow the crlFile to be reloaded | |55788|New|Enh|2013-11-16|TagPlugins should key on tag QName rather than imp| |55884|Ver|Maj|2013-12-14|JSPs no longer compile in Java 8 | |55969|New|Enh|2014-01-07|Security-related enhancements to the Windows Insta| |55988|New|Enh|2014-01-11|Add parameter useCipherSuitesOrder to JSSE (BIO an| |56166|New|Enh|2014-02-20|Suggestions for exception handling (avoid potentia| |56361|New|Enh|2014-04-08|org.apache.tomcat.websocket.WsWebSocketContainer#b| |56397|New|Enh|2014-04-11|Establish parallel Maven-based build process | |56398|New|Enh|2014-04-11|Support Arquillian-based unit testing | |56399|New|Enh|2014-04-11|Re-factor request/response recycling so Coyote and| |56402|New|Enh|2014-04-11|Add support for HTTP Upgrade to AJP components| |56448|New|Enh|2014-04-23|Implement a robust solution for client initiated S| |56546|New|Enh|2014-05-19|Improve thread trace logging in WebappClassLoader.| |56676|New|Enh|2014-06-26|Normalize access to native library| |56713|New|Enh|2014-07-12|Limit time that incoming request waits while webap| |56724|New|Enh|2014-07-15|Restart Container background thread if it died une| |56777|New|Enh|2014-07-28|Allow configuration resources to be loaded from pl| |56838|Opn|Enh|2014-08-11|Performance drop when repeatedly calling WebappCla| |56890|Inf|Maj|2014-08-26|getRealPath returns null | |56917|New|Enh|2014-09-05|Create a configuration to write relative 302 respo| |56966|New|Nor|2014-09-11|AccessLogValve's elapsed time has 15ms precision o| |57021|New|Enh|2014-09-25|Improve logging in AprLifecycleListener and jni.Li| |57108|New|Enh|2014-10-17|Implement multiple sslcontext SNI (server name ind| |57123|New|Enh|2014-10-21|Update to Eclipse ECJ 4.4.1 | |57130|New|Enh|2014-10-22|Allow digest.sh to accept password from a file or | |57135|Inf|Min|2014-10-23|ImportHandler shall ignore non-public classes | |57141|New|Nor|2014-10-24|JSP 2.3 & EL 3.0 Spec conflict w/Static Fields, Me| |57142|New|Nor|2014-10-24|JSP 2.3 & EL 3.0 - %page import directive & EL Imp| +-+---+---+--+--+ | Total 42 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Modules [2014/10/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen| |51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho| |51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods | |52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o| |53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe| |54437|New|Enh|2013-01-16|Update PoolProperties javadoc for ConnectState int| |54929|Inf|Nor|2013-05-05|jdbc-pool cannot be used with Java 1.5, "java.lang| |55078|New|Nor|2013-06-07|Configuring a DataSource Resource with dataSourceJ| |56046|New|Enh|2014-01-21|org.apache.tomcat.jdbc.pool.XADataSource InitSQL p| |56088|New|Maj|2014-01-29|AbstractQueryReport$StatementProxy throws exceptio| |56310|Inf|Maj|2014-03-25|PooledConnection and XAConnection not handled corr| |56586|New|Nor|2014-06-02|initSQL should be committed if defaultAutoCommit =| |56660|New|Maj|2014-06-23|Resource leak in FairBlockingQueue::poll method | |56765|New|Cri|2014-07-23|Classloader leak in Tomcat 8.0.9 caused by DBCP 2.| |56775|New|Nor|2014-07-28|PoolCleanerTime schedule issue| |56779|New|Nor|2014-07-28|Allow multiple connection initialization statement| |56790|New|Nor|2014-07-29|Resizing pool.maxActive to a higher value at runti| |56798|New|Nor|2014-07-31|Idle eviction strategy could perform better (and i| |56804|New|Nor|2014-08-02|Use a default validationQueryTimeout other than "f| |56805|New|Nor|2014-08-02|datasource.getConnection() may be unnecessarily bl| |56837|New|Nor|2014-08-11|if validationQuery have error with timeBetweenEvic| |56970|New|Nor|2014-09-11|MaxActive vs. MaxTotal for commons-dbcp and tomcat| |56974|New|Nor|2014-09-12|jdbc-pool validation query defaultAutoCommit statu| +-+---+---+--+--+ | Total 28 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 7 [2014/10/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |18500|New|Enh|2003-03-30|Host aliases to match by regular expression | |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr| |49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak| |49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al| |49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm| |49821|New|Enh|2010-08-25|Tomcat CLI [PATCH/Contribution] | |50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou| |50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply| |50234|New|Enh|2010-11-08|JspC use servlet 3.0 features | |50504|New|Enh|2010-12-21|Allow setting query string character set trough re| |50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern| |50944|Ver|Blk|2011-03-18|JSF: java.lang.NullPointerException at com.sun.fac| |51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class| |51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to | |51463|New|Enh|2011-07-01|Tomcat.setBaseDir (package org.apache.catalina.st| |51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul| |51587|New|Enh|2011-07-29|Implement status and uptime commands | |51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter [PATC| |52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site| |52381|New|Enh|2011-12-22|Please add OSGi metadata | |52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up| |52489|New|Enh|2012-01-19|Enhancement request for code signing of war files | |52688|New|Enh|2012-02-16|Add ability to remove old access log files [PATCHE| |52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s| |53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota| |53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr| |53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf| |53492|New|Enh|2012-07-01|Make JspC shell multithreaded | |53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from | |53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l| |54330|New|Enh|2012-12-19|Patch with some refactoring of Member.java [PATCH | |54499|New|Enh|2013-01-29|Implementation of Extensible EL Interpreter | |54618|New|Enh|2013-02-28|Add filter implementing HTTP Strict Transport Secu| |54802|New|Enh|2013-04-04|Provide location information for exceptions thrown| |55104|New|Enh|2013-06-16|Allow passing arguments with spaces to Commons Dae| |55470|New|Enh|2013-08-23|Help users for ClassNotFoundExceptions during star| |55477|New|Enh|2013-08-23|Add a solution to map an realm name to a security | |55662|New|Enh|2013-10-17|Add a way to set an instance of java.sql.Driver di| |56148|New|Enh|2014-02-17|support (multiple) ocsp stapling | |56181|New|Enh|2014-02-23|RemoteIpValve & RemoteIpFilter: HttpServletRequest| |56300|New|Enh|2014-03-22|[Tribes] No useful examples, lack of documentation| |56438|New|Enh|2014-04-21|If jar scan does not find context config or TLD co| |56614|New|Enh|2014-06-12|Add a switch to ignore annotations detection on ta| |56787|New|Enh|2014-07-29|Simplified jndi name parsing | |56848|Opn|Nor|2014-08-13|Tomcat accept-language parsing doesn't properly ha| |56931|New|Maj|2014-09-08|VirtualDirContext requires an absolute DocBase| |57136|Opn|Nor|2014-10-24|EL Parser escaping dollar sign not ${ or ${...} | |57144|
Bug report for Tomcat 6 [2014/10/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |43400|New|Enh|2007-09-14|enum support for tag libs | |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44312|Opn|Enh|2008-01-28|Warn when overwritting docBase of the default Host| |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|Opn|Enh|2008-11-21|Tomcat reloading of context.xml does not update do| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46558|Opn|Enh|2009-01-19|Shutdown port with address binding| |46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch| |47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho| |47242|New|Enh|2009-05-22|request for AJP command line client | |47281|New|Enh|2009-05-28|Efficiency of the JDBCStore | |47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session| |47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath| |47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked| |48358|Opn|Enh|2009-12-09|JSP-unloading reloaded| |48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.| |48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b| |48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe| |48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr| |48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems| |48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static| |48928|New|Enh|2010-03-17|An alternative solution to preloading classes when| |49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient | |49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding | |49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/| |49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu| |49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c| |50285|New|Enh|2010-11-17|Standard HTTP and AJP connectors silently ignore a| |50288|New|Enh|2010-11-17|Uploading a war file that already exists should au| |50677|Opn|Enh|2011-01-27|Allow system property variables in catalina.proper| |50692|New|Enh|2011-01-31|Improve log message in ThreadPool.logFull | |51142|New|Enh|2011-05-03|Offer possible resolution of StringIndexOutOfBound| |51513|New|Enh|2011-07-15|GzipInterceptor: Do not compress small packages | |52791|New|Enh|2012-02-28|[PATCH] read windows installer default values from| |52924|New|Enh|2012-03-15|Add support for per-application JSP compile config| |53011|New|Enh|2012-03-31|Ant Jasper task fails after one error | |53031|New|Enh|2012-04-03|Ant Jasper task should support Fork option| |53394|New|Maj|2012-06-11|Log warning if SSLv2 is enabled | |53677|
Re: svn commit: r1634161 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELParser.java java/org/apache/jasper/compiler/Parser.java test/org/apache/jasper/compiler/TestParser.java
On 25/10/2014 01:59, Konstantin Kolinko wrote: > 2014-10-25 3:27 GMT+04:00 : >> Author: markt >> Date: Fri Oct 24 23:27:40 2014 >> New Revision: 1634161 >> >> URL: http://svn.apache.org/r1634161 >> Log: >> Follow up to r1634089. >> Fix some additional test failures with the stricter escaping rules. >> >> Modified: >> tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java >> tomcat/trunk/java/org/apache/jasper/compiler/Parser.java >> tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java > > 1) The patches covered Parser.parseTemplateText(). > > There is also Parser.parseXMLTemplateText() ACK. > 2) In Parser: > > reader.nextChar() can return -1 in case when hasMoreInput() is false. > > In that case nothing has been read and "reader.pushChar();" should not > be called. > > There exists reader.peekChar() method in JspReader, but only for one > character ahead. ACK. > 3) In Parser and JspReader that it uses: There is a caveat with > reader.hasMoreInput(): it modifies the current reader state due to > the call to popFile(). > > If popFile() call happened during the hasMoreInput() call, then > reader.pushChar() won't be possible anymore. > > Is it possible to call pushChar() after end-of-data has been reached? > - I do not see the answer from popFile() code. It needs testing. > > I looked where this pushing/popping comes from, but the only caller to > JspReader.pushFile() is JspReader constructor. I think that actually > there is always no more than a single file. In that case I'd be happy to ditch that code, the sooner the better. Anything to make Jasper less complex would be a good thing. I'll so some svn archaeology and see if I can find a time when that feature was used and what it was used for. Mark > > There exists "JspReader.setSingleFile()" setter method that turns off > multiple files mode. The setter is called in two places, but I have > not yet figured why and why 'single mode' flag is not always true. > > Coverage report: [1] > > 158 boolean hasMoreInput() throws JasperException { > 159 1930260 if (current.cursor >= current.stream.length) { > 160 8958 if (singleFile) return false; > 161 2040 while (popFile()) { > 162 0 if (current.cursor < current.stream.length) return > true; > 163 } > 164 2040 return false; > 165 } > 166 1921302return true; > 167 } > > The popFile() line has "Conditional coverage 50%". The popFile() > method was called, but always returned false. > > [1] > http://ci.apache.org/projects/tomcat/tomcat8/coverage/org.apache.jasper.compiler.JspReader.html > > Best regards, > Konstantin Kolinko > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1634161 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELParser.java java/org/apache/jasper/compiler/Parser.java test/org/apache/jasper/compiler/TestParser.java
On 26/10/2014 08:20, Mark Thomas wrote: > On 25/10/2014 01:59, Konstantin Kolinko wrote: >> 2014-10-25 3:27 GMT+04:00 : >>> Author: markt >>> Date: Fri Oct 24 23:27:40 2014 >>> New Revision: 1634161 >>> >>> URL: http://svn.apache.org/r1634161 >>> Log: >>> Follow up to r1634089. >>> Fix some additional test failures with the stricter escaping rules. >>> >>> Modified: >>> tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java >>> tomcat/trunk/java/org/apache/jasper/compiler/Parser.java >>> tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java >> >> 1) The patches covered Parser.parseTemplateText(). >> >> There is also Parser.parseXMLTemplateText() > > ACK. > >> 2) In Parser: >> >> reader.nextChar() can return -1 in case when hasMoreInput() is false. >> >> In that case nothing has been read and "reader.pushChar();" should not >> be called. >> >> There exists reader.peekChar() method in JspReader, but only for one >> character ahead. > > ACK. > >> 3) In Parser and JspReader that it uses: There is a caveat with >> reader.hasMoreInput(): it modifies the current reader state due to >> the call to popFile(). >> >> If popFile() call happened during the hasMoreInput() call, then >> reader.pushChar() won't be possible anymore. >> >> Is it possible to call pushChar() after end-of-data has been reached? >> - I do not see the answer from popFile() code. It needs testing. >> >> I looked where this pushing/popping comes from, but the only caller to >> JspReader.pushFile() is JspReader constructor. I think that actually >> there is always no more than a single file. > > In that case I'd be happy to ditch that code, the sooner the better. > Anything to make Jasper less complex would be a good thing. > > I'll so some svn archaeology and see if I can find a time when that > feature was used and what it was used for. Tomcat 3.x, for including files: http://svn.apache.org/repos/asf/tomcat/archive/jasper/tags/other/tomcat_33_m4/jasper34/generator/org/apache/jasper34/generator/JspParseEventListener.java and http://svn.apache.org/repos/asf/tomcat/archive/jasper/tags/other/tomcat_33_m4/jasper34/generator/org/apache/jasper34/parser/JspReader.java Elements of it were kept when Jasper was re-written as Jasper2 for Tomcat 4 (and then renamed back to Jasper). As fas as I can tell the pushFile code was never used in Jasper 2 but it has been there since Tomcat 4. Japser(2) handles included files differently. I think it is safe to remove pushFile and all the associated code. Mark > > Mark > > >> >> There exists "JspReader.setSingleFile()" setter method that turns off >> multiple files mode. The setter is called in two places, but I have >> not yet figured why and why 'single mode' flag is not always true. >> >> Coverage report: [1] >> >> 158 boolean hasMoreInput() throws JasperException { >> 159 1930260 if (current.cursor >= current.stream.length) { >> 160 8958 if (singleFile) return false; >> 161 2040 while (popFile()) { >> 162 0 if (current.cursor < current.stream.length) return >> true; >> 163 } >> 164 2040 return false; >> 165 } >> 166 1921302return true; >> 167 } >> >> The popFile() line has "Conditional coverage 50%". The popFile() >> method was called, but always returned false. >> >> [1] >> http://ci.apache.org/projects/tomcat/tomcat8/coverage/org.apache.jasper.compiler.JspReader.html >> >> Best regards, >> Konstantin Kolinko >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634311 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/connector/ClientAbortException.java webapps/docs/changelog.xml
Author: kkolinko Date: Sun Oct 26 12:13:16 2014 New Revision: 1634311 URL: http://svn.apache.org/r1634311 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57144 Improve ClientAbortException to provide non-null message in getMessage() and full class name in toString(). Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/ClientAbortException.java tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/ClientAbortException.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/ClientAbortException.java?rev=1634311&r1=1634310&r2=1634311&view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/ClientAbortException.java (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/ClientAbortException.java Sun Oct 26 12:13:16 2014 @@ -24,7 +24,6 @@ import java.io.IOException; * * @author Glenn L. Nielsen */ - public final class ClientAbortException extends IOException { private static final long serialVersionUID = 1L; @@ -36,9 +35,7 @@ public final class ClientAbortException * Construct a new ClientAbortException with no other information. */ public ClientAbortException() { - -this(null, null); - +super(); } @@ -48,9 +45,8 @@ public final class ClientAbortException * @param message Message describing this exception */ public ClientAbortException(String message) { - -this(message, null); - +super(message); +this.message = getMessage(); } @@ -60,9 +56,9 @@ public final class ClientAbortException * @param throwable Throwable that caused this exception */ public ClientAbortException(Throwable throwable) { - -this(null, throwable); - +super(throwable); +this.message = getMessage(); +this.throwable = throwable; } @@ -74,11 +70,9 @@ public final class ClientAbortException * @param throwable Throwable that caused this exception */ public ClientAbortException(String message, Throwable throwable) { - -super(); -this.message = message; +super(message, throwable); +this.message = getMessage(); this.throwable = throwable; - } @@ -87,60 +81,17 @@ public final class ClientAbortException /** * The error message passed to our constructor (if any) + * @deprecated Use {@link Throwable#getMessage()} */ +@Deprecated protected String message = null; /** * The underlying exception or error passed to our constructor (if any) + * @deprecated Use {@link Throwable#getCause()} */ +@Deprecated protected Throwable throwable = null; - -//-- Public Methods - - -/** - * Returns the message associated with this exception, if any. - */ -@Override -public String getMessage() { - -return (message); - -} - - -/** - * Returns the cause that caused this exception, if any. - */ -@Override -public Throwable getCause() { - -return (throwable); - -} - - -/** - * Return a formatted string that describes this exception. - */ -@Override -public String toString() { - -StringBuilder sb = new StringBuilder("ClientAbortException: "); -if (message != null) { -sb.append(message); -if (throwable != null) { -sb.append(": "); -} -} -if (throwable != null) { -sb.append(throwable.toString()); -} -return (sb.toString()); - -} - - } Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1634311&r1=1634310&r2=1634311&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sun Oct 26 12:13:16 2014 @@ -97,6 +97,10 @@ Update the minimum required version of the Tomcat Native library (if used) to 1.1.32. (markt) + +57144: Improve ClientAbortException to provide non-null +message. (kkolinko) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57144] Improve ClientAbortException.getMessage() to provide non-null message in Tomcat 7
https://issues.apache.org/bugzilla/show_bug.cgi?id=57144 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED OS||All --- Comment #1 from Konstantin Kolinko --- Fixed in Tomcat 7 by r1634311 and will be in 7.0.57 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634312 - in /tomcat/trunk/test/org/apache: catalina/comet/TestCometProcessor.java catalina/connector/TestCoyoteAdapter.java catalina/loader/TestWebappClassLoaderMemoryLeak.java juli/Test
Author: kkolinko Date: Sun Oct 26 12:31:59 2014 New Revision: 1634312 URL: http://svn.apache.org/r1634312 Log: Simplify code that waits for threads to finish. This allows to shorten wait time if threads finish earlier. A subtle difference is that Thread.join() is a synchronized method while Thread.isAlive() is not one. Modified: tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java tomcat/trunk/test/org/apache/juli/TestClassLoaderLogManager.java Modified: tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java?rev=1634312&r1=1634311&r2=1634312&view=diff == --- tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java (original) +++ tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java Sun Oct 26 12:31:59 2014 @@ -392,19 +392,9 @@ public class TestCometProcessor extends tomcat.getConnector().stop(); -int count = 0; -// Wait for the read thread to stop -while (readThread.isAlive() && count < 50) { -Thread.sleep(100); -count ++; -} - -// Wait for the write thread to stop -count = 0; -while (writeThread.isAlive() && count < 50) { -Thread.sleep(100); -count ++; -} +// Wait for the read and write threads to stop +readThread.join(5000); +writeThread.join(5000); // Destroy the connector once the executor has sent the end event tomcat.getConnector().destroy(); Modified: tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java?rev=1634312&r1=1634311&r2=1634312&view=diff == --- tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java (original) +++ tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java Sun Oct 26 12:31:59 2014 @@ -317,12 +317,7 @@ public class TestCoyoteAdapter extends T // Wait for server thread to stop Thread t = servlet.getThread(); long startTime = System.nanoTime(); -for (int count = 0; t.isAlive() && count < 20; count++) { -t.join(250); -if (!t.isAlive()) { -break; -} -} +t.join(5000); long endTime = System.nanoTime(); log.info("Waited for servlet thread to stop for " + (endTime - startTime) / 100 + " ms"); Modified: tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java?rev=1634312&r1=1634311&r2=1634312&view=diff == --- tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java (original) +++ tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java Sun Oct 26 12:31:59 2014 @@ -63,11 +63,7 @@ public class TestWebappClassLoaderMemory for (Thread thread : threads) { if (thread != null && thread.isAlive() && TaskServlet.TIMER_THREAD_NAME.equals(thread.getName())) { -int count = 0; -while (count < 50 && thread.isAlive()) { -Thread.sleep(100); -count++; -} +thread.join(5000); if (thread.isAlive()) { fail("Timer thread still running"); } Modified: tomcat/trunk/test/org/apache/juli/TestClassLoaderLogManager.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/juli/TestClassLoaderLogManager.java?rev=1634312&r1=1634311&r2=1634312&view=diff == --- tomcat/trunk/test/org/apache/juli/TestClassLoaderLogManager.java (original) +++ tomcat/trunk/test/org/apache/juli/TestClassLoaderLogManager.java Sun Oct 26 12:31:59 2014 @@ -76,14 +76,10 @@ public class TestClassLoaderLogManager { listThread.setName("LoggerList"); listThread.start(); -int count = 0; -while (count < 4 && listThread.isAlive()) { -try { -Thread.sleep(500); -} catch (InterruptedException e) { -// Ignore -} -count++; +try { +listThread.join(2000); +} catch (InterruptedException e) { +// Ignore }
svn commit: r1634313 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/comet/ test/org/apache/catalina/connector/ test/org/apache/catalina/loader/ test/org/apache/juli/
Author: kkolinko Date: Sun Oct 26 12:34:29 2014 New Revision: 1634313 URL: http://svn.apache.org/r1634313 Log: Simplify code that waits for threads to finish. This allows to shorten wait time if threads finish earlier. Merged r1634312 from tomcat/trunk. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/comet/TestCometProcessor.java tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java tomcat/tc7.0.x/trunk/test/org/apache/juli/TestClassLoaderLogManager.java Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1634312 Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/comet/TestCometProcessor.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/comet/TestCometProcessor.java?rev=1634313&r1=1634312&r2=1634313&view=diff == --- tomcat/tc7.0.x/trunk/test/org/apache/catalina/comet/TestCometProcessor.java (original) +++ tomcat/tc7.0.x/trunk/test/org/apache/catalina/comet/TestCometProcessor.java Sun Oct 26 12:34:29 2014 @@ -392,19 +392,9 @@ public class TestCometProcessor extends tomcat.getConnector().stop(); -int count = 0; -// Wait for the read thread to stop -while (readThread.isAlive() && count < 50) { -Thread.sleep(100); -count ++; -} - -// Wait for the write thread to stop -count = 0; -while (writeThread.isAlive() && count < 50) { -Thread.sleep(100); -count ++; -} +// Wait for the read and write threads to stop +readThread.join(5000); +writeThread.join(5000); // Destroy the connector once the executor has sent the end event tomcat.getConnector().destroy(); Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java?rev=1634313&r1=1634312&r2=1634313&view=diff == --- tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java (original) +++ tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java Sun Oct 26 12:34:29 2014 @@ -317,12 +317,7 @@ public class TestCoyoteAdapter extends T // Wait for server thread to stop Thread t = servlet.getThread(); long startTime = System.nanoTime(); -for (int count = 0; t.isAlive() && count < 20; count++) { -t.join(250); -if (!t.isAlive()) { -break; -} -} +t.join(5000); long endTime = System.nanoTime(); log.info("Waited for servlet thread to stop for " + (endTime - startTime) / 100 + " ms"); Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java?rev=1634313&r1=1634312&r2=1634313&view=diff == --- tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java (original) +++ tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java Sun Oct 26 12:34:29 2014 @@ -63,11 +63,7 @@ public class TestWebappClassLoaderMemory for (Thread thread : threads) { if (thread != null && thread.isAlive() && TaskServlet.TIMER_THREAD_NAME.equals(thread.getName())) { -int count = 0; -while (count < 50 && thread.isAlive()) { -Thread.sleep(100); -count++; -} +thread.join(5000); if (thread.isAlive()) { fail("Timer thread still running"); } Modified: tomcat/tc7.0.x/trunk/test/org/apache/juli/TestClassLoaderLogManager.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/juli/TestClassLoaderLogManager.java?rev=1634313&r1=1634312&r2=1634313&view=diff == --- tomcat/tc7.0.x/trunk/test/org/apache/juli/TestClassLoaderLogManager.java (original) +++ tomcat/tc7.0.x/trunk/test/org/apache/juli/TestClassLoaderLogManager.java Sun Oct 26 12:34:29 2014 @@ -76,14 +76,10 @@ public class TestClassLoaderLogManager { listThread.setName("LoggerList"); listThread.start(); -int count = 0; -while (count < 4 && listThread.isAlive()) { -
svn commit: r1634316 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationJspPropertyGroupDescriptor.java
Author: kkolinko Date: Sun Oct 26 12:51:20 2014 New Revision: 1634316 URL: http://svn.apache.org/r1634316 Log: Simplify. Do not call toString() on values that are already strings. This is backport of r1633448 and followup to r1633452 (BZ 57105). Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationJspPropertyGroupDescriptor.java Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1633448 Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationJspPropertyGroupDescriptor.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationJspPropertyGroupDescriptor.java?rev=1634316&r1=1634315&r2=1634316&view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationJspPropertyGroupDescriptor.java (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationJspPropertyGroupDescriptor.java Sun Oct 26 12:51:20 2014 @@ -41,25 +41,13 @@ public class ApplicationJspPropertyGroup @Override public String getBuffer() { -String result = null; - -if (jspPropertyGroup.getBuffer() != null) { -result = jspPropertyGroup.getBuffer().toString(); -} - -return result; +return jspPropertyGroup.getBuffer(); } @Override public String getDefaultContentType() { -String result = null; - -if (jspPropertyGroup.getDefaultContentType() != null) { -result = jspPropertyGroup.getDefaultContentType().toString(); -} - -return result; +return jspPropertyGroup.getDefaultContentType(); } @@ -126,13 +114,7 @@ public class ApplicationJspPropertyGroup @Override public String getPageEncoding() { -String result = null; - -if (jspPropertyGroup.getPageEncoding() != null) { -result = jspPropertyGroup.getPageEncoding().toString(); -} - -return result; +return jspPropertyGroup.getPageEncoding(); } - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634318 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: schultz Date: Sun Oct 26 12:58:01 2014 New Revision: 1634318 URL: http://svn.apache.org/r1634318 Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1634318&r1=1634317&r2=1634318&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Oct 26 12:58:01 2014 @@ -100,7 +100,7 @@ PATCHES PROPOSED TO BACKPORT: 53952 patch above and I think that there is no pressing need to change the "required" version. https://people.apache.org/~kkolinko/patches/2014-10-25_tc6_native1132.patch - +1: kkolinko + +1: kkolinko, schultz -1: PATCHES/ISSUES THAT ARE STALLED: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634319 - /tomcat/trunk/modules/jdbc-pool/build.properties.default
Author: kkolinko Date: Sun Oct 26 13:00:23 2014 New Revision: 1634319 URL: http://svn.apache.org/r1634319 Log: Update dependency Modified: tomcat/trunk/modules/jdbc-pool/build.properties.default Modified: tomcat/trunk/modules/jdbc-pool/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.properties.default?rev=1634319&r1=1634318&r2=1634319&view=diff == --- tomcat/trunk/modules/jdbc-pool/build.properties.default (original) +++ tomcat/trunk/modules/jdbc-pool/build.properties.default Sun Oct 26 13:00:23 2014 @@ -79,7 +79,7 @@ mysql.home=${base.path}/mysql-connector- mysql.jar=${mysql.home}/mysql-connector-java-5.1.12-bin.jar mysql.loc=http://mysql.mirrors.hoobly.com/Downloads/Connector-J/mysql-connector-java-5.1.12.zip -tomcat.version=8.0.9 +tomcat.version=8.0.14 tomcat.home=${base.path}/apache-tomcat-${tomcat.version} tomcat.dbcp.jar=${tomcat.home}/lib/tomcat-dbcp.jar tomcat.juli.jar=${tomcat.home}/bin/tomcat-juli.jar - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634326 - /tomcat/trunk/modules/jdbc-pool/doc/package.xsl
Author: kkolinko Date: Sun Oct 26 13:48:11 2014 New Revision: 1634326 URL: http://svn.apache.org/r1634326 Log: Fix standalone javadoc generation in jdbc-pool using "javadoc" task in build.xml of jdbc-pool. I doubt anyone uses it. Usually javadocs for the pool are generated from Tomcat-wide task in Tomcat's main build.xml file. There is a trick: jdbc-pool.xml is transformed into package.html file. Javadoc tool cannot parse the generated package.html if the page has complex headers, footers, HTML comments. Modified: tomcat/trunk/modules/jdbc-pool/doc/package.xsl Modified: tomcat/trunk/modules/jdbc-pool/doc/package.xsl URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/package.xsl?rev=1634326&r1=1634325&r2=1634326&view=diff == --- tomcat/trunk/modules/jdbc-pool/doc/package.xsl (original) +++ tomcat/trunk/modules/jdbc-pool/doc/package.xsl Sun Oct 26 13:48:11 2014 @@ -15,8 +15,13 @@ See the License for the specific language governing permissions and limitations under the License. --> - - + http://www.w3.org/1999/XSL/Transform"; version="1.0"> @@ -28,14 +33,8 @@ - - http://tomcat.apache.org/'"/> - - - - http://issues.apache.org/bugzilla/show_bug.cgi?id='"/> http://svn.apache.org/viewvc?view=rev&rev='"/> @@ -60,123 +59,19 @@ - - - - - - - - - - - - -.noPrint {display: none;} -td#mainBody {width: 100%;} - - - - PAGE HEADER - - - - - - - - - - - - - - PROJECT LOGO - - - - - - - - - - - - APACHE LOGO - - - - http://www.apache.org/";> - - - - - - - - - HEADER SEPARATOR - - - - - - - - -RIGHT SIDE MAIN BODY - - - + . - - - - - FOOTER SEPARATOR - - - - - - - PAGE FOOTER - - -Copyright © 1999-2014, Apache Software Foundation - - - - - - - - - - - - - - - - - - - - - - @@ -322,15 +217,6 @@ td#mainBody {width: 100%;} - - - - - - - - - @@ -341,91 +227,6 @@ td#mainBody {width: 100%;} - - - - - - - - - - /images/add.gif - - - - - - - - /images/update.gif - - - - - - - - /images/design.gif - - - - - - - - /images/docs.gif - - - - - - - - /images/fix.gif - - - - - - - - /images/code.gif - - - - - - - - - - - Priority - - - Action Item - - - Volunteers - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634327 - /tomcat/trunk/modules/jdbc-pool/build.xml
Author: kkolinko Date: Sun Oct 26 13:52:15 2014 New Revision: 1634327 URL: http://svn.apache.org/r1634327 Log: Align javadoc generation options for javadoc task of jdbc-pool with main Tomcat. Suppress timestamp comment in generated Javadoc (see r1633500). Modified: tomcat/trunk/modules/jdbc-pool/build.xml Modified: tomcat/trunk/modules/jdbc-pool/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.xml?rev=1634327&r1=1634326&r2=1634327&view=diff == --- tomcat/trunk/modules/jdbc-pool/build.xml (original) +++ tomcat/trunk/modules/jdbc-pool/build.xml Sun Oct 26 13:52:15 2014 @@ -123,9 +123,14 @@ -http://java.sun.com/javase/6/docs/api/";> + + http://docs.oracle.com/javase/7/docs/api/"/> + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634328 - in /tomcat/trunk/modules/jdbc-pool: build.xml doc/package.xsl
Author: kkolinko Date: Sun Oct 26 13:54:05 2014 New Revision: 1634328 URL: http://svn.apache.org/r1634328 Log: Use UTF-8 for javadoc like in the main Tomcat build.xml - port of r1634105 Modified: tomcat/trunk/modules/jdbc-pool/build.xml tomcat/trunk/modules/jdbc-pool/doc/package.xsl Modified: tomcat/trunk/modules/jdbc-pool/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.xml?rev=1634328&r1=1634327&r2=1634328&view=diff == --- tomcat/trunk/modules/jdbc-pool/build.xml (original) +++ tomcat/trunk/modules/jdbc-pool/build.xml Sun Oct 26 13:54:05 2014 @@ -126,6 +126,9 @@ Modified: tomcat/trunk/modules/jdbc-pool/doc/package.xsl URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/package.xsl?rev=1634328&r1=1634327&r2=1634328&view=diff == --- tomcat/trunk/modules/jdbc-pool/doc/package.xsl (original) +++ tomcat/trunk/modules/jdbc-pool/doc/package.xsl Sun Oct 26 13:54:05 2014 @@ -28,7 +28,7 @@ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634329 - /tomcat/trunk/webapps/docs/changelog.xml
Author: kkolinko Date: Sun Oct 26 14:01:28 2014 New Revision: 1634329 URL: http://svn.apache.org/r1634329 Log: Changelog entry for r1634326 Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1634329&r1=1634328&r2=1634329&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sun Oct 26 14:01:28 2014 @@ -326,6 +326,10 @@ 57079: Use Tomcat version number for jdbc-pool module when building and shipping the module as part of Tomcat. (markt) + +Fix broken overview page in javadoc generated via "javadoc" task in +jdbc-pool build.xml file. (kkolinko) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634330 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/doc/package.xsl webapps/docs/changelog.xml
Author: kkolinko Date: Sun Oct 26 14:08:45 2014 New Revision: 1634330 URL: http://svn.apache.org/r1634330 Log: Fix standalone javadoc generation in jdbc-pool using "javadoc" task in build.xml of jdbc-pool. I doubt anyone uses it. Usually javadocs for the pool are generated from Tomcat-wide task in Tomcat's main build.xml file. There is a trick: jdbc-pool.xml is transformed into package.html file. Javadoc tool cannot parse the generated package.html if the page has complex headers, footers, HTML comments. Merged r1634326 r1634329 from tomcat/trunk. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/modules/jdbc-pool/doc/package.xsl tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1634326,1634329 Modified: tomcat/tc7.0.x/trunk/modules/jdbc-pool/doc/package.xsl URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/modules/jdbc-pool/doc/package.xsl?rev=1634330&r1=1634329&r2=1634330&view=diff == --- tomcat/tc7.0.x/trunk/modules/jdbc-pool/doc/package.xsl (original) +++ tomcat/tc7.0.x/trunk/modules/jdbc-pool/doc/package.xsl Sun Oct 26 14:08:45 2014 @@ -15,8 +15,13 @@ See the License for the specific language governing permissions and limitations under the License. --> - - + http://www.w3.org/1999/XSL/Transform"; version="1.0"> @@ -28,14 +33,8 @@ - - http://tomcat.apache.org/'"/> - - - - http://issues.apache.org/bugzilla/show_bug.cgi?id='"/> http://svn.apache.org/viewvc?view=rev&rev='"/> @@ -60,123 +59,19 @@ - - - - - - - - - - - - -.noPrint {display: none;} -td#mainBody {width: 100%;} - - - - PAGE HEADER - - - - - - - - - - - - - - PROJECT LOGO - - - - - - - - - - - - APACHE LOGO - - - - http://www.apache.org/";> - - - - - - - - - HEADER SEPARATOR - - - - - - - - -RIGHT SIDE MAIN BODY - - - + . - - - - - FOOTER SEPARATOR - - - - - - - PAGE FOOTER - - -Copyright © 1999-2014, Apache Software Foundation - - - - - - - - - - - - - - - - - - - - - - @@ -322,15 +217,6 @@ td#mainBody {width: 100%;} - - - - - - - - - @@ -341,91 +227,6 @@ td#mainBody {width: 100%;} - - - - - - - - - - /images/add.gif - - - - - - - - /images/update.gif - - - - - - - - /images/design.gif - - - - - - - - /images/docs.gif - - - - - - - - /images/fix.gif - - - - - - - - /images/code.gif - - - - - - - - - - - Priority - - - Action Item - - - Volunteers - - - - - - - - - - - - - - - - - - Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1634330&r1=1634329&r2=1634330&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sun Oct 26 14:08:45 2014 @@ -193,6 +193,10 @@ 57079: Use Tomcat version number for jdbc-pool module when building and shipping the module as part of Tomcat. (markt/kkolinko) + +Fix broken overview page in javadoc generated via "javadoc" task in +jdbc-pool build.xml file. (kkolinko) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634332 - in /tomcat/tc7.0.x/trunk: ./ build.xml modules/jdbc-pool/build.xml webapps/docs/changelog.xml
Author: kkolinko Date: Sun Oct 26 14:18:47 2014 New Revision: 1634332 URL: http://svn.apache.org/r1634332 Log: Suppress timestamp comment in generated Javadoc. Such as Those comments result in one changed line per each HTML file, which makes the diff between different versions of documentation unnecessary huge. Documentation: http://docs.oracle.com/javase/7/docs/technotes/tools/solaris/javadoc.html#standard Merged r1633500 r1634327 from tomcat/trunk. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/build.xml tomcat/tc7.0.x/trunk/modules/jdbc-pool/build.xml tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1633500,1634327 Modified: tomcat/tc7.0.x/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.xml?rev=1634332&r1=1634331&r2=1634332&view=diff == --- tomcat/tc7.0.x/trunk/build.xml (original) +++ tomcat/tc7.0.x/trunk/build.xml Sun Oct 26 14:18:47 2014 @@ -1837,7 +1837,7 @@ Apache Tomcat ${version} native binaries header="Servlet 3.0 - Apache Tomcat ${version}" bottom="Copyright © 2000-${year} Apache Software Foundation. All Rights Reserved." encoding="ISO-8859-1" - additionalparam="-breakiterator" + additionalparam="-breakiterator -notimestamp" maxmemory="256m" executable="${java.7.home}/bin/javadoc"> @@ -1855,7 +1855,7 @@ Apache Tomcat ${version} native binaries header="JSP 2.2 - Apache Tomcat ${version}" bottom="Copyright © 2000-${year} Apache Software Foundation. All Rights Reserved." encoding="ISO-8859-1" - additionalparam="-breakiterator" + additionalparam="-breakiterator -notimestamp" maxmemory="256m" executable="${java.7.home}/bin/javadoc"> @@ -1873,7 +1873,7 @@ Apache Tomcat ${version} native binaries header="EL 2.2 - Apache Tomcat ${version}" bottom="Copyright © 2000-${year} Apache Software Foundation. All Rights Reserved." encoding="ISO-8859-1" - additionalparam="-breakiterator" + additionalparam="-breakiterator -notimestamp" maxmemory="256m" executable="${java.7.home}/bin/javadoc"> @@ -1891,7 +1891,7 @@ Apache Tomcat ${version} native binaries header="WebSocket 1.1 - Apache Tomcat ${version}" bottom="Copyright © 2000-${year} Apache Software Foundation. All Rights Reserved." encoding="ISO-8859-1" - additionalparam="-breakiterator" + additionalparam="-breakiterator -notimestamp" maxmemory="256m" executable="${java.7.home}/bin/javadoc"> @@ -1908,7 +1908,7 @@ Apache Tomcat ${version} native binaries header="Apache Tomcat ${version}" bottom="Copyright © 2000-${year} Apache Software Foundation. All Rights Reserved." encoding="ISO-8859-1" - additionalparam="-breakiterator" + additionalparam="-breakiterator -notimestamp" maxmemory="256m" executable="${java.7.home}/bin/javadoc"> Modified: tomcat/tc7.0.x/trunk/modules/jdbc-pool/build.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/modules/jdbc-pool/build.xml?rev=1634332&r1=1634331&r2=1634332&view=diff == --- tomcat/tc7.0.x/trunk/modules/jdbc-pool/build.xml (original) +++ tomcat/tc7.0.x/trunk/modules/jdbc-pool/build.xml Sun Oct 26 14:18:47 2014 @@ -123,9 +123,15 @@ -http://java.sun.com/javase/6/docs/api/";> + + http://docs.oracle.com/javase/6/docs/api/"/> + Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1634332&r1=1634331&r2=1634332&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sun Oct 26 14:18:47 2014 @@ -185,6 +185,9 @@ In examples web application move Async and Comet examples from JSP to Servlet examples page. (kkolinko) + +Suppress timestamp comments in Javadoc. (kkolinko) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-nio2 : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2 -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build) Work ended in a state of : Failed Elapsed: 25 mins 38 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO2 -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141026-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20141026.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141026-native-src.tar.gz -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.openssl.path=/srv/gump/public/workspace/openssl/dest-20141026/bi n/openssl -Dexecute.test.apr=false -Dexecute.test.bio=false -Dexecute.test.nio2=true -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20141026.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu ild/lib/tomcat-spdy.
svn commit: r1634342 - /tomcat/tc7.0.x/trunk/build.xml
Author: kkolinko Date: Sun Oct 26 14:47:11 2014 New Revision: 1634342 URL: http://svn.apache.org/r1634342 Log: Remove patch-javadoc macros. It is not used, because another solution has been applier: all javadoc is generated with Java 7 JDK. Java 7.0.25+ is not vulnerable to CVE-2013-1571 that is fixed by this patch macro. Modified: tomcat/tc7.0.x/trunk/build.xml Modified: tomcat/tc7.0.x/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.xml?rev=1634342&r1=1634341&r2=1634342&view=diff == --- tomcat/tc7.0.x/trunk/build.xml (original) +++ tomcat/tc7.0.x/trunk/build.xml Sun Oct 26 14:47:11 2014 @@ -1931,74 +1931,6 @@ Apache Tomcat ${version} native binaries - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634345 - in /tomcat/tc7.0.x/trunk: build.xml webapps/docs/changelog.xml
Author: kkolinko Date: Sun Oct 26 14:53:55 2014 New Revision: 1634345 URL: http://svn.apache.org/r1634345 Log: Configure javadoc tool to generate tags with charset information. Modified: tomcat/tc7.0.x/trunk/build.xml tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.xml?rev=1634345&r1=1634344&r2=1634345&view=diff == --- tomcat/tc7.0.x/trunk/build.xml (original) +++ tomcat/tc7.0.x/trunk/build.xml Sun Oct 26 14:53:55 2014 @@ -1837,6 +1837,8 @@ Apache Tomcat ${version} native binaries header="Servlet 3.0 - Apache Tomcat ${version}" bottom="Copyright © 2000-${year} Apache Software Foundation. All Rights Reserved." encoding="ISO-8859-1" + docencoding="ISO-8859-1" + charset="ISO-8859-1" additionalparam="-breakiterator -notimestamp" maxmemory="256m" executable="${java.7.home}/bin/javadoc"> @@ -1855,6 +1857,8 @@ Apache Tomcat ${version} native binaries header="JSP 2.2 - Apache Tomcat ${version}" bottom="Copyright © 2000-${year} Apache Software Foundation. All Rights Reserved." encoding="ISO-8859-1" + docencoding="ISO-8859-1" + charset="ISO-8859-1" additionalparam="-breakiterator -notimestamp" maxmemory="256m" executable="${java.7.home}/bin/javadoc"> @@ -1873,6 +1877,8 @@ Apache Tomcat ${version} native binaries header="EL 2.2 - Apache Tomcat ${version}" bottom="Copyright © 2000-${year} Apache Software Foundation. All Rights Reserved." encoding="ISO-8859-1" + docencoding="ISO-8859-1" + charset="ISO-8859-1" additionalparam="-breakiterator -notimestamp" maxmemory="256m" executable="${java.7.home}/bin/javadoc"> @@ -1891,6 +1897,8 @@ Apache Tomcat ${version} native binaries header="WebSocket 1.1 - Apache Tomcat ${version}" bottom="Copyright © 2000-${year} Apache Software Foundation. All Rights Reserved." encoding="ISO-8859-1" + docencoding="ISO-8859-1" + charset="ISO-8859-1" additionalparam="-breakiterator -notimestamp" maxmemory="256m" executable="${java.7.home}/bin/javadoc"> @@ -1908,6 +1916,8 @@ Apache Tomcat ${version} native binaries header="Apache Tomcat ${version}" bottom="Copyright © 2000-${year} Apache Software Foundation. All Rights Reserved." encoding="ISO-8859-1" + docencoding="ISO-8859-1" + charset="ISO-8859-1" additionalparam="-breakiterator -notimestamp" maxmemory="256m" executable="${java.7.home}/bin/javadoc"> Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1634345&r1=1634344&r2=1634345&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sun Oct 26 14:53:55 2014 @@ -186,7 +186,8 @@ to Servlet examples page. (kkolinko) -Suppress timestamp comments in Javadoc. (kkolinko) +Suppress timestamp comments and enable charset header in Javadoc. +(kkolinko) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1634352 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Sun Oct 26 15:31:35 2014 New Revision: 1634352 URL: http://svn.apache.org/r1634352 Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1634352&r1=1634351&r2=1634352&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Oct 26 15:31:35 2014 @@ -103,6 +103,25 @@ PATCHES PROPOSED TO BACKPORT: +1: kkolinko, schultz -1: +* Configure javadoc tool to read sources as ISO-8859-1, suppress timestamp + comments and enable charset header. + + Motivation: + Timestamp comments: Those comments result in one changed line per each + HTML file, which makes the diff between different versions of + documentation unnecessary huge. I expect that the effect will be + noticeable when publishing documentation for version (next+1). The diff + between versions (next) and (next+1) will be smaller and easier to review. + + Charset header: The rest of Tomcat 6 documentation already has + header with charset information in generated HTML. This enables it for + Javadoc as well. + + https://people.apache.org/~kkolinko/patches/2014-10-26_tc6_javadoc_timestamp.patch + +1: kkolinko + -1: + + PATCHES/ISSUES THAT ARE STALLED: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44312 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57147] New: Fixes to JDBC Based Store Documentation
https://issues.apache.org/bugzilla/show_bug.cgi?id=57147 Bug ID: 57147 Summary: Fixes to JDBC Based Store Documentation Product: Tomcat 8 Version: 8.0.12 Hardware: PC OS: All Status: NEW Severity: normal Priority: P2 Component: Documentation Assignee: dev@tomcat.apache.org Reporter: fernando.ribe...@upic.com.br There are some fixes to make in the documentation of the JDBC-based store [1]: 1- The connectionName and connectionPassword parameters are missing 2- The sessionAppCol, sessionDataCol, sessionIdCol, sessionLastAccessedCol, sessionMaxInactiveCol, sessionTable and sessionValidCol parameters, which are optional, seem to be marked as required 3- The DDL for the sessions table doesn't match the defaults in the JDBCStore class [2]: CREATE TABLE tomcat$sessions ( id VARCHAR(100) NOT NULL PRIMARY KEY, app VARCHAR(255), data MEDIUMBLOB, lastaccess BIGINT NOT NULL, maxinactive INT NOT NULL, valid CHAR(1) NOT NULL ); [1] http://tomcat.apache.org/tomcat-8.0-doc/config/manager.html [2] http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57148] New: EL type conversion of empty string when there is a PropertyEditor (ELSupport.coerceToType())
https://issues.apache.org/bugzilla/show_bug.cgi?id=57148 Bug ID: 57148 Summary: EL type conversion of empty string when there is a PropertyEditor (ELSupport.coerceToType()) Product: Tomcat 8 Version: 8.0.14 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: EL Assignee: dev@tomcat.apache.org Reporter: knst.koli...@gmail.com (Noted when reviewing org.apache.el.lang.ELSupport.coerceToType()) My expectations are that ELSupport.coerceToType() method follows the type conversion rules specified in Expression Language specification. There is the following phrase in specification 3.0 ch.1.23.7 Coerce A to Any Other Type T: "If A is a String and T's PropertyEditor throws an exception:" "If A is "", return null" "Otherwise, error" The same phrase in present in EL 2.2 and EL 2.1 specifications (ch.1.18.7) as well. Consider the following case: - A is an empty string ("") - T has a PropertyEditor Expected behaviour: - Call PropertyEditor with value of "". - If it throws an exception, return null. - Otherwise use the converted value. try { propertyEditor.setAsText("").getValue(); } catch (RuntimeException e) { return null; } Actual implementation: - It skips calling the PropertyEditor and immediately returns null. if (obj instanceof String) { if ("".equals(obj)) return null; PropertyEditor editor = PropertyEditorManager.findEditor(type); ... The PropertyEditor.setAsText(String) method is documented to throw IllegalArgumentException on invalid values. I think that EL API expects an ELException, so it is to be wrapped somewhere. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Array handling in ELSupport.coerceToType() (Re: r1633806, r1607906)
Hi! This is a comment on the following commits: URL: http://svn.apache.org/r1633806 Log: When coercing an object to a given type, only attempt coercion to an array if both the object type and the target type are an array type. URL: http://svn.apache.org/r1607906 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56652 Add support for method parameters that use arrays and varargs to ELProcessor.defineFunction() Issues: 1) General issue: In r1607906 there was added a conversion support for arrays into ELSupport.coerceToType() and r1633806 fixed a bug in it. My understanding is that the method ELSupport.coerceToType() implements conversion rules from EL specification chapter "Type Conversion" (ch.1.23 in EL 3.0). My concern is that EL specification does not specify such conversion for array elements. As such, the varargs support fix needs a different implementation that does not change the ELSupport.coerceToType() method. 2) Technical issue: The ELSupport.coerceToArray() method does not support arrays of primitives. It class-casts its argument "(Object[]) obj", but that will fail for arrays of primitives. The correct way is to use the following method to access array elements: java.lang.reflect.Array.get(Object, int): Object 3) Bikeshed: Maybe mention BZ 56425#c6 in changelog for r1607906. I noted another unrelated difference vs specification in coerceToType() method - filed BZ 57148. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57147] Fixes to Documentation of JDBC-Based Store
https://issues.apache.org/bugzilla/show_bug.cgi?id=57147 Fernando Ribeiro changed: What|Removed |Added Summary|Fixes to JDBC Based Store |Fixes to Documentation of |Documentation |JDBC-Based Store -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57148] EL type conversion of empty string when there is a PropertyEditor (ELSupport.coerceToType())
https://issues.apache.org/bugzilla/show_bug.cgi?id=57148 --- Comment #1 from Konstantin Kolinko --- Created attachment 32147 --> https://issues.apache.org/bugzilla/attachment.cgi?id=32147&action=edit 2014-10-27_tc8_57148_v1.patch Patch for current trunk. Not tested. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57147] Fixes to Documentation of JDBC-Based Store
https://issues.apache.org/bugzilla/show_bug.cgi?id=57147 --- Comment #1 from Konstantin Kolinko --- (In reply to Fernando Ribeiro from comment #0) > 3- The DDL for the sessions table doesn't match the defaults in the > JDBCStore class [2]: > > CREATE TABLE tomcat$sessions ( > id VARCHAR(100) NOT NULL PRIMARY KEY, > app VARCHAR(255), > data MEDIUMBLOB, > lastaccess BIGINT NOT NULL, > maxinactive INT NOT NULL, > valid CHAR(1) NOT NULL > ); I see no such DDL code as above in JDBCStore class. Where is it from? Did you take the default column names and wrote it by yourself? I would say that the DDL in documentation has more readable column names. It also specifies "KEY kapp_name(app_name)". Is any substantial missing in documented DDL? I wonder whether "MEDIUMBLOB" is specific to MySQL or is actually defined in some specification. > 1- The connectionName and connectionPassword parameters are missing Those have to be documented. Though a better recommendation is to use a DataSource, referenced via dataSourceName property. When a DataSource is used, the "connectionURL", "driverName" properties are no more required. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57147] Fixes to Documentation of JDBC-Based Store
https://issues.apache.org/bugzilla/show_bug.cgi?id=57147 --- Comment #2 from Fernando Ribeiro --- (In reply to Konstantin Kolinko from comment #1) > (In reply to Fernando Ribeiro from comment #0) > > 3- The DDL for the sessions table doesn't match the defaults in the > > JDBCStore class [2]: > > > > CREATE TABLE tomcat$sessions ( > > id VARCHAR(100) NOT NULL PRIMARY KEY, > > app VARCHAR(255), > > data MEDIUMBLOB, > > lastaccess BIGINT NOT NULL, > > maxinactive INT NOT NULL, > > valid CHAR(1) NOT NULL > > ); > > I see no such DDL code as above in JDBCStore class. Where is it from? > Did you take the default column names and wrote it by yourself? Right. > I would say that the DDL in documentation has more readable column names. It > also specifies "KEY kapp_name(app_name)". Is any substantial missing in > documented DDL? They may be more readable but they are not the defaults. The key may really need to be added to my DDL. > I wonder whether "MEDIUMBLOB" is specific to MySQL or is actually defined in > some specification. It is a MySQL data type not available in many other databases. > > 1- The connectionName and connectionPassword parameters are missing > > Those have to be documented. > Though a better recommendation is to use a DataSource, referenced via > dataSourceName property. > > When a DataSource is used, the "connectionURL", "driverName" properties are > no more required. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 7 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-nio : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-NIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build) Work ended in a state of : Failed Elapsed: 25 mins 7 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141027-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20141027.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141027-native-src.tar.gz -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true -Dtest.openssl.path=/srv/gump/public/workspace/openssl/dest-20141027/bin/o penssl -Dexecute.test.apr=false -Dexecute.test.bio=false -Dexecute.test.nio2=false -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20141027.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu ild/lib/tomcat-s