svn commit: r1618112 - in /tomcat/trunk: java/org/apache/catalina/connector/Request.java test/org/apache/catalina/connector/TestRequest.java test/org/apache/catalina/connector/TesterRequest.java webap

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 07:34:43 2014
New Revision: 1618112

URL: http://svn.apache.org/r1618112
Log:
Need to put all locales in order before adding them to the locales collection - 
not just those from the first header.

Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
tomcat/trunk/test/org/apache/catalina/connector/TesterRequest.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1618112&r1=1618111&r2=1618112&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Fri Aug 15 
07:34:43 2014
@@ -3086,26 +3086,33 @@ public class Request
 
 localesParsed = true;
 
+// Store the accumulated languages that have been requested in
+// a local collection, sorted by the quality value (so we can
+// add Locales in descending order).  The values will be ArrayLists
+// containing the corresponding Locales to be added
+TreeMap> locales = new TreeMap<>();
+
 Enumeration values = getHeaders("accept-language");
 
 while (values.hasMoreElements()) {
 String value = values.nextElement();
-parseLocalesHeader(value);
+parseLocalesHeader(value, locales);
 }
 
+// Process the quality values in highest->lowest order (due to
+// negating the Double value when creating the key)
+for (ArrayList list : locales.values()) {
+for (Locale locale : list) {
+addLocale(locale);
+}
+}
 }
 
 
 /**
  * Parse accept-language header value.
  */
-protected void parseLocalesHeader(String value) {
-
-// Store the accumulated languages that have been requested in
-// a local collection, sorted by the quality value (so we can
-// add Locales in descending order).  The values will be ArrayLists
-// containing the corresponding Locales to be added
-TreeMap> locales = new TreeMap<>();
+protected void parseLocalesHeader(String value, TreeMap> locales) {
 
 // Preprocess the value to remove all whitespace
 int white = value.indexOf(' ');
@@ -3200,17 +3207,7 @@ public class Request
 locales.put(key, values);
 }
 values.add(locale);
-
-}
-
-// Process the quality values in highest->lowest order (due to
-// negating the Double value when creating the key)
-for (ArrayList list : locales.values()) {
-for (Locale locale : list) {
-addLocale(locale);
-}
 }
-
 }
 
 

Modified: tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java?rev=1618112&r1=1618111&r2=1618112&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java (original)
+++ tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java Fri Aug 15 
07:34:43 2014
@@ -27,6 +27,7 @@ import java.net.URL;
 import java.util.ArrayList;
 import java.util.Enumeration;
 import java.util.List;
+import java.util.Locale;
 import java.util.TreeMap;
 
 import javax.servlet.ServletException;
@@ -39,8 +40,8 @@ import static org.junit.Assert.assertNot
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
+import org.junit.Assert;
 import org.junit.Test;
-
 import org.apache.catalina.Context;
 import org.apache.catalina.authenticator.BasicAuthenticator;
 import org.apache.catalina.filters.FailedRequestFilter;
@@ -795,4 +796,35 @@ public class TestRequest extends TomcatB
 resp.getWriter().print(req.getContextPath());
 }
 }
+
+@Test
+public void getLocaleMultipleHeaders01() throws Exception {
+TesterRequest req = new TesterRequest();
+
+req.addHeader("accept-language", "en;q=0.5");
+req.addHeader("accept-language", "en-gb");
+
+Locale actual = req.getLocale();
+Locale expected = Locale.forLanguageTag("en-gb");
+
+Assert.assertEquals(expected, actual);
+}
+
+/*
+ * Reverse header order of getLocaleMultipleHeaders01() and make sure the
+ * result is the same.
+ */
+@Test
+public void getLocaleMultipleHeaders02() throws Exception {
+TesterRequest req = new TesterRequest();
+
+req.addHeader("accept-language", "en-gb");
+req.addHeader("accept-language", "en;q=0.5");
+
+Locale actual = req.getLocale();
+Locale expected = Locale

[jira] [Created] (MTOMCAT-274) Tomcat8 integration tests fail with JDK 7 / Maven 3.2.2

2014-08-15 Thread Envious Guest (JIRA)
Envious Guest created MTOMCAT-274:
-

 Summary: Tomcat8 integration tests fail with JDK 7 / Maven 3.2.2
 Key: MTOMCAT-274
 URL: https://issues.apache.org/jira/browse/MTOMCAT-274
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
Affects Versions: 2.3
 Environment: OS name: "mac os x", version: "10.9.4", arch: "x86_64", 
family: "mac"
Java version: 1.7.0_67, vendor: Oracle Corporation
Maven 3.2.2
Reporter: Envious Guest


When running integration tests for Tomcat8, like that:

mvn clean verify -pl :tomcat8-maven-plugin -am -P run-its

The build fails with following exception:

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war (default-war) on 
project simple-war-project: Execution default-war of goal 
org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war failed: Cannot 
construct org.apache.maven.plugin.war.util.WebappStructure as it does not have 
a no-args constructor
 Debugging information 
message : Cannot construct 
org.apache.maven.plugin.war.util.WebappStructure as it does not have a no-args 
constructor
cause-exception : 
com.thoughtworks.xstream.converters.reflection.ObjectAccessException
cause-message   : Cannot construct 
org.apache.maven.plugin.war.util.WebappStructure as it does not have a no-args 
constructor
class   : org.apache.maven.plugin.war.util.WebappStructure
required-type   : org.apache.maven.plugin.war.util.WebappStructure
path: /webapp-structure
line number : 1
---
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:364)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
default-war of goal org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war 
failed: Cannot construct org.apache.maven.plugin.war.util.WebappStructure as it 
does not have a no-args constructor




--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat-maven-plugin pull request: Updated maven-war-plugin version

2014-08-15 Thread anenviousguest
GitHub user anenviousguest opened a pull request:

https://github.com/apache/tomcat-maven-plugin/pull/8

Updated maven-war-plugin version

Related to MTOMCAT-274
ITs for Tomcat 7 still passing, ITs for Tomcat8 are still failing, but 
WebappStructure-related error is now gone.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anenviousguest/tomcat-maven-plugin tc8.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-maven-plugin/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 506769941392604a7c4fd5f9772461b175000aab
Author: Vladislav Ponomarev 
Date:   2014-08-15T08:12:52Z

Updated maven-war-plugin version




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-trunk

2014-08-15 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/371

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1618112
Blamelist: markt

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-274) Tomcat8 integration tests fail with JDK 7 / Maven 3.2.2

2014-08-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098341#comment-14098341
 ] 

ASF GitHub Bot commented on MTOMCAT-274:


GitHub user anenviousguest opened a pull request:

https://github.com/apache/tomcat-maven-plugin/pull/8

Updated maven-war-plugin version

Related to MTOMCAT-274
ITs for Tomcat 7 still passing, ITs for Tomcat8 are still failing, but 
WebappStructure-related error is now gone.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anenviousguest/tomcat-maven-plugin tc8.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-maven-plugin/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 506769941392604a7c4fd5f9772461b175000aab
Author: Vladislav Ponomarev 
Date:   2014-08-15T08:12:52Z

Updated maven-war-plugin version




> Tomcat8 integration tests fail with JDK 7 / Maven 3.2.2
> ---
>
> Key: MTOMCAT-274
> URL: https://issues.apache.org/jira/browse/MTOMCAT-274
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>Affects Versions: 2.3
> Environment: OS name: "mac os x", version: "10.9.4", arch: "x86_64", 
> family: "mac"
> Java version: 1.7.0_67, vendor: Oracle Corporation
> Maven 3.2.2
>Reporter: Envious Guest
>
> When running integration tests for Tomcat8, like that:
> mvn clean verify -pl :tomcat8-maven-plugin -am -P run-its
> The build fails with following exception:
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war (default-war) 
> on project simple-war-project: Execution default-war of goal 
> org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war failed: Cannot 
> construct org.apache.maven.plugin.war.util.WebappStructure as it does not 
> have a no-args constructor
>  Debugging information 
> message : Cannot construct 
> org.apache.maven.plugin.war.util.WebappStructure as it does not have a 
> no-args constructor
> cause-exception : 
> com.thoughtworks.xstream.converters.reflection.ObjectAccessException
> cause-message   : Cannot construct 
> org.apache.maven.plugin.war.util.WebappStructure as it does not have a 
> no-args constructor
> class   : org.apache.maven.plugin.war.util.WebappStructure
> required-type   : org.apache.maven.plugin.war.util.WebappStructure
> path: /webapp-structure
> line number : 1
> ---
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:364)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 

[jira] [Commented] (MTOMCAT-274) Tomcat8 integration tests fail with JDK 7 / Maven 3.2.2

2014-08-15 Thread Envious Guest (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098342#comment-14098342
 ] 

Envious Guest commented on MTOMCAT-274:
---

This allegedly has something to do with specific maven-war-plugin version which 
is not yet JDK 7-ready , as mentioned for example here: 
https://issues.apache.org/jira/browse/AMQ-3427

As a quick fix, I tried to update to most recent one (2.4) which seemingly did 
the trick. For sake of consistency, I updated the maven-war-plugin version also 
in tomcat7 plugin, whose integration tests still pass.


> Tomcat8 integration tests fail with JDK 7 / Maven 3.2.2
> ---
>
> Key: MTOMCAT-274
> URL: https://issues.apache.org/jira/browse/MTOMCAT-274
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>Affects Versions: 2.3
> Environment: OS name: "mac os x", version: "10.9.4", arch: "x86_64", 
> family: "mac"
> Java version: 1.7.0_67, vendor: Oracle Corporation
> Maven 3.2.2
>Reporter: Envious Guest
>
> When running integration tests for Tomcat8, like that:
> mvn clean verify -pl :tomcat8-maven-plugin -am -P run-its
> The build fails with following exception:
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war (default-war) 
> on project simple-war-project: Execution default-war of goal 
> org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war failed: Cannot 
> construct org.apache.maven.plugin.war.util.WebappStructure as it does not 
> have a no-args constructor
>  Debugging information 
> message : Cannot construct 
> org.apache.maven.plugin.war.util.WebappStructure as it does not have a 
> no-args constructor
> cause-exception : 
> com.thoughtworks.xstream.converters.reflection.ObjectAccessException
> cause-message   : Cannot construct 
> org.apache.maven.plugin.war.util.WebappStructure as it does not have a 
> no-args constructor
> class   : org.apache.maven.plugin.war.util.WebappStructure
> required-type   : org.apache.maven.plugin.war.util.WebappStructure
> path: /webapp-structure
> line number : 1
> ---
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:364)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-war of goal org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war 
> failed: Cannot construct org.apache.maven.plugin.war.util.WebappStructure as 
> it does not have a no-args constructor



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---

[Bug 56703] "Current number of backend connections" counter ever increasing when timeouts are defined

2014-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56703

--- Comment #6 from Martin Knoblauch  ---
Hi Rainer,

 good you double checked. I applied my previous fix to a productive system and
found that while it reduced the growth by 80-90 %, there was still something
missing.

 So, I found that [in my case] the remaining cases were happening in
"ajp_connection_tcp_get_message" when the calls to "jk_tcp_socket_recvfull"
were returning JK_SOCKET_EOF. So adding the "connected--" in those places cured
the problem for good.

 I then looked at the remaining case when abort_endpoint was called with
"shutdown == JK_FALSE". That is in "ajp_connection_tcp_send_message" when
"jk_tcp_socket_sendfull" returns an error. So in my opinion "connection--" is
warranted here also.

 But that would mean that commit r1334399 was the wrong fix to the going
negative problem. Hmm...

 Now looking at r1618000, you have decoupled the checks for "valid socket" and
"perform shutdown" in abort_endpoint and decrement the connection counter
regardless of the shutdown setting. That will definitely fix the growth
problem.

 But will it also fix the going negative thing? Looking at pre r1334399, a
superfluous decrement could happen when abort_endpoint was called with an
"invalidated" . Do you this could happen?

 Anyway, I will try to test on my high volume setup.

Martin

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56848] Tomcat accept-language parsing doesn't properly handle IETF BCP47 language tags

2014-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56848

--- Comment #1 from Mark Thomas  ---
This has been fixed in 8.0.x for 8.0.11 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1618166 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/http/parser/ test/org/apache/catalina/connector/ test/org/apache/tomcat/util/http/parser/ webap

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 12:47:56 2014
New Revision: 1618166

URL: http://svn.apache.org/r1618166
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56848
Improve handling of accept-language headers.

Added:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/AcceptLanguage.java   
(with props)

tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java   
(with props)
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
tomcat/trunk/java/org/apache/tomcat/util/http/parser/Authorization.java
tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
tomcat/trunk/java/org/apache/tomcat/util/http/parser/MediaType.java
tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
tomcat/trunk/test/org/apache/catalina/connector/TesterRequest.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1618166&r1=1618165&r2=1618166&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Fri Aug 15 
12:47:56 2014
@@ -21,6 +21,7 @@ import java.io.BufferedReader;
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.StringReader;
 import java.io.UnsupportedEncodingException;
 import java.lang.reflect.InvocationTargetException;
 import java.nio.charset.Charset;
@@ -76,7 +77,6 @@ import org.apache.catalina.core.Applicat
 import org.apache.catalina.core.AsyncContextImpl;
 import org.apache.catalina.mapper.MappingData;
 import org.apache.catalina.util.ParameterMap;
-import org.apache.catalina.util.StringParser;
 import org.apache.coyote.ActionCode;
 import org.apache.juli.logging.Log;
 import org.apache.juli.logging.LogFactory;
@@ -95,6 +95,7 @@ import org.apache.tomcat.util.http.fileu
 import org.apache.tomcat.util.http.fileupload.disk.DiskFileItemFactory;
 import org.apache.tomcat.util.http.fileupload.servlet.ServletFileUpload;
 import org.apache.tomcat.util.http.fileupload.servlet.ServletRequestContext;
+import org.apache.tomcat.util.http.parser.AcceptLanguage;
 import org.apache.tomcat.util.res.StringManager;
 import org.ietf.jgss.GSSCredential;
 import org.ietf.jgss.GSSException;
@@ -367,12 +368,6 @@ public class Request
 
 
 /**
- * The string parser we will use for parsing request lines.
- */
-private final StringParser parser = new StringParser();
-
-
-/**
  * Local port
  */
 protected int localPort = -1;
@@ -3114,99 +3109,24 @@ public class Request
  */
 protected void parseLocalesHeader(String value, TreeMap> locales) {
 
-// Preprocess the value to remove all whitespace
-int white = value.indexOf(' ');
-if (white < 0) {
-white = value.indexOf('\t');
-}
-if (white >= 0) {
-StringBuilder sb = new StringBuilder();
-int len = value.length();
-for (int i = 0; i < len; i++) {
-char ch = value.charAt(i);
-if ((ch != ' ') && (ch != '\t')) {
-sb.append(ch);
-}
-}
-parser.setString(sb.toString());
-} else {
-parser.setString(value);
+List acceptLanguages;
+try {
+acceptLanguages = AcceptLanguage.parse(new StringReader(value));
+} catch (IOException e) {
+// Mal-formed headers are ignore. Do the same in the unlikely event
+// of an IOException.
+return;
 }
 
-// Process each comma-delimited language specification
-int length = parser.getLength();
-while (true) {
-
-// Extract the next comma-delimited entry
-int start = parser.getIndex();
-if (start >= length) {
-break;
-}
-int end = parser.findChar(',');
-String entry = parser.extract(start, end).trim();
-parser.advance();   // For the following entry
-
-// Extract the quality factor for this entry
-double quality = 1.0;
-int semi = entry.indexOf(";q=");
-if (semi >= 0) {
-try {
-String strQuality = entry.substring(semi + 3);
-if (strQuality.length() <= 5) {
-quality = Double.parseDouble(strQuality);
-} else {
-quality = 0.0;
-}
-} catch (NumberFormatException e) {
-quality = 0.0;
-}
-entry = entry.substring(0, semi);
-}
-
-// Skip entries we are not going to keep track of
-if 

[Bug 56857] Thread safety issue in ApplicationContextFacade.invokeMethod

2014-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56857

--- Comment #2 from Mark Thomas  ---
Fixed in 8.0.x for 8.0.11 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1618169 - in /tomcat/trunk: java/org/apache/catalina/core/ApplicationContextFacade.java webapps/docs/changelog.xml

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 12:54:37 2014
New Revision: 1618169

URL: http://svn.apache.org/r1618169
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56857
Fix thread safety issue when calling ServletContext methods while running under 
a security manager.

Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java?rev=1618169&r1=1618168&r2=1618169&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java 
Fri Aug 15 12:54:37 2014
@@ -32,6 +32,7 @@ import java.util.EventListener;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
 
 import javax.servlet.Filter;
 import javax.servlet.FilterRegistration;
@@ -61,13 +62,13 @@ public class ApplicationContextFacade im
 /**
  * Cache Class object used for reflection.
  */
-private final HashMap[]> classCache;
+private final Map[]> classCache;
 
 
 /**
  * Cache method object.
  */
-private final HashMap objectCache;
+private final Map objectCache;
 
 
 // --- Constructors
@@ -84,7 +85,7 @@ public class ApplicationContextFacade im
 this.context = context;
 
 classCache = new HashMap<>();
-objectCache = new HashMap<>();
+objectCache = new ConcurrentHashMap<>();
 initClassCache();
 }
 

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1618169&r1=1618168&r2=1618169&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Aug 15 12:54:37 2014
@@ -145,6 +145,10 @@
 56848: Improve handling of accept-language
 headers. (markt)
   
+  
+56857: Fix thread safety issue when calling ServletContext
+methods while running under a security manager. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Tomcat for 8.0.next

2014-08-15 Thread Mark Thomas
On 12/08/2014 13:42, Mark Thomas wrote:
> It has been a while since my aborted attempt at the last 8.0.x release
> and we have quite a few additional changes so I intend to start a 8.0.x
> release shortly.
> 
> I'm starting to run the unit tests on the usual platforms (OSX, Win64,
> Linux64) now and - assuming they all pass - I'll tag 8.0.11 once the
> tests complete. I may still tag if we see some failures (e.g. in NIO2)
> but I'll look at the on a case by case basis.

Unsurprisingly, I got distracted. Trying this again now...

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1618171 - /tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 13:17:14 2014
New Revision: 1618171

URL: http://svn.apache.org/r1618171
Log:
Checkstyle

Modified:
tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java

Modified: tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java?rev=1618171&r1=1618170&r2=1618171&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java (original)
+++ tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java Fri Aug 15 
13:17:14 2014
@@ -43,6 +43,7 @@ import static org.junit.Assert.fail;
 import org.junit.Assert;
 import org.junit.Ignore;
 import org.junit.Test;
+
 import org.apache.catalina.Context;
 import org.apache.catalina.authenticator.BasicAuthenticator;
 import org.apache.catalina.filters.FailedRequestFilter;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1618175 - /tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 13:47:58 2014
New Revision: 1618175

URL: http://svn.apache.org/r1618175
Log:
Update for name change

Modified:
tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java?rev=1618175&r1=1618174&r2=1618175&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java Fri 
Aug 15 13:47:58 2014
@@ -276,7 +276,7 @@ public final class SecurityClassLoad {
 clazz.newInstance();
 loader.loadClass(basePackage + "util.http.HttpMessages");
 loader.loadClass(basePackage + "util.http.parser.HttpParser");
-loader.loadClass(basePackage + 
"util.http.parser.HttpParser$SkipConstantResult");
+loader.loadClass(basePackage + 
"util.http.parser.HttpParser$SkipResult");
 loader.loadClass(basePackage + "util.http.parser.MediaType");
 loader.loadClass(basePackage + "util.http.parser.MediaTypeCache");
 // net



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56860] New: SpdyAprNpnHandler class cast exception

2014-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56860

Bug ID: 56860
   Summary: SpdyAprNpnHandler class cast exception
   Product: Tomcat 8
   Version: 8.0.9
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: jmnarl...@gmail.com

I've tried to experiment with the SPDY within Tomcat, but unfortunetly without
much luck.

I've installed the APR in the lib modules
Configured the SpdyAprNpnHandler:



Although finding sample configuration is some hard, any chance that you could
document this somewhere?

And run the server, the SSL nogatition starts as I recieve the warning from the
browser regarding untrusted certificate but afterward the connection is being
reset.

>From logs I was able to find this error:
15-Aug-2014 17:46:46.447 SEVERE [http-nio-9443-exec-9]
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun 
 java.lang.ClassCastException: org.apache.tomcat.util.net.SecureNioChannel
cannot be cast to java.lang.Long
at
org.apache.coyote.spdy.SpdyAprNpnHandler.process(SpdyAprNpnHandler.java:96)
at
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:217)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1566)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1523)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Unknown Source)

Do you thing that this is permament, or I might be missing some additional
configuration?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1618166 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/http/parser/ test/org/apache/catalina/connector/ test/org/apache/tomcat/util/http/parser/ w

2014-08-15 Thread Konstantin Kolinko
2014-08-15 16:47 GMT+04:00  :
> Author: markt
> Date: Fri Aug 15 12:47:56 2014
> New Revision: 1618166
>
> URL: http://svn.apache.org/r1618166
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56848
> Improve handling of accept-language headers.
>
> Added:
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/AcceptLanguage.java  
>  (with props)
> 
> tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java  
>  (with props)
> Modified:
> tomcat/trunk/java/org/apache/catalina/connector/Request.java
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/Authorization.java
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
> tomcat/trunk/java/org/apache/tomcat/util/http/parser/MediaType.java
> tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
> tomcat/trunk/test/org/apache/catalina/connector/TesterRequest.java
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1618166&r1=1618165&r2=1618166&view=diff
> ==
> --- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Fri Aug 15 
> 12:47:56 2014
> @@ -21,6 +21,7 @@ import java.io.BufferedReader;
>  import java.io.File;
>  import java.io.IOException;
>  import java.io.InputStream;
> +import java.io.StringReader;
>  import java.io.UnsupportedEncodingException;
>  import java.lang.reflect.InvocationTargetException;
>  import java.nio.charset.Charset;
> @@ -76,7 +77,6 @@ import org.apache.catalina.core.Applicat
>  import org.apache.catalina.core.AsyncContextImpl;
>  import org.apache.catalina.mapper.MappingData;
>  import org.apache.catalina.util.ParameterMap;
> -import org.apache.catalina.util.StringParser;
>  import org.apache.coyote.ActionCode;
>  import org.apache.juli.logging.Log;
>  import org.apache.juli.logging.LogFactory;
> @@ -95,6 +95,7 @@ import org.apache.tomcat.util.http.fileu
>  import org.apache.tomcat.util.http.fileupload.disk.DiskFileItemFactory;
>  import org.apache.tomcat.util.http.fileupload.servlet.ServletFileUpload;
>  import org.apache.tomcat.util.http.fileupload.servlet.ServletRequestContext;
> +import org.apache.tomcat.util.http.parser.AcceptLanguage;
>  import org.apache.tomcat.util.res.StringManager;
>  import org.ietf.jgss.GSSCredential;
>  import org.ietf.jgss.GSSException;
> @@ -367,12 +368,6 @@ public class Request
>
>
>  /**
> - * The string parser we will use for parsing request lines.
> - */
> -private final StringParser parser = new StringParser();

As a result, the o.a.c.util.StringParser class is no longer used anywhere.

> -
> -
> -/**
>   * Local port
>   */
>  protected int localPort = -1;
> @@ -3114,99 +3109,24 @@ public class Request
>   */
>  protected void parseLocalesHeader(String value, TreeMap ArrayList> locales) {
>
> -// Preprocess the value to remove all whitespace
> -int white = value.indexOf(' ');
> -if (white < 0) {
> -white = value.indexOf('\t');
> -}
> -if (white >= 0) {
> -StringBuilder sb = new StringBuilder();
> -int len = value.length();
> -for (int i = 0; i < len; i++) {
> -char ch = value.charAt(i);
> -if ((ch != ' ') && (ch != '\t')) {
> -sb.append(ch);
> -}
> -}
> -parser.setString(sb.toString());
> -} else {
> -parser.setString(value);
> +List acceptLanguages;
> +try {
> +acceptLanguages = AcceptLanguage.parse(new StringReader(value));
> +} catch (IOException e) {
> +// Mal-formed headers are ignore. Do the same in the unlikely 
> event
> +// of an IOException.
> +return;
>  }
>
> -// Process each comma-delimited language specification
> -int length = parser.getLength();
> -while (true) {
> -
> -// Extract the next comma-delimited entry
> -int start = parser.getIndex();
> -if (start >= length) {
> -break;
> -}
> -int end = parser.findChar(',');
> -String entry = parser.extract(start, end).trim();
> -parser.advance();   // For the following entry
> -
> -// Extract the quality factor for this entry
> -double quality = 1.0;
> -int semi = entry.indexOf(";q=");
> -if (semi >= 0) {
> -try {
> -String strQuality = entry.substring(semi + 3);
> -if (strQuality.length() <= 5) {
> -quality = Double.parseDouble(strQuality);
>

[Bug 56703] "Current number of backend connections" counter ever increasing when timeouts are defined

2014-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56703

--- Comment #7 from Rainer Jung  ---
Hi Martin,

yes I think r1334399 was a bit to much. There are cases where
ajp_abort_endpoint() is called with shutdown==JK_FALSE because the shutdown
already happened in code lower down. That code doesn't adjust the connected
counter, so we have to do it. That part was correct before r1334399, wrong
between r1334399 and r1618000 and should be OK after my commit r1618000.

The other case was when the socket "sd" was already INVALID. In that case my
code inspection told me that we should not adjust the connected counter, so
here r1334399 was right and r1618000 still is right in not adjusting connected
when sd is INVALID.

I do hope that your production proves us right.

I see no risk of running the patch in production, because apart from the
connected counter nothing has changed. So only your monitoring/status page
display will change. The full 1.2.41 dev has a few more changes/fixes, but they
should be low risk and I'm not aware of new problems.

Thanks for the cooperation. Looking forward for your production results.

Regards,

Rainer

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56860] SpdyAprNpnHandler class cast exception

2014-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56860

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID
 OS||All

--- Comment #1 from Mark Thomas  ---
Bugzilla is not a support forum. Please ask you questions on the users mailing
list.

Regarding the documentation, patches welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1618258 - /tomcat/trunk/java/org/apache/catalina/util/StringParser.java

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 18:59:21 2014
New Revision: 1618258

URL: http://svn.apache.org/r1618258
Log:
Unused code. Prepare to drop it in 9.0.x

Modified:
tomcat/trunk/java/org/apache/catalina/util/StringParser.java

Modified: tomcat/trunk/java/org/apache/catalina/util/StringParser.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/util/StringParser.java?rev=1618258&r1=1618257&r2=1618258&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/util/StringParser.java (original)
+++ tomcat/trunk/java/org/apache/catalina/util/StringParser.java Fri Aug 15 
18:59:21 2014
@@ -28,7 +28,10 @@ package org.apache.catalina.util;
  * method with the appropriate saved offset values.
  *
  * @author Craig R. McClanahan
+ *
+ * @deprecated Unused. Will be removed in Tomcat 9 onwards.
  */
+@Deprecated
 public final class StringParser {
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1618259 - /tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 19:09:39 2014
New Revision: 1618259

URL: http://svn.apache.org/r1618259
Log:
Fix parsing bug when quality ends in invalid character(s)

Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java?rev=1618259&r1=1618258&r2=1618259&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java Fri 
Aug 15 19:09:39 2014
@@ -363,8 +363,9 @@ public class HttpParser {
 } else if (c == delimiter || c == 9 || c == 32 || c == -1) {
 break;
 } else {
-// Go back so character is available for next read
-input.skip(-1);
+// Malformed. Use quality of zero so it is dropped and 
skip until
+// EOF or the next delimiter
+skipUntil(input, c, delimiter);
 return 0;
 }
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1618260 - in /tomcat/trunk: java/org/apache/tomcat/util/http/parser/AcceptLanguage.java test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 19:09:59 2014
New Revision: 1618260

URL: http://svn.apache.org/r1618260
Log:
Optimisation for invalid quality case suggested by kkolinko
Don't create return values that are going to be ignored

Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/AcceptLanguage.java
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/http/parser/AcceptLanguage.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/parser/AcceptLanguage.java?rev=1618260&r1=1618259&r2=1618260&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/http/parser/AcceptLanguage.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/parser/AcceptLanguage.java 
Fri Aug 15 19:09:59 2014
@@ -68,7 +68,9 @@ public class AcceptLanguage {
 quality = HttpParser.readWeight(input, ',');
 }
 
-result.add(new AcceptLanguage(Locale.forLanguageTag(languageTag), 
quality));
+if (quality > 0) {
+result.add(new 
AcceptLanguage(Locale.forLanguageTag(languageTag), quality));
+}
 } while (true);
 
 return result;

Modified: 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java?rev=1618260&r1=1618259&r2=1618260&view=diff
==
--- 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java 
(original)
+++ 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java 
Fri Aug 15 19:09:59 2014
@@ -31,7 +31,6 @@ public class TestAcceptLanguage {
 private static final double Q1_000 = 1;
 private static final double Q0_500 = 0.5;
 private static final double Q0_050 = 0.05;
-private static final double Q0_000 = 0;
 
 @Test
 public void testSingle01() throws Exception {
@@ -153,56 +152,56 @@ public class TestAcceptLanguage {
 
 @Test
 public void testMalformed01() throws Exception {
-List actual = AcceptLanguage.parse(new 
StringReader("en-gb;x=1"));
+List actual = AcceptLanguage.parse(new 
StringReader("en-gb;x=1,en-gb;q=0.5"));
 
 Assert.assertEquals(1, actual.size());
 Assert.assertEquals(L_EN_GB, actual.get(0).getLocale());
-Assert.assertEquals(Q0_000, actual.get(0).getQuality(), 0.0001);
+Assert.assertEquals(Q0_500, actual.get(0).getQuality(), 0.0001);
 }
 
 @Test
 public void testMalformed02() throws Exception {
-List actual = AcceptLanguage.parse(new 
StringReader("en-gb;q=a"));
+List actual = AcceptLanguage.parse(new 
StringReader("en-gb;q=a,en-gb;q=0.5"));
 
 Assert.assertEquals(1, actual.size());
 Assert.assertEquals(L_EN_GB, actual.get(0).getLocale());
-Assert.assertEquals(Q0_000, actual.get(0).getQuality(), 0.0001);
+Assert.assertEquals(Q0_500, actual.get(0).getQuality(), 0.0001);
 }
 
 @Test
 public void testMalformed03() throws Exception {
-List actual = AcceptLanguage.parse(new 
StringReader("en-gb;q=0.5a"));
+List actual = AcceptLanguage.parse(new 
StringReader("en-gb;q=0.5a,en-gb;q=0.5"));
 
 Assert.assertEquals(1, actual.size());
 Assert.assertEquals(L_EN_GB, actual.get(0).getLocale());
-Assert.assertEquals(Q0_000, actual.get(0).getQuality(), 0.0001);
+Assert.assertEquals(Q0_500, actual.get(0).getQuality(), 0.0001);
 }
 
 @Test
 public void testMalformed04() throws Exception {
-List actual = AcceptLanguage.parse(new 
StringReader("en-gb;q=0.05a"));
+List actual = AcceptLanguage.parse(new 
StringReader("en-gb;q=0.05a,en-gb;q=0.5"));
 
 Assert.assertEquals(1, actual.size());
 Assert.assertEquals(L_EN_GB, actual.get(0).getLocale());
-Assert.assertEquals(Q0_000, actual.get(0).getQuality(), 0.0001);
+Assert.assertEquals(Q0_500, actual.get(0).getQuality(), 0.0001);
 }
 
 @Test
 public void testMalformed05() throws Exception {
-List actual = AcceptLanguage.parse(new 
StringReader("en-gb;q=0.005a"));
+List actual = AcceptLanguage.parse(new 
StringReader("en-gb;q=0.005a,en-gb;q=0.5"));
 
 Assert.assertEquals(1, actual.size());
 Assert.assertEquals(L_EN_GB, actual.get(0).getLocale());
-Assert.assertEquals(Q0_000, actual.get(0).getQuality(), 0.0001);
+Assert.assertEquals(Q0_500, actual.get(0).getQuality(), 0.0001);
 }
 
 @Test
 public void testMalformed06() throws Exception {
-List actual = AcceptLanguage.parse(new 
StringReader("en-gb;q=0.5a"));
+List actual = AcceptLanguage.parse(new 
StringReader("en-gb;q=0.5a,en-gb;q=0.5"));
 
 A

svn commit: r1618261 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_11: ./ build.properties.default

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 19:12:49 2014
New Revision: 1618261

URL: http://svn.apache.org/r1618261
Log:
Tag 8.0.11

Added:
tomcat/tc8.0.x/tags/TOMCAT_8_0_11/
  - copied from r1618260, tomcat/trunk/
Modified:
tomcat/tc8.0.x/tags/TOMCAT_8_0_11/build.properties.default

Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_11/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/tags/TOMCAT_8_0_11/build.properties.default?rev=1618261&r1=1618260&r2=1618261&view=diff
==
--- tomcat/tc8.0.x/tags/TOMCAT_8_0_11/build.properties.default (original)
+++ tomcat/tc8.0.x/tags/TOMCAT_8_0_11/build.properties.default Fri Aug 15 
19:12:49 2014
@@ -27,7 +27,7 @@ version.major=8
 version.minor=0
 version.build=11
 version.patch=0
-version.suffix=-dev
+version.suffix=
 
 # - Build control flags -
 # Note enabling validation uses Checkstyle which is LGPL licensed



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1618262 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 19:13:29 2014
New Revision: 1618262

URL: http://svn.apache.org/r1618262
Log:
Prep for next release

Modified:
tomcat/trunk/build.properties.default
tomcat/trunk/res/maven/mvn.properties.default

Modified: tomcat/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1618262&r1=1618261&r2=1618262&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Fri Aug 15 19:13:29 2014
@@ -25,7 +25,7 @@
 # - Version Control Flags -
 version.major=8
 version.minor=0
-version.build=11
+version.build=12
 version.patch=0
 version.suffix=-dev
 

Modified: tomcat/trunk/res/maven/mvn.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/maven/mvn.properties.default?rev=1618262&r1=1618261&r2=1618262&view=diff
==
--- tomcat/trunk/res/maven/mvn.properties.default (original)
+++ tomcat/trunk/res/maven/mvn.properties.default Fri Aug 15 19:13:29 2014
@@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos
 maven.asf.release.repo.repositoryId=apache.releases
 
 # Release version info
-maven.asf.release.deploy.version=8.0.11
+maven.asf.release.deploy.version=8.0.12
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r6174 - /dev/tomcat/tomcat-8/v8.0.10/

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 19:16:19 2014
New Revision: 6174

Log:
Drop failed RC

Removed:
dev/tomcat/tomcat-8/v8.0.10/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r6175 [2/2] - in /dev/tomcat/tomcat-8/v8.0.11: ./ bin/ bin/embed/ bin/extras/ src/

2014-08-15 Thread markt
Added: dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.tar.gz.md5
==
--- dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.tar.gz.md5 (added)
+++ dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.tar.gz.md5 Fri Aug 
15 19:41:59 2014
@@ -0,0 +1 @@
+d59520154ba9df3b341394f95d9dcceb *apache-tomcat-8.0.11-src.tar.gz
\ No newline at end of file

Added: dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.zip
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.zip
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.zip.asc
==
--- dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.zip.asc (added)
+++ dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.zip.asc Fri Aug 15 
19:41:59 2014
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v1.4.9 (MingW32)
+
+iQIcBAABAgAGBQJT7l1HAAoJEBDAHFovYFnnaLkP/Rx2iHOZnVcU0PWyrWHytmlM
+/RvHqFl+utGRWGDii/vjix/rfAYPvumKPzKUIgHbsKlngLggKUpLaqelc48CxUem
+CQ9+FxSYJfDCW3YiGvmjOOZSWzTnwTLmKQGs+Pfmn0QfZZmavToOxMc4rAKpfJBG
+IL9BPGBSk2rlxtQkzHY3GmfqyG8G3skLu4BeVWXeG8X6CdZAvg9XeOj4dYcE8NFn
+ROOpTd0LHNIEEbl3has09/gD1FpLVZwAIXM4xRN9oJ449ntmU2qmxT7O2RXbX4wC
+97NVgf1GqZZZM3CsntkCWFn4S9tIiO51VMysJ14JDNtvil1foi0e7V1kVCXLYp+C
+aL5sIRf7SygjHP0h8huMP3GFFiO9CP8I6/w5xr6OtVqb6UyfmPGeQA4fPEYcNB4x
+Ns0EPAyPirn6Cs+V9q0wI3M0GJg+IuKTOfHzTAPOrkm6Sph8IbFLrmA8LHMH6tMi
+Eq3IOw7zZpRtCXEAShFdT4VxBRAzsaT02ri7oBbUpw1VhQH+eGVHJVKMIYC0iThP
+pcjB+VKl8x6WI2Ip4kBUVNxbVOCD5FfQmepmQ3s+K4mIeayiBWqTMvoVMlwZamdd
+2sueKwGLyR7CDnrvIGfrwtvarCOI1zkFP8Ur0ReZVxS/fz6GiIRSVnw2MNeh4rYv
+GyZ7obxiwFes3MOtrvdx
+=gq+I
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.zip.md5
==
--- dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.zip.md5 (added)
+++ dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.zip.md5 Fri Aug 15 
19:41:59 2014
@@ -0,0 +1 @@
+0863d5541c0df406d9425507a389561b *apache-tomcat-8.0.11-src.zip
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r6175 [1/2] - in /dev/tomcat/tomcat-8/v8.0.11: ./ bin/ bin/embed/ bin/extras/ src/

2014-08-15 Thread markt
Author: markt
Date: Fri Aug 15 19:41:59 2014
New Revision: 6175

Log:
8.0.11 RC for voting

Added:
dev/tomcat/tomcat-8/v8.0.11/
dev/tomcat/tomcat-8/v8.0.11/KEYS   (with props)
dev/tomcat/tomcat-8/v8.0.11/README.html   (with props)
dev/tomcat/tomcat-8/v8.0.11/RELEASE-NOTES
dev/tomcat/tomcat-8/v8.0.11/bin/
dev/tomcat/tomcat-8/v8.0.11/bin/README.html   (with props)
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-deployer.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-deployer.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-deployer.tar.gz.md5
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-deployer.zip   (with 
props)
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-deployer.zip.asc
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-deployer.zip.md5
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-fulldocs.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-fulldocs.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-fulldocs.tar.gz.md5
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-i64.zip   
(with props)
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-i64.zip.asc
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-i64.zip.md5
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x64.zip   
(with props)
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x64.zip.asc
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x64.zip.md5
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x86.zip   
(with props)
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x86.zip.asc
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x86.zip.md5
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.exe   (with props)
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.exe.asc
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.exe.md5
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.tar.gz   (with props)
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.tar.gz.md5
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.zip   (with props)
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.zip.asc
dev/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.zip.md5
dev/tomcat/tomcat-8/v8.0.11/bin/embed/
dev/tomcat/tomcat-8/v8.0.11/bin/embed/apache-tomcat-8.0.11-embed.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.0.11/bin/embed/apache-tomcat-8.0.11-embed.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.11/bin/embed/apache-tomcat-8.0.11-embed.tar.gz.md5
dev/tomcat/tomcat-8/v8.0.11/bin/embed/apache-tomcat-8.0.11-embed.zip   
(with props)
dev/tomcat/tomcat-8/v8.0.11/bin/embed/apache-tomcat-8.0.11-embed.zip.asc
dev/tomcat/tomcat-8/v8.0.11/bin/embed/apache-tomcat-8.0.11-embed.zip.md5
dev/tomcat/tomcat-8/v8.0.11/bin/extras/
dev/tomcat/tomcat-8/v8.0.11/bin/extras/catalina-jmx-remote.jar   (with 
props)
dev/tomcat/tomcat-8/v8.0.11/bin/extras/catalina-jmx-remote.jar.asc
dev/tomcat/tomcat-8/v8.0.11/bin/extras/catalina-jmx-remote.jar.md5
dev/tomcat/tomcat-8/v8.0.11/bin/extras/catalina-ws.jar   (with props)
dev/tomcat/tomcat-8/v8.0.11/bin/extras/catalina-ws.jar.asc
dev/tomcat/tomcat-8/v8.0.11/bin/extras/catalina-ws.jar.md5
dev/tomcat/tomcat-8/v8.0.11/bin/extras/tomcat-juli-adapters.jar   (with 
props)
dev/tomcat/tomcat-8/v8.0.11/bin/extras/tomcat-juli-adapters.jar.asc
dev/tomcat/tomcat-8/v8.0.11/bin/extras/tomcat-juli-adapters.jar.md5
dev/tomcat/tomcat-8/v8.0.11/bin/extras/tomcat-juli.jar   (with props)
dev/tomcat/tomcat-8/v8.0.11/bin/extras/tomcat-juli.jar.asc
dev/tomcat/tomcat-8/v8.0.11/bin/extras/tomcat-juli.jar.md5
dev/tomcat/tomcat-8/v8.0.11/src/
dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.tar.gz   (with 
props)
dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.tar.gz.md5
dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.zip   (with props)
dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.zip.asc
dev/tomcat/tomcat-8/v8.0.11/src/apache-tomcat-8.0.11-src.zip.md5

Added: dev/tomcat/tomcat-8/v8.0.11/KEYS
==
--- dev/tomcat/tomcat-8/v8.0.11/KEYS (added)
+++ dev/tomcat/tomcat-8/v8.0.11/KEYS Fri Aug 15 19:41:59 2014
@@ -0,0 +1,616 @@
+This file contains the PGP&GPG keys of various Apache developers.
+Please don't use them for email unless you have to. Their main
+purpose is code signing.
+
+Apache users: pgp < KEYS
+Apache developers:
+(pgpk -ll  && pgpk -xa ) >> this file.
+  or
+(gpg --fingerprint --list-sigs 
+ && gpg --armor --export ) >> this file.
+
+Apache dev

[VOTE] Release Apache Tomcat 8.0.11

2014-08-15 Thread Mark Thomas
The proposed Apache Tomcat 8.0.11 release is now available for voting.

The main changes since 8.0.9 are:
- Various improvements to the Mapper including fixing some concurrency
  bugs
- Update to Tomcat Native Library version 1.1.31 to pick up the Windows
  binaries that are based on OpenSSL 1.0.1h
- Start to add permessage-deflate to WebSocket. Currently only client
  to server compression is supported.
- Support for using the OpenSSL cipher syntax with JSSE connectors
- Numerous bug fixes

There is also the usual collection of bug fixes, new features and
performance improvements. For full details, see the changelog:
http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.11/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1020/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_11/

The proposed 8.0.11 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.0.11

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56856] org.apache.catalina.ha.session.JvmRouteSessionIDBinderListener class not found exception

2014-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56856

--- Comment #2 from Narayana  ---
Ok 

Thanks for the url helps

You can close this defect fromissue tracker

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-trunk

2014-08-15 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/374

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1618258
Blamelist: markt

Build succeeded!

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed

2014-08-15 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-test-nio has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 14 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-test-nio :  Tomcat 7.x, a web server implementing Java 
Servlet 3.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-NIO/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-nio/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-nio.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 16 mins 45 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140816-native-src.tar.gz
 -Dtest.reports=output/logs-NIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140816-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140816.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar
 -Dexecute.test.nio=true -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/pub
 lic/workspace/commons-pool-1.x 
-Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x 
-Dexecute.test.apr=false -Dexecute.test.bio=false 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20140816.jar
 -Dtest.temp=output/test-tmp-NIO 
-Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140816.jar
 test 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/t

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2014-08-15 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-test-bio has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 14 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-test-bio :  Tomcat 7.x, a web server implementing Java 
Servlet 3.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-bio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/logs-BIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-BIO/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-bio/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-bio.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-bio (Type: Build)
Work ended in a state of : Failed
Elapsed: 15 mins 59 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140816-native-src.tar.gz
 -Dtest.reports=output/logs-BIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140816-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140816.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar
 -Dexecute.test.nio=false -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/pu
 blic/workspace/commons-pool-1.x 
-Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x 
-Dexecute.test.apr=false -Dexecute.test.bio=true 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20140816.jar
 -Dtest.temp=output/test-tmp-BIO 
-Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140816.jar
 test 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/t