[jira] [Commented] (MTOMCAT-234) Tomcat8 Maven Plugin
[ https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096699#comment-14096699 ] Xavier Dury commented on MTOMCAT-234: - About the Classloader issue, it seems that classes are not loaded _from inside_ the jar file but _as_ the jar file itself. I get an error message like "java.lang.ClassFormatError: Incompatible magic value 1347093252 in class file...", 1347093252 = 0x504B0304 = "PK.." (magic string of a zip file). The normal magic string should be 0xCAFEBABE in java class format. > Tomcat8 Maven Plugin > > > Key: MTOMCAT-234 > URL: https://issues.apache.org/jira/browse/MTOMCAT-234 > Project: Apache Tomcat Maven Plugin > Issue Type: Dependency upgrade >Affects Versions: 2.0, 2.1, 2.2 > Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25 >Reporter: Petr Novak >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Blocker > Fix For: 3.0 > > > Please provide initial version of Tomcat8 Maven Plugin. > I tried the recommendations in > http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none > but the guideline > http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html > does not work for Tomcat8 . > The problem is in changed Tomcat 8 API, the maven throws folloving exception: > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142) > ... 20 more > by: java.lang.NoSuchMethodError: > org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106) > ... 20 more > The method setDefaultRealm is deprecated in Tomcat7 and was removed in > Tomcat8 as described in documentation: > http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm) -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56853] New: "java.io.IOException: Broken pipe" occur.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56853 Bug ID: 56853 Summary: "java.io.IOException: Broken pipe" occur. Product: Tomcat 8 Version: 8.0.9 Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P2 Component: Connectors Assignee: dev@tomcat.apache.org Reporter: mouge...@gmail.com When I call Struts Action with Tomcat 8.*, Broken pipe Exception occur. ・If use Tomcat BIO protocol, Exception does not occur. ・If use Tomcat 7.* + NIO protocol, Exception does not occur. ・If read HttpResponse, Exception does not occur. ・If OS is Windows, Exception does not occur. ■ StackTrace org.apache.catalina.connector.ClientAbortException: java.io.IOException: Broken pipe at org.apache.catalina.connector.OutputBuffer.realWriteBytes(OutputBuffer.java:389) at org.apache.tomcat.util.buf.ByteChunk.flushBuffer(ByteChunk.java:426) at org.apache.catalina.connector.OutputBuffer.doFlush(OutputBuffer.java:338) at org.apache.catalina.connector.OutputBuffer.close(OutputBuffer.java:291) at org.apache.catalina.connector.CoyoteOutputStream.close(CoyoteOutputStream.java:151) at org.apache.struts2.dispatcher.StreamResult.doExecute(StreamResult.java:305) at org.apache.struts2.dispatcher.StrutsResultSupport.execute(StrutsResultSupport.java:186) at com.opensymphony.xwork2.DefaultActionInvocation.executeResult(DefaultActionInvocation.java:371) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:275) at org.apache.struts2.interceptor.DeprecationInterceptor.intercept(DeprecationInterceptor.java:41) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at org.apache.struts2.interceptor.debugging.DebuggingInterceptor.intercept(DebuggingInterceptor.java:256) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at com.opensymphony.xwork2.interceptor.DefaultWorkflowInterceptor.doIntercept(DefaultWorkflowInterceptor.java:167) at com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at com.opensymphony.xwork2.validator.ValidationInterceptor.doIntercept(ValidationInterceptor.java:265) at org.apache.struts2.interceptor.validation.AnnotationValidationInterceptor.doIntercept(AnnotationValidationInterceptor.java:68) at com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor.intercept(ConversionErrorInterceptor.java:138) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:254) at com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:254) at com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at com.opensymphony.xwork2.interceptor.StaticParametersInterceptor.intercept(StaticParametersInterceptor.java:191) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at org.apache.struts2.interceptor.MultiselectInterceptor.intercept(MultiselectInterceptor.java:73) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at org.apache.struts2.interceptor.CheckboxInterceptor.intercept(CheckboxInterceptor.java:91) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at org.apache.struts2.interceptor.FileUploadInterceptor.intercept(FileUploadInterceptor.java:252) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at com.opensymphony.xwork2.interceptor.ModelDrivenInterceptor.intercept(ModelDrivenInterceptor.java:100) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at com.opensymphony.xwork2.interceptor.ScopedModelDrivenInterceptor.intercept(ScopedModelDrivenInterceptor.java:141) at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246) at com.opensymphony.xwork2.interceptor.ChainingInterceptor.intercept(ChainingInterceptor.java:145) at com.opensymphony.xwork2.D
[Bug 56853] "java.io.IOException: Broken pipe" occur.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56853 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Mark Thomas --- The client is dropping the connection so the Exception is not unexpected. That the server only sees it in some circumstances is a result of the differences in behaviour between operating systems and between Java IO implementations. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-234) Tomcat8 Maven Plugin
[ https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096829#comment-14096829 ] Xavier Dury commented on MTOMCAT-234: - I could fix it by changing 2 things in the RunMojo (in the code that iterates over the jarPaths): 1. return a JarResource instead of a FileResource 2. remove the condition "ends with .class" otherwise, non-classes resources could not be loaded (*.properties) Do you need a PR? > Tomcat8 Maven Plugin > > > Key: MTOMCAT-234 > URL: https://issues.apache.org/jira/browse/MTOMCAT-234 > Project: Apache Tomcat Maven Plugin > Issue Type: Dependency upgrade >Affects Versions: 2.0, 2.1, 2.2 > Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25 >Reporter: Petr Novak >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Blocker > Fix For: 3.0 > > > Please provide initial version of Tomcat8 Maven Plugin. > I tried the recommendations in > http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none > but the guideline > http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html > does not work for Tomcat8 . > The problem is in changed Tomcat 8 API, the maven throws folloving exception: > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142) > ... 20 more > by: java.lang.NoSuchMethodError: > org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106) > ... 20 more > The method setDefaultRealm is deprecated in Tomcat7 and was removed in > Tomcat8 as described in documentation: > http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm) -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Comment Edited] (MTOMCAT-234) Tomcat8 Maven Plugin
[ https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096829#comment-14096829 ] Xavier Dury edited comment on MTOMCAT-234 at 8/14/14 10:25 AM: --- I could fix it by changing 2 things in the RunMojo (in the code that iterates over the jarPaths): 1. return a JarResource instead of a FileResource 2. remove the condition "ends with .class", otherwise non-classes resources could not be loaded (*.properties) Do you need a PR? was (Author: kalgon): I could fix it by changing 2 things in the RunMojo (in the code that iterates over the jarPaths): 1. return a JarResource instead of a FileResource 2. remove the condition "ends with .class" otherwise, non-classes resources could not be loaded (*.properties) Do you need a PR? > Tomcat8 Maven Plugin > > > Key: MTOMCAT-234 > URL: https://issues.apache.org/jira/browse/MTOMCAT-234 > Project: Apache Tomcat Maven Plugin > Issue Type: Dependency upgrade >Affects Versions: 2.0, 2.1, 2.2 > Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25 >Reporter: Petr Novak >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Blocker > Fix For: 3.0 > > > Please provide initial version of Tomcat8 Maven Plugin. > I tried the recommendations in > http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none > but the guideline > http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html > does not work for Tomcat8 . > The problem is in changed Tomcat 8 API, the maven throws folloving exception: > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142) > ... 20 more > by: java.lang.NoSuchMethodError: > org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106) > ... 20 more > The method setDefaultRealm is deprecated in Tomcat7 and was removed in > Tomcat8 as described in documentation: > http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm) -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1618000 - in /tomcat/jk/trunk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml
Author: rjung Date: Thu Aug 14 17:46:55 2014 New Revision: 1618000 URL: http://svn.apache.org/r1618000 Log: BZ 56703: Fix inflated counter for current number of backend connections in status worker. If an error occured during using a connection and the connection was known to be already shut down by lower level functions, the code to clean up did not decrement the connection counter. The most likely such situation was when a connection timeout occured on the backend. Modified: tomcat/jk/trunk/native/common/jk_ajp_common.c tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/native/common/jk_ajp_common.c URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_ajp_common.c?rev=1618000&r1=1617999&r2=1618000&view=diff == --- tomcat/jk/trunk/native/common/jk_ajp_common.c (original) +++ tomcat/jk/trunk/native/common/jk_ajp_common.c Thu Aug 14 17:46:55 2014 @@ -798,19 +798,21 @@ static int ajp_unmarshal_response(jk_msg static void ajp_abort_endpoint(ajp_endpoint_t * ae, int shutdown, jk_logger_t *l) { JK_TRACE_ENTER(l); -if (shutdown == JK_TRUE && IS_VALID_SOCKET(ae->sd)) { -if (ae->hard_close) { -/* Force unclean connection close to communicate client write errors - * back to Tomcat by aborting AJP response writes. - */ -jk_close_socket(ae->sd, l); -} -else { -jk_shutdown_socket(ae->sd, l); +if (IS_VALID_SOCKET(ae->sd)) { +if (shutdown == JK_TRUE) { +if (ae->hard_close) { +/* Force unclean connection close to communicate client write errors + * back to Tomcat by aborting AJP response writes. + */ +jk_close_socket(ae->sd, l); +} +else { +jk_shutdown_socket(ae->sd, l); +} } ae->worker->s->connected--; +ae->sd = JK_INVALID_SOCKET; } -ae->sd = JK_INVALID_SOCKET; ae->last_op = JK_AJP13_END_RESPONSE; JK_TRACE_EXIT(l); } Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1618000&r1=1617999&r2=1618000&view=diff == --- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Thu Aug 14 17:46:55 2014 @@ -45,6 +45,11 @@ +56703: Status: Fix inflated counter for current number +of backend connections especially when a connection timeout occured +on the backend. (rjung) + + 56661: Fix Servlet API getLocalAddr(). Works for Tomcat 6.0.42, 7.0.55 and 8.0.11 and Apache and ISAPI plugins. (rjung) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56703] "Current number of backend connections" counter ever increasing when timeouts are defined
https://issues.apache.org/bugzilla/show_bug.cgi?id=56703 --- Comment #5 from Rainer Jung --- Hi Martin, your analysis helped me finding the likely real root cause and fix a few more places by adusting the connection counter decrement in ajp_abort_endpoint(). I applied the resulting fix in r1618000. Do you have any chance to test this? Would you need me to roll a dev (snapshot) tarball, or do you know how to build mod_jk from a svn checkout? The problem always is not to decrement to often such that the counter gets skewed to the other side. I think the fix I did now should be safe. Thanks again for finding the right root cause and for (hopefully) testing this fix. If testing goes well, this will e part of 1.2.41. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1618028 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
Author: markt Date: Thu Aug 14 19:40:28 2014 New Revision: 1618028 URL: http://svn.apache.org/r1618028 Log: Don't use exceptions for flow control - especially in the class loader. This would slow things down in the case of external repositories. Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java?rev=1618028&r1=1618027&r2=1618028&view=diff == --- tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java (original) +++ tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Thu Aug 14 19:40:28 2014 @@ -878,10 +878,6 @@ public class WebappClassLoader extends U log.trace(" findClassInternal(" + name + ")"); try { clazz = findClassInternal(name); -} catch(ClassNotFoundException cnfe) { -if (!hasExternalRepositories) { -throw cnfe; -} } catch(AccessControlException ace) { log.warn("WebappClassLoader.findClassInternal(" + name + ") security exception: " + ace.getMessage(), ace); @@ -2396,11 +2392,11 @@ public class WebappClassLoader extends U * * @return the loaded class, or null if the class isn't found */ -protected Class findClassInternal(String name) -throws ClassNotFoundException { +protected Class findClassInternal(String name) { -if (!validate(name)) -throw new ClassNotFoundException(name); +if (!validate(name)) { +return null; +} String path = binaryNameToPath(name, true); @@ -2414,8 +2410,9 @@ public class WebappClassLoader extends U entry = findResourceInternal(name, path); } -if (entry == null) -throw new ClassNotFoundException(name); +if (entry == null) { +return null; +} Class clazz = entry.loadedClass; if (clazz != null) @@ -2426,8 +2423,9 @@ public class WebappClassLoader extends U if (clazz != null) return clazz; -if (entry.binaryContent == null) -throw new ClassNotFoundException(name); +if (entry.binaryContent == null) { +return null; +} // Looking up the package String packageName = null; - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56838] Performance drop when repeatedly calling WebappClassLoader.loadClass for the same class
https://issues.apache.org/bugzilla/show_bug.cgi?id=56838 --- Comment #9 from Mark Thomas --- I've done some experiements with Jira 6.2.7 (the latest version I can get to work with Tomcat 8) and the results are pretty unspectacular. Caching the class loader doesn't help and probably makes performance a little worse. Caching the class appears to make no difference or if there is a difference it is well within the noise. I also took a good look at the rest of the class loader code and I don't see any places where big gains could be made. I saw a handful of minor improvements but none of them made a measurable difference. I am currently leaning to resolving this as WONTFIX again although alternative ideas for optimising the class loader are welcome. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56856] New: org.apache.catalina.ha.session.JvmRouteSessionIDBinderListener class not found exception
https://issues.apache.org/bugzilla/show_bug.cgi?id=56856 Bug ID: 56856 Summary: org.apache.catalina.ha.session.JvmRouteSessionIDBinder Listener class not found exception Product: Tomcat 8 Version: 8.0.9 Hardware: All OS: Linux Status: NEW Severity: blocker Priority: P2 Component: Cluster Assignee: dev@tomcat.apache.org Reporter: narayana...@gmail.com Hi i downloaded zip archive catalina-home/lib/catalina-ha.jar i extracted this jar but i dont see this class included as part of build class not found exception: org.apache.catalina.ha.session.JvmRouteSessionIDBinderListener -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56838] Performance drop when repeatedly calling WebappClassLoader.loadClass for the same class
https://issues.apache.org/bugzilla/show_bug.cgi?id=56838 --- Comment #10 from Konstantin Kolinko --- OK. Thank you for investigating. If it does not go into production, maybe you can attach a patch here -- for archiving purposes and in case there is another web application that is worth being tested? There exists bug 52448 with patch for Tomcat 6 that I wrote 2,5 years ago. I have not looked whether the idea there is applicable to Tomcat 8. (The idea is to cache JAR indexes to skip opening unneeded JARs). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56856] org.apache.catalina.ha.session.JvmRouteSessionIDBinderListener class not found exception
https://issues.apache.org/bugzilla/show_bug.cgi?id=56856 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Konstantin Kolinko --- As expected. The class has been removed starting with Tomcat 8.0.0, as mentioned both in Changelog and in Migration Guide http://tomcat.apache.org/migration-8.html#Clustering http://tomcat.apache.org/tomcat-8.0-doc/changelog.html#Tomcat_8.0.0_%28markt%29/Cluster -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56857] New: Thread safety issue in ApplicationContextFacade.invokeMethod
https://issues.apache.org/bugzilla/show_bug.cgi?id=56857 Bug ID: 56857 Summary: Thread safety issue in ApplicationContextFacade.invokeMethod Product: Tomcat 7 Version: 7.0.52 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: vkleinschm...@blackboard.com Multiple subsequent Thread dumps were exhibiting lots of threads hanging in HashMap.get() while in RUNNABLE status, and consuming high CPU - a typical indicator of a thread safety issue with these non-threadsafe Maps. Thread stacks all as below. ApplicationContextFacade implements ServletContext, these objects are singletons per webapp, and get passed around among multiple threads. Their private member "objectCache" is a HashMap, i.e. not thread safe, but gets accessed AND modified without any synchronization in invokeMethod(). Suggested remedy: change to a ConcurrentHashMap, which is thread-safe, and performs much better than synchronizing on every access. "connector-93: userId=_101_1, sessionId=C9EC1C59DD2244557BC6231A5476000E" daemon prio=10 tid=0x7fb1e40cf800 nid=0x7b90 runnable [0x7fb1e82c3000] java.lang.Thread.State: RUNNABLE at java.util.HashMap.get(HashMap.java:326) at org.apache.catalina.core.ApplicationContextFacade.invokeMethod(ApplicationContextFacade.java:789) at org.apache.catalina.core.ApplicationContextFacade.doPrivileged(ApplicationContextFacade.java:767) at org.apache.catalina.core.ApplicationContextFacade.getContextPath(ApplicationContextFacade.java:428) at blackboard.portal.servlet.ModuleCustomizationServlet.service(ModuleCustomizationServlet.java:88) at javax.servlet.http.HttpServlet.service(HttpServlet.java:728) ... -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56857] Thread safety issue in ApplicationContextFacade.invokeMethod
https://issues.apache.org/bugzilla/show_bug.cgi?id=56857 --- Comment #1 from Volker Kleinschmidt --- As is common with thread safety issues, I have no strict replication steps. Issue occurs sporadically, however this particular method call (getContextPath) seems to trigger it fairly often. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-234) Tomcat8 Maven Plugin
[ https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097917#comment-14097917 ] Olivier Lamy (*$^¨%`£) commented on MTOMCAT-234: [~kalgon] if you have time for pr I will like that for sure :-) > Tomcat8 Maven Plugin > > > Key: MTOMCAT-234 > URL: https://issues.apache.org/jira/browse/MTOMCAT-234 > Project: Apache Tomcat Maven Plugin > Issue Type: Dependency upgrade >Affects Versions: 2.0, 2.1, 2.2 > Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25 >Reporter: Petr Novak >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Blocker > Fix For: 3.0 > > > Please provide initial version of Tomcat8 Maven Plugin. > I tried the recommendations in > http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none > but the guideline > http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html > does not work for Tomcat8 . > The problem is in changed Tomcat 8 API, the maven throws folloving exception: > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142) > ... 20 more > by: java.lang.NoSuchMethodError: > org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106) > ... 20 more > The method setDefaultRealm is deprecated in Tomcat7 and was removed in > Tomcat8 as described in documentation: > http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm) -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat-maven-plugin pull request: MTOMCAT-234 Classloading issues
GitHub user kalgon opened a pull request: https://github.com/apache/tomcat-maven-plugin/pull/7 MTOMCAT-234 Classloading issues this fixes the `java.lang.ClassFormatError` but there is another problem: it seems that the `JarScanner` scans the tomcat-maven-plugin dependencies instead of the webapp ones. The result is that no `web-fragment.xml` or `ServletContainerInitializer` works anymore (and I suspect there should be other consequences as well). I did not have enough time to investigate but I noticed that, at line 202 in `StandardJarScanner`, a classloader is skipped (it wasn't so in Tomcat7)... but I don't know if this could be the cause as I don't know the internals of Tomcat very well. I'll try to make some time next week to dig a bit deeper. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kalgon/tomcat-maven-plugin tc8.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat-maven-plugin/pull/7.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7 commit 8e92cb72f9c2629116b54ca2c6cd4957b7ef6496 Author: kalgon Date: 2014-08-14T10:47:12Z MTOMCAT-234 Classloading issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-234) Tomcat8 Maven Plugin
[ https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097945#comment-14097945 ] ASF GitHub Bot commented on MTOMCAT-234: GitHub user kalgon opened a pull request: https://github.com/apache/tomcat-maven-plugin/pull/7 MTOMCAT-234 Classloading issues this fixes the `java.lang.ClassFormatError` but there is another problem: it seems that the `JarScanner` scans the tomcat-maven-plugin dependencies instead of the webapp ones. The result is that no `web-fragment.xml` or `ServletContainerInitializer` works anymore (and I suspect there should be other consequences as well). I did not have enough time to investigate but I noticed that, at line 202 in `StandardJarScanner`, a classloader is skipped (it wasn't so in Tomcat7)... but I don't know if this could be the cause as I don't know the internals of Tomcat very well. I'll try to make some time next week to dig a bit deeper. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kalgon/tomcat-maven-plugin tc8.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat-maven-plugin/pull/7.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7 commit 8e92cb72f9c2629116b54ca2c6cd4957b7ef6496 Author: kalgon Date: 2014-08-14T10:47:12Z MTOMCAT-234 Classloading issues > Tomcat8 Maven Plugin > > > Key: MTOMCAT-234 > URL: https://issues.apache.org/jira/browse/MTOMCAT-234 > Project: Apache Tomcat Maven Plugin > Issue Type: Dependency upgrade >Affects Versions: 2.0, 2.1, 2.2 > Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25 >Reporter: Petr Novak >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Blocker > Fix For: 3.0 > > > Please provide initial version of Tomcat8 Maven Plugin. > I tried the recommendations in > http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none > but the guideline > http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html > does not work for Tomcat8 . > The problem is in changed Tomcat 8 API, the maven throws folloving exception: > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142) > ... 20 more > by: java.lang.NoSuchMethodError: > org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106) > ... 20 more > The method setDefaultRealm is deprecated in Tomcat7 and was removed in > Tomcat8 as described in documentation: > http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm) -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1618085 - /tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java
Author: olamy Date: Fri Aug 15 00:11:47 2014 New Revision: 1618085 URL: http://svn.apache.org/r1618085 Log: MTOMCAT-234 Classloading issues Modified: tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java Modified: tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java?rev=1618085&r1=1618084&r2=1618085&view=diff == --- tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java (original) +++ tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java Fri Aug 15 00:11:47 2014 @@ -18,6 +18,22 @@ package org.apache.tomcat.maven.plugin.t * under the License. */ +import java.io.File; +import java.io.FileReader; +import java.io.FileWriter; +import java.io.IOException; +import java.io.InputStream; +import java.io.StringWriter; +import java.net.URI; +import java.net.URISyntaxException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import java.util.jar.JarEntry; +import java.util.jar.JarFile; + import org.apache.catalina.Context; import org.apache.catalina.WebResource; import org.apache.catalina.WebResourceSet; @@ -25,6 +41,7 @@ import org.apache.catalina.loader.Webapp import org.apache.catalina.webresources.EmptyResource; import org.apache.catalina.webresources.FileResource; import org.apache.catalina.webresources.FileResourceSet; +import org.apache.catalina.webresources.JarResource; import org.apache.commons.io.FileUtils; import org.apache.commons.lang.StringUtils; import org.apache.maven.artifact.Artifact; @@ -47,21 +64,6 @@ import org.codehaus.plexus.util.xml.Xpp3 import org.codehaus.plexus.util.xml.Xpp3DomWriter; import org.codehaus.plexus.util.xml.pull.XmlPullParserException; -import java.io.File; -import java.io.FileReader; -import java.io.FileWriter; -import java.io.IOException; -import java.io.InputStream; -import java.io.StringWriter; -import java.net.URI; -import java.net.URISyntaxException; -import java.util.ArrayList; -import java.util.Collections; -import java.util.HashSet; -import java.util.List; -import java.util.Set; -import java.util.jar.JarFile; - /** * Runs the current project as a dynamic web application using an embedded Tomcat server. * @@ -359,7 +361,7 @@ public class RunMojo return new FileResource( context.getResources(), getPath(), file, true ); } -if ( StringUtils.endsWith( path, ".class" ) ) +//if ( StringUtils.endsWith( path, ".class" ) ) { // so we search the class file in the jars for ( String jarPath : jarPaths ) @@ -373,10 +375,10 @@ public class RunMojo try { JarFile jarFile = new JarFile( jar ); - -if ( jarFile.getEntry( StringUtils.removeStart( path, "/" ) ) != null ) +JarEntry jarEntry = (JarEntry) jarFile.getEntry( StringUtils.removeStart( path, "/" ) ); +if ( jarEntry != null ) { -return new FileResource( context.getResources(), getPath(), jar, true ); +return new JarResource( context.getResources(), getPath(), jarFile.getName(), jar.toURI().toASCIIString(), jarEntry, path, jarFile.getManifest()); } } catch ( IOException e ) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-nio has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 10 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test-nio : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-nio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/logs-NIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-NIO/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-nio/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-nio.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-nio (Type: Build) Work ended in a state of : Failed Elapsed: 16 mins 41 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140815-native-src.tar.gz -Dtest.reports=output/logs-NIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140815-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140815.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar -Dexecute.test.nio=true -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/pub lic/workspace/commons-pool-1.x -Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x -Dexecute.test.apr=false -Dexecute.test.bio=false -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20140815.jar -Dtest.temp=output/test-tmp-NIO -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140815.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/t
[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-bio has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 10 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test-bio : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-bio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/logs-BIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-BIO/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-bio/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-bio.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-bio (Type: Build) Work ended in a state of : Failed Elapsed: 16 mins Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140815-native-src.tar.gz -Dtest.reports=output/logs-BIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140815-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140815.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar -Dexecute.test.nio=false -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/pu blic/workspace/commons-pool-1.x -Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x -Dexecute.test.apr=false -Dexecute.test.bio=true -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20140815.jar -Dtest.temp=output/test-tmp-BIO -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140815.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.
[GitHub] tomcat-maven-plugin pull request: MTOMCAT-234 Classloading issues
Github user kalgon closed the pull request at: https://github.com/apache/tomcat-maven-plugin/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-234) Tomcat8 Maven Plugin
[ https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098264#comment-14098264 ] ASF GitHub Bot commented on MTOMCAT-234: Github user kalgon closed the pull request at: https://github.com/apache/tomcat-maven-plugin/pull/7 > Tomcat8 Maven Plugin > > > Key: MTOMCAT-234 > URL: https://issues.apache.org/jira/browse/MTOMCAT-234 > Project: Apache Tomcat Maven Plugin > Issue Type: Dependency upgrade >Affects Versions: 2.0, 2.1, 2.2 > Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25 >Reporter: Petr Novak >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Blocker > Fix For: 3.0 > > > Please provide initial version of Tomcat8 Maven Plugin. > I tried the recommendations in > http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none > but the guideline > http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html > does not work for Tomcat8 . > The problem is in changed Tomcat 8 API, the maven throws folloving exception: > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142) > ... 20 more > by: java.lang.NoSuchMethodError: > org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106) > ... 20 more > The method setDefaultRealm is deprecated in Tomcat7 and was removed in > Tomcat8 as described in documentation: > http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm) -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org