Bug report for Tomcat 7 [2014/08/10]

2014-08-10 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|18500|New|Enh|2003-03-30|Host aliases to match by regular expression   |
|28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn  |
|40881|Opn|Enh|2006-11-02|Unable to receive message through  TCP channel -> |
|41007|Opn|Enh|2006-11-20|Can't define customized 503 error page|
|43866|New|Enh|2007-11-14|add support for session attribute propagation with|
|44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr|
|49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak|
|49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al|
|49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm|
|49821|New|Enh|2010-08-25|Tomcat CLI [PATCH/Contribution]   |
|50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou|
|50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply|
|50234|New|Enh|2010-11-08|JspC use servlet 3.0 features |
|50504|New|Enh|2010-12-21|Allow setting query string character set trough re|
|50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern|
|50944|Ver|Blk|2011-03-18|JSF: java.lang.NullPointerException at com.sun.fac|
|51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class|
|51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to |
|51463|New|Enh|2011-07-01|Tomcat.setBaseDir  (package org.apache.catalina.st|
|51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul|
|51587|New|Enh|2011-07-29|Implement status and uptime commands  |
|51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter [PATC|
|52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site|
|52381|New|Enh|2011-12-22|Please add OSGi metadata  |
|52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up|
|52489|New|Enh|2012-01-19|Enhancement request for code signing of war files |
|52688|New|Enh|2012-02-16|Add ability to remove old access log files [PATCHE|
|52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s|
|53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota|
|53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr|
|53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf|
|53492|New|Enh|2012-07-01|Make JspC shell multithreaded |
|53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from |
|53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l|
|54330|New|Enh|2012-12-19|Patch with some refactoring of Member.java [PATCH |
|54499|New|Enh|2013-01-29|Implementation of Extensible EL Interpreter   |
|54618|New|Enh|2013-02-28|Add filter implementing HTTP Strict Transport Secu|
|54802|New|Enh|2013-04-04|Provide location information for exceptions thrown|
|55104|New|Enh|2013-06-16|Allow passing arguments with spaces to Commons Dae|
|55470|New|Enh|2013-08-23|Help users for ClassNotFoundExceptions during star|
|55477|New|Enh|2013-08-23|Add a solution to map an realm name to a security |
|55662|New|Enh|2013-10-17|Add a way to set an instance of java.sql.Driver di|
|55943|Opn|Enh|2014-01-01|Provide a way prevent  looking at the System class|
|56148|New|Enh|2014-02-17|support (multiple) ocsp stapling  |
|56181|New|Enh|2014-02-23|RemoteIpValve & RemoteIpFilter: HttpServletRequest|
|56300|New|Enh|2014-03-22|[Tribes] No useful examples, lack of documentation|
|56438|New|Enh|2014-04-21|If jar scan does not find context config or TLD co|
|56614|New|Nor|2014-06-12|Add a switch to ignore annotations detection on ta|
|56739|New|Nor|2014-07-17|Error response body generated only occasionally   |
|56776|Inf|Nor|2014-07-28|java.security.AccessControlException in ClassLoade|
|56787|New|Enh|2014-07-29|Simplified jndi name parsing  |
|56825|

Bug report for Taglibs [2014/08/10]

2014-08-10 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field   |
|38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)|
|42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements   |
|46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l|
|48333|New|Enh|2009-12-02|TLD generator |
|55609|New|Enh|2013-09-28|c:forEach loop on integer range consumes unnecessa|
+-+---+---+--+--+
| Total6 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat Connectors [2014/08/10]

2014-08-10 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo|
|35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName|
|43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn|
|44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan|
|44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s|
|44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 |
|44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc|
|44571|New|Enh|2008-03-10|Limits busy per worker to a threshold |
|45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff|
|45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so|
|46337|New|Nor|2008-12-04|real worker name is wrong |
|46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca|
|47327|New|Enh|2009-06-07|remote_user not logged in apache logfile  |
|47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err|
|47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_|
|47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus|
|47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit|
|47840|Inf|Min|2009-09-14|A broken worker name is written in the log file.  |
|48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the|
|48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio|
|48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert|
|48513|New|Enh|2010-01-09|IIS Quick setup instructions  |
|48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker  |
|48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv|
|48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk |
|49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form|
|49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work|
|49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat |
|49469|New|Enh|2010-06-19|Workers status page has negative number of connect|
|49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. |
|49822|New|Enh|2010-08-25|Add hash lb worker method |
|49903|New|Enh|2010-09-09|Make workers file reloadable  |
|50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c|
|52334|New|Maj|2011-12-14|recover_time is not properly used |
|52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus|
|52651|New|Nor|2012-02-13|JKSHMFile size limitation |
|53883|New|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe  on the p|
|53977|New|Maj|2012-10-07|32bits isapi connector cannot work in wow64 mode  |
|54027|New|Cri|2012-10-18|isapi send request to outside address instead of i|
|54112|Opn|Blk|2012-11-07|ISAPI redirector not working when IIS recycles|
|54117|New|Maj|2012-11-08|access violation exception in isapi_redirect.dll  |
|54177|New|Nor|2012-11-20|jkmanager generates non-well-formed XML for certai|
|54596|New|Nor|2013-02-22|Relative path functionality truncates last charact|
|54621|New|Nor|2013-02-28|[PATCH] custom mod_jk availability checks |
|54646|New|Trv|2013-03-06|socket_keepalive is sometimes 1 or true or True in|
|54923|New|Nor|2013-05-03|nsapi_redirect.so does not work with iPlanet on So|
|56005|New|Nor|2014-01-14|ISAPI redirector WEB-INF/META-INF Path Check false|
|56452|New|Nor|2014-04-24|IPv6 address and log level debug caused crash |
|56489|New|Enh|2014-05-05|Include a directory for configuration files   |
|56576|New|Enh|2014-05-29|Websocket support |
|56618|New|Nor|2014-06-13|Can not set Hostname property to IPv6 address usin|
|56703|

Bug report for Tomcat 6 [2014/08/10]

2014-08-10 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat|
|43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant|
|43400|New|Enh|2007-09-14|enum support for tag libs |
|43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml   |
|43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor|
|43742|New|Enh|2007-10-30|.tag compiles  performed one at a time -- extremel|
|43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output |
|44199|New|Enh|2008-01-10|expose current backlog queue size |
|44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f|
|44294|New|Enh|2008-01-25|Support for EL functions with varargs |
|44312|Opn|Enh|2008-01-28|Warn when overwritting docBase of the default Host|
|44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam|
|44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt|
|45014|New|Enh|2008-05-15|Request and Response classes should have wrappers |
|45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets|
|45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks|
|45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or |
|45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE|
|45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output|
|46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c|
|46263|Opn|Enh|2008-11-21|Tomcat reloading of context.xml does not update do|
|46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl|
|46350|New|Enh|2008-12-05|Maven repository should contain source bundles|
|46558|Opn|Enh|2009-01-19|Shutdown port with address binding|
|46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch|
|47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho|
|47242|New|Enh|2009-05-22|request for AJP command line client   |
|47281|New|Enh|2009-05-28|Efficiency of the JDBCStore   |
|47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session|
|47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath|
|47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked|
|47919|New|Enh|2009-09-30|Log Tomcat & Java environment variables in additio|
|48358|Opn|Enh|2009-12-09|JSP-unloading reloaded|
|48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.|
|48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b|
|48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe|
|48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr|
|48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems|
|48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static|
|48928|New|Enh|2010-03-17|An alternative solution to preloading classes when|
|49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient  |
|49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding  |
|49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/|
|49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu|
|49939|New|Enh|2010-09-16|Expose a method via JMX which empties the webapp f|
|49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c|
|50285|New|Enh|2010-11-17|Standard HTTP and AJP connectors silently ignore a|
|50288|New|Enh|2010-11-17|Uploading a war file that already exists should au|
|50677|Opn|Enh|2011-01-27|Allow system property variables in catalina.proper|
|50692|New|Enh|2011-01-31|Improve log message in ThreadPool.logFull |
|51142|New|Enh|2011-05-03|Offer possible resolution of StringIndexOutOfBound|
|51513|

Bug report for Tomcat 8 [2014/08/10]

2014-08-10 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing |
|51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs|
|53737|Opn|Enh|2012-08-18|Use ServletContext.getJspConfigDescriptor() in Jas|
|53930|New|Enh|2012-09-24|allow capture of catalina stdout/stderr to a comma|
|54503|New|Enh|2013-01-29|SAML2 based single sign on|
|54700|New|Enh|2013-03-15|Improvement: Add support for system property to sp|
|54741|New|Enh|2013-03-22|Add org.apache.catalina.startup.Tomcat#addWebapp(S|
|55006|New|Enh|2013-05-22|Add http proxy support for ClientEndpoint using sy|
|55243|New|Enh|2013-07-11|Add special search string for nested roles|
|55252|New|Enh|2013-07-12|Separate Ant and command-line wrappers for JspC   |
|55383|New|Enh|2013-08-07|Improve markup and design of Tomcat's HTML pages  |
|55479|New|Enh|2013-08-24|JSR 196 (JASPIC) support in Tomcat|
|9|New|Enh|2013-09-14|UserDatabaseRealm enhacement: may use local JNDI  |
|55675|New|Enh|2013-10-18|Checking and handling invalid configuration option|
|55770|New|Enh|2013-11-12|Allow the crlFile to be reloaded  |
|55788|New|Enh|2013-11-16|TagPlugins should key on tag QName rather than imp|
|55884|Ver|Maj|2013-12-14|JSPs no longer compile in Java 8  |
|55917|New|Nor|2013-12-20|Cookie parsing fails hard with ISO-8859-1 values  |
|55918|New|Nor|2013-12-21|CTL characters may appear in quoted values for RFC|
|55920|New|Enh|2013-12-22|Quotes should not be removed from quoted cookie va|
|55921|New|Nor|2013-12-22|Cookie values in JSON format are not skipped corre|
|55951|New|Enh|2014-01-04|HTML5 specifies UTF-8 encoding for cookie values  |
|55969|New|Enh|2014-01-07|Security-related enhancements to the Windows Insta|
|55984|New|Nor|2014-01-10|Invalid V1 cookie generated if value contains sepa|
|55988|New|Enh|2014-01-11|Add parameter useCipherSuitesOrder to JSSE (BIO an|
|56079|New|Enh|2014-01-28|Digitally sign the Windows binaries   |
|56166|New|Enh|2014-02-20|Suggestions for exception handling (avoid potentia|
|56323|New|Enh|2014-03-27|Include service .bat scripts with Microsoft Window|
|56361|New|Enh|2014-04-08|org.apache.tomcat.websocket.WsWebSocketContainer#b|
|56393|New|Enh|2014-04-11|Implement RFC6265 for Cookie parsing  |
|56394|New|Enh|2014-04-11|Allow cookie-parsing to be pluggable  |
|56397|New|Enh|2014-04-11|Establish parallel Maven-based build process  |
|56398|New|Enh|2014-04-11|Support Arquillian-based unit testing |
|56399|New|Enh|2014-04-11|Re-factor request/response recycling so Coyote and|
|56401|New|Enh|2014-04-11|Log version information on startup|
|56402|New|Enh|2014-04-11|Add support for HTTP Upgrade to AJP components|
|56403|New|Enh|2014-04-11|Support pluggable password-derivation in Realms   |
|56448|New|Enh|2014-04-23|Implement a robust solution for client initiated S|
|56530|New|Enh|2014-05-15|WebappClassLoader.loadClass synchronization issue |
|56546|New|Enh|2014-05-19|Improve thread trace logging in WebappClassLoader.|
|56551|New|Enh|2014-05-21|Increase timeouts in CometChat example|
|56650|New|Enh|2014-06-20|Websockets session replication support|
|56676|New|Enh|2014-06-26|Normalize access to native library|
|56713|New|Enh|2014-07-12|Limit time that incoming request waits while webap|
|56724|New|Enh|2014-07-15|Restart Container background thread if it died une|
|56777|New|Enh|2014-07-28|Allow configuration resources to be loaded from pl|
+-+---+---+--+--+
| Total   46 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: d

Bug report for Tomcat Native [2014/08/10]

2014-08-10 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown|
|49038|Inf|Nor|2010-04-02|Crash in tcnative |
|52319|Inf|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da]  sig|
|52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i|
|53605|Inf|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash   |
|53847|Inf|Nor|2012-09-10|High CPU usage in tomcat native 1.22+ |
|53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration|
|53952|New|Nor|2012-10-02|Add support for TLS 1.1 and 1.2   |
|54085|New|Nor|2012-11-01|ssl_socket_recv sometimes loops infinitely with no|
|54664|New|Reg|2013-03-11|[1.1.27 branch] Poll.remove incorrectly reports AP|
|55087|New|Cri|2013-06-10|tomcat crashes in tcnative-1.dll with OCSP when OC|
|55113|Inf|Nor|2013-06-18|FIPS-compatible OpenSSL fails fingerprint test in |
|55114|New|Nor|2013-06-18|BUILDING file in win32 source package contains UNI|
|55706|New|Nor|2013-10-25|broken apr version check in native v1.1.29 build; |
|55771|New|Maj|2013-11-12|Memory leak and then crash in org.apache.tomcat.jn|
|55797|Inf|Nor|2013-11-19|Tomcat 7.0.47 crashes using server jvm.dll and APR|
|55938|New|Nor|2013-12-29|clang-analyzer report for 1.1.31  |
|56027|Opn|Nor|2014-01-17|Unable to use TCN on RHEL6 boxes if box is booted |
|56108|New|Nor|2014-02-04|Allow user-defined Diffie-Hellman parameters  |
|56313|New|Maj|2014-03-25|Tomcat 8 crashes in tcnative-1.dll+0x7923 |
|56378|New|Nor|2014-04-09|Cert load fails if cert is located in path with no|
|56415|New|Maj|2014-04-16|EXCEPTION_ACCESS_VIOLATION (0xc005) in tcnativ|
+-+---+---+--+--+
| Total   22 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat Modules [2014/08/10]

2014-08-10 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers |
|48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite  |
|48861|New|Nor|2010-03-04|Files without AL headers  |
|49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean   |
|49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da|
|50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen|
|51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho|
|51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods   |
|52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o|
|53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe|
|54437|New|Enh|2013-01-16|Update PoolProperties javadoc for ConnectState int|
|54929|Inf|Nor|2013-05-05|jdbc-pool cannot be used with Java 1.5, "java.lang|
|55078|New|Nor|2013-06-07|Configuring a DataSource Resource with dataSourceJ|
|56046|New|Enh|2014-01-21|org.apache.tomcat.jdbc.pool.XADataSource InitSQL p|
|56088|New|Maj|2014-01-29|AbstractQueryReport$StatementProxy throws exceptio|
|56310|Inf|Maj|2014-03-25|PooledConnection and XAConnection not handled corr|
|56586|New|Nor|2014-06-02|initSQL should be committed if defaultAutoCommit =|
|56660|New|Maj|2014-06-23|Resource leak in FairBlockingQueue::poll method   |
|56765|New|Cri|2014-07-23|Classloader leak in Tomcat 8.0.9 caused by DBCP 2.|
|56775|New|Nor|2014-07-28|PoolCleanerTime schedule issue|
|56779|New|Nor|2014-07-28|Allow multiple connection initialization statement|
|56790|New|Nor|2014-07-29|Resizing pool.maxActive to a higher value at runti|
|56798|New|Nor|2014-07-31|Idle eviction strategy could perform better (and i|
|56804|New|Nor|2014-08-02|Use a default validationQueryTimeout other than "f|
|56805|New|Nor|2014-08-02|datasource.getConnection() may be unnecessarily bl|
+-+---+---+--+--+
| Total   25 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56833] New: ClassNotFoundException in org.apache.catalina.loader.WebappClassLoader.loadClass when depersist session

2014-08-10 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56833

Bug ID: 56833
   Summary: ClassNotFoundException in
org.apache.catalina.loader.WebappClassLoader.loadClass
when depersist session
   Product: Tomcat 6
   Version: 6.0.35
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: thomas...@hotmail.com

FileStore for persist session.

java.lang.ClassNotFoundException:
my class
at
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1645)
at
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1491)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:247)
at
org.apache.catalina.util.CustomObjectInputStream.resolveClass(CustomObjectInputStream.java:75)
at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1574)
at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1495)
at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1731)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1328)
at java.io.ObjectInputStream.readObject(ObjectInputStream.java:350)
at
org.apache.catalina.session.StandardSession.readObject(StandardSession.java:1475)
at
org.apache.catalina.session.StandardSession.readObjectData(StandardSession.java:977)
at org.apache.catalina.session.FileStore.load(FileStore.java:296)
at org.apache.catalina.session.StoreBase.processExpires(StoreBase.java:195)
at
org.apache.catalina.session.PersistentManagerBase.processExpires(PersistentManagerBase.java:563)
at
org.apache.catalina.session.ManagerBase.backgroundProcess(ManagerBase.java:685)
at
org.apache.catalina.core.ContainerBase.backgroundProcess(ContainerBase.java:1316)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1601)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1610)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1610)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.run(ContainerBase.java:1590)
at java.lang.Thread.run(Thread.java:662)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56833] ClassNotFoundException in org.apache.catalina.loader.WebappClassLoader.loadClass when depersist session

2014-08-10 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56833

Thomas.LIU  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 OS||All

--- Comment #1 from Thomas.LIU  ---
move context.xml to application META-INF. all good now.

http://tomcat.apache.org/tomcat-6.0-doc/jndi-resources-howto.html#context.xml_configuration

context.xml configuration

If Tomcat is unable to identify the appropriate resource factory and/or
additional configuration information is required, additional Tomcat specific
configuration must be specified before Tomcat can create the resource. Tomcat
specific resource configuration is entered in the  elements that can
be specified in either $CATALINA_BASE/conf/server.xml or, preferably, the
per-web-application context XML file (META-INF/context.xml).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Eclipse JAR dependency

2014-08-10 Thread Konstantin Kolinko 
2014-08-08 21:12 GMT+04:00 Mark Thomas :
> All,
>
> I've been chatting on and off over the last few weeks with some folks at
> $work that make extensive use of Tomcat embedded and for whom any issues
> with the JAR references in the Maven POM (such as [1]) are a real pain.
>
> The root cause of the issue is that the small (~2MB) Eclipse compiler
> (JDT) JAR we use is not officially released to Maven Central by Eclipse.
> One or more volunteers upload the JAR and it typically appears 2-4 weeks
> after the Eclipse release.
>
> There is a larger JAR (5.3MB) with contains the same functionality that
> is officially uploaded by Eclipse. It usually appears in Maven Central
> sooner that the smaller JAR.
>
> Having discussed the pros and cons of various options I would like to
> propose the following approach to be used when updating our dependency
> on JDT.
>
> 1. Tomcat releases will always package the 'small' JDT JAR as they do
>today.
>
> 2. The POMs that we use when we upload a release to Maven Central will
>always include references to valid JARs that are known to already
>exist in Maven central.
>
> 3. We will not normally update Tomcat's dependency on JDT until the
>'small' JAR is available in Maven Central.
>
> 4. If we need to update the JDT dependency before the 'small' JAR is
>available in Maven central (e.g. security issue, access new features
>such as Java 9 support for testing etc.) then we will use the
>following fallback options for the POM references:
>- if the 'small' JDT JAR is not available, use the 'large' one
>- if neither the 'small' nor the 'large' JDT JARs are available
>  continue to reference the pre-upadte version of the 'small' JDT
>  JAR
>
> 5. The changelog should make clear which dependencies have been updated
>and which have not.
>
> 6. The tomcat-embedded-jasper.pom will continue to reference the
>'small' Eclipse JAR as a non-optional dependency by default.
>
> I'll add this to a wiki page so we can reference it in the
> build.properties.default file etc. Obviously this is only a proposal at
> this stage. Feedback, questions alternative approaches etc. welcome.
>
> Mark
>
> [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=50604
>

https://wiki.apache.org/tomcat/JDTCoreBatchCompiler

I am +1 for 1-2, 5 above, they are good.
I am +1 for 4. and 6, but I do not have much knowledge/practice in those areas.

I disagree (-0, not a stopper) with 3., as this procedure lacks
explicit step that triggers upload of "small" jar.

Currently the incentive for the upload is our having started to use
the new version. There is no incentive other than that, as I think no
other project besides us uses the jar.

Essentially we have to announce that we want to update the dependency
and wait for a volunteer to notice the announcement.


I think that the incentive for the existence of "big" jar is that
tycho provides access to use Eclipse Compiler with Maven. E.g.
mentioned in [2][3].

[2] 
http://wiki.eclipse.org/Tycho/FAQ#Can_I_use_the_Tycho_compiler_support_in_non-OSGi_projects.2C_too.3F
[3] http://eclipse.org/tycho/sitedocs/tycho-compiler-plugin/plugin-info.html


Looking at "big" jar org.eclipse.jdt.core-3.10.0.v20140604-1726.jar I
have several comments.
1). The "big" jar is identical to the one distributed with Eclipse
IDE. It is a plugin, a jar placed into "plugins" directory. There is
insignificant naming difference, as the file in Eclipse uses "_" to
separate version from name, while Maven one uses "-".

2). The "small" jar is a separate product, "JDT Core Batch Compiler"
(as downloadable from Eclipse download pages). It slightly differs in
packaging: it provides Main class in its MANIFEST.MF  and declares
implementation of javax.tools.JavaCompiler service with a
META-INF/services file.

As we do not use javax.tools.JavaCompiler API (available since Java 6
[4][5]) and are using the classes directly, we are OK with using the
"big" jar.

3). As the file names differ, the "org.eclipse.jdt.core" file is
currently not covered by default value of jarsToSkip masks specified
in catalina.properties. I think we have to add a mask for that file
name.


[4] 
http://docs.oracle.com/javase/7/docs/api/javax/tools/package-summary.html#package_description
[5] http://docs.oracle.com/javase/7/docs/api/javax/tools/JavaCompiler.html


I think that the procedure is
1) update build.properties.default and IDE project files
2) post a heads-up notice on dev/users and wait a few days
3) update POM (using the fallback options)

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1617115 - /tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

2014-08-10 Thread kkolinko 
Author: kkolinko
Date: Sun Aug 10 15:02:03 2014
New Revision: 1617115

URL: http://svn.apache.org/r1617115
Log:
Documentation followup to r1616584
- s/try/true/
- explain what "current classloader" is
- format values with 

Modified:
tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=1617115&r1=1617114&r2=1617115&view=diff
==
--- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Sun Aug 10 15:02:03 2014
@@ -176,12 +176,15 @@
 
   
 (boolean) Controls classloading of dynamic classes, such as
-   jdbc drivers, interceptors and validators. If set to false, default 
value,
-   the pool will first attempt to load using the current loader and if 
class loading fails
-   attempt to load using the thread context loader.
-   Set this value to try, if you wish to remain backwards compatible,
-   Apache Tomcat 8.0.8 and earlier, and only attempt the current 
loader.
-   If not set then the default value is false.)
+   JDBC drivers, interceptors and validators. If set to
+   false, default value, the pool will first attempt
+   to load using the current loader (i.e. the class loader that
+   loaded the pool classes) and if class loading fails attempt to
+   load using the thread context loader. Set this value to
+   true, if you wish to remain backwards compatible
+   with Apache Tomcat 8.0.8 and earlier, and only attempt the
+   current loader.
+   If not set then the default value is false.
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1616584 - in /tomcat/trunk/modules/jdbc-pool: doc/ src/main/java/org/apache/tomcat/jdbc/naming/ src/main/java/org/apache/tomcat/jdbc/pool/

2014-08-10 Thread Konstantin Kolinko 
2014-08-08 0:15 GMT+04:00  :
> Author: fhanik
> Date: Thu Aug  7 20:15:19 2014
> New Revision: 1616584
>
> URL: http://svn.apache.org/r1616584
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53853
> Dynamic class loading of driver, validator and interceptors can be done from 
> libraries on the context class loader. Behavior is partly backwards 
> compatible, always try the current loader first, but then attempts the 
> current thread's context class loader
>
> Added:
> 
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
>(with props)
> Modified:
> tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
> 
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java
> 
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
> 
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
>
> Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=1616584&r1=1616583&r2=1616584&view=diff
> ==
> --- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
> +++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Thu Aug  7 20:15:19 2014
> @@ -170,6 +170,22 @@
>
>  
>
> +
> +  
> +System properties are JVM wide, affect all pools created in the 
> JVM
> +
> +   name="org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader" 
> required="false">
> +(boolean) Controls classloading of dynamic classes, such as
> +   jdbc drivers, interceptors and validators. If set to false, 
> default value,
> +   the pool will first attempt to load using the current loader and 
> if class loading fails
> +   attempt to load using the thread context loader.
> +   Set this value to try, if you wish to remain backwards compatible,

I have already fixed the typos here.

> +   Apache Tomcat 8.0.8 and earlier, and only attempt the current 
> loader.
> +   If not set then the default value is false.)
> +
> +  
> +
> +  
>

(...)


> Modified: 
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java?rev=1616584&r1=1616583&r2=1616584&view=diff
> ==
> --- 
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
>  (original)
> +++ 
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
>  Thu Aug  7 20:15:19 2014
> @@ -767,7 +767,11 @@ public class PoolProperties implements P
>
>  try {
>  @SuppressWarnings("unchecked")
> -Class validatorClass = 
> (Class)Class.forName(className);
> +Class validatorClass = 
> (Class)ClassLoaderUtil.loadClass(
> +className,
> +PoolProperties.class.getClassLoader(),

OK.

> +Thread.currentThread().getContextClassLoader()
> +);
>  validator = validatorClass.newInstance();
>  } catch (ClassNotFoundException e) {
>  log.warn("The class "+className+" cannot be found.", e);
> @@ -957,12 +961,20 @@ public class PoolProperties implements P
>  if (log.isDebugEnabled()) {
>  log.debug("Loading interceptor 
> class:"+PoolConfiguration.PKG_PREFIX+getClassName());
>  }
> -clazz = 
> Class.forName(PoolConfiguration.PKG_PREFIX+getClassName(), true, 
> this.getClass().getClassLoader());
> +clazz = ClassLoaderUtil.loadClass(
> +PoolConfiguration.PKG_PREFIX+getClassName(),
> +this.getClass().getClassLoader(),

It shall be "PoolProperties.class.getClassLoader()," as well here like
above. Otherwise the new code is not equivalent to the old one.

> +Thread.currentThread().getContextClassLoader()
> +);
>  } else {
>  if (log.isDebugEnabled()) {
>  log.debug("Loading interceptor 
> class:"+getClassName());
>  }
> -clazz = Class.forName(getClassName(), true, 
> this.getClass().getClassLoader());
> +clazz = ClassLoaderUtil.loadClass(
> +getClassName(),
> +this.getClass().getClassLoader(),
> +Thread.currentThread().getContextClassLoader()
> +);
>  }
>  }
>  return (Class)cla

svn commit: r1617165 - in /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool: ClassLoaderUtil.java PoolProperties.java

2014-08-10 Thread kkolinko 
Author: kkolinko
Date: Sun Aug 10 21:23:57 2014
New Revision: 1617165

URL: http://svn.apache.org/r1617165
Log:
Review of r1616584
- Explicitly reference the classloader of PoolProperties class, to keep the old 
behaviour of Class.forName.
It matters in unlikely theoretical case if PoolProperties$InterceptorDefinition 
class is being extended (subclassed).
- s/StringBuffer/StringBuilder/

Modified:

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java?rev=1617165&r1=1617164&r2=1617165&view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
 Sun Aug 10 21:23:57 2014
@@ -28,7 +28,7 @@ public class ClassLoaderUtil {
 
 public static Class loadClass(String className, ClassLoader... 
classLoaders) throws ClassNotFoundException {
 ClassNotFoundException last = null;
-StringBuffer errorMsg = null;
+StringBuilder errorMsg = null;
 for (ClassLoader cl : classLoaders) {
 try {
 if (cl!=null) {
@@ -42,9 +42,9 @@ public class ClassLoaderUtil {
 } catch (ClassNotFoundException x) {
 last = x;
 if (errorMsg==null) {
-errorMsg = new StringBuffer();
+errorMsg = new StringBuilder();
 } else {
-errorMsg.append(";");
+errorMsg.append(';');
 }
 errorMsg.append("ClassLoader:");
 errorMsg.append(cl);
@@ -53,7 +53,7 @@ public class ClassLoaderUtil {
 break;
 }
 }
-throw new ClassNotFoundException("Unable to load class:"+className+" 
from "+errorMsg, last);
+throw new ClassNotFoundException("Unable to load class: "+className+" 
from "+errorMsg, last);
 }
 
 

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java?rev=1617165&r1=1617164&r2=1617165&view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
 Sun Aug 10 21:23:57 2014
@@ -963,7 +963,7 @@ public class PoolProperties implements P
 }
 clazz = ClassLoaderUtil.loadClass(
 PoolConfiguration.PKG_PREFIX+getClassName(),
-this.getClass().getClassLoader(),
+PoolProperties.class.getClassLoader(),
 Thread.currentThread().getContextClassLoader()
 );
 } else {
@@ -972,7 +972,7 @@ public class PoolProperties implements P
 }
 clazz = ClassLoaderUtil.loadClass(
 getClassName(),
-this.getClass().getClassLoader(),
+PoolProperties.class.getClassLoader(),
 Thread.currentThread().getContextClassLoader()
 );
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53853] Can tomcat-jdbc consider Thread#getContextClassLoader() for interceptors & JDBC drivers please?

2014-08-10 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=53853

--- Comment #4 from Konstantin Kolinko  ---
(In reply to Filip Hanik from comment #2)
> Fixed in r1616584

With minor follow-ups in r1617115 and r1617165.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1616789 - /tomcat/trunk/modules/jdbc-pool/doc/changelog.xml

2014-08-10 Thread Konstantin Kolinko 
2014-08-08 18:53 GMT+04:00  :
> Author: fhanik
> Date: Fri Aug  8 14:53:06 2014
> New Revision: 1616789
>
> URL: http://svn.apache.org/r1616789
> Log:
> Update changelog with recent fixes
>
> Modified:
> tomcat/trunk/modules/jdbc-pool/doc/changelog.xml
>
> Modified: tomcat/trunk/modules/jdbc-pool/doc/changelog.xml
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/changelog.xml?rev=1616789&r1=1616788&r2=1616789&view=diff
> ==
> --- tomcat/trunk/modules/jdbc-pool/doc/changelog.xml (original)
> +++ tomcat/trunk/modules/jdbc-pool/doc/changelog.xml Fri Aug  8 14:53:06 2014
> @@ -28,6 +28,25 @@
>
>
>  
> +
> +

1. The version number is wrong. The next version is 8.0.11.

(8.0.10 was tagged a month ago and failed the vote).

2. This changelog file is not built and is not included with Tomcat releases.
Is it really needed here?

In Tomcat 7 we used subsection name "jdbc-pool" to list Tomcat-JDBC
pool changes. I think we should do the same for Tomcat 8.

(There have not been any such changes in 8.0.0-8.0.10, so it is the
first time when this section will be used in Tomcat 8).

Best regards,
Konstantin Kolinko

> +  
> +
> +  1616760 54227 Evaluate max age upon borrow 
> (fhanik)
> +  1616644 56318 Ability to trace statement 
> creation in StatementFinalizer (fhanik)
> +  1616639 53088 More identifiable thread name 
> (fhanik)
> +  1616629 56789 getPool() returns the actual 
> pool, always (fhanik)
> +  1616625 54978 Make sure proper connection 
> validation always happens, regardless of config (fhanik)
> +  1616602 54537 Performance improvement in 
> StatementFinalizer (fhanik)
> +  1616599 54395 Fix JDBC interceptor parsing 
> bug (fhanik)
> +  1616595 54235 Disallow nested pools 
> exploitating using data source (fhanik)
> +  1616592 54225 Disallow empty init SQL 
> (fhanik)
> +  1616584 53853 More flexible classloading 
> (fhanik)
> +  1616570 53200 Selective logging for slow 
> versus failed queries (fhanik)
> +
> +  
> +
> +
>  
>
>  
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1617178 - /tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

2014-08-10 Thread kkolinko 
Author: kkolinko
Date: Sun Aug 10 23:20:24 2014
New Revision: 1617178

URL: http://svn.apache.org/r1617178
Log:
Followup to r1616570
Correct a copy-paste. Fix missing trailing stop in sentences.

Modified:
tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=1617178&r1=1617177&r2=1617178&view=diff
==
--- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Sun Aug 10 23:20:24 2014
@@ -680,17 +680,17 @@
 
   
   
-(int as String) The maximum number of queries to keep track of in 
order to preserve memory space
+(int as String) The maximum number of queries to keep track of in 
order to preserve memory space.
The default value is 1000.
 
   
   
-(boolean as String) Set to true if you wish to log slow queries
+(boolean as String) Set to true if you wish to log 
slow queries.
 The default value is true.
 
   
   
-(boolean as String) Set to true if you wish to log slow queries
+(boolean as String) Set to true if you wish to log 
failed queries.
 The default value is true.
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1617179 - /tomcat/tc7.0.x/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

2014-08-10 Thread kkolinko 
Author: kkolinko
Date: Sun Aug 10 23:21:43 2014
New Revision: 1617179

URL: http://svn.apache.org/r1617179
Log:
Fix missing trailing stop in a sentence.

Modified:
tomcat/tc7.0.x/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

Modified: tomcat/tc7.0.x/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=1617179&r1=1617178&r2=1617179&view=diff
==
--- tomcat/tc7.0.x/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
+++ tomcat/tc7.0.x/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Sun Aug 10 
23:21:43 2014
@@ -654,7 +654,7 @@
 
   
   
-(int as String) The maximum number of queries to keep track of in 
order to preserve memory space
+(int as String) The maximum number of queries to keep track of in 
order to preserve memory space.
The default value is 1000.
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1616644 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java

2014-08-10 Thread Konstantin Kolinko 
2014-08-08 4:04 GMT+04:00  :
> Author: fhanik
> Date: Fri Aug  8 00:04:51 2014
> New Revision: 1616644
>
> URL: http://svn.apache.org/r1616644
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56318
> Contribution by Danila Galimov
> Ability to log statement creation stacks
>
> Modified:
> tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
> 
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
>
> Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=1616644&r1=1616643&r2=1616644&view=diff
> ==
> --- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
> +++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Fri Aug  8 00:04:51 2014
> @@ -608,6 +608,13 @@
> and closes these statements when the connection is returned to the 
> pool.
>  
>  
> +  
> +(boolean as String) Enable tracing of unclosed statements.
> +   When enabled and a connection is closed, and statements are not 
> closed,
> +   the interceptor will log all stack traces.
> +   The default value is false.
> +
> +  
>  
>
>
>
> Modified: 
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java?rev=1616644&r1=1616643&r2=1616644&view=diff
> ==
> --- 
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
>  (original)
> +++ 
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
>  Fri Aug  8 00:04:51 2014
> @@ -19,6 +19,7 @@ package org.apache.tomcat.jdbc.pool.inte
>  import org.apache.juli.logging.Log;
>  import org.apache.juli.logging.LogFactory;
>  import org.apache.tomcat.jdbc.pool.ConnectionPool;
> +import org.apache.tomcat.jdbc.pool.PoolProperties;
>  import org.apache.tomcat.jdbc.pool.PooledConnection;
>
>  import java.lang.ref.WeakReference;
> @@ -26,6 +27,8 @@ import java.lang.reflect.Method;
>  import java.sql.Statement;
>  import java.util.LinkedList;
>  import java.util.List;
> +import java.util.Map;
> +
>  /**
>   * Keeps track of statements associated with a connection and invokes close 
> upon {@link java.sql.Connection#close()}
>   * Useful for applications that dont close the associated statements after 
> being done with a connection.
> @@ -34,13 +37,15 @@ import java.util.List;
>  public class StatementFinalizer extends AbstractCreateStatementInterceptor {
>  private static final Log log = 
> LogFactory.getLog(StatementFinalizer.class);
>
> -protected List> statements = new LinkedList<>();
> -
> +protected List> statements = new 
> LinkedList<>();


1. This approach is broken.

Essentially this change breaks StatementFinalizer.

A weak reference to a Statement is OK, because there are hard
references to that statement object elsewhere.

A weak reference to a StatementEntry class is not OK,  because it is
the only reference to it. It is immediately eligible to be
garbage-collected.


> +
> +private boolean logCreationStack = false;
> +
>  @Override
>  public Object createStatement(Object proxy, Method method, Object[] 
> args, Object statement, long time) {
>  try {
>  if (statement instanceof Statement)
> -statements.add(new WeakReference<>((Statement)statement));
> +statements.add(new WeakReference<>(new 
> StatementEntry((Statement)statement)));
>  }catch (ClassCastException x) {
>  //ignore this one
>  }
> @@ -50,25 +55,58 @@ public class StatementFinalizer extends
>  @Override
>  public void closeInvoked() {
>  while (statements.size()>0) {
> -WeakReference ws = statements.remove(0);
> -Statement st = ws.get();
> +WeakReference ws = statements.remove(0);
> +StatementEntry st = ws.get();
>  if (st!=null) {
>  try {
> -st.close();
> +st.getStatement().close();
>  } catch (Exception ignore) {
>  if (log.isDebugEnabled()) {
>  log.debug("Unable to closed statement upon 
> connection close.",ignore);
>  }
>  }
> +if (logCreationStack) {
> +log.warn("Statement created, but was not closed at:", 
> st.getAllocationStack());
> +}
>  }
>  }
>  }
>
>  @Override
> +public void setProperties(Map PoolProperties.Intercep

buildbot success in ASF Buildbot on tomcat-7-trunk

2014-08-10 Thread buildbot 
The Buildbot has detected a restored build on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/206

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1617179
Blamelist: kkolinko

Build succeeded!

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1616584 - in /tomcat/trunk/modules/jdbc-pool: doc/ src/main/java/org/apache/tomcat/jdbc/naming/ src/main/java/org/apache/tomcat/jdbc/pool/

2014-08-10 Thread Filip Hanik 
all looks good


On Sun, Aug 10, 2014 at 9:04 AM, Konstantin Kolinko 
wrote:

> 2014-08-08 0:15 GMT+04:00  :
> > Author: fhanik
> > Date: Thu Aug  7 20:15:19 2014
> > New Revision: 1616584
> >
> > URL: http://svn.apache.org/r1616584
> > Log:
> > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53853
> > Dynamic class loading of driver, validator and interceptors can be done
> from libraries on the context class loader. Behavior is partly backwards
> compatible, always try the current loader first, but then attempts the
> current thread's context class loader
> >
> > Added:
> >
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
>   (with props)
> > Modified:
> > tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
> >
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java
> >
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
> >
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
> >
> > Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
> > URL:
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=1616584&r1=1616583&r2=1616584&view=diff
> >
> ==
> > --- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
> > +++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Thu Aug  7 20:15:19
> 2014
> > @@ -170,6 +170,22 @@
> >
> >  
> >
> > +
> > +  
> > +System properties are JVM wide, affect all pools created in the
> JVM
> > +
> > +   name="org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader"
> required="false">
> > +(boolean) Controls classloading of dynamic classes, such as
> > +   jdbc drivers, interceptors and validators. If set to false,
> default value,
> > +   the pool will first attempt to load using the current loader
> and if class loading fails
> > +   attempt to load using the thread context loader.
> > +   Set this value to try, if you wish to remain backwards
> compatible,
>
> I have already fixed the typos here.
>
> > +   Apache Tomcat 8.0.8 and earlier, and only attempt the
> current loader.
> > +   If not set then the default value is false.)
> > +
> > +  
> > +
> > +  
> >
>
> (...)
>
>
> > Modified:
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
> > URL:
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java?rev=1616584&r1=1616583&r2=1616584&view=diff
> >
> ==
> > ---
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
> (original)
> > +++
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
> Thu Aug  7 20:15:19 2014
> > @@ -767,7 +767,11 @@ public class PoolProperties implements P
> >
> >  try {
> >  @SuppressWarnings("unchecked")
> > -Class validatorClass =
> (Class)Class.forName(className);
> > +Class validatorClass =
> (Class)ClassLoaderUtil.loadClass(
> > +className,
> > +PoolProperties.class.getClassLoader(),
>
> OK.
>
> > +Thread.currentThread().getContextClassLoader()
> > +);
> >  validator = validatorClass.newInstance();
> >  } catch (ClassNotFoundException e) {
> >  log.warn("The class "+className+" cannot be found.", e);
> > @@ -957,12 +961,20 @@ public class PoolProperties implements P
> >  if (log.isDebugEnabled()) {
> >  log.debug("Loading interceptor
> class:"+PoolConfiguration.PKG_PREFIX+getClassName());
> >  }
> > -clazz =
> Class.forName(PoolConfiguration.PKG_PREFIX+getClassName(), true,
> this.getClass().getClassLoader());
> > +clazz = ClassLoaderUtil.loadClass(
> > +PoolConfiguration.PKG_PREFIX+getClassName(),
> > +this.getClass().getClassLoader(),
>
> It shall be "PoolProperties.class.getClassLoader()," as well here like
> above. Otherwise the new code is not equivalent to the old one.
>
> > +Thread.currentThread().getContextClassLoader()
> > +);
> >  } else {
> >  if (log.isDebugEnabled()) {
> >  log.debug("Loading interceptor
> class:"+getClassName());
> >  }
> > -clazz = Class.forName(getClassName(), true,
> this.getClass().getClassLoader());
> > +clazz = ClassLoaderUtil.loadClass(
> > +getClassName(),
> > +

Re: svn commit: r1616789 - /tomcat/trunk/modules/jdbc-pool/doc/changelog.xml

2014-08-10 Thread Filip Hanik 
changelog was probably built when it was published by itself in the V1
days. we can move it to the main changelog, under jdbc-pool




On Sun, Aug 10, 2014 at 3:42 PM, Konstantin Kolinko 
wrote:

> 2014-08-08 18:53 GMT+04:00  :
> > Author: fhanik
> > Date: Fri Aug  8 14:53:06 2014
> > New Revision: 1616789
> >
> > URL: http://svn.apache.org/r1616789
> > Log:
> > Update changelog with recent fixes
> >
> > Modified:
> > tomcat/trunk/modules/jdbc-pool/doc/changelog.xml
> >
> > Modified: tomcat/trunk/modules/jdbc-pool/doc/changelog.xml
> > URL:
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/changelog.xml?rev=1616789&r1=1616788&r2=1616789&view=diff
> >
> ==
> > --- tomcat/trunk/modules/jdbc-pool/doc/changelog.xml (original)
> > +++ tomcat/trunk/modules/jdbc-pool/doc/changelog.xml Fri Aug  8 14:53:06
> 2014
> > @@ -28,6 +28,25 @@
> >
> >
> >  
> > +
> > +
>
> 1. The version number is wrong. The next version is 8.0.11.
>
> (8.0.10 was tagged a month ago and failed the vote).
>
> 2. This changelog file is not built and is not included with Tomcat
> releases.
> Is it really needed here?
>
> In Tomcat 7 we used subsection name "jdbc-pool" to list Tomcat-JDBC
> pool changes. I think we should do the same for Tomcat 8.
>
> (There have not been any such changes in 8.0.0-8.0.10, so it is the
> first time when this section will be used in Tomcat 8).
>
> Best regards,
> Konstantin Kolinko
>
> > +  
> > +
> > +  1616760 54227 Evaluate max age upon
> borrow (fhanik)
> > +  1616644 56318 Ability to trace
> statement creation in StatementFinalizer (fhanik)
> > +  1616639 53088 More identifiable thread
> name (fhanik)
> > +  1616629 56789 getPool() returns the
> actual pool, always (fhanik)
> > +  1616625 54978 Make sure proper
> connection validation always happens, regardless of config (fhanik)
> > +  1616602 54537 Performance improvement
> in StatementFinalizer (fhanik)
> > +  1616599 54395 Fix JDBC interceptor
> parsing bug (fhanik)
> > +  1616595 54235 Disallow nested pools
> exploitating using data source (fhanik)
> > +  1616592 54225 Disallow empty init SQL
> (fhanik)
> > +  1616584 53853 More flexible
> classloading (fhanik)
> > +  1616570 53200 Selective logging for
> slow versus failed queries (fhanik)
> > +
> > +  
> > +
> > +
> >  
> >
> >  
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: svn commit: r1616644 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java

2014-08-10 Thread Filip Hanik 
you are right, I will resolve it on Monday
thanks for the review
Filip



On Sun, Aug 10, 2014 at 5:38 PM, Konstantin Kolinko 
wrote:

> 2014-08-08 4:04 GMT+04:00  :
> > Author: fhanik
> > Date: Fri Aug  8 00:04:51 2014
> > New Revision: 1616644
> >
> > URL: http://svn.apache.org/r1616644
> > Log:
> > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56318
> > Contribution by Danila Galimov
> > Ability to log statement creation stacks
> >
> > Modified:
> > tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
> >
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
> >
> > Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
> > URL:
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=1616644&r1=1616643&r2=1616644&view=diff
> >
> ==
> > --- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
> > +++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Fri Aug  8 00:04:51
> 2014
> > @@ -608,6 +608,13 @@
> > and closes these statements when the connection is returned to
> the pool.
> >  
> >  
> > +  
> > +(boolean as String) Enable tracing of unclosed statements.
> > +   When enabled and a connection is closed, and statements are
> not closed,
> > +   the interceptor will log all stack traces.
> > +   The default value is false.
> > +
> > +  
> >  
> >
> > name="org.apache.tomcat.jdbc.pool.interceptor.StatementCache">
> >
> > Modified:
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
> > URL:
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java?rev=1616644&r1=1616643&r2=1616644&view=diff
> >
> ==
> > ---
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
> (original)
> > +++
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
> Fri Aug  8 00:04:51 2014
> > @@ -19,6 +19,7 @@ package org.apache.tomcat.jdbc.pool.inte
> >  import org.apache.juli.logging.Log;
> >  import org.apache.juli.logging.LogFactory;
> >  import org.apache.tomcat.jdbc.pool.ConnectionPool;
> > +import org.apache.tomcat.jdbc.pool.PoolProperties;
> >  import org.apache.tomcat.jdbc.pool.PooledConnection;
> >
> >  import java.lang.ref.WeakReference;
> > @@ -26,6 +27,8 @@ import java.lang.reflect.Method;
> >  import java.sql.Statement;
> >  import java.util.LinkedList;
> >  import java.util.List;
> > +import java.util.Map;
> > +
> >  /**
> >   * Keeps track of statements associated with a connection and invokes
> close upon {@link java.sql.Connection#close()}
> >   * Useful for applications that dont close the associated statements
> after being done with a connection.
> > @@ -34,13 +37,15 @@ import java.util.List;
> >  public class StatementFinalizer extends
> AbstractCreateStatementInterceptor {
> >  private static final Log log =
> LogFactory.getLog(StatementFinalizer.class);
> >
> > -protected List> statements = new
> LinkedList<>();
> > -
> > +protected List> statements = new
> LinkedList<>();
>
>
> 1. This approach is broken.
>
> Essentially this change breaks StatementFinalizer.
>
> A weak reference to a Statement is OK, because there are hard
> references to that statement object elsewhere.
>
> A weak reference to a StatementEntry class is not OK,  because it is
> the only reference to it. It is immediately eligible to be
> garbage-collected.
>
>
> > +
> > +private boolean logCreationStack = false;
> > +
> >  @Override
> >  public Object createStatement(Object proxy, Method method, Object[]
> args, Object statement, long time) {
> >  try {
> >  if (statement instanceof Statement)
> > -statements.add(new
> WeakReference<>((Statement)statement));
> > +statements.add(new WeakReference<>(new
> StatementEntry((Statement)statement)));
> >  }catch (ClassCastException x) {
> >  //ignore this one
> >  }
> > @@ -50,25 +55,58 @@ public class StatementFinalizer extends
> >  @Override
> >  public void closeInvoked() {
> >  while (statements.size()>0) {
> > -WeakReference ws = statements.remove(0);
> > -Statement st = ws.get();
> > +WeakReference ws = statements.remove(0);
> > +StatementEntry st = ws.get();
> >  if (st!=null) {
> >  try {
> > -st.close();
> > +st.getStatement().close();
> >  } catch (Exception ignore) {
> >  if (log.isDebugEnabled()) {
> >  log.debug("Unab

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2014-08-10 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 19 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 25 mins 4 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140811-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140811.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140811-native-src.tar.gz
 -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true 
-Dexecute.test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl/dest-20140811/bi
 n/openssl -Dexecute.test.apr=false -Dexecute.test.bio=false 
-Dexecute.test.nio2=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar
 
-Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140811.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/o

[Bug 56837] New: if validationQuery have error with timeBetweenEvictionRunsMillis option, connection pool increase keep going

2014-08-10 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56837

Bug ID: 56837
   Summary: if validationQuery have error with
timeBetweenEvictionRunsMillis option, connection pool
increase keep going
   Product: Tomcat Modules
   Version: unspecified
  Hardware: HP
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: jdbc-pool
  Assignee: dev@tomcat.apache.org
  Reporter: ga...@hotmail.com

ENV: 
apache-tomcat-7.0.54
CentOS release 6.5 (Final)
jdk1.7.0_55


in case of  setting the  "timeBetweenEvictionRunsMillis",

when validationQuery is error, connection pool increase keep going.
Even if you set the maximum value(maxActive).

1. setting


2. try to ues connection Pool
--> validationQuery error 
---
3. server connection increases after 2 Millis
(timeBetweenEvictionRunsMillis value)
netstat -nap | grep 5432 | grep EST | grep java | wc -l
6
 netstat -nap | grep 5432 | grep EST | grep java | wc -l
8
---
If Pool can not guarantee maxActive value, that is problem.

Did I  something wrong use timeBetweenEvictionRunsMillis option?

timeBetweenEvictionRunsMillis option is not available?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56838] New: Resources Implementation

2014-08-10 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56838

Bug ID: 56838
   Summary: Resources Implementation
   Product: Tomcat 8
   Version: trunk
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: pgri...@gmail.com

Created attachment 31896
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31896&action=edit
test.TestingServlet

Per the below mailing list discussion, the latest 8.0.X branch does not cache
results from certain calls to the web resources implementation.

http://marc.info/?t=14072830811&r=1&w=2

This has resulted in a significant performance decrease in some scenarios over
Tomcat 7.  The attached servlet and web resource demonstrate the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56838] Resources Implementation

2014-08-10 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56838

--- Comment #1 from Peter Rifel  ---
Created attachment 31897
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31897&action=edit
/WEB-INF/test.xsd

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56838] Resources Implementation

2014-08-10 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56838

Peter Rifel  changed:

   What|Removed |Added

 CC||pgri...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56838] Performance issues with calls to Resources implementation

2014-08-10 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56838

Peter Rifel  changed:

   What|Removed |Added

Summary|Resources Implementation|Performance issues with
   ||calls to Resources
   ||implementation

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56838] Performance drop when using XML

2014-08-10 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56838

Mark Thomas  changed:

   What|Removed |Added

Summary|Performance issues with |Performance drop when using
   |calls to Resources  |XML
   |implementation  |

--- Comment #2 from Mark Thomas  ---
Tweak the title. I can reproduce this and while it is true that the call to
getResources() bypasses the cache and that has a negative performance impact,
that doesn't account for all of the differences observed. More investigation as
to the root cause is required.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org