[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 26 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20140710.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/tar get/commons-exec-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20140710.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20140710.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-20140710.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-18.0-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar setproxy: downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle [checkstyle] Running Checkstyle 5.8-SNAPSHOT on 2904 files [checkstyle] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseGenericObjectPool.java:252: Line matches the illegal pattern '\s+$'. [checkstyle] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseObjectPoolConfig.java:36: Line matches the illegal pattern '\s+$'. [checkstyle] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseObjectPoolConfig.java:156: Line matches the illegal pattern '\s+$'. [checkstyle] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseObjectPoolConfig.java:206: Line matches the illegal pattern '\s+$'. [checkstyle] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseObjectPoolConfig.java:234: Line matches the illegal pattern '\s+$'. [checkstyle] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/dbcp/pool2/impl/GenericObjectPoolMXBean.java:44: Line matches the illegal pattern '\s+$'. [checkstyle] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/dbcp/pool2/impl/InterruptibleReentrantLock.java:38: Line matches the illegal pattern '\s+$'. [checkstyle] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/dbcp/pool2/impl/LinkedBlockingDeque.java:164: Line matc
svn commit: r1609411 - in /tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl: BaseGenericObjectPool.java BaseObjectPoolConfig.java GenericObjectPoolMXBean.java InterruptibleReentrantLock.java Linked
Author: markt
Date: Thu Jul 10 07:22:24 2014
New Revision: 1609411
URL: http://svn.apache.org/r1609411
Log:
Whitespace police after merges
Modified:
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseGenericObjectPool.java
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseObjectPoolConfig.java
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/GenericObjectPoolMXBean.java
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/InterruptibleReentrantLock.java
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/LinkedBlockingDeque.java
Modified:
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseGenericObjectPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseGenericObjectPool.java?rev=1609411&r1=1609410&r2=1609411&view=diff
==
---
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseGenericObjectPool.java
(original)
+++
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseGenericObjectPool.java
Thu Jul 10 07:22:24 2014
@@ -249,7 +249,7 @@ public abstract class BaseGenericObjectP
public final boolean getLifo() {
return lifo;
}
-
+
/**
* Returns whether or not the pool serves threads waiting to borrow
objects fairly.
* True means that waiting threads are served as if waiting in a FIFO
queue.
Modified:
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseObjectPoolConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseObjectPoolConfig.java?rev=1609411&r1=1609410&r2=1609411&view=diff
==
---
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseObjectPoolConfig.java
(original)
+++
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/BaseObjectPoolConfig.java
Thu Jul 10 07:22:24 2014
@@ -33,7 +33,7 @@ public abstract class BaseObjectPoolConf
* @see GenericKeyedObjectPool#getLifo()
*/
public static final boolean DEFAULT_LIFO = true;
-
+
/**
* The default value for the {@code fairness} configuration attribute.
* @see GenericObjectPool#getFairness()
@@ -153,7 +153,7 @@ public abstract class BaseObjectPoolConf
private boolean lifo = DEFAULT_LIFO;
-
+
private boolean fairness = DEFAULT_FAIRNESS;
private long maxWaitMillis = DEFAULT_MAX_WAIT_MILLIS;
@@ -203,7 +203,7 @@ public abstract class BaseObjectPoolConf
public boolean getLifo() {
return lifo;
}
-
+
/**
* Get the value for the {@code fairness} configuration attribute for pools
* created with this configuration instance.
@@ -231,7 +231,7 @@ public abstract class BaseObjectPoolConf
public void setLifo(boolean lifo) {
this.lifo = lifo;
}
-
+
/**
* Set the value for the {@code fairness} configuration attribute for pools
* created with this configuration instance.
Modified:
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/GenericObjectPoolMXBean.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/GenericObjectPoolMXBean.java?rev=1609411&r1=1609410&r2=1609411&view=diff
==
---
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/GenericObjectPoolMXBean.java
(original)
+++
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/GenericObjectPoolMXBean.java
Thu Jul 10 07:22:24 2014
@@ -41,7 +41,7 @@ public interface GenericObjectPoolMXBean
* See {@link GenericObjectPool#getLifo()}
* @return See {@link GenericObjectPool#getLifo()}
*/
-boolean getFairness();
+boolean getFairness();
/**
* See {@link GenericObjectPool#getFairness()}
* @return See {@link GenericObjectPool#getFairness()}
Modified:
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/InterruptibleReentrantLock.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/InterruptibleReentrantLock.java?rev=1609411&r1=1609410&r2=1609411&view=diff
==
---
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/InterruptibleReentrantLock.java
(original)
+++
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/InterruptibleReentrantLock.java
Thu Jul 10 07:22:24 2014
@@ -35,7 +35,7 @@ class InterruptibleReentrantLock extends
/**
* Create a new InterruptibleReentrantLock with the given fairness policy.
- *
+ *
* @param fairness true means threads should acquire contended locks as if
* waiting in a FIFO queue
*/
Modified:
tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/LinkedBlockingDeque.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/impl/LinkedBlockingDeque.java?rev=1609411&r1=160941
Re: [GUMP@vmgump]: Project tomcat-trunk-test-bio (in module tomcat-trunk) failed
2014-07-10 7:02 GMT+04:00 Bill Barker : > To whom it may engage... > > This is an automated request, but not an unsolicited one. For > more information please visit http://gump.apache.org/nagged.html, > and/or contact the folk at gene...@gump.apache.org. > > Project tomcat-trunk-test-bio has an issue affecting its community > integration. > This issue affects 1 projects, > and has been outstanding for 6 runs. > The current state of this project is 'Failed', with reason 'Build Failed'. > For reference only, the following projects are affected by this: > - tomcat-trunk-test-bio : Tomcat 8.x, a web server implementing the Java > Servlet 3.1, > ... > > > Full details are available at: > > http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-bio/index.html > Test org.apache.catalina.session.TestPersistentManager FAILED [[[ Testsuite: org.apache.catalina.session.TestPersistentManager Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.868 sec - Standard Error - 10-Jul-2014 02:51:45.769 INFO [main] org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler ["http-bio-127.0.0.1-auto-1"] 10-Jul-2014 02:51:45.811 INFO [main] org.apache.catalina.core.StandardService.startInternal Starting service Tomcat 10-Jul-2014 02:51:45.822 INFO [main] org.apache.catalina.core.StandardEngine.startInternal Starting Servlet Engine: Apache Tomcat/8.0.10-dev 10-Jul-2014 02:51:46.116 INFO [main] org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler ["http-bio-127.0.0.1-auto-1-45846"] 10-Jul-2014 02:51:47.503 INFO [main] org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler ["http-bio-127.0.0.1-auto-1-45846"] 10-Jul-2014 02:51:47.505 INFO [main] org.apache.catalina.core.StandardService.stopInternal Stopping service Tomcat 10-Jul-2014 02:51:47.526 INFO [main] org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler ["http-bio-127.0.0.1-auto-1-45846"] 10-Jul-2014 02:51:47.527 INFO [main] org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler ["http-bio-127.0.0.1-auto-1-45846"] - --- Testcase: backsUpOnce took 2.848 sec FAILED expected:<[4AC2976017F91624B46E2D7D78F6ABE8]> but was:<[]> junit.framework.AssertionFailedError: expected:<[4AC2976017F91624B46E2D7D78F6ABE8]> but was:<[]> at org.apache.catalina.session.TestPersistentManager.backsUpOnce(TestPersistentManager.java:88) ]]] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Safe default SSL ciphers
On 09/07/14 18:46, Mark Thomas wrote:
On 09/07/2014 13:46, jean-frederic clere wrote:
On 09/07/14 02:22, Konstantin Kolinko wrote:
2014-07-08 23:52 GMT+04:00 Rémy Maucherat :
Hi,
Using the newly added OpenSSL syntax processor, a safe default cipher
suite
can be expressed as (for both native and JSSE):
"HIGH:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5"
This avoids weak ciphers in a neat and portable way, although the "best"
default is still under investigation.
I plan to change the default for AbstractProcessor.ciphers and
AprEndpoint.SSLCipherSuite to that string.
Do you expect to maintain that string and to change the value between
point releases in the future?
(1.) If not, then it may become obsolete and the situation will not be
much different from what we have now.
(2.) If yes, then do we have enough man power to test and support such
changes?
An expected situation is that some clients won't be able to connect to
their servers after such changes.
Do we make a decision of changing the setting by ourselves, or we rely
on some authority? E.g. we may follow [1].
In general, I like the idea.
I think it targets those admins who do not care enough to be able to
configure the values by themselves.
Regarding testing any changes to the value,
https://www.ssllabs.com/ssltest/ server test simulates some known
clients and prints what cipher they would choose with those settings.
E.g. (results for some site)
"IE 6 / XP": "Protocol or cipher suite mismatch"
so those people wouldn't be able to connect.
A good resource:
[1] https://wiki.mozilla.org/Security/Server_Side_TLS
Their current recommendation is
"ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:DHE-DSS-AES128-GCM-SHA256:kEDH+AESGCM:ECDHE-RSA-AES128-SHA256:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA:ECDHE-ECDSA-AES128-SHA:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA:ECDHE-ECDSA-AES256-SHA:DHE-RSA-AES128-SHA256:DHE-RSA-AES128-SHA:DHE-DSS-AES128-SHA256:DHE-RSA-AES256-SHA256:DHE-DSS-AES256-SHA:DHE-RSA-AES256-SHA:AES128-GCM-SHA256:AES256-GCM-SHA384:AES128:AES256:AES:DES-CBC3-SHA:HIGH:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5:!PSK"
Actually people in our security team suggest to remove DES-CBC3-SHA and
document how to add back it for backwards compatibility if needed.
My personal preference would be a selection that gets the best possible
score given the limitation of the ciphers provided by the JRE (with the
export grade stuff enabled) with https://www.ssllabs.com/ssltest/ with
the additional requirement that it includes a working configuration for
all of the reference clients.
On a related topic, it would be extremely useful if the available
ciphers were exposed through the native interface. Anyone with C skills
fancy taking a look?
My main motivation for this is that we can write a unit test that checks
the mapping of OpenSSL ciphers to JSSE ciphers and highlights (by a
failure) when the mapping changes (e.g. one of them adds support for a
new cipher).
There is a setCipherSuite() in the native probably adding a
getCipherSuite() would do the trick.
Cheers
Jean-Frederic
Mark
Cheers
Jean-Frederic
So
1) I am OK with the change.
2) I think there must be an explicit warning in documentation that the
default value may change at any time.
3) I think we should rely on some authority like [1] and follow them.
Instead of hard-coding the value in Java code, maybe put it as a
property into catalina.properties file, and reference it as
${propertyname} in server.xml?
We have a nice tool to compare catalina.properties between versions at
http://tomcat.apache.org/migration-8.html#Upgrading_8.0.x
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: security-unsubscr...@tomcat.apache.org
For additional commands, e-mail: security-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609435 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_10: ./ build.properties.default
Author: markt Date: Thu Jul 10 10:22:59 2014 New Revision: 1609435 URL: http://svn.apache.org/r1609435 Log: Tag 8.0.10 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_10/ - copied from r1609431, tomcat/trunk/ Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_10/build.properties.default Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_10/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/tags/TOMCAT_8_0_10/build.properties.default?rev=1609435&r1=1609431&r2=1609435&view=diff == --- tomcat/tc8.0.x/tags/TOMCAT_8_0_10/build.properties.default (original) +++ tomcat/tc8.0.x/tags/TOMCAT_8_0_10/build.properties.default Thu Jul 10 10:22:59 2014 @@ -27,7 +27,7 @@ version.major=8 version.minor=0 version.build=10 version.patch=0 -version.suffix=-dev +version.suffix= # - Build control flags - # Note enabling validation uses Checkstyle which is LGPL licensed - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 50604] Incorrect dependency in jasper.pom for eclipse ecj
https://issues.apache.org/bugzilla/show_bug.cgi?id=50604 --- Comment #16 from Mark Thomas --- The JAR is also available in Maven Central as: http://search.maven.org/#artifactdetails|org.eclipse.tycho|org.eclipse.jdt.core|3.10.0.v20140604-1726|jar I'm wondering if a) this JAR would work as a replacement and b) how folks would feel about if being larger. I'm only thinking of referencing it in the Jasper POM, not using it in a normal Tomcat build. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 50604] Incorrect dependency in jasper.pom for eclipse ecj
https://issues.apache.org/bugzilla/show_bug.cgi?id=50604 --- Comment #17 from Mark Thomas --- Chatting this over with some folks that actively use embedded Tomcat at $work someone suggested using the JDK compiler instead. With this in mind, I am currently thinking about the following plan: a) switch the JDT dependency in Jasper to the 5.3MB JAR that is in Maven central b) make the JDT dependency optional This should mean embedded Tomcat uses the JDK compiler by default unless JDT is available. I want to test that this works the way I think it will before I make any changes. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r5812 [2/2] - in /dev/tomcat/tomcat-8/v8.0.10: ./ bin/ bin/embed/ bin/extras/ src/
Added: dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.tar.gz.md5 == --- dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.tar.gz.md5 (added) +++ dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.tar.gz.md5 Thu Jul 10 12:31:43 2014 @@ -0,0 +1 @@ +60abec76f3af0098be78355537abb97e *apache-tomcat-8.0.10-src.tar.gz \ No newline at end of file Added: dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip == Binary file - no diff available. Propchange: dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip -- svn:mime-type = application/octet-stream Added: dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.asc == --- dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.asc (added) +++ dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.asc Thu Jul 10 12:31:43 2014 @@ -0,0 +1,17 @@ +-BEGIN PGP SIGNATURE- +Version: GnuPG v1.4.9 (MingW32) + +iQIcBAABAgAGBQJTvnXIAAoJEBDAHFovYFnnTlAP/1mlySZRtH6PBA9eWkio2rG2 +FcnVjhChMIX9G570Y2heZuIV8Z5+aJ0zxDjlYKMu7KRh+f1Jx6DWVoNtOTBZh0Qh +IbFMiJNvqmD2Rm1cPmz0+2yunA76TjqaoqduDNJ3l6Y0wXnl+oaTEIB29FPJ9xSP +ztgClylavdL0ghbvKGzOj7YoM2MY9VGt2e99aiCgtBsPFBIvW3X6lcLnj2mxOXIZ +F7inE5aJ2dtTRcfuhXxiS3U1+DlhIXXodzJ2mp8eaDF7y99Txi25BXZbT4aWmPSc +O5tQ1pmI27qdV6MTMMp90FRiMiQH3QOnANEAR4/KNOxXyr48zAVGZBCJLBbGWdEK +NQo0myQ1mUKGEjknwewoFd9G3094r/QA7fbtfX3vPhSVFdDbWyCFB8ksX5G0+gMH +3Bt0Z2EX1LspeVXSij1b1ByCM8RcAtib3tB3M6ctX95+CFxhPbfWsEINWkIWRxJW +5rHBwZQ9RzpaG+dpAZqKV4iLvq94mHMbM0t45+9rvq6mfj7FjVcD3aN0Pu84pbOg +P2RbMEFHPeoJHXCNQxxZThumyIn2akLzRN4xkqz6wL/Mz4KfVXsH2jyZC/NGf57v +i638IREeNMzTMfe5bDM13skxfqrCAIHNPBq3GGdo8NeDnUl6UMZYP+KbPdG9LR+d +1DKuvPFsI4gqZ00B74bE +=W1Tn +-END PGP SIGNATURE- Added: dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.md5 == --- dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.md5 (added) +++ dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.md5 Thu Jul 10 12:31:43 2014 @@ -0,0 +1 @@ +dc88454417151d55b70bb1c5340e468d *apache-tomcat-8.0.10-src.zip \ No newline at end of file - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Safe default SSL ciphers
Mark,
On 7/9/14, 12:46 PM, Mark Thomas wrote:
> On a related topic, it would be extremely useful if the available
> ciphers were exposed through the native interface. Anyone with C skills
> fancy taking a look?
>
> My main motivation for this is that we can write a unit test that
> checks the mapping of OpenSSL ciphers to JSSE ciphers and highlights
> (by a failure) when the mapping changes (e.g. one of them adds
> support for a new cipher).
So you want to:
1. Take a cipher suite string and run it through Rémy's JSSE code
2. Take the same cipher suite string and run it through OpenSSL
3. Compare the two resulting cipher suite lists to ensure they are
the same (barring absent ciphers in each implementation)
?
While step 2 could be done via JNI, it could also be done like this:
System.exec("openssl ciphers ");
Since OpenSSL and JSSE support different sets of ciphers out of the box,
does that mean that we'll have to maintain a complicated set of allowed
inconsistencies based upon the combination of JVM and OpenSSL version?
For example, OpenSSL prior to 1.0.something do not have ECDHE ciphers,
and at some point they became available in JSSE. Unless you have
matching versions of both, you'll get a failure. I think it would be
fairly chaotic.
-chris
signature.asc
Description: OpenPGP digital signature
[VOTE] Release Apache Tomcat 8.0.10
The proposed Apache Tomcat 8.0.10 release is now available for voting. The main changes since 8.0.9 are: - Various improvements to the Mapper including fixing some concurrency bugs - Update to Tomcat Native Library version 1.1.31 to pick up the Windows binaries that are based on OpenSSL 1.0.1h - Start to add permessage-deflate to WebSocket. Currently only client to server compression is supported. There is also the usual collection of bug fixes, new features and performance improvements. For full details, see the changelog: http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.10/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1017/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_10/ The proposed 8.0.10 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.0.10 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Safe default SSL ciphers
On 10/07/2014 14:27, Christopher Schultz wrote:
> Mark,
>
> On 7/9/14, 12:46 PM, Mark Thomas wrote:
>> On a related topic, it would be extremely useful if the
>> available ciphers were exposed through the native interface.
>> Anyone with C skills fancy taking a look?
>>
>> My main motivation for this is that we can write a unit test
>> that checks the mapping of OpenSSL ciphers to JSSE ciphers and
>> highlights (by a failure) when the mapping changes (e.g. one of
>> them adds support for a new cipher).
>
> So you want to:
>
> 1. Take a cipher suite string and run it through Rémy's JSSE code
> 2. Take the same cipher suite string and run it through OpenSSL 3.
> Compare the two resulting cipher suite lists to ensure they are the
> same (barring absent ciphers in each implementation)
>
> ?
Not what I had in mind but that would be useful too.
What I wanted to do was:
- get the list of ciphers from OpenSSL
- check that each entry was either mapped to a JSSE cipher or in a
list of known unmappable ciphers
- check that every JSSE entry we expected to be mapped as was mapped
To put it another way, I want a unit test that fails if JSSE or
OpenSSL add or remove a cipher and/or the mapping from JSSE to OpenSSL
changes so we can investigate.
> While step 2 could be done via JNI, it could also be done like
> this:
>
> System.exec("openssl ciphers ");
>
> Since OpenSSL and JSSE support different sets of ciphers out of the
> box, does that mean that we'll have to maintain a complicated set
> of allowed inconsistencies based upon the combination of JVM and
> OpenSSL version?
Nope. Just the mapping from latest OpenSSL to latest version of Java
that that version of Tomcat builds with.
> For example, OpenSSL prior to 1.0.something do not have ECDHE
> ciphers, and at some point they became available in JSSE. Unless
> you have matching versions of both, you'll get a failure. I think
> it would be fairly chaotic.
Which is why you work with the latest of each rather than trying to
track all possible combinations.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Safe default SSL ciphers
On 10/07/2014 11:20, jean-frederic clere wrote: > On 09/07/14 18:46, Mark Thomas wrote: >> My main motivation for this is that we can write a unit test that checks >> the mapping of OpenSSL ciphers to JSSE ciphers and highlights (by a >> failure) when the mapping changes (e.g. one of them adds support for a >> new cipher). > > There is a setCipherSuite() in the native probably adding a > getCipherSuite() would do the trick. I'd expect getCipherSuite() to return the current list of ciphers in use. What I'm after is getSupportedCipherSuites() or similar. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "ReleaseProcess" by VioletaGeorgieva
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "ReleaseProcess" page has been changed by VioletaGeorgieva:
https://wiki.apache.org/tomcat/ReleaseProcess?action=diff&rev1=8&rev2=9
The aim is to create a copy of the current trunk but without the "-dev"
appended to the end of the version number.
* Perform an svn checkout of tc7.0.x/trunk (e.g. to 7.0.x-release)
* Edit 7.0.x-release/build.properties and change the line
{{{version.suffix=-dev}}} to {{{version.suffix=}}}
+ * Remove repository's property "subclipse:tags"
* {{{svn cp .
https://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_XX}}}
* Check the diff mailed to the dev list
I found it simplest to keep this checkout with the modified
{{{build.properties.default}}} and just do an {{{svn up}}} prior to each tag. I
only used the checkout for tagging to ensure no other edits found their way
into the tag.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609528 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_55: ./ build.properties.default
Author: violetagg Date: Thu Jul 10 17:54:52 2014 New Revision: 1609528 URL: http://svn.apache.org/r1609528 Log: Tag 7.0.55 Added: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ (props changed) - copied from r1609522, tomcat/tc7.0.x/trunk/ Modified: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/build.properties.default Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- bugtraq:append = false Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- bugtraq:label = Bugzilla ID (optional) Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- --- bugtraq:logregex (added) +++ bugtraq:logregex Thu Jul 10 17:54:52 2014 @@ -0,0 +1,2 @@ +(https?\://issues.apache.org/bugzilla/show_bug.cgi\?id=\d+|BZ\s?\d+) +(\d+) Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- --- bugtraq:message (added) +++ bugtraq:message Thu Jul 10 17:54:52 2014 @@ -0,0 +1 @@ +Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- bugtraq:number = true Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- bugtraq:url = https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- bugtraq:warnifnoissue = false Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- --- svn:ignore (added) +++ svn:ignore Thu Jul 10 17:54:52 2014 @@ -0,0 +1,7 @@ +.* +build.properties +logs +nbproject +output +work +*.iml Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- --- svn:mergeinfo (added) +++ svn:mergeinfo Thu Jul 10 17:54:52 2014 @@ -0,0 +1 @@ +/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222329,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112,1240114 ,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342320,1342476,1342 498,1342503,1342717,1342795,1342805,1343044-1343046,1343335,1343394,1343400,1343629,1343708,1343718,1343895,1344063,1344068,1344250,1344266,1344515,1344528,1344612,1344629,1344725,1344868,1344890,1344893,1344896,1344901,1345020,1345029,1345039,1345287-1345290,1345294,1345309,1345325,1345357,1345367,1345579-1345580,1345582,1345688,1345699,1345704,1345731-1345732,1345737,1345744,1345752,1345754,1345779,1345781,1345846,1346107,1346365,1346376,1346404,1346510,1346514,1346519,1346581,1346635,1346644,1346683,1346794,1346885,1346932,1347034,1347047,1347087,1347108-1347109,1347583,1347737,1348105,1348357,1348398,1348425,1348461-1348495,1348498,1348752,1348762,1348772,1348776,1348859,1348968,1348973,1348989,1349007,1349237,1349298,1349317,1349410,1349473,1349539,1349879,1349887,1349893,13499
[Tomcat Wiki] Update of "ReleaseProcess" by VioletaGeorgieva
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "ReleaseProcess" page has been changed by VioletaGeorgieva: https://wiki.apache.org/tomcat/ReleaseProcess?action=diff&rev1=9&rev2=10 == If the vote does not pass == * Update the release date in the changelog to "not released" + * Drop the artifacts from https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/ + * Drop the maven artifacts from the staged maven repository - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56568] Incompatible change in "JSPs only permit GET POST or HEAD"
https://issues.apache.org/bugzilla/show_bug.cgi?id=56568 --- Comment #12 from Grigory --- UPDATE: As of Tomcat 8.0.9 when a JSP is used to generate an error page, any HTTP method will be allowed. Good news, thanks! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Safe default SSL ciphers
Mark,
On 7/10/14, 11:01 AM, Mark Thomas wrote:
> On 10/07/2014 14:27, Christopher Schultz wrote:
>> Mark,
>>
>> On 7/9/14, 12:46 PM, Mark Thomas wrote:
>>> On a related topic, it would be extremely useful if the
>>> available ciphers were exposed through the native interface.
>>> Anyone with C skills fancy taking a look?
>>>
>>> My main motivation for this is that we can write a unit test
>>> that checks the mapping of OpenSSL ciphers to JSSE ciphers and
>>> highlights (by a failure) when the mapping changes (e.g. one of
>>> them adds support for a new cipher).
>>
>> So you want to:
>>
>> 1. Take a cipher suite string and run it through Rémy's JSSE code
>> 2. Take the same cipher suite string and run it through OpenSSL 3.
>> Compare the two resulting cipher suite lists to ensure they are the
>> same (barring absent ciphers in each implementation)
>>
>> ?
>
> Not what I had in mind but that would be useful too.
>
> What I wanted to do was:
> - get the list of ciphers from OpenSSL
> - check that each entry was either mapped to a JSSE cipher or in a
> list of known unmappable ciphers
> - check that every JSSE entry we expected to be mapped as was mapped
>
> To put it another way, I want a unit test that fails if JSSE or
> OpenSSL add or remove a cipher and/or the mapping from JSSE to OpenSSL
> changes so we can investigate.
Okay, that sounds like what I was trying to express above, regardless of
the exact method of doing so.
>> While step 2 could be done via JNI, it could also be done like
>> this:
>>
>> System.exec("openssl ciphers ");
>>
>> Since OpenSSL and JSSE support different sets of ciphers out of the
>> box, does that mean that we'll have to maintain a complicated set
>> of allowed inconsistencies based upon the combination of JVM and
>> OpenSSL version?
>
> Nope. Just the mapping from latest OpenSSL to latest version of Java
> that that version of Tomcat builds with.
Okay.
>> For example, OpenSSL prior to 1.0.something do not have ECDHE
>> ciphers, and at some point they became available in JSSE. Unless
>> you have matching versions of both, you'll get a failure. I think
>> it would be fairly chaotic.
>
> Which is why you work with the latest of each rather than trying to
> track all possible combinations.
That seems reasonable.
Any reason not to use "openssl ciphers" rather than building a JNI
interface to the OpenSSL call? In order to get that list, you actually
have to build an SSL context, then an "SSL" object in C and set it all
up properly to get the list. To do it accurately, I think you might
have to initialize tcnative with a certificate and all that jazz. The
"ciphers" tool that OpenSSL ships already does all that stuff with dummy
certs and/or ones that you configure somewhere (I don't feel like
tracking-down all the code that loads those defaults, etc. because the
OpenSSL code is so horrible).
-chris
signature.asc
Description: OpenPGP digital signature
[Tomcat Wiki] Update of "FAQ/Password" by KonstantinKolinko
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Password" page has been changed by KonstantinKolinko: https://wiki.apache.org/tomcat/FAQ/Password?action=diff&rev1=9&rev2=10 Comment: Add emphasis == Why are plain text passwords in the config files? == Because there is no good way to "secure" them. When Tomcat needs to connect to a database, it needs the original password. While the password could be encoded, there still needs to be a mechanism to decode it. And since the source to Tomcat is freely available, the attacker would know the decoding method. So at best, the password is obscured - but not really protected. Please see the user and dev list archives for flame wars about this topic. - That said, any configuration file that does contain a password needs to be appropriately secured. That means limiting access to the file so that it could be read only by the user that Tomcat process runs as and root (or the administrator on Windows). + That said, any configuration file that does contain a password needs to be appropriately secured. That means '''limiting access''' to the file so that it could be read only by the user that Tomcat process runs as and root (or the administrator on Windows). In [[http://www.catb.org/~esr/writings/cathedral-bazaar/|The Cathedral and the Bazaar]], Eric S. Raymond recounts a story where his fetchmail users asked for encrypted passwords in the .fetchmailrc file (which is almost identical to the situation posed here with server.xml). He refused [[http://www.catb.org/~esr/writings/cathedral-bazaar/cathedral-bazaar/ar01s09.html|using the same arguments posed here]]: encrypting or otherwise obfuscating the password in server.xml does not provide any real security: only "security by obscurity" which isn't actually secure. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "FAQ/Password" by KonstantinKolinko
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "FAQ/Password" page has been changed by KonstantinKolinko:
https://wiki.apache.org/tomcat/FAQ/Password?action=diff&rev1=10&rev2=11
Comment:
Add link to Wikipedia article
* Write your own {{{javax.naming.spi.ObjectFactory}}} implementation that
creates and configures your datasource.
* (Tomcat 7) Write your own
{{{org.apache.tomcat.util.IntrospectionUtils.PropertySource}}} implementation
to 'decrypt' passwords that are 'encrypted' in catalina.properties and
referenced via ${...} in server.xml. You will need to set the system property
{{{org.apache.tomcat.util.digester.PROPERTY_SOURCE}}} to point to your
!PropertySource implementation.
+ A cultural reference:
+
+ * [[http://en.wikipedia.org/wiki/Turtles_all_the_way_down|It is turtles all
the way down]] (Wikipedia)
+
[[CategoryFAQ]]
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.10
I am seeing NPEs after reloading a web application with a custom . Just downloaded the sample.war, added the following block in web.xml and thus reloaded the web application: /404.jsp Accessing a nonexisting page now results in NPE instead of error page being shown. After tomcat restart the error-page is shown, until the next reload of the application: 10-Jul-2014 20:31:40.531 SEVERE [http-nio-8080-exec-2] org.apache.catalina.core.StandardHostValve.custom Exception Processing ErrorPage[errorCode=0, location=/404.jsp] java.lang.NullPointerException at org.apache.catalina.core.StandardHostValve.custom(StandardHostValve.java:423) at org.apache.catalina.core.StandardHostValve.status(StandardHostValve.java:291) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:610) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:526) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1078) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:658) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:222) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1566) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1523) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) at java.lang.Thread.run(Thread.java:745) On Thu, Jul 10, 2014 at 4:53 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.10 release is now available for voting. > > The main changes since 8.0.9 are: > - Various improvements to the Mapper including fixing some concurrency > bugs > - Update to Tomcat Native Library version 1.1.31 to pick up the Windows > binaries that are based on OpenSSL 1.0.1h > - Start to add permessage-deflate to WebSocket. Currently only client > to server compression is supported. > > There is also the usual collection of bug fixes, new features and > performance improvements. For full details, see the changelog: > http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.10/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1017/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_10/ > > The proposed 8.0.10 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 8.0.10 > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Created] (MTOMCAT-272) Add ability to change the embedded Tomcat's MemoryRealm allRolesMode.
SteveKrall created MTOMCAT-272: -- Summary: Add ability to change the embedded Tomcat's MemoryRealm allRolesMode. Key: MTOMCAT-272 URL: https://issues.apache.org/jira/browse/MTOMCAT-272 Project: Apache Tomcat Maven Plugin Issue Type: Improvement Reporter: SteveKrall Our web application we use AllRolesMode of strictAuthOnly. It would be nice to be able to change the MemoryRealm's allRolesMode via the pom. Something like strictAuthOnly -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56709] New: No TLD files message refers to invalid property DefaultJarScanner.jarsToSkip
https://issues.apache.org/bugzilla/show_bug.cgi?id=56709 Bug ID: 56709 Summary: No TLD files message refers to invalid property DefaultJarScanner.jarsToSkip Product: Tomcat 8 Version: 8.0.9 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Jasper Assignee: dev@tomcat.apache.org Reporter: robert.k...@ncogroup.com The error log entry: org.apache.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found in [file:something.jar]. Consider adding the JAR to the tomcat.util.scan.DefaultJarScanner.jarsToSkip property in CATALINA_BASE/conf/catalina.properties file. refers to an undocumented property tomcat.util.scan.DefaultJarScanner.jarsToSkip. I tried using this in my configuration, and I did not get the expected result. What is documented is tomcat.util.scan.StandardJarScanFilter.jarsToSkip. I propose that the error message be updated to reflect the actual name of the property setting. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609564 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11Nio2Processor.java java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml
Author: remm
Date: Thu Jul 10 20:21:55 2014
New Revision: 1609564
URL: http://svn.apache.org/r1609564
Log:
Fix various NIO2 sendfile issues discovered while testing ciphers, and refactor
to optimize its behavior.
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Processor.java
tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Processor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Processor.java?rev=1609564&r1=1609563&r2=1609564&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Processor.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Processor.java Thu Jul
10 20:21:55 2014
@@ -280,17 +280,21 @@ public class Http11Nio2Processor extends
if (sendfileData != null && !getErrorState().isError()) {
((Nio2Endpoint.Nio2SocketWrapper)
socketWrapper).setSendfileData(sendfileData);
sendfileData.keepAlive = keepAlive;
-if (((Nio2Endpoint) endpoint).processSendfile(
-(Nio2Endpoint.Nio2SocketWrapper) socketWrapper)) {
-sendfileInProgress = true;
-} else {
+switch (((Nio2Endpoint) endpoint)
+.processSendfile((Nio2Endpoint.Nio2SocketWrapper)
socketWrapper)) {
+case DONE:
+return false;
+case ERROR:
// Write failed
if (log.isDebugEnabled()) {
log.debug(sm.getString("http11processor.sendfile.error"));
}
setErrorState(ErrorState.CLOSE_NOW, null);
+return true;
+case PENDING:
+sendfileInProgress = true;
+return true;
}
-return true;
}
return false;
}
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java?rev=1609564&r1=1609563&r2=1609564&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Thu Jul 10
20:21:55 2014
@@ -17,11 +17,11 @@
package org.apache.tomcat.util.net;
+import java.io.EOFException;
import java.io.File;
import java.io.IOException;
import java.net.InetSocketAddress;
import java.net.SocketAddress;
-import java.net.StandardSocketOptions;
import java.nio.ByteBuffer;
import java.nio.channels.AsynchronousChannelGroup;
import java.nio.channels.AsynchronousServerSocketChannel;
@@ -315,8 +315,6 @@ public class Nio2Endpoint extends Abstra
// Determine which cipher suites and protocols to enable
enabledCiphers = sslUtil.getEnableableCiphers(sslContext);
enabledProtocols = sslUtil.getEnableableProtocols(sslContext);
-// FIXME: temporary, investigate apparent sendfile issue
-useSendfile = false;
}
if (oomParachute>0) reclaimParachute(true);
@@ -888,7 +886,85 @@ public class Nio2Endpoint extends Abstra
TimeUnit.MILLISECONDS, socket, awaitBytes);
}
-public boolean processSendfile(final Nio2SocketWrapper socket) {
+public enum SendfileState {
+PENDING, DONE, ERROR
+}
+
+private CompletionHandler sendfile = new
CompletionHandler() {
+
+@Override
+public void completed(Integer nWrite, SendfileData attachment) {
+if (nWrite.intValue() < 0) { // Reach the end of stream
+failed(new EOFException(), attachment);
+return;
+}
+attachment.pos += nWrite.intValue();
+if (!attachment.buffer.hasRemaining()) {
+if (attachment.length <= 0) {
+// All data has now been written
+attachment.socket.setSendfileData(null);
+attachment.buffer.clear();
+try {
+attachment.fchannel.close();
+} catch (IOException e) {
+// Ignore
+}
+if (attachment.keepAlive) {
+if (!isInline()) {
+awaitBytes(attachment.socket);
+} else {
+attachment.doneInline = true;
+}
+} else {
+if (!isInline()) {
+processSocket(attachment.socket,
SocketStatus.DISCONNECT, false);
+} else {
+attachment.doneInline = true;
+
Re: [VOTE] Release Apache Tomcat 8.0.10
2014-07-10 22:40 GMT+04:00 Falco Schwarz : > I am seeing NPEs after reloading a web application with a custom > . Just downloaded the sample.war, added the following > block in web.xml and thus reloaded the web application: > > > /404.jsp > > > Accessing a nonexisting page now results in NPE instead of error page > being shown. > After tomcat restart the error-page is shown, until the next reload of > the application: > I've reproduced the issue and run it with a debugger. The above scenario misses step "create 404.jsp". Actually it is more severe. After reload the Mapper$ContextVersion object does not contain information on wrappers (the *wrappers fields in it contain empty lists). Thus after reload *any* page in the examples webapp is inaccessible and results in error 404. (In case of a custom error page "servletContext.getRequestDispatcher(errorPage.getLocation());" call in StandardHostValve.custom() returns null ). Unfortunately, it is [x] Broken - do not release Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.10
2014-07-11 0:22 GMT+04:00 Konstantin Kolinko : > 2014-07-10 22:40 GMT+04:00 Falco Schwarz : >> I am seeing NPEs after reloading a web application with a custom >> . Just downloaded the sample.war, added the following >> block in web.xml and thus reloaded the web application: >> >> >> /404.jsp >> >> >> Accessing a nonexisting page now results in NPE instead of error page >> being shown. >> After tomcat restart the error-page is shown, until the next reload of >> the application: >> > > I've reproduced the issue and run it with a debugger. > The above scenario misses step "create 404.jsp". > > Actually it is more severe. After reload the Mapper$ContextVersion > object does not contain information on wrappers (the *wrappers fields > in it contain empty lists). > > Thus after reload *any* page in the examples webapp is inaccessible > and results in error 404. > > (In case of a custom error page > "servletContext.getRequestDispatcher(errorPage.getLocation());" call > in StandardHostValve.custom() returns null ). > > > Unfortunately, it is > > [x] Broken - do not release > 7.0.x is also affected. I'd be better to retag after the fix. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609566 - in /tomcat/jk/trunk/native/common: jk_ajp_common.c jk_lb_worker.c jk_status.c
Author: rjung
Date: Thu Jul 10 20:34:06 2014
New Revision: 1609566
URL: http://svn.apache.org/r1609566
Log:
Standardize on %d instead of %i on output.
Both should be equivalent for any type of printf,
like the one used in jk_log().
Modified:
tomcat/jk/trunk/native/common/jk_ajp_common.c
tomcat/jk/trunk/native/common/jk_lb_worker.c
tomcat/jk/trunk/native/common/jk_status.c
Modified: tomcat/jk/trunk/native/common/jk_ajp_common.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_ajp_common.c?rev=1609566&r1=1609565&r2=1609566&view=diff
==
--- tomcat/jk/trunk/native/common/jk_ajp_common.c (original)
+++ tomcat/jk/trunk/native/common/jk_ajp_common.c Thu Jul 10 20:34:06 2014
@@ -1976,8 +1976,8 @@ static int ajp_process_callback(jk_msg_b
*/
if (len > (unsigned int)(msg->len - 3)) {
jk_log(l, JK_LOG_ERROR,
- "Chunk length too large. Length of AJP message is %i,"
- " chunk length is %i.", msg->len, len);
+ "Chunk length too large. Length of AJP message is %d,"
+ " chunk length is %d.", msg->len, len);
JK_TRACE_EXIT(l);
return JK_INTERNAL_ERROR;
}
Modified: tomcat/jk/trunk/native/common/jk_lb_worker.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_lb_worker.c?rev=1609566&r1=1609565&r2=1609566&view=diff
==
--- tomcat/jk/trunk/native/common/jk_lb_worker.c (original)
+++ tomcat/jk/trunk/native/common/jk_lb_worker.c Thu Jul 10 20:34:06 2014
@@ -1764,7 +1764,7 @@ static int JK_METHOD validate(jk_worker_
}
if (JK_IS_DEBUG_LEVEL(l)) {
jk_log(l, JK_LOG_DEBUG,
- "Balanced worker %i has name %s and route %s in
domain %s",
+ "Balanced worker %d has name %s and route %s in
domain %s",
i,
p->lb_workers[i].name,
p->lb_workers[i].route,
@@ -1777,7 +1777,7 @@ static int JK_METHOD validate(jk_worker_
for (j = 0; j < i; j++) {
if (strcmp(p->lb_workers[i].route,
p->lb_workers[j].route) == 0) {
jk_log(l, JK_LOG_ERROR,
- "Balanced workers number %i (%s) and %i
(%s) share the same route %s - aborting configuration!",
+ "Balanced workers number %d (%s) and %d
(%s) share the same route %s - aborting configuration!",
i,
p->lb_workers[i].name,
j,
Modified: tomcat/jk/trunk/native/common/jk_status.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_status.c?rev=1609566&r1=1609565&r2=1609566&view=diff
==
--- tomcat/jk/trunk/native/common/jk_status.c (original)
+++ tomcat/jk/trunk/native/common/jk_status.c Thu Jul 10 20:34:06 2014
@@ -3110,7 +3110,7 @@ static void commit_worker(jk_ws_service_
lb->retries, l);
if (i != lb->retries && i > 0) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'retries' for lb worker '%s' to
'%i'",
+ "Status worker '%s' setting 'retries' for lb worker '%s' to
'%d'",
w->name, name, i);
lb->retries = i;
sync_needed = JK_TRUE;
@@ -3119,7 +3119,7 @@ static void commit_worker(jk_ws_service_
lb->retry_interval, l);
if (i != lb->retry_interval && i > 0) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'retry_interval' for lb worker '%s'
to '%i'",
+ "Status worker '%s' setting 'retry_interval' for lb worker '%s'
to '%d'",
w->name, name, i);
lb->retry_interval = i;
sync_needed = JK_TRUE;
@@ -3128,7 +3128,7 @@ static void commit_worker(jk_ws_service_
lb->recover_wait_time, l);
if (i != lb->recover_wait_time && i > 0) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'recover_time' for lb worker '%s'
to '%i'",
+ "Status worker '%s' setting 'recover_time' for lb worker '%s'
to '%d'",
w->name, name, i);
lb->recover_wait_time = i;
sync_needed = JK_TRUE;
@@ -3137,7 +3137,7 @@ static void commit_worker(jk_ws_service_
lb->error_escalation_time, l);
if (i != lb->error_escalation_time && i > 0) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'error_escalation_time' for lb
worker '%s' to '%i'",
+ "Status wor
Re: [VOTE] Release Apache Tomcat 8.0.10
2014-07-10 16:53 GMT+02:00 Mark Thomas :The proposed 8.0.10 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 8.0.10 > Although it is not a blocker since it is not a regression, the NIO2 sendfile code turned out mostly broken. It should now be fixed. Rémy
svn commit: r1609567 - in /tomcat/trunk: java/org/apache/jasper/resources/LocalStrings.properties java/org/apache/jasper/resources/LocalStrings_es.properties webapps/docs/changelog.xml
Author: remm
Date: Thu Jul 10 20:41:14 2014
New Revision: 1609567
URL: http://svn.apache.org/r1609567
Log:
56709: Fix property name is message.
Modified:
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties?rev=1609567&r1=1609566&r2=1609567&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties Thu
Jul 10 20:41:14 2014
@@ -389,7 +389,7 @@ jsp.message.jsp_unload_check=Checking JS
xmlParser.skipBomFail=Failed to skip BOM when parsing XML input stream
-jsp.tldCache.noTldInJar=No TLD files were found in [{0}]. Consider adding the
JAR to the tomcat.util.scan.DefaultJarScanner.jarsToSkip property in
CATALINA_BASE/conf/catalina.properties file.
+jsp.tldCache.noTldInJar=No TLD files were found in [{0}]. Consider adding the
JAR to the tomcat.util.scan.StandardJarScanFilter.jarsToSkip property in
CATALINA_BASE/conf/catalina.properties file.
jsp.tldCache.noTldSummary=At least one JAR was scanned for TLDs yet contained
no TLDs. Enable debug logging for this logger for a complete list of JARs that
were scanned but no TLDs were found in them. Skipping unneeded JARs during
scanning can improve startup time and JSP compilation time.
#ELInterpreter
Modified:
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties?rev=1609567&r1=1609566&r2=1609567&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
(original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
Thu Jul 10 20:41:14 2014
@@ -366,7 +366,7 @@ jsp.message.jsp_removed_excess = Quitand
jsp.message.jsp_removed_idle = Quitando JSP ocioso para ruta [{0}] en contexto
[{1}] tras {2} segundos");
jsp.message.jsp_unload_check = Revisando JSPs para descaga en contexto [{0}],
contador JSP\: {1} tamalo de cola\: {2}
xmlParser.skipBomFail = No pude saltar BOM al analizar flujo de entrada XML
-jsp.tldCache.noTldInJar = No se han hallado ficheros TLD en [{0}]. Considera
a\u00F1adir el JAR a la propiedad tomcat.util.scan.DefaultJarScanner.jarsToSkip
en el fichero CATALINA_BASE/conf/catalina.propeperties.
+jsp.tldCache.noTldInJar = No se han hallado ficheros TLD en [{0}]. Considera
a\u00F1adir el JAR a la propiedad
tomcat.util.scan.StandardJarScanFilter.jarsToSkip en el fichero
CATALINA_BASE/conf/catalina.propeperties.
jsp.tldCache.noTldSummary = Al menos un JAR, que se ha explorado buscando
TLDs, a\u00FAn no conten\u00EDa TLDs. Activar historial de depuraci\u00F3n para
este historiador para una completa lista de los JARs que fueron explorados y de
los que nos se hall\u00F3 TLDs. Saltarse JARs no necesarios durante la
exploraci\u00F3n puede dar lugar a una mejora de tiempo significativa en el
arranque y compilaci\u00F3n de JSP .
#ELInterpreter
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1609567&r1=1609566&r2=1609567&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jul 10 20:41:14 2014
@@ -62,6 +62,13 @@
+
+
+
+56709: Fix property name. Submitted by Robert Kish. (remm)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56709] No TLD files message refers to invalid property DefaultJarScanner.jarsToSkip
https://issues.apache.org/bugzilla/show_bug.cgi?id=56709 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED OS||All --- Comment #1 from Remy Maucherat --- Thanks, it will be included in 8.0.11. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [GUMP@vmgump]: Project tomcat-trunk-test-bio (in module tomcat-trunk) failed
On 10. Juli 2014 10:13:17 MESZ, Konstantin Kolinko wrote: >2014-07-10 7:02 GMT+04:00 Bill Barker : >> To whom it may engage... >> >> This is an automated request, but not an unsolicited one. For >> more information please visit http://gump.apache.org/nagged.html, >> and/or contact the folk at gene...@gump.apache.org. >> >> Project tomcat-trunk-test-bio has an issue affecting its community >integration. >> This issue affects 1 projects, >> and has been outstanding for 6 runs. >> The current state of this project is 'Failed', with reason 'Build >Failed'. >> For reference only, the following projects are affected by this: >> - tomcat-trunk-test-bio : Tomcat 8.x, a web server implementing >the Java Servlet 3.1, >> ... >> >> >> Full details are available at: >> >http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-bio/index.html >> > >Test org.apache.catalina.session.TestPersistentManager FAILED > >[[[ >Testsuite: org.apache.catalina.session.TestPersistentManager >Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.868 >sec >- Standard Error - >10-Jul-2014 02:51:45.769 INFO [main] >org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler >["http-bio-127.0.0.1-auto-1"] >10-Jul-2014 02:51:45.811 INFO [main] >org.apache.catalina.core.StandardService.startInternal Starting >service Tomcat >10-Jul-2014 02:51:45.822 INFO [main] >org.apache.catalina.core.StandardEngine.startInternal Starting Servlet >Engine: Apache Tomcat/8.0.10-dev >10-Jul-2014 02:51:46.116 INFO [main] >org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler >["http-bio-127.0.0.1-auto-1-45846"] >10-Jul-2014 02:51:47.503 INFO [main] >org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler >["http-bio-127.0.0.1-auto-1-45846"] >10-Jul-2014 02:51:47.505 INFO [main] >org.apache.catalina.core.StandardService.stopInternal Stopping service >Tomcat >10-Jul-2014 02:51:47.526 INFO [main] >org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler >["http-bio-127.0.0.1-auto-1-45846"] >10-Jul-2014 02:51:47.527 INFO [main] >org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler >["http-bio-127.0.0.1-auto-1-45846"] >- --- > >Testcase: backsUpOnce took 2.848 sec >FAILED >expected:<[4AC2976017F91624B46E2D7D78F6ABE8]> but was:<[]> >junit.framework.AssertionFailedError: >expected:<[4AC2976017F91624B46E2D7D78F6ABE8]> but was:<[]> >at >org.apache.catalina.session.TestPersistentManager.backsUpOnce(TestPersistentManager.java:88) >]]] We might have to bump up the sleep time a little bit (one second now). PersistentManager will save the session only if it seems to be older than one second. Regards Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56658] Concurrency issue with wrapper mappings in Mapper
https://issues.apache.org/bugzilla/show_bug.cgi?id=56658
Konstantin Kolinko changed:
What|Removed |Added
Component|Catalina|Catalina
Version|6.0.41 |8.0.9
Product|Tomcat 6|Tomcat 8
Target Milestone|default |
--- Comment #3 from Konstantin Kolinko ---
The fix for this issue caused a regression for web application reload.
(It was reported on the [VOTE] thread for 8.0.10 release candidate).
Steps to reproduce:
1. Start Tomcat
2. Open http://localhost:8080/examples/index.html
The page loads, as expected.
3. Touch $CATALINA_BASE/webapps/examples/WEB-INF/web.xml. This causes reload of
the examples webapp.
4. Wait until reload of examples webapp completes successfully.
5. Refresh (Ctrl+F5) http://localhost:8080/examples/index.html
Expected: the page
Actual: error 404
>From debugging:
---
After reload the lists of wrappers in MApper$ContextVersion object for this web
application are empty. In other words, none of the servlets of this webapp are
registered with the the mapper.
The cause:
---
Old code did
[[[
mapper.addContextVersion(...);
for (Container container : context.findChildren()) {
registerWrapper((Wrapper) container);
}
]]]
The first call "addContextVersion(...)" after reload tried to re-register the
same context with the mapper. As the context has already been registered, the
call actually failed, but subsequent "registerWrapper()" calls did work
successfully.
The new code essentially skips registration of wrappers if "addContextVersion"
fails.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Time for 7.0.55
Hi,
2014-07-09 21:10 GMT+03:00 Violeta Georgieva :
>
>
> Hi,
>
> 2014-07-09 17:35 GMT+03:00 Konstantin Kolinko :
>
> >
> > 2014-07-09 6:39 GMT+04:00 Konstantin Kolinko :
> > > 2014-07-08 13:45 GMT+04:00 Konstantin Kolinko :
> > >> 2014-07-08 13:17 GMT+04:00 Mark Thomas :
> > >>> On 27/06/2014 17:20, Konstantin Kolinko wrote:
> > 2014-06-27 18:16 GMT+04:00 Mark Thomas :
> > > On 23/06/2014 14:00, Violeta Georgieva wrote:
> > >> 2014-06-22 21:33 GMT+03:00 Konstantin Kolinko
> > Mapper issues:
> > BZ 44312: Fixed. Proposed for 6.0.
> >
> > BZ 56653: Fix re-implemented in Tomcat 8 to be less intrusive.
> > Not backported.
> > I backported testcase for it (r1604846), but neither Gump nor
Testbot
> > fail with it.
> >
> > BZ 56658: Not started.
> >
> > I plan to work on Mapper tonight and tomorrow.
> > >>>
> > >>> Any progress on this? Looking at Bugzilla, these are the only open
> > >>> issues for 7.0.x and I assume we want to resolve them before a
7.0.55 tag.
> > >>
> > >> All are fixed in Tomcat 8 a week ago.
> > >>
> > >> I shall backport 56653, 56658 to Tomcat 7 today.
> > >>
> > >
> > > Issue 56653 fixed. This leaves 56658.
> >
> > Issue 56658 fixed.
> >
> > Mapper issues fixed. I did run testsuite with NIO connector - all OK.
> >
> > I think we are OK to go with a release.
>
> Thanks a lot.
> I'll start the tagging tomorrow.
I'm receiving the following exception:
[exec] [junit] Jul 10, 2014 11:33:16 PM
org.apache.coyote.http11.AbstractHttp11Processor process
[exec] [junit] SEVERE: Error processing request
[exec] [junit] java.lang.ArrayIndexOutOfBoundsException: -1
[exec] [junit] at
org.apache.tomcat.util.http.mapper.Mapper.internalMap(Mapper.java:785)
[exec] [junit] at
org.apache.tomcat.util.http.mapper.Mapper.map(Mapper.java:662)
[exec] [junit] at
org.apache.catalina.connector.CoyoteAdapter.postParseRequest(CoyoteAdapter.java:714)
[exec] [junit] at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:403)
[exec] [junit] at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1070)
[exec] [junit] at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:611)
[exec] [junit] at
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:314)
[exec] [junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
[exec] [junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
[exec] [junit] at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
[exec] [junit] at java.lang.Thread.run(Thread.java:662)
The following "quick" patch fixes the problem:
Index: C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java
===
--- C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java (revision
1609565)
+++ C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java (working
copy)
@@ -779,18 +779,21 @@
if (version != null) {
contextVersion = exactFind(contextVersions, version);
}
+if (contextVersion == null) {
+// Return the latest version
+contextVersion = contextVersions[versionCount - 1];
+}
+} else if (versionCount == 1) {
+contextVersion = contextVersions[0];
}
-if (contextVersion == null) {
-// Return the latest version
-contextVersion = contextVersions[versionCount - 1];
+
+if (contextVersion != null) {
+mappingData.context = contextVersion.object;
+mappingData.contextSlashCount = contextVersion.slashCount;
+// Wrapper mapping
+internalMapWrapper(contextVersion, uri, mappingData);
}
-mappingData.context = contextVersion.object;
-mappingData.contextSlashCount = contextVersion.slashCount;
-
-// Wrapper mapping
-internalMapWrapper(contextVersion, uri, mappingData);
-
}
>
> Regards,
> Violeta
>
> >
> > Best regards,
> > Konstantin Kolinko
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
[Bug 56710] New: IllegalStateException: The resources may not be accessed during webapp reload
https://issues.apache.org/bugzilla/show_bug.cgi?id=56710 Bug ID: 56710 Summary: IllegalStateException: The resources may not be accessed during webapp reload Product: Tomcat 8 Version: 8.0.9 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: knst.koli...@gmail.com I encountered this while testing 8.0.10 release candidate while investigating bug 56658 regression. Steps to reproduce - see Comment 3 in bug 56658, but skip step 4, https://issues.apache.org/bugzilla/show_bug.cgi?id=56658#c3 That is: cause reload of the examples webapp, but ask for "index.html" while reloading has not been completed yet. Expected: The request shall wait for web application reload to complete and then display the page (or error 404 in case of that bug that I was investigating). There is a loop in CoyoteAdapter that waits while context is being reloaded. Actual: A blank page is rendered, and an IllegalStateException is logged. A snippet from catalina.2014-07-11.log: [[[ 11-Jul-2014 00:45:08.124 INFO [ContainerBackgroundProcessor[StandardEngine[Catalina]]] org.apache.catalina.startup.HostConfig.reload Reloading context [/examples] 11-Jul-2014 00:45:08.125 INFO [ContainerBackgroundProcessor[StandardEngine[Catalina]]] org.apache.catalina.core.StandardContext.reload Reloading Context with name [/examples] has started 11-Jul-2014 00:45:08.164 SEVERE [http-nio-8080-exec-1] org.apache.coyote.http11.AbstractHttp11Processor.process Error processing request java.lang.IllegalStateException: The resources may not be accessed if they are not currently started at org.apache.catalina.webresources.StandardRoot.validate(StandardRoot.java:245) at org.apache.catalina.webresources.StandardRoot.getResource(StandardRoot.java:212) at org.apache.catalina.webresources.StandardRoot.getResource(StandardRoot.java:206) at org.apache.catalina.mapper.Mapper.internalMapWrapper(Mapper.java:946) at org.apache.catalina.mapper.Mapper.internalMap(Mapper.java:765) at org.apache.catalina.mapper.Mapper.map(Mapper.java:635) at org.apache.catalina.connector.CoyoteAdapter.postParseRequest(CoyoteAdapter.java:861) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:521) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1078) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:658) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:222) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1566) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1523) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) at java.lang.Thread.run(Thread.java:745) 11-Jul-2014 00:45:09.007 INFO [ContainerBackgroundProcessor[StandardEngine[Catalina]]] org.apache.catalina.core.StandardContext.reload Reloading Context with name [/examples] is completed ]]] A snippet from localhost.2014-07-11.log: [[[ 127.0.0.1 - - [11/Jul/2014:00:44:10 +0400] "GET /examples/index.html HTTP/1.1" 200 1156 127.0.0.1 - - [11/Jul/2014:00:44:21 +0400] "GET /examples/index.html HTTP/1.1" 304 - 127.0.0.1 - - [11/Jul/2014:00:44:21 +0400] "GET /favicon.ico HTTP/1.1" 304 - 127.0.0.1 - - [11/Jul/2014:00:44:24 +0400] "GET /examples/index.html HTTP/1.1" 304 - 127.0.0.1 - - [11/Jul/2014:00:44:50 +0400] "GET /examples/index.html HTTP/1.1" 404 1000 127.0.0.1 - - [11/Jul/2014:00:44:50 +0400] "GET /favicon.ico HTTP/1.1" 304 - 127.0.0.1 - - [11/Jul/2014:00:45:08 +0400] "GET /examples/index.html HTTP/1.1" 500 - 127.0.0.1 - - [11/Jul/2014:00:45:11 +0400] "GET /examples/index.html HTTP/1.1" 404 1000 127.0.0.1 - - [11/Jul/2014:00:45:16 +0400] "GET /examples/index.html HTTP/1.1" 404 1000 ]]] The 404 are from the bug that I was investigating. The 500 is from this bug. I was running with jpda debugging enabled, so webapp reload was a bit slower than usual. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Time for 7.0.55
2014-07-11 1:05 GMT+04:00 Violeta Georgieva :
> Hi,
>
> I'm receiving the following exception:
>
> [exec] [junit] Jul 10, 2014 11:33:16 PM
> org.apache.coyote.http11.AbstractHttp11Processor process
> [exec] [junit] SEVERE: Error processing request
> [exec] [junit] java.lang.ArrayIndexOutOfBoundsException: -1
> [exec] [junit] at
> org.apache.tomcat.util.http.mapper.Mapper.internalMap(Mapper.java:785)
The line Mapper.java:785 in 7.0.x is
"contextVersion = contextVersions[versionCount - 1];"
so "versionCount" which is equal to "contextVersions.length" is 0.
Actually I supposed that contextVersions array always has at least one element.
There is a bug in Mapper.removeContextVersion().
326: if (context.versions.length == 0) {
The line was supposed to be "if (newContextVersions.length == 0)".
This explains the zero-length array.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609574 - in /tomcat/jk/trunk: native/common/jk_status.c xdocs/miscellaneous/changelog.xml
Author: rjung
Date: Thu Jul 10 21:34:03 2014
New Revision: 1609574
URL: http://svn.apache.org/r1609574
Log:
BZ 56667: Status: Fix log message when changing activation
state of all members.
Modified:
tomcat/jk/trunk/native/common/jk_status.c
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Modified: tomcat/jk/trunk/native/common/jk_status.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_status.c?rev=1609574&r1=1609573&r2=1609574&view=diff
==
--- tomcat/jk/trunk/native/common/jk_status.c (original)
+++ tomcat/jk/trunk/native/common/jk_status.c Thu Jul 10 21:34:03 2014
@@ -3601,10 +3601,10 @@ static void commit_all_members(jk_ws_ser
if (rv == JK_TRUE) {
i = jk_lb_get_activation_code(arg);
if (i != wr->activation && i >= 0 && i <=
JK_LB_ACTIVATION_MAX) {
+wr->activation = i;
jk_log(l, JK_LOG_INFO,
"Status worker '%s' setting 'activation'
for sub worker '%s' of lb worker '%s' to '%s'",
w->name, wr->name, name,
jk_lb_get_activation(wr, l));
-wr->activation = i;
rc = 1;
sync_needed = JK_TRUE;
}
Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1609574&r1=1609573&r2=1609574&view=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Thu Jul 10 21:34:03 2014
@@ -45,6 +45,10 @@
+56667: Status: Fix log message when changing activation
+state of all members. (rjung)
+
+
56565: Fix IPV6 address resolve on non-dual
network stacks. (mturk)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609575 - in /tomcat/jk/trunk/native/common: jk_lb_worker.c jk_lb_worker.h
Author: rjung
Date: Thu Jul 10 21:36:08 2014
New Revision: 1609575
URL: http://svn.apache.org/r1609575
Log:
Add utility methods.
Will be used in status worker during logging.
Modified:
tomcat/jk/trunk/native/common/jk_lb_worker.c
tomcat/jk/trunk/native/common/jk_lb_worker.h
Modified: tomcat/jk/trunk/native/common/jk_lb_worker.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_lb_worker.c?rev=1609575&r1=1609574&r2=1609575&view=diff
==
--- tomcat/jk/trunk/native/common/jk_lb_worker.c (original)
+++ tomcat/jk/trunk/native/common/jk_lb_worker.c Thu Jul 10 21:36:08 2014
@@ -150,6 +150,14 @@ static jk_uint64_t scm(jk_uint64_t a, jk
}
/* Return the string representation of the lb lock type */
+/* based on the integer representation */
+const char *jk_lb_get_lock_direct(int lblock, jk_logger_t *l)
+{
+return lb_locking_type[lblock];
+}
+
+/* Return the string representation of the lb lock type */
+/* based on the lb worker struct */
const char *jk_lb_get_lock(lb_worker_t *p, jk_logger_t *l)
{
return lb_locking_type[p->lblock];
@@ -168,6 +176,14 @@ int jk_lb_get_lock_code(const char *v)
}
/* Return the string representation of the lb method type */
+/* based on the integer representation */
+const char *jk_lb_get_method_direct(int lbmethod, jk_logger_t *l)
+{
+return lb_method_type[lbmethod];
+}
+
+/* Return the string representation of the lb method type */
+/* based on the lb worker struct */
const char *jk_lb_get_method(lb_worker_t *p, jk_logger_t *l)
{
return lb_method_type[p->lbmethod];
@@ -192,6 +208,14 @@ int jk_lb_get_method_code(const char *v)
}
/* Return the string representation of the balance worker state */
+/* based on the integer representation */
+const char *jk_lb_get_state_direct(int state, jk_logger_t *l)
+{
+return lb_state_type[state];
+}
+
+/* Return the string representation of the balance worker state */
+/* based on the sub worker struct */
const char *jk_lb_get_state(lb_sub_worker_t *p, jk_logger_t *l)
{
return lb_state_type[p->s->state];
Modified: tomcat/jk/trunk/native/common/jk_lb_worker.h
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_lb_worker.h?rev=1609575&r1=1609574&r2=1609575&view=diff
==
--- tomcat/jk/trunk/native/common/jk_lb_worker.h (original)
+++ tomcat/jk/trunk/native/common/jk_lb_worker.h Thu Jul 10 21:36:08 2014
@@ -208,10 +208,13 @@ typedef struct lb_worker lb_worker_t;
int JK_METHOD lb_worker_factory(jk_worker_t **w,
const char *name, jk_logger_t *l);
+const char *jk_lb_get_lock_direct(int lblock, jk_logger_t *l);
const char *jk_lb_get_lock(lb_worker_t *p, jk_logger_t *l);
int jk_lb_get_lock_code(const char *v);
+const char *jk_lb_get_method_direct(int lbmethod, jk_logger_t *l);
const char *jk_lb_get_method(lb_worker_t *p, jk_logger_t *l);
int jk_lb_get_method_code(const char *v);
+const char *jk_lb_get_state_direct(int state, jk_logger_t *l);
const char *jk_lb_get_state(lb_sub_worker_t *p, jk_logger_t *l);
int jk_lb_get_state_code(const char *v);
const char *jk_lb_get_activation_direct(int activation, jk_logger_t *l);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609576 - in /tomcat/jk/trunk: native/common/jk_status.c xdocs/miscellaneous/changelog.xml
Author: rjung
Date: Thu Jul 10 21:39:10 2014
New Revision: 1609576
URL: http://svn.apache.org/r1609576
Log:
Log old and new values when changing worker attributes
via the status worker.
Modified:
tomcat/jk/trunk/native/common/jk_status.c
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Modified: tomcat/jk/trunk/native/common/jk_status.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_status.c?rev=1609576&r1=1609575&r2=1609576&view=diff
==
--- tomcat/jk/trunk/native/common/jk_status.c (original)
+++ tomcat/jk/trunk/native/common/jk_status.c Thu Jul 10 21:39:10 2014
@@ -3110,8 +3110,8 @@ static void commit_worker(jk_ws_service_
lb->retries, l);
if (i != lb->retries && i > 0) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'retries' for lb worker '%s' to
'%d'",
- w->name, name, i);
+ "Status worker '%s' changing 'retries' for lb worker '%s' from
'%d' to '%d'",
+ w->name, name, lb->retries, i);
lb->retries = i;
sync_needed = JK_TRUE;
}
@@ -3119,8 +3119,8 @@ static void commit_worker(jk_ws_service_
lb->retry_interval, l);
if (i != lb->retry_interval && i > 0) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'retry_interval' for lb worker '%s'
to '%d'",
- w->name, name, i);
+ "Status worker '%s' changing 'retry_interval' for lb worker
'%s' from '%d' to '%d'",
+ w->name, name, lb->retry_interval, i);
lb->retry_interval = i;
sync_needed = JK_TRUE;
}
@@ -3128,8 +3128,8 @@ static void commit_worker(jk_ws_service_
lb->recover_wait_time, l);
if (i != lb->recover_wait_time && i > 0) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'recover_time' for lb worker '%s'
to '%d'",
- w->name, name, i);
+ "Status worker '%s' changing 'recover_time' for lb worker '%s'
from '%d' to '%d'",
+ w->name, name, lb->recover_wait_time, i);
lb->recover_wait_time = i;
sync_needed = JK_TRUE;
}
@@ -3137,8 +3137,8 @@ static void commit_worker(jk_ws_service_
lb->error_escalation_time, l);
if (i != lb->error_escalation_time && i > 0) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'error_escalation_time' for lb
worker '%s' to '%d'",
- w->name, name, i);
+ "Status worker '%s' changing 'error_escalation_time' for lb
worker '%s' from '%d' to '%d'",
+ w->name, name, lb->error_escalation_time, i);
lb->error_escalation_time = i;
sync_needed = JK_TRUE;
}
@@ -3146,24 +3146,24 @@ static void commit_worker(jk_ws_service_
lb->max_reply_timeouts, l);
if (i != lb->max_reply_timeouts && i >= 0) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'max_reply_timeouts' for lb worker
'%s' to '%d'",
- w->name, name, i);
+ "Status worker '%s' changing 'max_reply_timeouts' for lb worker
'%s' from '%d' to '%d'",
+ w->name, name, lb->max_reply_timeouts, i);
lb->max_reply_timeouts = i;
sync_needed = JK_TRUE;
}
i = status_get_bool(p, JK_STATUS_ARG_LB_STICKY, lb->sticky_session, l);
if (i != lb->sticky_session) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'sticky_session' for lb worker '%s'
to '%d'",
- w->name, name, i);
+ "Status worker '%s' changing 'sticky_session' for lb worker
'%s' from '%d' to '%d'",
+ w->name, name, lb->sticky_session, i);
lb->sticky_session = i;
sync_needed = JK_TRUE;
}
i = status_get_bool(p, JK_STATUS_ARG_LB_STICKY_FORCE,
lb->sticky_session_force, l);
if (i != lb->sticky_session_force) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'sticky_session_force' for lb
worker '%s' to '%d'",
- w->name, name, i);
+ "Status worker '%s' changing 'sticky_session_force' for lb
worker '%s' from '%d' to '%d'",
+ w->name, name, lb->sticky_session_force, i);
lb->sticky_session_force = i;
sync_needed = JK_TRUE;
}
@@ -3171,8 +3171,8 @@ static void commit_worker(jk_ws_service_
i = jk_lb_get_method_code(arg);
if (i != lb->lbmethod && i >= 0 && i <= JK_LB_METHOD_MAX) {
jk_log(l, JK_LOG_INFO,
- "Status worker '%s' setting 'method' for lb worker '%s' to
'%s'",
- w->name, name, jk_lb_get_method(lb, l));
+ "Status worker '%s' changing 'method' for lb worker '%s'
from '%s' to '%s'",
+ w->name, name, jk_lb_get_method(lb, l),
jk_lb_get_m
[Bug 56667] "commit_all_members" logs wrong "to" activation state
https://issues.apache.org/bugzilla/show_bug.cgi?id=56667 Rainer Jung changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Rainer Jung --- Thanks for the report. I fixed the wrong log message in r1609574, but also took the opportunity to add logging of old and new values to all 22 log statements in status worker that trigger on attribute changes. Those are the changes r1609566, r1609575 and r1609576. It would be nice, if you could give it a try. Regards, Rainer -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56710] IllegalStateException: The resources may not be accessed during webapp reload
https://issues.apache.org/bugzilla/show_bug.cgi?id=56710 Remy Maucherat changed: What|Removed |Added OS||All --- Comment #1 from Remy Maucherat --- "Expected: The request shall wait for web application reload to complete and then display the page (or error 404 in case of that bug that I was investigating). There is a loop in CoyoteAdapter that waits while context is being reloaded." This feature is actually a bug, the server should return a response and move on. It is not a good idea to tie up an indefinite amount of requests/threads waiting for something to happen. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.10
2014-07-11 0:27 GMT+04:00 Konstantin Kolinko : > 2014-07-11 0:22 GMT+04:00 Konstantin Kolinko : >> 2014-07-10 22:40 GMT+04:00 Falco Schwarz : >>> I am seeing NPEs after reloading a web application with a custom >>> . Just downloaded the sample.war, added the following >>> block in web.xml and thus reloaded the web application: >>> >> (...) >> >> Actually it is more severe. After reload the Mapper$ContextVersion >> object does not contain information on wrappers (the *wrappers fields >> in it contain empty lists). >> >> Thus after reload *any* page in the examples webapp is inaccessible >> and results in error 404. >> >> (In case of a custom error page >> "servletContext.getRequestDispatcher(errorPage.getLocation());" call >> in StandardHostValve.custom() returns null ). >> >> >> Unfortunately, it is >> >> [x] Broken - do not release >> > > 7.0.x is also affected. I'd be better to retag after the fix. > Thus far on the Mapper issues 1) This issue is regression from BZ 56658. I documented it there, https://issues.apache.org/bugzilla/show_bug.cgi?id=56658#c3 I think I know how to fix it. 2) I encountered another issue - BZ 56710 >From the look at it I think that it existed for previous versions as well. I wonder why nobody reported it. I have no idea on a fix yet. 3) Issue that Violetta reported in the "Time for 7.0.55" thread, http://markmail.org/message/57vijgczkqn4aopx I think I know how to fix it. Needs a test case. I wonder why I have not seen it during my test runs. 4) Searching for string "Mapper" across junit logs from a full TC7 test run, I see a lot of messages like Jul 09, 2014 5:19:56 PM org.apache.tomcat.util.http.mapper.Mapper findContextVersion SEVERE: No context version found: /test (The above one is from org.apache.catalina.core.TestStandardContextResources) This needs some investigation. An easy solution is to suppress those messages. (7.0.54 had those messages, but the code to display them was broken). I do not have much time tomorrow, but I will try something. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56710] IllegalStateException: The resources may not be accessed during webapp reload
https://issues.apache.org/bugzilla/show_bug.cgi?id=56710 --- Comment #2 from Konstantin Kolinko --- (In reply to Remy Maucherat from comment #1) > It is not a good idea (...) Ack, but some people find it useful. See bug 53024 that asked for it. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609589 - in /tomcat/jk/trunk: native/apache-1.3/ native/apache-2.0/ native/common/ native/iis/ native/netscape/ xdocs/generic_howto/ xdocs/miscellaneous/ xdocs/reference/
Author: rjung
Date: Thu Jul 10 23:27:52 2014
New Revision: 1609589
URL: http://svn.apache.org/r1609589
Log:
BZ 56661: Fix Servlet API getLocalAddr().
Forward local IP address which is not part of AJP protocol
via custom request attribute named "AJP_LOCAL_ADDR".
Currently Tomcat will handle getLocalAddr(U) like getLocalName().
Tomcat versions can now check for the new attribute and use it
if available.
Likely to be used by forthcoming TC 6.0.41, 7.0.55 and 8.0.11.
Modified:
tomcat/jk/trunk/native/apache-1.3/mod_jk.c
tomcat/jk/trunk/native/apache-2.0/mod_jk.c
tomcat/jk/trunk/native/common/jk_ajp_common.c
tomcat/jk/trunk/native/common/jk_ajp_common.h
tomcat/jk/trunk/native/common/jk_service.h
tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
tomcat/jk/trunk/native/netscape/jk_nsapi_plugin.c
tomcat/jk/trunk/xdocs/generic_howto/proxy.xml
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
tomcat/jk/trunk/xdocs/reference/apache.xml
Modified: tomcat/jk/trunk/native/apache-1.3/mod_jk.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/apache-1.3/mod_jk.c?rev=1609589&r1=1609588&r2=1609589&view=diff
==
--- tomcat/jk/trunk/native/apache-1.3/mod_jk.c (original)
+++ tomcat/jk/trunk/native/apache-1.3/mod_jk.c Thu Jul 10 23:27:52 2014
@@ -71,6 +71,7 @@
#define JK_ENV_REMOTE_USER ("JK_REMOTE_USER")
#define JK_ENV_AUTH_TYPE("JK_AUTH_TYPE")
#define JK_ENV_LOCAL_NAME ("JK_LOCAL_NAME")
+#define JK_ENV_LOCAL_ADDR ("JK_LOCAL_ADDR")
#define JK_ENV_LOCAL_PORT ("JK_LOCAL_PORT")
#define JK_ENV_HTTPS("HTTPS")
#define JK_ENV_CERTS("SSL_CLIENT_CERT")
@@ -181,6 +182,7 @@ typedef struct
char *remote_user_indicator;
char *auth_type_indicator;
char *local_name_indicator;
+char *local_addr_indicator;
char *local_port_indicator;
/*
@@ -827,6 +829,12 @@ static int init_ws_service(apache_privat
s->server_name = get_env_string(r, (char *)ap_get_server_name(r),
conf->local_name_indicator, 0);
+/* get the local IP address */
+/* s->local_addr = r->connection->local_ip; */
+/* XXX : a la jk2 */
+s->local_addr = get_env_string(r, r->connection->local_ip,
+ conf->local_addr_indicator, 0);
+
/* get the real port (otherwise redirect failed) */
/* s->server_port = htons( r->connection->local_addr.sin_port ); */
/* XXX : a la jk2 */
@@ -1906,6 +1914,16 @@ static const char *jk_set_local_name_ind
return NULL;
}
+static const char *jk_set_local_addr_indicator(cmd_parms * cmd,
+ void *dummy, char *indicator)
+{
+server_rec *s = cmd->server;
+jk_server_conf_t *conf =
+(jk_server_conf_t *) ap_get_module_config(s->module_config,
&jk_module);
+conf->local_addr_indicator = ap_pstrdup(cmd->pool, indicator);
+return NULL;
+}
+
static const char *jk_set_local_port_indicator(cmd_parms * cmd,
void *dummy, char *indicator)
{
@@ -2315,6 +2333,8 @@ static const command_rec jk_cmds[] = {
"Name of the Apache environment that contains the type of
authentication"},
{"JkLocalNameIndicator", jk_set_local_name_indicator, NULL, RSRC_CONF,
TAKE1,
"Name of the Apache environment that contains the local name"},
+{"JkLocalAddrIndicator", jk_set_local_addr_indicator, NULL, RSRC_CONF,
TAKE1,
+ "Name of the Apache environment that contains the local IP address"},
{"JkLocalPortIndicator", jk_set_local_port_indicator, NULL, RSRC_CONF,
TAKE1,
"Name of the Apache environment that contains the local port"},
@@ -2667,6 +2687,7 @@ static void *create_jk_config(ap_pool *
c->remote_user_indicator = JK_ENV_REMOTE_USER;
c->auth_type_indicator = JK_ENV_AUTH_TYPE;
c->local_name_indicator = JK_ENV_LOCAL_NAME;
+c->local_addr_indicator = JK_ENV_LOCAL_ADDR;
c->local_port_indicator = JK_ENV_LOCAL_PORT;
/*
Modified: tomcat/jk/trunk/native/apache-2.0/mod_jk.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/apache-2.0/mod_jk.c?rev=1609589&r1=1609588&r2=1609589&view=diff
==
--- tomcat/jk/trunk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/jk/trunk/native/apache-2.0/mod_jk.c Thu Jul 10 23:27:52 2014
@@ -106,6 +106,7 @@
#define JK_ENV_REMOTE_USER ("JK_REMOTE_USER")
#define JK_ENV_AUTH_TYPE("JK_AUTH_TYPE")
#define JK_ENV_LOCAL_NAME ("JK_LOCAL_NAME")
+#define JK_ENV_LOCAL_ADDR ("JK_LOCAL_ADDR")
#define JK_ENV_LOCAL_PORT ("JK_LOCAL_PORT")
#define JK_ENV_HTTPS("HTTPS")
#define JK_ENV_CERTS("SSL_CLIENT_CERT")
@@ -211,6 +212,7 @@ typedef struct
char *remot
[Bug 56661] ServletRequest#getLocalAddr() returns the hostname, not the IP address
https://issues.apache.org/bugzilla/show_bug.cgi?id=56661 Rainer Jung changed: What|Removed |Added Component|mod_jk |Connectors Version|1.2.40 |trunk Product|Tomcat Connectors |Tomcat 8 Target Milestone|--- | --- Comment #13 from Rainer Jung --- Implemented new request attribute "AJP_LOCAL_ADDR" in mod_jk r1609589. Will be part of version 1.2.41. Assigning issue back to Tomcat for implementing the use of the new attribute. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609593 - in /tomcat/trunk/java/org/apache/coyote/ajp: AbstractAjpProcessor.java Constants.java
Author: rjung
Date: Thu Jul 10 23:52:22 2014
New Revision: 1609593
URL: http://svn.apache.org/r1609593
Log:
BZ 56661: Fix Servlet API getLocalAddr().
Use new custom request attribute "AJP_LOCAL_ADDR"
forwarded by the next mod_jk 1.2.41 to set the local
IP address returned by getLocalAddr():
Before this change Tomcat handled getLocalAddr() like
getLocalName().
Needs some testing before backport.
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
tomcat/trunk/java/org/apache/coyote/ajp/Constants.java
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java?rev=1609593&r1=1609592&r2=1609593&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java Thu Jul
10 23:52:22 2014
@@ -486,13 +486,17 @@ public abstract class AbstractAjpProcess
break;
}
case REQ_LOCAL_ADDR_ATTRIBUTE: {
-// Copy from local name for now, which should simply be an address
-request.localAddr().setString(request.localName().toString());
+// Automatically populated during prepareRequest() when using
+// modern AJP forwarder, otherwise copy from local name
+if (request.localAddr().isNull()) {
+request.localAddr().setString(request.localName().toString());
+}
break;
}
case REQ_REMOTEPORT_ATTRIBUTE: {
// NO-OP
-// This information is not available when using the AJP protocol
+// Automatically populated during prepareRequest() when using
+// modern AJP forwarder, otherwise not available
break;
}
case REQ_LOCALPORT_ATTRIBUTE: {
@@ -1221,13 +1225,15 @@ public abstract class AbstractAjpProcess
requestHeaderMessage.getBytes(tmpMB);
String v = tmpMB.toString();
/*
- * AJP13 misses to forward the remotePort.
- * Allow the AJP connector to add this info via
- * a private request attribute.
- * We will accept the forwarded data as the remote port,
- * and remove it from the public list of request attributes.
+ * AJP13 misses to forward the local IP address and the
+ * remote port. Allow the AJP connector to add this info via
+ * private request attributes.
+ * We will accept the forwarded data and remove it from the
+ * public list of request attributes.
*/
-if(n.equals(Constants.SC_A_REQ_REMOTE_PORT)) {
+if(n.equals(Constants.SC_A_REQ_LOCAL_ADDR)) {
+request.localAddr().setString(v);
+} else if(n.equals(Constants.SC_A_REQ_REMOTE_PORT)) {
try {
request.setRemotePort(Integer.parseInt(v));
} catch (NumberFormatException nfe) {
Modified: tomcat/trunk/java/org/apache/coyote/ajp/Constants.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/Constants.java?rev=1609593&r1=1609592&r2=1609593&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/Constants.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/Constants.java Thu Jul 10 23:52:22
2014
@@ -81,6 +81,7 @@ public final class Constants {
/**
* AJP private request attributes
*/
+public static final String SC_A_REQ_LOCAL_ADDR = "AJP_LOCAL_ADDR";
public static final String SC_A_REQ_REMOTE_PORT = "AJP_REMOTE_PORT";
// Terminates list of attributes
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56661] ServletRequest#getLocalAddr() returns the hostname, not the IP address
https://issues.apache.org/bugzilla/show_bug.cgi?id=56661 --- Comment #14 from Rainer Jung --- I added support for the new attribute to TC 8 in r1609593. Needs some more testing before porting back to TC7 an probably 6. A full test needs a dev build of mod_jk r1609589 or later. Alternatively one can try in Apache: SetEnvIf Server_Addr "(.*)" AJP_LOCAL_ADDR=$1 JkEnvVar AJP_LOCAL_ADDR Which for current releases of mod_jk would send a request attribute named AJP_LOCAL_ADDR with its value set to the value of the Apache internal variable SERVER_ADDR which in turn contains the local IP address of Apache. Starting with mod_jk 1.2.41 the attribute will be set without explicit configuration. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Working tc native build
On 08.07.2014 18:14, Mark Thomas wrote: On 08/07/2014 16:39, Christopher Schultz wrote: Anyway, here's what the above tool says tcnative-1.dll requires in terms of direct dependencies: - USER32.dll - PSAPI.dll - SHLWAPI.dll - KERNEL32.dll - ADVAPI32.dll - WS2_32.dll - MSWSOCK.dll - MSVCR100.dll Is that last one the one you were concerned about? Yes. If so, what's the procedure for statically-linking that library into tcnative ... or, better yet, why is that library not necessary when using MSVS 2006 or whatever? Using VS6 or Mladen's toolkit, it builds against msvcrt.dll which is part of the base OS. For reasons I haven't dug into, later versions of Visual Studio build upon a newer version of that library and despite quite a lot of searching I haven't found a way to make later versions of Visual Studio build against the older dll. The dependency on the modern (versioned) msvcrXXX.dll only gets problematic when you need to mix binaries and libs build with different MSVC versions in the same process. For instance building modules for the Apache web server and the server itself with different MSVC versions can get you in trouble, because the msvcrXXX.dll version depends 1:1 on the MSVC version and different versions of the lib are not expected to interact nicely in the same process. In the tcnative case, this would only happen, if either the jvm itself or another native agent or library loaded into the jvm would be linked against a different msvcrXXX.dll. Concerning agents we can't be safe because we can't control what users load. Concerning the jvm I did a quick check with 1.7.0_51 64 bit on Windows 7 and depends.exe show the dependency to msvcr100.dll in bin/server/jvm.dll. The same for Java 8. So to me it looks one can only either use the old way of building against the old msvcrt.dll without version - which seems to be no longer really supported and might vanish - or sync on the msvc version that is used to build the jvm and hope they keep it stable per jvm major version. For end users the dependency on the dll is not a big problem, because Microsoft provides it for redistribution or download. Of course we can't bundle it due to license incompatibility. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 30 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20140711.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/tar get/commons-exec-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20140711.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20140711.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-20140711.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-18.0-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar setproxy: downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle [checkstyle] Running Checkstyle 5.8-SNAPSHOT on 2904 files [checkstyle] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java:966: Line matches the illegal pattern '\s+$'. BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:539: Got 1 errors and 0 warnings. Total time: 30 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2014071112, vmgump.apache.org:vmgump:2014071112 Gump E-mail Identifier (unique within run) #5. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609601 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
Author: rjung
Date: Fri Jul 11 01:16:51 2014
New Revision: 1609601
URL: http://svn.apache.org/r1609601
Log:
Remove trailing space to please Checkstyle and Gump.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java?rev=1609601&r1=1609600&r2=1609601&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Fri Jul 11
01:16:51 2014
@@ -963,7 +963,7 @@ public class Nio2Endpoint extends Abstra
}
}
};
-
+
public SendfileState processSendfile(Nio2SocketWrapper socket) {
// Configure the send file data
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609604 - /tomcat/trunk/webapps/docs/changelog.xml
Author: rjung Date: Fri Jul 11 01:28:48 2014 New Revision: 1609604 URL: http://svn.apache.org/r1609604 Log: Add changelog entry for BZ56661, r1609593. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1609604&r1=1609603&r2=1609604&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Fri Jul 11 01:28:48 2014 @@ -60,6 +60,11 @@ will now instead use the regular socket write buffer as configured. (remm) + +56661: Fix getLocalAddr() for AJP connectors. +The complete fix is only available with a recent AJP forwarder like +the forthcoming mod_jk 1.2.41. (rjung) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609606 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/AbstractAjpProcessor.java java/org/apache/coyote/ajp/Constants.java webapps/docs/changelog.xml
Author: rjung
Date: Fri Jul 11 01:43:33 2014
New Revision: 1609606
URL: http://svn.apache.org/r1609606
Log:
BZ 56661: Fix Servlet API getLocalAddr().
Use new custom request attribute "AJP_LOCAL_ADDR"
forwarded by the next mod_jk 1.2.41 to set the local
IP address returned by getLocalAddr():
Before this change Tomcat handled getLocalAddr() like
getLocalName().
Backport of r1609593 from trunk.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/Constants.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1609593
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java?rev=1609606&r1=1609605&r2=1609606&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
Fri Jul 11 01:43:33 2014
@@ -423,8 +423,11 @@ public abstract class AbstractAjpProcess
break;
}
case REQ_LOCAL_ADDR_ATTRIBUTE: {
-// Copy from local name for now, which should simply be an address
-request.localAddr().setString(request.localName().toString());
+// Automatically populated during prepareRequest() when using
+// modern AJP forwarder, otherwise copy from local name
+if (request.localAddr().isNull()) {
+request.localAddr().setString(request.localName().toString());
+}
break;
}
case REQ_SET_BODY_REPLAY: {
@@ -791,13 +794,15 @@ public abstract class AbstractAjpProcess
requestHeaderMessage.getBytes(tmpMB);
String v = tmpMB.toString();
/*
- * AJP13 misses to forward the remotePort.
- * Allow the AJP connector to add this info via
- * a private request attribute.
- * We will accept the forwarded data as the remote port,
- * and remove it from the public list of request attributes.
+ * AJP13 misses to forward the local IP address and the
+ * remote port. Allow the AJP connector to add this info via
+ * private request attributes.
+ * We will accept the forwarded data and remove it from the
+ * public list of request attributes.
*/
-if(n.equals(Constants.SC_A_REQ_REMOTE_PORT)) {
+if(n.equals(Constants.SC_A_REQ_LOCAL_ADDR)) {
+request.localAddr().setString(v);
+} else if(n.equals(Constants.SC_A_REQ_REMOTE_PORT)) {
try {
request.setRemotePort(Integer.parseInt(v));
} catch (NumberFormatException nfe) {
Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/Constants.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/Constants.java?rev=1609606&r1=1609605&r2=1609606&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/Constants.java (original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/Constants.java Fri Jul 11
01:43:33 2014
@@ -104,6 +104,7 @@ public final class Constants {
/**
* AJP private request attributes
*/
+public static final String SC_A_REQ_LOCAL_ADDR = "AJP_LOCAL_ADDR";
public static final String SC_A_REQ_REMOTE_PORT = "AJP_REMOTE_PORT";
// Terminates list of attributes
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1609606&r1=1609605&r2=1609606&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Fri Jul 11 01:43:33 2014
@@ -208,6 +208,11 @@
Allow to configure maxSwallowSize attribute of an HTTP
connector via JMX. (kkolinko)
+
+56661: Fix getLocalAddr() for AJP connectors.
+The complete fix is only available with a recent AJP forwarder like
+the forthcoming mod_jk 1.2.41. (rjung)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609611 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: rjung Date: Fri Jul 11 02:00:56 2014 New Revision: 1609611 URL: http://svn.apache.org/r1609611 Log: Propose. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1609611&r1=1609610&r2=1609611&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jul 11 02:00:56 2014 @@ -74,6 +74,13 @@ PATCHES PROPOSED TO BACKPORT: +1: markt, kkolinko -1: +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56661 + Support using AJP request attribute AJP_LOCAL_ADDR to fix getLocalAddr(). + Backport of r1609593 from trunk resp. r1609606 from tc7. + http://people.apache.org/~rjung/patches/getLocalAddr-tc6.patch + +1: rjung + -1: + PATCHES/ISSUES THAT ARE STALLED: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56661] ServletRequest#getLocalAddr() returns the hostname, not the IP address
https://issues.apache.org/bugzilla/show_bug.cgi?id=56661 --- Comment #15 from Rainer Jung --- Test looked good. Ported by to TC 7 in r1609606 and proposed for TC 6. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56661] ServletRequest#getLocalAddr() returns the hostname, not the IP address
https://issues.apache.org/bugzilla/show_bug.cgi?id=56661 Rainer Jung changed: What|Removed |Added Component|Connectors |Connectors Version|trunk |6.0.41 Product|Tomcat 8|Tomcat 6 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609612 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Author: rjung Date: Fri Jul 11 02:03:30 2014 New Revision: 1609612 URL: http://svn.apache.org/r1609612 Log: Fix typo. Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1609612&r1=1609611&r2=1609612&view=diff == --- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Fri Jul 11 02:03:30 2014 @@ -46,7 +46,7 @@ 56661: Fix Servlet API getLocalAddr(). -Works for Tomcat 6.0.41, 7.0.55 and 8.0.11 and Apache and ISAPI +Works for Tomcat 6.0.42, 7.0.55 and 8.0.11 and Apache and ISAPI plugins. (rjung) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test-bio (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-bio has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 3 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-bio : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-bio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-BIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-BIO/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-bio/gump_work/build_tomcat-trunk_tomcat-trunk-test-bio.html Work Name: build_tomcat-trunk_tomcat-trunk-test-bio (Type: Build) Work ended in a state of : Failed Elapsed: 22 mins 24 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-BIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140711-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140711.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140711-native-src.tar.gz -Dtest.temp=output/test-tmp-BIO -Dtest.accesslog=true -Dexecute.test.nio=false -Dexecute.test.apr=false -Dexecute.test.bio=true -Dexecute.test.n io2=false -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140711.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servle t-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat -trunk/output/build/lib/tomcat-spdy.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/t
