[Bug 55859] New: Restore back the method addApplicationListener(String listener) in the class StandardContext
https://issues.apache.org/bugzilla/show_bug.cgi?id=55859 Bug ID: 55859 Summary: Restore back the method addApplicationListener(String listener) in the class StandardContext Product: Tomcat 8 Version: 8.0.0-RC5 Hardware: PC Status: NEW Severity: enhancement Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: vns.shysh...@gmail.com As of Tomcat-8.0.0-RC5 the method addApplicationListener(String listener) from the class StandardContext is deleted. This is extremely inconvenient for embedded Tomcat as it forces to use the org.apache.catalina.deploy.ApplicationListener class. The last is not included into Tomcat Embedded distro. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Deprecation message in tomcat 7 javadoc for WebSocketServlet
On 08/12/2013 05:07, Karl-Philipp Richter wrote: > Hi together, > I'm new to this list and hope to be at the right place. Hi. It is the right place. > I have the suggestion to add a reason to the deprecation message for the > WebSocketServlet in tomcat 7 javadocs. As far as I know, the class and > some related classes are deprecated because the functionality will be > handled by Java EE 7's web socket API implementation (in tomcat 8). The > javadoc reader could be informed about this to save him or her some > research time. I've updated the message. The JSR356 WebSocket implementation is available in Tomcat 7 as well. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1549052 - in /tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket: Constants.java MessageInbound.java StreamInbound.java WebSocketServlet.java WsFrame.java WsHttpServletRequestWrapper
Author: markt
Date: Sun Dec 8 16:12:33 2013
New Revision: 1549052
URL: http://svn.apache.org/r1549052
Log:
Better deprecation message.
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/Constants.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/MessageInbound.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/StreamInbound.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsFrame.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsHttpServletRequestWrapper.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsInputStream.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsOutbound.java
Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/Constants.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/Constants.java?rev=1549052&r1=1549051&r2=1549052&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/Constants.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/Constants.java Sun
Dec 8 16:12:33 2013
@@ -19,7 +19,8 @@ package org.apache.catalina.websocket;
/**
* Constants for this Java package.
*
- * @deprecated Will be removed in Tomcat 8.0.x.
+ * @deprecated Replaced by the JSR356 WebSocket 1.0 implementation and will be
+ * removed in Tomcat 8.0.x.
*/
@Deprecated
public class Constants {
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/MessageInbound.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/MessageInbound.java?rev=1549052&r1=1549051&r2=1549052&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/MessageInbound.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/MessageInbound.java
Sun Dec 8 16:12:33 2013
@@ -30,7 +30,8 @@ import org.apache.tomcat.util.res.String
* specific functionality. Applications that wish to operate on a stream basis
* rather than a message basis should use {@link StreamInbound}.
*
- * @deprecated Will be removed in Tomcat 8.0.x.
+ * @deprecated Replaced by the JSR356 WebSocket 1.0 implementation and will be
+ * removed in Tomcat 8.0.x.
*/
@Deprecated
public abstract class MessageInbound extends StreamInbound {
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/StreamInbound.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/StreamInbound.java?rev=1549052&r1=1549051&r2=1549052&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/StreamInbound.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/StreamInbound.java
Sun Dec 8 16:12:33 2013
@@ -36,7 +36,8 @@ import org.apache.tomcat.util.net.Abstra
* specific functionality. Applications that wish to operate on a message basis
* rather than a stream basis should use {@link MessageInbound}.
*
- * @deprecated Will be removed in Tomcat 8.0.x.
+ * @deprecated Replaced by the JSR356 WebSocket 1.0 implementation and will be
+ * removed in Tomcat 8.0.x.
*/
@Deprecated
public abstract class StreamInbound implements UpgradeInbound {
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java?rev=1549052&r1=1549051&r2=1549052&view=diff
==
---
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java
(original)
+++
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java
Sun Dec 8 16:12:33 2013
@@ -43,7 +43,8 @@ import org.apache.tomcat.util.res.String
* connections as per RFC6455. It is expected that applications will extend
this
* implementation and provide application specific functionality.
*
- * @deprecated Will be removed in Tomcat 8.0.x.
+ * @deprecated Replaced by the JSR356 WebSocket 1.0 implementation and will be
+ * removed in Tomcat 8.0.x.
*/
@Deprecated
public abstract class WebSocketServlet extends HttpServlet {
Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsFrame.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsFrame.java?rev=1549052&r1=1549051&r2=1549052&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsFrame.java
(original)
+++ tomcat/tc7.0.x/trunk/java
[Bug 55859] Restore back the method addApplicationListener(String listener) in the class StandardContext
https://issues.apache.org/bugzilla/show_bug.cgi?id=55859 Mark Thomas changed: What|Removed |Added OS||All Severity|enhancement |normal --- Comment #1 from Mark Thomas --- Then that is a bug in the packaging of the embedded distro and needs to be fixed there. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55859] Restore back the method addApplicationListener(String listener) in the class StandardContext
https://issues.apache.org/bugzilla/show_bug.cgi?id=55859 --- Comment #2 from Valery Shyshkin --- (In reply to Mark Thomas from comment #1) > Then that is a bug in the packaging of the embedded distro and needs to be > fixed there. You are right. But whether it is necessary to remove the very simple and intuitive method? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55859] Restore back the method addApplicationListener(String listener) in the class StandardContext
https://issues.apache.org/bugzilla/show_bug.cgi?id=55859 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Mark Thomas --- The class in question is not org.apache.catalina.deploy.ApplicationListener but org.apache.tomcat.util.descriptor.web.ApplicationListener which is included in the core embedded package. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55859] Restore back the method addApplicationListener(String listener) in the class StandardContext
https://issues.apache.org/bugzilla/show_bug.cgi?id=55859 --- Comment #4 from Valery Shyshkin --- Oh, sorry. I work with Tomcat 7 and try 8.0.0RC5 and did not notice the new package org.apache.tomcat.util.descriptor. It may partially solve my problem. At least I can create a stub org.apache.tomcat.util.descriptor package for Tomcat7. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Deprecation message in tomcat 7 javadoc for WebSocketServlet
Thanks for taking my suggestion into account. Karl On 08.12.2013 17:13, Mark Thomas wrote: > On 08/12/2013 05:07, Karl-Philipp Richter wrote: >> Hi together, >> I'm new to this list and hope to be at the right place. > > Hi. It is the right place. > >> I have the suggestion to add a reason to the deprecation message for the >> WebSocketServlet in tomcat 7 javadocs. As far as I know, the class and >> some related classes are deprecated because the functionality will be >> handled by Java EE 7's web socket API implementation (in tomcat 8). The >> javadoc reader could be informed about this to save him or her some >> research time. > > I've updated the message. The JSR356 WebSocket implementation is > available in Tomcat 7 as well. > > Mark > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > signature.asc Description: OpenPGP digital signature
svn commit: r1549202 - in /tomcat/jk/trunk: native/apache-1.3/mod_jk.c native/apache-2.0/mod_jk.c xdocs/miscellaneous/changelog.xml
Author: rjung
Date: Sun Dec 8 20:11:13 2013
New Revision: 1549202
URL: http://svn.apache.org/r1549202
Log:
PR 55853: HTTPD: Use the correct API for setting
Content-Length.
Modified:
tomcat/jk/trunk/native/apache-1.3/mod_jk.c
tomcat/jk/trunk/native/apache-2.0/mod_jk.c
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Modified: tomcat/jk/trunk/native/apache-1.3/mod_jk.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/apache-1.3/mod_jk.c?rev=1549202&r1=1549201&r2=1549202&view=diff
==
--- tomcat/jk/trunk/native/apache-1.3/mod_jk.c (original)
+++ tomcat/jk/trunk/native/apache-1.3/mod_jk.c Sun Dec 8 20:11:13 2013
@@ -365,8 +365,7 @@ static int JK_METHOD ws_start_response(j
header_values[h]);
}
else if (!strcasecmp(header_names[h], "Content-Length")) {
-ap_table_set(r->headers_out, header_names[h],
- header_values[h]);
+ap_set_content_length(r, atol(header_values[h]));
}
else if (!strcasecmp(header_names[h], "Transfer-Encoding")) {
ap_table_set(r->headers_out, header_names[h],
Modified: tomcat/jk/trunk/native/apache-2.0/mod_jk.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/apache-2.0/mod_jk.c?rev=1549202&r1=1549201&r2=1549202&view=diff
==
--- tomcat/jk/trunk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/jk/trunk/native/apache-2.0/mod_jk.c Sun Dec 8 20:11:13 2013
@@ -392,7 +392,7 @@ static int JK_METHOD ws_start_response(j
apr_table_set(r->headers_out, header_names[h], header_values[h]);
}
else if (!strcasecmp(header_names[h], "Content-Length")) {
-apr_table_set(r->headers_out, header_names[h], header_values[h]);
+ap_set_content_length(r, apr_atoi64(header_values[h]));
}
else if (!strcasecmp(header_names[h], "Transfer-Encoding")) {
apr_table_set(r->headers_out, header_names[h], header_values[h]);
Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1549202&r1=1549201&r2=1549202&view=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Sun Dec 8 20:11:13 2013
@@ -47,6 +47,10 @@
Fix status worker not updating parameters for all members. (mturk)
+
+55853: HTTPD: Use the correct API for setting
Content-Length.
+Patch contributed by areese yahoo-inc.com. (rjung)
+
Add --disable-sock-cloexec to configure to disable use of SOCK_CLOEXEC
(using FD_CLOEXEC + fnctl instead) so built modules will work with
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55853] mod_jk doesn't set the content length correctly for apache 2.x
https://issues.apache.org/bugzilla/show_bug.cgi?id=55853 Rainer Jung changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Rainer Jung --- Thanks for the patch. Extended for the httpd 1.3 branch and committed to mod_jk in r1549202. Will be part of version 1.2.38. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55862] New: @OnMessage and other annotations doesn't works in super class
https://issues.apache.org/bugzilla/show_bug.cgi?id=55862
Bug ID: 55862
Summary: @OnMessage and other annotations doesn't works in
super class
Product: Tomcat 8
Version: 8.0.0-RC5
Hardware: PC
Status: NEW
Severity: blocker
Priority: P2
Component: WebSocket
Assignee: dev@tomcat.apache.org
Reporter: zhouyanm...@gmail.com
javax.websocket.OnClose
javax.websocket.OnError
javax.websocket.OnMessage
javax.websocket.OnOpen
public class A {
@OnMessage
public void onMessage(Session session, String message) {
System.out.println(message);
}
}
@ServerEndpoint(value = "/websocket/b")
public class B extends A{
}
It looks like a bug,the Java EE websocket specification doesn't mention this
situation is a limitation.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55862] @OnMessage and other annotations doesn't works in super class
https://issues.apache.org/bugzilla/show_bug.cgi?id=55862 quaff changed: What|Removed |Added OS||All --- Comment #1 from quaff --- org.apache.tomcat.websocket.pojo.PojoMethodMapping clazzPojo.getDeclaredMethods() should be clazzPojo.getMethods() -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55862] @OnMessage and other annotations doesn't works in super class
https://issues.apache.org/bugzilla/show_bug.cgi?id=55862 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Mark Thomas --- JSR 356, WebSocket 1.0, Section 4.8: The websocket annotation behaviors defined by this specification are not passed down the Java class inheritance hierarchy. They apply only to the Java class on which they are marked. The reaminder of section 4.8 only offers some examples, it is not an exhuastive list of scenarios that are not supported. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55846] Static resources Greater than 48k can not be accessed when I Config the Connector with Http11NioProtocol
https://issues.apache.org/bugzilla/show_bug.cgi?id=55846 --- Comment #6 from conquer0715 --- Thank you, I'll try. (In reply to Mark Thomas from comment #5) > I've tested this on a couple of other platforms without error. This is > looking like an AIX specific error. You'll need to raise this with IBM > through whatever support contract you have with them. The good news is you > have a simple to reproduce test case. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
