[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-validate has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-validate :  Tomcat 7.x, a web server implementing Java 
Servlet 3.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 18 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20130925.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/tar
 
get/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20130925.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20130925.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-20130925.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-16.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-7.0.x/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/temp

compile-prepare:

download-validate:

proxyflags:

setproxy:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar

downloadzip:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle
[checkstyle] Running Checkstyle 5.7-SNAPSHOT on 2529 files
[checkstyle] 
/srv/gump/public/workspace/tomcat-7.0.x/res/maven/mvn-pub.xml:312:3: File 
contains tab characters (this is the first instance).

BUILD FAILED
/srv/gump/public/workspace/tomcat-7.0.x/build.xml:472: Got 1 errors and 0 
warnings.

Total time: 17 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 20130925060003, vmgump.apache.org:vmgump:20130925060003
Gump E-mail Identifier (unique within run) #1.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1525975 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

[Rainer Jung]

On 24.09.2013 22:02, Mark Thomas wrote:
> On 24/09/2013 12:10, kpreis...@apache.org wrote:
>> Author: kpreisser
>> Date: Tue Sep 24 19:10:44 2013
>> New Revision: 1525975
>>
>> URL: http://svn.apache.org/r1525975
>> Log:
>> Add myself to the committers list.
> 
> I guess everything works then :)
> 
> A very warm welcome.

+1, keep up the good work.

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Issue in AprEndpoint detected by TestCoyoteAdapter

[Rainer Jung]

On 25.09.2013 01:50, Mark Thomas wrote:
> On 24/09/2013 16:19, Mark Thomas wrote:
>> On 24/09/2013 08:16, Mark Thomas wrote:
>>> On 23/09/2013 00:54, Rainer Jung wrote:
>>>
 I agree that there's probably another problem further up the stack.
>>>
>>> I'm looking at this now.
>>
>> I've found a couple of issues. Not sure if either of these are the root
>> cause of the remaining issues we see but I'll look into fixing them.
>>
>> - AprEndpoint.destroySocket() calls Poller.removeFromPoller() but that
>>   call isn't thread safe. I think we need a remove process similar to
>>   the add process.
>> - sockets are not always removed from the timeout list when they are
>>   destroyed
> 
> Fixed.
> 
> Rainer, over to you.

ACK, will be able to run test loops this evening/night.

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [ANN] New committer: Konstantin Preißer

[Violeta Georgieva]

2013/9/25 Mark Thomas 
>
> On behalf of the Tomcat committers I am pleased to announce that
> Konstantin Preißer has been voted in as a new Tomcat committer.
>
> In addition to a number of high quality bug reports and patches,
> Konstantin is also responsible for the makeover the Tomcat web site and
> Tomcat 8 documentation has received.
>
> Please join me in welcoming him.
>

Welcome!

Regards
Violeta

svn commit: r1526157 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_45: ./ build.properties.default

[violetagg]

Author: violetagg
Date: Wed Sep 25 11:28:24 2013
New Revision: 1526157

URL: http://svn.apache.org/r1526157
Log:
Tag 7.0.45

Added:
tomcat/tc7.0.x/tags/TOMCAT_7_0_45/   (props changed)
  - copied from r1526154, tomcat/tc7.0.x/trunk/
Modified:
tomcat/tc7.0.x/tags/TOMCAT_7_0_45/build.properties.default

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
bugtraq:append = false

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
bugtraq:label = Bugzilla ID (optional)

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
--- bugtraq:message (added)
+++ bugtraq:message Wed Sep 25 11:28:24 2013
@@ -0,0 +1 @@
+Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
bugtraq:number = true

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
bugtraq:url = https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
bugtraq:warnifnoissue = false

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
--- svn:ignore (added)
+++ svn:ignore Wed Sep 25 11:28:24 2013
@@ -0,0 +1,7 @@
+.*
+build.properties
+logs
+nbproject
+output
+work
+*.iml

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Wed Sep 25 11:28:24 2013
@@ -0,0 +1 @@
+/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222328,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112,1240114
 
,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342320,1342476,1342
 
498,1342503,1342717,1342795,1342805,1343044-1343046,1343335,1343394,1343400,1343629,1343708,1343718,1343895,1344063,1344068,1344250,1344266,1344515,1344528,1344612,1344629,1344725,1344868,1344890,1344893,1344896,1344901,1345020,1345029,1345039,1345287-1345290,1345294,1345309,1345325,1345357,1345367,1345579-1345580,1345582,1345688,1345699,1345704,1345731-1345732,1345737,1345744,1345752,1345754,1345779,1345781,1345846,1346107,1346376,1346404,1346510,1346514,1346519,1346581,1346635,1346644,1346683,1346794,1346885,1346932,1347034,1347047,1347087,1347108-1347109,1347583,1347737,1348105,1348357,1348398,1348425,1348461-1348495,1348498,1348752,1348762,1348772,1348776,1348859,1348968,1348973,1348989,1349007,1349237,1349298,1349317,1349410,1349473,1349539,1349879,1349887,1349893,1349922,1349984,1350124,1350241,1350243,1350294-1350295,1350299,1350864,1350900,1351010,1351054,1351056,1351068,1351134-1351135,1351148,1351259,1351604,1351636-1351640,1351991,1351993,1352011,1352056,1352059,1352661,1
 
352663,1352788,1352799,1353087,1353125,1353240,1353261,1353414,1353468,1353501,1353581,1

svn commit: r1526164 - /tomcat/tc7.0.x/tags/TOMCAT_7_0_45/

[violetagg]

Author: violetagg
Date: Wed Sep 25 12:11:41 2013
New Revision: 1526164

URL: http://svn.apache.org/r1526164
Log:
Remove tag TOMCAT_7_0_45 - r1526162 has to be added in the tag.

Removed:
tomcat/tc7.0.x/tags/TOMCAT_7_0_45/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1526162 - /tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml

[violetagg]

Author: violetagg
Date: Wed Sep 25 12:06:45 2013
New Revision: 1526162

URL: http://svn.apache.org/r1526162
Log:
Checkstyle: spaces should be used instead of tabs.

Modified:
tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml

Modified: tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml?rev=1526162&r1=1526161&r2=1526162&view=diff
==
--- tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml (original)
+++ tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml Wed Sep 25 12:06:45 2013
@@ -309,7 +309,7 @@
   jarFileName="websocket-api.jar"
srcJarFileName="websocket-api-src.jar"/>
 
-   
+
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1526165 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_45: ./ build.properties.default

[violetagg]

Author: violetagg
Date: Wed Sep 25 12:23:00 2013
New Revision: 1526165

URL: http://svn.apache.org/r1526165
Log:
Tag 7.0.45

Added:
tomcat/tc7.0.x/tags/TOMCAT_7_0_45/   (props changed)
  - copied from r1526164, tomcat/tc7.0.x/trunk/
Modified:
tomcat/tc7.0.x/tags/TOMCAT_7_0_45/build.properties.default

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
bugtraq:append = false

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
bugtraq:label = Bugzilla ID (optional)

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
--- bugtraq:message (added)
+++ bugtraq:message Wed Sep 25 12:23:00 2013
@@ -0,0 +1 @@
+Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
bugtraq:number = true

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
bugtraq:url = https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
bugtraq:warnifnoissue = false

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
--- svn:ignore (added)
+++ svn:ignore Wed Sep 25 12:23:00 2013
@@ -0,0 +1,7 @@
+.*
+build.properties
+logs
+nbproject
+output
+work
+*.iml

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Wed Sep 25 12:23:00 2013
@@ -0,0 +1 @@
+/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222328,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112,1240114
 
,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342320,1342476,1342
 
498,1342503,1342717,1342795,1342805,1343044-1343046,1343335,1343394,1343400,1343629,1343708,1343718,1343895,1344063,1344068,1344250,1344266,1344515,1344528,1344612,1344629,1344725,1344868,1344890,1344893,1344896,1344901,1345020,1345029,1345039,1345287-1345290,1345294,1345309,1345325,1345357,1345367,1345579-1345580,1345582,1345688,1345699,1345704,1345731-1345732,1345737,1345744,1345752,1345754,1345779,1345781,1345846,1346107,1346376,1346404,1346510,1346514,1346519,1346581,1346635,1346644,1346683,1346794,1346885,1346932,1347034,1347047,1347087,1347108-1347109,1347583,1347737,1348105,1348357,1348398,1348425,1348461-1348495,1348498,1348752,1348762,1348772,1348776,1348859,1348968,1348973,1348989,1349007,1349237,1349298,1349317,1349410,1349473,1349539,1349879,1349887,1349893,1349922,1349984,1350124,1350241,1350243,1350294-1350295,1350299,1350864,1350900,1351010,1351054,1351056,1351068,1351134-1351135,1351148,1351259,1351604,1351636-1351640,1351991,1351993,1352011,1352056,1352059,1352661,1
 
352663,1352788,1352799,1353087,1353125,1353240,1353261,1353414,1353468,1353501,1353581,1

Re: [ANN] New committer: Konstantin Preißer

[Yoav Shapira]

On Tue, Sep 24, 2013 at 6:20 PM, Mark Thomas  wrote:
> On behalf of the Tomcat committers I am pleased to announce that
> Konstantin Preißer has been voted in as a new Tomcat committer.

Welcome ;)

Yoav

>
> In addition to a number of high quality bug reports and patches,
> Konstantin is also responsible for the makeover the Tomcat web site and
> Tomcat 8 documentation has received.
>
> Please join me in welcoming him.
>
> Regards,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r2995 [2/2] - in /dev/tomcat/tomcat-7/v7.0.45: ./ bin/ bin/embed/ bin/extras/ src/

[violetagg]

Added: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.asc
==
--- dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.asc Wed Sep 
25 13:10:46 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2.0.21 (MingW32)
+
+iQIcBAABCgAGBQJSQt5TAAoJECCLCrHWMBHHqxMP/R9hZnOL7f4carBoG7URvgeE
+8Gc/yeMtLg9q9638tv/VR14xPprBrfpgEshbV595WsWct3Mp6vuVFqZyRlGw7Yj6
+46MNTBzPLtIpJ2WVtJvnwupdgpmfHKmZ1Fxq1pRwBP88ljfKeUyMIO1A+PDX7czO
+29ltsvwqYj9PHx0D8CjF/At8tQxhNanV/NaHc0NjU1hkgZ55yL7wOhm44ILUMSl0
+gXyPTMRAwR8j9EYviWfOcdTjQXL7zLuuy7o2GD1MyR53PfKrmiwzn1UuvT1mo0XY
+No1arczrR6iovu0b7BJB5CTTpNezMpgo2QhyUzAsYHyXM1n6bqI2zHpkwYooFewn
+jXzhWNX99u++hKbJ5eIuWXc75/f1tdrrgCdHrA7FewDdr2uKqhXVUOXAmSAhxrHc
+LTyi7Xg7HeN9arkrq7Ond+J9FqRmhP/a1UiV7K4bFlyw2sI13CvtgDOjJwfjkNCs
+R9t2EhuGYwcgFBrDU7oz/S/aj/66GpReohx5TCmHHkOULEzGwnpbljENdXJA6tvF
+Y7ZvwVXr8X2wASqTgEW/M4Sl8eI7o0AbTgxaxAFPkhFPR0bYWrvhBui4X5WoJwfC
+GZrSRBEd6nemPbihJmv37KBhGeh6AOUBdKGDH6MYMjcInr57/+fFpkVivj/banEa
+NkIni9s2/xI9nMj//lbE
+=9TrE
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.md5
==
--- dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.md5 (added)
+++ dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.md5 Wed Sep 
25 13:10:46 2013
@@ -0,0 +1 @@
+29677afa605521723eef9a5ba977e9e9 *apache-tomcat-7.0.45-src.tar.gz
\ No newline at end of file

Added: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.asc
==
--- dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.asc Wed Sep 25 
13:10:46 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2.0.21 (MingW32)
+
+iQIcBAABCgAGBQJSQt39AAoJECCLCrHWMBHHwM8QAOtJBcH+4H/mB4RvFrdN/pxv
+s8J8PzS7kqjiQN38YGq078nGWSgIOW38q2EI9NAgPqaedZTz7ffYS0i/XgG3qDjh
+wrKxXWFwi5vTtLVWSOMh1oJ8f5Pu0NqKSYnVMHKUd2mtsoZLWwT2r4vV7QlnXq/c
+5egNXzZh7BqhXKa9ko67JQyLyaa986APmk0uL9r1H1A2b35kwqvXHA7QMzh3E44R
+TR+cBlFHIqCpZpzStzAV5pwFbfarxwoxcOHT9UEn9vCtKVDGmhjl6RV/bkBCwe7O
+Ym5hvtiq9ggncEKc211cvDRtbNnPZe6FjE8Ac3w83MhVIpAJZLBwOVH2QLG+Kuxc
+SxT13MiBAROE3CBKq6Suy+y+hxwKRq/LEB+NkoXVlS/tMLORe0qY4jWMgqxxSJdO
+HpBCuUVlafdxjJs2yCMpH8Ek7azoyd7dQH1huOaehi+G/lesMoEExChgfB1IAsFL
++353Le1yu0aRJmtTKh1qPZJT6NHJWj6JF2PRXZn2yALdW9Uq84HVosZS4tw2M+2/
+lY8z/Jw6++iL1aYlxb9Kuj4v/Y3+qcZsch3LVe6nU+JqH9PNC1lvHKIl2JR9IGWs
+uQIt+eVKGS/N2jtVo8zafsiP4yUkRtR6WNFs4LAf7WCWkXyIk9JHQ36PRhw3kyMC
+unEr4DpGDQdgyDs4uSne
+=VJoG
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.md5
==
--- dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.md5 (added)
+++ dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.md5 Wed Sep 25 
13:10:46 2013
@@ -0,0 +1 @@
+bc6c2b7ba82a69aa60360bde5ef3b259 *apache-tomcat-7.0.45-src.zip
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r2995 [2/2] - in /dev/tomcat/tomcat-7/v7.0.45: ./ bin/ bin/embed/ bin/extras/ src/

[violetagg]

Added: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.asc
==
--- dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.asc Wed Sep 
25 13:10:46 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2.0.21 (MingW32)
+
+iQIcBAABCgAGBQJSQt5TAAoJECCLCrHWMBHHqxMP/R9hZnOL7f4carBoG7URvgeE
+8Gc/yeMtLg9q9638tv/VR14xPprBrfpgEshbV595WsWct3Mp6vuVFqZyRlGw7Yj6
+46MNTBzPLtIpJ2WVtJvnwupdgpmfHKmZ1Fxq1pRwBP88ljfKeUyMIO1A+PDX7czO
+29ltsvwqYj9PHx0D8CjF/At8tQxhNanV/NaHc0NjU1hkgZ55yL7wOhm44ILUMSl0
+gXyPTMRAwR8j9EYviWfOcdTjQXL7zLuuy7o2GD1MyR53PfKrmiwzn1UuvT1mo0XY
+No1arczrR6iovu0b7BJB5CTTpNezMpgo2QhyUzAsYHyXM1n6bqI2zHpkwYooFewn
+jXzhWNX99u++hKbJ5eIuWXc75/f1tdrrgCdHrA7FewDdr2uKqhXVUOXAmSAhxrHc
+LTyi7Xg7HeN9arkrq7Ond+J9FqRmhP/a1UiV7K4bFlyw2sI13CvtgDOjJwfjkNCs
+R9t2EhuGYwcgFBrDU7oz/S/aj/66GpReohx5TCmHHkOULEzGwnpbljENdXJA6tvF
+Y7ZvwVXr8X2wASqTgEW/M4Sl8eI7o0AbTgxaxAFPkhFPR0bYWrvhBui4X5WoJwfC
+GZrSRBEd6nemPbihJmv37KBhGeh6AOUBdKGDH6MYMjcInr57/+fFpkVivj/banEa
+NkIni9s2/xI9nMj//lbE
+=9TrE
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.md5
==
--- dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.md5 (added)
+++ dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.tar.gz.md5 Wed Sep 
25 13:10:46 2013
@@ -0,0 +1 @@
+29677afa605521723eef9a5ba977e9e9 *apache-tomcat-7.0.45-src.tar.gz
\ No newline at end of file

Added: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.asc
==
--- dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.asc Wed Sep 25 
13:10:46 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2.0.21 (MingW32)
+
+iQIcBAABCgAGBQJSQt39AAoJECCLCrHWMBHHwM8QAOtJBcH+4H/mB4RvFrdN/pxv
+s8J8PzS7kqjiQN38YGq078nGWSgIOW38q2EI9NAgPqaedZTz7ffYS0i/XgG3qDjh
+wrKxXWFwi5vTtLVWSOMh1oJ8f5Pu0NqKSYnVMHKUd2mtsoZLWwT2r4vV7QlnXq/c
+5egNXzZh7BqhXKa9ko67JQyLyaa986APmk0uL9r1H1A2b35kwqvXHA7QMzh3E44R
+TR+cBlFHIqCpZpzStzAV5pwFbfarxwoxcOHT9UEn9vCtKVDGmhjl6RV/bkBCwe7O
+Ym5hvtiq9ggncEKc211cvDRtbNnPZe6FjE8Ac3w83MhVIpAJZLBwOVH2QLG+Kuxc
+SxT13MiBAROE3CBKq6Suy+y+hxwKRq/LEB+NkoXVlS/tMLORe0qY4jWMgqxxSJdO
+HpBCuUVlafdxjJs2yCMpH8Ek7azoyd7dQH1huOaehi+G/lesMoEExChgfB1IAsFL
++353Le1yu0aRJmtTKh1qPZJT6NHJWj6JF2PRXZn2yALdW9Uq84HVosZS4tw2M+2/
+lY8z/Jw6++iL1aYlxb9Kuj4v/Y3+qcZsch3LVe6nU+JqH9PNC1lvHKIl2JR9IGWs
+uQIt+eVKGS/N2jtVo8zafsiP4yUkRtR6WNFs4LAf7WCWkXyIk9JHQ36PRhw3kyMC
+unEr4DpGDQdgyDs4uSne
+=VJoG
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.md5
==
--- dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.md5 (added)
+++ dev/tomcat/tomcat-7/v7.0.45/src/apache-tomcat-7.0.45-src.zip.md5 Wed Sep 25 
13:10:46 2013
@@ -0,0 +1 @@
+bc6c2b7ba82a69aa60360bde5ef3b259 *apache-tomcat-7.0.45-src.zip
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 7.0.45

[Violeta Georgieva]

The proposed Apache Tomcat 7.0.45 release is now available for voting.
This release candidate contains JSR-356 Java WebSocket 1.0 implementation.
Note that use of this functionality requires Java 7.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.45/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-098/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_45/

The proposed 7.0.45 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.45 Stable

Regards
Violeta

svn commit: r1526175 - in /tomcat/tc7.0.x/trunk: build.properties.default res/maven/mvn.properties.default

[violetagg]

Author: violetagg
Date: Wed Sep 25 13:45:57 2013
New Revision: 1526175

URL: http://svn.apache.org/r1526175
Log:
Prep for next version

Modified:
tomcat/tc7.0.x/trunk/build.properties.default
tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default

Modified: tomcat/tc7.0.x/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.properties.default?rev=1526175&r1=1526174&r2=1526175&view=diff
==
--- tomcat/tc7.0.x/trunk/build.properties.default (original)
+++ tomcat/tc7.0.x/trunk/build.properties.default Wed Sep 25 13:45:57 2013
@@ -27,7 +27,7 @@
 # - Version Control Flags -
 version.major=7
 version.minor=0
-version.build=45
+version.build=46
 version.patch=0
 version.suffix=-dev
 

Modified: tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default?rev=1526175&r1=1526174&r2=1526175&view=diff
==
--- tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default (original)
+++ tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default Wed Sep 25 13:45:57 
2013
@@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos
 maven.asf.release.repo.repositoryId=apache.releases
 
 # Release version info
-maven.asf.release.deploy.version=7.0.45
+maven.asf.release.deploy.version=7.0.46
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1526185 - /tomcat/trunk/webapps/ROOT/index.jsp

[kpreisser]

Author: kpreisser
Date: Wed Sep 25 14:15:05 2013
New Revision: 1526185

URL: http://svn.apache.org/r1526185
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55383
Use UTF-8 as encoding for the ROOT index.jsp.

Modified:
tomcat/trunk/webapps/ROOT/index.jsp

Modified: tomcat/trunk/webapps/ROOT/index.jsp
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/ROOT/index.jsp?rev=1526185&r1=1526184&r2=1526185&view=diff
==
--- tomcat/trunk/webapps/ROOT/index.jsp (original)
+++ tomcat/trunk/webapps/ROOT/index.jsp Wed Sep 25 14:15:05 2013
@@ -14,8 +14,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY 
 See the License for the specific language governing permissions and
 limitations under the License.
 --%>
-
-<%@ page session="false" %>
+<%@ page session="false" pageEncoding="UTF-8" contentType="text/html; 
charset=UTF-8" %>
 <%
 java.text.SimpleDateFormat sdf = new java.text.SimpleDateFormat("");
 request.setAttribute("year", sdf.format(new java.util.Date()));
@@ -23,8 +22,10 @@ request.setAttribute("tomcatUrl", "http:
 request.setAttribute("tomcatDocUrl", "/docs/");
 request.setAttribute("tomcatExamplesUrl", "/examples/");
 %>
+
 
 
+
 <%=request.getServletContext().getServerInfo() %>
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

International characters in source files and SVN commit messages (was: RE:r1525975)

[Konstantin Preißer]

Hi all,

> -Original Message-
> From: kpreis...@apache.org [mailto:kpreis...@apache.org]
> Sent: Tuesday, September 24, 2013 9:11 PM

> --- tomcat/site/trunk/xdocs/whoweare.xml (original)
> +++ tomcat/site/trunk/xdocs/whoweare.xml Tue Sep 24 19:10:44 2013
> @@ -100,6 +100,9 @@ A complete list of all the Apache Commit
>  Costin Manolache (costin at apache.org)
>  
> 
> +Konstantin Preißer (kpreisser at apache.org)

When editing the whoweare.xml, I wrote the "ß" character (sharp s) which is now 
displayed as "ß" in the commit message, because the source XML file is encoded 
in UTF-8 (the default encoding for XML files).

As far as I understand, SVN needs to treat changes in text files at byte-level, 
not at character-level, to be independent from character encodings. Therefore 
e.g. ".patch" files don't have a character encoding as they describe changes at 
byte-level.

However, when the Commit E-Mail is sent, the bytes need to be converted to 
characters, and it seems the SVN commit diff is interpreted as ISO-8859-1 (or 
Windows-1252). Therefore, the UTF-8 bytes 0xC3 0x9F are displayed as "ß", 
instead of "ß".

That would be the preferred way to handle such issues? One way I can think 
would be to XML-encode such characters ("ß" as "ß"). However, personally I 
would rather not do this, but write such characters directly ("ß"), so that the 
source is better readable (and encodings like UTF-8 guarantee that the 
characters are interpreted the same on each system, independently from the 
system language or geographic location).

Could it be possible to change SVN Commit E-Mail system so that it may 
interpret diffs as UTF-8 instead of ISO-8859-1 (assuming all files which 
contain bytes > 0x7F are encoded as UTF-8)? (Or, that it tries to decode it as 
UTF-8, and if it fails, decode it as ISO-8859-1 ?)

For example, when I use TortoiseSVN to view the unified diff of r152597, then 
it prints the "ß" character, so it seems to interpret it as UTF-8.

Can you give me a hint?

Thanks!

Kind regards,
Konstantin Preißer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: International characters in source files and SVN commit messages (was: RE:r1525975)

[Mark Thomas]

On 25/09/2013 07:52, Konstantin Preißer wrote:
> Hi all,
> 
>> -Original Message- From: kpreis...@apache.org
>> [mailto:kpreis...@apache.org] Sent: Tuesday, September 24, 2013
>> 9:11 PM
> 
>> --- tomcat/site/trunk/xdocs/whoweare.xml (original) +++
>> tomcat/site/trunk/xdocs/whoweare.xml Tue Sep 24 19:10:44 2013 @@
>> -100,6 +100,9 @@ A complete list of all the Apache Commit 
>> Costin Manolache (costin at apache.org) 
>> 
>> +Konstantin Preißer (kpreisser at apache.org)
> 
> When editing the whoweare.xml, I wrote the "ß" character (sharp s)
> which is now displayed as "ß" in the commit message, because the
> source XML file is encoded in UTF-8 (the default encoding for XML
> files).
> 
> As far as I understand, SVN needs to treat changes in text files at
> byte-level, not at character-level, to be independent from character
> encodings. Therefore e.g. ".patch" files don't have a character
> encoding as they describe changes at byte-level.
> 
> However, when the Commit E-Mail is sent, the bytes need to be
> converted to characters, and it seems the SVN commit diff is
> interpreted as ISO-8859-1 (or Windows-1252). Therefore, the UTF-8
> bytes 0xC3 0x9F are displayed as "ß", instead of "ß".
> 
> That would be the preferred way to handle such issues? One way I can
> think would be to XML-encode such characters ("ß" as "ß").
> However, personally I would rather not do this, but write such
> characters directly ("ß"), so that the source is better readable (and
> encodings like UTF-8 guarantee that the characters are interpreted
> the same on each system, independently from the system language or
> geographic location).

I don't like the idea of using XML encoding at all.

> Could it be possible to change SVN Commit E-Mail system so that it
> may interpret diffs as UTF-8 instead of ISO-8859-1 (assuming all
> files which contain bytes > 0x7F are encoded as UTF-8)? (Or, that it
> tries to decode it as UTF-8, and if it fails, decode it as ISO-8859-1
> ?)

This is a question for infra. If UTF-8 fails then ISO-8859-1 is going to
fail as well.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: International characters in source files and SVN commit messages (was: RE:r1525975)

[Konstantin Preißer]

Hi Mark,

thanks for the reply.

> -Original Message-
> From: Mark Thomas [mailto:ma...@apache.org]
> Sent: Wednesday, September 25, 2013 5:01 PM

> > One way I can
> > think would be to XML-encode such characters ("ß" as "ß").
> > However, personally I would rather not do this, but write such
> > characters directly ("ß"), so that the source is better readable (and
> > encodings like UTF-8 guarantee that the characters are interpreted
> > the same on each system, independently from the system language or
> > geographic location).
> 
> I don't like the idea of using XML encoding at all.

Just to avoid a misunderstanding, with "XML encoding" you mean numeric 
character references like &#nnn; ?


> > Could it be possible to change SVN Commit E-Mail system so that it
> > may interpret diffs as UTF-8 instead of ISO-8859-1 (assuming all
> > files which contain bytes > 0x7F are encoded as UTF-8)? (Or, that it
> > tries to decode it as UTF-8, and if it fails, decode it as ISO-8859-1
> > ?)
> 
> This is a question for infra. If UTF-8 fails then ISO-8859-1 is going to
> fail as well.

I mean, to guess a character encoding by first decoding it as UTF-8, and if it 
fails, assume the file was encoded as ISO-8859-1/Windows-1252. This approach 
seems to be used by some programs to decide if the file was encoded as UTF-8 or 
as ANSI when it doesn't have BOM bytes.

For example, consider a file that contains only ASCII characters (< 0x7F) 
stored as single-byte-per-character. As UTF-8 is ASCII-compatble, you will get 
the same results if you interpret it as UTF-8 and with ISO-8859-1.

However, if you have a file that contains "äöü" (german umlaut characters) as 
ISO-8859-1 (Bytes: E4 F6 FC), then UTF-8 decoding will fail because the bytes 
after the one which starts with 11xx (binary) don't start with 10xx; 
but decoding as ISO-8859-1 will succeed.

This approach to guess the encoding (UTF-8 vs. ISO-8859-1/Windows-1252) seems 
to be used by programs like Notepad++ when opening text files without a BOM, 
and by TortoiseSVN when displaying file changes, and seems to be working well 
if you have files with either UTF-8 or ISO-8859-1/Windows-1252 (or other local  
encodings). Of course, this will not always work, e.g. if your text file that 
is encoded with ISO-8859-1 actually contains text like "ß". (Personally, for 
my projects I use UTF-8 for everything :) )


I was asking because I saw some i18n files like "LocalStrings_ja.properties" 
that encode non-ASCII characters with "\u", and I'd like to know if it is 
okay to put characters "ß" character in the XML file without encoding it by a 
numeric character reference, while the Commit E-Mails don't use UTF-8. If you 
are okay with this, then I don't mind changing the encoding for the SVN Commit 
E-Mails.

Thanks!

Konstantin


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: International characters in source files and SVN commit messages (was: RE:r1525975)

[Konstantin Preißer]

> If you are okay with this, then I don't mind changing the encoding for the SVN
> Commit E-Mails.

Sorry; I meant "then I don't care about changing it".

Konstantin


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Refactoring class loader access to resources

[Mark Thomas]

On 24/09/2013 06:44, Romain Manni-Bucau wrote:
> Hi
> 
> about the expanding, tomee forces it so an option can work. I agree with
> you "theorically" components shouldn't do it but in practises they have to
> (there is no real solutions on this side. That's why all APIs about
> scanning ends with a SPI :().
> 
> About addURL I think you are right too and addURL() impl can handle the
> conversion.

OK. I think I can see a way to make this work then.

> About jars.txt here is the history about it
> https://issues.apache.org/jira/browse/TOMEE-794. In 2 words you can pu tin
> WEB-INF a file called jars.txt and each line represent a jar. It can be a
> mvn url, a http url, a file url or simply a path (with a hack for *.jar as
> in the virtual webapp class loader of tomcat). A part of the magic is done
> in start and addURL methods of
> http://svn.apache.org/repos/asf/tomee/tomee/trunk/tomee/tomee-catalina/src/main/java/org/apache/tomee/catalina/LazyStopWebappClassLoader.java
> (of
> course this supposes getURLs impact addURL then).
> 
> Hope it is clearer

Much clearer thanks. I'm assuming that TomEE is going to convert the
mvn:... coordinates into a URL (http, file, etc) that that JRE can
understand.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: International characters in source files and SVN commit messages (was: RE:r1525975)

[Mark Thomas]

On 25/09/2013 08:36, Konstantin Preißer wrote:
> Hi Mark,
> 
> thanks for the reply.
> 
>> -Original Message- From: Mark Thomas
>> [mailto:ma...@apache.org] Sent: Wednesday, September 25, 2013 5:01
>> PM
> 
>>> One way I can think would be to XML-encode such characters ("ß"
>>> as "ß"). However, personally I would rather not do this, but
>>> write such characters directly ("ß"), so that the source is
>>> better readable (and encodings like UTF-8 guarantee that the
>>> characters are interpreted the same on each system, independently
>>> from the system language or geographic location).
>> 
>> I don't like the idea of using XML encoding at all.
> 
> Just to avoid a misunderstanding, with "XML encoding" you mean
> numeric character references like &#nnn; ?

Yes.

>>> Could it be possible to change SVN Commit E-Mail system so that
>>> it may interpret diffs as UTF-8 instead of ISO-8859-1 (assuming
>>> all files which contain bytes > 0x7F are encoded as UTF-8)? (Or,
>>> that it tries to decode it as UTF-8, and if it fails, decode it
>>> as ISO-8859-1 ?)
>> 
>> This is a question for infra. If UTF-8 fails then ISO-8859-1 is
>> going to fail as well.
> 
> I mean, to guess a character encoding by first decoding it as UTF-8,
> and if it fails, assume the file was encoded as
> ISO-8859-1/Windows-1252. This approach seems to be used by some
> programs to decide if the file was encoded as UTF-8 or as ANSI when
> it doesn't have BOM bytes.
> 
> For example, consider a file that contains only ASCII characters (<
> 0x7F) stored as single-byte-per-character. As UTF-8 is
> ASCII-compatble, you will get the same results if you interpret it as
> UTF-8 and with ISO-8859-1.
> 
> However, if you have a file that contains "äöü" (german umlaut
> characters) as ISO-8859-1 (Bytes: E4 F6 FC), then UTF-8 decoding will
> fail because the bytes after the one which starts with 11xx
> (binary) don't start with 10xx; but decoding as ISO-8859-1 will
> succeed.
> 
> This approach to guess the encoding (UTF-8 vs.
> ISO-8859-1/Windows-1252) seems to be used by programs like Notepad++
> when opening text files without a BOM, and by TortoiseSVN when
> displaying file changes, and seems to be working well if you have
> files with either UTF-8 or ISO-8859-1/Windows-1252 (or other local
> encodings). Of course, this will not always work, e.g. if your text
> file that is encoded with ISO-8859-1 actually contains text like
> "ß". (Personally, for my projects I use UTF-8 for everything :) )
> 
> 
> I was asking because I saw some i18n files like
> "LocalStrings_ja.properties" that encode non-ASCII characters with
> "\u", and I'd like to know if it is okay to put characters "ß"
> character in the XML file without encoding it by a numeric character
> reference,

I'd say yes. Property files are a 'special' case:
http://stackoverflow.com/questions/4659929/how-to-use-utf-8-in-resource-properties-with-resourcebundle

> while the Commit E-Mails don't use UTF-8. If you are okay
> with this, then I don't mind changing the encoding for the SVN Commit
> E-Mails.

It doesn't bother me but I'm only one committer. I think this falls
under the category if someone cares enough about the commit e-mails
using UTF-8 then they need to work with infra to make that happen. I'm
happy with things as they are.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1526214 - /tomcat/trunk/test/webresources/war-url-connection.war

[markt]

Author: markt
Date: Wed Sep 25 16:00:37 2013
New Revision: 1526214

URL: http://svn.apache.org/r1526214
Log:
Add an empty WEB-INF/classes dir to the WAR for testing 
WebappClassLoader.getURLs()

Modified:
tomcat/trunk/test/webresources/war-url-connection.war

Modified: tomcat/trunk/test/webresources/war-url-connection.war
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/webresources/war-url-connection.war?rev=1526214&r1=1526213&r2=1526214&view=diff
==
Files tomcat/trunk/test/webresources/war-url-connection.war (original) and 
tomcat/trunk/test/webresources/war-url-connection.war Wed Sep 25 16:00:37 2013 
differ



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: International characters in source files and SVN commit messages (was: RE:r1525975)

[Konstantin Preißer]

Mark,

> -Original Message-
> From: Mark Thomas [mailto:ma...@apache.org]
> Sent: Wednesday, September 25, 2013 5:54 PM

> I'd say yes. Property files are a 'special' case:
> http://stackoverflow.com/questions/4659929/how-to-use-utf-8-in-
> resource-properties-with-resourcebundle

OK, thank you for the clarification.

> It doesn't bother me but I'm only one committer. I think this falls
> under the category if someone cares enough about the commit e-mails
> using UTF-8 then they need to work with infra to make that happen. I'm
> happy with things as they are.

OK.

Thanks!

Konstantin


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Refactoring class loader access to resources

[Romain Manni-Bucau]

worse than it, we download the artifact then new File(...).toURI().toURL()
:)

*Romain Manni-Bucau*
*Twitter: @rmannibucau *
*Blog: **http://rmannibucau.wordpress.com/*
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/9/25 Mark Thomas 

> On 24/09/2013 06:44, Romain Manni-Bucau wrote:
> > Hi
> >
> > about the expanding, tomee forces it so an option can work. I agree with
> > you "theorically" components shouldn't do it but in practises they have
> to
> > (there is no real solutions on this side. That's why all APIs about
> > scanning ends with a SPI :().
> >
> > About addURL I think you are right too and addURL() impl can handle the
> > conversion.
>
> OK. I think I can see a way to make this work then.
>
> > About jars.txt here is the history about it
> > https://issues.apache.org/jira/browse/TOMEE-794. In 2 words you can pu
> tin
> > WEB-INF a file called jars.txt and each line represent a jar. It can be a
> > mvn url, a http url, a file url or simply a path (with a hack for *.jar
> as
> > in the virtual webapp class loader of tomcat). A part of the magic is
> done
> > in start and addURL methods of
> >
> http://svn.apache.org/repos/asf/tomee/tomee/trunk/tomee/tomee-catalina/src/main/java/org/apache/tomee/catalina/LazyStopWebappClassLoader.java
> > (of
> > course this supposes getURLs impact addURL then).
> >
> > Hope it is clearer
>
> Much clearer thanks. I'm assuming that TomEE is going to convert the
> mvn:... coordinates into a URL (http, file, etc) that that JRE can
> understand.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

[jira] [Updated] (MTOMCAT-240) Artifacts with same artifactID but different groupID are skipped

[Petar Tahchiev (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Petar Tahchiev updated MTOMCAT-240:
---

Attachment: MTOMCAT-240.patch

> Artifacts with same artifactID but different groupID are skipped
> 
>
> Key: MTOMCAT-240
> URL: https://issues.apache.org/jira/browse/MTOMCAT-240
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>  Components: commons-lib
>Affects Versions: 2.1
> Environment: all
>Reporter: Petar Tahchiev
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.2
>
> Attachments: MTOMCAT-240.patch
>
>
> Hi guys,
> I have the following situation: my classpath includes the following artifacts:
> 1) artifactA in group com.mygroup
> 2) artifactA in group com.myothergroup.
> Looking in DefaultClassLoaderEntriesCalculator.java on line 120 we see the 
> following:
> {code}
> String fileName = artifact.getFile().getName();
> if ( !fileInClassLoaderEntries.contains( fileName ) ) 
> {
>// add the artifact to the classpath
> }
> {code}
> So in my case both artifacts are resolved as artifactA-1.0-SNAPSHOT.jar so 
> the second one gets omitted. I have chaged to code to simply include the 
> categoryID like this: 
> {code}
> String fileName = artifact.getGroupId() + "-" + 
> artifact.getFile().getName();
> if ( !fileInClassLoaderEntries.contains( fileName ) ) 
> {
>   //add to classpath
> }
> {code}
> and it works like a charm.
> You can find the patch attached. Please review it and apply.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[jira] [Created] (MTOMCAT-240) Artifacts with same artifactID but different groupID are skipped

[Petar Tahchiev (JIRA)]

Petar Tahchiev created MTOMCAT-240:
--

 Summary: Artifacts with same artifactID but different groupID are 
skipped
 Key: MTOMCAT-240
 URL: https://issues.apache.org/jira/browse/MTOMCAT-240
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: commons-lib
Affects Versions: 2.1
 Environment: all
Reporter: Petar Tahchiev
Assignee: Olivier Lamy (*$^¨%`£)
 Fix For: 2.2
 Attachments: MTOMCAT-240.patch

Hi guys,

I have the following situation: my classpath includes the following artifacts:
1) artifactA in group com.mygroup
2) artifactA in group com.myothergroup.

Looking in DefaultClassLoaderEntriesCalculator.java on line 120 we see the 
following:
{code}
String fileName = artifact.getFile().getName();
if ( !fileInClassLoaderEntries.contains( fileName ) ) {
   // add the artifact to the classpath
}
{code}

So in my case both artifacts are resolved as artifactA-1.0-SNAPSHOT.jar so the 
second one gets omitted. I have chaged to code to simply include the categoryID 
like this: 

{code}
String fileName = artifact.getGroupId() + "-" + 
artifact.getFile().getName();
if ( !fileInClassLoaderEntries.contains( fileName ) ) {
  //add to classpath
}
{code}

and it works like a charm.
You can find the patch attached. Please review it and apply.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1526224 - in /tomcat/trunk/java/org/apache/catalina: util/TomcatCSS.java valves/ErrorReportValve.java

[kpreisser]

Author: kpreisser
Date: Wed Sep 25 16:31:22 2013
New Revision: 1526224

URL: http://svn.apache.org/r1526224
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55383
Improve HTML markup of the ErrorReportValve.
The design/layout is still the same, but I'm looking into how it can be 
improved.

Modified:
tomcat/trunk/java/org/apache/catalina/util/TomcatCSS.java
tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

Modified: tomcat/trunk/java/org/apache/catalina/util/TomcatCSS.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/util/TomcatCSS.java?rev=1526224&r1=1526223&r2=1526224&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/util/TomcatCSS.java (original)
+++ tomcat/trunk/java/org/apache/catalina/util/TomcatCSS.java Wed Sep 25 
16:31:22 2013
@@ -30,7 +30,7 @@ public class TomcatCSS {
 "P 
{font-family:Tahoma,Arial,sans-serif;background:white;color:black;font-size:12px;}"
 +
 "A {color : black;}" +
 "A.name {color : black;}" +
-"HR {color : #525D76;}";
+".line {height: 1px; background-color: #525D76; border: none;}";
 
 
 }

Modified: tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java?rev=1526224&r1=1526223&r2=1526224&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Wed Sep 
25 16:31:22 2013
@@ -177,18 +177,18 @@ public class ErrorReportValve extends Va
 
 StringBuilder sb = new StringBuilder();
 
-sb.append("");
+sb.append("");
 sb.append(ServerInfo.getServerInfo()).append(" - ");
 sb.append(smClient.getString("errorReportValve.errorReport"));
 sb.append("");
-sb.append(" ");
+sb.append(" ");
 sb.append("");
 sb.append("");
 sb.append(smClient.getString("errorReportValve.statusHeader",
"" + statusCode, message)).append("");
-sb.append("");
+sb.append("");
 sb.append("type ");
 if (throwable != null) {
 sb.append(smClient.getString("errorReportValve.exceptionReport"));
@@ -211,9 +211,9 @@ public class ErrorReportValve extends Va
 String stackTrace = getPartialServletStackTrace(throwable);
 sb.append("");
 sb.append(smClient.getString("errorReportValve.exception"));
-sb.append(" ");
+sb.append("");
 sb.append(RequestUtil.filter(stackTrace));
-sb.append("");
+sb.append("");
 
 int loops = 0;
 Throwable rootCause = throwable.getCause();
@@ -221,9 +221,9 @@ public class ErrorReportValve extends Va
 stackTrace = getPartialServletStackTrace(rootCause);
 sb.append("");
 sb.append(smClient.getString("errorReportValve.rootCause"));
-sb.append(" ");
+sb.append("");
 sb.append(RequestUtil.filter(stackTrace));
-sb.append("");
+sb.append("");
 // In case root cause is somehow heavily nested
 rootCause = rootCause.getCause();
 loops++;
@@ -238,7 +238,7 @@ public class ErrorReportValve extends Va
 
 }
 
-sb.append("");
+sb.append("");
 sb.append("").append(ServerInfo.getServerInfo()).append("");
 sb.append("");
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1526233 - /tomcat/trunk/java/org/apache/jasper/servlet/TldScanner.java

[markt]

Author: markt
Date: Wed Sep 25 17:10:02 2013
New Revision: 1526233

URL: http://svn.apache.org/r1526233
Log:
Fix indent

Modified:
tomcat/trunk/java/org/apache/jasper/servlet/TldScanner.java

Modified: tomcat/trunk/java/org/apache/jasper/servlet/TldScanner.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/servlet/TldScanner.java?rev=1526233&r1=1526232&r2=1526233&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/servlet/TldScanner.java (original)
+++ tomcat/trunk/java/org/apache/jasper/servlet/TldScanner.java Wed Sep 25 
17:10:02 2013
@@ -246,8 +246,8 @@ public class TldScanner {
 try {
 jar.nextEntry();
 for (String entryName = jar.getEntryName();
- entryName != null;
- jar.nextEntry(), entryName = jar.getEntryName()) {
+entryName != null;
+jar.nextEntry(), entryName = jar.getEntryName()) {
 if (!(entryName.startsWith("META-INF/") &&
 entryName.endsWith(TLD_EXT))) {
 continue;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 55595] New: Request parameter parsing is not thread-safe

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=55595

Bug ID: 55595
   Summary: Request parameter parsing is not thread-safe
   Product: Tomcat 8
   Version: trunk
  Hardware: PC
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: tajud...@amazon.com

Created attachment 30882
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30882&action=edit
Proposed patch to trunk

I have a use case for accessing the parameters of a request in multiple threads
in order to generate the response. In that situation, there is a race condition
in org.apache.catalina.connector.Request when attempting to access parameters. 

The first thread in will flag the parameters as parsed while successive threads
may retrieve partially-constructed parameters. I can retrieve the parameters in
the request thread before dispatching to the other threads, and this problem
does not occur. However, that imposes overhead on my environment where it may
not be required.

A little synchronization should handle this case without creating any overhead
for the standard single-threaded request handling use cases. I have attached a
patch with a proposed solution. Any feedback is welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 55595] Request parameter parsing is not thread-safe

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=55595

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from Mark Thomas  ---
See section 2.3.3.4 of the Servlet 3.1 specification.

Adding synchronization would add unnecessary overhead for the significant
majority of users who do not need multi-threaded access to the parameters.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.45

[Martin Grigorov]

On Wed, Sep 25, 2013 at 3:37 PM, Violeta Georgieva wrote:

> The proposed Apache Tomcat 7.0.45 release is now available for voting.
> This release candidate contains JSR-356 Java WebSocket 1.0 implementation.
> Note that use of this functionality requires Java 7.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.45/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-098/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
>
> The proposed 7.0.45 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.45 Stable
>
> Regards
> Violeta
>

Re: [VOTE] Release Apache Tomcat 7.0.45

[Jeanfrancois Arcand]

[X] Stable - go ahead and release as 7.0.45 Stable

-- Jeanfrancois


On 2013-09-25 9:37 AM, Violeta Georgieva wrote:

The proposed Apache Tomcat 7.0.45 release is now available for voting.
This release candidate contains JSR-356 Java WebSocket 1.0 implementation.
Note that use of this functionality requires Java 7.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.45/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-098/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_45/

The proposed 7.0.45 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.45 Stable

Regards
Violeta




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 55595] Request parameter parsing is not thread-safe

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=55595

--- Comment #2 from Christopher Schultz  ---
A bit more commentary to avoid grumbling:

1. While uncontended locks are cheap, they still have a cost that nobody else
wants to pay.

2. If you need to access request parameters from multiple threads, you can do
so yourself without having to modify the container to do it for you. Two
examples I can think of are to wrap the request in an HttpServletRequestWrapper
that you write which includes synchronization for any of the getParameter...()
family of methods, or to use a similar but simpler interface (e.g. just not
HttpServletRequestWrapper).

In any case, you will need to take special care not to retain references to the
request or response in those other threads. Otherwise, you risk a security
vulnerability at worst and mass confusion at the least.

If you don't want to complicate your own servlet code with this kind of thing,
you could even write a Filter to apply a wrapper for those servlets for which
it is appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.45

[Christopher Schultz]

Violetta,

On 9/25/13 9:37 AM, Violeta Georgieva wrote:
> The proposed Apache Tomcat 7.0.45 release is now available for voting.
> This release candidate contains JSR-356 Java WebSocket 1.0 implementation.
> Note that use of this functionality requires Java 7.
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.45/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-098/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
> 
> The proposed 7.0.45 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.45 Stable

+1 for Stable

Debian Linux 2.6 x86-64
Oracle Java 1.6.0_26 64-bit JVM

MD5 sums match
GPG signatures match
ZIP and tarball are the same
tcnative builds fine
Checkstyle is happy
Java builds with a single warning:
compile-java6:
[javac] Compiling 1313 source files to
/home/cschultz/projects/apache-tomcat/tarball/apache-tomcat-7.0.45-src/output/classes
[javac]
/home/cschultz/projects/apache-tomcat/tarball/apache-tomcat-7.0.45-src/java/javax/el/ResourceBundleELResolver.java:109:
warning: getFeatureDescriptors(javax.el.ELContext,java.lang.Object) in
javax.el.ResourceBundleELResolver overrides
getFeatureDescriptors(javax.el.ELContext,java.lang.Object) in
javax.el.ELResolver; return type requires unchecked conversion
[javac] found   : java.util.Iterator
[javac] required: java.util.Iterator
[javac] public Iterator getFeatureDescriptors(
[javac] ^
BIO, NIO, and APR tests all pass (except for Tribes which are known to
fail in my environment)

A short smoke test in my development environment shows no problems.

-chris



signature.asc
Description: OpenPGP digital signature

Re: [VOTE] Release Apache Tomcat 7.0.45

[Rossen Stoyanchev]

On Wed, Sep 25, 2013 at 9:37 AM, Violeta Georgieva  wrote:
> The proposed Apache Tomcat 7.0.45 release is now available for voting.
> This release candidate contains JSR-356 Java WebSocket 1.0 implementation.
> Note that use of this functionality requires Java 7.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.45/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-098/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_45/
>
> The proposed 7.0.45 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.45 Stable

+1 stable

I can confirm the exception I reported with 7.0.44 is now fixed.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org