[Bug 55158] New: Wasted work in AttributeNamesEnumerator constructor
https://issues.apache.org/bugzilla/show_bug.cgi?id=55158 Bug ID: 55158 Summary: Wasted work in AttributeNamesEnumerator constructor Product: Tomcat 7 Version: 7.0.41 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: nist...@illinois.edu Created attachment 30498 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30498&action=edit patch The problem appears in version 7.0.41 and in revision 1497999. I attached a two-line patch that fixes it. In the "AttributeNamesEnumerator" constructor, the loop over "specials" keeps overriding "last" with "i". Therefore, only the last written value is visible out of the loop and all the other writes and iterations are not necessary. The patch iterates from the end of "specials" and breaks the first time when "last" is set. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55158] Wasted work in AttributeNamesEnumerator constructor
https://issues.apache.org/bugzilla/show_bug.cgi?id=55158 Adrian Nistor changed: What|Removed |Added Keywords||PatchAvailable CC||nist...@illinois.edu -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55159] New: Wasted work in ErrorReportValve.getPartialServletStackTrace
https://issues.apache.org/bugzilla/show_bug.cgi?id=55159 Bug ID: 55159 Summary: Wasted work in ErrorReportValve.getPartialServletStackTrace Product: Tomcat 7 Version: 7.0.41 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: nist...@illinois.edu Created attachment 30499 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30499&action=edit patch The problem appears in version 7.0.41 and in revision 1497999. I attached a two-line patch (patch.diff) that fixes it. In method "ErrorReportValve.getPartialServletStackTrace", the loop over "elements" keeps overriding "pos" with "i". Therefore, only the last written value is visible out of the loop and all the other writes and iterations are not necessary. The patch iterates from the end of "elements" and breaks the first time when "pos" is set. The above fix (in patch.diff) is certainly correct (it's easy to see through code inspection), but I think we can have an even shorter patch (one line, in patchShort.diff): just break as soon as "pos" is set, without reversion the loop order. patchShort.diff is correct only if there can be only one "elements[i]" with class name "org.apache.catalina.core.ApplicationFilterChain" and method name "internalDoFilter" or if it doesn't matter which such "elements[i]" is detected (the last, like in the original code, or the first, like in patchShort.diff). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55159] Wasted work in ErrorReportValve.getPartialServletStackTrace
https://issues.apache.org/bugzilla/show_bug.cgi?id=55159 --- Comment #1 from Adrian Nistor --- Created attachment 30500 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30500&action=edit patchShort -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55159] Wasted work in ErrorReportValve.getPartialServletStackTrace
https://issues.apache.org/bugzilla/show_bug.cgi?id=55159 Adrian Nistor changed: What|Removed |Added Keywords||PatchAvailable CC||nist...@illinois.edu -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55160] New: NIO connectionUploadTimeout can't work
https://issues.apache.org/bugzilla/show_bug.cgi?id=55160
Bug ID: 55160
Summary: NIO connectionUploadTimeout can't work
Product: Tomcat 7
Version: 7.0.30
Hardware: PC
OS: other
Status: NEW
Severity: normal
Priority: P2
Component: Connectors
Assignee: dev@tomcat.apache.org
Reporter: jmwmj...@163.com
when i configure disableUploadTimeout="false" and connectionTimeout="2"
,connectionUploadTimeout="3" .
I found the connectionUploadTimeout doesn't work, because the code in
internalNioInputBuffer.readSocket():
try {
NioEndpoint.KeyAttachment att =
(NioEndpoint.KeyAttachment)socket.getAttachment(false);
if ( att == null ) throw new IOException("Key must be
cancelled.");
nRead =
pool.read(socket.getBufHandler().getReadBuffer(),socket,selector,att.getTimeout());
} catch ( EOFException eof ) {
nRead = -1;
} finally {
if ( selector != null ) pool.put(selector);
}
~
att.getTimeout() is the connectionTimeout ,not the connectionUploadTimeout.
so , in NioBlockingSelector.read(), the readTimeout is connectionTimeout
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55160] NIO connectionUploadTimeout can't work
https://issues.apache.org/bugzilla/show_bug.cgi?id=55160 Roger Wang changed: What|Removed |Added OS|other |Windows 7 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55162] New: Incorrect namespace URI test webapp
https://issues.apache.org/bugzilla/show_bug.cgi?id=55162 Bug ID: 55162 Summary: Incorrect namespace URI test webapp Product: Tomcat 8 Version: trunk Hardware: PC OS: Mac OS X 10.4 Status: NEW Severity: minor Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: jboy...@apache.org The test/webapp web.xml is using the Sun namespace for a 3.1 web-app rather than the JCP namespace. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55162] Incorrect namespace URI test webapp
https://issues.apache.org/bugzilla/show_bug.cgi?id=55162 --- Comment #1 from Jeremy Boynes --- Created attachment 30503 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30503&action=edit Quick fix for namespace -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53737] Use ServletContext.getJspConfigDescriptor() in Jasper instead of XML-parsing of merged web.xml
https://issues.apache.org/bugzilla/show_bug.cgi?id=53737 --- Comment #3 from Jeremy Boynes --- Created attachment 30504 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30504&action=edit Add support for JspConfig to JspC's ServletContext Related to r1377509 (reverted), this patch adds support for identifying the effective version of an application and for setting up a JspConfigDescriptor for JspC that would match the one returned by a container at runtime. This should mean that Mark's original change would also work in JspC, allowing the two implementations to be consolidated. This patch does not yet attempt to merge in web-fragment.xml files as that functionality is not supported by the current JspC implementation either. I plan to add that later if this looks like a good way to go. There is also some duplication with implementations in o.a.c.core. Jasper does not have any dependencies on catalina so I did not reuse those. However, these could potentially be moved to o.a.tomcat.util and shared. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
