Bug report for Tomcat 7 [2013/06/16]

2013-06-16 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to|
|18500|New|Enh|2003-03-30|Host aliases to match by regular expression   |
|28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn  |
|40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes  |
|40881|Opn|Enh|2006-11-02|Unable to receive message through  TCP channel -> |
|41007|Opn|Enh|2006-11-20|Can't define customized 503 error page|
|43866|New|Enh|2007-11-14|add support for session attribute propagation with|
|43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing |
|44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr|
|48550|Inf|Enh|2010-01-14|Update examples and default server.xml to use UTF-|
|49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak|
|49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al|
|49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm|
|49821|New|Enh|2010-08-25|Tomcat CLI|
|50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou|
|50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply|
|50234|New|Enh|2010-11-08|JspC use servlet 3.0 features |
|50504|New|Enh|2010-12-21|Allow setting query string character set trough re|
|50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern|
|51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class|
|51294|Opn|Enh|2011-05-30|Since 7.0.12 do not work option unpackWARs=true fo|
|51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to |
|51463|New|Enh|2011-07-01|Tomcat.setBaseDir  (package org.apache.catalina.st|
|51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul|
|51526|New|Enh|2011-07-18|Process web application context config with embedd|
|51587|New|Enh|2011-07-29|Implement status and uptime commands  |
|51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter  |
|52092|New|Enh|2011-10-26|Please make AsyncFileHandler and OneLineFormatter |
|52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site|
|52323|New|Enh|2011-12-13|Cobertura test code coverage support for build.xml|
|52381|New|Enh|2011-12-22|Please add OSGi metadata  |
|52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up|
|52489|New|Enh|2012-01-19|Enhancement request for code signing of war files |
|52558|New|Enh|2012-01-30|CometConnectionManagerValve is adding non-serializ|
|52688|New|Enh|2012-02-16|Add ability to remove old access log files|
|52751|Opn|Enh|2012-02-23|Optimized configuration of the system info display|
|52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s|
|53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota|
|53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr|
|53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf|
|53492|New|Enh|2012-07-01|Make JspC shell multithreaded |
|53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from |
|53602|New|Enh|2012-07-25|Support for HTTP status code 451  |
|53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l|
|53665|New|Enh|2012-08-06|Minor JNDI Howto document enhancement concerning m|
|53776|New|Enh|2012-08-24|Multitenancy support for JDBCRealm|
|53777|New|Enh|2012-08-24|Ability to bundle JAAS Configuration in Webappp   |
|54013|New|Enh|2012-10-16|Catalina.sh force kill to wait till process exits |
|54083|New|Enh|2012-10-31|Provide jarsToSkip on a per-webapp basis  |
|54330|New|Enh|2012-12-19|Patch with some refactoring of Member.java|
|54499|New|Enh|2013-01-29|Implementation of Extensible EL Interpreter   |
|54618|

Bug report for Tomcat 8 [2013/06/16]

2013-06-16 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs|
|53737|Opn|Enh|2012-08-18|Use ServletContext.getJspConfigDescriptor() in Jas|
|53930|New|Enh|2012-09-24|allow capture of catalina stdout/stderr to a comma|
|53987|New|Enh|2012-10-09|Log uncovered HTTP methods in combined security co|
|54095|New|Enh|2012-11-03|[patch] support gzipped versions of static resourc|
|54503|New|Enh|2013-01-29|SAML2 based single sign on|
|54522|New|Nor|2013-02-04|Add patch binary as prerequisite in BUILDING.txt  |
|54700|New|Enh|2013-03-15|Improvement: Add support for system property to sp|
|54741|New|Enh|2013-03-22|Add org.apache.catalina.startup.Tomcat#addWebapp(S|
|54745|New|Enh|2013-03-22|Tomcat JarScanning does not work when Tomcat start|
|55006|New|Enh|2013-05-22|Add http proxy support for ClientEndpoint using sy|
|55101|New|Enh|2013-06-15|BasicAuthenticator parser and associated unit test|
|55102|New|Enh|2013-06-15|Add ability to report time taken to prepare respon|
+-+---+---+--+--+
| Total   13 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Taglibs [2013/06/16]

2013-06-16 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field   |
|38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)|
|42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements   |
|46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l|
|48333|New|Enh|2009-12-02|TLD generator |
+-+---+---+--+--+
| Total5 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat 6 [2013/06/16]

2013-06-16 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat|
|41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific|
|43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant|
|43400|New|Enh|2007-09-14|enum support for tag libs |
|43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml   |
|43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor|
|43742|New|Enh|2007-10-30|.tag compiles  performed one at a time -- extremel|
|43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output |
|44199|New|Enh|2008-01-10|expose current backlog queue size |
|44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f|
|44294|New|Enh|2008-01-25|Support for EL functions with varargs |
|44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam|
|44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt|
|44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin|
|45014|New|Enh|2008-05-15|Request and Response classes should have wrappers |
|45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets|
|45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete  |
|45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks|
|45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or |
|45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE|
|45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output|
|46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c|
|46263|New|Enh|2008-11-21|Tomcat reloading of context.xml does not update do|
|46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl|
|46350|New|Enh|2008-12-05|Maven repository should contain source bundles|
|46558|Opn|Enh|2009-01-19|Shutdown port with address binding|
|46727|New|Enh|2009-02-17|DefaultServlet - serving multiple encodings   |
|46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch|
|47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho|
|47242|New|Enh|2009-05-22|request for AJP command line client   |
|47281|New|Enh|2009-05-28|Efficiency of the JDBCStore   |
|47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session|
|47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath|
|47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked|
|47919|New|Enh|2009-09-30|Log Tomcat & Java environment variables in additio|
|48358|Opn|Enh|2009-12-09|JSP-unloading reloaded|
|48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.|
|48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b|
|48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe|
|48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr|
|48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems|
|48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static|
|48928|New|Enh|2010-03-17|An alternative solution to preloading classes when|
|49161|New|Enh|2010-04-21|Unknown Publisher when installing tomcat 6.0.26   |
|49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient  |
|49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding  |
|49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/|
|49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu|
|49939|New|Enh|2010-09-16|Expose a method via JMX which empties the webapp f|
|49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c|
|50285|New|Enh|2010-11-17|Standard HTTP and AJP connectors silently ignore a|
|50288|

Bug report for Tomcat Connectors [2013/06/16]

2013-06-16 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo|
|35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName|
|43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn|
|43968|Inf|Enh|2007-11-26|[patch] support ipv6 with mod_jk  |
|44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan|
|44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s|
|44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 |
|44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc|
|44571|New|Enh|2008-03-10|Limits busy per worker to a threshold |
|45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff|
|45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so|
|46337|New|Nor|2008-12-04|real worker name is wrong |
|46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca|
|47327|New|Enh|2009-06-07|remote_user not logged in apache logfile  |
|47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err|
|47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_|
|47714|New|Cri|2009-08-20|Reponse mixed between users   |
|47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus|
|47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit|
|47840|Inf|Min|2009-09-14|A broken worker name is written in the log file.  |
|48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the|
|48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio|
|48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert|
|48513|New|Enh|2010-01-09|IIS Quick setup instructions  |
|48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker  |
|48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv|
|48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk |
|49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form|
|49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work|
|49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat |
|49469|New|Enh|2010-06-19|Workers status page has negative number of connect|
|49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. |
|49822|New|Enh|2010-08-25|Add hash lb worker method |
|49903|New|Enh|2010-09-09|Make workers file reloadable  |
|50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c|
|52334|New|Maj|2011-12-14|recover_time is not properly used |
|52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus|
|52651|New|Nor|2012-02-13|JKSHMFile size limitation |
|53324|Opn|Nor|2012-05-30|Starting with mod_jk 1.2.35 I cannot modify worker|
|53542|New|Min|2012-07-13|Spelling mistake on 503 service unavailable page  |
|53762|New|Nor|2012-08-22|JK status manager: mass nodes handling doesn't wor|
|53883|New|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe  on the p|
|53977|New|Maj|2012-10-07|32bits isapi connector cannot work in wow64 mode  |
|54027|New|Cri|2012-10-18|isapi send request to outside address instead of i|
|54112|Opn|Blk|2012-11-07|ISAPI redirector not working when IIS recycles|
|54117|New|Maj|2012-11-08|access violation exception in isapi_redirect.dll  |
|54177|New|Nor|2012-11-20|jkmanager generates non-well-formed XML for certai|
|54596|New|Nor|2013-02-22|Relative paths truncates last character of values |
|54621|New|Nor|2013-02-28|[PATCH] custom mod_jk availability checks |
|54646|New|Trv|2013-03-06|socket_keepalive is sometimes 1 or true or True in|
|54923|New|Nor|2013-05-03|nsapi_redirect.so does not work with iPlanet on So|
|55094|

Bug report for Tomcat Native [2013/06/16]

2013-06-16 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|46179|Opn|Maj|2008-11-10|apr ssl client authentication |
|48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown|
|49038|Inf|Nor|2010-04-02|Crash in tcnative |
|51655|New|Nor|2011-08-12|Index page does not say what native does  |
|51813|New|Cri|2011-09-14|Tomcat randomly crashes with [libtcnative-1.so.1+0|
|52153|New|Maj|2011-11-08|periodic JVM crash (access violation) on buffer fl|
|52319|New|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da]  sig|
|52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i|
|53110|New|Cri|2012-04-20|Access Violation Error while creating SHM |
|53605|New|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash   |
|53847|Inf|Nor|2012-09-10|High CPU usage in tomcat native 1.22+ |
|53937|New|Reg|2012-09-26|Double call to apr_pool_destroy() if OCSP checking|
|53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration|
|53952|New|Nor|2012-10-02|Add support for TLS 1.1 and 1.2   |
|54085|New|Nor|2012-11-01|ssl_socket_recv sometimes loops infinitely with no|
|54664|New|Reg|2013-03-11|[1.1.27 branch] Poll.remove incorrectly reports AP|
|55087|New|Cri|2013-06-10|tomcat crashes in tcnative-1.dll with OCSP when OC|
+-+---+---+--+--+
| Total   17 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat Modules [2013/06/16]

2013-06-16 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers |
|48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite  |
|48861|New|Nor|2010-03-04|Files without AL headers  |
|49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean   |
|49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da|
|50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen|
|51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho|
|51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods   |
|52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o|
|53088|Opn|Min|2012-04-17|Give PoolCleaner TimerTask a better name  |
|53198|New|Cri|2012-05-07|'driverClassName' Data Source Property Being Manda|
|53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe|
|53200|New|Enh|2012-05-07|Be able to use SlowQueryReport without reporting f|
|53770|New|Enh|2012-08-23|tomcat-pool: always log validation query syntax er|
|53853|New|Nor|2012-09-11|Can tomcat-jdbc consider Thread#getContextClassLoa|
|54225|New|Nor|2012-11-30|if initSQL property is set to an empty string a Nu|
|54227|New|Nor|2012-11-30|maxAge should be checked on borrow|
|54235|New|Nor|2012-12-03|tomcat jdbc pool stackoverflow error used with spr|
|54395|New|Nor|2013-01-09|JdbcInterceptor config parameter parsing errors   |
|54437|New|Enh|2013-01-16|Update PoolProperties javadoc for ConnectState int|
|54537|New|Cri|2013-02-07|StatementFinalizer closeInvoked is too slow for la|
|54693|New|Enh|2013-03-13|Add a validationQueryTimeout property |
|54929|New|Nor|2013-05-05|jdbc-pool cannot be used with Java 1.5, "java.lang|
|54978|New|Nor|2013-05-15|Validate on Borrow should be tested on Reconnect i|
|55031|New|Nor|2013-05-30|Update MANIFEST.MF for OSGi headers   |
+-+---+---+--+--+
| Total   25 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1493490 - /tomcat/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java

2013-06-16 Thread markt
Author: markt
Date: Sun Jun 16 10:19:29 2013
New Revision: 1493490

URL: http://svn.apache.org/r1493490
Log:
Method doesn't throw an exception

Modified:
tomcat/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java?rev=1493490&r1=1493489&r2=1493490&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java Sun 
Jun 16 10:19:29 2013
@@ -195,7 +195,7 @@ public class InternalOutputBuffer extend
 
 
 @Override
-protected void registerWriteInterest() throws IOException {
+protected void registerWriteInterest() {
 // NO-OP for non-blocking connector
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1493491 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2013-06-16 Thread markt
Author: markt
Date: Sun Jun 16 10:29:13 2013
New Revision: 1493491

URL: http://svn.apache.org/r1493491
Log:
Fix a TODO.

Modified:
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java?rev=1493491&r1=1493490&r2=1493491&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Sun 
Jun 16 10:29:13 2013
@@ -821,8 +821,8 @@ public abstract class AbstractHttp11Proc
 try {
 isReady.set(getOutputBuffer().isReady());
 } catch (IOException e) {
-// TODO
-throw new IllegalStateException();
+getLog().debug("isReady() failed", e);
+error = true;
 }
 } else if (actionCode == ActionCode.NB_READ_INTEREST) {
 registerForEvent(true, false);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: MD5Encoder.encode versus HexUtils.toHexString

2013-06-16 Thread Mark Thomas
On 15/06/2013 16:39, Christopher Schultz wrote:
> All,
> 
> While looking into a patch for BasicRealm, I noticed that there are two
> classes that convert byte[] to a hex-encoded string (e.g. byte[] { 1, 2,
> a, b ] -> "12ab"): HexUtils and MD5Encoder.

That isn't what those methods do. There are 2 output characters for each
input byte.

> MD5Encoder only has a single method (encode) and it does exactly what
> HexUtils.toHexString does, except that it only works for exactly 16-byte
> arrays.

Agreed.

> I haven't actually written any performance tests, but looking at the
> code it seems that HexUtils.toHexString would execute slightly faster
> for a 16-byte array because of repeated integer multiplication in the loop.

I'd want to see some hard numbers on both methods before making are
decisions based on performance.

> Is there a reason for MD5Encoder to exist? It appears only to be used in
> the following classes:
> 
>   RealmBase
>   DigestAuthenticator
>   WebdavServlet

The check that the input is exactly 16 bytes might be a useful one in
that it confirms other code is behaving as expected.

I just took a look and in every case it is converting the output of a
call to MessageDigest.digest() for an MD5 digest. I don't see a need to
confirm that the JRE is behaving as expected here.

> Although I suppose a specialty 16-byte-only method might be written to
> be slightly faster than the general-purpose HexUtils.toHexString method,
> I'm not sure it's worth having a separate class/method to do it.
> 
> Any objections to using HexUtils.toHexString uniformly and removing the
> MD5Encoder class entirely?

In Tomcat 8, no objections here.

In Tomcat 7, MD5Encoder will have to remain but be deprecated.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1493526 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractOutputBuffer.java InternalAprOutputBuffer.java InternalNioOutputBuffer.java InternalOutputBuffer.java

2013-06-16 Thread markt
Author: markt
Date: Sun Jun 16 16:20:24 2013
New Revision: 1493526

URL: http://svn.apache.org/r1493526
Log:
Pull up common constructor code

Modified:
tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java
tomcat/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java
tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java
tomcat/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java?rev=1493526&r1=1493525&r2=1493526&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java Sun 
Jun 16 16:20:24 2013
@@ -119,6 +119,24 @@ public abstract class AbstractOutputBuff
 protected int bufferedWriteSize = 64*1024; //64k default write buffer
 
 
+protected AbstractOutputBuffer(Response response, int headerBufferSize) {
+
+this.response = response;
+
+headerBuffer = new byte[headerBufferSize];
+
+filterLibrary = new OutputFilter[0];
+activeFilters = new OutputFilter[0];
+lastActiveFilter = -1;
+
+committed = false;
+finished = false;
+
+// Cause loading of HttpMessages
+HttpMessages.getMessage(200);
+}
+
+
 // -- Variables
 
 /**

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java?rev=1493526&r1=1493525&r2=1493526&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java Sun 
Jun 16 16:20:24 2013
@@ -28,7 +28,6 @@ import org.apache.coyote.Response;
 import org.apache.tomcat.jni.Socket;
 import org.apache.tomcat.jni.Status;
 import org.apache.tomcat.util.buf.ByteChunk;
-import org.apache.tomcat.util.http.HttpMessages;
 import org.apache.tomcat.util.net.AbstractEndpoint;
 import org.apache.tomcat.util.net.AprEndpoint;
 import org.apache.tomcat.util.net.SocketWrapper;
@@ -47,9 +46,8 @@ public class InternalAprOutputBuffer ext
  */
 public InternalAprOutputBuffer(Response response, int headerBufferSize) {
 
-this.response = response;
+super(response, headerBufferSize);
 
-headerBuffer = new byte[headerBufferSize];
 if (headerBufferSize < (8 * 1024)) {
 bbuf = ByteBuffer.allocateDirect(6 * 1500);
 } else {
@@ -57,17 +55,6 @@ public class InternalAprOutputBuffer ext
 }
 
 outputStreamOutputBuffer = new SocketOutputBuffer();
-
-filterLibrary = new OutputFilter[0];
-activeFilters = new OutputFilter[0];
-lastActiveFilter = -1;
-
-committed = false;
-finished = false;
-
-// Cause loading of HttpMessages
-HttpMessages.getMessage(200);
-
 }
 
 
@@ -362,7 +349,7 @@ public class InternalAprOutputBuffer ext
 int len = chunk.getLength();
 int start = chunk.getStart();
 byte[] b = chunk.getBuffer();
-addToBB(b, start,len);
+addToBB(b, start, len);
 byteCount += chunk.getLength();
 return chunk.getLength();
 }

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java?rev=1493526&r1=1493525&r2=1493526&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java Sun 
Jun 16 16:20:24 2013
@@ -27,7 +27,6 @@ import java.util.concurrent.atomic.Atomi
 import org.apache.coyote.OutputBuffer;
 import org.apache.coyote.Response;
 import org.apache.tomcat.util.buf.ByteChunk;
-import org.apache.tomcat.util.http.HttpMessages;
 import org.apache.tomcat.util.net.AbstractEndpoint;
 import org.apache.tomcat.util.net.NioChannel;
 import org.apache.tomcat.util.net.NioEndpoint;
@@ -49,22 +48,9 @@ public class InternalNioOutputBuffer ext
  */
 public InternalNioOutputBuffer(Response response, int headerBufferSize) {
 
-this.response = response;
-
-headerBuffer = new byte[headerBufferSize];
+super(response, headerBufferSize);
 
 outputStreamOutputBuffer = new SocketOutputBuffer();
-
-filterLibrary = new OutputFilter[0];
-activeFilters = new OutputFilter[0];

[Bug 55104] New: Allow passing arguments with spaces to Commons Daemon

2013-06-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55104

Bug ID: 55104
   Summary: Allow passing arguments with spaces to Commons Daemon
   Product: Tomcat 7
   Version: 7.0.41
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Integration
  Assignee: dev@tomcat.apache.org
  Reporter: marko.aspl...@gmail.com

With the current version of the Commons Daemon wrapper script (daemon.sh) it's
not possible to pass arguments with spaces to jsvc.

For example jsvc fails to start with the following command:

JSVC_OPTS="-XX:OnOutOfMemoryError='/bin/ls foo bar'" daemon.sh start

The attached patch makes it possible to pass arguments with spaces to Commons
Daemon like this:

daemon.sh start -XX:OnOutOfMemoryError='/bin/ls foo bar'

The patch also allows daemon.sh invoker override hardcoded arguments (i.e.
"-wait"). Overriding the current wait default value is often required because
Tomcat startup may take a long time due to entropy read operation blocking by
default on Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55104] Allow passing arguments with spaces to Commons Daemon

2013-06-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55104

--- Comment #1 from marko asplund  ---
Created attachment 30446
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30446&action=edit
allow passing arguments with spaces

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55104] Allow passing arguments with spaces to Commons Daemon

2013-06-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55104

marko asplund  changed:

   What|Removed |Added

 CC||marko.aspl...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53770] tomcat-pool: always log validation query syntax errors

2013-06-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53770

marko asplund  changed:

   What|Removed |Added

 CC||marko.aspl...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55017] Ability to configure RMI bind address

2013-06-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017

--- Comment #11 from Alexey Noskov  ---
Are there other areas in which this patch should be improved?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1493584 - in /tomcat/trunk: res/findbugs/filter-false-positives.xml test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java

2013-06-16 Thread markt
Author: markt
Date: Sun Jun 16 21:14:37 2013
New Revision: 1493584

URL: http://svn.apache.org/r1493584
Log:
Fix FindBugs warnings in test code

Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml

tomcat/trunk/test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1493584&r1=1493583&r2=1493584&view=diff
==
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Sun Jun 16 21:14:37 
2013
@@ -466,6 +466,11 @@
 
   
   
+
+
+
+  
+  
 
   
   
@@ -586,4 +591,13 @@
 
 
   
+  
+
+
+
+  
+  
+
+
+  
 
\ No newline at end of file

Modified: 
tomcat/trunk/test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java?rev=1493584&r1=1493583&r2=1493584&view=diff
==
--- 
tomcat/trunk/test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java
 (original)
+++ 
tomcat/trunk/test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java
 Sun Jun 16 21:14:37 2013
@@ -126,7 +126,7 @@ public class TestApplicationSessionCooki
 }
 
 private static class CustomContext extends StandardContext {
-private LifecycleState state;
+private volatile LifecycleState state;
 
 @Override
 public LifecycleState getState() {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1493584 - in /tomcat/trunk: res/findbugs/filter-false-positives.xml test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java

2013-06-16 Thread Nick Williams

On Jun 16, 2013, at 4:14 PM, ma...@apache.org wrote:

> Author: markt
> Date: Sun Jun 16 21:14:37 2013
> New Revision: 1493584
> 
> URL: http://svn.apache.org/r1493584
> Log:
> Fix FindBugs warnings in test code
> 
> Modified:
>tomcat/trunk/res/findbugs/filter-false-positives.xml
>
> tomcat/trunk/test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java
> 
> Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1493584&r1=1493583&r2=1493584&view=diff
> ==
> --- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
> +++ tomcat/trunk/res/findbugs/filter-false-positives.xml Sun Jun 16 21:14:37 
> 2013
> @@ -466,6 +466,11 @@
> 
>   
>   
> + name="org.apache.catalina.core.TestApplicationSessionCookieConfig$CustomContext"
>  />
> +
> +
> +  
> +  

Maybe it's just me, but it seems like you should be a little more specific 
here. Specifying the method or methods and the full bug pattern instead of the 
code (prefix) would prevent false-negatives if other bugs arose. Of course, at 
the moment there is only one bug pattern that starts with UG_, but that could 
change in future versions.

> 
>   
>   
> @@ -586,4 +591,13 @@
> 
> 
>   
> +  
> +
> +
> +
> +  
> +  
> +
> +
> +  
> 

Same thing. The method names are great here, but there are six bug patterns 
that start with DLS_. Are you really meaning to suppress all six of them?

Just my $0.02.

> \ No newline at end of file
> 
> Modified: 
> tomcat/trunk/test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java?rev=1493584&r1=1493583&r2=1493584&view=diff
> ==
> --- 
> tomcat/trunk/test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java
>  (original)
> +++ 
> tomcat/trunk/test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java
>  Sun Jun 16 21:14:37 2013
> @@ -126,7 +126,7 @@ public class TestApplicationSessionCooki
> }
> 
> private static class CustomContext extends StandardContext {
> -private LifecycleState state;
> +private volatile LifecycleState state;
> 
> @Override
> public LifecycleState getState() {
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1493605 - in /tomcat/trunk/java/org/apache/tomcat/websocket/pojo: PojoMessageHandlerPartialBase.java PojoMessageHandlerWholeBase.java

2013-06-16 Thread markt
Author: markt
Date: Sun Jun 16 23:06:51 2013
New Revision: 1493605

URL: http://svn.apache.org/r1493605
Log:
Fix FindBugs warnings. params is never null so no need to test for null

Modified:

tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java

tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java

Modified: 
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java?rev=1493605&r1=1493604&r2=1493605&view=diff
==
--- 
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java
 (original)
+++ 
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java
 Sun Jun 16 23:06:51 2013
@@ -48,8 +48,7 @@ public abstract class PojoMessageHandler
 
 @Override
 public final void onMessage(T message, boolean last) {
-if (params != null && params.length == 1 &&
-params[0] instanceof DecodeException) {
+if (params.length == 1 && params[0] instanceof DecodeException) {
 ((WsSession) session).getLocal().onError(session,
 (DecodeException) params[0]);
 return;

Modified: 
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java?rev=1493605&r1=1493604&r2=1493605&view=diff
==
--- 
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java
 (original)
+++ 
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java
 Sun Jun 16 23:06:51 2013
@@ -45,8 +45,7 @@ public abstract class PojoMessageHandler
 @Override
 public final void onMessage(T message) {
 
-if (params != null && params.length == 1 &&
-params[0] instanceof DecodeException) {
+if (params.length == 1 && params[0] instanceof DecodeException) {
 ((WsSession) session).getLocal().onError(session,
 (DecodeException) params[0]);
 return;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1493607 - /tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java

2013-06-16 Thread markt
Author: markt
Date: Sun Jun 16 23:12:04 2013
New Revision: 1493607

URL: http://svn.apache.org/r1493607
Log:
Fix a FindBugs warning. Correctly handle a timeout.

Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java

Modified: 
tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java?rev=1493607&r1=1493606&r2=1493607&view=diff
==
--- 
tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java 
(original)
+++ 
tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java 
Sun Jun 16 23:12:04 2013
@@ -472,7 +472,10 @@ public class AsyncChannelWrapperSecure i
 public T get(long timeout, TimeUnit unit)
 throws InterruptedException, ExecutionException,
 TimeoutException {
-completionLatch.await(timeout, unit);
+boolean latchResult = completionLatch.await(timeout, unit);
+if (latchResult == false) {
+throw new TimeoutException();
+}
 if (throwable != null) {
 throw new ExecutionException(throwable);
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1493584 - in /tomcat/trunk: res/findbugs/filter-false-positives.xml test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java

2013-06-16 Thread Mark Thomas
On 16/06/2013 22:32, Nick Williams wrote:
> 
> On Jun 16, 2013, at 4:14 PM, ma...@apache.org wrote:
> 
>> Author: markt Date: Sun Jun 16 21:14:37 2013 New Revision: 1493584

> Maybe it's just me, but it seems like you should be a little more
> specific here. Specifying the method or methods and the full bug
> pattern instead of the code (prefix) would prevent false-negatives if
> other bugs arose. Of course, at the moment there is only one bug
> pattern that starts with UG_, but that could change in future
> versions.

Patches welcome.

> Same thing. The method names are great here, but there are six bug
> patterns that start with DLS_. Are you really meaning to suppress all
> six of them?

Ditto.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1493612 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2013-06-16 Thread markt
Author: markt
Date: Sun Jun 16 23:19:53 2013
New Revision: 1493612

URL: http://svn.apache.org/r1493612
Log:
More false positives

Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1493612&r1=1493611&r2=1493612&view=diff
==
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Sun Jun 16 23:19:53 
2013
@@ -202,6 +202,20 @@
 
 
 
+
+  
+  
+
+
+
+
+
+  
+  
+
+
+
+
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1493615 - /tomcat/trunk/java/org/apache/tomcat/util/codec/binary/BaseNCodec.java

2013-06-16 Thread markt
Author: markt
Date: Sun Jun 16 23:32:31 2013
New Revision: 1493615

URL: http://svn.apache.org/r1493615
Log:
Fix FindBugs warning - better debug message

Modified:
tomcat/trunk/java/org/apache/tomcat/util/codec/binary/BaseNCodec.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/codec/binary/BaseNCodec.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/codec/binary/BaseNCodec.java?rev=1493615&r1=1493614&r2=1493615&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/codec/binary/BaseNCodec.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/codec/binary/BaseNCodec.java Sun 
Jun 16 23:32:31 2013
@@ -16,6 +16,7 @@
  */
 package org.apache.tomcat.util.codec.binary;
 
+import org.apache.tomcat.util.buf.HexUtils;
 import org.apache.tomcat.util.codec.BinaryDecoder;
 import org.apache.tomcat.util.codec.BinaryEncoder;
 import org.apache.tomcat.util.codec.DecoderException;
@@ -97,8 +98,10 @@ public abstract class BaseNCodec impleme
 @SuppressWarnings("boxing") // OK to ignore boxing here
 @Override
 public String toString() {
-return String.format("%s[buffer=%s, currentLinePos=%s, eof=%s, 
ibitWorkArea=%s, lbitWorkArea=%s, " +
-"modulus=%s, pos=%s, readPos=%s]", 
this.getClass().getSimpleName(), buffer, currentLinePos, eof,
+return String.format("%s[buffer=%s, currentLinePos=%s, eof=%s, " +
+"ibitWorkArea=%s, lbitWorkArea=%s, modulus=%s, pos=%s, " +
+"readPos=%s]", this.getClass().getSimpleName(),
+HexUtils.toHexString(buffer), currentLinePos, eof,
 ibitWorkArea, lbitWorkArea, modulus, pos, readPos);
 }
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Created] (MTOMCAT-228) Provide option to deploy war file(s) from a location when executing run mojo

2013-06-16 Thread Peter Nguyen (JIRA)
Peter Nguyen created MTOMCAT-228:


 Summary: Provide option to deploy war file(s) from a location when 
executing run mojo
 Key: MTOMCAT-228
 URL: https://issues.apache.org/jira/browse/MTOMCAT-228
 Project: Apache Tomcat Maven Plugin
  Issue Type: Improvement
Reporter: Peter Nguyen
Priority: Minor


Can we please add the ability to deploy a war file from a location instead of 
the m2 repository (via webapps) when running the run mojo?

I currently have a multi module project that contains two sub projects: a 
project containing a war file and it's sibling containing a suite of selenium 
tests 

project-parent
+-- war-project (war project)
+-- integration-tests (non-war project)

I'd like to have the integration tests start up an embedded server and deploy 
the war file from the project containing the web app. It seems I can only do 
this if the artifact under test has been installed and deployed via the 
 configuration.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org