svn commit: r1479482 - in /tomcat/trunk/test/webapp-3.0/bug5nnnn: bug54801a.jspx bug54801b.jspx bug54821a.jspx bug54821b.jspx
Author: rjung
Date: Mon May 6 08:00:40 2013
New Revision: 1479482
URL: http://svn.apache.org/r1479482
Log:
Set svn:eol-style native.
Modified:
tomcat/trunk/test/webapp-3.0/bug5/bug54801a.jspx (contents, props
changed)
tomcat/trunk/test/webapp-3.0/bug5/bug54801b.jspx (contents, props
changed)
tomcat/trunk/test/webapp-3.0/bug5/bug54821a.jspx (contents, props
changed)
tomcat/trunk/test/webapp-3.0/bug5/bug54821b.jspx (contents, props
changed)
Modified: tomcat/trunk/test/webapp-3.0/bug5/bug54801a.jspx
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp-3.0/bug5/bug54801a.jspx?rev=1479482&r1=1479481&r2=1479482&view=diff
==
--- tomcat/trunk/test/webapp-3.0/bug5/bug54801a.jspx (original)
+++ tomcat/trunk/test/webapp-3.0/bug5/bug54801a.jspx Mon May 6 08:00:40
2013
@@ -1,23 +1,23 @@
-
-
-http://java.sun.com/JSP/Page"; version="2.0">
-
+
+
+http://java.sun.com/JSP/Page"; version="2.0">
+
\ No newline at end of file
Propchange: tomcat/trunk/test/webapp-3.0/bug5/bug54801a.jspx
--
svn:eol-style = native
Modified: tomcat/trunk/test/webapp-3.0/bug5/bug54801b.jspx
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp-3.0/bug5/bug54801b.jspx?rev=1479482&r1=1479481&r2=1479482&view=diff
==
--- tomcat/trunk/test/webapp-3.0/bug5/bug54801b.jspx (original)
+++ tomcat/trunk/test/webapp-3.0/bug5/bug54801b.jspx Mon May 6 08:00:40
2013
@@ -1,23 +1,23 @@
-
-
-http://java.sun.com/JSP/Page"; version="2.0">
-
- // ${foo}
- out.println("Hello, world!!");
-
+
+
+http://java.sun.com/JSP/Page"; version="2.0">
+
+ // ${foo}
+ out.println("Hello, world!!");
+
\ No newline at end of file
Propchange: tomcat/trunk/test/webapp-3.0/bug5/bug54801b.jspx
--
svn:eol-style = native
Modified: tomcat/trunk/test/webapp-3.0/bug5/bug54821a.jspx
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp-3.0/bug5/bug54821a.jspx?rev=1479482&r1=1479481&r2=1479482&view=diff
==
--- tomcat/trunk/test/webapp-3.0/bug5/bug54821a.jspx (original)
+++ tomcat/trunk/test/webapp-3.0/bug5/bug54821a.jspx Mon May 6 08:00:40
2013
@@ -1,21 +1,21 @@
-
-
-http://java.sun.com/JSP/Page"; version="2.0">
-
-${Hello, world!!}
+
+
+http://java.sun.com/JSP/Page"; version="2.0">
+
+${Hello, world!!}
\ No newline at end of file
Propchange: tomcat/trunk/test/webapp-3.0/bug5/bug54821a.jspx
--
svn:eol-style = native
Modified: tomcat/trunk/test/webapp-3.0/bug5/bug54821b.jspx
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp-3.0/bug5/bug54821b.jspx?rev=1479482&r1=1479481&r2=1479482&view=diff
==
--- tomcat/trunk/test/webapp-3.0/bug5/bug54821b.jspx (original)
+++ tomcat/trunk/test/webapp-3.0/bug5/bug54821b.jspx Mon May 6 08:00:40
2013
@@ -1,21 +1,21 @@
-
-
-http://java.sun.com/JSP/Page"; version="2.0">
-
-${Hello, world!!
+
+
+http://java.sun.com/JSP/Page"; version="2.0">
+
+${Hello, world!!
\ No newline at end of file
Propchange: tomcat/trunk/test/webapp-3.0/bug5/bug54821b.jspx
--
svn:eol-style = native
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1479483 - in /tomcat/tc7.0.x/trunk: ./ test/webapp-3.0/bug5nnnn/bug54801a.jspx test/webapp-3.0/bug5nnnn/bug54801b.jspx test/webapp-3.0/bug5nnnn/bug54821a.jspx test/webapp-3.0/bug5nnnn/bug
Author: rjung
Date: Mon May 6 08:03:52 2013
New Revision: 1479483
URL: http://svn.apache.org/r1479483
Log:
Set svn:eol-style native.
Backport of r1479482 from trunk.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801a.jspx (contents,
props changed)
tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801b.jspx (contents,
props changed)
tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821a.jspx (contents,
props changed)
tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821b.jspx (contents,
props changed)
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1479482
Modified: tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801a.jspx
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801a.jspx?rev=1479483&r1=1479482&r2=1479483&view=diff
==
--- tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801a.jspx (original)
+++ tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801a.jspx Mon May 6
08:03:52 2013
@@ -1,23 +1,23 @@
-
-
-http://java.sun.com/JSP/Page"; version="2.0">
-
+
+
+http://java.sun.com/JSP/Page"; version="2.0">
+
\ No newline at end of file
Propchange: tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801a.jspx
--
svn:eol-style = native
Modified: tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801b.jspx
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801b.jspx?rev=1479483&r1=1479482&r2=1479483&view=diff
==
--- tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801b.jspx (original)
+++ tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801b.jspx Mon May 6
08:03:52 2013
@@ -1,23 +1,23 @@
-
-
-http://java.sun.com/JSP/Page"; version="2.0">
-
- // ${foo}
- out.println("Hello, world!!");
-
+
+
+http://java.sun.com/JSP/Page"; version="2.0">
+
+ // ${foo}
+ out.println("Hello, world!!");
+
\ No newline at end of file
Propchange: tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54801b.jspx
--
svn:eol-style = native
Modified: tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821a.jspx
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821a.jspx?rev=1479483&r1=1479482&r2=1479483&view=diff
==
--- tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821a.jspx (original)
+++ tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821a.jspx Mon May 6
08:03:52 2013
@@ -1,21 +1,21 @@
-
-
-http://java.sun.com/JSP/Page"; version="2.0">
-
-${Hello, world!!}
+
+
+http://java.sun.com/JSP/Page"; version="2.0">
+
+${Hello, world!!}
\ No newline at end of file
Propchange: tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821a.jspx
--
svn:eol-style = native
Modified: tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821b.jspx
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821b.jspx?rev=1479483&r1=1479482&r2=1479483&view=diff
==
--- tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821b.jspx (original)
+++ tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821b.jspx Mon May 6
08:03:52 2013
@@ -1,21 +1,21 @@
-
-
-http://java.sun.com/JSP/Page"; version="2.0">
-
-${Hello, world!!
+
+
+http://java.sun.com/JSP/Page"; version="2.0">
+
+${Hello, world!!
\ No newline at end of file
Propchange: tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug54821b.jspx
--
svn:eol-style = native
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.40
On 05.05.2013 12:44, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.40 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.40/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-001/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_40/ > > The proposed 7.0.40 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 7.0.40 Stable +1 to release. Details: - MD5 OK - signatures OK - key in KEYS file - gz and zip for src and bin consistent - src completely consistent with svn tag - except line ends in 4 jspx files (missing eol-style) fixed now in r1479483. - builds fine - warning about unsafe or unchecked operations in: - javax/el/ResourceBundleELResolver.java:108 - org/apache/catalina/core/AsyncContextImpl.java:270 - org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java (14 times) - org/apache/catalina/ha/context/ReplicatedContext.java:66 - org/apache/catalina/ha/session/BackupManager.java:169 - org/apache/catalina/tribes/group/interceptors/TwoPhaseCommitInterceptor.java:119 - org/apache/coyote/http11/AbstractHttp11Processor.java:820 Same as for 7.0.39 plus http11.AbstractHttp11Processor. - build result looks consistent with binaries - no checkstyle complaints - some Javadoc warnings - only one remaining in jdbc-pool, better than before - Unit tests no errors or failures - the previous SEVERE message (144 times) with exception stack in Echo servlet when running TestInputBuffer is now fixed. - JMX MBean-Comparison OK - unchanged except new tools.jar in jarsToSkip Build and tests were done using Java 1.6.0_45. OS was Solaris 10 Sparc, tcnative was 1.1.27 based on APR 1.4.6 and OpenSSL 1.0.1e (plus a few patches). Unit test warnings (very similar to 7.0.35 and before): - org.apache.catalina.deploy.TestWebXmlOrdering - BIO, NIO and APR: [main] org.apache.catalina.deploy.WebXml.orderWebFragments Used a wrong fragment name z at web.xml absolute-ordering tag! - org.apache.tomcat.util.net.TestCustomSsl - BIO twice "Exception getting SSL attributes" in org.apache.coyote.http11.Http11Processor actionInternal exception is: javax.net.ssl.SSLProtocolException: handshake alert: no_certificate - NIO twice "WARNING: Exception re-negotiating SSL connection" in org.apache.coyote.http11.Http11NioProcessor actionInternal - tribes: several warnings (18), numbers down to the level of 7.0.38 after the temporary rise in 7.0.39 Unit test SEVERE messages: 225 total (-141). The drop is due to silencing the Echo servlet. We are now back to 7.0.37 numbers. About 20 unique messages. Most of those are of type "Servlet.service() for servlet ... threw exception" (137 times, unchanged). Second biggest block: Countmessage 27 [junit] TIMESTAMP SEVERE [main] org.apache.tomcat.util.digester.Digester.startElement Begin event threw exception 3 [junit] TIMESTAMP SEVERE [main] org.apache.tomcat.util.digester.Digester.endElement End event threw exception Third biggest block is 24 messages from the mem leak detection during context unload. "Exception" in output of unit tests: 217 times (-286, most due to fixed Echo servlet). Numbers are now back to the lower 7.0.37 range. Top exception counts: 75 [junit] javax.servlet.ServletException: Opps. 9 [junit] java.io.IOException: Invalid CRLF, no CR character encountered. 9 [junit] java.lang.IllegalArgumentException: element is limited to 1 occurrence 9 [junit] java.lang.IllegalArgumentException: element is limited to 1 occurrence 9 [junit] java.lang.IllegalArgumentException: element is limited to 1 occurrence 6 [junit] org.apache.jasper.JasperException: /bug49nnn/bug49297DuplicateAttr.jsp (line: 21, column: 46) Attribute qualified names must be unique within an element I'm not claiming that any of the SEVERE or Exception messages are important. Total numbers of warnings, SEVERE and exceptions are about the same than for previous releases. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[ANN] Apache Tomcat 6.0.37 released
The Apache Tomcat team announces the immediate availability of Apache Tomcat 6.0.37 stable. Apache Tomcat 6.0.37 is primarily a security and bug fix release. All users of older versions of the Tomcat 6.0 family should upgrade to 6.0.37. Note that is version has 4 zip binaries: a generic one and three bundled with Tomcat native binaries for different CPU architectures. Apache Tomcat 6.0 includes new features over Apache Tomcat 5.5, including support for the new Servlet 2.5 and JSP 2.1 specifications, a refactored clustering implementation, advanced IO features, and improvements in memory usage. Please refer to the change log for the list of changes: http://tomcat.apache.org/tomcat-6.0-doc/changelog.html Downloads: http://tomcat.apache.org/download-60.cgi Migration guide from Apache Tomcat 5.5.x: http://tomcat.apache.org/migration.html Thank you, -- The Apache Tomcat Team - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54931] New: Updates to windows-service-howto to include support for installing multiple windows services
https://issues.apache.org/bugzilla/show_bug.cgi?id=54931 Bug ID: 54931 Summary: Updates to windows-service-howto to include support for installing multiple windows services Product: Tomcat 7 Version: trunk Hardware: All OS: All Status: NEW Severity: minor Priority: P2 Component: Documentation Assignee: dev@tomcat.apache.org Reporter: ch...@derham.me.uk Classification: Unclassified Created attachment 30257 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30257&action=edit Diff file for windows-service-howto The existing documentation does not explain how to use service.bat to install multiple services on windows. I attach a diff which makes changes that I suggest as included. The diff updates existing entries to include explanation of the 2nd service parameter which allows a service to be named, and creates a new section that explains how to install multiple services. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.40
On 05/05/2013 12:44 PM, Mark Thomas wrote: The proposed 7.0.40 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 7.0.40 Stable Tested install/run on Win7, Win8, Fedora No regressions found. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] Apache Tomcat 6.0.37 released
Do not forget to send this to announce@tomcat.a.o and announce@a.o as well. You need to send those using your @apache.org address, instead of this gmail one. Best regards, Konstantin Kolinko 2013/5/6 jean-frederic clere : > The Apache Tomcat team announces the immediate availability of Apache > Tomcat 6.0.37 stable. > > Apache Tomcat 6.0.37 is primarily a security and bug fix release. All users > of older versions of the Tomcat 6.0 family should upgrade to 6.0.37. > > > Note that is version has 4 zip binaries: a generic one and three > bundled with Tomcat native binaries for different CPU architectures. > > Apache Tomcat 6.0 includes new features over Apache Tomcat 5.5, > including support for the new Servlet 2.5 and JSP 2.1 specifications, a > refactored clustering implementation, advanced IO features, and > improvements in memory usage. > > Please refer to the change log for the list of changes: > http://tomcat.apache.org/tomcat-6.0-doc/changelog.html > > Downloads: > http://tomcat.apache.org/download-60.cgi > > Migration guide from Apache Tomcat 5.5.x: > http://tomcat.apache.org/migration.html > > Thank you, > > -- The Apache Tomcat Team > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.40
On 05.05.2013 12:44, Mark Thomas wrote: The proposed Apache Tomcat 7.0.40 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.40/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-001/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_40/ The proposed 7.0.40 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 7.0.40 Stable I would like to use this release as early as possible, so I picked up the source, built and tested it. I noticed some errors which do not matter in my environment, but because I haven't tested any earlier releases, I don't know whether they are generally acceptable. I couldn't find a reference to them being known problems, and (of course) it could be a "user error". environment: Linux version 3.5.0-28-lowlatency (buildd@roseapple) (gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-2ubuntu1) ) #32-Ubuntu SMP PREEMPT Fri Apr 26 11:05:36 UTC 2013 (Ubuntu 3.5.0-28.32-lowlatency 3.5.7.9) brian@bacchus:~$ /usr/lib/jvm/java-6-openjdk-i386/bin/java -version java version "1.6.0_27" OpenJDK Runtime Environment (IcedTea6 1.12.3) (6b27-1.12.3-0ubuntu1~12.10.1) OpenJDK Server VM (build 20.0-b12, mixed mode) I have /real/ test failures for both BIO and NIO in: TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.?IO.txt TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.?IO.txt TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.?IO.txt TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.?IO.txt for example, one of them is: Testcase: testMemberArrival took 7.191 sec FAILED Checking member arrival length (Listener-10) expected:<9> but was:<0> junit.framework.AssertionFailedError: Checking member arrival length (Listener-10) expected:<9> but was:<0> at org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.testMemberArrival(TestGroupChannelMemberArrival.java:80) I don't want to waste anybody's time, but perhaps you could let me know whether the errors are significant? If you think it is because I've made a simple error in my configuration, perhaps you point me in the right direction to resolve it. Thanks, Brian - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54932] New: Broken link to Tribes documentation
https://issues.apache.org/bugzilla/show_bug.cgi?id=54932 Bug ID: 54932 Summary: Broken link to Tribes documentation Product: Tomcat 7 Version: 7.0.39 Hardware: PC OS: Windows XP Status: NEW Severity: minor Priority: P2 Component: Documentation Assignee: dev@tomcat.apache.org Reporter: knst.koli...@gmail.com Classification: Unclassified 1. Go to http://tomcat.apache.org/tomcat-7.0-doc/ 2. In the menu at the left of the page, scroll down to "Apache Tomcat Development" section and click on "Tribes" link 3. The browser navigates to http://tomcat.apache.org/tomcat-7.0-doc/tribes/index.html which gives error 404 "Not Found". The issue is that - there is no "index.html" in Tribes section - there are pages there, but all they except one are empty, containing only header and "TODO" marker - the correct link (and the only valuable page there) is: http://tomcat.apache.org/tomcat-7.0-doc/tribes/introduction.html Alternatively, linking to http://tomcat.apache.org/tomcat-7.0-doc/tribes/ will provide a listing of all pages in that directory on the server. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.40
Hi Brian, On 06.05.2013 15:39, Brian Burch wrote: > On 05.05.2013 12:44, Mark Thomas wrote: > I would like to use this release as early as possible, so I picked up > the source, built and tested it. I noticed some errors which do not > matter in my environment, but because I haven't tested any earlier > releases, I don't know whether they are generally acceptable. I couldn't > find a reference to them being known problems, and (of course) it could > be a "user error". > > environment: > > Linux version 3.5.0-28-lowlatency (buildd@roseapple) (gcc version 4.7.2 > (Ubuntu/Linaro 4.7.2-2ubuntu1) ) #32-Ubuntu SMP PREEMPT Fri Apr 26 > 11:05:36 UTC 2013 (Ubuntu 3.5.0-28.32-lowlatency 3.5.7.9) > > brian@bacchus:~$ /usr/lib/jvm/java-6-openjdk-i386/bin/java -version > java version "1.6.0_27" > OpenJDK Runtime Environment (IcedTea6 1.12.3) > (6b27-1.12.3-0ubuntu1~12.10.1) > OpenJDK Server VM (build 20.0-b12, mixed mode) > > > I have /real/ test failures for both BIO and NIO in: > TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.?IO.txt > > TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.?IO.txt > > TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.?IO.txt > > TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.?IO.txt > > for example, one of them is: > > Testcase: testMemberArrival took 7.191 sec FAILED > Checking member arrival length (Listener-10) expected:<9> but was:<0> > junit.framework.AssertionFailedError: Checking member arrival length > (Listener-10) expected:<9> but was:<0> > at > org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.testMemberArrival(TestGroupChannelMemberArrival.java:80) > > > > I don't want to waste anybody's time, but perhaps you could let me know > whether the errors are significant? If you think it is because I've made > a simple error in my configuration, perhaps you point me in the right > direction to resolve it. Those failures are not normal. Maybe multicast doesn't work on your system or something similar. A special setup of the tests is usually not needed. I pasted a full output of TestGroupChannelMemberArrival at: http://www.apaste.info/KLUH You might compare with your output to get an idea, how far the test succeeds and where is starts to look strange. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] Apache Tomcat 6.0.37 released
On 05/06/2013 02:33 PM, Konstantin Kolinko wrote: Do not forget to send this to announce@tomcat.a.o and announce@a.o as well. You need to send those using your @apache.org address, instead of this gmail one. I did that from people.apache.org some it doesn't work :-( Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.40
2013/5/6 Brian Burch : > On 05.05.2013 12:44, Mark Thomas wrote: >> >> The proposed Apache Tomcat 7.0.40 release is now available for voting. >> >> It can be obtained from: >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.40/ >> The Maven staging repo is: >> https://repository.apache.org/content/repositories/orgapachetomcat-001/ >> The svn tag is: >> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_40/ >> >> The proposed 7.0.40 release is: >> [ ] Broken - do not release >> [X] Stable - go ahead and release as 7.0.40 Stable > > > I would like to use this release as early as possible, so I picked up the > source, built and tested it. I noticed some errors which do not matter in my > environment, but because I haven't tested any earlier releases, I don't know > whether they are generally acceptable. I couldn't find a reference to them > being known problems, and (of course) it could be a "user error". > > environment: > > Linux version 3.5.0-28-lowlatency (buildd@roseapple) (gcc version 4.7.2 > (Ubuntu/Linaro 4.7.2-2ubuntu1) ) #32-Ubuntu SMP PREEMPT Fri Apr 26 11:05:36 > UTC 2013 (Ubuntu 3.5.0-28.32-lowlatency 3.5.7.9) > > brian@bacchus:~$ /usr/lib/jvm/java-6-openjdk-i386/bin/java -version > java version "1.6.0_27" > OpenJDK Runtime Environment (IcedTea6 1.12.3) (6b27-1.12.3-0ubuntu1~12.10.1) > OpenJDK Server VM (build 20.0-b12, mixed mode) > > > I have /real/ test failures for both BIO and NIO in: > TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.?IO.txt > TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.?IO.txt > TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.?IO.txt > TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.?IO.txt > > for example, one of them is: > > Testcase: testMemberArrival took 7.191 sec FAILED > Checking member arrival length (Listener-10) expected:<9> but was:<0> > junit.framework.AssertionFailedError: Checking member arrival length > (Listener-10) expected:<9> but was:<0> > at > org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.testMemberArrival(TestGroupChannelMemberArrival.java:80) > > > I don't want to waste anybody's time, but perhaps you could let me know > whether the errors are significant? If you think it is because I've made a > simple error in my configuration, perhaps you point me in the right > direction to resolve it. Tribes is communication layer that is used to implement clustering (aka "ha", high availability) http://tomcat.apache.org/tomcat-7.0-doc/tribes/introduction.html If you do not use clustering, then those do not matter for you. You can compare your test log files with ones produced by buildbot: http://ci.apache.org/projects/tomcat/tomcat7/logs/ If you want to (re)run a single test from the testsuite, BUILDING.txt says how to do so. Maybe some network or security configuration at your box prevents those tests from working? IPv6? Any error messages in the logs? The tests respect the "conf/logging.properties" file, so it is possible to enable fine logging if you need so. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.40
On Sun, May 5, 2013 at 6:44 AM, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.40 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.40/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-001/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_40/ > > The proposed 7.0.40 release is: > [ ] Broken - do not release > [ X ] Stable - go ahead and release as 7.0.40 Stable Looks good in home-brewed test app (same one I've been using since 6.0.) Yoav - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Problem with nsapi_redirect.so (1.2.37) on iPlanet 7.0.15 and Solaris 11
Oracle has agreed this is a bug. I've got a query into them to find out what their ETA is. Andy On 05/03/2013 10:01 AM, Andy Wang wrote: On 05/02/2013 01:30 PM, Rainer Jung wrote: Especially since the nsapi docs for systhread_start only tell us that the prio is an int depending on the platform and the only other source of information, nsapi.h only contains a single defined prio, which is SYSTHREAD_DEFAULT_PRIORITY. The other constants PR_PRIORITY_... are defined in nspr/prthread.h and are enum elements of type PRThreadPriority which formally don't qualify as arguments to systhread_start(int prio, int stksz, void (*fn)(void *), void *arg) which needs an int. Yeah, I didn't go as far as dealing with the type differences when complaining to them but I'll make that point as well when I update the call later today. I'm still not fully convinced, that PR_PRIORITY_* is correct and isn't just working because PR_PRIORITY_NORMAL=1 is such a low number. When you use PR_PRIORITY_NORMAL, can you see which priority the created thread actually has? Probably using truss, since I think the thread doesn't live long enough to be observable using "ps" with the "-L" flag for threads and adding "pri" to the output format. Nevertheless opening a bugzilla seems to be OK for tracking our progress on this and making the problem publicly available. We might later decide on resolving it as invalid though ;) Oh absolutely. I actually looked at the NSPR code and found the chunk that does the conversion and at initial glance it's basically the math used allows PR_PRIORITY_NORMAL and LOW to work. I went ahead and filed this in bugzilla: https://issues.apache.org/bugzilla/show_bug.cgi?id=54923 I'll push this with Oracle, but if they refuse to budge, does it seem like there'd be no choice but to include an ugly hack to use PR_PRIORITY_NORMAL or something else? Thanks, Andy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] Apache Tomcat 6.0.37 released
2013/5/6 jean-frederic clere : > On 05/06/2013 02:33 PM, Konstantin Kolinko wrote: >> >> Do not forget to send this to announce@tomcat.a.o and announce@a.o as >> well. >> You need to send those using your @apache.org address, instead of this >> gmail one. > > > I did that from people.apache.org some it doesn't work :-( > It worked for announce@a.o. I just received it, it has Message-ID: <20130506105608.ga13...@minotaur.apache.org> Maybe it was in some moderation queue. I do not know about announce@tomcat.a.o one. I am not subscribed there and it is not in the archives yet. Thank you. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] Apache Tomcat 6.0.37 released
On 05/06/2013 04:54 PM, Konstantin Kolinko wrote: 2013/5/6 jean-frederic clere : On 05/06/2013 02:33 PM, Konstantin Kolinko wrote: Do not forget to send this to announce@tomcat.a.o and announce@a.o as well. You need to send those using your @apache.org address, instead of this gmail one. I did that from people.apache.org some it doesn't work :-( It worked for announce@a.o. I just received it, it has Message-ID: <20130506105608.ga13...@minotaur.apache.org> Maybe it was in some moderation queue. I do not know about announce@tomcat.a.o one. I am not subscribed there and it is not in the archives yet. That is probably the same of the announce@tomcat.a.o (I mail there just a while ago). Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1479597 - in /tomcat/site/trunk: docs/doap_Tomcat.rdf docs/index.html docs/migration-6.html docs/oldnews.html xdocs/doap_Tomcat.rdf xdocs/index.xml xdocs/migration-6.xml xdocs/oldnews.xml
Author: kkolinko
Date: Mon May 6 15:08:32 2013
New Revision: 1479597
URL: http://svn.apache.org/r1479597
Log:
Followup to r1478727:
1) Move new announcement to the top of the page
2) Restore old announcement, moving it to archive
3) Update DOAP file
4) Update migration guide
Modified:
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-6.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-6.xml
tomcat/site/trunk/xdocs/oldnews.xml
Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL:
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1479597&r1=1479596&r2=1479597&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Mon May 6 15:08:32 2013
@@ -64,8 +64,8 @@
Latest Stable 6.0.x Release
-2012-10-19
-6.0.36
+2013-05-03
+6.0.37
Modified: tomcat/site/trunk/docs/index.html
URL:
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1479597&r1=1479596&r2=1479597&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Mon May 6 15:08:32 2013
@@ -227,6 +227,40 @@ project logo are trademarks of the Apach
+
+Tomcat 6.0.37
Released2013-05-03
+
+
+
+
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 6.0.37 of
+Apache Tomcat. This release includes security and bug fixes over Apache Tomcat
+6.0.36.
+
+
+
+
+
+Download |
+ChangeLog for 6.0.37
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Tomcat 7.0.39
Released2013-03-26
@@ -402,40 +436,6 @@ Tomcat Native.
-
-Tomcat 6.0.37
Released2013-05-03
-
-
-
-
-
-
-
-The Apache Tomcat Project is proud to announce the release of version 6.0.37 of
-Apache Tomcat. This release includes security and bug fixes over Apache Tomcat
-6.0.36.
-
-
-
-
-
-Download |
-ChangeLog for 6.0.37
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Tomcat
Connectors 1.2.37 Released2012-05-31
Modified: tomcat/site/trunk/docs/migration-6.html
URL:
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-6.html?rev=1479597&r1=1479596&r2=1479597&view=diff
==
--- tomcat/site/trunk/docs/migration-6.html (original)
+++ tomcat/site/trunk/docs/migration-6.html Mon May 6 15:08:32 2013
@@ -703,7 +703,9 @@ of Apache Tomcat.
"6.0.30":"1057276",
"6.0.32":"1066582",
"6.0.33":"1158221",
- "6.0.35":"1207053"
+ "6.0.35":"1207053",
+ "6.0.36":"1398690",
+ "6.0.37":"1476938"
};
var formSubmit= document.getElementById('tc6Submit');
var elementsSelect= document.getElementById('tc6Select').elements;
@@ -753,8 +755,10 @@ of Apache Tomcat.
6.0.29
6.0.30
6.0.32
-6.0.33
+6.0.33
6.0.35
+6.0.36
+6.0.37
, new version:
6.0.0
@@ -778,7 +782,9 @@ of Apache Tomcat.
6.0.30
6.0.32
6.0.33
-6.0.35
+6.0.35
+6.0.36
+6.0.37
trunk (unreleased)
@@ -801,8 +807,8 @@ of Apache Tomcat.
You can also use Subversion command similar to the following (all on one
line):
svn diff
-
--old=http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_33/conf/
-
--new=http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_35/conf/
+
--old=http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_36/conf/
+
--new=http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_37/conf/
Modified: tomcat/site/trunk/docs/oldnews.html
URL:
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews.html?rev=1479597&r1=1479596&r2=1479597&view=diff
==
--- tomcat/site/trunk/docs/oldnews.html (original)
+++ tomcat/site/trunk/docs/oldnews.html Mon May 6 15:08:32 2013
@@ -383,6 +383,40 @@ Full details of these changes, and all t
+
+Tomcat 6.0.36
Released2012-10-19
+
+
+
+
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 6.0.36 of
+Apache Tomcat. This release includes security and bug fixes over Apache Tomcat
+6.0.35.
+
+
+
+
+
+Download |
+ChangeLog for
6.0.36
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Tomcat 5.5.36
Released2012-10-10
Modified: tomcat/site/trunk/xdocs/doap_Tomcat.rdf
URL:
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/doap_Tomcat.rdf?rev=1479597&r1=1479596&r2=1479597&view=diff
==
--- tomcat/site/trunk/xdocs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/xdocs/doap_Tomcat.rdf Mon May 6
[Bug 54854] java.lang.UnsatisfiedLinkError tcnative-1.dll can't load IA 32-bit .dll on a 64-bit platform
https://issues.apache.org/bugzilla/show_bug.cgi?id=54854 shekhar changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- --- Comment #3 from shekhar --- Observed the same error on the following environment: OS: Windows 8 Processor: Intel Core i5-3230MCPU@2.60GHz System type: 64 bit operating system, x64 based processor Stack trace: java.lang.UnsatisfiedLinkError: C:\Apache Software Foundation\apache-tomcat-7.0.39\bin\tcnative-1.dll: Can't load IA 32-bit .dll on a AMD 64-bit platf orm at java.lang.ClassLoader$NativeLibrary.load(Native Method) at java.lang.ClassLoader.loadLibrary1(ClassLoader.java:1939) at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1864) at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1854) at java.lang.Runtime.loadLibrary0(Runtime.java:845) at java.lang.System.loadLibrary(System.java:1084) at org.apache.tomcat.jni.Library.(Library.java:42) at org.apache.tomcat.jni.Library.initialize(Library.java:174) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.apache.catalina.core.AprLifecycleListener.init(AprLifecycleListener.java:180) at org.apache.catalina.core.AprLifecycleListener.isAprAvailable(AprLifecycleListener.java:85) at org.apache.catalina.connector.Connector.setProtocol(Connector.java:595) at org.apache.catalina.connector.Connector.(Connector.java:69) at org.apache.catalina.startup.ConnectorCreateRule.begin(ConnectorCreateRule.java:62) at org.apache.tomcat.util.digester.Digester.startElement(Digester.java:1276) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:506) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:182) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1303) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2717) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.40
On 06/05/13 15:27, Konstantin Kolinko wrote: 2013/5/6 Brian Burch : On 05.05.2013 12:44, Mark Thomas wrote: The proposed Apache Tomcat 7.0.40 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.40/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-001/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_40/ The proposed 7.0.40 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 7.0.40 Stable I would like to use this release as early as possible, so I picked up the source, built and tested it. I noticed some errors which do not matter in my environment, but because I haven't tested any earlier releases, I don't know whether they are generally acceptable. I couldn't find a reference to them being known problems, and (of course) it could be a "user error". environment: Linux version 3.5.0-28-lowlatency (buildd@roseapple) (gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-2ubuntu1) ) #32-Ubuntu SMP PREEMPT Fri Apr 26 11:05:36 UTC 2013 (Ubuntu 3.5.0-28.32-lowlatency 3.5.7.9) brian@bacchus:~$ /usr/lib/jvm/java-6-openjdk-i386/bin/java -version java version "1.6.0_27" OpenJDK Runtime Environment (IcedTea6 1.12.3) (6b27-1.12.3-0ubuntu1~12.10.1) OpenJDK Server VM (build 20.0-b12, mixed mode) I have /real/ test failures for both BIO and NIO in: TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.?IO.txt TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.?IO.txt TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.?IO.txt TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.?IO.txt for example, one of them is: Testcase: testMemberArrival took 7.191 sec FAILED Checking member arrival length (Listener-10) expected:<9> but was:<0> junit.framework.AssertionFailedError: Checking member arrival length (Listener-10) expected:<9> but was:<0> at org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.testMemberArrival(TestGroupChannelMemberArrival.java:80) I don't want to waste anybody's time, but perhaps you could let me know whether the errors are significant? If you think it is because I've made a simple error in my configuration, perhaps you point me in the right direction to resolve it. Tribes is communication layer that is used to implement clustering (aka "ha", high availability) http://tomcat.apache.org/tomcat-7.0-doc/tribes/introduction.html If you do not use clustering, then those do not matter for you. You can compare your test log files with ones produced by buildbot: http://ci.apache.org/projects/tomcat/tomcat7/logs/ If you want to (re)run a single test from the testsuite, BUILDING.txt says how to do so. Maybe some network or security configuration at your box prevents those tests from working? IPv6? Any error messages in the logs? The tests respect the "conf/logging.properties" file, so it is possible to enable fine logging if you need so. Thank you for your suggestions, Konstantin. Thanks also to Rainer for his suggestions. My primary objective was to raise the issue at this opportune moment, just in case it turned out to be a general problem. I am satisfied with your theory that the failures I see are related to multicast support on my particular development system. As I said at the start, I do not need tribes support on my production system. When I deploy the new release on my production system, hopefully later this week, I will run all the tests there too. It (now) seems quite likely that I will observe different behaviour under the different execution environment. If anything strikes me as strange, then I will raise the issue, with more diagnostics, on the users list. In the meantime, please discount my report when considering the stability of 7.0.40. Thanks, Brian Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54932] Broken link to Tribes documentation
https://issues.apache.org/bugzilla/show_bug.cgi?id=54932 --- Comment #1 from Violeta Georgieva --- (In reply to comment #0) > - the correct link (and the only valuable page there) is: > http://tomcat.apache.org/tomcat-7.0-doc/tribes/introduction.html > +1 If we choose this option then project.xml needs also correction - "Tribes Docs Home" should point to introduction.html -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54854] java.lang.UnsatisfiedLinkError tcnative-1.dll can't load IA 32-bit .dll on a 64-bit platform
https://issues.apache.org/bugzilla/show_bug.cgi?id=54854 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |INVALID --- Comment #4 from Mark Thomas --- Still user error. Still INVALID. If you need help with this error message, please use the users mailing list. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] Apache Tomcat 6.0.37 released
On 06/05/2013 15:58, jean-frederic clere wrote: > On 05/06/2013 04:54 PM, Konstantin Kolinko wrote: >> 2013/5/6 jean-frederic clere : >>> On 05/06/2013 02:33 PM, Konstantin Kolinko wrote: Do not forget to send this to announce@tomcat.a.o and announce@a.o as well. You need to send those using your @apache.org address, instead of this gmail one. >>> >>> >>> I did that from people.apache.org some it doesn't work :-( >>> >> >> >> It worked for announce@a.o. I just received it, it has >> >> Message-ID: <20130506105608.ga13...@minotaur.apache.org> >> >> Maybe it was in some moderation queue. >> >> I do not know about announce@tomcat.a.o one. I am not subscribed there >> and it is not in the archives yet. > > That is probably the same of the announce@tomcat.a.o (I mail there just > a while ago). It was in moderation. I just passed it. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54703] Nullpointer exception in HttpParser.parseMediaType
https://issues.apache.org/bugzilla/show_bug.cgi?id=54703 Jarek Gawor changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- --- Comment #4 from Jarek Gawor --- Mark, We ran into the same problem while upgrading Geronimo (while running TCK). It would be great if you can reconsider fixing this for the following reasons: 1) This can be considered as a regression. A header value with LWS was accepted fine in Tomcat 7.0.27, for example. This, of course, makes things harded for the users as now they might be forced to change their code to work on the latest version of Tomcat. 2) The Servlet 3.0 spec does not talk about (one way or the other) how the header value should look like when using addHeader()/setHeader() API. 3) The HTTP/1.1 spec in section 2.1 talks about "implied *LWS": "The grammar described by this specification is word-based. Except where noted otherwise, linear white space (LWS) can be included between any two adjacent words (token or quoted-string), and between adjacent words and separators, without changing the interpretation of a field." So that would allow LWS within almost any header value - or at least addHeader()/setHeader() should be able to deal with it. 4) The HTTP/1.1 spec in section 2.2 talks about replacing LWS with a single SP before interpreting values. I think that mostly talks about the folding LWS (on the wire format) but since Tomcat is interpreting the values it maybe should follow the same logic in addHeader()/setHeader() API. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54703] Nullpointer exception in HttpParser.parseMediaType
https://issues.apache.org/bugzilla/show_bug.cgi?id=54703 --- Comment #5 from Mark Thomas --- Short version: The arguments present here aren't valid but they did cause me to look at this again and there is a case for changing the current behaviour. Long version: 1. A regression is when valid behaviour is broken. Using CR or LF in setHeader() is not valid behaviour (see point 2) so this is not a regression. The question here is how tolerant should Tomcat be when an application presents invalid input. Those goalposts may be moved and any changes in behaviour will not get treated as regressions (I usually withdraw an in progress release if we find a regression). 2. If a HTTP header is folded, getHeader() returns the unfolded value. If it did anything else, lots of applications would break. Logically, setHeader() and getHeader() should be symmetric. Therefore, they work with the header value not the "on the wire" representation. If this was different, I'd expect to see it called out in the specification. It isn't. As an aside, cookies values are handled the same way to avoid a bunch of security issues. See CVE-2007-3385, CVE-2007-3382 & CVE-2007-5333. 3. The format used on the wire is irrelevant. See point 2. Note that proxies are free to unfold headers if they wish. There is no point an application trying to specify that a header should be folded because a proxy can unfold it. 4. The idea here is along the right lines but there is a better way to implement it. The skipping of LWS can be pulled out into a separate function and CR and LF added to the characters that are skipped. Currently they are not handled as for input Tomcat has already unfolded all headers and for output the application shouldn't use using them. I took a careful look at the Tomcat code while I was researching this response and I believe there is an argument for taking a different approach. Generally, Tomcat doesn't validate what gets passed to setHeader() but it does in a few cases where the header value has an impact on Tomcat's processing (Content-Type, Content-Length). Tomcat refers to these as special headers. If the value passed to setHeader() for a special header is invalid (e.g. non-numeric content length) then Tomcat simply ignores it and passes it to the client as is on the basis the application really does know what it is doing. It is arguable that Tomcat should not do this (servers should be strict in what they send and tolerant in what they accept) but it does mean that applications are given some leeway to bend the HTTP spec if they need to on the understanding that if they shoot themselves in the foot then any resulting mess is an application responsibility (and with headers there are likely to be security implications). How far application servers should go to stop developers shooting themselves in the foot - particularly from a security perspective - is a matter of debate. Certainly validating all header values and dropping invalid ones should be more secure but it would come at a price both in code complexity (writing parsing code for all the headers in RFC2616 would not be fun) and performance. Getting back to the original point, it is clear from the current code that the intention is to parse headers where they can be parsed and ignore them otherwise - not to validate them and reject invalid headers. Therefore a CR or LF in a header value should not cause the response to fail. The question is whether to just ignore the invalid header (and pass it through to the client as-is) or to do as suggested in point 4 and treat all LWS as a single space. I can't see any down side to the latter approach and it has the upside if that there is data there Tomcat needs it can extract it. Therefore I will look at implementing this for the next 7.0.x release. Note that this means that any folded content-type header values passed to setHeader() and friends will be unfolded by Tomcat before it is written to the wire. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1479743 - /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml
Author: olamy
Date: Tue May 7 01:12:37 2013
New Revision: 1479743
URL: http://svn.apache.org/r1479743
Log:
use tomcat6 6.0.37
Modified:
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml
Modified: tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml?rev=1479743&r1=1479742&r2=1479743&view=diff
==
--- tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml (original)
+++ tomcat/maven-plugin/trunk/tomcat6-maven-plugin/pom.xml Tue May 7 01:12:37
2013
@@ -33,7 +33,7 @@
-6.0.36
+6.0.37
${basedir}/target/
${basedir}/src/test/simple-war-project-1.0-SNAPSHOT.war
${basedir}/src/test/keystore
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.40
2013/5/5 Mark Thomas : > The proposed Apache Tomcat 7.0.40 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.40/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-001/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_40/ > > The proposed 7.0.40 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 7.0.40 Stable +1 Tested with some applications and maven artifacts tested with the plugin. > > Cheers, > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > -- Olivier Lamy Ecetera: http://ecetera.com.au http://twitter.com/olamy | http://linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.40
2013/5/5 Mark Thomas > The proposed Apache Tomcat 7.0.40 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.40/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-001/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_40/ > > The proposed 7.0.40 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 7.0.40 Stable > > +1 Tested on some test applications (enable session replication). Works fine. > > -- > Keiichi.Fujino
Re: svn commit: r1478596 - /tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
2013/5/3 :
> Author: markt
> Date: Thu May 2 22:52:36 2013
> New Revision: 1478596
>
> URL: http://svn.apache.org/r1478596
> Log:
> A little more refactoring to make pulling code up easier
>
> Modified:
> tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
>
> Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java?rev=1478596&r1=1478595&r2=1478596&view=diff
> ==
> --- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
> (original)
> +++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java Thu
> May 2 22:52:36 2013
> @@ -189,7 +189,7 @@ public class Http11NioProcessor extends
> request.setAttribute(RequestDispatcher.ERROR_EXCEPTION,
> x);
> }
> } catch (IllegalStateException x) {
> -registerForEvent(SelectionKey.OP_WRITE);
> +registerForEvent(false, true);
> }
> } else if (status == SocketStatus.OPEN_READ) {
> try {
> @@ -203,7 +203,7 @@ public class Http11NioProcessor extends
> request.setAttribute(RequestDispatcher.ERROR_EXCEPTION,
> x);
> }
> } catch (IllegalStateException x) {
> -registerForEvent(SelectionKey.OP_READ);
> +registerForEvent(false, true);
The above should be "(true, false)", unless this change was intended.
> }
> }
>
> @@ -229,7 +229,7 @@ public class Http11NioProcessor extends
> protected boolean registerForWrite() {
> // Register for write if we have more data to write
> if (outputBuffer.hasDataToWrite()) {
> -registerForEvent(SelectionKey.OP_WRITE);
> +registerForEvent(false, true);
> return true;
> } else {
> return false;
> @@ -237,12 +237,18 @@ public class Http11NioProcessor extends
> }
>
>
> -protected void registerForEvent(int event) {
> +protected void registerForEvent(boolean read, boolean write) {
> final NioEndpoint.KeyAttachment attach =
> (NioEndpoint.KeyAttachment)socket.getSocket().getAttachment(
> false);
> -if (attach != null) {
> -attach.interestOps(attach.interestOps() | event);
> +if (attach == null) {
> +return;
> +}
> +if (read) {
> +attach.interestOps(attach.interestOps() | SelectionKey.OP_READ);
> +}
> +if (write) {
> +attach.interestOps(attach.interestOps() | SelectionKey.OP_WRITE);
> }
> }
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
