Bug report for Tomcat 8 [2013/04/28]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs| |53737|Opn|Enh|2012-08-18|Use ServletContext.getJspConfigDescriptor() in Jas| |53930|New|Enh|2012-09-24|allow capture of catalina stdout/stderr to a comma| |53987|New|Enh|2012-10-09|Log uncovered HTTP methods in combined security co| |54095|New|Enh|2012-11-03|[patch] support gzipped versions of static resourc| |54503|New|Enh|2013-01-29|SAML2 based single sign on| |54522|New|Nor|2013-02-04|Add patch binary as prerequisite in BUILDING.txt | |54700|New|Enh|2013-03-15|Improvement: Add support for system property to sp| |54729|New|Enh|2013-03-20|new HttpParser.parseAuthorizationBasic method | |54741|New|Enh|2013-03-22|Add org.apache.catalina.startup.Tomcat#addWebapp(S| |54745|New|Enh|2013-03-22|Tomcat JarScanning does not work when Tomcat start| |54746|Opn|Maj|2013-03-24|Cannot obtain idempotent information from Session | |54770|New|Enh|2013-03-29|Add jarsToScan properties to counteract jarsToSkip| +-+---+---+--+--+ | Total 13 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Connectors [2013/04/28]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|Inf|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |46337|New|Nor|2008-12-04|real worker name is wrong | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c| |52334|New|Maj|2011-12-14|recover_time is not properly used | |52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus| |52651|New|Nor|2012-02-13|JKSHMFile size limitation | |53324|Opn|Nor|2012-05-30|Starting with mod_jk 1.2.35 I cannot modify worker| |53542|New|Min|2012-07-13|Spelling mistake on 503 service unavailable page | |53762|New|Nor|2012-08-22|JK status manager: mass nodes handling doesn't wor| |53883|New|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe on the p| |53977|New|Maj|2012-10-07|32bits isapi connector cannot work in wow64 mode | |54027|New|Cri|2012-10-18|isapi send request to outside address instead of i| |54112|Opn|Blk|2012-11-07|ISAPI redirector not working when IIS recycles| |54117|New|Maj|2012-11-08|access violation exception in isapi_redirect.dll | |54177|New|Nor|2012-11-20|jkmanager generates non-well-formed XML for certai| |54596|New|Nor|2013-02-22|Relative paths truncates last character of values | |54621|New|Nor|2013-02-28|[PATCH] custom mod_jk availability checks | |54646|New|Trv|2013-03-06|socket_keepalive is sometimes 1 or true or True in| +-+---+---+--+--+ | Total
Bug report for Taglibs [2013/04/28]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | +-+---+---+--+--+ | Total5 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 7 [2013/04/28]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to| |18500|New|Enh|2003-03-30|Host aliases to match by regular expression | |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr| |48550|Inf|Enh|2010-01-14|Update examples and default server.xml to use UTF-| |49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak| |49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al| |49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm| |49821|New|Enh|2010-08-25|Tomcat CLI| |50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou| |50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply| |50234|New|Enh|2010-11-08|JspC use servlet 3.0 features | |50504|New|Enh|2010-12-21|Allow setting query string character set trough re| |50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern| |51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class| |51294|Opn|Enh|2011-05-30|Since 7.0.12 do not work option unpackWARs=true fo| |51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to | |51463|New|Enh|2011-07-01|Tomcat.setBaseDir (package org.apache.catalina.st| |51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul| |51526|New|Enh|2011-07-18|Process web application context config with embedd| |51587|New|Enh|2011-07-29|Implement status and uptime commands | |51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter | |52092|New|Enh|2011-10-26|Please make AsyncFileHandler and OneLineFormatter | |52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site| |52323|New|Enh|2011-12-13|Cobertura test code coverage support for build.xml| |52381|New|Enh|2011-12-22|Please add OSGi metadata | |52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up| |52489|New|Enh|2012-01-19|Enhancement request for code signing of war files | |52558|New|Enh|2012-01-30|CometConnectionManagerValve is adding non-serializ| |52688|New|Enh|2012-02-16|Add ability to remove old access log files| |52751|Opn|Enh|2012-02-23|Optimized configuration of the system info display| |52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s| |53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota| |53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr| |53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf| |53492|New|Enh|2012-07-01|Make JspC shell multithreaded | |53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from | |53602|New|Enh|2012-07-25|Support for HTTP status code 451 | |53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l| |53665|New|Enh|2012-08-06|Minor JNDI Howto document enhancement concerning m| |53776|New|Enh|2012-08-24|Multitenancy support for JDBCRealm| |53777|New|Enh|2012-08-24|Ability to bundle JAAS Configuration in Webappp | |54013|New|Enh|2012-10-16|Catalina.sh force kill to wait till process exits | |54083|New|Enh|2012-10-31|Provide jarsToSkip on a per-webapp basis | |54330|New|Enh|2012-12-19|Patch with some refactoring of Member.java| |54499|New|Enh|2013-01-29|Implementation of Extensible EL Interpreter | |54618|
Bug report for Tomcat 6 [2013/04/28]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43400|New|Enh|2007-09-14|enum support for tag libs | |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context.xml does not update do| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46558|Opn|Enh|2009-01-19|Shutdown port with address binding| |46727|New|Enh|2009-02-17|DefaultServlet - serving multiple encodings | |46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch| |47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho| |47242|New|Enh|2009-05-22|request for AJP command line client | |47281|New|Enh|2009-05-28|Efficiency of the JDBCStore | |47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session| |47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath| |47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked| |47919|New|Enh|2009-09-30|Log Tomcat & Java environment variables in additio| |48358|Opn|Enh|2009-12-09|JSP-unloading reloaded| |48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.| |48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b| |48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe| |48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr| |48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems| |48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static| |48928|New|Enh|2010-03-17|An alternative solution to preloading classes when| |49161|New|Enh|2010-04-21|Unknown Publisher when installing tomcat 6.0.26 | |49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient | |49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding | |49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/| |49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu| |49939|New|Enh|2010-09-16|Expose a method via JMX which empties the webapp f| |49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c| |50285|New|Enh|2010-11-17|Standard HTTP and AJP connectors silently ignore a| |50288|
Bug report for Tomcat Native [2013/04/28]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |46179|Opn|Maj|2008-11-10|apr ssl client authentication | |48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |51655|New|Nor|2011-08-12|Index page does not say what native does | |51813|New|Cri|2011-09-14|Tomcat randomly crashes with [libtcnative-1.so.1+0| |52153|New|Maj|2011-11-08|periodic JVM crash (access violation) on buffer fl| |52231|New|Nor|2011-11-23|Ant Tasks need to reflect changes in manager comma| |52319|New|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da] sig| |52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i| |53110|New|Cri|2012-04-20|Access Violation Error while creating SHM | |53605|New|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash | |53847|Inf|Nor|2012-09-10|High CPU usage in tomcat native 1.22+ | |53937|New|Reg|2012-09-26|Double call to apr_pool_destroy() if OCSP checking| |53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration| |53952|New|Nor|2012-10-02|Add support for TLS 1.1 and 1.2 | |54085|New|Nor|2012-11-01|ssl_socket_recv sometimes loops infinitely with no| |54664|New|Reg|2013-03-11|[1.1.27 branch] Poll.remove incorrectly reports AP| +-+---+---+--+--+ | Total 17 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Modules [2013/04/28]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen| |51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho| |51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods | |52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o| |53088|Opn|Min|2012-04-17|Give PoolCleaner TimerTask a better name | |53198|New|Cri|2012-05-07|'driverClassName' Data Source Property Being Manda| |53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe| |53200|New|Enh|2012-05-07|Be able to use SlowQueryReport without reporting f| |53770|New|Enh|2012-08-23|tomcat-pool: always log validation query syntax er| |53853|New|Nor|2012-09-11|Can tomcat-jdbc consider Thread#getContextClassLoa| |54225|New|Nor|2012-11-30|if initSQL property is set to an empty string a Nu| |54227|New|Nor|2012-11-30|maxAge should be checked on borrow| |54235|New|Nor|2012-12-03|tomcat jdbc pool stackoverflow error used with spr| |54395|New|Nor|2013-01-09|JdbcInterceptor config parameter parsing errors | |54437|New|Enh|2013-01-16|Update PoolProperties javadoc for ConnectState int| |54537|New|Cri|2013-02-07|StatementFinalizer closeInvoked is too slow for la| |54693|New|Enh|2013-03-13|Add a validationQueryTimeout property | +-+---+---+--+--+ | Total 22 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1476726 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: jfclere Date: Sun Apr 28 07:42:42 2013 New Revision: 1476726 URL: http://svn.apache.org/r1476726 Log: Remove my vote. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1476726&r1=1476725&r2=1476726&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Apr 28 07:42:42 2013 @@ -72,8 +72,7 @@ PATCHES PROPOSED TO BACKPORT: Update to Eclipse JDT Compiler 4.2.2 http://people.apache.org/~kkolinko/patches/2013-03-26_tc6_eclipse422.patch +1: kkolinko, rjung - -1: jfclere: I am ~OK to add the method to allow to compile but not to - change the major version of ecj + -1: PATCHES/ISSUES THAT ARE STALLED - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1476728 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/tomcat/util/http/LocalStrings.properties java/org/apache/tomcat/util/http/Parameters.java webapps/docs/changelog.xml webapps
Author: jfclere
Date: Sun Apr 28 07:55:14 2013
New Revision: 1476728
URL: http://svn.apache.org/r1476728
Log:
commit accepted patch for BZ 52184.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/LocalStrings.properties
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/Parameters.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1476728&r1=1476727&r2=1476728&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Apr 28 07:55:14 2013
@@ -31,18 +31,6 @@ PATCHES ACCEPTED TO BACKPORT:
PATCHES PROPOSED TO BACKPORT:
[ New proposals should be added at the end of the list ]
-* Backport UserDataHelper class (issue 52184)
- Provide greater control over the logging of errors triggered by invalid
- input data (i.e. data over which Tomcat has no control).
-
- Note: cookies logging (o.a.t.util.http.Cookies) does not need to be
- addressed in Tomcat 6, because all logging in that class here is done at
- debug level.
-
-
http://people.apache.org/~kkolinko/patches/2013-03-24_tc6_52184_UserDataHelper.patch
- +1: kkolinko, rjung, jfclere
- -1:
-
* For https://issues.apache.org/bugzilla/show_bug.cgi?id=52055
Ensure that filters are recycled.
Inspired by r1334790 (TC7), r565964 (TC6 Nio)
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/LocalStrings.properties?rev=1476728&r1=1476727&r2=1476728&view=diff
==
---
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/LocalStrings.properties
(original)
+++
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/LocalStrings.properties
Sun Apr 28 07:55:14 2013
@@ -20,7 +20,9 @@ parameters.decodeFail.info=Character dec
parameters.emptyChunk=Empty parameter chunk ignored
parameters.invalidChunk=Invalid chunk starting at byte [{0}] and ending at
byte [{1}] with a value of [{2}] ignored
parameters.maxCountFail=More than the maximum number of request parameters
(GET plus POST) for a single request ([{0}]) were detected. Any parameters
beyond this limit have been ignored. To change this limit, set the
maxParameterCount attribute on the Connector.
+parameters.maxCountFail.fallToDebug=\n Note: further occurrences of this error
will be logged at DEBUG level.
parameters.multipleDecodingFail=Character decoding failed. A total of [{0}]
failures were detected but only the first was logged. Enable debug level
logging for this logger to log all failures.
parameters.noequal=Parameter starting at position [{0}] and ending at position
[{1}] with a value of [{0}] was not followed by an '=' character
+parameters.fallToDebug=\n Note: further occurrences of Parameter errors will
be logged at DEBUG level.
headers.maxCountFail=More than the maximum allowed number of headers ([{0}])
were detected.
Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/Parameters.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/Parameters.java?rev=1476728&r1=1476727&r2=1476728&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/Parameters.java
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/Parameters.java Sun
Apr 28 07:55:14 2013
@@ -30,6 +30,7 @@ import org.apache.tomcat.util.buf.B2CCon
import org.apache.tomcat.util.buf.ByteChunk;
import org.apache.tomcat.util.buf.MessageBytes;
import org.apache.tomcat.util.buf.UDecoder;
+import org.apache.tomcat.util.log.UserDataHelper;
import org.apache.tomcat.util.res.StringManager;
/**
@@ -41,6 +42,10 @@ public final class Parameters {
private static final org.apache.juli.logging.Log log =
org.apache.juli.logging.LogFactory.getLog(Parameters.class );
+private static final UserDataHelper userDataLog = new UserDataHelper(log);
+
+private static final UserDataHelper maxParamCountLog = new
UserDataHelper(log);
+
protected static final StringManager sm =
StringManager.getManager("org.apache.tomcat.util.http");
@@ -239,8 +244,22 @@ public final class Parameters {
if (limit > -1 && parameterCount > limit) {
parseFailed = true;
-log.info(sm.getString("parameters.maxCountFail",
-Integer.valueOf(limit)));
+UserDataHelper.Mode logMode = maxParamCountLog.getNextMode();
+if (logMode != null) {
+String message = sm.getString("parameters.maxCountFail",
+
buildbot failure in ASF Buildbot on tomcat-6-trunk
The Buildbot has detected a new failure on builder tomcat-6-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-6-trunk/builds/543 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc6.0.x/trunk] 1476728 Blamelist: jfclere BUILD FAILED: failed compile_1 sincerely, -The Buildbot
svn commit: r1476736 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/log/UserDataHelper.java
Author: jfclere
Date: Sun Apr 28 08:56:38 2013
New Revision: 1476736
URL: http://svn.apache.org/r1476736
Log:
missing file from r1476728.
Added:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/log/UserDataHelper.java
Added: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/log/UserDataHelper.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/log/UserDataHelper.java?rev=1476736&view=auto
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/log/UserDataHelper.java
(added)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/log/UserDataHelper.java
Sun Apr 28 08:56:38 2013
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.util.log;
+
+import org.apache.juli.logging.Log;
+
+/**
+ * This helper class assists with the logging associated with invalid input
+ * data. A developer may want all instances of invalid input data logged to
+ * assist with debugging whereas in production it is likely to be desirable not
+ * to log anything for invalid data. The following settings may be used:
+ *
+ * NOTHING: Log nothing.
+ * DEBUG_ALL: Log all problems at DEBUG log level.
+ * INFO_THEN_DEBUG: Log first problem at INFO log level and any further
+ * issues in the following TBD (configurable) seconds at DEBUG level
+ * INFO_ALL: Log all problems at INFO log level.
+ *
+ * By default, INFO_THEN_DEBUG is used with a suppression time of 24 hours.
+ *
+ * NOTE: This class is not completely thread-safe. When using INFO_THEN_DEBUG
it
+ * is possible that several INFO messages will be logged before dropping to
+ * DEBUG.
+ */
+public class UserDataHelper {
+
+private final Log log;
+
+private final Config config;
+
+// A value of 0 is equivalent to using INFO_ALL
+// A negative value will trigger infinite suppression
+// The value is milliseconds
+private final long suppressionTime;
+
+private volatile long lastInfoTime = 0;
+
+
+public UserDataHelper(Log log) {
+this.log = log;
+
+Config tempConfig;
+String configString = System.getProperty(
+"org.apache.juli.logging.UserDataHelper.CONFIG");
+if (configString == null) {
+tempConfig = Config.INFO_THEN_DEBUG;
+} else {
+try {
+tempConfig = Config.valueOf(configString);
+} catch (IllegalArgumentException iae) {
+// Ignore - use default
+tempConfig = Config.INFO_THEN_DEBUG;
+}
+}
+
+// Default suppression time of 1 day.
+suppressionTime = Integer.getInteger(
+"org.apache.juli.logging.UserDataHelper.SUPPRESSION_TIME",
+60 * 60 * 24).intValue() * 1000L;
+
+if (suppressionTime == 0) {
+tempConfig = Config.INFO_ALL;
+}
+
+config = tempConfig;
+}
+
+
+/**
+ * Returns log mode for the next log message, or null if the
+ * message should not be logged.
+ *
+ *
+ * If INFO_THEN_DEBUG configuration option is enabled, this
+ * method might change internal state of this object.
+ *
+ * @return Log mode, or null
+ */
+public Mode getNextMode() {
+if (Config.NONE == config) {
+return null;
+} else if (Config.DEBUG_ALL == config) {
+return log.isDebugEnabled() ? Mode.DEBUG : null;
+} else if (Config.INFO_THEN_DEBUG == config) {
+if (logAtInfo()) {
+return log.isInfoEnabled() ? Mode.INFO_THEN_DEBUG : null;
+} else {
+return log.isDebugEnabled() ? Mode.DEBUG : null;
+}
+} else if (Config.INFO_ALL == config) {
+return log.isInfoEnabled() ? Mode.INFO : null;
+}
+// Should never happen
+return null;
+}
+
+
+/*
+ * Not completely thread-safe but good enough for this use case. I couldn't
+ * see a simple enough way to make it completely thread-safe that was not
+ * likely to compromise performance.
+ */
+private boolean logAtInfo() {
+
+if (suppressionTime < 0 && la
buildbot success in ASF Buildbot on tomcat-6-trunk
The Buildbot has detected a restored build on builder tomcat-6-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-6-trunk/builds/544 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc6.0.x/trunk] 1476736 Blamelist: jfclere Build succeeded! sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1476738 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/coyote/http11/ webapps/docs/
Author: jfclere
Date: Sun Apr 28 09:05:51 2013
New Revision: 1476738
URL: http://svn.apache.org/r1476738
Log:
commit accepted patch for BZ 52055.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1476738&r1=1476737&r2=1476738&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Apr 28 09:05:51 2013
@@ -31,16 +31,6 @@ PATCHES ACCEPTED TO BACKPORT:
PATCHES PROPOSED TO BACKPORT:
[ New proposals should be added at the end of the list ]
-* For https://issues.apache.org/bugzilla/show_bug.cgi?id=52055
- Ensure that filters are recycled.
- Inspired by r1334790 (TC7), r565964 (TC6 Nio)
- I do not have evidence that this change matters, but it should not hurt.
- The nextRequest() method already recycles the filters. If it has been called,
- then lastActiveFilter is -1 and the new code will be NOOP.
- http://people.apache.org/~kkolinko/patches/2012-06-02_tc6_recycle.patch
- +1: kkolinko, schultz, jfclere
- -1:
-
* Improve method cache handling in SecurityUtil class.
Add caching for Comet methods and simplify cache lookup code.
It is backport of r728776 (BZ 46304) and r1429360
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java?rev=1476738&r1=1476737&r2=1476738&view=diff
==
---
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
(original)
+++
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
Sun Apr 28 09:05:51 2013
@@ -275,6 +275,11 @@ public class InternalAprInputBuffer impl
// Recycle Request object
request.recycle();
+// Recycle filters
+for (int i = 0; i <= lastActiveFilter; i++) {
+activeFilters[i].recycle();
+}
+
socket = 0;
lastValid = 0;
pos = 0;
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java?rev=1476738&r1=1476737&r2=1476738&view=diff
==
---
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java
(original)
+++
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java
Sun Apr 28 09:05:51 2013
@@ -332,6 +332,11 @@ public class InternalAprOutputBuffer
response.recycle();
bbuf.clear();
+// Recycle filters
+for (int i = 0; i <= lastActiveFilter; i++) {
+activeFilters[i].recycle();
+}
+
socket = 0;
pos = 0;
lastActiveFilter = -1;
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java?rev=1476738&r1=1476737&r2=1476738&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java
Sun Apr 28 09:05:51 2013
@@ -276,6 +276,11 @@ public class InternalInputBuffer impleme
// Recycle Request object
request.recycle();
+// Recycle filters
+for (int i = 0; i <= lastActiveFilter; i++) {
+activeFilters[i].recycle();
+}
+
inputStream = null;
lastValid = 0;
pos = 0;
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java?rev=1476738&r1=1476737&r2=1476738&view=diff
==
---
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java
(original)
+++
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalOutputBuffer.java
Sun Apr 28 09:05:51 2013
@@ -347,6 +347,11 @@ public class InternalOutputBuffer
response.recycle();
socketBuffer.recycle();
+// Recycle filters
+for (int i = 0; i <=
svn commit: r1476739 - in /tomcat/tc6.0.x/trunk: STATUS.txt bin/catalina.sh webapps/docs/changelog.xml
Author: jfclere Date: Sun Apr 28 09:13:33 2013 New Revision: 1476739 URL: http://svn.apache.org/r1476739 Log: commit accepted patch for BZ 54601. Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/bin/catalina.sh tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1476739&r1=1476738&r2=1476739&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Apr 28 09:13:33 2013 @@ -38,14 +38,6 @@ PATCHES PROPOSED TO BACKPORT: +1: kkolinko, schultz -1: -* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54601 - Change catalina.sh to consistently use LOGGING_MANAGER variable to - configure logging, instead of modifying JAVA_OPTS one. - https://issues.apache.org/bugzilla/attachment.cgi?id=29985 - (backport of r1449406; r1449412 in tc7) - +1: kkolinko, rjung, jfclere - -1: - * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54615 Update to Eclipse JDT Compiler 4.2.2 http://people.apache.org/~kkolinko/patches/2013-03-26_tc6_eclipse422.patch Modified: tomcat/tc6.0.x/trunk/bin/catalina.sh URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/bin/catalina.sh?rev=1476739&r1=1476738&r2=1476739&view=diff == --- tomcat/tc6.0.x/trunk/bin/catalina.sh (original) +++ tomcat/tc6.0.x/trunk/bin/catalina.sh Sun Apr 28 09:13:33 2013 @@ -218,9 +218,7 @@ if [ -z "$LOGGING_CONFIG" ]; then fi if [ -z "$LOGGING_MANAGER" ]; then - JAVA_OPTS="$JAVA_OPTS -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager" -else - JAVA_OPTS="$JAVA_OPTS $LOGGING_MANAGER" + LOGGING_MANAGER="-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager" fi # - Execute The Requested Command - @@ -269,7 +267,7 @@ if [ "$1" = "debug" ] ; then echo "Using Security Manager" fi shift - exec "$_RUNJDB" "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \ + exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS $CATALINA_OPTS \ -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \ -sourcepath "$CATALINA_HOME"/../../java \ -Djava.security.manager \ @@ -279,7 +277,7 @@ if [ "$1" = "debug" ] ; then -Djava.io.tmpdir="$CATALINA_TMPDIR" \ org.apache.catalina.startup.Bootstrap "$@" start else - exec "$_RUNJDB" "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \ + exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS $CATALINA_OPTS \ -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \ -sourcepath "$CATALINA_HOME"/../../java \ -Dcatalina.base="$CATALINA_BASE" \ @@ -297,7 +295,7 @@ elif [ "$1" = "run" ]; then echo "Using Security Manager" fi shift -exec "$_RUNJAVA" "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \ +exec "$_RUNJAVA" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS $CATALINA_OPTS \ -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \ -Djava.security.manager \ -Djava.security.policy=="$CATALINA_BASE"/conf/catalina.policy \ @@ -306,7 +304,7 @@ elif [ "$1" = "run" ]; then -Djava.io.tmpdir="$CATALINA_TMPDIR" \ org.apache.catalina.startup.Bootstrap "$@" start else -exec "$_RUNJAVA" "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \ +exec "$_RUNJAVA" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS $CATALINA_OPTS \ -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \ -Dcatalina.base="$CATALINA_BASE" \ -Dcatalina.home="$CATALINA_HOME" \ @@ -361,7 +359,7 @@ elif [ "$1" = "start" ] ; then echo "Using Security Manager" fi shift -"$_RUNJAVA" "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \ +"$_RUNJAVA" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS $CATALINA_OPTS \ -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \ -Djava.security.manager \ -Djava.security.policy=="$CATALINA_BASE"/conf/catalina.policy \ @@ -372,7 +370,7 @@ elif [ "$1" = "start" ] ; then >> "$CATALINA_OUT" 2>&1 & else -"$_RUNJAVA" "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \ +"$_RUNJAVA" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS $CATALINA_OPTS \ -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \ -Dcatalina.base="$CATALINA_BASE" \ -Dcatalina.home="$CATALINA_HOME" \ @@ -422,7 +420,7 @@ elif [ "$1" = "stop" ] ; then fi fi - "$_RUNJAVA" $JAVA_OPTS \ + "$_RUNJAVA" $LOGGING_MANAGER $JAVA_OPTS \ -Djava.endorsed.dirs="$JAVA_ENDORSED_DIRS" -classpath "$CLASSPATH" \ -Dcatalina.base="$CATALINA_BASE" \ -Dcatalina.home="$CATALINA_HOME" \ Modified: tomcat/tc6.0.x/trunk/webapps
svn commit: r1476761 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardWrapper.java
Author: markt
Date: Sun Apr 28 13:19:48 2013
New Revision: 1476761
URL: http://svn.apache.org/r1476761
Log:
Improve logging by naming the Servlet that hasn't stopped.
Modified:
tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java
Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties?rev=1476761&r1=1476760&r2=1476761&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties Sun Apr
28 13:19:48 2013
@@ -175,7 +175,7 @@ standardWrapper.serviceExceptionRoot=Ser
standardWrapper.unavailable=Marking servlet {0} as unavailable
standardWrapper.unloadException=Servlet {0} threw unload() exception
standardWrapper.unloading=Cannot allocate servlet {0} because it is being
unloaded
-standardWrapper.waiting=Waiting for {0} instance(s) to be deallocated
+standardWrapper.waiting=Waiting for {0} instance(s) to be deallocated for
Servlet [{1}]
threadLocalLeakPreventionListener.lifecycleEvent.error=Exception processing
lifecycle event {0}
threadLocalLeakPreventionListener.containerEvent.error=Exception processing
container event {0}
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java?rev=1476761&r1=1476760&r2=1476761&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java Sun Apr 28
13:19:48 2013
@@ -1403,7 +1403,8 @@ public class StandardWrapper extends Con
while ((nRetries < 21) && (countAllocated.get() > 0)) {
if ((nRetries % 10) == 0) {
log.info(sm.getString("standardWrapper.waiting",
- countAllocated.toString()));
+ countAllocated.toString(),
+ getName()));
}
try {
Thread.sleep(delay);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1476761 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardWrapper.java
On 28/04/2013 14:19, ma...@apache.org wrote: > Author: markt > Date: Sun Apr 28 13:19:48 2013 > New Revision: 1476761 > > URL: http://svn.apache.org/r1476761 > Log: > Improve logging by naming the Servlet that hasn't stopped. I'm currently looking at the trunk unit test failures with buildbot. I'm not at all sure what is going on. The logs suggest threads are getting stuck for extended periods of time (minutes in some cases) but it always seems to happen with the same tests. The delays are too long for GC but they could be swapping related as buildbot is running on a VM. If that were the case I'd expect to see more variation in the test failures though. At the moment I am looking at improving the logging which has the added benefit of being useful to our users as well. What I really need is the ability to trigger a thread dump from within the JVM. While there are ways of doing it, none of them are particularly simple. I might look into this if the logging doesn't get me anywhere. Suggestions - and better still help - welcome. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1476761 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardWrapper.java
2013/4/28 Mark Thomas : > On 28/04/2013 14:19, ma...@apache.org wrote: >> Author: markt >> Date: Sun Apr 28 13:19:48 2013 >> New Revision: 1476761 >> >> URL: http://svn.apache.org/r1476761 >> Log: >> Improve logging by naming the Servlet that hasn't stopped. > > I'm currently looking at the trunk unit test failures with buildbot. I'm > not at all sure what is going on. The logs suggest threads are getting > stuck for extended periods of time (minutes in some cases) but it always > seems to happen with the same tests. > > The delays are too long for GC but they could be swapping related as > buildbot is running on a VM. If that were the case I'd expect to see > more variation in the test failures though. > > At the moment I am looking at improving the logging which has the added > benefit of being useful to our users as well. > > What I really need is the ability to trigger a thread dump from within > the JVM. While there are ways of doing it, none of them are particularly > simple. I might look into this if the logging doesn't get me anywhere. > > > Suggestions - and better still help - welcome. > There exists Thread.getStackTrace() @since 1.5 that can get stacktrace from a different thread. I thought it could be a good addition to our WebAppLoader report of non-stopped threads. There exists static method Thread.getAllStackTraces(): Map. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1476761 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardWrapper.java
2013/4/28 Konstantin Kolinko :
> 2013/4/28 Mark Thomas :
>> On 28/04/2013 14:19, ma...@apache.org wrote:
>>> Author: markt
>>> Date: Sun Apr 28 13:19:48 2013
>>> New Revision: 1476761
>>>
>>> URL: http://svn.apache.org/r1476761
>>> Log:
>>> Improve logging by naming the Servlet that hasn't stopped.
>>
>> I'm currently looking at the trunk unit test failures with buildbot. I'm
>> not at all sure what is going on. The logs suggest threads are getting
>> stuck for extended periods of time (minutes in some cases) but it always
>> seems to happen with the same tests.
>>
>> The delays are too long for GC but they could be swapping related as
>> buildbot is running on a VM. If that were the case I'd expect to see
>> more variation in the test failures though.
>>
>> At the moment I am looking at improving the logging which has the added
>> benefit of being useful to our users as well.
>>
>> What I really need is the ability to trigger a thread dump from within
>> the JVM. While there are ways of doing it, none of them are particularly
>> simple. I might look into this if the logging doesn't get me anywhere.
>>
>>
>> Suggestions - and better still help - welcome.
>>
1.
> There exists Thread.getStackTrace() @since 1.5 that can get
> stacktrace from a different thread.
>
> I thought it could be a good addition to our WebAppLoader report of
> non-stopped threads.
>
> There exists static method Thread.getAllStackTraces(): Map StackTraceElement[]>.
2. Maybe change default logging configuration to use OneLineFormatter.
It will give us thread names in the log,
Alternatively, there appears to be a way to customize the pattern used
by SimpleFormatter
http://tomcat.markmail.org/thread/dxvweaxzkgwjymai
("Cannot apply simpleformtatter pattern to catalina.sh" thread from Jan 2013)
3. "Read time out" errors
http://ci.apache.org/projects/tomcat/tomcat8/logs/1476401/TEST-org.apache.catalina.loader.TestVirtualContext.BIO.txt
http://ci.apache.org/projects/tomcat/tomcat8/logs/1476401/TEST-org.apache.catalina.loader.TestVirtualContext.NIO.txt
What is strange is that the whole Tomcat startup and shutdown appears
to be faster
than timeout value reported by client thread
(read fails after 12 and 9 seconds and Tomcat goes up and down in 10 and 7).
4.
http://ci.apache.org/projects/tomcat/tomcat8/logs/1476401/TEST-org.apache.catalina.core.TestAsyncContextImpl.BIO.txt
says
"java.lang.IllegalStateException: Calling [asyncDispatch()] is not
valid for a request with Async state [MUST_COMPLETE]"
There is no such message in NIO test.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54899] New: Initial support for netbeans ide
https://issues.apache.org/bugzilla/show_bug.cgi?id=54899
Bug ID: 54899
Summary: Initial support for netbeans ide
Product: Tomcat 8
Version: trunk
Hardware: PC
OS: Linux
Status: NEW
Severity: enhancement
Priority: P2
Component: Packaging
Assignee: dev@tomcat.apache.org
Reporter: br...@pingtoo.com
Classification: Unclassified
Created attachment 30229
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30229&action=edit
svn diff: changes to build.xml
I started work on this task at the late in 2011, with some
discussion on the dev list, i.e.
http://mail-archives.apache.org/mod_mbox/tomcat-dev/201112.mbox/%3c4efd25b0.6050...@pingtoo.com%3E
Every now and then I've improved the support on my own netbeans system, but
finally decided to try packaging the local changes so they would be
appropriate for other users. It has been a frustrating task, and I have
not yet achieved my objective. However, I have produced a fairly large
change that works - subject to some limitations. Further improvements are
quite difficult for me because there isn't anything in the repository
for me to revert to!
I would like to have my current set of changes committed to the repository.
They are intended to be transparent to anyone who doesn't use netbeans,
and are optional for netbeans users.
The change comprises several parts:
0. Netbeans reserves the subdirectory ${basedir}/nbproject for its
local files. A svn ignore for this directory was committed more than
a year ago, and is a pre-requisite for my change.
1. In line with Konstantin's suggestions, I need a new directory
added to the source tree, called ${basedir}/res/ide-support/netbeans
2. I need to make two neutral changes to build.xml:
2.1. A new property that defines the invariant nbproject directory path.
2.2. A set of netbeans-specific tasks to install the new res templates
into the local nbproject directory for an individual user.
(Analogous to the existing ide-eclipse target).
3. A new collection of five template files to be committed to the
res/ide-support/netbeans directory. These files will be installed by
the new ide-netbeans build target.
3.1. One of these files is a README which explains how to use the new
support, and its current limitations. I expect to replicate this
information into the appropriate section of the wiki.
3.2. Project.xml "wires" the tomcat Free-Form project, associating
ide actions to ant targets, and also providing classpaths for
syntax checking and code completion.
3.3. nb-tomcat.xml defines additional ant targets that are only applicable
to the netbeans workbench, such as debugging a single unit test
class.
3.4. Two properties files, one relevant to both syntax-checking and ide
targets, and the other only relevant to the ide targets.
4. Checkstyle passes all my changes, although I am not convinced that my
copyright notices are appropriate. However, checkstyle does not like
a file called nbproject/private/private.xml. This is created and
maintained by netbeans. I think there should be an exclusion rule for
checkstyle to ignore either the whole of nbproject, or at least
nbproject/private/*.
I hope this proposed change is not too controversial.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54899] Initial support for netbeans ide
https://issues.apache.org/bugzilla/show_bug.cgi?id=54899 --- Comment #1 from Brian Burch --- Created attachment 30230 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30230&action=edit New file: res/ide-support/netbeans/README -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54899] Initial support for netbeans ide
https://issues.apache.org/bugzilla/show_bug.cgi?id=54899 --- Comment #2 from Brian Burch --- Created attachment 30231 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30231&action=edit New file: res/ide-support/netbeans/project.xml -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54899] Initial support for netbeans ide
https://issues.apache.org/bugzilla/show_bug.cgi?id=54899 --- Comment #3 from Brian Burch --- Created attachment 30232 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30232&action=edit New file: res/ide-support/netbeans/nb-tomcat.xml -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54899] Initial support for netbeans ide
https://issues.apache.org/bugzilla/show_bug.cgi?id=54899 --- Comment #4 from Brian Burch --- Created attachment 30233 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30233&action=edit New file: res/ide-support/netbeans/nb-tomcat-project.properties -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54899] Initial support for netbeans ide
https://issues.apache.org/bugzilla/show_bug.cgi?id=54899 --- Comment #5 from Brian Burch --- Created attachment 30234 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30234&action=edit New file: res/ide-support/netbeans/nb-tomcat-build.properties -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1476761 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardWrapper.java
On 28.04.2013 15:28, Mark Thomas wrote: > On 28/04/2013 14:19, ma...@apache.org wrote: >> Author: markt >> Date: Sun Apr 28 13:19:48 2013 >> New Revision: 1476761 >> >> URL: http://svn.apache.org/r1476761 >> Log: >> Improve logging by naming the Servlet that hasn't stopped. > > I'm currently looking at the trunk unit test failures with buildbot. I'm > not at all sure what is going on. The logs suggest threads are getting > stuck for extended periods of time (minutes in some cases) but it always > seems to happen with the same tests. > > The delays are too long for GC but they could be swapping related as > buildbot is running on a VM. If that were the case I'd expect to see > more variation in the test failures though. > > At the moment I am looking at improving the logging which has the added > benefit of being useful to our users as well. > > What I really need is the ability to trigger a thread dump from within > the JVM. While there are ways of doing it, none of them are particularly > simple. I might look into this if the logging doesn't get me anywhere. I uploaded a class that has a static getDump() method which returns a thread dump formatted very similar to the usual "kipp -QUIT" one: http://people.apache.org/~rjung/ThreadDump.java It retrieves the ThreadMXBean from the platform MBean server, gets the ThreadInfo for each thread and formats the data. HTH. I had to strip down some longer code I had and only did a very quick test but it seemed to work for me. It assumes Java 6 or newer. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1476761 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardWrapper.java
On 28.04.2013 16:44, Rainer Jung wrote: > thread dump formatted very similar to the usual "kipp -QUIT" one: Freudian typo: I mean't "kill -QUIT" :) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1476761 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardWrapper.java
On 28.04.2013 16:01, Konstantin Kolinko wrote:
> 2. Maybe change default logging configuration to use OneLineFormatter.
> It will give us thread names in the log,
>
> Alternatively, there appears to be a way to customize the pattern used
> by SimpleFormatter
> http://tomcat.markmail.org/thread/dxvweaxzkgwjymai
> ("Cannot apply simpleformtatter pattern to catalina.sh" thread from Jan 2013)
The format customization added in Java 7 for SimpleFormatter is somehow
limitted:
http://docs.oracle.com/javase/7/docs/api/java/util/logging/SimpleFormatter.html
The data from which you can choose is "date, source, logger, level,
message, thrown", so current thread name doesn't seem to be an option.
Regards,
Rainer
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1476761 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardWrapper.java
On 28/04/2013 16:53, Rainer Jung wrote:
> On 28.04.2013 16:01, Konstantin Kolinko wrote:
>> 2. Maybe change default logging configuration to use OneLineFormatter.
>> It will give us thread names in the log,
>>
>> Alternatively, there appears to be a way to customize the pattern used
>> by SimpleFormatter
>> http://tomcat.markmail.org/thread/dxvweaxzkgwjymai
>> ("Cannot apply simpleformtatter pattern to catalina.sh" thread from Jan 2013)
>
> The format customization added in Java 7 for SimpleFormatter is somehow
> limitted:
>
> http://docs.oracle.com/javase/7/docs/api/java/util/logging/SimpleFormatter.html
>
> The data from which you can choose is "date, source, logger, level,
> message, thrown", so current thread name doesn't seem to be an option.
Thanks for all the suggestions. I have console access to the box where
the test runs and it appears that the initialisation of the JSP servlet
is causing the request to take longer than the read timeout.
The test fails consistently from the command line with -Dtest.entry=...
I'll commit this change shortly while I continue to investigate why the
scan takes so long.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1476805 - /tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
Author: markt
Date: Sun Apr 28 17:33:47 2013
New Revision: 1476805
URL: http://svn.apache.org/r1476805
Log:
Extend read timeout to 30s for this test as JSP initialisation seems to take
longer than 3s.
Modified:
tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
Modified: tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java?rev=1476805&r1=1476804&r2=1476805&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java Sun
Apr 28 17:33:47 2013
@@ -323,7 +323,7 @@ public class TestVirtualContext extends
private void assertPageContains(String pageUrl, String expectedBody,
int expectedStatus) throws IOException {
ByteChunk res = new ByteChunk();
-int sc = getUrl("http://localhost:"; + getPort() + pageUrl, res, 3000,
+int sc = getUrl("http://localhost:"; + getPort() + pageUrl, res, 3,
null, null);
assertEquals(expectedStatus, sc);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1476761 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardWrapper.java
On 28/04/2013 15:01, Konstantin Kolinko wrote:
> 2013/4/28 Konstantin Kolinko :
>> 2013/4/28 Mark Thomas :
>>> On 28/04/2013 14:19, ma...@apache.org wrote:
Author: markt
Date: Sun Apr 28 13:19:48 2013
New Revision: 1476761
URL: http://svn.apache.org/r1476761
Log:
Improve logging by naming the Servlet that hasn't stopped.
>>>
>>> I'm currently looking at the trunk unit test failures with buildbot. I'm
>>> not at all sure what is going on. The logs suggest threads are getting
>>> stuck for extended periods of time (minutes in some cases) but it always
>>> seems to happen with the same tests.
>>>
>>> The delays are too long for GC but they could be swapping related as
>>> buildbot is running on a VM. If that were the case I'd expect to see
>>> more variation in the test failures though.
>>>
>>> At the moment I am looking at improving the logging which has the added
>>> benefit of being useful to our users as well.
>>>
>>> What I really need is the ability to trigger a thread dump from within
>>> the JVM. While there are ways of doing it, none of them are particularly
>>> simple. I might look into this if the logging doesn't get me anywhere.
>>>
>>>
>>> Suggestions - and better still help - welcome.
>>>
>
> 1.
>
>> There exists Thread.getStackTrace() @since 1.5 that can get
>> stacktrace from a different thread.
>>
>> I thought it could be a good addition to our WebAppLoader report of
>> non-stopped threads.
>>
>> There exists static method Thread.getAllStackTraces(): Map> StackTraceElement[]>.
+1
> 2. Maybe change default logging configuration to use OneLineFormatter.
> It will give us thread names in the log,
>
> Alternatively, there appears to be a way to customize the pattern used
> by SimpleFormatter
> http://tomcat.markmail.org/thread/dxvweaxzkgwjymai
> ("Cannot apply simpleformtatter pattern to catalina.sh" thread from Jan 2013)
>
> 3. "Read time out" errors
> http://ci.apache.org/projects/tomcat/tomcat8/logs/1476401/TEST-org.apache.catalina.loader.TestVirtualContext.BIO.txt
> http://ci.apache.org/projects/tomcat/tomcat8/logs/1476401/TEST-org.apache.catalina.loader.TestVirtualContext.NIO.txt
>
> What is strange is that the whole Tomcat startup and shutdown appears
> to be faster
> than timeout value reported by client thread
> (read fails after 12 and 9 seconds and Tomcat goes up and down in 10 and 7).
The read fails after 3s. The 12s and 9s figures are for the entire test.
> 4.
> http://ci.apache.org/projects/tomcat/tomcat8/logs/1476401/TEST-org.apache.catalina.core.TestAsyncContextImpl.BIO.txt
>
> says
> "java.lang.IllegalStateException: Calling [asyncDispatch()] is not
> valid for a request with Async state [MUST_COMPLETE]"
>
> There is no such message in NIO test.
Haven't looked into this yet but it looks possible this might have the
same root cause.
Fundamentally, the VM running the tests appears to have quite big IO
delays. This is triggering failures in some timing related tests.
I suspect there isn't much we can do about this short of buying new
hardware. I'll stick my infra hat on and take a look at the VM host.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1476761 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardWrapper.java
On 28/04/2013 15:44, Rainer Jung wrote: > On 28.04.2013 15:28, Mark Thomas wrote: >> On 28/04/2013 14:19, ma...@apache.org wrote: >>> Author: markt >>> Date: Sun Apr 28 13:19:48 2013 >>> New Revision: 1476761 >>> >>> URL: http://svn.apache.org/r1476761 >>> Log: >>> Improve logging by naming the Servlet that hasn't stopped. >> >> I'm currently looking at the trunk unit test failures with buildbot. I'm >> not at all sure what is going on. The logs suggest threads are getting >> stuck for extended periods of time (minutes in some cases) but it always >> seems to happen with the same tests. >> >> The delays are too long for GC but they could be swapping related as >> buildbot is running on a VM. If that were the case I'd expect to see >> more variation in the test failures though. >> >> At the moment I am looking at improving the logging which has the added >> benefit of being useful to our users as well. >> >> What I really need is the ability to trigger a thread dump from within >> the JVM. While there are ways of doing it, none of them are particularly >> simple. I might look into this if the logging doesn't get me anywhere. > > I uploaded a class that has a static getDump() method which returns a > thread dump formatted very similar to the usual "kipp -QUIT" one: > > http://people.apache.org/~rjung/ThreadDump.java > > It retrieves the ThreadMXBean from the platform MBean server, gets the > ThreadInfo for each thread and formats the data. HTH. > > I had to strip down some longer code I had and only did a very quick > test but it seemed to work for me. It assumes Java 6 or newer. I'm thinking o.a.tomcat.util.Diagnostics and add an option to call it from the manager. It is then available to any code that wants to use it. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4244 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1476805 Blamelist: markt Build succeeded! sincerely, -The Buildbot
svn commit: r1476815 - /tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
Author: markt
Date: Sun Apr 28 19:01:41 2013
New Revision: 1476815
URL: http://svn.apache.org/r1476815
Log:
Slightly shorter timeout. Add a note.
Modified:
tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
Modified: tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java?rev=1476815&r1=1476814&r2=1476815&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java Sun
Apr 28 19:01:41 2013
@@ -323,7 +323,13 @@ public class TestVirtualContext extends
private void assertPageContains(String pageUrl, String expectedBody,
int expectedStatus) throws IOException {
ByteChunk res = new ByteChunk();
-int sc = getUrl("http://localhost:"; + getPort() + pageUrl, res, 3,
+// Note: With a read timeout of 3s the ASF CI buildbot was consistently
+// seeing failures with this test. The failures were due to the
+// JSP initialisation taking longer than the read timeout. The
+// root cause of this is the frequent poor IO performance of the
+// VM running the buildbot instance. Increasing this to 10s
should
+// avoid these failures.
+int sc = getUrl("http://localhost:"; + getPort() + pageUrl, res, 1,
null, null);
assertEquals(expectedStatus, sc);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1476846 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/LocalStrings.properties java/org/apache/catalina/core/StandardWrapper.java test/org/apache/catalina/loader/TestVirtual
Author: markt
Date: Sun Apr 28 22:04:06 2013
New Revision: 1476846
URL: http://svn.apache.org/r1476846
Log:
Port unit test changes from trunk that should allow ASF CI system to complete
without error
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java
tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1476761,1476805,1476815
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties?rev=1476846&r1=1476845&r2=1476846&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties
Sun Apr 28 22:04:06 2013
@@ -261,7 +261,7 @@ standardWrapper.statusTitle=Tomcat Error
standardWrapper.unavailable=Marking servlet {0} as unavailable
standardWrapper.unloadException=Servlet {0} threw unload() exception
standardWrapper.unloading=Cannot allocate servlet {0} because it is being
unloaded
-standardWrapper.waiting=Waiting for {0} instance(s) to be deallocated
+standardWrapper.waiting=Waiting for {0} instance(s) to be deallocated for
Servlet [{1}]
threadLocalLeakPreventionListener.lifecycleEvent.error=Exception processing
lifecycle event {0}
threadLocalLeakPreventionListener.containerEvent.error=Exception processing
container event {0}
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java?rev=1476846&r1=1476845&r2=1476846&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java Sun
Apr 28 22:04:06 2013
@@ -1448,7 +1448,8 @@ public class StandardWrapper extends Con
while ((nRetries < 21) && (countAllocated.get() > 0)) {
if ((nRetries % 10) == 0) {
log.info(sm.getString("standardWrapper.waiting",
- countAllocated.toString()));
+ countAllocated.toString(),
+ getName()));
}
try {
Thread.sleep(delay);
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestVirtualContext.java?rev=1476846&r1=1476845&r2=1476846&view=diff
==
---
tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
(original)
+++
tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
Sun Apr 28 22:04:06 2013
@@ -297,7 +297,13 @@ public class TestVirtualContext extends
private void assertPageContains(String pageUrl, String expectedBody,
int expectedStatus) throws IOException {
ByteChunk res = new ByteChunk();
-int sc = getUrl("http://localhost:"; + getPort() + pageUrl, res, 3000,
+// Note: With a read timeout of 3s the ASF CI buildbot was consistently
+// seeing failures with this test. The failures were due to the
+// JSP initialisation taking longer than the read timeout. The
+// root cause of this is the frequent poor IO performance of the
+// VM running the buildbot instance. Increasing this to 10s
should
+// avoid these failures.
+int sc = getUrl("http://localhost:"; + getPort() + pageUrl, res, 1,
null, null);
assertEquals(expectedStatus, sc);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1476847 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sun Apr 28 22:08:50 2013 New Revision: 1476847 URL: http://svn.apache.org/r1476847 Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1476847&r1=1476846&r2=1476847&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Apr 28 22:08:50 2013 @@ -35,13 +35,13 @@ PATCHES PROPOSED TO BACKPORT: Add caching for Comet methods and simplify cache lookup code. It is backport of r728776 (BZ 46304) and r1429360 http://people.apache.org/~kkolinko/patches/2013-01-05_tc6_46304_SecurityUtil.patch - +1: kkolinko, schultz + +1: kkolinko, schultz, markt -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54615 Update to Eclipse JDT Compiler 4.2.2 http://people.apache.org/~kkolinko/patches/2013-03-26_tc6_eclipse422.patch - +1: kkolinko, rjung + +1: kkolinko, rjung, markt -1: PATCHES/ISSUES THAT ARE STALLED - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1189 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1476846 Blamelist: markt Build succeeded! sincerely, -The Buildbot
