[jira] [Commented] (MTOMCAT-216) tomca7:run fails in multi-module project with overlays
[ https://issues.apache.org/jira/browse/MTOMCAT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642721#comment-13642721 ] Henri Tremblay commented on MTOMCAT-216: Same issue here. The overlay seems to be ignored. mvn install tomcat7:run doesn't fix it. I have and exemple here. > tomca7:run fails in multi-module project with overlays > -- > > Key: MTOMCAT-216 > URL: https://issues.apache.org/jira/browse/MTOMCAT-216 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat7 >Affects Versions: 2.1 > Environment: Windows 7 64-bit, Java 7u17 64-bit, maven 3.0.4, > tomcat7-maven-plugin 2.1 >Reporter: Jan Zelenka >Assignee: Olivier Lamy (*$^¨%`£) > > I have maven multi module project with two war child projects: > parent pom.xml > --- mainWebapp > --- overlayWebapp > mainWebapp has dependency of type war on overlayWebapp > overlayWebapp has only static resources (css, js..) > mvn package (run from parent project) works correctly, mainWebapp.war > contains overlaid resources from overlayWebapp > mvn tomcat7:run (run from root parent project) fails with exception: > [INFO] create webapp with contextPath: /mainWebapp > [ERROR] fail to extract war file > C:\projekty\FIS\source\overlayWebapp\target\classes, reason:The source file > C:\projekty\FIS\source\overlayWebapp\target\classes doesn't exist. > org.codehaus.plexus.archiver.ArchiverException: The source file > C:\projekty\FIS\source\overlayWebapp\target\classes doesn't exist. > at > org.codehaus.plexus.archiver.AbstractUnArchiver.validate(AbstractUnArchiver.java:190) > at > org.codehaus.plexus.archiver.AbstractUnArchiver.extract(AbstractUnArchiver.java:118) > at > org.apache.tomcat.maven.common.run.DefaultClassLoaderEntriesCalculator.calculateClassPathEntries(DefaultClassLoaderEntriesCalculator.java:152) > at > org.apache.tomcat.maven.plugin.tomcat7.run.RunMojo.createWebappLoader(RunMojo.java:239) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.createContext(AbstractRunMojo.java:612) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:512) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:601) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) > when I create some classpath resource in overlayWebapp to create > overlayWebapp\target\classes directory, there is an different exception: > [INFO] create webapp with contextPath: /mainWebapp > [ERROR] fail to extract war file > C:\projekty\FIS\source\overlayWebapp\target\classes, reason:The source must > not be a directory. > org.codehaus.plexus.archiver.ArchiverException: The source must not be a > directory. > at > org.codehaus.plexus.archiver.AbstractUnArchiver.validate(AbstractUnArchiver.java:185) >
[jira] [Comment Edited] (MTOMCAT-216) tomca7:run fails in multi-module project with overlays
[ https://issues.apache.org/jira/browse/MTOMCAT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642721#comment-13642721 ] Henri Tremblay edited comment on MTOMCAT-216 at 4/26/13 10:19 AM: -- Same issue here. The overlay seems to be ignored. mvn install tomcat7:run doesn't fix it. I have and example here. was (Author: henri): Same issue here. The overlay seems to be ignored. mvn install tomcat7:run doesn't fix it. I have and exemple here. > tomca7:run fails in multi-module project with overlays > -- > > Key: MTOMCAT-216 > URL: https://issues.apache.org/jira/browse/MTOMCAT-216 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat7 >Affects Versions: 2.1 > Environment: Windows 7 64-bit, Java 7u17 64-bit, maven 3.0.4, > tomcat7-maven-plugin 2.1 >Reporter: Jan Zelenka >Assignee: Olivier Lamy (*$^¨%`£) > > I have maven multi module project with two war child projects: > parent pom.xml > --- mainWebapp > --- overlayWebapp > mainWebapp has dependency of type war on overlayWebapp > overlayWebapp has only static resources (css, js..) > mvn package (run from parent project) works correctly, mainWebapp.war > contains overlaid resources from overlayWebapp > mvn tomcat7:run (run from root parent project) fails with exception: > [INFO] create webapp with contextPath: /mainWebapp > [ERROR] fail to extract war file > C:\projekty\FIS\source\overlayWebapp\target\classes, reason:The source file > C:\projekty\FIS\source\overlayWebapp\target\classes doesn't exist. > org.codehaus.plexus.archiver.ArchiverException: The source file > C:\projekty\FIS\source\overlayWebapp\target\classes doesn't exist. > at > org.codehaus.plexus.archiver.AbstractUnArchiver.validate(AbstractUnArchiver.java:190) > at > org.codehaus.plexus.archiver.AbstractUnArchiver.extract(AbstractUnArchiver.java:118) > at > org.apache.tomcat.maven.common.run.DefaultClassLoaderEntriesCalculator.calculateClassPathEntries(DefaultClassLoaderEntriesCalculator.java:152) > at > org.apache.tomcat.maven.plugin.tomcat7.run.RunMojo.createWebappLoader(RunMojo.java:239) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.createContext(AbstractRunMojo.java:612) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:512) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:601) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) > when I create some classpath resource in overlayWebapp to create > overlayWebapp\target\classes directory, there is an different exception: > [INFO] create webapp with contextPath: /mainWebapp > [ERROR] fail to extract war file > C:\projekty\FIS\source\overlayWebapp\target\classes, reason:The source must
[jira] [Updated] (MTOMCAT-216) tomca7:run fails in multi-module project with overlays
[ https://issues.apache.org/jira/browse/MTOMCAT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Tremblay updated MTOMCAT-216: --- Attachment: overlay.zip Just launch http://localhost:8080/overlay-webapp When launched from the tomcat7 plugin, you get a jsp compilation error. If the war is deployed manually in tomcat, it works perfectly > tomca7:run fails in multi-module project with overlays > -- > > Key: MTOMCAT-216 > URL: https://issues.apache.org/jira/browse/MTOMCAT-216 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat7 >Affects Versions: 2.1 > Environment: Windows 7 64-bit, Java 7u17 64-bit, maven 3.0.4, > tomcat7-maven-plugin 2.1 >Reporter: Jan Zelenka >Assignee: Olivier Lamy (*$^¨%`£) > Attachments: overlay.zip > > > I have maven multi module project with two war child projects: > parent pom.xml > --- mainWebapp > --- overlayWebapp > mainWebapp has dependency of type war on overlayWebapp > overlayWebapp has only static resources (css, js..) > mvn package (run from parent project) works correctly, mainWebapp.war > contains overlaid resources from overlayWebapp > mvn tomcat7:run (run from root parent project) fails with exception: > [INFO] create webapp with contextPath: /mainWebapp > [ERROR] fail to extract war file > C:\projekty\FIS\source\overlayWebapp\target\classes, reason:The source file > C:\projekty\FIS\source\overlayWebapp\target\classes doesn't exist. > org.codehaus.plexus.archiver.ArchiverException: The source file > C:\projekty\FIS\source\overlayWebapp\target\classes doesn't exist. > at > org.codehaus.plexus.archiver.AbstractUnArchiver.validate(AbstractUnArchiver.java:190) > at > org.codehaus.plexus.archiver.AbstractUnArchiver.extract(AbstractUnArchiver.java:118) > at > org.apache.tomcat.maven.common.run.DefaultClassLoaderEntriesCalculator.calculateClassPathEntries(DefaultClassLoaderEntriesCalculator.java:152) > at > org.apache.tomcat.maven.plugin.tomcat7.run.RunMojo.createWebappLoader(RunMojo.java:239) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.createContext(AbstractRunMojo.java:612) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:512) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:601) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) > when I create some classpath resource in overlayWebapp to create > overlayWebapp\target\classes directory, there is an different exception: > [INFO] create webapp with contextPath: /mainWebapp > [ERROR] fail to extract war file > C:\projekty\FIS\source\overlayWebapp\target\classes, reason:The source must > not be a directory. > org.codehaus.plexus.archiver.ArchiverException: The source must not be a > directory. > at > org.codehaus.p
svn commit: r1476177 - in /tomcat/trunk/java/org/apache/coyote/http11: InternalNioInputBuffer.java LocalStrings.properties
Author: markt
Date: Fri Apr 26 13:04:06 2013
New Revision: 1476177
URL: http://svn.apache.org/r1476177
Log:
Another NPE in the WebSocket tests.
Modified:
tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java?rev=1476177&r1=1476176&r2=1476177&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java Fri
Apr 26 13:04:06 2013
@@ -789,6 +789,10 @@ public class InternalNioInputBuffer exte
AbstractEndpoint endpoint) throws IOException {
socket = socketWrapper.getSocket();
+if (socket == null) {
+// Socket has been closed in another thread
+throw new IOException(sm.getString("iib.socketClosed"));
+}
socketReadBufferSize =
socket.getBufHandler().getReadBuffer().capacity();
Modified: tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties?rev=1476177&r1=1476176&r2=1476177&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties Fri Apr
26 13:04:06 2013
@@ -30,5 +30,6 @@ iib.invalidheader=The HTTP header line [
iib.invalidmethod=Invalid character (CR or LF) found in method name
iib.parseheaders.ise.error=Unexpected state: headers already parsed. Buffer
not recycled?
iib.requestheadertoolarge.error=Request header is too large
+iib.socketClosed=The socket has been closed in another thread
iob.responseheadertoolarge.error=An attempt was made to write more data to the
response headers than there was room available in the buffer. Increase
maxHttpHeaderSize on the connector or write less data into the response headers.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-212) Missing "skip" configuration option
[ https://issues.apache.org/jira/browse/MTOMCAT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642843#comment-13642843 ] Hudson commented on MTOMCAT-212: Integrated in TomcatMavenPlugin-mvn3.x #247 (See [https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/247/]) [MTOMCAT-212] Missing "skip" configuration option Submitted by Eugenio Santoboni (Revision 1469252) Result = SUCCESS olamy : http://svn.apache.org/viewvc/?view=rev&rev=1469252 Files : * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java > Missing "skip" configuration option > --- > > Key: MTOMCAT-212 > URL: https://issues.apache.org/jira/browse/MTOMCAT-212 > Project: Apache Tomcat Maven Plugin > Issue Type: Improvement > Components: tomcat7 >Affects Versions: 2.1 >Reporter: Eugenio Santoboni >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Minor > Fix For: 2.2 > > Attachments: 0001-Add-skip-configuration-option.patch > > Original Estimate: 20m > Remaining Estimate: 20m > > There isn't a "skip" parameter that allows developers to skip mojo execution > for "exec-war" and "exec-war-only" goals. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-216) tomca7:run fails in multi-module project with overlays
[ https://issues.apache.org/jira/browse/MTOMCAT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Zelenka updated MTOMCAT-216: Attachment: repro.zip Project has flat (eclipse friendly) directory structure: project/ - contains parent pom mainWebapp/ - main webapp overlayWebapp/ - overlayed webapp Now, from project/ directory: mvn tomcat7:run fails with above mentioned exeption mvn install tomcat7:run does not fail, but overlay does not happen (overlay.html is not accesible) Overlay itself is OK, (create war with mvn package, then deploy war to standalone tomcat work OK), only tomcat7 does not handle it. > tomca7:run fails in multi-module project with overlays > -- > > Key: MTOMCAT-216 > URL: https://issues.apache.org/jira/browse/MTOMCAT-216 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat7 >Affects Versions: 2.1 > Environment: Windows 7 64-bit, Java 7u17 64-bit, maven 3.0.4, > tomcat7-maven-plugin 2.1 >Reporter: Jan Zelenka >Assignee: Olivier Lamy (*$^¨%`£) > Attachments: overlay.zip, repro.zip > > > I have maven multi module project with two war child projects: > parent pom.xml > --- mainWebapp > --- overlayWebapp > mainWebapp has dependency of type war on overlayWebapp > overlayWebapp has only static resources (css, js..) > mvn package (run from parent project) works correctly, mainWebapp.war > contains overlaid resources from overlayWebapp > mvn tomcat7:run (run from root parent project) fails with exception: > [INFO] create webapp with contextPath: /mainWebapp > [ERROR] fail to extract war file > C:\projekty\FIS\source\overlayWebapp\target\classes, reason:The source file > C:\projekty\FIS\source\overlayWebapp\target\classes doesn't exist. > org.codehaus.plexus.archiver.ArchiverException: The source file > C:\projekty\FIS\source\overlayWebapp\target\classes doesn't exist. > at > org.codehaus.plexus.archiver.AbstractUnArchiver.validate(AbstractUnArchiver.java:190) > at > org.codehaus.plexus.archiver.AbstractUnArchiver.extract(AbstractUnArchiver.java:118) > at > org.apache.tomcat.maven.common.run.DefaultClassLoaderEntriesCalculator.calculateClassPathEntries(DefaultClassLoaderEntriesCalculator.java:152) > at > org.apache.tomcat.maven.plugin.tomcat7.run.RunMojo.createWebappLoader(RunMojo.java:239) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.createContext(AbstractRunMojo.java:612) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:512) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:601) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) > when I create some classpath resource in overlayWebapp to create > overlayWebapp\target\classes directory, there is an different exception: > [INFO] create webapp
[jira] [Comment Edited] (MTOMCAT-216) tomca7:run fails in multi-module project with overlays
[ https://issues.apache.org/jira/browse/MTOMCAT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642845#comment-13642845 ] Jan Zelenka edited comment on MTOMCAT-216 at 4/26/13 1:42 PM: -- I uploaded repro.zip, project has flat (eclipse friendly) directory structure: project/ - contains parent pom mainWebapp/ - main webapp overlayWebapp/ - overlayed webapp Now, from project/ directory: mvn tomcat7:run fails with above mentioned exeption mvn install tomcat7:run does not fail, but overlay does not happen (overlay.html is not accesible) Overlay itself is OK, (create war with mvn package, then deploy war to standalone tomcat work OK), only tomcat7 plugin does not handle it. was (Author: jzelenka): Project has flat (eclipse friendly) directory structure: project/ - contains parent pom mainWebapp/ - main webapp overlayWebapp/ - overlayed webapp Now, from project/ directory: mvn tomcat7:run fails with above mentioned exeption mvn install tomcat7:run does not fail, but overlay does not happen (overlay.html is not accesible) Overlay itself is OK, (create war with mvn package, then deploy war to standalone tomcat work OK), only tomcat7 does not handle it. > tomca7:run fails in multi-module project with overlays > -- > > Key: MTOMCAT-216 > URL: https://issues.apache.org/jira/browse/MTOMCAT-216 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat7 >Affects Versions: 2.1 > Environment: Windows 7 64-bit, Java 7u17 64-bit, maven 3.0.4, > tomcat7-maven-plugin 2.1 >Reporter: Jan Zelenka >Assignee: Olivier Lamy (*$^¨%`£) > Attachments: overlay.zip, repro.zip > > > I have maven multi module project with two war child projects: > parent pom.xml > --- mainWebapp > --- overlayWebapp > mainWebapp has dependency of type war on overlayWebapp > overlayWebapp has only static resources (css, js..) > mvn package (run from parent project) works correctly, mainWebapp.war > contains overlaid resources from overlayWebapp > mvn tomcat7:run (run from root parent project) fails with exception: > [INFO] create webapp with contextPath: /mainWebapp > [ERROR] fail to extract war file > C:\projekty\FIS\source\overlayWebapp\target\classes, reason:The source file > C:\projekty\FIS\source\overlayWebapp\target\classes doesn't exist. > org.codehaus.plexus.archiver.ArchiverException: The source file > C:\projekty\FIS\source\overlayWebapp\target\classes doesn't exist. > at > org.codehaus.plexus.archiver.AbstractUnArchiver.validate(AbstractUnArchiver.java:190) > at > org.codehaus.plexus.archiver.AbstractUnArchiver.extract(AbstractUnArchiver.java:118) > at > org.apache.tomcat.maven.common.run.DefaultClassLoaderEntriesCalculator.calculateClassPathEntries(DefaultClassLoaderEntriesCalculator.java:152) > at > org.apache.tomcat.maven.plugin.tomcat7.run.RunMojo.createWebappLoader(RunMojo.java:239) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.createContext(AbstractRunMojo.java:612) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999) > at > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:512) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAc
svn commit: r1476401 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Author: markt
Date: Fri Apr 26 20:57:33 2013
New Revision: 1476401
URL: http://svn.apache.org/r1476401
Log:
Fix double start of Resources noticed while investigating CI unit test failures
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1476401&r1=1476400&r2=1476401&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Fri Apr 26
20:57:33 2013
@@ -4870,7 +4870,11 @@ public class StandardContext extends Con
resources.setCacheMaxSize(getCacheMaxSize());
resources.setCacheMaxObjectSize(getCacheObjectMaxSize());
-resources.start();
+// May have been started (but not fully configured) in init() so no
need
+// to start the resources if they are already available
+if (!resources.getState().isAvailable()) {
+resources.start();
+}
if (effectiveMajorVersion >=3 && addWebinfClassesResources) {
WebResource webinfClassesResource = resources.getResource(
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
