svn commit: r1410715 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/tagplugins/jstl/core/Out.java
Author: markt
Date: Sat Nov 17 10:10:16 2012
New Revision: 1410715
URL: http://svn.apache.org/viewvc?rev=1410715&view=rev
Log:
Follow up to r1410636
Fix test failure
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1410714
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java?rev=1410715&r1=1410714&r2=1410715&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java
Sat Nov 17 10:10:16 2012
@@ -48,6 +48,7 @@ public final class Out implements TagPlu
String strSkipBodyName = ctxt.getTemporaryVariableName();
//according to the tag file, the value attribute is mandatory.
+ctxt.generateImport("java.io.Reader");
ctxt.generateJavaSource("Object " + strObjectName + "=");
ctxt.generateAttribute("value");
ctxt.generateJavaSource(";");
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1410717 - /tomcat/tc7.0.x/trunk/build.properties.default
Author: markt Date: Sat Nov 17 10:13:58 2012 New Revision: 1410717 URL: http://svn.apache.org/viewvc?rev=1410717&view=rev Log: Restore -dev in version for trunk build Modified: tomcat/tc7.0.x/trunk/build.properties.default Modified: tomcat/tc7.0.x/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.properties.default?rev=1410717&r1=1410716&r2=1410717&view=diff == --- tomcat/tc7.0.x/trunk/build.properties.default (original) +++ tomcat/tc7.0.x/trunk/build.properties.default Sat Nov 17 10:13:58 2012 @@ -29,7 +29,7 @@ version.major=7 version.minor=0 version.build=33 version.patch=0 -version.suffix= +version.suffix=-dev # - Build control flags - # Note enabling validation uses Checkstyle which is LGPL licensed - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1410718 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_33: ./ build.properties.default
Author: markt Date: Sat Nov 17 10:16:22 2012 New Revision: 1410718 URL: http://svn.apache.org/viewvc?rev=1410718&view=rev Log: Tag 7.0.33 Added: tomcat/tc7.0.x/tags/TOMCAT_7_0_33/ (props changed) - copied from r1410717, tomcat/tc7.0.x/trunk/ Modified: tomcat/tc7.0.x/tags/TOMCAT_7_0_33/build.properties.default Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_33/ -- bugtraq:append = false Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_33/ -- bugtraq:label = Bugzilla ID (optional) Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_33/ -- --- bugtraq:message (added) +++ bugtraq:message Sat Nov 17 10:16:22 2012 @@ -0,0 +1 @@ +Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_33/ -- bugtraq:number = true Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_33/ -- bugtraq:url = https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_33/ -- bugtraq:warnifnoissue = false Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_33/ -- --- svn:ignore (added) +++ svn:ignore Sat Nov 17 10:16:22 2012 @@ -0,0 +1,7 @@ +.* +build.properties +logs +nbproject +output +work +*.iml Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_33/ -- --- svn:mergeinfo (added) +++ svn:mergeinfo Sat Nov 17 10:16:22 2012 @@ -0,0 +1 @@ +/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222328,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112 ,1240114,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342 320,1342476,1342498,1342503,1342717,1342795,1342805,1343044-1343046,1343335,1343394,1343400,1343629,1343708,1343718,1343895,1344063,1344068,1344250,1344266,1344515,1344528,1344612,1344629,1344725,1344868,1344890,1344893,1344896,1344901,1345020,1345029,1345039,1345287-1345290,1345294,1345309,1345325,1345357,1345367,1345579-1345580,1345582,1345688,1345699,1345704,1345731-1345732,1345737,1345744,1345752,1345754,1345779,1345781,1345846,1346107,1346376,1346404,1346510,1346514,1346519,1346581,1346635,1346644,1346683,1346794,1346885,1346932,1347034,1347047,1347087,1347108-1347109,1347583,1347737,1348105,1348357,1348398,1348425,1348461-1348495,1348498,1348752,1348762,1348772,1348776,1348859,1348968,1348973,1348989,1349007,1349237,1349298,1349317,1349410,1349473,1349539,1349879,1349887,1349893,1349922,1349984,1350124,1350241,1350243,1350294-1350295,1350299,1350864,1350900,1351010,1351054,1351056,1351068,1351134-1351135,1351148,1351259,1351604,1351636-1351640,1351991,1351993,1352011,1 352056,1352059,1352661,1352663,1352788,1352799,1353087,1353125,1353240,1353261,1353414,1353468,13
svn commit: r1410719 - in /tomcat/tc7.0.x/trunk: build.properties.default res/maven/mvn.properties.default
Author: markt Date: Sat Nov 17 10:18:33 2012 New Revision: 1410719 URL: http://svn.apache.org/viewvc?rev=1410719&view=rev Log: Prep for next release Modified: tomcat/tc7.0.x/trunk/build.properties.default tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default Modified: tomcat/tc7.0.x/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.properties.default?rev=1410719&r1=1410718&r2=1410719&view=diff == --- tomcat/tc7.0.x/trunk/build.properties.default (original) +++ tomcat/tc7.0.x/trunk/build.properties.default Sat Nov 17 10:18:33 2012 @@ -27,7 +27,7 @@ # - Version Control Flags - version.major=7 version.minor=0 -version.build=33 +version.build=34 version.patch=0 version.suffix=-dev Modified: tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default?rev=1410719&r1=1410718&r2=1410719&view=diff == --- tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default (original) +++ tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default Sat Nov 17 10:18:33 2012 @@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos maven.asf.release.repo.repositoryId=apache.releases # Release version info -maven.asf.release.deploy.version=7.0.33 +maven.asf.release.deploy.version=7.0.34 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tomcat 7.0.33 progress report
On 16/11/2012 17:02, Mark Thomas wrote: > I'll shout if I get stuck although the fastest way to find my errors > seems to be writing an e-mail to the dev list as shortly after I send > it, I spot the silly mistake that invalidates most of what I just wrote. As it was in this case. The TCKs all passed as well as the unit tests but the unit test failure in trunk indicated an error that existed in 7.0.x and trunk. This has been fixed and although it shouldn't impact the results of the unit tests or the TCKs I am re-running them before I upload the release candidate for voting. We should have an RC for voting ready by Monday at the latest. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Using comments.apache.org for our live docs
Thanks Konstantin. Will work over the weekend on your valuable remarks. On 08.11.2012 23:25, Konstantin Kolinko wrote: > 2012/11/8 Rainer Jung : >> Cross posting intentionally, because our long time users list supporters >> might want to comment as well. >> >> A few months ago a new Web Server committer, Daniel Gruno, suggested to use >> a commenting system as part of the online documentation. He wanted to >> include the disqus system. Some of his fellow committers were not very glad >> with using an external system for the users comments and he sat down and >> wrote an ASF commenting system. It is now running as an ASF service under >> comments.apache.org. >> >> It allows users to add comments to documentation pages. Comments without >> URLs and HTML tags are going live immediately without moderation, the other >> ones need moderation first. >> >> We are using it in the web server project since a few months and we observe >> close to no spam. Comment activity isn't to high, about 1 comments per day. >> Some of those are not actually docs comments and they are responded by >> referring the users to the users list. Some of them are really useful >> because they help to clarify and improve documentation. In the meantime, the >> trafficserver project also uses the feature. >> >> The comments are not meant to stay forever. Important content should be >> integrated into the docs. >> >> Technically the commenting is done by adding a few lines of html and inline >> JavaScript to each page, which then calls comments.apache.org. For the >> Tomcat docs this can be done by adding those items to the XSL stylesheet >> used to generate the HTML pages. >> >> I prepared a simple demo at: >> >> http://people.apache.org/~rjung/tomcat-docs-comments/tomcat-8.0-docs/ >> >> It would be nice if you would have a look and we would discuss, whether we >> find it useful or not. The patch for build.xml and the xsl that I applied to >> build the comment enabled docs can be found at >> >> http://people.apache.org/~rjung/patches/tc-trunk-comments.patch >> >> A final version would include a reference to tomcat.apache.org instead of >> people.apache.org/... The JavaScript checks the host header in order to >> disable the feature if the docs are running on a different server, e.g. >> inside a localhost Tomcat etc. >> > > Nice. > > Several notes: > >> A final version would include a reference to tomcat.apache.org > > 1. I think it needs to also allow tomcat.[eu|us].apache.org mirrors > and ci.apache.org where nightly builds of documentation are published. > > 2. I think that the comments should be be hidden when the document is > being printed. > > 3. Regarding the "Comments" section header and notice > > I think it would be better > a) to have this section more distinct from the rest of the page > (formatted as something "external" to the page itself), and > > b) to write proper introduction to the comments feature somewhere one > (formatted as a proper chapter/section of the documentation), > e,g, in the "Introduction" chapter, or maybe on the main tomcat.apache.org > site. > > The short notice section can have a link to this introduction. > > > Regarding the notice section, or rather the introduction to the > feature if we write one, > I would like to see the following: > 1) Maybe do not mention the IRC channel. > 2) Maybe mention how the comments are used. (Copyrights, AL) > 3) Maybe mention who sees the comments (Those who subscribe to receive > them. They are not forwarded to the public mailing list). > > Looking at httpd.a.o, > - the comments section header there spans the whole page width. > - the "Available Languages" line is above it. > - the "notice" is distinct from the rest of text by using a red border > - documentation and comments style is more consistent. They use the same font > > > 4. Looking at httpd.a.o, I noticed a nice feature: > http://httpd.apache.org/docs/2.2/configuring.html > http://httpd.apache.org/docs/2.4/configuring.html > > The "2.2" page has comments, the "2.4" does not. The following footer > is added to the "2.4" page: > "The 2.2 branch of the documentation has comments available for this > page. Click here to view them." > > > 5. It does not work well when I browse the main site through https. > > It works, but most of the links back and forth redirect to the http > version of it. > Examples: > a) The " Click here to view them." link mentioned above > b) The "View" link on a comment in the list of comments on comments.apache.org > > > 6. It is not clear what is lifecycle of a comment. > > I see that when I log in then there is a link above each comment that > allows to mark it as "Resolved". When (and who) is removing resolved > comments? > E.g. someone is supposed to do a manual sweep once the next minor > Tomcat version is released and its updated documentation is published? > The dashboard GUI is not very friendly for such a task. > > Some message boards have a feature where a
Making the Mapper type safe
Hi, I did some experiments about more flexible version mapping for contextes a while back and was a bit unhappy about the type unsafetyness of the Mapper. Internally it only uses plain Objects and the code using it has to cast everything. There is a patch available at http://people.apache.org/~rjung/patches/mapper-typesafe-trunk.patch that makes the Mapper type safe. The only changes outside of the mapper package is the removal of the casts. The TestMapper class had to be adjusted to use Host, Context and Wrapper objects instead of Strings. The test suite runs without errors. One change is potentially problematic: MapperListener previously registered a new context using the Container returned by context.getParent(), ignoring whether it is a Host or something else. I had to cast to Host, because registering a Context for any type of Container is no longer possible. I doubt that previously it would have really worked, because all code using the container returned later by the mapper would have assumed it to be a Host. The Context interface mentions in comments, that the parent might be something else than a Host. Does anyone know a good example? Would it have worked? What would the expected behaviour of MapperListener have been (where would it have registered that context in the mapper)? Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-taglibs-standard has an issue affecting its community
integration.
This issue affects 2 projects,
and has been outstanding for 189 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-taglibs-standard : Standard Taglib
- tomcat-taglibs-standard-install : JSP Taglibs
Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-INFO- Optional dependency httpunit failed with reason build failed
-DEBUG- (Apache Gump generated) Apache Maven Settings in:
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
-INFO- Failed with reason build failed
-DEBUG- Maven POM in:
/srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
-INFO- Failed to extract fallback artifacts from Gump Repository
The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
Work ended in a state of : Failed
Elapsed: 23 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
install
[Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
M2_HOME: /opt/maven2
-
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Nothing to compile - all classes are up to date
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] No sources to compile
[INFO] [surefire:test {execution: default-test}]
[INFO] Tests are skipped.
[INFO] [bundle:bundle {execution: default-bundle}]
[INFO] [install:install {execution: default-install}]
[INFO] Installing
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/target/taglibs-standard-spec-1.2-SNAPSHOT.jar
to
/srv/gump/public/workspace/mvnlocalrepo/shared/org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] [bundle:install {execution: default-install}]
[INFO] Parsing
file:/srv/gump/public/workspace/mvnlocalrepo/shared/repository.xml
[INFO] Installing
org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO]
[INFO] Building JSTL Implementation
[INFO]task-segment: [install]
[INFO]
[INFO] [remote-resources:process {execution: default}]
[INFO] snapshot org.apache.taglibs:taglibs-standard-spec:1.2-SNAPSHOT: checking
for updates from apache.snapshots
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 96 source files to
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/classes
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
error: DataSourceWrapper is not abstract and does not override abstract method
getParentLogger() in CommonDataSource
[INFO] 1 error
[INFO] -
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Compilation failure
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
error: DataSourceWrapper is not abstract and does not override abstract method
getParentLogger() in CommonDataSource
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO] --
Re: Making the Mapper type safe
On 17/11/2012 13:05, Rainer Jung wrote: > Hi, > > I did some experiments about more flexible version mapping for contextes > a while back and was a bit unhappy about the type unsafetyness of the > Mapper. Internally it only uses plain Objects and the code using it has > to cast everything. > > There is a patch available at > > http://people.apache.org/~rjung/patches/mapper-typesafe-trunk.patch There is a lot to take in there. I am generally in agreement but find myself rather overwhelmed by the patch. May I suggest you go ahead with just the renaming of Host->MappedHost etc and commit that to trunk (should be simple to do in an IDE) and then prepare a patch that makes the mapper type safe. If it would be easier for me to make the name changes and then you could just svn up I'm happy to do so. Let me know. > that makes the Mapper type safe. The only changes outside of the mapper > package is the removal of the casts. The TestMapper class had to be > adjusted to use Host, Context and Wrapper objects instead of Strings. > > The test suite runs without errors. > > One change is potentially problematic: MapperListener previously > registered a new context using the Container returned by > context.getParent(), ignoring whether it is a Host or something else. I > had to cast to Host, because registering a Context for any type of > Container is no longer possible. I doubt that previously it would have > really worked, because all code using the container returned later by > the mapper would have assumed it to be a Host. > > The Context interface mentions in comments, that the parent might be > something else than a Host. Does anyone know a good example? I can't think of a single example. > Would it have worked? No. I see multiple places where the result would be an NPE if Context->Host->Engine is not in place. > What would the expected behaviour of MapperListener have > been (where would it have registered that context in the mapper)? I doubt the start up processes would have got that far. I suspect that the initial design allowed for a different container hierarchy but over time the Wrapper->Context->Host->Engine hierarchy has become embedded in numerous places in the code. I see no reason to unpick that so lets make it explicit and override getParent() for Wrapper, Context and Host for Tomcat 8. It will enable us to remove lots of casting and we may even find a few obscure bugs. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1410732 - /tomcat/trunk/java/org/apache/tomcat/util/modeler/NotificationInfo.java
Author: markt
Date: Sat Nov 17 14:53:03 2012
New Revision: 1410732
URL: http://svn.apache.org/viewvc?rev=1410732&view=rev
Log:
Fix a FindBugs issue (incorrect synchronization)
Modified:
tomcat/trunk/java/org/apache/tomcat/util/modeler/NotificationInfo.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/modeler/NotificationInfo.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/modeler/NotificationInfo.java?rev=1410732&r1=1410731&r2=1410732&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/modeler/NotificationInfo.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/modeler/NotificationInfo.java Sat
Nov 17 14:53:03 2012
@@ -14,14 +14,14 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
-
package org.apache.tomcat.util.modeler;
+import java.util.concurrent.locks.Lock;
+import java.util.concurrent.locks.ReadWriteLock;
+import java.util.concurrent.locks.ReentrantReadWriteLock;
import javax.management.MBeanNotificationInfo;
-
/**
* Internal configuration information for a Notification
* descriptor.
@@ -29,8 +29,8 @@ import javax.management.MBeanNotificatio
* @author Craig R. McClanahan
* @version $Id$
*/
-
public class NotificationInfo extends FeatureInfo {
+
static final long serialVersionUID = -6319885418912650856L;
// - Instance Variables
@@ -42,6 +42,7 @@ public class NotificationInfo extends Fe
*/
transient MBeanNotificationInfo info = null;
protected String notifTypes[] = new String[0];
+protected ReadWriteLock notifTypesLock = new ReentrantReadWriteLock();
// - Properties
@@ -74,7 +75,13 @@ public class NotificationInfo extends Fe
* The set of notification types for this MBean.
*/
public String[] getNotifTypes() {
-return (this.notifTypes);
+Lock readLock = notifTypesLock.readLock();
+try {
+readLock.lock();
+return this.notifTypes;
+} finally {
+readLock.unlock();
+}
}
@@ -88,14 +95,18 @@ public class NotificationInfo extends Fe
*/
public void addNotifType(String notifType) {
-synchronized (notifTypes) {
+Lock writeLock = notifTypesLock.writeLock();
+try {
+writeLock.lock();
+
String results[] = new String[notifTypes.length + 1];
System.arraycopy(notifTypes, 0, results, 0, notifTypes.length);
results[notifTypes.length] = notifType;
notifTypes = results;
this.info = null;
+} finally {
+writeLock.unlock();
}
-
}
@@ -107,7 +118,7 @@ public class NotificationInfo extends Fe
// Return our cached information (if any)
if (info != null)
-return (info);
+return info;
// Create and return a new information object
info = new MBeanNotificationInfo
@@ -115,7 +126,7 @@ public class NotificationInfo extends Fe
//Descriptor descriptor = info.getDescriptor();
//addFields(descriptor);
//info.setDescriptor(descriptor);
-return (info);
+return info;
}
@@ -132,11 +143,14 @@ public class NotificationInfo extends Fe
sb.append(", description=");
sb.append(description);
sb.append(", notifTypes=");
-sb.append(notifTypes.length);
+Lock readLock = notifTypesLock.readLock();
+try {
+readLock.lock();
+sb.append(notifTypes.length);
+} finally {
+readLock.unlock();
+}
sb.append("]");
return (sb.toString());
-
}
-
-
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1410733 - /tomcat/trunk/res/findbugs/filter-false-positives.xml
Author: markt Date: Sat Nov 17 14:53:20 2012 New Revision: 1410733 URL: http://svn.apache.org/viewvc?rev=1410733&view=rev Log: Silence another false positive Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1410733&r1=1410732&r2=1410733&view=diff == --- tomcat/trunk/res/findbugs/filter-false-positives.xml (original) +++ tomcat/trunk/res/findbugs/filter-false-positives.xml Sat Nov 17 14:53:20 2012 @@ -278,6 +278,12 @@ + + + + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1410740 - /tomcat/trunk/java/org/apache/tomcat/util/modeler/OperationInfo.java
Author: markt
Date: Sat Nov 17 15:20:08 2012
New Revision: 1410740
URL: http://svn.apache.org/viewvc?rev=1410740&view=rev
Log:
Fix a FindBugs issue (incorrect synchronization)
Modified:
tomcat/trunk/java/org/apache/tomcat/util/modeler/OperationInfo.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/modeler/OperationInfo.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/modeler/OperationInfo.java?rev=1410740&r1=1410739&r2=1410740&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/modeler/OperationInfo.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/modeler/OperationInfo.java Sat Nov
17 15:20:08 2012
@@ -14,17 +14,16 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
-
package org.apache.tomcat.util.modeler;
-
import java.util.Locale;
+import java.util.concurrent.locks.Lock;
+import java.util.concurrent.locks.ReadWriteLock;
+import java.util.concurrent.locks.ReentrantReadWriteLock;
import javax.management.MBeanOperationInfo;
import javax.management.MBeanParameterInfo;
-
/**
* Internal configuration information for an Operation
* descriptor.
@@ -32,23 +31,24 @@ import javax.management.MBeanParameterIn
* @author Craig R. McClanahan
*/
public class OperationInfo extends FeatureInfo {
+
static final long serialVersionUID = 4418342922072614875L;
-// --- Constructors
+// --- Constructors
/**
* Standard zero-arguments constructor.
*/
public OperationInfo() {
-
super();
-
}
+
// - Instance Variables
protected String impact = "UNKNOWN";
protected String role = "operation";
+protected ReadWriteLock parametersLock = new ReentrantReadWriteLock();
protected ParameterInfo parameters[] = new ParameterInfo[0];
@@ -59,7 +59,7 @@ public class OperationInfo extends Featu
* string value "ACTION", "ACTION_INFO", "INFO", or "UNKNOWN".
*/
public String getImpact() {
-return (this.impact);
+return this.impact;
}
public void setImpact(String impact) {
@@ -75,7 +75,7 @@ public class OperationInfo extends Featu
* "constructor").
*/
public String getRole() {
-return (this.role);
+return this.role;
}
public void setRole(String role) {
@@ -102,7 +102,13 @@ public class OperationInfo extends Featu
* The set of parameters for this operation.
*/
public ParameterInfo[] getSignature() {
-return (this.parameters);
+Lock readLock = parametersLock.readLock();
+try {
+readLock.lock();
+return this.parameters;
+} finally {
+readLock.unlock();
+}
}
// - Public Methods
@@ -115,14 +121,17 @@ public class OperationInfo extends Featu
*/
public void addParameter(ParameterInfo parameter) {
-synchronized (parameters) {
+Lock writeLock = parametersLock.writeLock();
+try {
+writeLock.lock();
ParameterInfo results[] = new ParameterInfo[parameters.length + 1];
System.arraycopy(parameters, 0, results, 0, parameters.length);
results[parameters.length] = parameter;
parameters = results;
this.info = null;
+} finally {
+writeLock.unlock();
}
-
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3574 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1410733 Blamelist: markt Build succeeded! sincerely, -The Buildbot
svn commit: r1410742 - /tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java
Author: markt
Date: Sat Nov 17 15:53:34 2012
New Revision: 1410742
URL: http://svn.apache.org/viewvc?rev=1410742&view=rev
Log:
Refactor since returning -1 makes no sense with chars. The old code worked but
it was a little odd (and FindBugs didn't like it).
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java?rev=1410742&r1=1410741&r2=1410742&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java Sat Nov 17
15:53:34 2012
@@ -240,8 +240,9 @@ public class ELParser {
if (Character.isJavaIdentifierStart(ch)) {
StringBuilder buf = new StringBuilder();
buf.append(ch);
-while ((ch = peekChar()) != -1
-&& Character.isJavaIdentifierPart(ch)) {
+while (index < expression.length() &&
+Character.isJavaIdentifierPart(
+ch = expression.charAt(index))) {
buf.append(ch);
nextChar();
}
@@ -307,13 +308,6 @@ public class ELParser {
return expression.charAt(index++);
}
-private char peekChar() {
-if (index >= expression.length()) {
-return (char) -1;
-}
-return expression.charAt(index);
-}
-
private int getIndex() {
return index;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1410752 - in /tomcat/trunk: java/org/apache/catalina/mapper/Mapper.java test/org/apache/catalina/mapper/TestMapper.java
Author: rjung
Date: Sat Nov 17 17:12:18 2012
New Revision: 1410752
URL: http://svn.apache.org/viewvc?rev=1410752&view=rev
Log:
Type-Safety for the Mapper - Part 1.
Rename inner classes Host, Context and Wrapper
to MappedHost, MappedContext and MappedWrapper.
Modified:
tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java
tomcat/trunk/test/org/apache/catalina/mapper/TestMapper.java
Modified: tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java?rev=1410752&r1=1410751&r2=1410752&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java (original)
+++ tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java Sat Nov 17
17:12:18 2012
@@ -47,7 +47,7 @@ public final class Mapper {
/**
* Array containing the virtual hosts definitions.
*/
-protected Host[] hosts = new Host[0];
+protected MappedHost[] hosts = new MappedHost[0];
/**
@@ -83,8 +83,8 @@ public final class Mapper {
*/
public synchronized void addHost(String name, String[] aliases,
Object host) {
-Host[] newHosts = new Host[hosts.length + 1];
-Host newHost = new Host();
+MappedHost[] newHosts = new MappedHost[hosts.length + 1];
+MappedHost newHost = new MappedHost();
ContextList contextList = new ContextList();
newHost.name = name;
newHost.contextList = contextList;
@@ -93,8 +93,8 @@ public final class Mapper {
hosts = newHosts;
}
for (int i = 0; i < aliases.length; i++) {
-newHosts = new Host[hosts.length + 1];
-newHost = new Host();
+newHosts = new MappedHost[hosts.length + 1];
+newHost = new MappedHost();
newHost.name = aliases[i];
newHost.contextList = contextList;
newHost.object = host;
@@ -117,14 +117,14 @@ public final class Mapper {
return;
}
Object host = hosts[pos].object;
-Host[] newHosts = new Host[hosts.length - 1];
+MappedHost[] newHosts = new MappedHost[hosts.length - 1];
if (removeMap(hosts, newHosts, name)) {
hosts = newHosts;
}
// Remove all aliases (they will map to the same host object)
for (int i = 0; i < newHosts.length; i++) {
if (newHosts[i].object == host) {
-Host[] newHosts2 = new Host[hosts.length - 1];
+MappedHost[] newHosts2 = new MappedHost[hosts.length - 1];
if (removeMap(hosts, newHosts2, newHosts[i].name)) {
hosts = newHosts2;
}
@@ -144,10 +144,10 @@ public final class Mapper {
// just in case...
return;
}
-Host realHost = hosts[pos];
+MappedHost realHost = hosts[pos];
-Host[] newHosts = new Host[hosts.length + 1];
-Host newHost = new Host();
+MappedHost[] newHosts = new MappedHost[hosts.length + 1];
+MappedHost newHost = new MappedHost();
newHost.name = alias;
newHost.contextList = realHost.contextList;
newHost.object = realHost.object;
@@ -166,7 +166,7 @@ public final class Mapper {
if (pos < 0) {
return;
}
-Host[] newHosts = new Host[hosts.length - 1];
+MappedHost[] newHosts = new MappedHost[hosts.length - 1];
if (removeMap(hosts, newHosts, alias)) {
hosts = newHosts;
}
@@ -189,7 +189,7 @@ public final class Mapper {
String version, Object context, String[] welcomeResources,
WebResourceRoot resources) {
-Host[] hosts = this.hosts;
+MappedHost[] hosts = this.hosts;
int pos = find(hosts, hostName);
if( pos <0 ) {
addHost(hostName, new String[0], host);
@@ -199,27 +199,27 @@ public final class Mapper {
if (pos < 0) {
log.error("No host found: " + hostName);
}
-Host mappedHost = hosts[pos];
+MappedHost mappedHost = hosts[pos];
if (mappedHost.name.equals(hostName)) {
int slashCount = slashCount(path);
synchronized (mappedHost) {
-Context[] contexts = mappedHost.contextList.contexts;
+MappedContext[] contexts = mappedHost.contextList.contexts;
// Update nesting
if (slashCount > mappedHost.contextList.nesting) {
mappedHost.contextList.nesting = slashCount;
}
int pos2 = find(contexts, path);
if (pos2 < 0 || !path.equals(contexts[pos2].name)) {
-Context newContext = new Context();
+MappedContext newContext = new MappedContext();
newContext.name =
Re: Making the Mapper type safe
On 17.11.2012 15:35, Mark Thomas wrote: > On 17/11/2012 13:05, Rainer Jung wrote: >> Hi, >> >> I did some experiments about more flexible version mapping for contextes >> a while back and was a bit unhappy about the type unsafetyness of the >> Mapper. Internally it only uses plain Objects and the code using it has >> to cast everything. >> >> There is a patch available at >> >> http://people.apache.org/~rjung/patches/mapper-typesafe-trunk.patch > > There is a lot to take in there. I am generally in agreement but find > myself rather overwhelmed by the patch. May I suggest you go ahead with > just the renaming of Host->MappedHost etc and commit that to trunk > (should be simple to do in an IDE) and then prepare a patch that makes > the mapper type safe. Renaming committed as r1410752. Remaining patch (half the size, biggest part in TestMapper, plus the generics in MapElement): http://people.apache.org/~rjung/patches/mapper-typesafe-trunk-v2.patch > If it would be easier for me to make the name changes and then you could > just svn up I'm happy to do so. Let me know. Thanks, it was easy for me as well :) >> One change is potentially problematic: MapperListener previously >> registered a new context using the Container returned by >> context.getParent(), ignoring whether it is a Host or something else. I >> had to cast to Host, because registering a Context for any type of >> Container is no longer possible. I doubt that previously it would have >> really worked, because all code using the container returned later by >> the mapper would have assumed it to be a Host. >> >> The Context interface mentions in comments, that the parent might be >> something else than a Host. Does anyone know a good example? > > I can't think of a single example. > >> Would it have worked? > > No. I see multiple places where the result would be an NPE if > Context->Host->Engine is not in place. > >> What would the expected behaviour of MapperListener have >> been (where would it have registered that context in the mapper)? > > I doubt the start up processes would have got that far. OK > I suspect that the initial design allowed for a different container > hierarchy but over time the Wrapper->Context->Host->Engine hierarchy has > become embedded in numerous places in the code. I see no reason to > unpick that so lets make it explicit and override getParent() for > Wrapper, Context and Host for Tomcat 8. It will enable us to remove lots > of casting and we may even find a few obscure bugs. Good, so that could be a next step after the remaining mapper type-safety changes. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
AccessLogValve test failure (timezone)
Currently the ALV tests fail for me because of a hard coded timezone in
the test. We can either copy some logic from ALV into the test class, or
make the private static method getTimeZone(() protected and call it from
the test class. A patch for the latter approach is available at:
http://people.apache.org/~rjung/patches/test-alv-timezone.patch
If we wanted to copy in, the code basically boils down to
timezone = TimeZone.getDefault();
if (timezone.inDaylightTime(date)) {
int offset = timezone.getDSTSavings();
return calculateTimeZoneOffset(timezone.getRawOffset() + offset);
} else {
return calculateTimeZoneOffset(timezone.getRawOffset());
}
and calculateTimeZoneOffset() is another 20 lines private static method
that formats the timezone offset.
I'd go with making the getTimeZone(() method protected. Of course we
then do not test the timezone formatting code, only the caching, like we
do now.
Regards,
Rainer
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Making the Mapper type safe
On 17/11/2012 17:22, Rainer Jung wrote: > On 17.11.2012 15:35, Mark Thomas wrote: >> On 17/11/2012 13:05, Rainer Jung wrote: >>> Hi, >>> >>> I did some experiments about more flexible version mapping for contextes >>> a while back and was a bit unhappy about the type unsafetyness of the >>> Mapper. Internally it only uses plain Objects and the code using it has >>> to cast everything. >>> >>> There is a patch available at >>> >>> http://people.apache.org/~rjung/patches/mapper-typesafe-trunk.patch >> >> There is a lot to take in there. I am generally in agreement but find >> myself rather overwhelmed by the patch. May I suggest you go ahead with >> just the renaming of Host->MappedHost etc and commit that to trunk >> (should be simple to do in an IDE) and then prepare a patch that makes >> the mapper type safe. > > Renaming committed as r1410752. Thanks. Much easier to review. > Remaining patch (half the size, biggest part in TestMapper, plus the > generics in MapElement): > > http://people.apache.org/~rjung/patches/mapper-typesafe-trunk-v2.patch +1. Looks good to me. >> I suspect that the initial design allowed for a different container >> hierarchy but over time the Wrapper->Context->Host->Engine hierarchy has >> become embedded in numerous places in the code. I see no reason to >> unpick that so lets make it explicit and override getParent() for >> Wrapper, Context and Host for Tomcat 8. It will enable us to remove lots >> of casting and we may even find a few obscure bugs. > > Good, so that could be a next step after the remaining mapper > type-safety changes. +1 Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "PoweredBy" by Neha
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "PoweredBy" page has been changed by Neha:
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=446&rev2=447
=== Merkaweb.com (Web Hosting Spain) ===
{{http://www.merkaweb.com/images/logo2.png}}
[[http://www.merkaweb.com|Alojamiento Web]] - Spanish based web hosting company
supporting Tomcat in all cPanel web hosting plans. Professional web hosting
services since 2003.
+
+ === Milesweb.com (Web Hosting India) ===
+ [[http://www.milesweb.com/hosting-faqs/what-is-apache-tomcat-hosting/|Apache
Tomcat Hosting]] - India based web hosting company supporting Tomcat in all
cPanel web hosting plans.
=== Pickaweb - UK Web Hosting ===
[[http://www.pickaweb.co.uk|{{http://www.pickaweb.co.uk/images/logo.png|http://www.pickaweb.co.uk}}]]
[[http://www.pickaweb.co.uk|UK Web Hosting]] - Supporting Tomcat in all of our
web hosting plans. Professional UK based web hosting services since 2000. 24x7
Support via chat, phone & email.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1410763 - /tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
Author: rjung
Date: Sat Nov 17 19:25:18 2012
New Revision: 1410763
URL: http://svn.apache.org/viewvc?rev=1410763&view=rev
Log:
Fix time zone formatting in ALV test.
Test failed in non-GMT time zone.
Modified:
tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
Modified: tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java?rev=1410763&r1=1410762&r2=1410763&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java Sat
Nov 17 19:25:18 2012
@@ -34,7 +34,7 @@ public class TestAccessLogValve {
final int cacheSize = 10;
SimpleDateFormat sdf =
-new SimpleDateFormat("dd/MMM/:HH:mm:ss", Locale.US);
+new SimpleDateFormat("[dd/MMM/:HH:mm:ss Z]", Locale.US);
sdf.setTimeZone(TimeZone.getDefault());
AccessLogValve.DateFormatCache dfc =
@@ -89,6 +89,7 @@ public class TestAccessLogValve {
}
private String generateExpected(SimpleDateFormat sdf, long secs) {
-return "[" + sdf.format(new Date(secs * 1000)) + " +]";
+System.out.println("generateExpected: " + sdf.format(new Date(secs *
1000)));
+return sdf.format(new Date(secs * 1000));
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: AccessLogValve test failure (timezone)
On 17.11.2012 18:53, Rainer Jung wrote:
> Currently the ALV tests fail for me because of a hard coded timezone in
> the test. We can either copy some logic from ALV into the test class, or
> make the private static method getTimeZone(() protected and call it from
> the test class. A patch for the latter approach is available at:
>
> http://people.apache.org/~rjung/patches/test-alv-timezone.patch
>
> If we wanted to copy in, the code basically boils down to
>
> timezone = TimeZone.getDefault();
> if (timezone.inDaylightTime(date)) {
> int offset = timezone.getDSTSavings();
> return calculateTimeZoneOffset(timezone.getRawOffset() + offset);
> } else {
> return calculateTimeZoneOffset(timezone.getRawOffset());
> }
>
> and calculateTimeZoneOffset() is another 20 lines private static method
> that formats the timezone offset.
>
> I'd go with making the getTimeZone(() method protected. Of course we
> then do not test the timezone formatting code, only the caching, like we
> do now.
Rubbish. Failure fixed in a simpler way by r1410763.
Regards,
Rainer
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1410764 - in /tomcat/trunk: build.properties.default java/org/apache/jasper/compiler/JDTCompiler.java
Author: markt
Date: Sat Nov 17 19:27:33 2012
New Revision: 1410764
URL: http://svn.apache.org/viewvc?rev=1410764&view=rev
Log:
Update JDT complier to 4.2.1
Fixes Findbugs warning
Modified:
tomcat/trunk/build.properties.default
tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1410764&r1=1410763&r2=1410764&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Sat Nov 17 19:27:33 2012
@@ -122,14 +122,14 @@ wsdl4j-lib.home=${base.path}/wsdl4j-${ws
wsdl4j-lib.loc=${base-maven.loc}/wsdl4j/wsdl4j/${wsdl4j-lib.version}/wsdl4j-${wsdl4j-lib.version}.jar
wsdl4j-lib.jar=${wsdl4j-lib.home}/wsdl4j-${wsdl4j-lib.version}.jar
-# - Eclipse JDT, version 3.2 or later -
-jdt.version=3.7.2
-jdt.release=R-3.7.2-201202080800
+# - Eclipse JDT, version 3.2 or later -#
+jdt.version=4.2.1
+jdt.release=R-4.2.1-201209141800
jdt.home=${base.path}/ecj-${jdt.version}
jdt.jar=${jdt.home}/ecj-${jdt.version}.jar
# The download will be moved to the archive area eventually. We are taking
care of that in advance.
-jdt.loc.1=http://archive.eclipse.org/eclipse/downloads/drops/${jdt.release}/ecj-${jdt.version}.jar
-jdt.loc.2=http://download.eclipse.org/eclipse/downloads/drops/${jdt.release}/ecj-${jdt.version}.jar
+jdt.loc.1=http://archive.eclipse.org/eclipse/downloads/drops4/${jdt.release}/ecj-${jdt.version}.jar
+jdt.loc.2=http://download.eclipse.org/eclipse/downloads/drops4/${jdt.release}/ecj-${jdt.version}.jar
# NPN support
npn.version=8.1.2.v20120308
Modified: tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java?rev=1410764&r1=1410763&r2=1410764&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java Sat Nov 17
19:27:33 2012
@@ -165,8 +165,7 @@ public class JDTCompiler extends org.apa
return result;
}
-@SuppressWarnings("unused") // New method added to interface in
-// later JDT versions
+@Override
public boolean ignoreOptionalProblems() {
return false;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1410764 - in /tomcat/trunk: build.properties.default java/org/apache/jasper/compiler/JDTCompiler.java
On 17/11/2012 19:27, ma...@apache.org wrote: > Author: markt > Date: Sat Nov 17 19:27:33 2012 > New Revision: 1410764 > > URL: http://svn.apache.org/viewvc?rev=1410764&view=rev > Log: > Update JDT complier to 4.2.1 Thoughts on back-porting this to 7.0.x? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1410766 - /tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
Author: rjung
Date: Sat Nov 17 19:47:59 2012
New Revision: 1410766
URL: http://svn.apache.org/viewvc?rev=1410766&view=rev
Log:
Sorry, committed debug code in r1410763.
Modified:
tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
Modified: tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java?rev=1410766&r1=1410765&r2=1410766&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java Sat
Nov 17 19:47:59 2012
@@ -89,7 +89,6 @@ public class TestAccessLogValve {
}
private String generateExpected(SimpleDateFormat sdf, long secs) {
-System.out.println("generateExpected: " + sdf.format(new Date(secs *
1000)));
return sdf.format(new Date(secs * 1000));
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1410770 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/valves/TestAccessLogValve.java webapps/docs/changelog.xml
Author: rjung
Date: Sat Nov 17 19:54:35 2012
New Revision: 1410770
URL: http://svn.apache.org/viewvc?rev=1410770&view=rev
Log:
Fix time zone formatting in ALV test.
Test failed in non-GMT time zone.
Backport of r1410763 and r1410766 from trunk.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1410763,1410766
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java?rev=1410770&r1=1410769&r2=1410770&view=diff
==
---
tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
(original)
+++
tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
Sat Nov 17 19:54:35 2012
@@ -34,7 +34,7 @@ public class TestAccessLogValve {
final int cacheSize = 10;
SimpleDateFormat sdf =
-new SimpleDateFormat("dd/MMM/:HH:mm:ss", Locale.US);
+new SimpleDateFormat("[dd/MMM/:HH:mm:ss Z]", Locale.US);
sdf.setTimeZone(TimeZone.getDefault());
AccessLogValve.DateFormatCache dfc =
@@ -89,6 +89,6 @@ public class TestAccessLogValve {
}
private String generateExpected(SimpleDateFormat sdf, long secs) {
-return "[" + sdf.format(new Date(secs * 1000)) + " +]";
+return sdf.format(new Date(secs * 1000));
}
}
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1410770&r1=1410769&r2=1410770&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sat Nov 17 19:54:35 2012
@@ -53,6 +53,15 @@
They eventually become mixed with the numbered issues. (I.e., numbered
issues to not "pop up" wrt. others).
-->
+
+
+
+
+Fix unit test for AccessLogValve when using non-GMT time zone. (rjung)
+
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1410764 - in /tomcat/trunk: build.properties.default java/org/apache/jasper/compiler/JDTCompiler.java
2012/11/17 Mark Thomas : > On 17/11/2012 19:27, ma...@apache.org wrote: >> Author: markt >> Date: Sat Nov 17 19:27:33 2012 >> New Revision: 1410764 >> >> URL: http://svn.apache.org/viewvc?rev=1410764&view=rev >> Log: >> Update JDT complier to 4.2.1 > > Thoughts on back-porting this to 7.0.x? > +1 The compiler in Eclipse 3.7.2 was crashing for me when compiling Tomcat 8. I switched over to 4.2.1 a week ago and the problem disappeared. Someone else with Java 7 could be experiencing a similar issue, so it is better to upgrade. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1408739 - in /tomcat/trunk: java/org/apache/catalina/startup/RealmRuleSet.java webapps/docs/config/systemprops.xml
Mark,
Apologies for the late reply. Please see comments inline.
On 11/13/12 9:17 AM, ma...@apache.org wrote:
> Author: markt
> Date: Tue Nov 13 14:17:42 2012
> New Revision: 1408739
>
> URL: http://svn.apache.org/viewvc?rev=1408739&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54141
> Increase the maximum number of supported nested realm levels from 2 to 3 and
> make the maximum configurable via a system property.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/startup/RealmRuleSet.java
> tomcat/trunk/webapps/docs/config/systemprops.xml
>
> Modified: tomcat/trunk/java/org/apache/catalina/startup/RealmRuleSet.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/RealmRuleSet.java?rev=1408739&r1=1408738&r2=1408739&view=diff
> ==
> --- tomcat/trunk/java/org/apache/catalina/startup/RealmRuleSet.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/startup/RealmRuleSet.java Tue Nov
> 13 14:17:42 2012
> @@ -34,6 +34,10 @@ import org.apache.tomcat.util.digester.R
> public class RealmRuleSet extends RuleSetBase {
>
>
> +private static final int MAX_NESTED_REALM_LEVELS = Integer.getInteger(
> +
> "org.apache.catalina.startup.RealmRuleSet.MAX_NESTED_REALM_LEVELS",
> +3).intValue();
> +
> // - Instance
> Variables
>
>
> @@ -83,23 +87,28 @@ public class RealmRuleSet extends RuleSe
> @Override
> public void addRuleInstances(Digester digester) {
>
> -digester.addObjectCreate(prefix + "Realm",
> - null, // MUST be specified in the element,
> - "className");
> -digester.addSetProperties(prefix + "Realm");
> -digester.addSetNext(prefix + "Realm",
> -"setRealm",
> -"org.apache.catalina.Realm");
> -
> -digester.addObjectCreate(prefix + "Realm/Realm",
> - null, // MUST be specified in the element
> - "className");
> -digester.addSetProperties(prefix + "Realm/Realm");
> -digester.addSetNext(prefix + "Realm/Realm",
> -"addRealm",
> -"org.apache.catalina.Realm");
> -
> -}
> +String pattern = prefix;
>
> +for (int i = 0; i < MAX_NESTED_REALM_LEVELS; i++) {
>
> +if (i > 0) {
> +pattern += "/";
> +}
> +pattern += "Realm";
> +
> +digester.addObjectCreate(pattern,
> + null, // MUST be specified in the
> element,
> + "className");
> +digester.addSetProperties(pattern);
> +if (i == 0) {
> +digester.addSetNext(pattern,
> +"setRealm",
> +"org.apache.catalina.Realm");
> +} else {
> +digester.addSetNext(pattern,
> +"addRealm",
> +"org.apache.catalina.Realm");
> +}
> +}
> +}
The code above might be a bit more straightforward if you did "step 1"
(prefix/Realm + setRealm) above the loop and then loop for each "nested"
realm.
Also, I think most users would expect setting MAX_NESTED_REALM_LEVELS
to, say, 3, would allow Realm/Realm/Realm while I believe the code above
will only allow Realm/Realm. If you want Realm/Realm/Realm, you have to
set MAX_NESTED_REALM_LEVELS to 4 because of the strictly-less-than that
you have in the loop control statement.
Thanks,
-chris
signature.asc
Description: OpenPGP digital signature
Re: Delete catalina.out
Josh, On 11/15/12 2:45 PM, Josh Gooding wrote: > That is the tomcat default log file. Nothing server wise will happen if > you delete if that is your concern. It just removes that particular log > file. I believe that you have to either be root and/or have the server > stopped to remove the file however. On a *NIX system, neither of the above statements are true: you may delete the file while a process holds a file handle to the file (the file will no longer be accessible to any other process -- at least under its old name) without harm. I'm not sure what will happen on win32. You'll either fail to delete the file or get the *NIX-style behavior. Once deleted, the file will be re-created when Tomcat next launches, as long as the Tomcat process has "create" privileges for the CATALINA_BASE/logs directory. -chris signature.asc Description: OpenPGP digital signature
Re: svn commit: r1408739 - in /tomcat/trunk: java/org/apache/catalina/startup/RealmRuleSet.java webapps/docs/config/systemprops.xml
Mark,
On 11/17/12 8:04 PM, Christopher Schultz wrote:
> Apologies for the late reply. Please see comments inline.
>
> On 11/13/12 9:17 AM, ma...@apache.org wrote:
>> Author: markt
>> Date: Tue Nov 13 14:17:42 2012
>> New Revision: 1408739
>>
>> URL: http://svn.apache.org/viewvc?rev=1408739&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54141
>> Increase the maximum number of supported nested realm levels from 2 to 3 and
>> make the maximum configurable via a system property.
>>
>> Modified:
>> tomcat/trunk/java/org/apache/catalina/startup/RealmRuleSet.java
>> tomcat/trunk/webapps/docs/config/systemprops.xml
>>
>> Modified: tomcat/trunk/java/org/apache/catalina/startup/RealmRuleSet.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/RealmRuleSet.java?rev=1408739&r1=1408738&r2=1408739&view=diff
>> ==
>> --- tomcat/trunk/java/org/apache/catalina/startup/RealmRuleSet.java
>> (original)
>> +++ tomcat/trunk/java/org/apache/catalina/startup/RealmRuleSet.java Tue Nov
>> 13 14:17:42 2012
>> @@ -34,6 +34,10 @@ import org.apache.tomcat.util.digester.R
>> public class RealmRuleSet extends RuleSetBase {
>>
>>
>> +private static final int MAX_NESTED_REALM_LEVELS = Integer.getInteger(
>> +
>> "org.apache.catalina.startup.RealmRuleSet.MAX_NESTED_REALM_LEVELS",
>> +3).intValue();
>> +
>> // - Instance
>> Variables
>>
>>
>> @@ -83,23 +87,28 @@ public class RealmRuleSet extends RuleSe
>> @Override
>> public void addRuleInstances(Digester digester) {
>>
>> -digester.addObjectCreate(prefix + "Realm",
>> - null, // MUST be specified in the element,
>> - "className");
>> -digester.addSetProperties(prefix + "Realm");
>> -digester.addSetNext(prefix + "Realm",
>> -"setRealm",
>> -"org.apache.catalina.Realm");
>> -
>> -digester.addObjectCreate(prefix + "Realm/Realm",
>> - null, // MUST be specified in the element
>> - "className");
>> -digester.addSetProperties(prefix + "Realm/Realm");
>> -digester.addSetNext(prefix + "Realm/Realm",
>> -"addRealm",
>> -"org.apache.catalina.Realm");
>> -
>> -}
>> +String pattern = prefix;
>>
>> +for (int i = 0; i < MAX_NESTED_REALM_LEVELS; i++) {
>>
>> +if (i > 0) {
>> +pattern += "/";
>> +}
>> +pattern += "Realm";
>> +
>> +digester.addObjectCreate(pattern,
>> + null, // MUST be specified in the
>> element,
>> + "className");
>> +digester.addSetProperties(pattern);
>> +if (i == 0) {
>> +digester.addSetNext(pattern,
>> +"setRealm",
>> +"org.apache.catalina.Realm");
>> +} else {
>> +digester.addSetNext(pattern,
>> +"addRealm",
>> +"org.apache.catalina.Realm");
>> +}
>> +}
>> +}
>
> The code above might be a bit more straightforward if you did "step 1"
> (prefix/Realm + setRealm) above the loop and then loop for each "nested"
> realm.
>
> Also, I think most users would expect setting MAX_NESTED_REALM_LEVELS
> to, say, 3, would allow Realm/Realm/Realm while I believe the code above
> will only allow Realm/Realm. If you want Realm/Realm/Realm, you have to
> set MAX_NESTED_REALM_LEVELS to 4 because of the strictly-less-than that
> you have in the loop control statement.
That last part is, of course, nonsense. That's what I get for reading
code while quite exhausted.
I still think that the code would be more straightforward without a
special-case when i=0.
-chris
signature.asc
Description: OpenPGP digital signature
Bug report for Tomcat 6 [2012/11/18]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43400|New|Enh|2007-09-14|enum support for tag libs | |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context.xml does not update do| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46727|New|Enh|2009-02-17|DefaultServlet - serving multiple encodings | |46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch| |47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho| |47242|New|Enh|2009-05-22|request for AJP command line client | |47281|New|Enh|2009-05-28|Efficiency of the JDBCStore | |47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session| |47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath| |47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked| |47919|New|Enh|2009-09-30|Log Tomcat & Java environment variables in additio| |48358|Opn|Enh|2009-12-09|JSP-unloading reloaded| |48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.| |48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b| |48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe| |48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr| |48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems| |48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static| |48928|New|Enh|2010-03-17|An alternative solution to preloading classes when| |49161|New|Enh|2010-04-21|Unknown Publisher when installing tomcat 6.0.26 | |49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient | |49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding | |49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/| |49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu| |49939|New|Enh|2010-09-16|Expose a method via JMX which empties the webapp f| |49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c| |50285|New|Enh|2010-11-17|Standard HTTP and AJP connectors silently ignore a| |50288|New|Enh|2010-11-17|Uploading a war file that already exists should au| |50692|
Bug report for Tomcat 7 [2012/11/18]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to| |18500|New|Enh|2003-03-30|Host aliases to match by regular expression | |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr| |48550|Inf|Enh|2010-01-14|Update examples and default server.xml to use UTF-| |49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak| |49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al| |49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm| |49821|New|Enh|2010-08-25|Tomcat CLI| |50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou| |50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply| |50234|New|Enh|2010-11-08|JspC use servlet 3.0 features | |50504|New|Enh|2010-12-21|Allow setting query string character set trough re| |50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern| |51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class| |51294|Opn|Enh|2011-05-30|Since 7.0.12 do not work option unpackWARs=true fo| |51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to | |51463|New|Enh|2011-07-01|Tomcat.setBaseDir (package org.apache.catalina.st| |51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul| |51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs| |51526|New|Enh|2011-07-18|Process web application context config with embedd| |51587|New|Enh|2011-07-29|Implement status and uptime commands | |51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter | |52092|New|Enh|2011-10-26|Please make AsyncFileHandler and OneLineFormatter | |52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site| |52236|New|Enh|2011-11-23|Idea: support 'overlays' shaped like Maven overlay| |52323|New|Enh|2011-12-13|Cobertura test code coverage support for build.xml| |52381|New|Enh|2011-12-22|Please add OSGi metadata | |52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up| |52489|New|Enh|2012-01-19|Enhancement request for code signing of war files | |52558|New|Enh|2012-01-30|CometConnectionManagerValve is adding non-serializ| |52688|New|Enh|2012-02-16|Add ability to remove old access log files| |52751|Opn|Enh|2012-02-23|Optimized configuration of the system info display| |52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s| |53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota| |53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr| |53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf| |53469|Inf|Nor|2012-06-26|possible bug in Response.normalize(CharChunk cc) | |53492|New|Enh|2012-07-01|Make JspC shell multithreaded | |53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from | |53602|New|Enh|2012-07-25|Support for HTTP status code 451 | |53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l| |53665|New|Enh|2012-08-06|Minor JNDI Howto document enhancement concerning m| |53776|New|Enh|2012-08-24|Multitenancy support for JDBCRealm| |53777|New|Enh|2012-08-24|Ability to bundle JAAS Configuration in Webappp | |53869|Inf|Enh|2012-09-13|Performance tuning solution to resolve too many ca| |54013|
Bug report for Taglibs [2012/11/18]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | +-+---+---+--+--+ | Total5 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Connectors [2012/11/18]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|Inf|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |46337|New|Nor|2008-12-04|real worker name is wrong | |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c| |52334|New|Maj|2011-12-14|recover_time is not properly used | |52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus| |52651|New|Nor|2012-02-13|JKSHMFile size limitation | |53324|Opn|Nor|2012-05-30|Starting with mod_jk 1.2.35 I cannot modify worker| |53542|New|Min|2012-07-13|Spelling mistake on 503 service unavailable page | |53762|New|Nor|2012-08-22|JK status manager: mass nodes handling doesn't wor| |53883|New|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe on the p| |53977|New|Maj|2012-10-07|32bits isapi connector cannot work in wow64 mode | |54027|New|Cri|2012-10-18|isapi send request to outside address instead of i| |54112|Opn|Blk|2012-11-07|ISAPI redirector not working when IIS recycles| |54117|New|Maj|2012-11-08|access violation exception in isapi_redirect.dll | +-+---+---+--+--+ | Total 47 bugs | +---+ - To unsubscribe
Bug report for Tomcat Modules [2012/11/18]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen| |51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho| |51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods | |52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o| |53088|Opn|Min|2012-04-17|Give PoolCleaner TimerTask a better name | |53198|New|Cri|2012-05-07|'driverClassName' Data Source Property Being Manda| |53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe| |53200|New|Enh|2012-05-07|Be able to use SlowQueryReport without reporting f| |53565|New|Min|2012-07-18|deprecated| |53770|New|Enh|2012-08-23|tomcat-pool: always log validation query syntax er| |53853|New|Nor|2012-09-11|Can tomcat-jdbc consider Thread#getContextClassLoa| |53905|New|Nor|2012-09-19|Connection pool not reusing connections. | |53968|New|Nor|2012-10-04|Database password is exposed via JMX in getDbPrope| |54116|New|Cri|2012-11-07|Deadlocks with mysql driver | |54150|New|Nor|2012-11-15|SlowQueryReportJmx mbean deregistration failure du| +-+---+---+--+--+ | Total 20 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Native [2012/11/18]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |45392|New|Nor|2008-07-14|No OCSP support for client SSL verification | |46179|Opn|Maj|2008-11-10|apr ssl client authentication | |48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |51655|New|Nor|2011-08-12|Index page does not say what native does | |51813|New|Cri|2011-09-14|Tomcat randomly crashes with [libtcnative-1.so.1+0| |52153|New|Maj|2011-11-08|periodic JVM crash (access violation) on buffer fl| |52231|New|Nor|2011-11-23|Ant Tasks need to reflect changes in manager comma| |52319|New|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da] sig| |52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i| |52856|New|Maj|2012-03-08|High CPU load when the underlying socket error in | |53110|New|Cri|2012-04-20|Access Violation Error while creating SHM | |53605|New|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash | |53847|Inf|Nor|2012-09-10|High CPU usage in tomcat native 1.22+ | |53937|New|Reg|2012-09-26|Double call to apr_pool_destroy() if OCSP checking| |53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration| |53952|New|Nor|2012-10-02|Add support for TLS 1.1 and 1.2 | |54064|New|Nor|2012-10-29|tomcat native randomly very slow with high CPU usa| |54085|New|Nor|2012-11-01|ssl_socket_recv sometimes loops infinitely with no| +-+---+---+--+--+ | Total 19 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
