Re: svn commit: r1405980 - /tomcat/maven-plugin/trunk/init-git-svn.sh

2012-11-08 Thread Olivier Lamy
apologize for delayed response (I'm on vacations :-) )
So I have added a "how to contribute" page see
http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/how-to-contribute.html



2012/11/6 Konstantin Kolinko :
> It would be better to add some comment at the top of the script,  describing
> - what it is needed for  (whether it initializes "git", "svn" or "git-svn"),
> - how often it has to be run ("once"? Though maybe more often if the
> authors file is updated).
>
> Or maybe just mention that the file is described elsewhere, or follows
> some procedure described elsewhere.
>
> It may be worth adding the AL header (though some say that trivial
> files do not need it).
>
> Best regards,
> Konstantin Kolinko
>
> 2012/11/6  :
>> Author: olamy
>> Date: Mon Nov  5 21:59:43 2012
>> New Revision: 1405980
>>
>> URL: http://svn.apache.org/viewvc?rev=1405980&view=rev
>> Log:
>> add init-git-svn.sh script to ease git svn setup
>>
>> Added:
>> tomcat/maven-plugin/trunk/init-git-svn.sh   (with props)
>>
>> Added: tomcat/maven-plugin/trunk/init-git-svn.sh
>> URL: 
>> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/init-git-svn.sh?rev=1405980&view=auto
>> ==
>> --- tomcat/maven-plugin/trunk/init-git-svn.sh (added)
>> +++ tomcat/maven-plugin/trunk/init-git-svn.sh Mon Nov  5 21:59:43 2012
>> @@ -0,0 +1,4 @@
>> +cd .git;wget http://git.apache.org/authors.txt; cd ..
>> +git config svn.authorsfile ".git/authors.txt"
>> +git svn init --prefix=origin/ --tags=tags --trunk=trunk --branches=branches 
>> https://svn.apache.org/repos/asf/tomcat/maven-plugin/
>> +git svn rebase
>>
>> Propchange: tomcat/maven-plugin/trunk/init-git-svn.sh
>> --
>> svn:eol-style = native
>>
>> Propchange: tomcat/maven-plugin/trunk/init-git-svn.sh
>> --
>> svn:executable = *
>>
>> Propchange: tomcat/maven-plugin/trunk/init-git-svn.sh
>> --
>> svn:keywords = Author Date Id Revision
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54117] access violation exception in isapi_redirect.dll

2012-11-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54117

--- Comment #6 from Mladen Turk  ---
Created attachment 29571
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29571&action=edit
iis 1.2.38-dev

Try with this file, I added a patch that should at least trace the problem for
the given crash dump. It zeroes out the header value pointers in case something
invalid comes in.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Using comments.apache.org for our live docs

2012-11-08 Thread Tim Funk
Nice. +1

-Tim

On Wed, Nov 7, 2012 at 5:31 PM, Rainer Jung  wrote:
 


> I prepared a simple demo at:
>
> http://people.apache.org/~**rjung/tomcat-docs-comments/**tomcat-8.0-docs/
>
> It would be nice if you would have a look and we would discuss, whether we
> find it useful or not. The patch for build.xml and the xsl that I applied
> to build the comment enabled docs can be found at
>
> http://people.apache.org/~**rjung/patches/tc-trunk-**comments.patch
>
>


[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2012-11-08 Thread Gump
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-taglibs-standard has an issue affecting its community 
integration.
This issue affects 2 projects,
 and has been outstanding for 171 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-taglibs-standard :  Standard Taglib
- tomcat-taglibs-standard-install :  JSP Taglibs


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Optional dependency httpunit failed with reason build failed
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
Work ended in a state of : Failed
Elapsed: 21 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml 
install 
[Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
M2_HOME: /opt/maven2
-
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Nothing to compile - all classes are up to date
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] No sources to compile
[INFO] [surefire:test {execution: default-test}]
[INFO] Tests are skipped.
[INFO] [bundle:bundle {execution: default-bundle}]
[INFO] [install:install {execution: default-install}]
[INFO] Installing 
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/target/taglibs-standard-spec-1.2-SNAPSHOT.jar
 to 
/srv/gump/public/workspace/mvnlocalrepo/shared/org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] [bundle:install {execution: default-install}]
[INFO] Parsing 
file:/srv/gump/public/workspace/mvnlocalrepo/shared/repository.xml
[INFO] Installing 
org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO] 
[INFO] Building JSTL Implementation
[INFO]task-segment: [install]
[INFO] 
[INFO] [remote-resources:process {execution: default}]
[INFO] snapshot org.apache.taglibs:taglibs-standard-spec:1.2-SNAPSHOT: checking 
for updates from apache.snapshots
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 96 source files to 
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/classes
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
 error: DataSourceWrapper is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource
[INFO] 1 error
[INFO] -
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
 error: DataSourceWrapper is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource

[INFO] 
[INFO] For more information, run Maven with the -e switch
[INFO] --

Re: Using comments.apache.org for our live docs

2012-11-08 Thread Pid
On 07/11/2012 22:31, Rainer Jung wrote:
> Cross posting intentionally, because our long time users list supporters
> might want to comment as well.
> 
> A few months ago a new Web Server committer, Daniel Gruno, suggested to
> use a commenting system as part of the online documentation. He wanted
> to include the disqus system. Some of his fellow committers were not
> very glad with using an external system for the users comments and he
> sat down and wrote an ASF commenting system. It is now running as an ASF
> service under comments.apache.org.
> 
> It allows users to add comments to documentation pages. Comments without
> URLs and HTML tags are going live immediately without moderation, the
> other ones need moderation first.
> 
> We are using it in the web server project since a few months and we
> observe close to no spam. Comment activity isn't to high, about 1
> comments per day. Some of those are not actually docs comments and they
> are responded by referring the users to the users list. Some of them are
> really useful because they help to clarify and improve documentation. In
> the meantime, the trafficserver project also uses the feature.
> 
> The comments are not meant to stay forever. Important content should be
> integrated into the docs.
> 
> Technically the commenting is done by adding a few lines of html and
> inline JavaScript to each page, which then calls comments.apache.org.
> For the Tomcat docs this can be done by adding those items to the XSL
> stylesheet used to generate the HTML pages.
> 
> I prepared a simple demo at:
> 
> http://people.apache.org/~rjung/tomcat-docs-comments/tomcat-8.0-docs/

I like it.  :)


p


> It would be nice if you would have a look and we would discuss, whether
> we find it useful or not. The patch for build.xml and the xsl that I
> applied to build the comment enabled docs can be found at
> 
> http://people.apache.org/~rjung/patches/tc-trunk-comments.patch
> 
> A final version would include a reference to tomcat.apache.org instead
> of people.apache.org/... The JavaScript checks the host header in order
> to disable the feature if the docs are running on a different server,
> e.g. inside a localhost Tomcat etc.
> 
> Regards,
> 
> Rainer
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-- 

[key:62590808]



signature.asc
Description: OpenPGP digital signature


Re: Using comments.apache.org for our live docs

2012-11-08 Thread Konstantin Kolinko
2012/11/8 Rainer Jung :
> Cross posting intentionally, because our long time users list supporters
> might want to comment as well.
>
> A few months ago a new Web Server committer, Daniel Gruno, suggested to use
> a commenting system as part of the online documentation. He wanted to
> include the disqus system. Some of his fellow committers were not very glad
> with using an external system for the users comments and he sat down and
> wrote an ASF commenting system. It is now running as an ASF service under
> comments.apache.org.
>
> It allows users to add comments to documentation pages. Comments without
> URLs and HTML tags are going live immediately without moderation, the other
> ones need moderation first.
>
> We are using it in the web server project since a few months and we observe
> close to no spam. Comment activity isn't to high, about 1 comments per day.
> Some of those are not actually docs comments and they are responded by
> referring the users to the users list. Some of them are really useful
> because they help to clarify and improve documentation. In the meantime, the
> trafficserver project also uses the feature.
>
> The comments are not meant to stay forever. Important content should be
> integrated into the docs.
>
> Technically the commenting is done by adding a few lines of html and inline
> JavaScript to each page, which then calls comments.apache.org. For the
> Tomcat docs this can be done by adding those items to the XSL stylesheet
> used to generate the HTML pages.
>
> I prepared a simple demo at:
>
> http://people.apache.org/~rjung/tomcat-docs-comments/tomcat-8.0-docs/
>
> It would be nice if you would have a look and we would discuss, whether we
> find it useful or not. The patch for build.xml and the xsl that I applied to
> build the comment enabled docs can be found at
>
> http://people.apache.org/~rjung/patches/tc-trunk-comments.patch
>
> A final version would include a reference to tomcat.apache.org instead of
> people.apache.org/... The JavaScript checks the host header in order to
> disable the feature if the docs are running on a different server, e.g.
> inside a localhost Tomcat etc.
>

Nice.

Several notes:

> A final version would include a reference to tomcat.apache.org

1. I think it needs to also allow tomcat.[eu|us].apache.org mirrors
and ci.apache.org where nightly builds of documentation are published.

2. I think that the comments should be be hidden when the document is
being printed.

3. Regarding the "Comments" section header and notice

I think it would be better
a) to have this section more distinct from the rest of the page
(formatted as something "external" to the page itself), and

b) to write proper introduction to the comments feature somewhere one
(formatted as a proper chapter/section of the documentation),
e,g, in the "Introduction" chapter, or maybe on the main tomcat.apache.org site.

The short notice section can have a link to this introduction.


Regarding the notice section, or rather the introduction to the
feature if we write one,
I would like to see the following:
1) Maybe do not mention the IRC channel.
2) Maybe mention how the comments are used. (Copyrights, AL)
3) Maybe mention who sees the comments (Those who subscribe to receive
them. They are not forwarded to the public mailing list).

Looking at httpd.a.o,
- the comments section header there spans the whole page width.
- the "Available Languages" line is above it.
- the "notice" is distinct from the rest of text by using a red border
- documentation and comments style is more consistent. They use the same font


4. Looking at httpd.a.o, I noticed a nice feature:
http://httpd.apache.org/docs/2.2/configuring.html
http://httpd.apache.org/docs/2.4/configuring.html

The "2.2" page has comments, the "2.4" does not. The following footer
is added to the "2.4" page:
"The 2.2 branch of the documentation has comments available for this
page. Click here to view them."


5. It does not work well when I browse the main site through https.

It works, but most of the links back and forth redirect to the http
version of it.
Examples:
a) The " Click here to view them." link mentioned above
b) The "View" link on a comment in the list of comments on comments.apache.org


6. It is not clear what is lifecycle of a comment.

I see that when I log in then there is a link above each comment that
allows to mark it as "Resolved". When (and who) is removing resolved
comments?
E.g. someone is supposed to do a manual sweep once the next minor
Tomcat version is released and its updated documentation is published?
The dashboard GUI is not very friendly for such a task.

Some message boards have a feature where a comment can be marked to
auto-disappear after certain time (e.g. several days).



Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1405980 - /tomcat/maven-plugin/trunk/init-git-svn.sh

2012-11-08 Thread Konstantin Kolinko
2012/11/8 Olivier Lamy :
> apologize for delayed response (I'm on vacations :-) )
> So I have added a "how to contribute" page see
> http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/how-to-contribute.html
>

OK. I have seen your commits.

Best regards,
Konstantin Kolinko

>
>
> 2012/11/6 Konstantin Kolinko :
>> It would be better to add some comment at the top of the script,  describing
>> - what it is needed for  (whether it initializes "git", "svn" or "git-svn"),
>> - how often it has to be run ("once"? Though maybe more often if the
>> authors file is updated).
>>
>> Or maybe just mention that the file is described elsewhere, or follows
>> some procedure described elsewhere.
>>
>> It may be worth adding the AL header (though some say that trivial
>> files do not need it).
>>
>> Best regards,
>> Konstantin Kolinko
>>
>> 2012/11/6  :
>>> Author: olamy
>>> Date: Mon Nov  5 21:59:43 2012
>>> New Revision: 1405980
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1405980&view=rev
>>> Log:
>>> add init-git-svn.sh script to ease git svn setup
>>>
>>> Added:
>>> tomcat/maven-plugin/trunk/init-git-svn.sh   (with props)
>>>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54117] access violation exception in isapi_redirect.dll

2012-11-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54117

--- Comment #7 from Werner  ---
Changed the message buffer sizes to 65536 (we move application to new servers
in the past week - had same issue on previous servers where we did change the
message buffer size to 65536, without success).

Debug log kills performance, had it on briefly to get:

Number of headers is = 4
Header[0] [Set-Cookie] = [JSESSIONID...
Header[1] [Cache-Control] = [No-Cach...
Header[2] [Content-Type] = [text/htm...
Header[3] [Content-Length] = [21837]

Number of headers is = 5
Header[0] [Accept-Ranges] = [bytes]
Header[1] [ETag] = [W/"13968-1352262
Header[2] [Last-Modified] = [Wed, 07...
Header[3] [Content-Type] = [text/jav...
Header[4] [Content-Length] = [13968]

Number of headers is = 3
Header[0] [Cache-Control] = [No-Cach...
Header[1] [Content-Type] = [text/htm...
Header[2] [Content-Length] = [24471]

Is it worth getting this data from our UAT environment (where we have not had
these crashes)?

Have deployed 1.2.38-dev (does this require log_level=trace - as mentioned it
killed performance?), will attached results after next crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54117] access violation exception in isapi_redirect.dll

2012-11-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54117

--- Comment #8 from Werner  ---
Created attachment 29574
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29574&action=edit
Screen shot of Visual Studio debug session

Not sure whether it's usefull but attached screen shots of debug session of
existing crash dumps in Visual Studio.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54121] New: add a option to disable checkThreadLocalMapForLeaks

2012-11-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54121

  Priority: P2
Bug ID: 54121
  Assignee: dev@tomcat.apache.org
   Summary: add a option to disable checkThreadLocalMapForLeaks
  Severity: critical
Classification: Unclassified
  Reporter: zhouyanm...@gmail.com
  Hardware: PC
Status: NEW
   Version: unspecified
 Component: Catalina
   Product: Tomcat 7

in most use case,tomcat was running for just one webapp and disabled reloadable
option,so if it's unnecessary to wait clearReferences(),System.exit() is OK.
in my case.I have a autodeploy shell to shutdown tomcat and unzip wars then
startup tomcat,tomcat have to took long time when shutdown,sometime it's halt
and not terminate the process ,I need to kill the process,I hope tomcat provide
a way to disable such feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org