Bug report for Taglibs [2012/10/14]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | +-+---+---+--+--+ | Total5 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 6 [2012/10/14]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43400|New|Enh|2007-09-14|enum support for tag libs | |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag | |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context.xml does not update do| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46727|New|Enh|2009-02-17|DefaultServlet - serving multiple encodings | |46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch| |47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho| |47242|New|Enh|2009-05-22|request for AJP command line client | |47281|New|Enh|2009-05-28|Efficiency of the JDBCStore | |47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session| |47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath| |47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked| |47919|New|Enh|2009-09-30|Log Tomcat & Java environment variables in additio| |48358|Opn|Enh|2009-12-09|JSP-unloading reloaded| |48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.| |48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b| |48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe| |48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr| |48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems| |48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static| |48928|New|Enh|2010-03-17|An alternative solution to preloading classes when| |49161|New|Enh|2010-04-21|Unknown Publisher when installing tomcat 6.0.26 | |49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient | |49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding | |49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/| |49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu| |49939|New|Enh|2010-09-16|Expose a method via JMX which empties the webapp f| |49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c| |50285|New|Enh|2010-11-17|Standard HTTP and AJP connectors silently ignore a| |50288|
Bug report for Tomcat Connectors [2012/10/14]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|Inf|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |46337|New|Nor|2008-12-04|real worker name is wrong | |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c| |52334|New|Maj|2011-12-14|recover_time is not properly used | |52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus| |52651|New|Nor|2012-02-13|JKSHMFile size limitation | |53324|Opn|Nor|2012-05-30|Starting with mod_jk 1.2.35 I cannot modify worker| |53542|New|Min|2012-07-13|Spelling mistake on 503 service unavailable page | |53762|New|Nor|2012-08-22|JK status manager: mass nodes handling doesn't wor| |53883|New|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe on the p| |53977|New|Maj|2012-10-07|32bits isapi connector cannot work in wow64 mode | +-+---+---+--+--+ | Total 44 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 7 [2012/10/14]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to| |18500|New|Enh|2003-03-30|Host aliases to match by regular expression | |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr| |48550|Inf|Enh|2010-01-14|Update examples and default server.xml to use UTF-| |49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak| |49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al| |49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm| |49821|New|Enh|2010-08-25|Tomcat CLI| |50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou| |50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply| |50234|New|Enh|2010-11-08|JspC use servlet 3.0 features | |50504|New|Enh|2010-12-21|Allow setting query string character set trough re| |50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern| |51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class| |51294|Opn|Enh|2011-05-30|Since 7.0.12 do not work option unpackWARs=true fo| |51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to | |51463|New|Enh|2011-07-01|Tomcat.setBaseDir (package org.apache.catalina.st| |51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul| |51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs| |51526|New|Enh|2011-07-18|Process web application context config with embedd| |51587|New|Enh|2011-07-29|Implement status and uptime commands | |51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter | |52092|New|Enh|2011-10-26|Please make AsyncFileHandler and OneLineFormatter | |52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site| |52236|New|Enh|2011-11-23|Idea: support 'overlays' shaped like Maven overlay| |52323|New|Enh|2011-12-13|Cobertura test code coverage support for build.xml| |52381|New|Enh|2011-12-22|Please add OSGi metadata | |52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up| |52489|New|Enh|2012-01-19|Enhancement request for code signing of war files | |52558|New|Enh|2012-01-30|CometConnectionManagerValve is adding non-serializ| |52688|New|Enh|2012-02-16|Add ability to remove old access log files| |52751|Opn|Enh|2012-02-23|Optimized configuration of the system info display| |52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s| |53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota| |53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr| |53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf| |53469|Inf|Nor|2012-06-26|possible bug in Response.normalize(CharChunk cc) | |53492|New|Enh|2012-07-01|Make JspC shell multithreaded | |53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from | |53602|New|Enh|2012-07-25|Support for HTTP status code 451 | |53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l| |53665|New|Enh|2012-08-06|Minor JNDI Howto document enhancement concerning m| |53776|New|Enh|2012-08-24|Multitenancy support for JDBCRealm| |53777|New|Enh|2012-08-24|Ability to bundle JAAS Configuration in Webappp | |53867|New|Enh|2012-09-13|Performance tuning solution for PageContextImpl.Xm| |53869|
Bug report for Tomcat Modules [2012/10/14]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen| |51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho| |51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods | |52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o| |53088|Opn|Min|2012-04-17|Give PoolCleaner TimerTask a better name | |53198|New|Cri|2012-05-07|'driverClassName' Data Source Property Being Manda| |53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe| |53200|New|Enh|2012-05-07|Be able to use SlowQueryReport without reporting f| |53565|New|Min|2012-07-18|deprecated| |53770|New|Enh|2012-08-23|tomcat-pool: always log validation query syntax er| |53853|New|Nor|2012-09-11|Can tomcat-jdbc consider Thread#getContextClassLoa| |53905|New|Nor|2012-09-19|Connection pool not reusing connections. | |53968|New|Nor|2012-10-04|Database password is exposed via JMX in getDbPrope| +-+---+---+--+--+ | Total 18 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Native [2012/10/14]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |45392|New|Nor|2008-07-14|No OCSP support for client SSL verification | |46179|Opn|Maj|2008-11-10|apr ssl client authentication | |48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |51655|New|Nor|2011-08-12|Index page does not say what native does | |51813|New|Cri|2011-09-14|Tomcat randomly crashes with [libtcnative-1.so.1+0| |52153|New|Maj|2011-11-08|periodic JVM crash (access violation) on buffer fl| |52231|New|Nor|2011-11-23|Ant Tasks need to reflect changes in manager comma| |52319|New|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da] sig| |52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i| |52856|New|Maj|2012-03-08|High CPU load when the underlying socket error in | |53110|New|Cri|2012-04-20|Access Violation Error while creating SHM | |53605|New|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash | |53847|Inf|Nor|2012-09-10|High CPU usage in tomcat native 1.22+ | |53937|New|Reg|2012-09-26|Double call to apr_pool_destroy() if OCSP checking| |53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration| |53952|New|Nor|2012-10-02|Add support for TLS 1.1 and 1.2 | +-+---+---+--+--+ | Total 17 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1398089 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: Code.java CodeException.java InnerClass.java InnerClasses.java Utility.java
Author: markt Date: Sun Oct 14 14:26:18 2012 New Revision: 1398089 URL: http://svn.apache.org/viewvc?rev=1398089&view=rev Log: Start to strip out the unused classes Removed: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/CodeException.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/InnerClass.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Code.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/InnerClasses.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Utility.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Code.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Code.java?rev=1398089&r1=1398088&r2=1398089&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Code.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Code.java Sun Oct 14 14:26:18 2012 @@ -35,7 +35,6 @@ import java.io.IOException; * @version $Id$ * @author mailto:m.d...@gmx.de";>M. Dahm * @see Attribute - * @see CodeException * @see LineNumberTable * @see LocalVariableTable */ @@ -45,7 +44,6 @@ public final class Code extends Attribut private int code_length; // Length of code in bytes private byte[] code; // Actual byte code private int exception_table_length; -private CodeException[] exception_table; // Table of handled exceptions private int attributes_count; // Attributes of code: LineNumber private Attribute[] attributes; // or LocalVariable @@ -59,8 +57,8 @@ public final class Code extends Attribut Code(int name_index, int length, DataInputStream file, ConstantPool constant_pool) throws IOException { // Initialize with some default values which will be overwritten later -this(name_index, length, (byte[]) null, -(CodeException[]) null, (Attribute[]) null, constant_pool); +this(name_index, length, (byte[]) null, (Attribute[]) null, +constant_pool); file.readUnsignedShort(); // Unused max_stack file.readUnsignedShort(); // Unused max_locals code_length = file.readInt(); @@ -70,9 +68,8 @@ public final class Code extends Attribut * handler is active, i.e., a try { ... } catch() block. */ exception_table_length = file.readUnsignedShort(); -exception_table = new CodeException[exception_table_length]; for (int i = 0; i < exception_table_length; i++) { -exception_table[i] = new CodeException(file); +Utility.swallowCodeException(file); } /* Read all attributes, currently `LineNumberTable' and * `LocalVariableTable' @@ -94,15 +91,13 @@ public final class Code extends Attribut * @param name_index Index pointing to the name Code * @param length Content length in bytes * @param code Actual byte code - * @param exception_table Table of handled exceptions * @param attributes Attributes of code: LineNumber or LocalVariable * @param constant_pool Array of constants */ public Code(int name_index, int length, byte[] code, -CodeException[] exception_table, Attribute[] attributes, ConstantPool constant_pool) { +Attribute[] attributes, ConstantPool constant_pool) { super(name_index, length, constant_pool); setCode(code); -setExceptionTable(exception_table); setAttributes(attributes); // Overwrites length! } @@ -151,14 +146,4 @@ public final class Code extends Attribut code_length = (code == null) ? 0 : code.length; length = calculateLength(); // Adjust length } - - -/** - * @param exception_table exception table - */ -public final void setExceptionTable( CodeException[] exception_table ) { -this.exception_table = exception_table; -exception_table_length = (exception_table == null) ? 0 : exception_table.length; -length = calculateLength(); // Adjust length -} } Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/InnerClasses.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/InnerClasses.java?rev=1398089&r1=1398088&r2=1398089&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/InnerClasses.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/InnerClasses.java Sun Oct 14 14:26:18 2012 @@ -33,24 +33,10 @@ import java.io.IOException; public final class InnerClasses extends Attribute { private static final long serialVersionUID = 54179484605570305L; -private InnerClass[] inner_classes; private int number_of_classes; /** - * @param name_index Index
svn commit: r1398107 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: LineNumber.java LineNumberTable.java LocalVariable.java LocalVariableTable.java LocalVariableTypeTable.java Utility.
Author: markt Date: Sun Oct 14 17:59:38 2012 New Revision: 1398107 URL: http://svn.apache.org/viewvc?rev=1398107&view=rev Log: More unused classes Removed: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LineNumber.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariable.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LineNumberTable.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTable.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTypeTable.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Utility.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LineNumberTable.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LineNumberTable.java?rev=1398107&r1=1398106&r2=1398107&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LineNumberTable.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LineNumberTable.java Sun Oct 14 17:59:38 2012 @@ -28,26 +28,10 @@ import java.io.IOException; * @version $Id$ * @author mailto:m.d...@gmx.de";>M. Dahm * @see Code - * @see LineNumber */ public final class LineNumberTable extends Attribute { private static final long serialVersionUID = 6585122636118666124L; -private int line_number_table_length; -private LineNumber[] line_number_table; // Table of line/numbers pairs - - -/* - * @param name_index Index of name - * @param length Content length in bytes - * @param line_number_table Table of line/numbers pairs - * @param constant_pool Array of constants - */ -public LineNumberTable(int name_index, int length, LineNumber[] line_number_table, -ConstantPool constant_pool) { -super(name_index, length, constant_pool); -setLineNumberTable(line_number_table); -} /** @@ -60,20 +44,10 @@ public final class LineNumberTable exten */ LineNumberTable(int name_index, int length, DataInputStream file, ConstantPool constant_pool) throws IOException { -this(name_index, length, (LineNumber[]) null, constant_pool); -line_number_table_length = (file.readUnsignedShort()); -line_number_table = new LineNumber[line_number_table_length]; +super(name_index, length, constant_pool); +int line_number_table_length = (file.readUnsignedShort()); for (int i = 0; i < line_number_table_length; i++) { -line_number_table[i] = new LineNumber(file); +Utility.swallowLineNumber(file); } } - - -/** - * @param line_number_table the line number entries for this table - */ -public final void setLineNumberTable( LineNumber[] line_number_table ) { -this.line_number_table = line_number_table; -line_number_table_length = (line_number_table == null) ? 0 : line_number_table.length; -} } Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTable.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTable.java?rev=1398107&r1=1398106&r2=1398107&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTable.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTable.java Sun Oct 14 17:59:38 2012 @@ -27,26 +27,10 @@ import java.io.IOException; * @version $Id$ * @author mailto:m.d...@gmx.de";>M. Dahm * @see Code - * @see LocalVariable */ public class LocalVariableTable extends Attribute { private static final long serialVersionUID = -3904314258294133920L; -private int local_variable_table_length; // Table of local -private LocalVariable[] local_variable_table; // variables - - -/** - * @param name_index Index in constant pool to `LocalVariableTable' - * @param length Content length in bytes - * @param local_variable_table Table of local variables - * @param constant_pool Array of constants - */ -public LocalVariableTable(int name_index, int length, LocalVariable[] local_variable_table, -ConstantPool constant_pool) { -super(name_index, length, constant_pool); -setLocalVariableTable(local_variable_table); -} /** @@ -59,19 +43,10 @@ public class LocalVariableTable extends */ LocalVariableTable(int name_index, int length, DataInputStream file, ConstantPool constant_pool) throws IOException { -this(name_index, length, (LocalVariable[]) null, constant_pool); -local_variable_table_length = (file.readUnsignedShort()); -local_variable_table = new LocalVariable[local_variable_table_length]; +super
svn commit: r1398109 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/
Author: markt Date: Sun Oct 14 18:11:49 2012 New Revision: 1398109 URL: http://svn.apache.org/viewvc?rev=1398109&view=rev Log: Remove unused dump() methods Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationElementValue.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationEntry.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ArrayElementValue.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ClassElementValue.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ElementValue.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ElementValuePair.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/EnumElementValue.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/SimpleElementValue.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationElementValue.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationElementValue.java?rev=1398109&r1=1398108&r2=1398109&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationElementValue.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationElementValue.java Sun Oct 14 18:11:49 2012 @@ -17,9 +17,6 @@ */ package org.apache.tomcat.util.bcel.classfile; -import java.io.DataOutputStream; -import java.io.IOException; - public class AnnotationElementValue extends ElementValue { // For annotation element values, this is the annotation @@ -36,13 +33,6 @@ public class AnnotationElementValue exte } @Override -public void dump(DataOutputStream dos) throws IOException -{ -dos.writeByte(type); // u1 type of value (ANNOTATION == '@') -annotationEntry.dump(dos); -} - -@Override public String stringifyValue() { return annotationEntry.toString(); Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationEntry.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationEntry.java?rev=1398109&r1=1398108&r2=1398109&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationEntry.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationEntry.java Sun Oct 14 18:11:49 2012 @@ -18,7 +18,6 @@ package org.apache.tomcat.util.bcel.classfile; import java.io.DataInputStream; -import java.io.DataOutputStream; import java.io.IOException; import java.util.ArrayList; import java.util.List; @@ -79,14 +78,4 @@ public class AnnotationEntry implements // TODO return List return element_value_pairs.toArray(new ElementValuePair[element_value_pairs.size()]); } - -public void dump(DataOutputStream dos) throws IOException { -dos.writeShort(type_index); // u2 index of type name in cpool -dos.writeShort(element_value_pairs.size()); // u2 element_value pair -// count -for (int i = 0; i < element_value_pairs.size(); i++) { -final ElementValuePair envp = element_value_pairs.get(i); -envp.dump(dos); -} -} } Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ArrayElementValue.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ArrayElementValue.java?rev=1398109&r1=1398108&r2=1398109&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ArrayElementValue.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ArrayElementValue.java Sun Oct 14 18:11:49 2012 @@ -17,9 +17,6 @@ */ package org.apache.tomcat.util.bcel.classfile; -import java.io.DataOutputStream; -import java.io.IOException; - public class ArrayElementValue extends ElementValue { // For array types, this is the array @@ -35,17 +32,6 @@ public class ArrayElementValue extends E } @Override -public void dump(DataOutputStream dos) throws IOException -{ -dos.writeByte(type); // u1 type of value (ARRAY == '[') -dos.writeShort(evalues.length); -for (int i = 0; i < evalues.length; i++) -{ -evalues[i].dump(dos); -} -} - -@Override public String stringifyValue() { StringBuilder sb = new StringBuilder(); Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ClassElementValue.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ClassElementValue.java?rev=1398109&r1=1398108&r2=1398109&view=diff == --- tomcat/trunk/java/org/apache/tomcat/u
svn commit: r1398110 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: ElementValue.java EnumElementValue.java
Author: markt Date: Sun Oct 14 18:19:33 2012 New Revision: 1398110 URL: http://svn.apache.org/viewvc?rev=1398110&view=rev Log: Unused field identified by Eclipse Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ElementValue.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/EnumElementValue.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ElementValue.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ElementValue.java?rev=1398110&r1=1398109&r2=1398110&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ElementValue.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ElementValue.java Sun Oct 14 18:19:33 2012 @@ -101,7 +101,8 @@ public abstract class ElementValue return new SimpleElementValue(STRING, dis.readUnsignedShort(), cpool); case 'e': // Enum constant -return new EnumElementValue(ENUM_CONSTANT, dis.readUnsignedShort(), +dis.readUnsignedShort();// Unused type_index +return new EnumElementValue(ENUM_CONSTANT, dis.readUnsignedShort(), cpool); case 'c': // Class return new ClassElementValue(CLASS, dis.readUnsignedShort(), cpool); Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/EnumElementValue.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/EnumElementValue.java?rev=1398110&r1=1398109&r2=1398110&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/EnumElementValue.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/EnumElementValue.java Sun Oct 14 18:19:33 2012 @@ -21,19 +21,14 @@ import org.apache.tomcat.util.bcel.Const public class EnumElementValue extends ElementValue { -// For enum types, these two indices point to the type and value -private int typeIdx; - private int valueIdx; -public EnumElementValue(int type, int typeIdx, int valueIdx, -ConstantPool cpool) +public EnumElementValue(int type, int valueIdx, ConstantPool cpool) { super(type, cpool); if (type != ENUM_CONSTANT) throw new RuntimeException( "Only element values of type enum can be built with this ctor - type specified: " + type); -this.typeIdx = typeIdx; this.valueIdx = valueIdx; } - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1398112 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: Attribute.java AttributeReader.java Unknown.java
Author: markt Date: Sun Oct 14 18:27:10 2012 New Revision: 1398112 URL: http://svn.apache.org/viewvc?rev=1398112&view=rev Log: Remove unused AttributeReader Removed: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AttributeReader.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Unknown.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java?rev=1398112&r1=1398111&r2=1398112&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java Sun Oct 14 18:27:10 2012 @@ -20,8 +20,6 @@ package org.apache.tomcat.util.bcel.clas import java.io.DataInputStream; import java.io.IOException; import java.io.Serializable; -import java.util.HashMap; -import java.util.Map; import org.apache.tomcat.util.bcel.Constants; @@ -65,8 +63,6 @@ public abstract class Attribute implemen this.constant_pool = constant_pool; } -private static final Map readers = new HashMap<>(); - /* * Class method reads one attribute from the input data stream. This method * must not be accessible from the outside. It is called by the Field and @@ -107,12 +103,6 @@ public abstract class Attribute implemen switch (tag) { case Constants.ATTR_UNKNOWN: -AttributeReader r = readers.get(name); -if (r != null) -{ -return r.createAttribute(name_index, length, file, -constant_pool); -} return new Unknown(name_index, length, file, constant_pool); case Constants.ATTR_CONSTANT_VALUE: return new ConstantValue(name_index, length, file, constant_pool); Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Unknown.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Unknown.java?rev=1398112&r1=1398111&r2=1398112&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Unknown.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Unknown.java Sun Oct 14 18:27:10 2012 @@ -37,7 +37,6 @@ import org.apache.tomcat.util.bcel.Const * * @version $Id$ * @see org.apache.tomcat.util.bcel.classfile.Attribute - * @see org.apache.tomcat.util.bcel.classfile.AttributeReader * @author mailto:m.d...@gmx.de";>M. Dahm */ public final class Unknown extends Attribute { - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53665] Minor JNDI Howto document enhancement concerning mail properties
https://issues.apache.org/bugzilla/show_bug.cgi?id=53665 --- Comment #1 from David Bullock --- I was about to file this one, and noticed I had been beaten to the punch. My description for the issue would have been: "Documentation of JavaMail JNDI resource factories fails to document the 'password' attribute". I was lucky to have found http://stackoverflow.com/questions/6372171/documentation-of-java-mail-api-configuration-for-jndi-in-tomcat or else I'd have been reading the source-code myself. It's great that when we get a javax.mail.Session via JNDI, Tomcat can arrange for it to have an administrator-configured javax.mail.Authenticator already. But you do need to: a) tell the administrator: i) what they're doing (causing the Session to issue Transports with Authenitcators already set); and ii) how to do it (using the 'password' attribute in combination with various JavaMail provider attributes) b) re-assure the coder that: i) Transport.send(aMessage) ... is right; and using ii) aTransport.sendMessage() ... is not *necessary*, because iii) the behaviour of Transport.send(Message), in calling aTransport.connect() is OK so long as the deployer knew his work. c) document who "wins" when the coder calls aTransport.connect(String,String,String) and aTransport.sendMessage(Message) in lieu of using Transport.send(Message)... BUT the deployer already set things up such that the Transport has an Authenticator. Who will prevail? (NB. This is an entirely legitimate use of the Transport, at least as far as the JavaMail FAQ is concerned: http://www.oracle.com/technetwork/java/faq-135477.html#send I'm not sure if the JavaEE spec says anything about it. (I hope it does, but hopes are not high, and I don't have time to hunt for it rght now). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org