Bug report for Tomcat 5 [2012/09/30]

2012-09-30 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|42181|Opn|Nor|2007-04-21|ArrayIndexOutOfBoundsException in parseChunkHeader|
|52579|New|Reg|2012-02-02|Tomcat5.5.35?Java1.5 cannot return proper value of|
|53050|New|Nor|2012-04-09|org.apache.catalina.session.ManagerBase has issues|
|53531|New|Trv|2012-07-11|ExpandWar.expand does not check the return value o|
+-+---+---+--+--+
| Total4 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat 7 [2012/09/30]

2012-09-30 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to|
|18500|New|Enh|2003-03-30|Host aliases to match by regular expression   |
|28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn  |
|40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes  |
|40881|Opn|Enh|2006-11-02|Unable to receive message through  TCP channel -> |
|41007|Opn|Enh|2006-11-20|Can't define customized 503 error page|
|43866|New|Enh|2007-11-14|add support for session attribute propagation with|
|43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing |
|44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr|
|48550|Inf|Enh|2010-01-14|Update examples and default server.xml to use UTF-|
|49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak|
|49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al|
|49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm|
|49821|New|Enh|2010-08-25|Tomcat CLI|
|50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou|
|50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply|
|50234|New|Enh|2010-11-08|JspC use servlet 3.0 features |
|50504|New|Enh|2010-12-21|Allow setting query string character set trough re|
|50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern|
|51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class|
|51294|Opn|Enh|2011-05-30|Since 7.0.12 do not work option unpackWARs=true fo|
|51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to |
|51463|New|Enh|2011-07-01|Tomcat.setBaseDir  (package org.apache.catalina.st|
|51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul|
|51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs|
|51526|New|Enh|2011-07-18|Process web application context config with embedd|
|51587|New|Enh|2011-07-29|Implement status and uptime commands  |
|51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter  |
|52092|New|Enh|2011-10-26|Please make AsyncFileHandler and OneLineFormatter |
|52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site|
|52236|New|Enh|2011-11-23|Idea: support 'overlays' shaped like Maven overlay|
|52323|New|Enh|2011-12-13|Cobertura test code coverage support for build.xml|
|52381|New|Enh|2011-12-22|Please add OSGi metadata  |
|52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up|
|52489|New|Enh|2012-01-19|Enhancement request for code signing of war files |
|52558|New|Enh|2012-01-30|CometConnectionManagerValve is adding non-serializ|
|52688|New|Enh|2012-02-16|Add ability to remove old access log files|
|52751|Opn|Enh|2012-02-23|Optimized configuration of the system info display|
|52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s|
|53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota|
|53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr|
|53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf|
|53469|Inf|Nor|2012-06-26|possible bug in Response.normalize(CharChunk cc)  |
|53492|New|Enh|2012-07-01|Make JspC shell multithreaded |
|53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from |
|53602|New|Enh|2012-07-25|Support for HTTP status code 451  |
|53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l|
|53665|New|Enh|2012-08-06|Minor JNDI Howto document enhancement concerning m|
|53776|New|Enh|2012-08-24|Multitenancy support for JDBCRealm|
|53777|New|Enh|2012-08-24|Ability to bundle JAAS Configuration in Webappp   |
|53854|New|Min|2012-09-11|DefaultServlet directory listings for aliased dire|
|53867|

Bug report for Tomcat 6 [2012/09/30]

2012-09-30 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat|
|41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific|
|43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant|
|43400|New|Enh|2007-09-14|enum support for tag libs |
|43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml   |
|43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor|
|43742|New|Enh|2007-10-30|.tag compiles  performed one at a time -- extremel|
|43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output |
|44199|New|Enh|2008-01-10|expose current backlog queue size |
|44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f|
|44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag   |
|44294|New|Enh|2008-01-25|Support for EL functions with varargs |
|44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam|
|44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt|
|44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin|
|45014|New|Enh|2008-05-15|Request and Response classes should have wrappers |
|45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets|
|45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete  |
|45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks|
|45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or |
|45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE|
|45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output|
|46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c|
|46263|New|Enh|2008-11-21|Tomcat reloading of context.xml does not update do|
|46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl|
|46350|New|Enh|2008-12-05|Maven repository should contain source bundles|
|46727|New|Enh|2009-02-17|DefaultServlet - serving multiple encodings   |
|46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch|
|47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho|
|47242|New|Enh|2009-05-22|request for AJP command line client   |
|47281|New|Enh|2009-05-28|Efficiency of the JDBCStore   |
|47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session|
|47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath|
|47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked|
|47919|New|Enh|2009-09-30|Log Tomcat & Java environment variables in additio|
|48358|Opn|Enh|2009-12-09|JSP-unloading reloaded|
|48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.|
|48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b|
|48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe|
|48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr|
|48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems|
|48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static|
|48928|New|Enh|2010-03-17|An alternative solution to preloading classes when|
|49161|New|Enh|2010-04-21|Unknown Publisher when installing tomcat 6.0.26   |
|49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient  |
|49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding  |
|49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/|
|49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu|
|49939|New|Enh|2010-09-16|Expose a method via JMX which empties the webapp f|
|49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c|
|50285|New|Enh|2010-11-17|Standard HTTP and AJP connectors silently ignore a|
|50288|

Bug report for Tomcat Connectors [2012/09/30]

2012-09-30 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo|
|35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName|
|43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn|
|43968|Inf|Enh|2007-11-26|[patch] support ipv6 with mod_jk  |
|44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan|
|44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s|
|44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 |
|44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc|
|44571|New|Enh|2008-03-10|Limits busy per worker to a threshold |
|45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff|
|45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so|
|46337|New|Nor|2008-12-04|real worker name is wrong |
|46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread |
|46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca|
|47327|New|Enh|2009-06-07|remote_user not logged in apache logfile  |
|47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err|
|47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_|
|47714|New|Cri|2009-08-20|Reponse mixed between users   |
|47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus|
|47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit|
|47840|Inf|Min|2009-09-14|A broken worker name is written in the log file.  |
|48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the|
|48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio|
|48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert|
|48513|New|Enh|2010-01-09|IIS Quick setup instructions  |
|48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker  |
|48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv|
|48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk |
|49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form|
|49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work|
|49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat |
|49469|New|Enh|2010-06-19|Workers status page has negative number of connect|
|49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. |
|49822|New|Enh|2010-08-25|Add hash lb worker method |
|49903|New|Enh|2010-09-09|Make workers file reloadable  |
|50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c|
|52334|New|Maj|2011-12-14|recover_time is not properly used |
|52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus|
|52651|New|Nor|2012-02-13|JKSHMFile size limitation |
|53324|Opn|Nor|2012-05-30|Starting with mod_jk 1.2.35 I cannot modify worker|
|53542|New|Min|2012-07-13|Spelling mistake on 503 service unavailable page  |
|53762|New|Nor|2012-08-22|JK status manager: mass nodes handling doesn't wor|
|53883|New|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe  on the p|
+-+---+---+--+--+
| Total   43 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Taglibs [2012/09/30]

2012-09-30 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field   |
|38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)|
|42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements   |
|46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l|
|48333|New|Enh|2009-12-02|TLD generator |
+-+---+---+--+--+
| Total5 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat Native [2012/09/30]

2012-09-30 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|45392|New|Nor|2008-07-14|No OCSP support for client SSL verification   |
|46179|Opn|Maj|2008-11-10|apr ssl client authentication |
|48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown|
|49038|Inf|Nor|2010-04-02|Crash in tcnative |
|51655|New|Nor|2011-08-12|Index page does not say what native does  |
|51813|New|Cri|2011-09-14|Tomcat randomly crashes with [libtcnative-1.so.1+0|
|52153|New|Maj|2011-11-08|periodic JVM crash (access violation) on buffer fl|
|52231|New|Nor|2011-11-23|Ant Tasks need to reflect changes in manager comma|
|52319|New|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da]  sig|
|52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i|
|52856|New|Maj|2012-03-08|High CPU load when the underlying socket error in |
|53110|New|Cri|2012-04-20|Access Violation Error while creating SHM |
|53605|New|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash   |
|53847|Inf|Nor|2012-09-10|High CPU usage in tomcat native 1.22+ |
|53937|New|Reg|2012-09-26|Double call to apr_pool_destroy() if OCSP checking|
|53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration|
+-+---+---+--+--+
| Total   16 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat Modules [2012/09/30]

2012-09-30 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers |
|48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite  |
|48861|New|Nor|2010-03-04|Files without AL headers  |
|49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean   |
|49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da|
|50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen|
|51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho|
|51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods   |
|52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o|
|53088|Opn|Min|2012-04-17|Give PoolCleaner TimerTask a better name  |
|53198|New|Cri|2012-05-07|'driverClassName' Data Source Property Being Manda|
|53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe|
|53200|New|Enh|2012-05-07|Be able to use SlowQueryReport without reporting f|
|53565|New|Min|2012-07-18|deprecated|
|53770|New|Enh|2012-08-23|tomcat-pool: always log validation query syntax er|
|53853|New|Nor|2012-09-11|Can tomcat-jdbc consider Thread#getContextClassLoa|
|53905|New|Nor|2012-09-19|Connection pool not reusing connections.  |
+-+---+---+--+--+
| Total   17 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2012-09-30 Thread Gump 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-taglibs-standard has an issue affecting its community 
integration.
This issue affects 2 projects,
 and has been outstanding for 105 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-taglibs-standard :  Standard Taglib
- tomcat-taglibs-standard-install :  JSP Taglibs


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Optional dependency httpunit failed with reason build failed
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
Work ended in a state of : Failed
Elapsed: 21 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml 
install 
[Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
M2_HOME: /opt/maven2
-
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Nothing to compile - all classes are up to date
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] No sources to compile
[INFO] [surefire:test {execution: default-test}]
[INFO] Tests are skipped.
[INFO] [bundle:bundle {execution: default-bundle}]
[INFO] [install:install {execution: default-install}]
[INFO] Installing 
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/target/taglibs-standard-spec-1.2-SNAPSHOT.jar
 to 
/srv/gump/public/workspace/mvnlocalrepo/shared/org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] [bundle:install {execution: default-install}]
[INFO] Parsing 
file:/srv/gump/public/workspace/mvnlocalrepo/shared/repository.xml
[INFO] Installing 
org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO] 
[INFO] Building JSTL Implementation
[INFO]task-segment: [install]
[INFO] 
[INFO] [remote-resources:process {execution: default}]
[INFO] snapshot org.apache.taglibs:taglibs-standard-spec:1.2-SNAPSHOT: checking 
for updates from apache.snapshots
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 96 source files to 
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/classes
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
 error: DataSourceWrapper is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource
[INFO] 1 error
[INFO] -
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
 error: DataSourceWrapper is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource

[INFO] 
[INFO] For more information, run Maven with the -e switch
[INFO] --

Re: Custom compression filters

2012-09-30 Thread Konstantin Kolinko 
2012/9/29 Florian Fray :
> Dear TC Devs,
>
> while looking around in TC 7 I've found no possibility to plug-in a custom 
> compression filter.
>
> So I've had a quick look at the code to find out that the gzip-handling is 
> coded into AbstractHttp11Processor.

Only HTTP protocol management is performed by AbstractHttp11Processor.
 The gzip support is just an org.apache.coyote.http11.OutputFilter.

> Though I could create a custom processor, I'd like to know whether there's 
> any interest in having the standard processors supporting custom compressions.
>

There might be an interest,
but until it is really requested by someone, and someone takes the
time to implement it (aka scratch their own itch), very little can be
done.  Do you care to explain what "custom" compressions do you need?
Can you propose a patch?

If you need help to understand Tomcat code / writing a patch, just ask
on this list.


2012/9/30 Jess Holle :
> It is quite possible to write a custom compression filter as a servlet
> filter that will work across multiple servlet engines.
>

+1.

There is a sample gzip filter in the examples webapp
(compressionFilters.CompressionFilter).

There exists a gzip filter in the Ehcache project.

It is likely that there are others as well.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53938] Silent Install

2012-09-30 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=53938

Konstantin Kolinko  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #2 from Konstantin Kolinko  ---
1. I think it will be counter-intuitive. You are proposing that the installer
program change its behaviour based on some hidden system state.

2. I do not see a merit in such feature.

3. If Tomcat uninstalls, the key should be removed from the registry. So you
would not be able to use this feature.

4. If you consider installing over already-installed Tomcat, see bug 51496.

5. You are wrong with the key name. The key name depends on parameters that are
chosen during installation. It is

"SOFTWARE\Apache Software
Foundation\Tomcat\@VERSION_MAJOR_MINOR@\$TomcatServiceName"

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53940] Added support for new CRL loading after expiration

2012-09-30 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=53940

Konstantin Kolinko  changed:

   What|Removed |Added

  Attachment #29426|0   |1
   is patch||
  Attachment #29426|application/octet-stream|text/plain
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Custom compression filters

2012-09-30 Thread Florian Fray 
Thanks for your reply, Konstantin and Jess.The main reason for adding this feature to the Container is the same as for all features provided by a Container:My applications should not deal with these details.Currently I'm looking at adding Googles Snappy to some servers.I could add filters to my applications, but if possible, I'd like to get around this, as I'd have to do it to a bunch of applications,partially running on the same Tomcat or JBoss instances.I'm currently thinking about which way to go.Patching Tomcat was not that hard and it was fun anyway.Maintaining a custom Tomcat codeline is something I'd like to avoid (I've already got a customized installation, but this deals only with configuration and packaging).Maybe Jess is right and a ServletFilter is not that bad, grmbl :-)I've already implemented an initial version. It's not ideal, but it's enough for me to play around:



TC70x_1390896_compression_filter.patch
Description: Binary data
Your feedback is highly appreciated!Best regards,FlorianAm 30.09.2012 um 10:42 schrieb Konstantin Kolinko:2012/9/29 Florian Fray :Dear TC Devs,while looking around in TC 7 I've found no possibility to plug-in a custom compression filter.So I've had a quick look at the code to find out that the gzip-handling is coded into AbstractHttp11Processor.Only HTTP protocol management is performed by AbstractHttp11Processor. The gzip support is just an org.apache.coyote.http11.OutputFilter.Though I could create a custom processor, I'd like to know whether there's any interest in having the standard processors supporting custom compressions.There might be an interest,but until it is really requested by someone, and someone takes thetime to implement it (aka scratch their own itch), very little can bedone.  Do you care to explain what "custom" compressions do you need?Can you propose a patch?If you need help to understand Tomcat code / writing a patch, just askon this list.2012/9/30 Jess Holle :It is quite possible to write a custom compression filter as a servletfilter that will work across multiple servlet engines.+1.There is a sample gzip filter in the examples webapp(compressionFilters.CompressionFilter).There exists a gzip filter in the Ehcache project.It is likely that there are others as well.Best regards,Konstantin Kolinko-To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.orgFor additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Custom compression filters

2012-09-30 Thread Konstantin Kolinko 
2012/9/30 Florian Fray :
> Thanks for your reply, Konstantin and Jess.
> The main reason for adding this feature to the Container is the same as for
> all features provided by a Container:
> My applications should not deal with these details.
>
> Currently I'm looking at adding Googles Snappy to some servers.
> I could add filters to my applications, but if possible, I'd like to get
> around this, as I'd have to do it to a bunch of applications,
> partially running on the same Tomcat or JBoss instances.
>
> I'm currently thinking about which way to go.
> Patching Tomcat was not that hard and it was fun anyway.
> Maintaining a custom Tomcat codeline is something I'd like to avoid (I've
> already got a customized installation, but this deals only with
> configuration and packaging).
> Maybe Jess is right and a ServletFilter is not that bad, grmbl :-)
>
> I've already implemented an initial version. It's not ideal, but it's enough
> for me to play around:
>
>
> Your feedback is highly appreciated!
>
> Best regards,
>
> Florian
>
> Am 30.09.2012 um 10:42 schrieb Konstantin Kolinko:
>
> 2012/9/29 Florian Fray :
>
> Dear TC Devs,
>
>
> while looking around in TC 7 I've found no possibility to plug-in a custom
> compression filter.
>
>
> So I've had a quick look at the code to find out that the gzip-handling is
> coded into AbstractHttp11Processor.
>
>
> Only HTTP protocol management is performed by AbstractHttp11Processor.
> The gzip support is just an org.apache.coyote.http11.OutputFilter.
>
> Though I could create a custom processor, I'd like to know whether there's
> any interest in having the standard processors supporting custom
> compressions.
>
>
>
> There might be an interest,
> but until it is really requested by someone, and someone takes the
> time to implement it (aka scratch their own itch), very little can be
> done.  Do you care to explain what "custom" compressions do you need?
> Can you propose a patch?
>
> If you need help to understand Tomcat code / writing a patch, just ask
> on this list.
>
>
> 2012/9/30 Jess Holle :
>
> It is quite possible to write a custom compression filter as a servlet
>
> filter that will work across multiple servlet engines.
>
>
>
> +1.
>
> There is a sample gzip filter in the examples webapp
> (compressionFilters.CompressionFilter).
>
> There exists a gzip filter in the Ehcache project.
>
> It is likely that there are others as well.
>

1. Please do not top-post
http://en.wikipedia.org/wiki/Posting_style#Choosing_the_proper_posting_style

2. Do not use HTML formatting
3. The proper way to submit patches is through Bugzilla.  Attachments
on this mailing list are usually stripped by the mail server.   (I
received yours, but that looks like an exception).


The patch looks interesting.

Just noting, that there is certainly an error in it. In findCompressionFilter():

a)
 // If force mode, always compress (test purposes only)
 if (compressionLevel == 2) {
-return true;
+return null;
 }

b)
 if (noCompressionUserAgents != null &&

noCompressionUserAgents.matcher(userAgentValue).matches()) {
-return false;
+return null;
 }

You cannot replace both "true" and "false" results with null.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53936] Minimize classloader leaks from stacktrace elements in long-lived Exceptions

2012-09-30 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=53936

--- Comment #2 from Konstantin Kolinko  ---
(In reply to comment #0)
> The attached test code contains two versions of the algorithm, for Java 1.6
> and 1.7.

1. It is a bit hard to see, but looks that

1.6 version is "containerOnlyFill(Throwable)"
1.7 version is "bootclassLoaderOnlyFill(Throwable)"

Why are you using Throwable[]? It would make sense if you were returning a
different value than passing it, but you are not.  Just a simple

  public static void containerOnlyFill(final Throwable throwable) {
try {
  Runnable target = new Runnable() {
@Override public void run() {
  throwable.fillInStackTrace();
}
  };
(...)
  }

would suffice.


2. What is the intended use of this code?

In those several cases when Tomcat creates and holds an exception, we already
solved the issue by implementing the fillInStackTrace() method as a NOOP.

See e.g. o.a.naming.resources.ImmutableNameNotFoundException.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53936] Minimize classloader leaks from stacktrace elements in long-lived Exceptions

2012-09-30 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=53936

--- Comment #3 from Timo Kinnunen  ---
1) Yes, this is correct. containerOnlyFill(Throwable) is a straight-up Java 1.6
port of the Java 1.7 bootclassLoaderOnlyFill(Throwable) method. 

The 1.6 version could be simplified for production use in Tomcat. Please note,
however, that the same simplification couldn't be applied to the 1.7 version,
because the classes created by java.lang.invoke.MethodHandles can remain in
memory for a long time. An array is used to prevent these classes from holding
a direct reference to the Throwable and keeping it and its ClassLoader from
being garbage-collected.

2) The intended use of this code is for the WebappClassLoader to clean up
Exceptions that are created and held by third-party libraries included in a
webapp when the webapp is unloaded. 

The 1.7 version is also intended to be usable from user code when the developer
of the webapp is aware of one of their libraries having this issue. In this
case the developer can use reflection to get the Exception object held by a
library and call bootclassLoaderOnlyFill(Throwable) on it during
initialization.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1392098 - in /tomcat/trunk/java/org/apache/naming/resources: BaseDirContext.java FileDirContext.java WARDirContext.java

2012-09-30 Thread markt 
Author: markt
Date: Sun Sep 30 19:45:00 2012
New Revision: 1392098

URL: http://svn.apache.org/viewvc?rev=1392098&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53854
Get directory listings working with aliases

Modified:
tomcat/trunk/java/org/apache/naming/resources/BaseDirContext.java
tomcat/trunk/java/org/apache/naming/resources/FileDirContext.java
tomcat/trunk/java/org/apache/naming/resources/WARDirContext.java

Modified: tomcat/trunk/java/org/apache/naming/resources/BaseDirContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/resources/BaseDirContext.java?rev=1392098&r1=1392097&r2=1392098&view=diff
==
--- tomcat/trunk/java/org/apache/naming/resources/BaseDirContext.java (original)
+++ tomcat/trunk/java/org/apache/naming/resources/BaseDirContext.java Sun Sep 
30 19:45:00 2012
@@ -48,6 +48,7 @@ import javax.naming.directory.SearchResu
 
 import org.apache.naming.NameParserImpl;
 import org.apache.naming.NamingContextBindingsEnumeration;
+import org.apache.naming.NamingContextEnumeration;
 import org.apache.naming.NamingEntry;
 import org.apache.naming.StringManager;
 
@@ -651,7 +652,7 @@ public abstract class BaseDirContext imp
  * @exception NamingException if a naming exception is encountered
  */
 @Override
-public NamingEnumeration list(Name name)
+public final NamingEnumeration list(Name name)
 throws NamingException {
 return list(name.toString());
 }
@@ -667,8 +668,44 @@ public abstract class BaseDirContext imp
  * @exception NamingException if a naming exception is encountered
  */
 @Override
-public abstract NamingEnumeration list(String name)
-throws NamingException;
+public final NamingEnumeration list(String name)
+throws NamingException {
+
+if (!aliases.isEmpty()) {
+AliasResult result = findAlias(name);
+if (result.dirContext != null) {
+return result.dirContext.list(result.aliasName);
+}
+}
+
+// Next do a standard lookup
+List bindings = doListBindings(name);
+
+// Check the alternate locations
+List altBindings = null;
+
+for (DirContext altDirContext : altDirContexts) {
+if (altDirContext instanceof BaseDirContext) {
+altBindings = ((BaseDirContext) altDirContext).doListBindings(
+"/META-INF/resources" + name);
+}
+if (altBindings != null) {
+if (bindings == null) {
+bindings = altBindings;
+} else {
+bindings.addAll(altBindings);
+}
+}
+}
+
+if (bindings != null) {
+return new NamingContextEnumeration(bindings.iterator());
+}
+
+// Really not found
+throw new NameNotFoundException(
+sm.getString("resources.notFound", name));
+}
 
 
 /**

Modified: tomcat/trunk/java/org/apache/naming/resources/FileDirContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/resources/FileDirContext.java?rev=1392098&r1=1392097&r2=1392098&view=diff
==
--- tomcat/trunk/java/org/apache/naming/resources/FileDirContext.java (original)
+++ tomcat/trunk/java/org/apache/naming/resources/FileDirContext.java Sun Sep 
30 19:45:00 2012
@@ -30,7 +30,6 @@ import java.util.Hashtable;
 import java.util.List;
 
 import javax.naming.NameAlreadyBoundException;
-import javax.naming.NameClassPair;
 import javax.naming.NameNotFoundException;
 import javax.naming.NamingEnumeration;
 import javax.naming.NamingException;
@@ -41,7 +40,6 @@ import javax.naming.directory.Modificati
 import javax.naming.directory.SearchControls;
 import javax.naming.directory.SearchResult;
 
-import org.apache.naming.NamingContextEnumeration;
 import org.apache.naming.NamingEntry;
 import org.apache.tomcat.util.http.RequestUtil;
 
@@ -279,34 +277,6 @@ public class FileDirContext extends Base
 
 
 /**
- * Enumerates the names bound in the named context, along with the class
- * names of objects bound to them. The contents of any subcontexts are
- * not included.
- * 
- * If a binding is added to or removed from this context, its effect on
- * an enumeration previously returned is undefined.
- *
- * @param name the name of the context to list
- * @return an enumeration of the names and class names of the bindings in
- * this context. Each element of the enumeration is of type NameClassPair.
- * @exception NamingException if a naming exception is encountered
- */
-@Override
-public NamingEnumeration list(String name)
-throws NamingException {
-
-File file = file(name);
-
-if (file == null)
-

svn commit: r1392099 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/naming/resources/BaseDirContext.java java/org/apache/naming/resources/FileDirContext.java java/org/apache/naming/resources/WARDirCon

2012-09-30 Thread markt 
Author: markt
Date: Sun Sep 30 19:48:36 2012
New Revision: 1392099

URL: http://svn.apache.org/viewvc?rev=1392099&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53854
Get directory listings working with aliases

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/BaseDirContext.java
tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/FileDirContext.java
tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/WARDirContext.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1392098

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/BaseDirContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/BaseDirContext.java?rev=1392099&r1=1392098&r2=1392099&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/BaseDirContext.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/BaseDirContext.java 
Sun Sep 30 19:48:36 2012
@@ -48,6 +48,7 @@ import javax.naming.directory.SearchResu
 
 import org.apache.naming.NameParserImpl;
 import org.apache.naming.NamingContextBindingsEnumeration;
+import org.apache.naming.NamingContextEnumeration;
 import org.apache.naming.NamingEntry;
 import org.apache.naming.StringManager;
 
@@ -658,7 +659,7 @@ public abstract class BaseDirContext imp
  * @exception NamingException if a naming exception is encountered
  */
 @Override
-public NamingEnumeration list(Name name)
+public final NamingEnumeration list(Name name)
 throws NamingException {
 return list(name.toString());
 }
@@ -674,8 +675,44 @@ public abstract class BaseDirContext imp
  * @exception NamingException if a naming exception is encountered
  */
 @Override
-public abstract NamingEnumeration list(String name)
-throws NamingException;
+public final NamingEnumeration list(String name)
+throws NamingException {
+
+if (!aliases.isEmpty()) {
+AliasResult result = findAlias(name);
+if (result.dirContext != null) {
+return result.dirContext.list(result.aliasName);
+}
+}
+
+// Next do a standard lookup
+List bindings = doListBindings(name);
+
+// Check the alternate locations
+List altBindings = null;
+
+for (DirContext altDirContext : altDirContexts) {
+if (altDirContext instanceof BaseDirContext) {
+altBindings = ((BaseDirContext) altDirContext).doListBindings(
+"/META-INF/resources" + name);
+}
+if (altBindings != null) {
+if (bindings == null) {
+bindings = altBindings;
+} else {
+bindings.addAll(altBindings);
+}
+}
+}
+
+if (bindings != null) {
+return new NamingContextEnumeration(bindings.iterator());
+}
+
+// Really not found
+throw new NameNotFoundException(
+sm.getString("resources.notFound", name));
+}
 
 
 /**

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/FileDirContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/FileDirContext.java?rev=1392099&r1=1392098&r2=1392099&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/FileDirContext.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/FileDirContext.java 
Sun Sep 30 19:48:36 2012
@@ -30,7 +30,6 @@ import java.util.Hashtable;
 import java.util.List;
 
 import javax.naming.NameAlreadyBoundException;
-import javax.naming.NameClassPair;
 import javax.naming.NameNotFoundException;
 import javax.naming.NamingEnumeration;
 import javax.naming.NamingException;
@@ -41,7 +40,6 @@ import javax.naming.directory.Modificati
 import javax.naming.directory.SearchControls;
 import javax.naming.directory.SearchResult;
 
-import org.apache.naming.NamingContextEnumeration;
 import org.apache.naming.NamingEntry;
 import org.apache.tomcat.util.http.RequestUtil;
 
@@ -279,34 +277,6 @@ public class FileDirContext extends Base
 
 
 /**
- * Enumerates the names bound in the named context, along with the class
- * names of objects bound to them. The contents of any subcontexts are
- * not included.
- * 
- * If a binding is added to or removed from this context, its effect on
- * an enumeration previously returned is undefined.
- *
- * @param name the name of the context to list
- * @return an enumeration of the names and class names of the bindings in
-

[Bug 53854] DefaultServlet directory listings for aliased directories do not seem to work

2012-09-30 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=53854

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Mark Thomas  ---
This has been fixed in trunk and 7.0.x and will be included in 7.0.31 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53917] @PostConstruct in base class never called - only works if it's declared the derived web service class (JAX-WS/Catalina)

2012-09-30 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=53917

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID
 OS||All

--- Comment #1 from Mark Thomas  ---
Tomcat does not implement the JAX-WS specification and therefore does not
inject into service endpoints or handlers. The bug is likely in whatever JAX-WS
implementation is being used.

I have traced the call stacks in Tomcat and confirmed it only injects into
those classes listed under the Servlet and JSP specs in Table EE.5-1 of the
J2EE 5 spec.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: FormAuthenticatorTest for cases without cookies - implementation issues

2012-09-30 Thread Konstantin Kolinko 
2012/9/26 Brian Burch :
> Thanks for all the help while I was developing the new test case for
> https://issues.apache.org/bugzilla/show_bug.cgi?id=53584. The thread on the
> users mailing list is called "AuthenticatorBase
> setChangeSessionIdOnAuthentication without cookies".
>
> I now have two new test cases working successfully against a
> recently-updated trunk. I hope to use them in future as boilerplates, to
> expand the set of tests, and also to examine SSO behaviour.
>
> Before I open a bugzilla enhancement request and submit my patch files, I
> would like to discuss my implementation decisions in general, to ensure that
> my effort, and other developer's time, isn't wasted.
>
> I found it necessary to modify both
> org.apache.catalina.authenticator.FormAuthenticatorTest, and its parent
> class org.apache.catalina.startup.SimpleHttpClient.
>
> To save you looking it up, here is the unchanged class comment to
> SimpleHttpClient:
>
> /**
>  * Simple client for unit testing. It isn't robust, it isn't secure and
>  * should not be used as the basis for production code. Its only purpose
>  * is to do the bare minimum for the unit tests.
>  */
>
> FormAuthenticatorTest doesn't have a class-level comment at all, but I have
> written a new one based on the conclusions in my thread on the users list.
>
> I would have preferred to make fairly localised changes to both of these
> classes, but the existing logic seems to incorporate some fundamental
> assumptions that made my intention too difficult to implement.
>
> I am not at all proud of my code, but I believe it a) works, b) is fairly
> harmonious with the existing design, and c) is amenable to the extensions I
> intend to add in due course.
>
> Firstly, I've written several small blocks of parser logic for urls and http
> headers, which are specific to the test environment and not very pretty. I
> looked for suitable parsers to re-use in the various tomcat utils packages,
> but haven't found them yet, even though tomcat MUST be doing similar work in
> an elegant and robust manner. I haven't found any unit tests, either.
>
> Then, I looked at the apache HttpClient project. An ideal solution would
> have been to use the parsers from that project, or perhaps even the entire
> client. This would have required starting with a blank sheet of paper, and I
> am very reluctant to take that approach. I might have been swayed if I had
> found HttpClient already in use by other tomcat unit tests, but I couldn't
> find it in the dependencies and didn't want to add a new one.
>
> Next,  the current version only supports cookies, so I had to add some extra
> boolean arguments to control the use of server and client cookies in each
> test case. In my professional work, I would have use singleton inner classes
> to achieve type-safety and make these crucial arguments self-documenting,
> but this wouldn't be compatible with the existing style of the various
> current authenticator unit test classes. Also, I wanted to make my initial
> change as transparent as possible, so it could be reviewed (and accepted)
> with as little effort from others as possible.
>
> I didn't want to touch SimpleHttpClient at all, but that turned out to be
> unavoidable. This class does most of the http header processing, and so it
> seemed ugly to split this work between the two classes. On the other hand,
> all the url handling is done by FormAuthenticatorTest, so it felt ugly to
> start doing any of that work in SimpleHttpClient. The consequence is that
> the two classes need to be cross-wired to some extent. This was always the
> case, but I had to cross some more wires for the new test cases.
>
> So, to summarise: I would like to make quite a bulky change to these two
> classes. I am somewhat embarrassed by my ugly style and DIY approach to
> parsing. Many of the line-changes in the patch are trivial, but a lot of
> lines will be hit at once. I haven't gone mad with comments, but have tried
> to add useful tips when an existing section of uncommented code didn't make
> sense to me. On the other hand, to maintain similar look'n'feel, I haven't
> been heavy-handed with comments in my new code. Of course, I will make sure
> it passes checkstyle before I actually cut the patches!
>
> To put things in perspective, the tests only demonstrate that Mark's fix
> works - and that wasn't even in question. However, I'd like to get my change
> committed soon, so that I can move forward with additional test cases.
>
> What do you think? Should I publish and be damned, or would you like me to
> do more work to eliminate some of my compromises?
>

1. If you a set of changes (a, b, c) and you cannot separate them into
distinct patches,  I would prefer to see (a), (a+b) and (a+b+c).

Seeing (a+b+c) is usually also good enough if you can explain the
changes such that a committer would be able to separate them.


2. Why do you need sophisticated header parsing in SimpleHttpClient?

The server side for this clie

Re: FormAuthenticatorTest for cases without cookies - implementation issues

2012-09-30 Thread Brian Burch 

On 30/09/12 21:56, Konstantin Kolinko wrote:

2012/9/26 Brian Burch :

Thanks for all the help while I was developing the new test case for
https://issues.apache.org/bugzilla/show_bug.cgi?id=53584. The thread on the
users mailing list is called "AuthenticatorBase
setChangeSessionIdOnAuthentication without cookies".

I now have two new test cases working successfully against a
recently-updated trunk. I hope to use them in future as boilerplates, to
expand the set of tests, and also to examine SSO behaviour.

Before I open a bugzilla enhancement request and submit my patch files, I
would like to discuss my implementation decisions in general, to ensure that
my effort, and other developer's time, isn't wasted.

I found it necessary to modify both
org.apache.catalina.authenticator.FormAuthenticatorTest, and its parent
class org.apache.catalina.startup.SimpleHttpClient.

To save you looking it up, here is the unchanged class comment to
SimpleHttpClient:

/**
  * Simple client for unit testing. It isn't robust, it isn't secure and
  * should not be used as the basis for production code. Its only purpose
  * is to do the bare minimum for the unit tests.
  */

FormAuthenticatorTest doesn't have a class-level comment at all, but I have
written a new one based on the conclusions in my thread on the users list.

I would have preferred to make fairly localised changes to both of these
classes, but the existing logic seems to incorporate some fundamental
assumptions that made my intention too difficult to implement.

I am not at all proud of my code, but I believe it a) works, b) is fairly
harmonious with the existing design, and c) is amenable to the extensions I
intend to add in due course.

Firstly, I've written several small blocks of parser logic for urls and http
headers, which are specific to the test environment and not very pretty. I
looked for suitable parsers to re-use in the various tomcat utils packages,
but haven't found them yet, even though tomcat MUST be doing similar work in
an elegant and robust manner. I haven't found any unit tests, either.

Then, I looked at the apache HttpClient project. An ideal solution would
have been to use the parsers from that project, or perhaps even the entire
client. This would have required starting with a blank sheet of paper, and I
am very reluctant to take that approach. I might have been swayed if I had
found HttpClient already in use by other tomcat unit tests, but I couldn't
find it in the dependencies and didn't want to add a new one.

Next,  the current version only supports cookies, so I had to add some extra
boolean arguments to control the use of server and client cookies in each
test case. In my professional work, I would have use singleton inner classes
to achieve type-safety and make these crucial arguments self-documenting,
but this wouldn't be compatible with the existing style of the various
current authenticator unit test classes. Also, I wanted to make my initial
change as transparent as possible, so it could be reviewed (and accepted)
with as little effort from others as possible.

I didn't want to touch SimpleHttpClient at all, but that turned out to be
unavoidable. This class does most of the http header processing, and so it
seemed ugly to split this work between the two classes. On the other hand,
all the url handling is done by FormAuthenticatorTest, so it felt ugly to
start doing any of that work in SimpleHttpClient. The consequence is that
the two classes need to be cross-wired to some extent. This was always the
case, but I had to cross some more wires for the new test cases.

So, to summarise: I would like to make quite a bulky change to these two
classes. I am somewhat embarrassed by my ugly style and DIY approach to
parsing. Many of the line-changes in the patch are trivial, but a lot of
lines will be hit at once. I haven't gone mad with comments, but have tried
to add useful tips when an existing section of uncommented code didn't make
sense to me. On the other hand, to maintain similar look'n'feel, I haven't
been heavy-handed with comments in my new code. Of course, I will make sure
it passes checkstyle before I actually cut the patches!

To put things in perspective, the tests only demonstrate that Mark's fix
works - and that wasn't even in question. However, I'd like to get my change
committed soon, so that I can move forward with additional test cases.

What do you think? Should I publish and be damned, or would you like me to
do more work to eliminate some of my compromises?



1. If you a set of changes (a, b, c) and you cannot separate them into
distinct patches,  I would prefer to see (a), (a+b) and (a+b+c).

Seeing (a+b+c) is usually also good enough if you can explain the
changes such that a committer would be able to separate them.


Thanks for thinking about my worries, Konstantin. I appreciate you 
spending time analysing what must appear to be a peripheral issue.


In fact, when I didn't receive a quick reaction, I started

CMS or svnpubsub for Site

2012-09-30 Thread Olivier Lamy 
Hi Folks,
I wonder what is the plan for CMS or svnpubsub for the web site ?

-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53936] Minimize classloader leaks from stacktrace elements in long-lived Exceptions

2012-09-30 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=53936

Konstantin Kolinko  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #4 from Konstantin Kolinko  ---
> MemoryLeakProtection in the Tomcat wiki says: "Sun bug 6916498 - An
> exception can keep a classloader in memory if the stack trace that was
> recorded when it was created contains a reference to one of its classes."

(In reply to comment #3)
> The intended use of this code is for the WebappClassLoader to clean up
> Exceptions that are created and held by third-party libraries included in a
> webapp when the webapp is unloaded. 
> 

For reference:

http://wiki.apache.org/tomcat/MemoryLeakProtection
https://issues.apache.org/bugzilla/show_bug.cgi?id=50460

1. First, I think that there will not be a leak in your scenario.

Tomcat already has code to clear static fields in classes that belong to a web
application.  Note though that it is possible only because those classes are
loaded through Tomcat's own WebappClassLoader class. It holds references to all
classes that it loaded.


The scenario where I observed this memory leak issue was different. See bug
50460 for details. The Exception instance was being hold by a shared library,
not by webapp one:

1) A webapp does its first call to a shared library or to Tomcat server code.
2) A class from the shared library is loaded and creates an Exception instance.
3) That exception holds reference to the calling webapp class.


2. If a library caches an Exception instance and has such a leak, it is a bug
in that library. It is up to the authors of that library to fix their bug, e.g.
by implementing fillInStackTrace() as a NOOP, like we did in
ImmutableNameNotFoundException.

3. Each "class scanning" solution takes noticeable time, because usually there
are a lot of classes. It is not worth here.

If there is no way to fix a library, one could implement a "targeted" solution:
write a listener to perform cleanup in their specific case.

4. If the leak occurs in a shared library, I see no sane way to enumerate
loaded classes (and thus to apply your solution). A good news is that there is
an alternative solution: you can preload those classes.

A list of classes to preload is already configurable on
JreMemoryLeakPreventionListener.


Thus I am closing this issue as WONTFIX.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of "MemoryLeakProtection" by KonstantinKolinko

2012-09-30 Thread Apache Wiki 
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "MemoryLeakProtection" page has been changed by KonstantinKolinko:
http://wiki.apache.org/tomcat/MemoryLeakProtection?action=diff&rev1=15&rev2=16

Comment:
Add reference to BZ 53936 that proposes a workaround for classloader leaks 
caused by long-lived Exceptions

  Related issues
   * <>[[https://issues.apache.org/bugzilla/show_bug.cgi?id= 
49159|49159]] - Improve ThreadLocal memory leak clean-up
   * [[http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4957990|Sun bug 
4957990]] - In some cases the Server JVM fails to collect classloaders. 
According to [[http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4957990|this 
page]] it should have been fixed with java 6u16 but actually it was not. It 
seems to be fixed with 6u21 (documented 
[[http://download.java.net/jdk6/6u21/promoted/b03/changes/JDK6u21.list.html|here]]
 and verified by the author of this wiki page).
-  * [[http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6916498|Sun bug 
6916498]] - An exception can keep a classloader in memory if the stack trace 
that was recorded when it was created contains a reference to one of its 
classes. Some fixes have been made in tomcat (see 
[[https://issues.apache.org/bugzilla/show_bug.cgi?id=50460|BZ 50460]]), but 
some library or JRE code may still create a leak that is undetected by tools 
because of this JVM bug.
+  * [[http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6916498|Sun bug 
6916498]] - An exception can keep a classloader in memory if the stack trace 
that was recorded when it was created contains a reference to one of its 
classes. Fixes were done in Tomcat for its own classes that had this issue (see 
[[https://issues.apache.org/bugzilla/show_bug.cgi?id=50460|BZ 50460]]), but 
some library or JRE code may still create a leak that is undetected by tools 
because of this JVM bug. See also 
[[https://issues.apache.org/bugzilla/show_bug.cgi?id=53936|BZ 53936]] for a 
workaround that you can implement if you are unable to fix a buggy library.
  
  
  [[CategoryFAQ]]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: CMS or svnpubsub for Site

2012-09-30 Thread Konstantin Kolinko 
2012/10/1 Olivier Lamy :
> Hi Folks,
> I wonder what is the plan for CMS or svnpubsub for the web site ?

The plan is to use svnpubsub.

The whole site is already in svn, except for subprojects that rely on Maven:

1. Taglibs
2. Maven Plugin


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of "Attorney at law Search Engine Marketing" by StephanyMay

2012-09-30 Thread Apache Wiki 
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "Attorney at law Search Engine Marketing" page has been changed by 
StephanyMay:
http://wiki.apache.org/tomcat/Attorney%20at%20law%20Search%20Engine%20Marketing

New page:
Whichever company is going on line simply to take pleasure in what are the 
online can bring is without a doubt performing it all wrong. The web is full of 
lots of chances to earn a living. It will in reality be perfectly fine to 
mention that people that just go online for that fun of it are increasingly 
being foolish sufficient to neglect the cash register pings which the 
world-wide-web can certainly lure in. The web is more than only a venue to get 
chattering, browsing through websites, taking part in on-line games and the 
majority of coming from all, reviewing e-mails. There are plenty of business 
along with fiscal programs on the internet you can't forget about.

They've got a strong idea of the way the Road directions algorithm criteria 
operates plus the elements helpful to identify rankings connected with a 
facility bookings. Next to your skin a few methods right up their sleeves that 
can help present you with obtain a aggressive edge. They could give your 
company an enhancement inside the Maps search rankings along with assist you on 
how wise to shore up your current ranks as time passes. Local Search Engine 
Optimization is an important strategy with regard to cyberspace businesses 
aiming to achieve the people. If you're looking to sell your products or 
services along with services to the market, with a precise geographic vicinity, 
you will need neighborhood SEO to attract prospective buyers to your web page. 
[[http://www.semp.com/|search engine marketing agency]]

One important factor essentially want to get interested in market research and 
pick the listing correctly. Do not forget that men and women might be searching 
for the same though the scrolls they insight might various. This is primarily 
because to the fact that there are several colloquialisms across the country 
and as such you ought to be hugely clever although choosing your current 
localised keywords and phrases. Localised keyphrase research will be difficult 
when compared with it may are go ahead and, but it is required for the roll-out 
of your internet-site for your company prospective.

 Your search engine advertising and marketing agencies play an important role 
for making the company modern inside internet websites as well as rewarding in 
their esteem. They may be gaining popularity reported by its reputation plus 
accomplishment out there. The experienced businesses will be in need greatly 
assist ideas of promoting a business in the web-site. The ways which might be 
utilised by many of the marketing businesses are  article submission, directory 
syndication, social media advertising, link building, etcetera. They will can a 
great deal of help your producing the actual website totally different from the 
mediocre ones. The services that will variety from- web design, cut-throat 
examination, keyword advancement along with settled search advertising.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: CMS or svnpubsub for Site

2012-09-30 Thread Olivier Lamy 
2012/10/1 Konstantin Kolinko :
> 2012/10/1 Olivier Lamy :
>> Hi Folks,
>> I wonder what is the plan for CMS or svnpubsub for the web site ?
>
> The plan is to use svnpubsub.
Ok.
>
> The whole site is already in svn, except for subprojects that rely on Maven:
>
> 1. Taglibs
> 2. Maven Plugin
What is the svn path for both ?
Recently I released a maven plugin to be able to commit maven site to
a svn location, so I can have a look at the configuration for those
projects.
Once it's done, can we go live ?

>
>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org